)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"53bb6f7d226b50810efcc353daa6de66c9093ed6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change also deprecates using domain_id and domain_name to"},{"line_number":10,"context_line":"construct request context. Eventually they should be removed from"},{"line_number":11,"context_line":"policy enforcement and context constructor. It removes from_dict"},{"line_number":12,"context_line":"method from IronicContext too, as the only two additional fields"},{"line_number":13,"context_line":"there are is_public_api and show_password, which should not come"},{"line_number":14,"context_line":"to ironic API via message bus, which is the only place where"},{"line_number":15,"context_line":"from_dict and to_dict methods are used."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I9afe89bc6aee282ee4b7579d661e3fa83cc0ce84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a061dce_8558f333","line":15,"range":{"start_line":11,"start_character":44,"end_line":15,"end_character":39},"updated":"2016-04-06 08:22:49.000000000","message":"This sounds correct, but seems too hack to me.","commit_id":"49aec97b02c2c629dbacf729d61cf6557cfa0d61"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"154e604d9d0effbb950a88fd8a3e7c41abff0079","unresolved":false,"context_lines":[{"line_number":20,"context_line":"receiving the context over RPC. It will be changed in Pike release"},{"line_number":21,"context_line":"to reuse the base oslo_context class\u0027 to_dict."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I9afe89bc6aee282ee4b7579d661e3fa83cc0ce84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"da6895a0_22afb4e4","line":23,"updated":"2016-10-20 19:49:25.000000000","message":"Does this work need a bug? It seems like a pretty sizable change, so I think we should file one.","commit_id":"c177de00b4c1994e42f02351f544b7f73882ed55"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3f66a840fb69c07998c18da6a65d3682a319f0c6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"receiving the context over RPC. It will be changed in Pike release"},{"line_number":21,"context_line":"to reuse the base oslo_context class\u0027 to_dict."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I9afe89bc6aee282ee4b7579d661e3fa83cc0ce84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"7a77a97e_e6903f98","line":23,"in_reply_to":"da6895a0_22afb4e4","updated":"2016-11-15 15:39:41.000000000","message":"Done","commit_id":"c177de00b4c1994e42f02351f544b7f73882ed55"}],"etc/ironic/policy.json.sample":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"550f4585eb8e4eb3de14ed272c1f2309dbfc11a9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Show or mask secrets within instance information in API responses"},{"line_number":8,"context_line":"\"show_instance_secrets\": \"!\""},{"line_number":9,"context_line":"# May be used to restrict access to specific tenants/projects"},{"line_number":10,"context_line":"\"is_member\": \"project_id:demo or project_id:baremetal\""},{"line_number":11,"context_line":"# Read-only API access"},{"line_number":12,"context_line":"\"is_observer\": \"rule:is_member and (role:observer or role:baremetal_observer)\""},{"line_number":13,"context_line":"# Full read/write API access"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"3a98d1f4_83c25983","line":10,"updated":"2016-10-03 23:01:25.000000000","message":"this doesn\u0027t look right - ids are typically uuids. At best this is name but i\u0027d not recommend enforcing on a name as a name is not unique across domains.","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9986c6505ec66742e6a3b4ed0c6280128a59bd91","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Show or mask secrets within instance information in API responses"},{"line_number":8,"context_line":"\"show_instance_secrets\": \"!\""},{"line_number":9,"context_line":"# May be used to restrict access to specific tenants/projects"},{"line_number":10,"context_line":"\"is_member\": \"project_id:demo or project_id:baremetal\""},{"line_number":11,"context_line":"# Read-only API access"},{"line_number":12,"context_line":"\"is_observer\": \"rule:is_member and (role:observer or role:baremetal_observer)\""},{"line_number":13,"context_line":"# Full read/write API access"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"3a98d1f4_35c8c954","line":10,"in_reply_to":"3a98d1f4_83c25983","updated":"2016-10-04 12:29:13.000000000","message":"Hm, this is a bit strange - right now in the context hook we have:\n\n \u0027tenant\u0027: headers.get(\u0027X-Tenant\u0027) or headers.get(\u0027X-Tenant-Id\u0027),\n\nand it works this way... But I think it\u0027s because we don\u0027t really use these rules yet, it seems we still use the old admin_api rule. In oslo context, tenant is either X-Project-Id or X-Tenant-Id or X-Tenant. I think to be sure that it is a name, I\u0027ll add a project_name to the to_policy_values and add \u0027project_domain:default\u0027 to this rule, as it should be some sane default preferably without having to write uuids here. Does it make sense?","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"}],"ironic/api/hooks.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3fd43545f8776fde4ce001506c203ee64082e54c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        is_public_api \u003d state.request.environ.get(\u0027is_public_api\u0027, False)"},{"line_number":87,"context_line":"        show_password \u003d policy.enforce(\u0027show_password\u0027, creds, creds)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # TODO(vdrok): remove completely after deprecation period"},{"line_number":90,"context_line":"        creds.pop(\u0027domain_id\u0027)"},{"line_number":91,"context_line":"        creds.pop(\u0027domain_name\u0027)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_488d9d7a","line":89,"updated":"2016-04-08 23:19:56.000000000","message":"Should we add in what exactly release it is going to be removed?","commit_id":"49aec97b02c2c629dbacf729d61cf6557cfa0d61"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0643b7bcff96d97d00e057a5abf4dc6d86301206","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        substitution_dict \u003d {"},{"line_number":39,"context_line":"            \u0027user\u0027: \u0027user_id\u0027,"},{"line_number":40,"context_line":"            \u0027domain_id\u0027: \u0027user_domain\u0027,"},{"line_number":41,"context_line":"            \u0027domain_name\u0027: \u0027user_domain (user_domain value is a domain \u0027"},{"line_number":42,"context_line":"                           \u0027ID, not name, the check has to be updated \u0027"},{"line_number":43,"context_line":"                           \u0027accordingly)\u0027,"},{"line_number":44,"context_line":"            \u0027tenant\u0027: \u0027project_id\u0027,"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":"        policy_rules \u003d enforcer.file_rules.values()"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_5082eac8","line":43,"range":{"start_line":41,"start_character":40,"end_line":43,"end_character":40},"updated":"2016-10-03 15:19:08.000000000","message":"This message is not translated, maybe better remove it or add separately.","commit_id":"b8f05fe471b801d204814b25216f04a269d6686a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aa7cf685662502c794137b746732611374efc444","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        substitution_dict \u003d {"},{"line_number":39,"context_line":"            \u0027user\u0027: \u0027user_id\u0027,"},{"line_number":40,"context_line":"            \u0027domain_id\u0027: \u0027user_domain\u0027,"},{"line_number":41,"context_line":"            \u0027domain_name\u0027: \u0027user_domain (user_domain value is a domain \u0027"},{"line_number":42,"context_line":"                           \u0027ID, not name, the check has to be updated \u0027"},{"line_number":43,"context_line":"                           \u0027accordingly)\u0027,"},{"line_number":44,"context_line":"            \u0027tenant\u0027: \u0027project_id\u0027,"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":"        policy_rules \u003d enforcer.file_rules.values()"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_8043416b","line":43,"range":{"start_line":41,"start_character":40,"end_line":43,"end_character":40},"in_reply_to":"3a98d1f4_5082eac8","updated":"2016-10-03 15:32:24.000000000","message":"Done","commit_id":"b8f05fe471b801d204814b25216f04a269d6686a"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7b0e55a60ca92f7f0e77725c1e65027396873713","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        for rule in policy_rules:"},{"line_number":48,"context_line":"            str_rule \u003d six.text_type(rule)"},{"line_number":49,"context_line":"            for deprecated, replacement in substitution_dict.items():"},{"line_number":50,"context_line":"                if re.match(r\u0027.*\\b%s\\b\u0027 % deprecated, str_rule):"},{"line_number":51,"context_line":"                    LOG.warning(_LW("},{"line_number":52,"context_line":"                        \"Deprecated argument %(deprecated)s is used in policy \""},{"line_number":53,"context_line":"                        \"file rule (%(rule)s), please use %(replacement)s \""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a95cdbc_8e2ef589","line":50,"updated":"2016-10-10 18:57:02.000000000","message":"nit: remove \u0027.*\u0027 and use re.search()","commit_id":"c177de00b4c1994e42f02351f544b7f73882ed55"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3f66a840fb69c07998c18da6a65d3682a319f0c6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        for rule in policy_rules:"},{"line_number":48,"context_line":"            str_rule \u003d six.text_type(rule)"},{"line_number":49,"context_line":"            for deprecated, replacement in substitution_dict.items():"},{"line_number":50,"context_line":"                if re.match(r\u0027.*\\b%s\\b\u0027 % deprecated, str_rule):"},{"line_number":51,"context_line":"                    LOG.warning(_LW("},{"line_number":52,"context_line":"                        \"Deprecated argument %(deprecated)s is used in policy \""},{"line_number":53,"context_line":"                        \"file rule (%(rule)s), please use %(replacement)s \""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a77a97e_86814b4d","line":50,"in_reply_to":"1a95cdbc_8e2ef589","updated":"2016-11-15 15:39:41.000000000","message":"Done","commit_id":"c177de00b4c1994e42f02351f544b7f73882ed55"}],"ironic/common/context.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"3055f4a8ca69f9741cd57be3896f7183074471b3","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @classmethod"},{"line_number":70,"context_line":"    def from_dict(cls, values):"},{"line_number":71,"context_line":"        values.pop(\u0027user\u0027, None)"},{"line_number":72,"context_line":"        values.pop(\u0027tenant\u0027, None)"},{"line_number":73,"context_line":"        return cls(**values)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_6e371e4d","side":"PARENT","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":32},"updated":"2016-04-01 07:15:57.000000000","message":"could you elaborate on this, looks like now it passed to context.","commit_id":"fcf98a75bc15a75a0c7c7e7b504cc5d5cd38455e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"20e823c7fb7522a346abfe748b7364ec4ea61985","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @classmethod"},{"line_number":70,"context_line":"    def from_dict(cls, values):"},{"line_number":71,"context_line":"        values.pop(\u0027user\u0027, None)"},{"line_number":72,"context_line":"        values.pop(\u0027tenant\u0027, None)"},{"line_number":73,"context_line":"        return cls(**values)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_d31bf57e","side":"PARENT","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":32},"in_reply_to":"ba0121b8_6e371e4d","updated":"2016-04-05 16:51:14.000000000","message":"It is, it was added when oslo.messaginig was adopted in ironic, and I don\u0027t know the reasoning behind this, but it seems to work fine now, and I don\u0027t know why should we exclude user and tenant. Maybe back then oslo.context was different.","commit_id":"fcf98a75bc15a75a0c7c7e7b504cc5d5cd38455e"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"3c56b2b44f2bebfde3363f469a0d27958d06ad65","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                 read_only\u003dFalse, show_deleted\u003dFalse, request_id\u003dNone,"},{"line_number":31,"context_line":"                 roles\u003dNone, show_password\u003dTrue, resource_uuid\u003dNone,"},{"line_number":32,"context_line":"                 overwrite\u003dTrue, user_domain\u003dNone, project_domain\u003dNone,"},{"line_number":33,"context_line":"                 domain\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"Stores several additional request parameters:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :param domain_id: The ID of the domain."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_6fcc3989","line":33,"updated":"2016-04-01 08:22:27.000000000","message":"A simple idea to avoid using inspect and improve the readability.\ndomain\u003dNone, **kwargs):\n\nif kwargs:\n   Log.warning(_LW(\u0027Extra parameters are dropped: %s\u0027), six.text_type(kwargs))","commit_id":"b2dd5e933aae17155572e5887d0f7ef0ee4ff972"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"20e823c7fb7522a346abfe748b7364ec4ea61985","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                 read_only\u003dFalse, show_deleted\u003dFalse, request_id\u003dNone,"},{"line_number":31,"context_line":"                 roles\u003dNone, show_password\u003dTrue, resource_uuid\u003dNone,"},{"line_number":32,"context_line":"                 overwrite\u003dTrue, user_domain\u003dNone, project_domain\u003dNone,"},{"line_number":33,"context_line":"                 domain\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"Stores several additional request parameters:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        :param domain_id: The ID of the domain."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_ce3a2c98","line":33,"in_reply_to":"ba0121b8_6fcc3989","updated":"2016-04-05 16:51:14.000000000","message":"This could be done, but it is not the way it is done right now in ironic or oslo, so I\u0027d prefer to leave this as is.","commit_id":"b2dd5e933aae17155572e5887d0f7ef0ee4ff972"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"55b5388dc5215c314a6cf83a8c1d4badd61defc9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        :param roles: List of user\u0027s roles if any."},{"line_number":41,"context_line":"        :param show_password: Specifies whether passwords should be masked"},{"line_number":42,"context_line":"                              before sending back to API call."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        super(RequestContext, self).__init__(auth_token\u003dauth_token,"},{"line_number":46,"context_line":"                                             user\u003duser, tenant\u003dtenant,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_65462a7c","line":43,"updated":"2016-03-31 22:00:33.000000000","message":"should add user_domain, project_domain, and domin here","commit_id":"b2dd5e933aae17155572e5887d0f7ef0ee4ff972"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"3c56b2b44f2bebfde3363f469a0d27958d06ad65","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        :param roles: List of user\u0027s roles if any."},{"line_number":41,"context_line":"        :param show_password: Specifies whether passwords should be masked"},{"line_number":42,"context_line":"                              before sending back to API call."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        super(RequestContext, self).__init__(auth_token\u003dauth_token,"},{"line_number":46,"context_line":"                                             user\u003duser, tenant\u003dtenant,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_4f57b5c9","line":43,"in_reply_to":"ba0121b8_2e1886d2","updated":"2016-04-01 08:22:27.000000000","message":"I am adding used para in my patch and it is better to add here too.","commit_id":"b2dd5e933aae17155572e5887d0f7ef0ee4ff972"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"20e823c7fb7522a346abfe748b7364ec4ea61985","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        :param roles: List of user\u0027s roles if any."},{"line_number":41,"context_line":"        :param show_password: Specifies whether passwords should be masked"},{"line_number":42,"context_line":"                              before sending back to API call."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        super(RequestContext, self).__init__(auth_token\u003dauth_token,"},{"line_number":46,"context_line":"                                             user\u003duser, tenant\u003dtenant,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_c4984d1e","line":43,"in_reply_to":"ba0121b8_4f57b5c9","updated":"2016-04-05 16:51:14.000000000","message":"Done","commit_id":"b2dd5e933aae17155572e5887d0f7ef0ee4ff972"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"3055f4a8ca69f9741cd57be3896f7183074471b3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        :param roles: List of user\u0027s roles if any."},{"line_number":41,"context_line":"        :param show_password: Specifies whether passwords should be masked"},{"line_number":42,"context_line":"                              before sending back to API call."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        super(RequestContext, self).__init__(auth_token\u003dauth_token,"},{"line_number":46,"context_line":"                                             user\u003duser, tenant\u003dtenant,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_2e1886d2","line":43,"in_reply_to":"ba0121b8_65462a7c","updated":"2016-04-01 07:15:57.000000000","message":"looks like we don\u0027t add base class args to docstring, should we?","commit_id":"b2dd5e933aae17155572e5887d0f7ef0ee4ff972"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"3c56b2b44f2bebfde3363f469a0d27958d06ad65","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                   inspect.getargspec(RequestContext.__init__).args"},{"line_number":85,"context_line":"                   if arg !\u003d \u0027self\u0027]"},{"line_number":86,"context_line":"        kwargs \u003d {k: v for (k, v) in values.items() if k in allowed}"},{"line_number":87,"context_line":"        return cls(**kwargs)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def ensure_thread_contain_context(self):"},{"line_number":90,"context_line":"        \"\"\"Ensure threading contains context"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_6fe55907","line":87,"updated":"2016-04-01 08:22:27.000000000","message":"what about just pass values but cut it during init?\nsee my comments above.","commit_id":"b2dd5e933aae17155572e5887d0f7ef0ee4ff972"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"20e823c7fb7522a346abfe748b7364ec4ea61985","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                   inspect.getargspec(RequestContext.__init__).args"},{"line_number":85,"context_line":"                   if arg !\u003d \u0027self\u0027]"},{"line_number":86,"context_line":"        kwargs \u003d {k: v for (k, v) in values.items() if k in allowed}"},{"line_number":87,"context_line":"        return cls(**kwargs)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def ensure_thread_contain_context(self):"},{"line_number":90,"context_line":"        \"\"\"Ensure threading contains context"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_8ee31433","line":87,"in_reply_to":"ba0121b8_6fe55907","updated":"2016-04-05 16:51:14.000000000","message":"I think we can get away without this method at all, using the one from base class. The 2 attributes that are specific to ironic (ofc excluding domain_id and domain_name which were added just because oslo.context did not understand domains back then) are API-specific: is_admin_api and show_password. And I believe they should not get to API via messaging bus, so can be excluded during context deserializing.","commit_id":"b2dd5e933aae17155572e5887d0f7ef0ee4ff972"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"550f4585eb8e4eb3de14ed272c1f2309dbfc11a9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_c36621ba","line":45,"updated":"2016-10-03 23:01:25.000000000","message":"I\u0027d be really careful about replacing this dict if it\u0027s being RPC-ed. user and tenant in oslo.context don\u0027t seem to be the same as here and may cause problems.\n\nAlso you probably need to handle the is_public_api in from_dict.","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d6f385ebf5dc950e2f606411ce76bf65897ac98c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_6064e721","line":45,"in_reply_to":"1a95cdbc_204bbfca","updated":"2016-10-06 12:25:03.000000000","message":"Hm, it will break anyway, as the context constructor (which will be called by from_dict) right now has a fixed args list, so passing e.g. user_domain there will break it.","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d345d58954816e1ec01ca039f08d3fb37fc1f22e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_9bcc878a","line":45,"in_reply_to":"1a95cdbc_24952632","updated":"2016-10-10 12:18:16.000000000","message":"Yup, that\u0027s what was done in the latest patch set, please have a look, thanks!","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a11a32e9208d8cba9adb1f3bb0d586ec65d39108","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_85165da5","line":45,"in_reply_to":"1a95cdbc_6064e721","updated":"2016-10-06 14:00:45.000000000","message":"So after the discussion with Jim, it seems like the way forward is:\n\n1. make the from_dict work properly now;\n2. make to_dict output both old and new values in P release;\n3. remove old cruft in Q.","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d491ce3136a03291d4b51b7168f7be662132d5fb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_81faf1bb","line":45,"in_reply_to":"1a95cdbc_64a185a9","updated":"2016-10-05 20:52:02.000000000","message":"well there is still a question of does it matter? Policy should (not sure about ironic) only be enforced at the API layer and I don\u0027t actually know where else domain is used. If it\u0027s not used and it gets picked up incorrectly elsewhere it might not matter?\n\nWhat I\u0027ve found (and did in mine) is that for now i don\u0027t mess with project\u0027s to_dict. I\u0027m hoping in future we can do a to_rpc_values() on oslo.context or something that makes all this simpler but the compat story is really difficult.","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b55c70d8448803ce9848f4bcb4c295def8eb8cb6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_7ccea35b","line":45,"in_reply_to":"1a95cdbc_766884bb","updated":"2016-10-04 20:33:00.000000000","message":"++ thanks for the fix.\n\nAs for domain_id in fact being user_domain_id, yep, this is definitely wrong, but can be used in policy, that\u0027s why I added the deprecation and a check in hooks. I think this might matter for some people but I don\u0027t have any solid opinion on that. It is indeed unlikely that someone was using it.\n\ndomain_id is not present in base oslo context so there should be no confusion of RPC. domain_name is and it indeed can bring an inconsistency. Also if api is this-commit, and conductor is pre-this-commit, context deserialization can break, as there are new parameters - user_domain_name and such. What can be done is maybe a bump here https://github.com/openstack/ironic/blob/master/ironic/conductor/rpcapi.py#L88, if it is different between api and conductor, communication won\u0027t happen properly anyway :)","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"da0184c3d251559136a4a3027c9db81e4b367167","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_64a185a9","line":45,"in_reply_to":"1a95cdbc_7ccea35b","updated":"2016-10-05 15:21:23.000000000","message":"Ignore the part of bumping RPC_API_VERSION, it won\u0027t help :( I\u0027ll try to come up with something else.","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"fc5327459f58acd30955b732540000c980fba677","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_204bbfca","line":45,"in_reply_to":"1a95cdbc_81faf1bb","updated":"2016-10-06 12:20:22.000000000","message":"What if we did:\n\n    d \u003d {old_dict...}\n    d.update(super(...))\n    return d\n\nThis will make sure the old dict is passed to Mitaka conductor services. Then in Pike we can remove the old dict keys because we know in Ocata everything was updated to use the new dict keys.\n\nSeems like it\u0027d work to me, what do you think?","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5a2a626a19744701ba5031fbfcb755231823e288","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_206e5f95","line":45,"in_reply_to":"1a95cdbc_81faf1bb","updated":"2016-10-06 12:19:14.000000000","message":"You\u0027re right, it is difficult :( I think I\u0027ll bring it up in the monday\u0027s meeting to reach a consensus whether we need fixing it or not.\n\nIt is not used on the conductor side indeed (it is the only receiver of the messages atm), but it is used for logging, and I was hoping that we can just use identity string from oslo_context itself to be consistent with other projects... OTOH we can construct it ourselves.","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"41e8992d8fda79f60bbe5897ed1de863a61fa93b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_24952632","line":45,"in_reply_to":"1a95cdbc_85165da5","updated":"2016-10-10 05:09:27.000000000","message":"The part about the constructor having fixed args list is not quite true any more. I only fixed it in the last version of oslo.context (which should be in requirements) but have a look at how base from_dict works [1], it\u0027s pretty easy to customize that behaviour from the subclass.\n\n\n[1] http://git.openstack.org/cgit/openstack/oslo.context/tree/oslo_context/context.py#n173","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"478036019b1f769d91c0479028772366c7c1b0d8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a95cdbc_766884bb","line":45,"in_reply_to":"3a98d1f4_758df1d1","updated":"2016-10-04 19:21:46.000000000","message":"yea, i have a fix for that: https://review.openstack.org/#/c/357537/\n\nin practice USER_ID and PROJECT_ID will be available and so user and tenant will be ids not names. The other thing i found when trying this is that domain_id is set where you mean user_domain_id. \n\ntypically domain_id here is where a user is scoped to a domain directly which is not something ironic would likely deal with. I\u0027m guessing the only time these are used are in policy so maybe it doesn\u0027t matter? I\u0027m just worrying about RPC with different versions getting confused.","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9986c6505ec66742e6a3b4ed0c6280128a59bd91","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return policy_values"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def to_dict(self):"},{"line_number":45,"context_line":"        d \u003d super(RequestContext, self).to_dict()"},{"line_number":46,"context_line":"        d[\u0027is_public_api\u0027] \u003d self.is_public_api"},{"line_number":47,"context_line":"        return d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_758df1d1","line":45,"in_reply_to":"3a98d1f4_c36621ba","updated":"2016-10-04 12:29:13.000000000","message":"user and tenant are almost the same, in oslo:\n\n \u0027user\u0027: [\u0027HTTP_X_USER_ID\u0027,\n          \u0027HTTP_X_USER\u0027],\n \u0027tenant\u0027: [\u0027HTTP_X_PROJECT_ID\u0027,\n            \u0027HTTP_X_TENANT_ID\u0027,\n            \u0027HTTP_X_TENANT\u0027],\n\nin ironic:\n\n \u0027user\u0027: headers.get(\u0027X-User\u0027) or headers.get(\u0027X-User-Id\u0027),\n \u0027tenant\u0027: headers.get(\u0027X-Tenant\u0027) or headers.get(\u0027X-Tenant-Id\u0027),\n\nSo the only differences are - 1) project_id is handled by oslo context too; 2) HTTP_X_USER_ID and HTTP_X_TENANT_ID have higher preference in oslo.context than HTTP_X_USER and HTTP_X_TENANT.\n\nAs for other fields, all of them were intended to be standard context values. Not sure if it\u0027s worth special handling. WDYT?\n\nYeah, is_public_api has to be handled in from_dict, will add, thanks!","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"}],"ironic/common/policy.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"550f4585eb8e4eb3de14ed272c1f2309dbfc11a9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    # Roles likely to be overriden by operator"},{"line_number":55,"context_line":"    policy.RuleDefault(\u0027is_member\u0027,"},{"line_number":56,"context_line":"                       \u0027project_id:demo or project_id:baremetal\u0027,"},{"line_number":57,"context_line":"                       description\u003d\u0027May be used to restrict access to specific tenants/projects\u0027),  # noqa"},{"line_number":58,"context_line":"    policy.RuleDefault(\u0027is_observer\u0027,"},{"line_number":59,"context_line":"                       \u0027rule:is_member and (role:observer or role:baremetal_observer)\u0027,  # noqa"},{"line_number":60,"context_line":"                       description\u003d\u0027Read-only API access\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_43113103","line":57,"range":{"start_line":57,"start_character":86,"end_line":57,"end_character":87},"updated":"2016-10-03 23:01:25.000000000","message":"just replace with projects","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9986c6505ec66742e6a3b4ed0c6280128a59bd91","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    # Roles likely to be overriden by operator"},{"line_number":55,"context_line":"    policy.RuleDefault(\u0027is_member\u0027,"},{"line_number":56,"context_line":"                       \u0027project_id:demo or project_id:baremetal\u0027,"},{"line_number":57,"context_line":"                       description\u003d\u0027May be used to restrict access to specific tenants/projects\u0027),  # noqa"},{"line_number":58,"context_line":"    policy.RuleDefault(\u0027is_observer\u0027,"},{"line_number":59,"context_line":"                       \u0027rule:is_member and (role:observer or role:baremetal_observer)\u0027,  # noqa"},{"line_number":60,"context_line":"                       description\u003d\u0027Read-only API access\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_350a8926","line":57,"range":{"start_line":57,"start_character":86,"end_line":57,"end_character":87},"in_reply_to":"3a98d1f4_43113103","updated":"2016-10-04 12:29:13.000000000","message":"Done","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8efa0551e4306b4a5ff461c0f11654e0ca4acc70","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                       description\u003d\u0027Show or mask secrets within instance information in API responses\u0027),  # noqa"},{"line_number":54,"context_line":"    # Roles likely to be overriden by operator"},{"line_number":55,"context_line":"    policy.RuleDefault(\u0027is_member\u0027,"},{"line_number":56,"context_line":"                       \u0027project_domain_id:default and (project_name:demo or project_name:baremetal)\u0027,  # noqa"},{"line_number":57,"context_line":"                       description\u003d\u0027May be used to restrict access to specific projects\u0027),  # noqa"},{"line_number":58,"context_line":"    policy.RuleDefault(\u0027is_observer\u0027,"},{"line_number":59,"context_line":"                       \u0027rule:is_member and (role:observer or role:baremetal_observer)\u0027,  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_eae757aa","line":56,"updated":"2016-10-04 15:20:06.000000000","message":"I\u0027m not sure about this place, should we include the domain here? In case of v2 there is no domain. But in the same time project names are not unique across domains as pointed out by Jamie earlier.","commit_id":"86b121f161d4e8b65ac09d7d8236c82874f396ab"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"59ccbbf01cf8730549f2a8f12ffed2a0d9db4e04","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                       description\u003d\u0027Show or mask secrets within instance information in API responses\u0027),  # noqa"},{"line_number":54,"context_line":"    # Roles likely to be overriden by operator"},{"line_number":55,"context_line":"    policy.RuleDefault(\u0027is_member\u0027,"},{"line_number":56,"context_line":"                       \u0027project_domain_id:default and (project_name:demo or project_name:baremetal)\u0027,  # noqa"},{"line_number":57,"context_line":"                       description\u003d\u0027May be used to restrict access to specific projects\u0027),  # noqa"},{"line_number":58,"context_line":"    policy.RuleDefault(\u0027is_observer\u0027,"},{"line_number":59,"context_line":"                       \u0027rule:is_member and (role:observer or role:baremetal_observer)\u0027,  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_81222cb8","line":56,"in_reply_to":"1a95cdbc_d60078ad","updated":"2016-10-04 20:12:40.000000000","message":"Yup, I think I\u0027ll add another or here, it should be either None or default.","commit_id":"86b121f161d4e8b65ac09d7d8236c82874f396ab"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"647f2a45ce7a8031378f50f2419313da2076d59b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                       description\u003d\u0027Show or mask secrets within instance information in API responses\u0027),  # noqa"},{"line_number":54,"context_line":"    # Roles likely to be overriden by operator"},{"line_number":55,"context_line":"    policy.RuleDefault(\u0027is_member\u0027,"},{"line_number":56,"context_line":"                       \u0027project_domain_id:default and (project_name:demo or project_name:baremetal)\u0027,  # noqa"},{"line_number":57,"context_line":"                       description\u003d\u0027May be used to restrict access to specific projects\u0027),  # noqa"},{"line_number":58,"context_line":"    policy.RuleDefault(\u0027is_observer\u0027,"},{"line_number":59,"context_line":"                       \u0027rule:is_member and (role:observer or role:baremetal_observer)\u0027,  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a95cdbc_d60078ad","line":56,"in_reply_to":"1a95cdbc_eae757aa","updated":"2016-10-04 19:25:07.000000000","message":"yea, this is something i\u0027ve not seen on other projects. \n\ndoes (project_domain_id:default or project_domain_id:None) work? I would expect None to be the value that came through on v2 rather than default.","commit_id":"86b121f161d4e8b65ac09d7d8236c82874f396ab"}],"ironic/common/rpc.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"550f4585eb8e4eb3de14ed272c1f2309dbfc11a9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    return ALLOWED_EXMODS + EXTRA_EXMODS"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class RequestContextSerializer(messaging.RequestContextSerializer):"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def deserialize_context(self, context):"},{"line_number":100,"context_line":"        return ironic_context.RequestContext.from_dict(context)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_43df7139","line":97,"range":{"start_line":97,"start_character":6,"end_line":97,"end_character":30},"updated":"2016-10-03 23:01:25.000000000","message":"RequestContextSerializer was deprecated in messaging. \n\nhttps://review.openstack.org/#/c/305892/","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9986c6505ec66742e6a3b4ed0c6280128a59bd91","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    return ALLOWED_EXMODS + EXTRA_EXMODS"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class RequestContextSerializer(messaging.RequestContextSerializer):"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def deserialize_context(self, context):"},{"line_number":100,"context_line":"        return ironic_context.RequestContext.from_dict(context)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a98d1f4_951a7d7b","line":97,"range":{"start_line":97,"start_character":6,"end_line":97,"end_character":30},"in_reply_to":"3a98d1f4_43df7139","updated":"2016-10-04 12:29:13.000000000","message":"OK, leaving it here then, thanks for the pointer!","commit_id":"3b546fcfedbab147f52548e4a5b4741e224af8b1"}],"ironic/tests/unit/objects/test_objects.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bc82649807b195f819175c2fccdbf31ca361d202","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                          base.IronicObject.obj_class_from_name, \u0027foo\u0027, \u00271.0\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_with_alternate_context(self):"},{"line_number":212,"context_line":"        ctxt1 \u003d context.RequestContext(auth_token\u003d\u0027foo\u0027, tenant\u003d\u0027foo\u0027)"},{"line_number":213,"context_line":"        ctxt2 \u003d context.RequestContext(auth_token\u003d\u0027bar\u0027, tenant\u003d\u0027alternate\u0027)"},{"line_number":214,"context_line":"        obj \u003d MyObj.query(ctxt1)"},{"line_number":215,"context_line":"        obj.update_test(ctxt2)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a74a57a_256323b3","line":212,"range":{"start_line":212,"start_character":57,"end_line":212,"end_character":63},"updated":"2016-11-23 12:33:36.000000000","message":"Should we be using project here instead now?","commit_id":"3eba764be3dcbafa01e1e4298bdf1810925a6f49"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aee2b247f3fa4fa3a7a90784beead103e11d214c","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                          base.IronicObject.obj_class_from_name, \u0027foo\u0027, \u00271.0\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_with_alternate_context(self):"},{"line_number":212,"context_line":"        ctxt1 \u003d context.RequestContext(auth_token\u003d\u0027foo\u0027, tenant\u003d\u0027foo\u0027)"},{"line_number":213,"context_line":"        ctxt2 \u003d context.RequestContext(auth_token\u003d\u0027bar\u0027, tenant\u003d\u0027alternate\u0027)"},{"line_number":214,"context_line":"        obj \u003d MyObj.query(ctxt1)"},{"line_number":215,"context_line":"        obj.update_test(ctxt2)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a74a57a_85db17ed","line":212,"range":{"start_line":212,"start_character":57,"end_line":212,"end_character":63},"in_reply_to":"5a74a57a_256323b3","updated":"2016-11-23 12:44:46.000000000","message":"ATM there is no project attribute on oslo side, it is either tenant or project_name. I think we should wait for at least the deprecation notice on the oslo_context side (in the comment in constructor, this spec is referred - https://review.openstack.org/#/c/290907/, which is abandoned ATM).","commit_id":"3eba764be3dcbafa01e1e4298bdf1810925a6f49"}],"releasenotes/notes/context-domain-id-name-deprecation-ae6e40718273be8d.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3fd43545f8776fde4ce001506c203ee64082e54c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - domain_id and domain_name RequestContext parameters are being deprecated,"},{"line_number":4,"context_line":"    domain, user_domain and project_domain should be used instead. They will"},{"line_number":5,"context_line":"    also be removed from policy enforcement after deprecation period."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a061dce_0848c52c","line":5,"updated":"2016-04-08 23:19:56.000000000","message":"I think that we should exactly specify deprecation release. eg: It is going to be deprecated in Ocata release.","commit_id":"49aec97b02c2c629dbacf729d61cf6557cfa0d61"}]}
