)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"148c65180645997abc595183da6b8aee7f2be417","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[amt]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa0719c6_4f93a34f","line":1,"updated":"2016-03-22 19:52:35.000000000","message":"I generally against changes that remove the sample conf files. Mainly because other projects may relay on it in there. As example see: https://github.com/openstack/bifrost/blob/master/playbooks/roles/bifrost-ironic-install/tasks/ironic_config.yml","commit_id":"0d49e46705a9f29642c5fd97be0f4ccf62bc0870"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"eb6d04806041b67dd16ff8b662c261dc7959c3c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9abb7d3a_0ea33a01","updated":"2016-05-31 21:53:34.000000000","message":"These changes are unrelated to the patch. Doing a checkout of master and generating the config file I see these changes too.\n\nSo looks good that the code change doesn\u0027t affect the config file.","commit_id":"8b8fb3782d9b567c1ab47b71fa8795ea2058c3e5"}],"ironic/conf/console.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"074300ce4b7abdf50e968ccb21bfbe98a2ebff83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# coding\u003dutf-8"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2014 International Business Machines Corporation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_9b06061f","line":1,"updated":"2016-03-24 21:00:38.000000000","message":"Delete this, unless it is needed. I don\u0027t think it is.","commit_id":"b7656aa7b62e7ae6be8f919d3ae3b83acb22d684"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0032af130d8798982d1e7196a4a9b1b9f5ccbe4e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def register_opts(conf):"},{"line_number":44,"context_line":"    conf.register_opts(opts, group\u003d\u0027console\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_8f48912e","line":43,"updated":"2016-06-14 17:47:23.000000000","message":"This is another thing - we can move this function to the ironic.conf.__init__, as all these functions differ only by name of the variable containing options and group name.\n\nso in __init__ it can be \n\n def register_opts(opts, group):\n     cfg.CONF.register_opts(opts, group)\n\nand it could be called this way:\n\n from ironic.conf import console\n\n register_opts(console.opts, \u0027console\u0027)\n\nOr we could even require all the ironic.conf.* modules to contain \"opts\" variable, then we could just pass the module name as an argument to register_opts.","commit_id":"c2d43a9f297cbb9a65ebc29614d5a854ac71195a"}],"ironic/drivers/modules/amt/common.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"44f6df09f79a5a6bd7f9542875b0e24b45e46987","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_utils import importutils"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import ironic.conf"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from ironic.common import boot_devices"},{"line_number":27,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_e6b1c702","line":24,"updated":"2016-03-23 17:44:36.000000000","message":"This needs to be in the same section of lines 26-30\n\nMight be easiest to do:\n\n from ironic.conf import CONF\n\nAnd delete the line:\n CONF \u003d ironic.conf.CONF","commit_id":"394d1553af2f8dae2939b6e413144d0ebb53742f"}],"ironic/drivers/modules/amt/power.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"44f6df09f79a5a6bd7f9542875b0e24b45e46987","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_utils import excutils"},{"line_number":22,"context_line":"from oslo_utils import importutils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import ironic.conf"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from ironic.common import exception"},{"line_number":27,"context_line":"from ironic.common.i18n import _"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_26e9ffe6","line":24,"updated":"2016-03-23 17:44:36.000000000","message":"This needs to be in the same section of lines 26-35\n\nMight be easiest to do:\n\n from ironic.conf import CONF\n\nAnd delete the line:\n CONF \u003d ironic.conf.CONF","commit_id":"394d1553af2f8dae2939b6e413144d0ebb53742f"}],"ironic/drivers/modules/console_utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cd18e4087ec034a2775113a71185e92a74aff829","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from ironic.common.i18n import _"},{"line_number":37,"context_line":"from ironic.common.i18n import _LW"},{"line_number":38,"context_line":"from ironic.common import utils"},{"line_number":39,"context_line":"from ironic.conf import CONF"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_d4b23048","line":39,"updated":"2016-06-14 17:27:34.000000000","message":"I\u0027m not sure about this line - we can just do the import of ironic.conf once in some place that will be definitely run in the very beginning of the process startup, maybe in cmd modules, in case of unittests it will be base class. Then here and in all the subsequent commits we can leave cfg.CONF as is, as it is a global object.","commit_id":"c2d43a9f297cbb9a65ebc29614d5a854ac71195a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"51b754a3f02d72f6b20d370bf0f63f209938f2a5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from ironic.common.i18n import _"},{"line_number":37,"context_line":"from ironic.common.i18n import _LW"},{"line_number":38,"context_line":"from ironic.common import utils"},{"line_number":39,"context_line":"from ironic.conf import CONF"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_affbcdbf","line":39,"in_reply_to":"7aa08908_d4b23048","updated":"2016-06-14 17:48:49.000000000","message":"I thought of that too, to have fewer changes. The only advantage I can think of to doing this change, is if, for whatever reason, the ironic code in ironic.conf changes what CONF is, so that it isn\u0027t the same as oslo_config.cfg.CONF.\n\nAnd to do it your way, we\u0027d need to be careful that we import ironic.conf early enough...\n\nI don\u0027t really have a strong opinion one way or the other though. But yeah, we should agree on one way :)","commit_id":"c2d43a9f297cbb9a65ebc29614d5a854ac71195a"}]}