)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5c49cf987e7a1bf7c7a7c60c97fe28b26624e1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cpshchelokovskyy@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-14 12:02:25 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update devstack plugin with new auth options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0a12f010d5b4325ee707bf674adb4813a8721c05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a18252c_4ae6a815","line":7,"updated":"2016-04-14 21:41:08.000000000","message":"Sorry, I am not up to date with things. What \u0027new auth\u0027 options?","commit_id":"878ddb8a5ddc39bba8773b3eea451b2d2fdcc9bf"}],"devstack/lib/ironic":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"32dd81c7f9a21d7ef24d0c4f6558158c6f0c6b2a","unresolved":false,"context_lines":[{"line_number":351,"context_line":"function configure_auth_for {"},{"line_number":352,"context_line":"    local service_config_section"},{"line_number":353,"context_line":"    service_config_section\u003d$1"},{"line_number":354,"context_line":"    iniset $IRONIC_CONF_FILE service_config_section auth_type password"},{"line_number":355,"context_line":"    iniset $IRONIC_CONF_FILE service_config_section auth_url $KEYSTONE_SERVICE_URI"},{"line_number":356,"context_line":"    iniset $IRONIC_CONF_FILE service_config_section username ironic"},{"line_number":357,"context_line":"    iniset $IRONIC_CONF_FILE service_config_section password $SERVICE_PASSWORD"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da0c15f0_8937cee2","line":354,"range":{"start_line":354,"start_character":29,"end_line":354,"end_character":51},"updated":"2016-03-25 07:34:27.000000000","message":"Tests are failed because of missed $ at the beginning.","commit_id":"1b9e3a4bf216062effddef5fb669ea696b6732bb"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"35ec0f21d91d64b35441efe5b50d5667bd14cf47","unresolved":false,"context_lines":[{"line_number":351,"context_line":"function configure_auth_for {"},{"line_number":352,"context_line":"    local service_config_section"},{"line_number":353,"context_line":"    service_config_section\u003d$1"},{"line_number":354,"context_line":"    iniset $IRONIC_CONF_FILE service_config_section auth_type password"},{"line_number":355,"context_line":"    iniset $IRONIC_CONF_FILE service_config_section auth_url $KEYSTONE_SERVICE_URI"},{"line_number":356,"context_line":"    iniset $IRONIC_CONF_FILE service_config_section username ironic"},{"line_number":357,"context_line":"    iniset $IRONIC_CONF_FILE service_config_section password $SERVICE_PASSWORD"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da0c15f0_95d1a1fe","line":354,"range":{"start_line":354,"start_character":29,"end_line":354,"end_character":51},"in_reply_to":"da0c15f0_8937cee2","updated":"2016-03-25 09:54:08.000000000","message":"Done","commit_id":"1b9e3a4bf216062effddef5fb669ea696b6732bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"04ad7cc3743f4a33b67b401d066dabd594fcf1d7","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section project_name $SERVICE_PROJECT_NAME"},{"line_number":359,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section user_domain_id default"},{"line_number":360,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section project_domain_id default"},{"line_number":361,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section cafile $SSL_BUNDLE_FILE"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"}"},{"line_number":364,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da0c15f0_dbf987ca","line":361,"range":{"start_line":361,"start_character":4,"end_line":361,"end_character":76},"updated":"2016-03-25 10:58:56.000000000","message":"should it be wrapped with if? In case SSL_BUNDLE_FILE is not defined?","commit_id":"cbb43ff8e0ca7948dc9e31cd62e879bb65f264ab"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"f7ad394cb9b9f6f4e52ea2cf74f107451b7295d4","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section project_name $SERVICE_PROJECT_NAME"},{"line_number":359,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section user_domain_id default"},{"line_number":360,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section project_domain_id default"},{"line_number":361,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section cafile $SSL_BUNDLE_FILE"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"}"},{"line_number":364,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da0c15f0_5e60c535","line":361,"range":{"start_line":361,"start_character":4,"end_line":361,"end_character":76},"in_reply_to":"da0c15f0_dbf987ca","updated":"2016-03-25 11:34:24.000000000","message":"not really, in many other places it is used w/o if-wrapping (e.g. [1]) as it has a default value [2]\n\n\n[1] https://github.com/openstack-dev/devstack/blob/master/lib/keystone#L487\n[2] https://github.com/openstack-dev/devstack/blob/master/stack.sh#L521","commit_id":"cbb43ff8e0ca7948dc9e31cd62e879bb65f264ab"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5c49cf987e7a1bf7c7a7c60c97fe28b26624e1d","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section project_name $SERVICE_PROJECT_NAME"},{"line_number":410,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section user_domain_id default"},{"line_number":411,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section project_domain_id default"},{"line_number":412,"context_line":"    iniset $IRONIC_CONF_FILE $service_config_section cafile $SSL_BUNDLE_FILE"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"}"},{"line_number":415,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5a18252c_ead4d420","line":412,"updated":"2016-04-14 21:41:08.000000000","message":"I don\u0027t understand this. Maybe there are other patches in the pipeline, because when I look at etc/ironic/ironic.conf.sample, I don\u0027t see these config options in those sections mentioned in configure_ironic_conductor().","commit_id":"878ddb8a5ddc39bba8773b3eea451b2d2fdcc9bf"}]}
