)]}'
{"ironic/drivers/modules/irmc/management.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e429cbdca6f03b599340d59a2d390e27e7f0722d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Set/Get System Boot Options Command, IPMI spec v2.0."},{"line_number":36,"context_line":"_BOOTPARAM5_DATA2 \u003d {boot_devices.PXE: \u00270x04\u0027,"},{"line_number":37,"context_line":"                     boot_devices.DISK: \u00270x08\u0027,"},{"line_number":38,"context_line":"                     boot_devices.CDROM: \u00270x20\u0027,"},{"line_number":39,"context_line":"                     boot_devices.BIOS: \u00270x18\u0027,"},{"line_number":40,"context_line":"                     boot_devices.SAFE: \u00270x0c\u0027,"},{"line_number":41,"context_line":"                     }"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_6b5789ce","line":38,"updated":"2016-03-30 10:02:24.000000000","message":"If I understand correctly we introduce a new bug: user can not set physical CD-ROM as boot device via API (ironic-client) after this change. Fix can be done later, but please leave comment here.","commit_id":"042641bee2fa808150bbdacdbad1550a27d4fe6d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1a2b0bc73b39f2e20232f063115c8d22589620aa","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Set/Get System Boot Options Command, IPMI spec v2.0."},{"line_number":36,"context_line":"_BOOTPARAM5_DATA2 \u003d {boot_devices.PXE: \u00270x04\u0027,"},{"line_number":37,"context_line":"                     boot_devices.DISK: \u00270x08\u0027,"},{"line_number":38,"context_line":"                     boot_devices.CDROM: \u00270x20\u0027,"},{"line_number":39,"context_line":"                     boot_devices.BIOS: \u00270x18\u0027,"},{"line_number":40,"context_line":"                     boot_devices.SAFE: \u00270x0c\u0027,"},{"line_number":41,"context_line":"                     }"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_d59d590b","line":38,"in_reply_to":"ba0121b8_6b5789ce","updated":"2016-03-31 03:03:55.000000000","message":"Okay, I\u0027ll add the comment.","commit_id":"042641bee2fa808150bbdacdbad1550a27d4fe6d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"838a235c0d21dc294fbf8955c89b8a0a15a79024","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        # data2 : boot device defined in the dict _BOOTPARAM5_DATA2"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        bootparam5 \u003d \u00270x00 0x08 0x05 %s %s 0x00 0x00 0x00\u0027"},{"line_number":167,"context_line":"        data1 \u003d ("},{"line_number":168,"context_line":"            \u00270xe0\u0027 if persistent and uefi_mode else ("},{"line_number":169,"context_line":"                \u00270xc0\u0027 if persistent and not uefi_mode else ("},{"line_number":170,"context_line":"                    \u00270xa0\u0027 if not persistent and uefi_mode else ("},{"line_number":171,"context_line":"                        \u00270x80\u0027))))"},{"line_number":172,"context_line":"        data2 \u003d _BOOTPARAM5_DATA2[device]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        cmd8 \u003d bootparam5 % (data1, data2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_3fd82f1d","line":171,"range":{"start_line":167,"start_character":8,"end_line":171,"end_character":34},"updated":"2016-03-30 08:52:40.000000000","message":"I like one liners but they are not always very readable, what about:\n\n if persistent:\n     data1 \u003d \u00270xe0\u0027 if uefi_mode else \u00270xc0\u0027\n else:\n     data1 \u003d \u00270xa0\u0027 if uefi_mode else \u00270x80\u0027","commit_id":"042641bee2fa808150bbdacdbad1550a27d4fe6d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1a2b0bc73b39f2e20232f063115c8d22589620aa","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        # data2 : boot device defined in the dict _BOOTPARAM5_DATA2"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        bootparam5 \u003d \u00270x00 0x08 0x05 %s %s 0x00 0x00 0x00\u0027"},{"line_number":167,"context_line":"        data1 \u003d ("},{"line_number":168,"context_line":"            \u00270xe0\u0027 if persistent and uefi_mode else ("},{"line_number":169,"context_line":"                \u00270xc0\u0027 if persistent and not uefi_mode else ("},{"line_number":170,"context_line":"                    \u00270xa0\u0027 if not persistent and uefi_mode else ("},{"line_number":171,"context_line":"                        \u00270x80\u0027))))"},{"line_number":172,"context_line":"        data2 \u003d _BOOTPARAM5_DATA2[device]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        cmd8 \u003d bootparam5 % (data1, data2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_5592e9f6","line":171,"range":{"start_line":167,"start_character":8,"end_line":171,"end_character":34},"in_reply_to":"ba0121b8_3fd82f1d","updated":"2016-03-31 03:03:55.000000000","message":"Okay, I\u0027ll update that.","commit_id":"042641bee2fa808150bbdacdbad1550a27d4fe6d"}],"releasenotes/notes/update-irmc-set-boot-device-fd50d9dce42aaa89.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0a683fed3be79ab869e159269adebdeaf8113310","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - This forces iRMC vmedia boot from remotely connected (redirected)"},{"line_number":4,"context_line":"    CD/DVD instead of default CD/DVD. See"},{"line_number":5,"context_line":"    https://bugs.launchpad.net/ironic/+bug/1561852 for details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_99c08e7e","line":5,"range":{"start_line":4,"start_character":38,"end_line":5,"end_character":63},"updated":"2016-03-27 03:54:06.000000000","message":"No need to add bug reference here.","commit_id":"042641bee2fa808150bbdacdbad1550a27d4fe6d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"633b81c688192b86ce68713e8a897edfa3c314cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - This forces iRMC vmedia boot from remotely connected (redirected)"},{"line_number":4,"context_line":"    CD/DVD instead of default CD/DVD. See"},{"line_number":5,"context_line":"    https://bugs.launchpad.net/ironic/+bug/1561852 for details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_98ed1ef2","line":5,"range":{"start_line":4,"start_character":38,"end_line":5,"end_character":63},"in_reply_to":"da0c15f0_99c08e7e","updated":"2016-03-28 01:36:32.000000000","message":"Shivanand,\n\nThanks for the comment. But wouldn\u0027t it better for our users to let them know for details?\n\nThere are several release notes which have a link to the bug report:\n\n- https://github.com/openstack/ironic/blob/master/releasenotes/notes/boot-ipxe-inc-workaround-548e10d1d6616752.yaml\n- https://github.com/openstack/ironic/blob/master/releasenotes/notes/bug-1506657-3bcb4ef46623124d.yaml\n- https://github.com/openstack/ironic/blob/master/releasenotes/notes/fix-api-access-logs-68b9ca4f411f339c.yaml\n- https://github.com/openstack/ironic/blob/master/releasenotes/notes/fix-cleaning-spawn-error-60b60281f3be51c2.yaml\n- https://github.com/openstack/ironic/blob/master/releasenotes/notes/fix-ipxe-template-for-whole-disk-image-943da0311ca7aeb5.yaml\n- https://github.com/openstack/ironic/blob/master/releasenotes/notes/notimplementederror-misspell-276a181afd652cf6.yaml\n\nBest regards,\nNaohiro.","commit_id":"042641bee2fa808150bbdacdbad1550a27d4fe6d"}]}