)]}'
{"ironic/drivers/modules/irmc/inspect.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4b9e805dda89eaa8c2775f94bf1818bfd48b4ec5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                  d_info[\u0027irmc_snmp_security\u0027])"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    node_classes \u003d snmp_client.get_next(NODE_CLASS_OID)"},{"line_number":102,"context_line":"    mac_addresses \u003d [\u0027:\u0027.join([\u0027%02x\u0027 % ord(x) for x in mac])"},{"line_number":103,"context_line":"                     for mac in snmp_client.get_next(MAC_ADDRESS_OID)]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    return [a for c, a in zip(node_classes, mac_addresses)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_aa128656","line":102,"updated":"2016-04-03 09:56:31.000000000","message":"nit: [] inside join() are redundant","commit_id":"df06a848f12d2d4712fc2fc59976d0ddc44dbddc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bd9ee931420f8d1f0dd47784111a06e4691d3e12","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                  d_info[\u0027irmc_snmp_security\u0027])"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    node_classes \u003d snmp_client.get_next(NODE_CLASS_OID)"},{"line_number":102,"context_line":"    mac_addresses \u003d [\u0027:\u0027.join([\u0027%02x\u0027 % ord(x) for x in mac])"},{"line_number":103,"context_line":"                     for mac in snmp_client.get_next(MAC_ADDRESS_OID)]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    return [a for c, a in zip(node_classes, mac_addresses)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_e7ff7732","line":102,"in_reply_to":"9a061dce_648d2531","updated":"2016-04-05 07:54:49.000000000","message":"Sorry, I meant that inner [] is not needed. Join itself is fine:\n\n [\u0027:\u0027.join(\u0027%02x\u0027 % ord(x) for x in mac)","commit_id":"df06a848f12d2d4712fc2fc59976d0ddc44dbddc"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d692a17f41532fc20106316a07c3541c3d71b87f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                  d_info[\u0027irmc_snmp_security\u0027])"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    node_classes \u003d snmp_client.get_next(NODE_CLASS_OID)"},{"line_number":102,"context_line":"    mac_addresses \u003d [\u0027:\u0027.join([\u0027%02x\u0027 % ord(x) for x in mac])"},{"line_number":103,"context_line":"                     for mac in snmp_client.get_next(MAC_ADDRESS_OID)]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    return [a for c, a in zip(node_classes, mac_addresses)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_648d2531","line":102,"in_reply_to":"ba0121b8_aa128656","updated":"2016-04-05 07:24:53.000000000","message":"Dmitry,\n\nThanks for the comment.\n\nOne way I can think of without join() is as follows, but it\u0027s a little bit verbose.\n\n\u003e\u003e\u003e mac \u003d \u0027\\xaa\\xaa\\xaa\\xaa\\xaa\\xaa\u0027\n\u003e\u003e\u003e reduce(operator.add, [\u0027%02x:\u0027 % ord(x) for x in mac])[0:-1]\n\u0027aa:aa:aa:aa:aa:aa\u0027","commit_id":"df06a848f12d2d4712fc2fc59976d0ddc44dbddc"}],"releasenotes/notes/fix-mac-address-48060f9e2847a38c.yaml":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6a6d24db570c9bafbe09600777726fa7bde61f64","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - This fixes InvalidMAC exception of iRMC out-of-band inspection."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_4b4b052c","line":3,"updated":"2016-04-04 09:13:06.000000000","message":"s/This/\u0027\u0027 it\u0027s a part of release notes.","commit_id":"df06a848f12d2d4712fc2fc59976d0ddc44dbddc"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d692a17f41532fc20106316a07c3541c3d71b87f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - This fixes InvalidMAC exception of iRMC out-of-band inspection."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_a403bd72","line":3,"in_reply_to":"9a061dce_4b4b052c","updated":"2016-04-05 07:24:53.000000000","message":"Yuriy,\n\nThanks for the comment.\nI\u0027d like to update it if I had to submit another patch.\n\nBest regards,\nNaohiro","commit_id":"df06a848f12d2d4712fc2fc59976d0ddc44dbddc"}]}