)]}'
{"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"456512c6239d33d926e87bbd8f82cabacf3f7d8e","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        # aside from a deployment, such as conductor takeover, we should"},{"line_number":299,"context_line":"        # treat this as a no-op and move on otherwise we would modify"},{"line_number":300,"context_line":"        # the state of the node due to virtual media operations."},{"line_number":301,"context_line":"        if node.provision_state !\u003d states.DEPLOYING:"},{"line_number":302,"context_line":"            return"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Clear ilo_boot_iso if it\u0027s a glance image to force recreate"},{"line_number":305,"context_line":"        # another one again (or use existing one in glance)."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_493666e8","line":302,"range":{"start_line":301,"start_character":8,"end_line":302,"end_character":18},"updated":"2016-04-02 06:34:53.000000000","message":"Add a testcase for this path.","commit_id":"01b4c97539424b77aa4cd1275a71b093cda66276"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"32cf3c39d2c585dea12c54e05fdd7cf7c6c5d7bc","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        # aside from a deployment, such as conductor takeover, we should"},{"line_number":299,"context_line":"        # treat this as a no-op and move on otherwise we would modify"},{"line_number":300,"context_line":"        # the state of the node due to virtual media operations."},{"line_number":301,"context_line":"        if node.provision_state !\u003d states.DEPLOYING:"},{"line_number":302,"context_line":"            return"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # Clear ilo_boot_iso if it\u0027s a glance image to force recreate"},{"line_number":305,"context_line":"        # another one again (or use existing one in glance)."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_0a40de55","line":302,"range":{"start_line":301,"start_character":8,"end_line":302,"end_character":18},"in_reply_to":"ba0121b8_493666e8","updated":"2016-04-04 12:33:47.000000000","message":"Done","commit_id":"01b4c97539424b77aa4cd1275a71b093cda66276"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f65f3f8f3af2a1ed40f4f054bb0938dd25f30921","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if service_utils.is_glance_image("},{"line_number":308,"context_line":"                node.instance_info.get(\u0027image_source\u0027)):"},{"line_number":309,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":310,"context_line":"            instance_info.pop(\u0027ilo_boot_iso\u0027, None)"},{"line_number":311,"context_line":"            node.instance_info \u003d instance_info"},{"line_number":312,"context_line":"            node.save()"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_b23affcb","line":310,"updated":"2016-04-04 15:18:03.000000000","message":"Do we want to still do this part with ilo_boot_iso removal? It is for the case of boot iso previously hosted on a web server (L183 in this file) and a node is being adopted from another ironic deployment.","commit_id":"bf5853b2cd98f6b682a65d0ca0325a9d9cdc1568"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1a47226b679527885fd3dff5f6510ab3435f3fa5","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if service_utils.is_glance_image("},{"line_number":308,"context_line":"                node.instance_info.get(\u0027image_source\u0027)):"},{"line_number":309,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":310,"context_line":"            instance_info.pop(\u0027ilo_boot_iso\u0027, None)"},{"line_number":311,"context_line":"            node.instance_info \u003d instance_info"},{"line_number":312,"context_line":"            node.save()"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_a1a266ac","line":310,"in_reply_to":"9a061dce_1b60df00","updated":"2016-04-05 18:01:08.000000000","message":"In that case I don\u0027t think it is a bug since we realistically shouldn\u0027t be modifying the data.  The case for normal use though would be through prepare_instance afaik, not prepare_ramdisk.","commit_id":"bf5853b2cd98f6b682a65d0ca0325a9d9cdc1568"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"82af022f386e4965cc82735c376ef3614bfbe85d","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if service_utils.is_glance_image("},{"line_number":308,"context_line":"                node.instance_info.get(\u0027image_source\u0027)):"},{"line_number":309,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":310,"context_line":"            instance_info.pop(\u0027ilo_boot_iso\u0027, None)"},{"line_number":311,"context_line":"            node.instance_info \u003d instance_info"},{"line_number":312,"context_line":"            node.save()"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_c244851c","line":310,"in_reply_to":"9a061dce_a1a266ac","updated":"2016-04-06 15:32:27.000000000","message":"we may want to look at refactoring the prepare_instance and prepare_ramdisk functions in another patch set, But I am good with what this patch is doing.","commit_id":"bf5853b2cd98f6b682a65d0ca0325a9d9cdc1568"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5c4a09314a5f4aa89fd4d7e931f38f2d6ce0db3c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if service_utils.is_glance_image("},{"line_number":308,"context_line":"                node.instance_info.get(\u0027image_source\u0027)):"},{"line_number":309,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":310,"context_line":"            instance_info.pop(\u0027ilo_boot_iso\u0027, None)"},{"line_number":311,"context_line":"            node.instance_info \u003d instance_info"},{"line_number":312,"context_line":"            node.save()"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_df3774ae","line":310,"in_reply_to":"9a061dce_b23affcb","updated":"2016-04-05 16:58:42.000000000","message":"I don\u0027t think we want to at this point.  My understanding is that this method should only get executed upon deployment, so ideally we wouldn\u0027t want to muck with it if takeover causes this to be called.\n\nI think we need to be more concerned with prepare_instance, but thus far I\u0027m staying hands-off that for adoption, since those boot from cd methods incorporated with prepare_instance and failover from such are part of the way the driver operates in a non-deployment case.","commit_id":"bf5853b2cd98f6b682a65d0ca0325a9d9cdc1568"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"b53bd3d64b3f34c0477f69e5c6d15bcbf62f8560","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if service_utils.is_glance_image("},{"line_number":308,"context_line":"                node.instance_info.get(\u0027image_source\u0027)):"},{"line_number":309,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":310,"context_line":"            instance_info.pop(\u0027ilo_boot_iso\u0027, None)"},{"line_number":311,"context_line":"            node.instance_info \u003d instance_info"},{"line_number":312,"context_line":"            node.save()"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_1b60df00","line":310,"in_reply_to":"9a061dce_df3774ae","updated":"2016-04-05 17:24:20.000000000","message":"vdrok, i think its still required. if a node is in DEPLOYING state and still this is populated. i believe that we shouldnt remove this as part of adoption atleast. If it is eally required to do so, it should be done as seperate bug(if it is a bug which i dont think it is)","commit_id":"bf5853b2cd98f6b682a65d0ca0325a9d9cdc1568"}],"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"456512c6239d33d926e87bbd8f82cabacf3f7d8e","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        # aside from a deployment, such as conductor takeover, we should"},{"line_number":608,"context_line":"        # treat this as a no-op and move on otherwise we would modify"},{"line_number":609,"context_line":"        # the state of the node due to virtual media operations."},{"line_number":610,"context_line":"        if task.node.provision_state !\u003d states.DEPLOYING:"},{"line_number":611,"context_line":"            return"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":614,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_09246ead","line":611,"range":{"start_line":610,"start_character":8,"end_line":611,"end_character":18},"updated":"2016-04-02 06:34:53.000000000","message":"Add a testcase for this path.","commit_id":"01b4c97539424b77aa4cd1275a71b093cda66276"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"32cf3c39d2c585dea12c54e05fdd7cf7c6c5d7bc","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        # aside from a deployment, such as conductor takeover, we should"},{"line_number":608,"context_line":"        # treat this as a no-op and move on otherwise we would modify"},{"line_number":609,"context_line":"        # the state of the node due to virtual media operations."},{"line_number":610,"context_line":"        if task.node.provision_state !\u003d states.DEPLOYING:"},{"line_number":611,"context_line":"            return"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":614,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_8a2ceeac","line":611,"range":{"start_line":610,"start_character":8,"end_line":611,"end_character":18},"in_reply_to":"ba0121b8_09246ead","updated":"2016-04-04 12:33:47.000000000","message":"Done","commit_id":"01b4c97539424b77aa4cd1275a71b093cda66276"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3cb34dcd4a86c3e1562b06fdf547f6e845a72683","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":614,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        _setup_deploy_iso(task, ramdisk_params)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    def clean_up_ramdisk(self, task):"},{"line_number":619,"context_line":"        \"\"\"Cleans up the boot of ironic ramdisk."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_5546a0bf","line":616,"updated":"2016-04-05 19:27:52.000000000","message":"Iso is placed on NFS or CIFS so during conductor takeover link will remain the same.","commit_id":"bf5853b2cd98f6b682a65d0ca0325a9d9cdc1568"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b851926bf7849dc611bdb4101d6e40b3352b4e14","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        deploy_nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":614,"context_line":"        ramdisk_params[\u0027BOOTIF\u0027] \u003d deploy_nic_mac"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        _setup_deploy_iso(task, ramdisk_params)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"    def clean_up_ramdisk(self, task):"},{"line_number":619,"context_line":"        \"\"\"Cleans up the boot of ironic ramdisk."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_e09f795d","line":616,"in_reply_to":"9a061dce_5546a0bf","updated":"2016-04-12 12:44:36.000000000","message":"Good to know, thank you!","commit_id":"bf5853b2cd98f6b682a65d0ca0325a9d9cdc1568"}]}