)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ad12da5b493b0807d833d9d7f8b2ae2625d8178b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes iLO driver CI for IRONIC_RAMDISK_TYPE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix avoids the devstack to stop proceeding if"},{"line_number":10,"context_line":"the IRONIC_RAMDISK_TYPE is not coreos or tinyipa."},{"line_number":11,"context_line":"The change ID I641a5afe8318ec0848395b2b70e056c448f3dd00"},{"line_number":12,"context_line":"forces teh stack to stop if IRONIC_RAMDISK_TYPE is other"},{"line_number":13,"context_line":"than coreos and tinyipa. There is no tar ball which can be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_77e0cc96","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":23},"updated":"2016-04-06 18:52:41.000000000","message":"nit: Perhaps state that it is a setting?","commit_id":"ab122aa3600fc17fd07656019dcb4878dced876b"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5ee355fc19794469a0c879ff1090107bbf497175","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This fix avoids the devstack to stop proceeding if"},{"line_number":10,"context_line":"the IRONIC_RAMDISK_TYPE is not coreos or tinyipa."},{"line_number":11,"context_line":"The change ID I641a5afe8318ec0848395b2b70e056c448f3dd00"},{"line_number":12,"context_line":"forces teh stack to stop if IRONIC_RAMDISK_TYPE is other"},{"line_number":13,"context_line":"than coreos and tinyipa. There is no tar ball which can be"},{"line_number":14,"context_line":"fetched if the IRONIC_RAMDISK_TYPE is dib."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_97748036","line":12,"updated":"2016-04-06 18:45:21.000000000","message":"nit: s/teh/the/","commit_id":"ab122aa3600fc17fd07656019dcb4878dced876b"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e261cc77ec0d92f4240a54a2d052f291586e5960","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes iLO driver CI for IRONIC_RAMDISK_TYPE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix avoids the devstack to stop proceeding if"},{"line_number":10,"context_line":"the IRONIC_RAMDISK_TYPE is not coreos or tinyipa."},{"line_number":11,"context_line":"The change ID I641a5afe8318ec0848395b2b70e056c448f3dd00"},{"line_number":12,"context_line":"forces teh stack to stop if IRONIC_RAMDISK_TYPE is other"},{"line_number":13,"context_line":"than coreos and tinyipa. There is no tar ball which can be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_7271fa43","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":24},"updated":"2016-04-06 19:09:45.000000000","message":"nit: setting","commit_id":"1a67ccbb80dc5ba989b44c93408db4b962fce689"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e261cc77ec0d92f4240a54a2d052f291586e5960","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This fix avoids the devstack to stop proceeding if"},{"line_number":10,"context_line":"the IRONIC_RAMDISK_TYPE is not coreos or tinyipa."},{"line_number":11,"context_line":"The change ID I641a5afe8318ec0848395b2b70e056c448f3dd00"},{"line_number":12,"context_line":"forces teh stack to stop if IRONIC_RAMDISK_TYPE is other"},{"line_number":13,"context_line":"than coreos and tinyipa. There is no tar ball which can be"},{"line_number":14,"context_line":"fetched if the IRONIC_RAMDISK_TYPE is dib."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_12807ef6","line":12,"range":{"start_line":12,"start_character":7,"end_line":12,"end_character":10},"updated":"2016-04-06 19:09:45.000000000","message":"Nit: the","commit_id":"1a67ccbb80dc5ba989b44c93408db4b962fce689"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"561a3586940d8dd09eb82ab303644f34255a6911","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-07 10:42:44 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes iLO driver CI for IRONIC_RAMDISK_TYPE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix avoids the devstack to stop proceeding if"},{"line_number":10,"context_line":"the setting IRONIC_RAMDISK_TYPE is not coreos or tinyipa."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a122d0e_f8e27700","line":7,"updated":"2016-05-03 09:18:59.000000000","message":"The change seems to be generic enough and not related to the iLO CI specifically (just saying because it may confuse someone reading this commit message).\n\nWhat about: \"Extend IRONIC_RAMDISK_TYPE to support dib\"","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c2449e1703709a3421207706fbc90e344f97e751","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-07 10:42:44 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes iLO driver CI for IRONIC_RAMDISK_TYPE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix avoids the devstack to stop proceeding if"},{"line_number":10,"context_line":"the setting IRONIC_RAMDISK_TYPE is not coreos or tinyipa."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a122d0e_20e651e8","line":7,"in_reply_to":"1a122d0e_f8e27700","updated":"2016-05-04 09:15:52.000000000","message":"Ok. I will rephrase it as suggested.","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"}],"devstack/lib/ironic":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5ee355fc19794469a0c879ff1090107bbf497175","unresolved":false,"context_lines":[{"line_number":116,"context_line":"elif $IRONIC_RAMDISK_TYPE\u003d\"tinyipa\"; then"},{"line_number":117,"context_line":"    IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.vmlinuz}"},{"line_number":118,"context_line":"    IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":119,"context_line":"fi"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":122,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a061dce_17a99090","line":119,"updated":"2016-04-06 18:45:21.000000000","message":"There wasn\u0027t really a need to change this from a case statement, you could just replace the die with a log message so it would continue.","commit_id":"ab122aa3600fc17fd07656019dcb4878dced876b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ad12da5b493b0807d833d9d7f8b2ae2625d8178b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"elif $IRONIC_RAMDISK_TYPE\u003d\"tinyipa\"; then"},{"line_number":117,"context_line":"    IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.vmlinuz}"},{"line_number":118,"context_line":"    IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":119,"context_line":"fi"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":122,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a061dce_d77a78f0","line":119,"in_reply_to":"9a061dce_17a99090","updated":"2016-04-06 18:52:41.000000000","message":"++  Truthfully, the case statement is a lot easier to read","commit_id":"ab122aa3600fc17fd07656019dcb4878dced876b"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"ceab4cc665d26afda1a40e0e0957d045bdc13cbb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"elif $IRONIC_RAMDISK_TYPE\u003d\"tinyipa\"; then"},{"line_number":117,"context_line":"    IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.vmlinuz}"},{"line_number":118,"context_line":"    IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":119,"context_line":"fi"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":122,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a061dce_92180e20","line":119,"in_reply_to":"9a061dce_d77a78f0","updated":"2016-04-06 19:06:37.000000000","message":"+1 for reverting back to the case statement","commit_id":"ab122aa3600fc17fd07656019dcb4878dced876b"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e261cc77ec0d92f4240a54a2d052f291586e5960","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        echo \"DIB has no pre-built tar balls\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027\""},{"line_number":127,"context_line":"    ;;"},{"line_number":128,"context_line":"esac"},{"line_number":129,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a061dce_52d0361f","line":126,"range":{"start_line":126,"start_character":86,"end_line":126,"end_character":107},"updated":"2016-04-06 19:09:45.000000000","message":"should add DIB here.","commit_id":"1a67ccbb80dc5ba989b44c93408db4b962fce689"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"dfbaa8da6b20130bf0720941d0c4537b04083f56","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        echo \"DIB has no pre-built tar balls\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027\""},{"line_number":127,"context_line":"    ;;"},{"line_number":128,"context_line":"esac"},{"line_number":129,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a061dce_12e51edb","line":126,"range":{"start_line":126,"start_character":86,"end_line":126,"end_character":107},"updated":"2016-04-06 19:11:15.000000000","message":"we should list DIB here too.","commit_id":"278e18b6f4996f25fae526e9de4572ba4b17a727"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"52ce87f876a97503483c9aa15359ff757d1cad50","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        echo \"DIB has no pre-built tar balls\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027\""},{"line_number":127,"context_line":"    ;;"},{"line_number":128,"context_line":"esac"},{"line_number":129,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a061dce_323e6228","line":126,"range":{"start_line":126,"start_character":86,"end_line":126,"end_character":107},"in_reply_to":"9a061dce_12e51edb","updated":"2016-04-06 19:12:57.000000000","message":"ok :)","commit_id":"278e18b6f4996f25fae526e9de4572ba4b17a727"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c03fcbd000ce1c6030ce03cc26a657a41213c586","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"DIB has no pre-built tar balls\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a061dce_af27a8b4","line":123,"range":{"start_line":123,"start_character":14,"end_line":123,"end_character":44},"updated":"2016-04-06 20:31:45.000000000","message":"Maybe \"IRONIC_RAMDISK_TYPE setting DIB has no pre-built packages\" so the reader has context into the setting?","commit_id":"6ff4b3dfeb1edc98a9e37c29f7c3b4c83ecb825a"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e70a6a35123f122ede978bd1b8eee6c5aca1def3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        echo \"DIB has no pre-built tar balls\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027 or \u0027dib\u0027\""},{"line_number":127,"context_line":"    ;;"},{"line_number":128,"context_line":"esac"},{"line_number":129,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a061dce_42f7c358","line":126,"range":{"start_line":126,"start_character":95,"end_line":126,"end_character":97},"updated":"2016-04-06 21:11:18.000000000","message":"NIT: s/or/,/","commit_id":"6ff4b3dfeb1edc98a9e37c29f7c3b4c83ecb825a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e712c5b631694739c30d35f9b34f9d66cd090a21","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built tar balls\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a061dce_9eaaa283","line":123,"updated":"2016-04-07 15:33:22.000000000","message":"+1\n\nalso this should fail if IRONIC_BUILD_DEPLOY_RAMDISK is False and these 2 URL\u0027s are empty","commit_id":"a1d2eb71a6bbe71272218c975c89d7782b130bf0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"01b46a78e297e1e164865cd35fa4cf085e96edf9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built tar balls\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9a061dce_7d8ec22e","line":123,"range":{"start_line":123,"start_character":65,"end_line":123,"end_character":74},"updated":"2016-04-07 12:46:44.000000000","message":"nit: The provided images are not tarballs, just compressed files.","commit_id":"a1d2eb71a6bbe71272218c975c89d7782b130bf0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"561a3586940d8dd09eb82ab303644f34255a6911","unresolved":false,"context_lines":[{"line_number":104,"context_line":"# (The value must be an absolute path)"},{"line_number":105,"context_line":"IRONIC_DEPLOY_RAMDISK\u003d${IRONIC_DEPLOY_RAMDISK:-}"},{"line_number":106,"context_line":"IRONIC_DEPLOY_KERNEL\u003d${IRONIC_DEPLOY_KERNEL:-}"},{"line_number":107,"context_line":"IRONIC_DEPLOY_ELEMENT\u003d${IRONIC_DEPLOY_ELEMENT:-deploy-ironic}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# NOTE(jroll) this needs to be updated when stable branches are cut"},{"line_number":110,"context_line":"IPA_DOWNLOAD_BRANCH\u003d${IPA_DOWNLOAD_BRANCH:-master}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_e3076c16","line":107,"updated":"2016-05-03 09:18:59.000000000","message":"For DIB we should use these variables, no?","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c2449e1703709a3421207706fbc90e344f97e751","unresolved":false,"context_lines":[{"line_number":104,"context_line":"# (The value must be an absolute path)"},{"line_number":105,"context_line":"IRONIC_DEPLOY_RAMDISK\u003d${IRONIC_DEPLOY_RAMDISK:-}"},{"line_number":106,"context_line":"IRONIC_DEPLOY_KERNEL\u003d${IRONIC_DEPLOY_KERNEL:-}"},{"line_number":107,"context_line":"IRONIC_DEPLOY_ELEMENT\u003d${IRONIC_DEPLOY_ELEMENT:-deploy-ironic}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# NOTE(jroll) this needs to be updated when stable branches are cut"},{"line_number":110,"context_line":"IPA_DOWNLOAD_BRANCH\u003d${IPA_DOWNLOAD_BRANCH:-master}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_7b70f840","line":107,"in_reply_to":"1a122d0e_e3076c16","updated":"2016-05-04 09:15:52.000000000","message":"Yes for pre-built images we use these only. For ISO we use the patch https://review.openstack.org/#/c/264590 where we add teh variable for ISO.\n\nThe iscsi-ilo gate also works fine when building the ramdisk in the gate using DIB where we use the patch https://review.openstack.org/#/c/264579. But right now i have coded it to use pre-built iso, kernel, ramdisk.","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7fd0783e00538a16f9076bd42e622bdbdc42ecac","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a1b2928_f93ab3e6","line":123,"updated":"2016-04-10 16:34:21.000000000","message":"nit: I\u0027d prefer this to fail, if IRONIC_BUILD_DEPLOY_RAMDISK is False, and the URL\u0027s are empty","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6c83a330550e73a071e3e3a5d40edf2ab9138819","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_562cc549","line":123,"in_reply_to":"1a122d0e_2202d43e","updated":"2016-05-05 02:50:50.000000000","message":"Dmitry, here for DIB i can just check if URLs are none or not. But that shouldnt make it fail, correct? It will be non-Null only if user provides them as inputs through local.conf for DIB images. Is that what you mean?","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"133804704bb357c0f19ac4beb65007cb40ff289d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dab17558_8a07641b","line":123,"in_reply_to":"1a122d0e_76274163","updated":"2016-05-09 13:18:03.000000000","message":"\u003e It will be non-Null only if user provides them as inputs through local.conf for DIB images. Is that what you mean?\n\nYep.","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c2449e1703709a3421207706fbc90e344f97e751","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_fb21a89f","line":123,"in_reply_to":"1a122d0e_78078781","updated":"2016-05-04 09:15:52.000000000","message":"Lucas, This fix is in place in iscsi-ilo gate. and as of now i dont build the ramdisk on each run, rather use the pre-built ramdisk and kernel i.e. prebuilt iso  and pass teh arguments through local.conf. And that works perfectly fine. \n\nThe IRONIC_BUILD_DEPLOY_RAMDISK is a config which applies globally to any type of ramdisk we build and therefore i dont see why this is necessary to be checked here but not for other type of ramdisks. \n\nThis case-esac was added as part of a patch which merged on April6, before that the RAMDISK type as dib used to pass this code.","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1d3945716c65b0074feed6f7fddca83a685da67a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_2202d43e","line":123,"in_reply_to":"1a122d0e_a9939bff","updated":"2016-05-04 10:02:15.000000000","message":"\u003e The URL\u0027s doesnt make any sense for DIB, correct? \n\nWhy? URL makes the same sense for any ramdisk implementation","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"561a3586940d8dd09eb82ab303644f34255a6911","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_78078781","line":123,"in_reply_to":"1a122d0e_a9939bff","updated":"2016-05-03 09:18:59.000000000","message":"Hi @Nisha,\n\nI think that what @Ruby means is that the code should fail before (in this case-conditional) in case IRONIC_RAMDISK_TYPE\u003ddib and IRONIC_BUILD_DEPLOY_RAMDISK\u003dFalse\n\n...\n\nPersonally I would prefer that we fail if RONIC_BUILD_DEPLOY_RAMDISK is set to False, otherwise using dib will build a new ramdisk on every devstack run, which doesn\u0027t seems ideal specially if you already pre-built one (see L106).\n\nPerhaps we should just echo a warning here?","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6c83a330550e73a071e3e3a5d40edf2ab9138819","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_76274163","line":123,"in_reply_to":"1a122d0e_d78113fd","updated":"2016-05-05 02:50:50.000000000","message":"Thanks Lucas, should i take that you are fine with current fix then?","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"942829310f8ee4e144f41087ad0e416e79a7db24","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_d78113fd","line":123,"in_reply_to":"1a122d0e_fb21a89f","updated":"2016-05-04 13:56:01.000000000","message":"@Nisha, I\u0027m sorry there\u0027s a typo/mistake in my comment. I wanted to say that I prefer that we *do not* fail if IRONIC_BUILD_DEPLOY_RAMDISK is False (so we can reuse a pre-built ramdisk), that\u0027s why I actually was thinking about only echo\u0027ing a warning message.","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"448eb7341644748c3ebf5c81cba19fdaae902142","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_69e4e3ab","line":123,"in_reply_to":"5a18252c_10cf4b80","updated":"2016-05-03 04:48:09.000000000","message":"But Ruby this doesnt fail even without the patch which added the condition for tinyipa here.","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f9a51c1c772ef79aa34c824fe98885438df1de7","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5a18252c_10cf4b80","line":123,"in_reply_to":"7a1b2928_f93ab3e6","updated":"2016-04-12 20:23:43.000000000","message":"Dmitry, is this really a nit? It seems like it ought to be addressed. Because this case would have failed before, but with this change, it won\u0027t.","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"448eb7341644748c3ebf5c81cba19fdaae902142","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.cpio.gz}"},{"line_number":121,"context_line":"    ;;"},{"line_number":122,"context_line":"    dib)"},{"line_number":123,"context_line":"        echo \"IRONIC_RAMDISK_TYPE setting \u0027dib\u0027 has no pre-built images\""},{"line_number":124,"context_line":"    ;;"},{"line_number":125,"context_line":"    *)"},{"line_number":126,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_a9939bff","line":123,"in_reply_to":"7a1b2928_f93ab3e6","updated":"2016-05-03 04:48:09.000000000","message":"The URL\u0027s doesnt make any sense for DIB, correct? Or you mean user is allowed to pass these URLs for DIB?\n\nIf IRONIC_BUILD_DEPLOY_RAMDISK is False the code will automatically fail at line 989","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"561a3586940d8dd09eb82ab303644f34255a6911","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":972,"context_line":"                        build_tinyipa_ramdisk $IRONIC_DEPLOY_KERNEL_PATH $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":973,"context_line":"                    else"},{"line_number":974,"context_line":"                        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027\""},{"line_number":975,"context_line":"                    fi"},{"line_number":976,"context_line":"                else"},{"line_number":977,"context_line":"                    ramdisk-image-create $IRONIC_DEPLOY_FLAVOR \\"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_8350380c","line":974,"updated":"2016-05-03 09:18:59.000000000","message":"I believe we should also update this bits over here","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"bffeea481107c9248acf170a50b7c6c1f494aa41","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":972,"context_line":"                        build_tinyipa_ramdisk $IRONIC_DEPLOY_KERNEL_PATH $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":973,"context_line":"                    else"},{"line_number":974,"context_line":"                        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027\""},{"line_number":975,"context_line":"                    fi"},{"line_number":976,"context_line":"                else"},{"line_number":977,"context_line":"                    ramdisk-image-create $IRONIC_DEPLOY_FLAVOR \\"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a122d0e_fb5b6884","line":974,"in_reply_to":"1a122d0e_8350380c","updated":"2016-05-04 09:17:35.000000000","message":"This part of code taken care by https://review.openstack.org/#/c/264579, where there are some outstanding comments. i will address them shortly.","commit_id":"3d2faee929223aef5189f88aeca8fe3c1ed70dbe"}]}