)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"9b607bf1b91fed8654f707224f94b8ed8661940d","unresolved":false,"context_lines":[{"line_number":926,"context_line":"# Operator option to enable fallback from the failure of a"},{"line_number":927,"context_line":"# disk based secure erase operation to a shred operation in"},{"line_number":928,"context_line":"# the Ironic Python Agent. Defaults to False. (boolean value)"},{"line_number":929,"context_line":"#fallback_to_shred_upon_secure_erase_failure\u003dfalse"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"[dhcp]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a061dce_aaaac882","line":929,"updated":"2016-04-07 14:52:43.000000000","message":"I\u0027m unsure about that name, shred is the current fallback, but in theory, it\u0027s more like continuing if ATA secure erase fails (hence the agent_continue_if_ata_erase_failed name in driver_internal_info). Maybe something along the lines of ignore ata erase failures? (but then that doesn\u0027t mean the process will continue..)","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e498fc0dc4088c4a0e56c501458ee817ffd90bae","unresolved":false,"context_lines":[{"line_number":926,"context_line":"# Operator option to enable fallback from the failure of a"},{"line_number":927,"context_line":"# disk based secure erase operation to a shred operation in"},{"line_number":928,"context_line":"# the Ironic Python Agent. Defaults to False. (boolean value)"},{"line_number":929,"context_line":"#fallback_to_shred_upon_secure_erase_failure\u003dfalse"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"[dhcp]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_d7168ea6","line":929,"in_reply_to":"5a18252c_cc58c159","updated":"2016-04-12 10:05:31.000000000","message":"+1 for new name.","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ff1d07413d71b8842b1c4f38d0b09bdd00de529","unresolved":false,"context_lines":[{"line_number":926,"context_line":"# Operator option to enable fallback from the failure of a"},{"line_number":927,"context_line":"# disk based secure erase operation to a shred operation in"},{"line_number":928,"context_line":"# the Ironic Python Agent. Defaults to False. (boolean value)"},{"line_number":929,"context_line":"#fallback_to_shred_upon_secure_erase_failure\u003dfalse"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"[dhcp]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_25606335","line":929,"in_reply_to":"5a18252c_d7168ea6","updated":"2016-04-12 12:18:44.000000000","message":"Seems like we have reached some consensus.  New rev inbound shortly.","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"dd0e0659bf9ada40773c025862641f644753896f","unresolved":false,"context_lines":[{"line_number":926,"context_line":"# Operator option to enable fallback from the failure of a"},{"line_number":927,"context_line":"# disk based secure erase operation to a shred operation in"},{"line_number":928,"context_line":"# the Ironic Python Agent. Defaults to False. (boolean value)"},{"line_number":929,"context_line":"#fallback_to_shred_upon_secure_erase_failure\u003dfalse"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"[dhcp]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_cc58c159","line":929,"in_reply_to":"7a1b2928_38b413f1","updated":"2016-04-12 09:49:38.000000000","message":"+1 for the new name","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"32f1cac7aedfacb3709c2e0021d4599e87423a35","unresolved":false,"context_lines":[{"line_number":926,"context_line":"# Operator option to enable fallback from the failure of a"},{"line_number":927,"context_line":"# disk based secure erase operation to a shred operation in"},{"line_number":928,"context_line":"# the Ironic Python Agent. Defaults to False. (boolean value)"},{"line_number":929,"context_line":"#fallback_to_shred_upon_secure_erase_failure\u003dfalse"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"[dhcp]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a1b2928_38b413f1","line":929,"in_reply_to":"9a061dce_6817cb54","updated":"2016-04-11 10:31:54.000000000","message":"beautiful :)","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bb31b84c2187a827898e21ec9a4303acfda9ee05","unresolved":false,"context_lines":[{"line_number":926,"context_line":"# Operator option to enable fallback from the failure of a"},{"line_number":927,"context_line":"# disk based secure erase operation to a shred operation in"},{"line_number":928,"context_line":"# the Ironic Python Agent. Defaults to False. (boolean value)"},{"line_number":929,"context_line":"#fallback_to_shred_upon_secure_erase_failure\u003dfalse"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"[dhcp]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a061dce_6817cb54","line":929,"in_reply_to":"9a061dce_aaaac882","updated":"2016-04-08 18:29:03.000000000","message":"continue_if_disk_secure_erase_fails ?","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7a3be34b351c466a4201947772c079e9c2d12097","unresolved":false,"context_lines":[{"line_number":926,"context_line":"# Operator option to enable fallback from the failure of a"},{"line_number":927,"context_line":"# disk based secure erase operation to a shred operation in"},{"line_number":928,"context_line":"# the Ironic Python Agent. Defaults to False. (boolean value)"},{"line_number":929,"context_line":"#fallback_to_shred_upon_secure_erase_failure\u003dfalse"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"[dhcp]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a18252c_e6c5a73c","line":929,"updated":"2016-04-13 07:18:17.000000000","message":"Please update config example with tox -e genconfig","commit_id":"47ce2b3440a50e5528eaae0b10d23f4cd10552d6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"19de8d3174a7ce87d8afbec0842bf94872140337","unresolved":false,"context_lines":[{"line_number":926,"context_line":"# Operator option to enable fallback from the failure of a"},{"line_number":927,"context_line":"# disk based secure erase operation to a shred operation in"},{"line_number":928,"context_line":"# the Ironic Python Agent. Defaults to False. (boolean value)"},{"line_number":929,"context_line":"#fallback_to_shred_upon_secure_erase_failure\u003dfalse"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"[dhcp]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a18252c_2a83d005","line":929,"in_reply_to":"5a18252c_e6c5a73c","updated":"2016-04-13 12:41:37.000000000","message":"Done","commit_id":"47ce2b3440a50e5528eaae0b10d23f4cd10552d6"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"dd0e0659bf9ada40773c025862641f644753896f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                help\u003d_(\u0027Operator option to enable fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based secure erase operation to a shred \u0027"},{"line_number":82,"context_line":"                       \u0027operation in the Ironic Python Agent. \u0027"},{"line_number":83,"context_line":"                       \u0027Defaults to False.\u0027)),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":"CONF \u003d cfg.CONF"},{"line_number":86,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_0c18f983","line":83,"updated":"2016-04-12 09:49:38.000000000","message":"nit: I think we should mention this is part of cleaning, so people that has cleaning disabled will easily realize that they shouldn\u0027t care about this configuration.","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ff1d07413d71b8842b1c4f38d0b09bdd00de529","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                help\u003d_(\u0027Operator option to enable fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based secure erase operation to a shred \u0027"},{"line_number":82,"context_line":"                       \u0027operation in the Ironic Python Agent. \u0027"},{"line_number":83,"context_line":"                       \u0027Defaults to False.\u0027)),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":"CONF \u003d cfg.CONF"},{"line_number":86,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_2526a3ba","line":83,"in_reply_to":"5a18252c_0c18f983","updated":"2016-04-12 12:18:44.000000000","message":"Good point, will do.","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e498fc0dc4088c4a0e56c501458ee817ffd90bae","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                help\u003d_(\u0027Operator option to enable fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based secure erase operation to a shred \u0027"},{"line_number":82,"context_line":"                       \u0027operation in the Ironic Python Agent. \u0027"},{"line_number":83,"context_line":"                       \u0027Defaults to False.\u0027)),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":"CONF \u003d cfg.CONF"},{"line_number":86,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_7754da53","line":83,"in_reply_to":"5a18252c_0c18f983","updated":"2016-04-12 10:05:31.000000000","message":"Might be we should think to move cleaning options to separate config section?","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0ff1d07413d71b8842b1c4f38d0b09bdd00de529","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                help\u003d_(\u0027Operator option to enable fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based secure erase operation to a shred \u0027"},{"line_number":82,"context_line":"                       \u0027operation in the Ironic Python Agent. \u0027"},{"line_number":83,"context_line":"                       \u0027Defaults to False.\u0027)),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":"CONF \u003d cfg.CONF"},{"line_number":86,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_e555cbc6","line":83,"in_reply_to":"5a18252c_7754da53","updated":"2016-04-12 12:18:44.000000000","message":"I think discussing moving them may be an item for a larger discussion and out of scope of supporting a fix in IPA.  Two of the options were previously in the agent config group, and while the agent is the deploy utility for the agent drivers, it is also the cleaning mechanism for agent drivers. :\\","commit_id":"b65c6be9f22aa02fad9e6dafd9ac557fb01c7f7a"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d2024cdc30f936b39178bd86aadfe34f1691a48b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027continue_if_disk_secure_erase_fails\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d_(\u0027Operator option to enable cleaning fallback from the \u0027"},{"line_number":81,"context_line":"                       \u0027failure of a disk based secure erase operation to a \u0027"},{"line_number":82,"context_line":"                       \u0027shred operation in the Ironic Python Agent. \u0027"},{"line_number":83,"context_line":"                       \u0027Defaults to False.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_74d0af1f","line":80,"range":{"start_line":80,"start_character":24,"end_line":80,"end_character":33},"updated":"2016-04-14 20:52:54.000000000","message":"Nit: \"operator\" seems strange here.","commit_id":"39bd401204a4c944529b21ef957ede152f4b421c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"df2cf67f85996cecbed90a4749969112d1775217","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027continue_if_disk_secure_erase_fails\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d_(\u0027Operator option to enable cleaning fallback from the \u0027"},{"line_number":81,"context_line":"                       \u0027failure of a disk based secure erase operation to a \u0027"},{"line_number":82,"context_line":"                       \u0027shred operation in the Ironic Python Agent. \u0027"},{"line_number":83,"context_line":"                       \u0027Defaults to False.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_9f1d5669","line":80,"range":{"start_line":80,"start_character":24,"end_line":80,"end_character":33},"in_reply_to":"5a18252c_74d0af1f","updated":"2016-04-15 12:47:51.000000000","message":"Upon further thought, operator is implied in this case.  Changing.","commit_id":"39bd401204a4c944529b21ef957ede152f4b421c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cd78ac46b3ac57c91fc106c66ecf6927da3cd27e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                default\u003dTrue,"},{"line_number":76,"context_line":"                help\u003d_(\u0027Whether to power off a node after deploy failure. \u0027"},{"line_number":77,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027continue_if_disk_secure_erase_fails\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d_(\u0027Option to enable cleaning fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based ATA secure erase operation to a \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_72ba310c","line":78,"updated":"2016-04-21 14:44:03.000000000","message":"If all the configs in this [deploy] group are not specific to IPA, maybe move this one next to the others that are.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"16896b9fae34e8d487af96ca195cccd9585fd54b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                default\u003dTrue,"},{"line_number":76,"context_line":"                help\u003d_(\u0027Whether to power off a node after deploy failure. \u0027"},{"line_number":77,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027continue_if_disk_secure_erase_fails\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d_(\u0027Option to enable cleaning fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based ATA secure erase operation to a \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_3959b58f","line":78,"in_reply_to":"1a122d0e_72ba310c","updated":"2016-04-21 17:46:37.000000000","message":"Moved up to be above power_off_after_deploy_failure to be with the rest of the IPA  options.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"eb6f70cc96dde37094f276051bcd47aae2066ed9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                help\u003d_(\u0027Whether to power off a node after deploy failure. \u0027"},{"line_number":77,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027continue_if_disk_secure_erase_fails\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d_(\u0027Option to enable cleaning fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based ATA secure erase operation to a \u0027"},{"line_number":82,"context_line":"                       \u0027shred operation in the Ironic Python Agent. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_47567506","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":29},"updated":"2016-04-21 03:59:58.000000000","message":"How about changing default to True, as we have another method to erase disk, so if operators don\u0027t explicitly specify they need secure erase, it\u0027s better to prevent go into CLEANFAIL directly by default.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c4da6513119d62369d73685141724df9bd9c6465","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                help\u003d_(\u0027Whether to power off a node after deploy failure. \u0027"},{"line_number":77,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027continue_if_disk_secure_erase_fails\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d_(\u0027Option to enable cleaning fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based ATA secure erase operation to a \u0027"},{"line_number":82,"context_line":"                       \u0027shred operation in the Ironic Python Agent. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b99957d3","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":29},"in_reply_to":"1a122d0e_47567506","updated":"2016-04-21 12:32:19.000000000","message":"Setting this to True changes the current behavior of IPA since it presently blocks.  Specifically the bulk of the concern is over SSDs since shred operations are extremely taxing to and reduces the lifecycle of the SSD.\n\nIdeally operators should be using secure erase.  I\u0027m sure JayF and I will be discussing alternatives to erasing disk volumes at the summit since we realize that it is not perfect and presently some types of disks will fall to shred by default which is less than ideal.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"693c2fc968d2969eca8cad19943a44a95ef817e0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                help\u003d_(\u0027Whether to power off a node after deploy failure. \u0027"},{"line_number":77,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027continue_if_disk_secure_erase_fails\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d_(\u0027Option to enable cleaning fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based ATA secure erase operation to a \u0027"},{"line_number":82,"context_line":"                       \u0027shred operation in the Ironic Python Agent. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_df934eff","line":79,"range":{"start_line":79,"start_character":24,"end_line":79,"end_character":29},"in_reply_to":"1a122d0e_b99957d3","updated":"2016-04-21 14:29:37.000000000","message":"Thanks for the explanation Julia!","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cd78ac46b3ac57c91fc106c66ecf6927da3cd27e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                help\u003d_(\u0027Option to enable cleaning fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based ATA secure erase operation to a \u0027"},{"line_number":82,"context_line":"                       \u0027shred operation in the Ironic Python Agent. \u0027"},{"line_number":83,"context_line":"                       \u0027Defaults to False.\u0027)),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":"CONF \u003d cfg.CONF"},{"line_number":86,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_1ffdc66e","line":83,"updated":"2016-04-21 14:44:03.000000000","message":"I had a hard time parsing this sentence. How about something like:\n\nDetermines what to do if a disk-based ATA secure erase operation fails during cleaning in the Ironic Python Agent. If False, the cleaning will fail and the node will be put in \u0027clean failed\u0027 state. If True, shred will be invoked and cleaning will continue.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"16896b9fae34e8d487af96ca195cccd9585fd54b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                help\u003d_(\u0027Option to enable cleaning fallback from the failure \u0027"},{"line_number":81,"context_line":"                       \u0027of a disk based ATA secure erase operation to a \u0027"},{"line_number":82,"context_line":"                       \u0027shred operation in the Ironic Python Agent. \u0027"},{"line_number":83,"context_line":"                       \u0027Defaults to False.\u0027)),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":"CONF \u003d cfg.CONF"},{"line_number":86,"context_line":"CONF.register_opts(deploy_opts, group\u003d\u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_d93401fd","line":83,"in_reply_to":"1a122d0e_1ffdc66e","updated":"2016-04-21 17:46:37.000000000","message":"I kind of like it.  Changing, although a few minor word adjustments.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"acbb6e77103eb043d3aead6cc07c9351192a6f3b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                help\u003d_(\u0027Defines what to do if an ATA secure erase operation \u0027"},{"line_number":71,"context_line":"                       \u0027fails during cleaning in the Ironic Python Agent. \u0027"},{"line_number":72,"context_line":"                       \u0027If False, the cleaning operation will fail and the \u0027"},{"line_number":73,"context_line":"                       \u0027node will be put in ``clean fail`` state. \u0027"},{"line_number":74,"context_line":"                       \u0027If True, shred will be invoked and cleaning will \u0027"},{"line_number":75,"context_line":"                       \u0027continue.\u0027)),"},{"line_number":76,"context_line":"    cfg.BoolOpt(\u0027power_off_after_deploy_failure\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_5f5a9151","line":73,"updated":"2016-04-21 18:22:12.000000000","message":"nit: it is actually s/clean fail/clean failed/. (That\u0027s what you\u0027ll see if you do a eg \u0027node show\u0027.)","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"332ab0a2cba78a1f11bcd6d6293420d7bdc89063","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                help\u003d_(\u0027Defines what to do if an ATA secure erase operation \u0027"},{"line_number":71,"context_line":"                       \u0027fails during cleaning in the Ironic Python Agent. \u0027"},{"line_number":72,"context_line":"                       \u0027If False, the cleaning operation will fail and the \u0027"},{"line_number":73,"context_line":"                       \u0027node will be put in ``clean fail`` state. \u0027"},{"line_number":74,"context_line":"                       \u0027If True, shred will be invoked and cleaning will \u0027"},{"line_number":75,"context_line":"                       \u0027continue.\u0027)),"},{"line_number":76,"context_line":"    cfg.BoolOpt(\u0027power_off_after_deploy_failure\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_da34effc","line":73,"in_reply_to":"1a122d0e_5f5a9151","updated":"2016-04-21 18:50:51.000000000","message":"Done","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b1d2933cd9ac4f236324a85585c8074f683c1cb7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       \"deploy.shred_random_overwrite_interations is 0. This \""},{"line_number":78,"context_line":"                       \"option is only used if a device could not be ATA \""},{"line_number":79,"context_line":"                       \"Secure Erased. Defaults to True.\")),"},{"line_number":80,"context_line":"    cfg.BoolOpt(\u0027continue_if_disk_secure_erase_fails\u0027,"},{"line_number":81,"context_line":"                default\u003dFalse,"},{"line_number":82,"context_line":"                help\u003d_(\u0027Defines what to do if an ATA secure erase operation \u0027"},{"line_number":83,"context_line":"                       \u0027fails during cleaning in the Ironic Python Agent. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_8e691e28","line":80,"updated":"2016-06-07 14:25:55.000000000","message":"\"disk\" in name looks like general case, what about \"ata\", but OK as is, it described in help.","commit_id":"87e68256b6e90b5c7bc3618756b3843f5117fe60"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2231bca255982f852c485032fb3e67e1e163f2d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       \"deploy.shred_random_overwrite_interations is 0. This \""},{"line_number":78,"context_line":"                       \"option is only used if a device could not be ATA \""},{"line_number":79,"context_line":"                       \"Secure Erased. Defaults to True.\")),"},{"line_number":80,"context_line":"    cfg.BoolOpt(\u0027continue_if_disk_secure_erase_fails\u0027,"},{"line_number":81,"context_line":"                default\u003dFalse,"},{"line_number":82,"context_line":"                help\u003d_(\u0027Defines what to do if an ATA secure erase operation \u0027"},{"line_number":83,"context_line":"                       \u0027fails during cleaning in the Ironic Python Agent. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_d015ee9b","line":80,"in_reply_to":"7aa08908_8e691e28","updated":"2016-06-09 15:16:10.000000000","message":"I would prefer ata too, but it\u0027s OK as-is as well.","commit_id":"87e68256b6e90b5c7bc3618756b3843f5117fe60"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"710ef03a562ff48332b7f1c8d2aa117f5796b4cc","unresolved":false,"context_lines":[{"line_number":1688,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":1689,"context_line":"                \u0027agent_erase_devices_iterations\u0027), 2)"},{"line_number":1690,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":1691,"context_line":"                \u0027agent_continue_if_ata_erase_failed\u0027), True)"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi.delete_cleaning_ports\u0027,"},{"line_number":1694,"context_line":"                autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_55671fea","line":1691,"updated":"2016-04-21 14:48:03.000000000","message":"Isn\u0027t it the other way? self.assertEqual(True, task.node...)\n\nand why not just do task.node.driver_internal_info[\u0027agent_continue_if_ata_erase_failed\u0027]. It better be there.\n\nI know, this is similar to the line above.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"16896b9fae34e8d487af96ca195cccd9585fd54b","unresolved":false,"context_lines":[{"line_number":1688,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":1689,"context_line":"                \u0027agent_erase_devices_iterations\u0027), 2)"},{"line_number":1690,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":1691,"context_line":"                \u0027agent_continue_if_ata_erase_failed\u0027), True)"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi.delete_cleaning_ports\u0027,"},{"line_number":1694,"context_line":"                autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_790b2d2c","line":1691,"in_reply_to":"1a122d0e_55671fea","updated":"2016-04-21 17:46:37.000000000","message":"Ahh, your right, it should be flipped.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"46706ed7ba93800cb7eea7dcd18f9287351be6a4","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"            utils.agent_add_clean_params(task)"},{"line_number":1688,"context_line":"            self.assertEqual(task.node.driver_internal_info.get("},{"line_number":1689,"context_line":"                \u0027agent_erase_devices_iterations\u0027), 2)"},{"line_number":1690,"context_line":"            self.assertEqual(True, task.node.driver_internal_info.get("},{"line_number":1691,"context_line":"                \u0027agent_continue_if_ata_erase_failed\u0027))"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi.delete_cleaning_ports\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_00aa6b19","line":1690,"range":{"start_line":1690,"start_character":17,"end_line":1690,"end_character":28},"updated":"2016-04-22 06:41:49.000000000","message":"may be replaced with assertTrue(task.node.driver_internal_info.get(\u0027agent_continue_if_ata_erase_failed\u0027))","commit_id":"d0d11dbe084f153ee897ccf4d63faa34c2391ad1"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b1d2933cd9ac4f236324a85585c8074f683c1cb7","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"                \u0027agent_erase_devices_iterations\u0027))"},{"line_number":1725,"context_line":"            self.assertEqual(False, task.node.driver_internal_info.get("},{"line_number":1726,"context_line":"                \u0027agent_erase_devices_zeroize\u0027))"},{"line_number":1727,"context_line":"            self.assertEqual(True, task.node.driver_internal_info.get("},{"line_number":1728,"context_line":"                \u0027agent_continue_if_ata_erase_failed\u0027))"},{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi.delete_cleaning_ports\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_4eb8d6e5","line":1727,"updated":"2016-06-07 14:25:55.000000000","message":"Will be good if you change this to assertTrue as Vasil comments.","commit_id":"87e68256b6e90b5c7bc3618756b3843f5117fe60"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"018921045b7dcd11f6d16e18d0656e6495ff4fb5","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"                \u0027agent_erase_devices_iterations\u0027))"},{"line_number":1725,"context_line":"            self.assertEqual(False, task.node.driver_internal_info.get("},{"line_number":1726,"context_line":"                \u0027agent_erase_devices_zeroize\u0027))"},{"line_number":1727,"context_line":"            self.assertEqual(True, task.node.driver_internal_info.get("},{"line_number":1728,"context_line":"                \u0027agent_continue_if_ata_erase_failed\u0027))"},{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"    @mock.patch(\u0027ironic.dhcp.neutron.NeutronDHCPApi.delete_cleaning_ports\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_9a054a16","line":1727,"in_reply_to":"7aa08908_4eb8d6e5","updated":"2016-06-09 14:34:15.000000000","message":"There is actually a subtle difference between assertEqual and assertTrue.\n\nassertTrue(10) will pass, but assertEqual(True, 10) will fail.\n\nIf we really want to test for True/False (or 0/1) values, the assertEqual() is the way to go. I don\u0027t think our tests distinguish between those two though.\n\nSo I think this is good :)","commit_id":"87e68256b6e90b5c7bc3618756b3843f5117fe60"}],"releasenotes/notes/add-agent-erase-fallback-b07613a7042fe236.yaml":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fb717bd3e935b05f0ffa51ef03a221929bfbbda3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - A new configuration option"},{"line_number":4,"context_line":"    ``fallback_to_shred_upon_secure_erase_failure``, which"},{"line_number":5,"context_line":"    has a default value of False, has been added to allow"},{"line_number":6,"context_line":"    operators to inform the agent that it can fallback"},{"line_number":7,"context_line":"    from secure erase operations to disk shred operations."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a18252c_bf9ba9c8","line":4,"updated":"2016-04-13 10:40:28.000000000","message":"This is old name.","commit_id":"47ce2b3440a50e5528eaae0b10d23f4cd10552d6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"19de8d3174a7ce87d8afbec0842bf94872140337","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - A new configuration option"},{"line_number":4,"context_line":"    ``fallback_to_shred_upon_secure_erase_failure``, which"},{"line_number":5,"context_line":"    has a default value of False, has been added to allow"},{"line_number":6,"context_line":"    operators to inform the agent that it can fallback"},{"line_number":7,"context_line":"    from secure erase operations to disk shred operations."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a18252c_ea88b824","line":4,"in_reply_to":"5a18252c_bf9ba9c8","updated":"2016-04-13 12:41:37.000000000","message":"Fixed.","commit_id":"47ce2b3440a50e5528eaae0b10d23f4cd10552d6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cd78ac46b3ac57c91fc106c66ecf6927da3cd27e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - A new configuration option"},{"line_number":4,"context_line":"    ``continue_if_disk_secure_erase_fails``, which"},{"line_number":5,"context_line":"    has a default value of False, has been added to allow"},{"line_number":6,"context_line":"    operators to inform the agent that it can fallback"},{"line_number":7,"context_line":"    from secure erase operations to disk shred operations."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_32f559cb","line":4,"updated":"2016-04-21 14:44:03.000000000","message":"should mention that it is in [deploy] group.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cd78ac46b3ac57c91fc106c66ecf6927da3cd27e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - A new configuration option"},{"line_number":4,"context_line":"    ``continue_if_disk_secure_erase_fails``, which"},{"line_number":5,"context_line":"    has a default value of False, has been added to allow"},{"line_number":6,"context_line":"    operators to inform the agent that it can fallback"},{"line_number":7,"context_line":"    from secure erase operations to disk shred operations."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_f2d481be","line":6,"updated":"2016-04-21 14:44:03.000000000","message":"I\u0027m not sure I\u0027d mention \u0027allow operators\u0027. How about s/allow operators to//\n\nActually, how about s/added/added./\n\ns/To allow.../If set to True, if a secure erase operation fails in the agent, a disk shred operation will be performed./\n\nWell, that isn\u0027t great either. Oh well.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"16896b9fae34e8d487af96ca195cccd9585fd54b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - A new configuration option"},{"line_number":4,"context_line":"    ``continue_if_disk_secure_erase_fails``, which"},{"line_number":5,"context_line":"    has a default value of False, has been added to allow"},{"line_number":6,"context_line":"    operators to inform the agent that it can fallback"},{"line_number":7,"context_line":"    from secure erase operations to disk shred operations."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_340b7c7f","line":6,"in_reply_to":"1a122d0e_f2d481be","updated":"2016-04-21 17:46:37.000000000","message":"Done","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cd78ac46b3ac57c91fc106c66ecf6927da3cd27e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a122d0e_b2f1696d","line":8,"updated":"2016-04-21 14:44:03.000000000","message":"I think we tend to mention changes to configs in the \u0027Upgrade\u0027 section too.","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"16896b9fae34e8d487af96ca195cccd9585fd54b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a122d0e_d415e89b","line":8,"in_reply_to":"1a122d0e_b2f1696d","updated":"2016-04-21 17:46:37.000000000","message":"Done","commit_id":"177bc7521f9652a931de4229651fd32efcdc0f9e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"acbb6e77103eb043d3aead6cc07c9351192a6f3b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - A new configuration option"},{"line_number":4,"context_line":"    ``[deploy]continue_if_disk_secure_erase_fails``, which"},{"line_number":5,"context_line":"    has a default value of False, has been added. If set too"},{"line_number":6,"context_line":"    True, the Ironic Python Agent will revert to a disk shred"},{"line_number":7,"context_line":"    operation if a ATA secure erase operation fails. Under"},{"line_number":8,"context_line":"    normal circumstances, the failure of an ATA secure erase"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_1f165955","line":5,"updated":"2016-04-21 18:22:12.000000000","message":"s/too/to/","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"332ab0a2cba78a1f11bcd6d6293420d7bdc89063","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - A new configuration option"},{"line_number":4,"context_line":"    ``[deploy]continue_if_disk_secure_erase_fails``, which"},{"line_number":5,"context_line":"    has a default value of False, has been added. If set too"},{"line_number":6,"context_line":"    True, the Ironic Python Agent will revert to a disk shred"},{"line_number":7,"context_line":"    operation if a ATA secure erase operation fails. Under"},{"line_number":8,"context_line":"    normal circumstances, the failure of an ATA secure erase"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_ba05b315","line":5,"in_reply_to":"1a122d0e_1f165955","updated":"2016-04-21 18:50:51.000000000","message":"Done","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"acbb6e77103eb043d3aead6cc07c9351192a6f3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    ``[deploy]continue_if_disk_secure_erase_fails``, which"},{"line_number":5,"context_line":"    has a default value of False, has been added. If set too"},{"line_number":6,"context_line":"    True, the Ironic Python Agent will revert to a disk shred"},{"line_number":7,"context_line":"    operation if a ATA secure erase operation fails. Under"},{"line_number":8,"context_line":"    normal circumstances, the failure of an ATA secure erase"},{"line_number":9,"context_line":"    operation results in the node being put in ``clean fail``"},{"line_number":10,"context_line":"    state."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_5f08d12d","line":7,"updated":"2016-04-21 18:22:12.000000000","message":"s/a/an/","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"332ab0a2cba78a1f11bcd6d6293420d7bdc89063","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    ``[deploy]continue_if_disk_secure_erase_fails``, which"},{"line_number":5,"context_line":"    has a default value of False, has been added. If set too"},{"line_number":6,"context_line":"    True, the Ironic Python Agent will revert to a disk shred"},{"line_number":7,"context_line":"    operation if a ATA secure erase operation fails. Under"},{"line_number":8,"context_line":"    normal circumstances, the failure of an ATA secure erase"},{"line_number":9,"context_line":"    operation results in the node being put in ``clean fail``"},{"line_number":10,"context_line":"    state."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_5a08df2d","line":7,"in_reply_to":"1a122d0e_5f08d12d","updated":"2016-04-21 18:50:51.000000000","message":"Done","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"acbb6e77103eb043d3aead6cc07c9351192a6f3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    True, the Ironic Python Agent will revert to a disk shred"},{"line_number":7,"context_line":"    operation if a ATA secure erase operation fails. Under"},{"line_number":8,"context_line":"    normal circumstances, the failure of an ATA secure erase"},{"line_number":9,"context_line":"    operation results in the node being put in ``clean fail``"},{"line_number":10,"context_line":"    state."},{"line_number":11,"context_line":"upgrades:"},{"line_number":12,"context_line":"  - A new configuration option"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_fafd6b09","line":9,"updated":"2016-04-21 18:22:12.000000000","message":"same nit. s/clean fail/clean failed/","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"332ab0a2cba78a1f11bcd6d6293420d7bdc89063","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    True, the Ironic Python Agent will revert to a disk shred"},{"line_number":7,"context_line":"    operation if a ATA secure erase operation fails. Under"},{"line_number":8,"context_line":"    normal circumstances, the failure of an ATA secure erase"},{"line_number":9,"context_line":"    operation results in the node being put in ``clean fail``"},{"line_number":10,"context_line":"    state."},{"line_number":11,"context_line":"upgrades:"},{"line_number":12,"context_line":"  - A new configuration option"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_3a11a35e","line":9,"in_reply_to":"1a122d0e_fafd6b09","updated":"2016-04-21 18:50:51.000000000","message":"Done","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"acbb6e77103eb043d3aead6cc07c9351192a6f3b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    has a default value of False, has been added. The default"},{"line_number":15,"context_line":"    setting represents the standard behavior of the Ironic"},{"line_number":16,"context_line":"    Python Agent during a cleaning failure action upon an"},{"line_number":17,"context_line":"    upgrade is required."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_1a24a7ad","line":17,"updated":"2016-04-21 18:22:12.000000000","message":"There\u0027s something odd about this last sentence. I\u0027m not sure what you\u0027re trying to \u0027say\u0027.","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"332ab0a2cba78a1f11bcd6d6293420d7bdc89063","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    has a default value of False, has been added. The default"},{"line_number":15,"context_line":"    setting represents the standard behavior of the Ironic"},{"line_number":16,"context_line":"    Python Agent during a cleaning failure action upon an"},{"line_number":17,"context_line":"    upgrade is required."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_8e3d1cbe","line":17,"in_reply_to":"1a122d0e_1a24a7ad","updated":"2016-04-21 18:50:51.000000000","message":"Reduced the statement to the minimum required instead.","commit_id":"ad90755d71b2ad1075e0a5ca21e20af04e8d7d70"}]}
