)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c022b4a24b5c95a37c956a072af862a7c13f8f45","unresolved":false,"context_lines":[{"line_number":10,"context_line":"before the disk is exposed through iscsi. Otherwise this disk"},{"line_number":11,"context_line":"partition can create a conflict during the grub installation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"start_iscsi_target() has now a new paramter wipe_disk_metadata to"},{"line_number":14,"context_line":"request the agent to wipe the disk before exposing it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"References:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a122d0e_4bf4a086","line":13,"range":{"start_line":13,"start_character":34,"end_line":13,"end_character":43},"updated":"2016-04-21 15:38:16.000000000","message":"s/paramter/parameter/","commit_id":"03a068b7ac7c3c808467978329111a25d00df5a9"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"0aaaa79c7aa980e8acc02ed65655b63edbeb78cf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"before the disk is exposed through iscsi. Otherwise this disk"},{"line_number":11,"context_line":"partition can create a conflict during the grub installation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"start_iscsi_target() has now a new paramter wipe_disk_metadata to"},{"line_number":14,"context_line":"request the agent to wipe the disk before exposing it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"References:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a122d0e_c561bcd5","line":13,"range":{"start_line":13,"start_character":34,"end_line":13,"end_character":43},"in_reply_to":"1a122d0e_4bf4a086","updated":"2016-04-21 16:06:09.000000000","message":"Done","commit_id":"03a068b7ac7c3c808467978329111a25d00df5a9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c022b4a24b5c95a37c956a072af862a7c13f8f45","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"start_iscsi_target() has now a new paramter wipe_disk_metadata to"},{"line_number":14,"context_line":"request the agent to wipe the disk before exposing it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"References:"},{"line_number":17,"context_line":"- IPA: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf"},{"line_number":18,"context_line":"- ironic-lib: 042aa9ab5a27e251c8fb2f1855695cf5e791ecf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a122d0e_069d7f59","line":15,"updated":"2016-04-21 15:38:16.000000000","message":"we should specify when wipe_disk_metadata is set. And add it to release note.","commit_id":"03a068b7ac7c3c808467978329111a25d00df5a9"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"0aaaa79c7aa980e8acc02ed65655b63edbeb78cf","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"start_iscsi_target() has now a new paramter wipe_disk_metadata to"},{"line_number":14,"context_line":"request the agent to wipe the disk before exposing it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"References:"},{"line_number":17,"context_line":"- IPA: Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf"},{"line_number":18,"context_line":"- ironic-lib: 042aa9ab5a27e251c8fb2f1855695cf5e791ecf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a122d0e_a55e4010","line":15,"in_reply_to":"1a122d0e_069d7f59","updated":"2016-04-21 16:06:09.000000000","message":"Done","commit_id":"03a068b7ac7c3c808467978329111a25d00df5a9"}],"ironic/drivers/modules/agent_client.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"582185e6b8ac266e81df97e9e3cef1dca2042903","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                             params\u003dparams,"},{"line_number":131,"context_line":"                             wait\u003dwait)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start_iscsi_target(self, node, iqn, wipe_disk_metadata\u003dFalse):"},{"line_number":134,"context_line":"        \"\"\"Expose the node\u0027s disk as an ISCSI target."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param iqn: iSCSI target IQN"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_abab98d5","line":133,"updated":"2016-04-08 20:44:56.000000000","message":"nit/question; Is there a reason we wouldn\u0027t want this default true? Doesn\u0027t look like we ever call it with any other setting.","commit_id":"38f588db534e10c69d56a4622fc2f2063aba8285"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"b0c2f42fedd03cf130bf7ef24f9fcc7312a370d1","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                             params\u003dparams,"},{"line_number":131,"context_line":"                             wait\u003dwait)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start_iscsi_target(self, node, iqn, wipe_disk_metadata\u003dFalse):"},{"line_number":134,"context_line":"        \"\"\"Expose the node\u0027s disk as an ISCSI target."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        :param iqn: iSCSI target IQN"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_c653636b","line":133,"in_reply_to":"9a061dce_abab98d5","updated":"2016-04-08 21:32:11.000000000","message":"This was the initial idea of I39637e22c344703ad48fc271f6f866aa018bbdd1 but we may also want to use start_iscsi_target just to access/read the remote disk without wiping it.","commit_id":"38f588db534e10c69d56a4622fc2f2063aba8285"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"59ba02ff5d0ce30b98d1e1f3040949ade19b82db","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        signature."},{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        params \u003d {\u0027iqn\u0027: iqn,"},{"line_number":142,"context_line":"                  \u0027wipe_disk_metadata\u0027: False}"},{"line_number":143,"context_line":"        return self._command(node\u003dnode,"},{"line_number":144,"context_line":"                             method\u003d\u0027iscsi.start_iscsi_target\u0027,"},{"line_number":145,"context_line":"                             params\u003dparams,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_eb1630f0","line":142,"updated":"2016-04-08 20:51:14.000000000","message":"This will not read the passed parameter.","commit_id":"38f588db534e10c69d56a4622fc2f2063aba8285"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"b0c2f42fedd03cf130bf7ef24f9fcc7312a370d1","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        signature."},{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        params \u003d {\u0027iqn\u0027: iqn,"},{"line_number":142,"context_line":"                  \u0027wipe_disk_metadata\u0027: False}"},{"line_number":143,"context_line":"        return self._command(node\u003dnode,"},{"line_number":144,"context_line":"                             method\u003d\u0027iscsi.start_iscsi_target\u0027,"},{"line_number":145,"context_line":"                             params\u003dparams,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_0620bbf6","line":142,"in_reply_to":"9a061dce_eb1630f0","updated":"2016-04-08 21:32:11.000000000","message":"Rofl... thank you Mathieu.","commit_id":"38f588db534e10c69d56a4622fc2f2063aba8285"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"829a4b4c34ce6c5cc5babc516ee3cb132ac3215c","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        :param iqn: iSCSI target IQN"},{"line_number":138,"context_line":"        :param portal_port: iSCSI portal port"},{"line_number":139,"context_line":"        :param wipe_disk_metadata: True if the agent should wipe first wipe"},{"line_number":140,"context_line":"        the disk magic strings like the partition table, RAID or filesystem"},{"line_number":141,"context_line":"        signature."},{"line_number":142,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_20ccc734","line":139,"range":{"start_line":139,"start_character":59,"end_line":139,"end_character":75},"updated":"2016-04-16 11:43:32.000000000","message":"Some typo here. \ns/ \u0027wipe first wipe\u0027 / \u0027first wipe\u0027","commit_id":"9c6397c97ec8ffd7085560e046216ca5b7b6d78c"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"d8d872b9dc949f2e82123d611ac395054b2919a4","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        :param iqn: iSCSI target IQN"},{"line_number":138,"context_line":"        :param portal_port: iSCSI portal port"},{"line_number":139,"context_line":"        :param wipe_disk_metadata: True if the agent should wipe first wipe"},{"line_number":140,"context_line":"        the disk magic strings like the partition table, RAID or filesystem"},{"line_number":141,"context_line":"        signature."},{"line_number":142,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_83b68588","line":139,"range":{"start_line":139,"start_character":59,"end_line":139,"end_character":75},"in_reply_to":"1a122d0e_20ccc734","updated":"2016-04-16 14:05:07.000000000","message":"Oops, thanks.","commit_id":"9c6397c97ec8ffd7085560e046216ca5b7b6d78c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c022b4a24b5c95a37c956a072af862a7c13f8f45","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                           portal_port\u003d3260, wipe_disk_metadata\u003dFalse):"},{"line_number":135,"context_line":"        \"\"\"Expose the node\u0027s disk as an ISCSI target."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        :param iqn: iSCSI target IQN"},{"line_number":138,"context_line":"        :param portal_port: iSCSI portal port"},{"line_number":139,"context_line":"        :param wipe_disk_metadata: True if the agent should wipe first the"},{"line_number":140,"context_line":"        disk magic strings like the partition table, RAID or filesystem"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_2b59648f","line":137,"updated":"2016-04-21 15:38:16.000000000","message":"please add param node,iqn to docstring","commit_id":"03a068b7ac7c3c808467978329111a25d00df5a9"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"96ebf15ea60bb4dfe77d2a59ab94af4e12169895","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    portal_port \u003d iscsi_options[\u0027iscsi_portal_port\u0027]"},{"line_number":345,"context_line":"    result \u003d agent_client.start_iscsi_target(node, iqn,"},{"line_number":346,"context_line":"                                             portal_port,"},{"line_number":347,"context_line":"                                             wipe_disk_metadata\u003dTrue)"},{"line_number":348,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":349,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""},{"line_number":350,"context_line":"                 \"node %(node)s. Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_a84e1f94","line":347,"updated":"2016-04-15 12:20:14.000000000","message":"Should not be wiped if we do delploy with preserve ephemeral https://github.com/openstack/ironic-lib/blob/master/ironic_lib/disk_utils.py#L422","commit_id":"2a31fc8a598fcffafb49d07017d11632eeaf2f73"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"db412f2a2a6e14b93c1eb9095280494e0ba7ea6f","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    portal_port \u003d iscsi_options[\u0027iscsi_portal_port\u0027]"},{"line_number":345,"context_line":"    result \u003d agent_client.start_iscsi_target(node, iqn,"},{"line_number":346,"context_line":"                                             portal_port,"},{"line_number":347,"context_line":"                                             wipe_disk_metadata\u003dTrue)"},{"line_number":348,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":349,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""},{"line_number":350,"context_line":"                 \"node %(node)s. Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_5a861fba","line":347,"in_reply_to":"1a122d0e_525e1546","updated":"2016-04-15 16:59:44.000000000","message":"++ this is exactly what happens in work_on_disk:\n\n     commit \u003d not preserve_ephemeral\n     # now if we are committing the changes to disk clean first.\n     if commit:\n         destroy_disk_metadata(dev, node_uuid)","commit_id":"2a31fc8a598fcffafb49d07017d11632eeaf2f73"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"b6f75a86ae6f345d07dbe1ff2a623c162006ef34","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    portal_port \u003d iscsi_options[\u0027iscsi_portal_port\u0027]"},{"line_number":345,"context_line":"    result \u003d agent_client.start_iscsi_target(node, iqn,"},{"line_number":346,"context_line":"                                             portal_port,"},{"line_number":347,"context_line":"                                             wipe_disk_metadata\u003dTrue)"},{"line_number":348,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":349,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""},{"line_number":350,"context_line":"                 \"node %(node)s. Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_df87ce10","line":347,"in_reply_to":"1a122d0e_a84e1f94","updated":"2016-04-15 13:01:47.000000000","message":"only the root disk is wipe by wipe_disk_metadata.","commit_id":"2a31fc8a598fcffafb49d07017d11632eeaf2f73"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"56121ebe3c2ecf3867b474fd3a284b73a5a53200","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    portal_port \u003d iscsi_options[\u0027iscsi_portal_port\u0027]"},{"line_number":345,"context_line":"    result \u003d agent_client.start_iscsi_target(node, iqn,"},{"line_number":346,"context_line":"                                             portal_port,"},{"line_number":347,"context_line":"                                             wipe_disk_metadata\u003dTrue)"},{"line_number":348,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":349,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""},{"line_number":350,"context_line":"                 \"node %(node)s. Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_525e1546","line":347,"in_reply_to":"1a122d0e_df87ce10","updated":"2016-04-15 13:30:44.000000000","message":"Ephemeral partition placed on the same device as root partition https://github.com/openstack/ironic-lib/blob/master/ironic_lib/disk_utils.py#L393","commit_id":"2a31fc8a598fcffafb49d07017d11632eeaf2f73"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"2971af696c056743427ec8e0571848ddc9eb9204","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    portal_port \u003d iscsi_options[\u0027iscsi_portal_port\u0027]"},{"line_number":347,"context_line":"    result \u003d agent_client.start_iscsi_target("},{"line_number":348,"context_line":"        node, iqn,"},{"line_number":349,"context_line":"        portal_port,"},{"line_number":350,"context_line":"        wipe_disk_metadata\u003dwipe_disk_metadata)"},{"line_number":351,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":352,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_b4d290d0","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":20},"updated":"2016-04-19 05:21:42.000000000","message":"oh this should be \u0027portal_port\u003dportal_port\u0027 too","commit_id":"323452a978607825a9d2393cdc53bb641b4af8ee"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"8f42271b0fa408bfe4076dfa36dbdc4f8d57bed3","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    node \u003d task.node"},{"line_number":341,"context_line":"    iscsi_options \u003d build_deploy_ramdisk_options(node)"},{"line_number":342,"context_line":"    i_info \u003d deploy_utils.parse_instance_info(node)"},{"line_number":343,"context_line":"    wipe_disk_metadata \u003d not i_info[\u0027preserve_ephemeral\u0027]"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    iqn \u003d iscsi_options[\u0027iscsi_target_iqn\u0027]"},{"line_number":346,"context_line":"    portal_port \u003d iscsi_options[\u0027iscsi_portal_port\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_87e5c4a9","line":343,"range":{"start_line":343,"start_character":4,"end_line":343,"end_character":22},"updated":"2016-04-23 06:38:50.000000000","message":"should this be only done when automated_clean disabled? before deploying we already cleaned the disk by default.","commit_id":"1a4bf23ce5773726fc776369b483254d13d54f2b"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"1519d7108543398b549047d9ef6c06989a1bad7f","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    node \u003d task.node"},{"line_number":341,"context_line":"    iscsi_options \u003d build_deploy_ramdisk_options(node)"},{"line_number":342,"context_line":"    i_info \u003d deploy_utils.parse_instance_info(node)"},{"line_number":343,"context_line":"    wipe_disk_metadata \u003d not i_info[\u0027preserve_ephemeral\u0027]"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    iqn \u003d iscsi_options[\u0027iscsi_target_iqn\u0027]"},{"line_number":346,"context_line":"    portal_port \u003d iscsi_options[\u0027iscsi_portal_port\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_2872ae49","line":343,"range":{"start_line":343,"start_character":4,"end_line":343,"end_character":22},"in_reply_to":"1a122d0e_2a20f09a","updated":"2016-04-25 02:42:11.000000000","message":"sorry for the -1 for a question here :)\n\njust want to clarify, with automated cleaning, new nodes will also be cleaned when going from manageable -\u003e available state before the first workload is assigned, but I agree that wipefs is really fast.","commit_id":"1a4bf23ce5773726fc776369b483254d13d54f2b"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"df8d4d6e303728d8db92f8e1a63d9590da66b2ec","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    node \u003d task.node"},{"line_number":341,"context_line":"    iscsi_options \u003d build_deploy_ramdisk_options(node)"},{"line_number":342,"context_line":"    i_info \u003d deploy_utils.parse_instance_info(node)"},{"line_number":343,"context_line":"    wipe_disk_metadata \u003d not i_info[\u0027preserve_ephemeral\u0027]"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    iqn \u003d iscsi_options[\u0027iscsi_target_iqn\u0027]"},{"line_number":346,"context_line":"    portal_port \u003d iscsi_options[\u0027iscsi_portal_port\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_2a20f09a","line":343,"range":{"start_line":343,"start_character":4,"end_line":343,"end_character":22},"in_reply_to":"1a122d0e_87e5c4a9","updated":"2016-04-23 15:58:39.000000000","message":"No because this can be a new ironic node that was used for something else previously. In this case, it may still have an existing partition table on the system disk.\n\nThe wipefs is also really fast and having this kind of condition would make the code more complex without real benefit IMO.\n\nCan you please avoid the use of a -1 just for a question?","commit_id":"1a4bf23ce5773726fc776369b483254d13d54f2b"}],"releasenotes/notes/wipe-disk-before-deployment-0a8b9cede4a659e9.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75361226560bf82a1ec2a0967921c93815deb016","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - Fix a bug that was bringing grub installation failure. If the disk"},{"line_number":4,"context_line":"    was already coming with a partition table, the conductor was not able"},{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_ab16e652","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"updated":"2016-04-22 13:56:41.000000000","message":"Issues is reserved for known issues in the release.   This should go under fixes in the release notes.","commit_id":"6d64c63e2ea3f74bddbfb31a994ef0effdc222d0"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"98f34bf6b40d731c4fb4bd7c3cf0e4bb00a930bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - Fix a bug that was bringing grub installation failure. If the disk"},{"line_number":4,"context_line":"    was already coming with a partition table, the conductor was not able"},{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_77814d4d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"in_reply_to":"1a122d0e_ab16e652","updated":"2016-04-22 14:48:36.000000000","message":"Done","commit_id":"6d64c63e2ea3f74bddbfb31a994ef0effdc222d0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75361226560bf82a1ec2a0967921c93815deb016","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - Fix a bug that was bringing grub installation failure. If the disk"},{"line_number":4,"context_line":"    was already coming with a partition table, the conductor was not able"},{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installation"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_2be2d69f","line":3,"range":{"start_line":3,"start_character":23,"end_line":3,"end_character":31},"updated":"2016-04-22 13:56:41.000000000","message":"nit s/Fix/Fixed/\nnit: s/bringing/causing/","commit_id":"6d64c63e2ea3f74bddbfb31a994ef0effdc222d0"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"98f34bf6b40d731c4fb4bd7c3cf0e4bb00a930bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - Fix a bug that was bringing grub installation failure. If the disk"},{"line_number":4,"context_line":"    was already coming with a partition table, the conductor was not able"},{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installation"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_17b6193d","line":3,"range":{"start_line":3,"start_character":23,"end_line":3,"end_character":31},"in_reply_to":"1a122d0e_2be2d69f","updated":"2016-04-22 14:48:36.000000000","message":"Done","commit_id":"6d64c63e2ea3f74bddbfb31a994ef0effdc222d0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75361226560bf82a1ec2a0967921c93815deb016","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Fix a bug that was bringing grub installation failure. If the disk"},{"line_number":4,"context_line":"    was already coming with a partition table, the conductor was not able"},{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installation"},{"line_number":7,"context_line":"    with disabled automated_clean."},{"line_number":8,"context_line":"    Now, disk without preserve_ephemeral are cleaned up before new deployment."},{"line_number":9,"context_line":"    See https://bugs.launchpad.net/ironic-lib/+bug/1550604"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_cb9ec206","line":6,"updated":"2016-04-22 13:56:41.000000000","message":"nit: s/installation/installations/","commit_id":"6d64c63e2ea3f74bddbfb31a994ef0effdc222d0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75361226560bf82a1ec2a0967921c93815deb016","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    was already coming with a partition table, the conductor was not able"},{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installation"},{"line_number":7,"context_line":"    with disabled automated_clean."},{"line_number":8,"context_line":"    Now, disk without preserve_ephemeral are cleaned up before new deployment."},{"line_number":9,"context_line":"    See https://bugs.launchpad.net/ironic-lib/+bug/1550604"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_2b7e56ae","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":33},"updated":"2016-04-22 13:56:41.000000000","message":"Perhaps \"with automated_clean disabled in the configuration.\"","commit_id":"6d64c63e2ea3f74bddbfb31a994ef0effdc222d0"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"98f34bf6b40d731c4fb4bd7c3cf0e4bb00a930bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    was already coming with a partition table, the conductor was not able"},{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installation"},{"line_number":7,"context_line":"    with disabled automated_clean."},{"line_number":8,"context_line":"    Now, disk without preserve_ephemeral are cleaned up before new deployment."},{"line_number":9,"context_line":"    See https://bugs.launchpad.net/ironic-lib/+bug/1550604"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_37b9952f","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":33},"in_reply_to":"1a122d0e_2b7e56ae","updated":"2016-04-22 14:48:36.000000000","message":"Done","commit_id":"6d64c63e2ea3f74bddbfb31a994ef0effdc222d0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"75361226560bf82a1ec2a0967921c93815deb016","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installation"},{"line_number":7,"context_line":"    with disabled automated_clean."},{"line_number":8,"context_line":"    Now, disk without preserve_ephemeral are cleaned up before new deployment."},{"line_number":9,"context_line":"    See https://bugs.launchpad.net/ironic-lib/+bug/1550604"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_eb73bee5","line":8,"range":{"start_line":8,"start_character":45,"end_line":8,"end_character":52},"updated":"2016-04-22 13:56:41.000000000","message":"Instead of saying they are cleaned, which they are not, the metadata is purged, so we should likely reflect that instead of stating cleaned, implying the cleaning state.","commit_id":"6d64c63e2ea3f74bddbfb31a994ef0effdc222d0"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"98f34bf6b40d731c4fb4bd7c3cf0e4bb00a930bd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installation"},{"line_number":7,"context_line":"    with disabled automated_clean."},{"line_number":8,"context_line":"    Now, disk without preserve_ephemeral are cleaned up before new deployment."},{"line_number":9,"context_line":"    See https://bugs.launchpad.net/ironic-lib/+bug/1550604"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_d7ab01d5","line":8,"range":{"start_line":8,"start_character":45,"end_line":8,"end_character":52},"in_reply_to":"1a122d0e_eb73bee5","updated":"2016-04-22 14:48:36.000000000","message":"Done","commit_id":"6d64c63e2ea3f74bddbfb31a994ef0effdc222d0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"013e3c6bc0c8df99f1c0699cb4321d3ad290af7c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed a bug that was causing grub installation failure. If the disk"},{"line_number":4,"context_line":"    was already coming with a partition table, the conductor was not able"},{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installations"},{"line_number":7,"context_line":"    with automated_clean disabled in the configuration."},{"line_number":8,"context_line":"    Now, disk without preserve_ephemeral are purge before new deployment."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a122d0e_9bec13f5","line":5,"range":{"start_line":5,"start_character":52,"end_line":5,"end_character":55},"updated":"2016-04-22 15:08:00.000000000","message":"nit: s/was/would/","commit_id":"aee84be44857ee27a276bd1dc0e80484ea5059f2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"013e3c6bc0c8df99f1c0699cb4321d3ad290af7c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installations"},{"line_number":7,"context_line":"    with automated_clean disabled in the configuration."},{"line_number":8,"context_line":"    Now, disk without preserve_ephemeral are purge before new deployment."},{"line_number":9,"context_line":"    See https://bugs.launchpad.net/ironic-lib/+bug/1550604"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a122d0e_7ba3f79e","line":8,"updated":"2016-04-22 15:08:00.000000000","message":"nit s/disk/a instance disk/","commit_id":"aee84be44857ee27a276bd1dc0e80484ea5059f2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"013e3c6bc0c8df99f1c0699cb4321d3ad290af7c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    to wipe it properly and the new partition table was conflicting with"},{"line_number":6,"context_line":"    the old one. The issue was only impacting new nodes and installations"},{"line_number":7,"context_line":"    with automated_clean disabled in the configuration."},{"line_number":8,"context_line":"    Now, disk without preserve_ephemeral are purge before new deployment."},{"line_number":9,"context_line":"    See https://bugs.launchpad.net/ironic-lib/+bug/1550604"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a122d0e_dbb84bca","line":8,"range":{"start_line":8,"start_character":41,"end_line":8,"end_character":44},"updated":"2016-04-22 15:08:00.000000000","message":"s/are/is/\ns/purge/purged/","commit_id":"aee84be44857ee27a276bd1dc0e80484ea5059f2"}]}
