)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e50fe84d10252bb5c0f47ee0a924854379fdc5e8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add new portal_port option for agent client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IPA supported iSCSI portal port customization by ic83a968997 commit."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"With this patch, we added new portal_port argument into"},{"line_number":12,"context_line":"agent_client.start_iscsi_target() method to pass iSCSI portal"},{"line_number":13,"context_line":"port to IPA side. And add new configuration as below:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a1b2928_600c1b43","line":10,"updated":"2016-04-11 07:02:06.000000000","message":"We can combine these two statements in to a single paragraph.","commit_id":"7c87a161815288d69c7d04e5155d7d5b2dccdc58"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e50fe84d10252bb5c0f47ee0a924854379fdc5e8","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"With this patch, we added new portal_port argument into"},{"line_number":12,"context_line":"agent_client.start_iscsi_target() method to pass iSCSI portal"},{"line_number":13,"context_line":"port to IPA side. And add new configuration as below:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"CONF.iscsi.portal_port"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ia1515cbd6723a965e362a7dfa0b58077194401f3"},{"line_number":18,"context_line":"Partial-Bug: #1523829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a1b2928_13a5c303","line":15,"range":{"start_line":13,"start_character":17,"end_line":15,"end_character":22},"updated":"2016-04-11 07:02:06.000000000","message":"Would be better if rephrased as:\n\"This patch also adds CONF.iscsi.portal_port as new configuration parameter.\"","commit_id":"7c87a161815288d69c7d04e5155d7d5b2dccdc58"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"511a5f3e96aa75c047a9331740b116db90dac6ca","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF.iscsi.portal_port"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"NOTE: Once these Centralize config options patches are merged, this"},{"line_number":19,"context_line":"new iscsi option will be moved to ironic/conf/issi.py in a following"},{"line_number":20,"context_line":"patch."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Reference:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a1b2928_30d89153","line":19,"updated":"2016-04-11 16:46:59.000000000","message":"nit - iscsi.py","commit_id":"8be6ab7b342dee25aae5dcb3546454b342ec9765"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"511a5f3e96aa75c047a9331740b116db90dac6ca","unresolved":false,"context_lines":[{"line_number":23,"context_line":"https://review.openstack.org/#/c/272420/"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ia1515cbd6723a965e362a7dfa0b58077194401f3"},{"line_number":26,"context_line":"Partial-Bug: #1523829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a1b2928_d07cbd22","line":26,"updated":"2016-04-11 16:46:59.000000000","message":"is it closes-bug now? And here you add the ability to set it in config, but the bug description says about API request, could you clarify this?","commit_id":"8be6ab7b342dee25aae5dcb3546454b342ec9765"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9a1a6d5079ca960ad8c36d7fca7973882e6cc708","unresolved":false,"context_lines":[{"line_number":23,"context_line":"https://review.openstack.org/#/c/272420/"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ia1515cbd6723a965e362a7dfa0b58077194401f3"},{"line_number":26,"context_line":"Partial-Bug: #1523829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_ea5c8bef","line":26,"in_reply_to":"7a1b2928_d07cbd22","updated":"2016-04-12 02:19:55.000000000","message":"Done","commit_id":"8be6ab7b342dee25aae5dcb3546454b342ec9765"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f34b84294d3de46a44162d4e2e124d28feda2cd7","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"NOTE: Once these Centralize config options patches are merged, this"},{"line_number":19,"context_line":"new iscsi option will be moved to ironic/conf/iscsi.py in a following"},{"line_number":20,"context_line":"patch."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Reference:"},{"line_number":23,"context_line":"https://review.openstack.org/#/c/272420/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a18252c_49a5c302","line":20,"updated":"2016-04-12 09:17:38.000000000","message":"I think this note is a bit out of place, they are two separated work (oslo-config and portal port), I would delete it just to avoid confusion.","commit_id":"ade8b6033f18d721c1d1093371847cdcce455fa5"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"05e9f47055aa79d0a4975c858f463aa1be194ab1","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"NOTE: Once these Centralize config options patches are merged, this"},{"line_number":19,"context_line":"new iscsi option will be moved to ironic/conf/iscsi.py in a following"},{"line_number":20,"context_line":"patch."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Reference:"},{"line_number":23,"context_line":"https://review.openstack.org/#/c/272420/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a18252c_e015949b","line":20,"in_reply_to":"5a18252c_49a5c302","updated":"2016-04-13 01:57:50.000000000","message":"Done","commit_id":"ade8b6033f18d721c1d1093371847cdcce455fa5"}],"ironic/drivers/modules/agent_client.py":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9123537d97ca3e6602b7c56ad08122beb4d65532","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                             params\u003dparams,"},{"line_number":131,"context_line":"                             wait\u003dwait)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start_iscsi_target(self, node, iqn, portal_port):"},{"line_number":134,"context_line":"        \"\"\"Expose the node\u0027s disk as an ISCSI target.\"\"\""},{"line_number":135,"context_line":"        params \u003d {\u0027iqn\u0027: iqn, \u0027portal_port\u0027: portal_port}"},{"line_number":136,"context_line":"        return self._command(node\u003dnode,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_466f40c5","line":133,"range":{"start_line":133,"start_character":44,"end_line":133,"end_character":55},"updated":"2016-04-13 03:03:48.000000000","message":"better to make this new param as optional to keep backward compatible.","commit_id":"5a086e44d75cc6148f601ccec3d650ea972c47d9"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"3b134b478b1df6a5d2f0df43afa8905eeba9ee54","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                             params\u003dparams,"},{"line_number":131,"context_line":"                             wait\u003dwait)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start_iscsi_target(self, node, iqn, portal_port):"},{"line_number":134,"context_line":"        \"\"\"Expose the node\u0027s disk as an ISCSI target.\"\"\""},{"line_number":135,"context_line":"        params \u003d {\u0027iqn\u0027: iqn, \u0027portal_port\u0027: portal_port}"},{"line_number":136,"context_line":"        return self._command(node\u003dnode,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_cc308f04","line":133,"range":{"start_line":133,"start_character":44,"end_line":133,"end_character":55},"in_reply_to":"5a18252c_466f40c5","updated":"2016-04-13 07:43:27.000000000","message":"Good idea.","commit_id":"5a086e44d75cc6148f601ccec3d650ea972c47d9"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"511a5f3e96aa75c047a9331740b116db90dac6ca","unresolved":false,"context_lines":[{"line_number":78,"context_line":"]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"iscsi_opts \u003d ["},{"line_number":81,"context_line":"    cfg.PortOpt(\u0027portal_port\u0027,"},{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027iSCSI portal port.\u0027)),"},{"line_number":84,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a1b2928_f069f98c","line":81,"updated":"2016-04-11 16:46:59.000000000","message":"Please regenerate config","commit_id":"8be6ab7b342dee25aae5dcb3546454b342ec9765"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9a1a6d5079ca960ad8c36d7fca7973882e6cc708","unresolved":false,"context_lines":[{"line_number":78,"context_line":"]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"iscsi_opts \u003d ["},{"line_number":81,"context_line":"    cfg.PortOpt(\u0027portal_port\u0027,"},{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027iSCSI portal port.\u0027)),"},{"line_number":84,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_aa2a937c","line":81,"in_reply_to":"7a1b2928_f069f98c","updated":"2016-04-12 02:19:55.000000000","message":"Done","commit_id":"8be6ab7b342dee25aae5dcb3546454b342ec9765"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"511a5f3e96aa75c047a9331740b116db90dac6ca","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"iscsi_opts \u003d ["},{"line_number":81,"context_line":"    cfg.PortOpt(\u0027portal_port\u0027,"},{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027iSCSI portal port.\u0027)),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a1b2928_90f3650a","line":82,"updated":"2016-04-11 16:46:59.000000000","message":"There already is a default on the agent side, why do we need it here?","commit_id":"8be6ab7b342dee25aae5dcb3546454b342ec9765"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9a1a6d5079ca960ad8c36d7fca7973882e6cc708","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"iscsi_opts \u003d ["},{"line_number":81,"context_line":"    cfg.PortOpt(\u0027portal_port\u0027,"},{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027iSCSI portal port.\u0027)),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a18252c_6a8d1b7b","line":82,"in_reply_to":"7a1b2928_90f3650a","updated":"2016-04-12 02:19:55.000000000","message":"Good point, IMO, we have to set default value for these options in conf, so, do you mean we need remove this default value, or did not pass the default 3260 to start_iscsi_target call?","commit_id":"8be6ab7b342dee25aae5dcb3546454b342ec9765"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f34b84294d3de46a44162d4e2e124d28feda2cd7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"iscsi_opts \u003d ["},{"line_number":81,"context_line":"    cfg.PortOpt(\u0027portal_port\u0027,"},{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027iSCSI portal port, used for setting IPA iSCSI \u0027"},{"line_number":84,"context_line":"                       \u0027target portal port number.\u0027)),"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a18252c_a3e4783b","line":84,"range":{"start_line":83,"start_character":43,"end_line":84,"end_character":49},"updated":"2016-04-12 09:17:38.000000000","message":"I think this bits should explain what a portal port is instead of just saying it\u0027s the \"portal port number\" twice. What about the following: \"The port number on which the iSCSI portal listens for incoming connections.\"","commit_id":"ade8b6033f18d721c1d1093371847cdcce455fa5"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"05e9f47055aa79d0a4975c858f463aa1be194ab1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"iscsi_opts \u003d ["},{"line_number":81,"context_line":"    cfg.PortOpt(\u0027portal_port\u0027,"},{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027iSCSI portal port, used for setting IPA iSCSI \u0027"},{"line_number":84,"context_line":"                       \u0027target portal port number.\u0027)),"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a18252c_60222403","line":84,"range":{"start_line":83,"start_character":43,"end_line":84,"end_character":49},"in_reply_to":"5a18252c_a3e4783b","updated":"2016-04-13 01:57:50.000000000","message":"Done","commit_id":"ade8b6033f18d721c1d1093371847cdcce455fa5"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9123537d97ca3e6602b7c56ad08122beb4d65532","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.PortOpt(\u0027portal_port\u0027,"},{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027The port number on which the iSCSI portal listens \u0027"},{"line_number":84,"context_line":"                       \u0027for incoming connections.\u0027)),"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_2624c4ad","line":84,"updated":"2016-04-13 03:03:48.000000000","message":"better to also say it defaults to 3260 in the help_ message","commit_id":"5a086e44d75cc6148f601ccec3d650ea972c47d9"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"3b134b478b1df6a5d2f0df43afa8905eeba9ee54","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.PortOpt(\u0027portal_port\u0027,"},{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027The port number on which the iSCSI portal listens \u0027"},{"line_number":84,"context_line":"                       \u0027for incoming connections.\u0027)),"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a18252c_6c217bb4","line":84,"in_reply_to":"5a18252c_2624c4ad","updated":"2016-04-13 07:43:27.000000000","message":"Looks like other options did not say default value in help msg, so can we keep same format, any thoughts?","commit_id":"5a086e44d75cc6148f601ccec3d650ea972c47d9"}]}