)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"fca44fe843612f62e612ea77443c5e95eaccca60","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# For example:"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# 192.168.110.107 00:1e:67:57:50:4c root otc123"},{"line_number":66,"context_line":"# "},{"line_number":67,"context_line":"# Currently supported IRONIC_DEPLOY_DRIVERs:"},{"line_number":68,"context_line":"# *_ipmitool:"},{"line_number":69,"context_line":"#   \u003cBMC address\u003e \u003cMAC address\u003e \u003cBMC username\u003e \u003cBMC password\u003e"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a18252c_5464f7e3","line":66,"updated":"2016-04-13 12:02:07.000000000","message":"Trailing space.","commit_id":"5b2b9f5516d4d0dda854e78459ffb84b18166c28"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8923311a189325839e77d365304eef3f56478207","unresolved":false,"context_lines":[{"line_number":77,"context_line":"# IRONIC_IPMIINFO_FILE is deprecated, please use IRONIC_HWINFO_FILE."},{"line_number":78,"context_line":"IRONIC_IPMIINFO_FILE\u003d${IRONIC_IPMIINFO_FILE:-\"\"}"},{"line_number":79,"context_line":"if [ ! -z \"$IRONIC_IPMIINFO_FILE\" ]; then"},{"line_number":80,"context_line":"    echo \"IRONIC_IPMIINFO_FILE is deprecated, please switch to IRONIC_HWINFO_FILE\""},{"line_number":81,"context_line":"fi"},{"line_number":82,"context_line":"IRONIC_HWINFO_FILE\u003d${IRONIC_HWINFO_FILE:-${IRONIC_IPMIINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}}"},{"line_number":83,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a18252c_f488a324","line":80,"updated":"2016-04-13 12:04:59.000000000","message":"I think you need to use the \"deprecated\" function to print this message in devstack [0]\n\n[0] https://github.com/openstack-dev/devstack/blob/master/functions-common#L216-L220","commit_id":"5b2b9f5516d4d0dda854e78459ffb84b18166c28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dc53eeaf67634510e8f542f3dbfce20ae378ab8b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# 192.168.110.107 00:1e:67:57:50:4c root otc123"},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# Currently supported IRONIC_DEPLOY_DRIVERs:"},{"line_number":68,"context_line":"# *_ipmitool:"},{"line_number":69,"context_line":"#   \u003cBMC address\u003e \u003cMAC address\u003e \u003cBMC username\u003e \u003cBMC password\u003e"},{"line_number":70,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a18252c_b032aa0e","line":67,"updated":"2016-04-13 15:11:05.000000000","message":"nit: \u0027Currently\u0027 isn\u0027t very useful because \u0027current\u0027 is when the user is reading this. So I would just omit that word.","commit_id":"d38b14ed68af89c3c9cec60e97f15b692c39cf00"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"83f50a03e02ead0448fc3ab9118b5422c9eec279","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# 192.168.110.107 00:1e:67:57:50:4c root otc123"},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# Currently supported IRONIC_DEPLOY_DRIVERs:"},{"line_number":68,"context_line":"# *_ipmitool:"},{"line_number":69,"context_line":"#   \u003cBMC address\u003e \u003cMAC address\u003e \u003cBMC username\u003e \u003cBMC password\u003e"},{"line_number":70,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a18252c_16a0b68f","line":67,"in_reply_to":"5a18252c_b032aa0e","updated":"2016-04-13 15:26:21.000000000","message":"Done","commit_id":"d38b14ed68af89c3c9cec60e97f15b692c39cf00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dc53eeaf67634510e8f542f3dbfce20ae378ab8b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# *_ucs:"},{"line_number":75,"context_line":"#   \u003cBMC address\u003e \u003cMAC address\u003e \u003cBMC username\u003e \u003cBMC password\u003e \u003cUCS service profile\u003e"},{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"# IRONIC_IPMIINFO_FILE is deprecated, please use IRONIC_HWINFO_FILE."},{"line_number":78,"context_line":"IRONIC_IPMIINFO_FILE\u003d${IRONIC_IPMIINFO_FILE:-\"\"}"},{"line_number":79,"context_line":"if [ ! -z \"$IRONIC_IPMIINFO_FILE\" ]; then"},{"line_number":80,"context_line":"    deprecated \"IRONIC_IPMIINFO_FILE is deprecated, please switch to IRONIC_HWINFO_FILE\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a18252c_9b034f0d","line":77,"updated":"2016-04-13 15:11:05.000000000","message":"How long are we going to deprecate this before removing it?","commit_id":"d38b14ed68af89c3c9cec60e97f15b692c39cf00"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"83f50a03e02ead0448fc3ab9118b5422c9eec279","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# *_ucs:"},{"line_number":75,"context_line":"#   \u003cBMC address\u003e \u003cMAC address\u003e \u003cBMC username\u003e \u003cBMC password\u003e \u003cUCS service profile\u003e"},{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"# IRONIC_IPMIINFO_FILE is deprecated, please use IRONIC_HWINFO_FILE."},{"line_number":78,"context_line":"IRONIC_IPMIINFO_FILE\u003d${IRONIC_IPMIINFO_FILE:-\"\"}"},{"line_number":79,"context_line":"if [ ! -z \"$IRONIC_IPMIINFO_FILE\" ]; then"},{"line_number":80,"context_line":"    deprecated \"IRONIC_IPMIINFO_FILE is deprecated, please switch to IRONIC_HWINFO_FILE\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a18252c_eaf54acb","line":77,"in_reply_to":"5a18252c_9b034f0d","updated":"2016-04-13 15:26:21.000000000","message":"Updated to state that it will be removed in Ocata.","commit_id":"d38b14ed68af89c3c9cec60e97f15b692c39cf00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dc53eeaf67634510e8f542f3dbfce20ae378ab8b","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            node_options+\u003d\" -i deploy_ramdisk\u003d$IRONIC_DEPLOY_RAMDISK_ID\""},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"            if is_deployed_by_ipmitool; then"},{"line_number":804,"context_line":"                local node_options+\u003d\" -i ipmi_address\u003d$bmc_address -i ipmi_password\u003d$bmc_passwd\\"},{"line_number":805,"context_line":"                    -i ipmi_username\u003d$bmc_username\""},{"line_number":806,"context_line":"            elif is_deployed_by_cimc; then"},{"line_number":807,"context_line":"                local node_options+\u003d\" -i cimc_address\u003d$bmc_address -i cimc_password\u003d$bmc_passwd\\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a18252c_fbe883b6","line":804,"updated":"2016-04-13 15:11:05.000000000","message":"this is a dumb question. Why do \u0027local node_options\u0027 here, instead of adding a new line \u0027local node_options\u0027 before line 800? They are the same \u0027node_options\u0027, right?","commit_id":"d38b14ed68af89c3c9cec60e97f15b692c39cf00"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"83f50a03e02ead0448fc3ab9118b5422c9eec279","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            node_options+\u003d\" -i deploy_ramdisk\u003d$IRONIC_DEPLOY_RAMDISK_ID\""},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"            if is_deployed_by_ipmitool; then"},{"line_number":804,"context_line":"                local node_options+\u003d\" -i ipmi_address\u003d$bmc_address -i ipmi_password\u003d$bmc_passwd\\"},{"line_number":805,"context_line":"                    -i ipmi_username\u003d$bmc_username\""},{"line_number":806,"context_line":"            elif is_deployed_by_cimc; then"},{"line_number":807,"context_line":"                local node_options+\u003d\" -i cimc_address\u003d$bmc_address -i cimc_password\u003d$bmc_passwd\\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a18252c_d6b8fee7","line":804,"in_reply_to":"5a18252c_fbe883b6","updated":"2016-04-13 15:26:21.000000000","message":"Done","commit_id":"d38b14ed68af89c3c9cec60e97f15b692c39cf00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f19d031fde492301252b6654c15bd7c19afbb574","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# *_ucs:"},{"line_number":75,"context_line":"#   \u003cBMC address\u003e \u003cMAC address\u003e \u003cBMC username\u003e \u003cBMC password\u003e \u003cUCS service profile\u003e"},{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"# IRONIC_IPMIINFO_FILE is deprecated, please use IRONIC_HWINFO_FILE. IRONIC_IPMIINFO_FILE will be removed in Ocata."},{"line_number":78,"context_line":"IRONIC_IPMIINFO_FILE\u003d${IRONIC_IPMIINFO_FILE:-\"\"}"},{"line_number":79,"context_line":"if [ ! -z \"$IRONIC_IPMIINFO_FILE\" ]; then"},{"line_number":80,"context_line":"    deprecated \"IRONIC_IPMIINFO_FILE is deprecated, please switch to IRONIC_HWINFO_FILE. IRONIC_IPMIINFO_FILE will be removed in Ocata.\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a18252c_2aee22ec","line":77,"updated":"2016-04-13 15:29:18.000000000","message":"I don\u0027t know if we have any rules about long lines (nor am I sure how long this is but pointing it out)","commit_id":"b61d9c076b4ce69312bc5e5303d58522e40352fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"10c6d60044b2a70be2767bf91e8037260d7d361b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# *_ucs:"},{"line_number":75,"context_line":"#   \u003cBMC address\u003e \u003cMAC address\u003e \u003cBMC username\u003e \u003cBMC password\u003e \u003cUCS service profile\u003e"},{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"# IRONIC_IPMIINFO_FILE is deprecated, please use IRONIC_HWINFO_FILE. IRONIC_IPMIINFO_FILE will be removed in Ocata."},{"line_number":78,"context_line":"IRONIC_IPMIINFO_FILE\u003d${IRONIC_IPMIINFO_FILE:-\"\"}"},{"line_number":79,"context_line":"if [ ! -z \"$IRONIC_IPMIINFO_FILE\" ]; then"},{"line_number":80,"context_line":"    deprecated \"IRONIC_IPMIINFO_FILE is deprecated, please switch to IRONIC_HWINFO_FILE. IRONIC_IPMIINFO_FILE will be removed in Ocata.\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a18252c_f1e08398","line":77,"in_reply_to":"5a18252c_2aee22ec","updated":"2016-04-14 07:36:09.000000000","message":"Not for bash files, it\u0027s currently disabled in bashate [0]\n\n[0] https://github.com/openstack/ironic/blob/master/tools/run_bashate.sh#L27","commit_id":"b61d9c076b4ce69312bc5e5303d58522e40352fe"}]}