)]}'
{"ironic/drivers/base.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ee3b5cdf72cd329a688ddb5c1545b1f90c87c1dc","unresolved":false,"context_lines":[{"line_number":826,"context_line":"        raise exception.UnsupportedDriverExtension("},{"line_number":827,"context_line":"            driver\u003dtask.node.driver, extension\u003d\u0027inject_nmi\u0027)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    def set_iscsi_boot_target(self, task):"},{"line_number":830,"context_line":"        \"\"\"Set iscsi boot volume target info into the node."},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        Retrieve \u0027target_iqn\u0027, \u0027target_portal\u0027, \u0027target_lun\u0027,"},{"line_number":833,"context_line":"        \u0027auth_method\u0027, \u0027auth_username\u0027, \u0027auth_password\u0027 from"},{"line_number":834,"context_line":"        node\u0027s volume target information and set the same in"},{"line_number":835,"context_line":"        the node\u0027s bios details."},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        :param task: A TaskManager instance containing the node to act on."},{"line_number":838,"context_line":"        :raises: UnsupportedDriverExtension"},{"line_number":839,"context_line":"        \"\"\""},{"line_number":840,"context_line":"        raise exception.UnsupportedDriverExtension("},{"line_number":841,"context_line":"            driver\u003dtask.node.driver, extension\u003d\u0027set_iscsi_boot_target\u0027)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    def clear_iscsi_boot_target(self, task):"},{"line_number":844,"context_line":"        \"\"\"Clear iscsi boot volume target info from the node."},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"        Clear target iqn details from the node\u0027s bios."},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"        :param task: A TaskManager instance containing the node to act on."},{"line_number":849,"context_line":"        :raises: UnsupportedDriverExtension"},{"line_number":850,"context_line":"        \"\"\""},{"line_number":851,"context_line":"        raise exception.UnsupportedDriverExtension("},{"line_number":852,"context_line":"            driver\u003dtask.node.driver, extension\u003d\u0027clear_iscsi_boot_target\u0027)"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"class InspectInterface(BaseInterface):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_5ed92881","line":852,"range":{"start_line":829,"start_character":0,"end_line":852,"end_character":73},"updated":"2017-05-15 19:42:30.000000000","message":"I would actually not mind seeing this proposed with an iLO driver as management interface additions.  It makes sense for vendor specific hardware drivers for their boot interfaces to assert proper boot devices.","commit_id":"ec4aaf3add54af8a6a4f6642948a51185a2bc7ca"}],"ironic/drivers/ilo.py":[{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"11fdc1549d4fb6165b9ada741071aede8c19966c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":"from ironic.drivers import base"},{"line_number":23,"context_line":"from ironic.drivers.modules import agent"},{"line_number":24,"context_line":"from ironic.drivers.modules import fake"},{"line_number":25,"context_line":"from ironic.drivers.modules.ilo import boot"},{"line_number":26,"context_line":"from ironic.drivers.modules.ilo import console"},{"line_number":27,"context_line":"from ironic.drivers.modules.ilo import deploy"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_cd9426e4","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":39},"updated":"2016-12-02 12:14:50.000000000","message":"See my comment below for FakeBoot. You can safely remove this line if it\u0027s incorporated.","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"11fdc1549d4fb6165b9ada741071aede8c19966c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                reason\u003d_(\"Unable to import proliantutils library\"))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.power \u003d power.IloPower()"},{"line_number":104,"context_line":"        self.boot \u003d fake.FakeBoot()"},{"line_number":105,"context_line":"        self.deploy \u003d deploy.IloUefiIscsiBootDeploy()"},{"line_number":106,"context_line":"        self.console \u003d console.IloConsoleInterface()"},{"line_number":107,"context_line":"        self.management \u003d management.IloManagement()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_8d030e42","line":104,"range":{"start_line":104,"start_character":20,"end_line":104,"end_character":35},"updated":"2016-12-02 12:14:50.000000000","message":"Better to use boot.IloISCSIVolumeBoot. If it is not there implement it similar to FakeBoot.","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b297e8f206ff938bf2f22073498d59d3caab0e88","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                reason\u003d_(\"Unable to import proliantutils library\"))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.power \u003d power.IloPower()"},{"line_number":104,"context_line":"        self.boot \u003d fake.FakeBoot()"},{"line_number":105,"context_line":"        self.deploy \u003d deploy.IloUefiIscsiBootDeploy()"},{"line_number":106,"context_line":"        self.console \u003d console.IloConsoleInterface()"},{"line_number":107,"context_line":"        self.management \u003d management.IloManagement()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_891a78c4","line":104,"range":{"start_line":104,"start_character":20,"end_line":104,"end_character":35},"in_reply_to":"3a71b18c_8d030e42","updated":"2016-12-07 09:19:27.000000000","message":"I will continue to use fakeboot till reference driver get merged, and then i will remove if needed","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"11fdc1549d4fb6165b9ada741071aede8c19966c","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.power \u003d power.IloPower()"},{"line_number":104,"context_line":"        self.boot \u003d fake.FakeBoot()"},{"line_number":105,"context_line":"        self.deploy \u003d deploy.IloUefiIscsiBootDeploy()"},{"line_number":106,"context_line":"        self.console \u003d console.IloConsoleInterface()"},{"line_number":107,"context_line":"        self.management \u003d management.IloManagement()"},{"line_number":108,"context_line":"        self.vendor \u003d vendor.VendorPassthru()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_f29b7d70","line":105,"range":{"start_line":105,"start_character":41,"end_line":105,"end_character":45},"updated":"2016-12-02 12:14:50.000000000","message":"Remove this from the name of the class since it is misleading. Make changes accordingly.","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b297e8f206ff938bf2f22073498d59d3caab0e88","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.power \u003d power.IloPower()"},{"line_number":104,"context_line":"        self.boot \u003d fake.FakeBoot()"},{"line_number":105,"context_line":"        self.deploy \u003d deploy.IloUefiIscsiBootDeploy()"},{"line_number":106,"context_line":"        self.console \u003d console.IloConsoleInterface()"},{"line_number":107,"context_line":"        self.management \u003d management.IloManagement()"},{"line_number":108,"context_line":"        self.vendor \u003d vendor.VendorPassthru()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_c9e2b0d4","line":105,"range":{"start_line":105,"start_character":41,"end_line":105,"end_character":45},"in_reply_to":"3a71b18c_f29b7d70","updated":"2016-12-07 09:19:27.000000000","message":"Done","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"75007bc412a9aba538aa48a9f6603262786eea49","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    ilo_object \u003d get_ilo_object(task.node)"},{"line_number":722,"context_line":"    for mac in macs:"},{"line_number":723,"context_line":"        if auth is None:"},{"line_number":724,"context_line":"            ilo_object.set_iscsi_boot_info(mac, target_iqn, target_lun,"},{"line_number":725,"context_line":"                                           target_ip, target_port, None,"},{"line_number":726,"context_line":"                                           None, None)"},{"line_number":727,"context_line":"        else:"},{"line_number":728,"context_line":"            ilo_object.set_iscsi_boot_info(mac, target_iqn, target_lun,"},{"line_number":729,"context_line":"                                           target_ip, target_port, auth,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_ebef9c1b","line":726,"range":{"start_line":724,"start_character":12,"end_line":726,"end_character":54},"updated":"2016-12-06 07:25:09.000000000","message":"Use ``ilo_object.set_iscsi_boot_info(mac, target_iqn,                     target_lun, target_ip, target_port)``. \u0027None\u0027 is not needed because they are keyword parameters (https://github.com/openstack/proliantutils/blob/master/proliantutils/ilo/ris.py#L879)","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b297e8f206ff938bf2f22073498d59d3caab0e88","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    ilo_object \u003d get_ilo_object(task.node)"},{"line_number":722,"context_line":"    for mac in macs:"},{"line_number":723,"context_line":"        if auth is None:"},{"line_number":724,"context_line":"            ilo_object.set_iscsi_boot_info(mac, target_iqn, target_lun,"},{"line_number":725,"context_line":"                                           target_ip, target_port, None,"},{"line_number":726,"context_line":"                                           None, None)"},{"line_number":727,"context_line":"        else:"},{"line_number":728,"context_line":"            ilo_object.set_iscsi_boot_info(mac, target_iqn, target_lun,"},{"line_number":729,"context_line":"                                           target_ip, target_port, auth,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_69e43cab","line":726,"range":{"start_line":724,"start_character":12,"end_line":726,"end_character":54},"in_reply_to":"3a71b18c_ebef9c1b","updated":"2016-12-07 09:19:27.000000000","message":"Done","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ee3b5cdf72cd329a688ddb5c1545b1f90c87c1dc","unresolved":false,"context_lines":[{"line_number":597,"context_line":"class UEFIiSCSIBootDeploy(base.DeployInterface):"},{"line_number":598,"context_line":"    \"\"\"UEFI iSCSI Boot Interface for deploy-related actions.\"\"\""},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def __init__(self):"},{"line_number":601,"context_line":"        REQUIRED_PROPERTIES \u003d {"},{"line_number":602,"context_line":"            \u0027target_iqn\u0027: _(\u0027IQN from iscsi target. \u0027"},{"line_number":603,"context_line":"                            \u0027Required.\u0027),"},{"line_number":604,"context_line":"            \u0027target_lun\u0027: _(\u0027LUN from iscsi target. \u0027"},{"line_number":605,"context_line":"                            \u0027Required.\u0027),"},{"line_number":606,"context_line":"            \u0027target_portal\u0027: _(\u0027Ip address and port of iscsi target. \u0027"},{"line_number":607,"context_line":"                               \u0027Required.\u0027)}"},{"line_number":608,"context_line":"        OPTIONAL_PROPERTIES \u003d {"},{"line_number":609,"context_line":"            \u0027auth_method\u0027: _(\u0027Auth method from iscsi target. \u0027"},{"line_number":610,"context_line":"                             \u0027Optional.\u0027),"},{"line_number":611,"context_line":"            \u0027auth_username\u0027: _(\u0027Auth username from iscsi target. \u0027"},{"line_number":612,"context_line":"                               \u0027Optional.\u0027),"},{"line_number":613,"context_line":"            \u0027auth_password\u0027: _(\u0027Auth password from iscsi target. \u0027"},{"line_number":614,"context_line":"                               \u0027Optional.\u0027)}"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"        COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"},{"line_number":617,"context_line":"        COMMON_PROPERTIES.update(OPTIONAL_PROPERTIES)"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def get_properties(self):"},{"line_number":620,"context_line":"        \"\"\"Return the properties of the interface."}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_1eb5e031","line":617,"range":{"start_line":600,"start_character":1,"end_line":617,"end_character":53},"updated":"2017-05-15 19:42:30.000000000","message":"This information should be available from volume_connectors, and shouldn\u0027t need to be defined by a \"user\" triggering  deploy since volume mappings have to be handled.","commit_id":"ec4aaf3add54af8a6a4f6642948a51185a2bc7ca"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ee3b5cdf72cd329a688ddb5c1545b1f90c87c1dc","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        _validate_boot_option_for_uefi_iscsi_boot(task)"},{"line_number":635,"context_line":"        node \u003d task.node"},{"line_number":636,"context_line":"        instance_info \u003d node.instance_info"},{"line_number":637,"context_line":"        iscsi_target_info \u003d {"},{"line_number":638,"context_line":"            \u0027iqn\u0027: instance_info.get(\u0027target_iqn\u0027),"},{"line_number":639,"context_line":"            \u0027portal\u0027: instance_info.get(\u0027target_portal\u0027),"},{"line_number":640,"context_line":"            \u0027lun\u0027: str(instance_info.get(\u0027target_lun\u0027))"},{"line_number":641,"context_line":"        }"},{"line_number":642,"context_line":"        if instance_info.get(\u0027auth_method\u0027) is not None:"},{"line_number":643,"context_line":"            iscsi_target_info.update({"},{"line_number":644,"context_line":"                \u0027auth\u0027: instance_info.get(\u0027auth_method\u0027),"},{"line_number":645,"context_line":"                \u0027username\u0027: instance_info.get(\u0027auth_username\u0027),"},{"line_number":646,"context_line":"                \u0027password\u0027: instance_info.get(\u0027auth_password\u0027)"},{"line_number":647,"context_line":"            })"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        error_msg \u003d _(\"Cannot validate UEFI iSCSI deploy. Some parameters\""},{"line_number":650,"context_line":"                      \" were missing in node\u0027s instance_info\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_9e82104f","line":647,"range":{"start_line":637,"start_character":0,"end_line":647,"end_character":14},"updated":"2017-05-15 19:42:30.000000000","message":"Same comment as optional and required properties above.","commit_id":"ec4aaf3add54af8a6a4f6642948a51185a2bc7ca"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ee3b5cdf72cd329a688ddb5c1545b1f90c87c1dc","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        \"\"\"Prepare the deployment environment for this node."},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"        :param task: a TaskManager instance."},{"line_number":675,"context_line":"        :raises: IloOperationError, if some operation on iLO failed."},{"line_number":676,"context_line":"        \"\"\""},{"line_number":677,"context_line":"        if task.node.provision_state \u003d\u003d states.DEPLOYING:"},{"line_number":678,"context_line":"            # Adding the node to provisioning network so that the dhcp"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_de9f78b2","line":675,"range":{"start_line":675,"start_character":17,"end_line":675,"end_character":35},"updated":"2017-05-15 19:42:30.000000000","message":"Generic !\u003d ILO","commit_id":"ec4aaf3add54af8a6a4f6642948a51185a2bc7ca"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ee3b5cdf72cd329a688ddb5c1545b1f90c87c1dc","unresolved":false,"context_lines":[{"line_number":681,"context_line":"            # NOTE(vdrok): in case of rebuild, we have tenant network"},{"line_number":682,"context_line":"            # already configured, unbind tenant ports if present"},{"line_number":683,"context_line":"            task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":684,"context_line":"            task.driver.network.add_provisioning_network(task)"},{"line_number":685,"context_line":"        task.driver.management.set_iscsi_boot_target(task)"},{"line_number":686,"context_line":"        deploy_utils.try_set_boot_device(task, boot_devices.ISCSIBOOT)"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f013ff3_3e63fcde","line":684,"range":{"start_line":684,"start_character":0,"end_line":684,"end_character":62},"updated":"2017-05-15 19:42:30.000000000","message":"I don\u0027t see anywhere in this where the tenant network is reconfigured to complete the deploy.  Does this make sense to even have in place?","commit_id":"ec4aaf3add54af8a6a4f6642948a51185a2bc7ca"}],"ironic/drivers/modules/iscsivolume_deploy.py":[{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"11fdc1549d4fb6165b9ada741071aede8c19966c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _LE"},{"line_number":22,"context_line":"from ironic.drivers import base"},{"line_number":23,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":24,"context_line":"from ironic.drivers.modules.ilo import common as ilo_common"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_680dc036","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":59},"updated":"2016-12-02 12:14:50.000000000","message":"We can not have ilo related stuff here. Remove this.","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b297e8f206ff938bf2f22073498d59d3caab0e88","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _LE"},{"line_number":22,"context_line":"from ironic.drivers import base"},{"line_number":23,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":24,"context_line":"from ironic.drivers.modules.ilo import common as ilo_common"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_a962d43b","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":59},"in_reply_to":"3a71b18c_680dc036","updated":"2016-12-07 09:19:27.000000000","message":"Done","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"11fdc1549d4fb6165b9ada741071aede8c19966c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    return macs"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class ISCSIDeploy(base.DeployInterface):"},{"line_number":80,"context_line":"    \"\"\"iSCSI Boot Interface for deploy-related actions.\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_48e9e47f","line":79,"range":{"start_line":79,"start_character":6,"end_line":79,"end_character":39},"updated":"2016-12-02 12:14:50.000000000","message":"I somehow feel that this should all be part of boot interface.  When we speak of deploy it\u0027s more associated with copying the image either triggered by controller or by the agent. So i\u0027d rather say, move this to boot interface and handle the deploy part accordingly in the deploy interface, which may turn out to be setting the states or etc. In short, may be having iscsi_boot.py and define the IscsiBootInterface and moving all the stuff from here. \nFor instance \"validate\" here just does task.node.boot.validate()\nSimilarly \"prepare\" can do task.node.boot.prepare()","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b297e8f206ff938bf2f22073498d59d3caab0e88","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    return macs"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class ISCSIDeploy(base.DeployInterface):"},{"line_number":80,"context_line":"    \"\"\"iSCSI Boot Interface for deploy-related actions.\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_095ca87b","line":79,"range":{"start_line":79,"start_character":6,"end_line":79,"end_character":39},"in_reply_to":"3a71b18c_48e9e47f","updated":"2016-12-07 09:19:27.000000000","message":"will make changes once the reference driver code is submitted.","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"11fdc1549d4fb6165b9ada741071aede8c19966c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            username \u003d info.get(\u0027auth_username\u0027)"},{"line_number":135,"context_line":"            password \u003d info.get(\u0027auth_password\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"            ilo_common.set_iscsi_boot_info(task, macs, iqn, lun, ip,"},{"line_number":138,"context_line":"                                           port, auth, username,"},{"line_number":139,"context_line":"                                           password)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            ilo_common.set_iscsi_boot_info(task, macs, iqn, lun, ip,"},{"line_number":142,"context_line":"                                           port, None, None, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_084e0c6f","line":139,"range":{"start_line":137,"start_character":12,"end_line":139,"end_character":52},"updated":"2016-12-02 12:14:50.000000000","message":"Should not be specific to vendor.","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"75007bc412a9aba538aa48a9f6603262786eea49","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            username \u003d info.get(\u0027auth_username\u0027)"},{"line_number":135,"context_line":"            password \u003d info.get(\u0027auth_password\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"            ilo_common.set_iscsi_boot_info(task, macs, iqn, lun, ip,"},{"line_number":138,"context_line":"                                           port, auth, username,"},{"line_number":139,"context_line":"                                           password)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            ilo_common.set_iscsi_boot_info(task, macs, iqn, lun, ip,"},{"line_number":142,"context_line":"                                           port, None, None, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_4bfa5076","line":139,"range":{"start_line":137,"start_character":12,"end_line":139,"end_character":52},"in_reply_to":"3a71b18c_084e0c6f","updated":"2016-12-06 07:25:09.000000000","message":"I agree with vinay. Ilo specific calls should be made from corresponding deploy class from ilo/deploy.py. In this case, the prepare() from the child class \u0027IloUefiIscsiBootDeploy\u0027  should make ilo specific calls.","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b297e8f206ff938bf2f22073498d59d3caab0e88","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            username \u003d info.get(\u0027auth_username\u0027)"},{"line_number":135,"context_line":"            password \u003d info.get(\u0027auth_password\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"            ilo_common.set_iscsi_boot_info(task, macs, iqn, lun, ip,"},{"line_number":138,"context_line":"                                           port, auth, username,"},{"line_number":139,"context_line":"                                           password)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            ilo_common.set_iscsi_boot_info(task, macs, iqn, lun, ip,"},{"line_number":142,"context_line":"                                           port, None, None, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_694d1cc3","line":139,"range":{"start_line":137,"start_character":12,"end_line":139,"end_character":52},"in_reply_to":"3a71b18c_4bfa5076","updated":"2016-12-07 09:19:27.000000000","message":"Done","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"11fdc1549d4fb6165b9ada741071aede8c19966c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                           port, auth, username,"},{"line_number":139,"context_line":"                                           password)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            ilo_common.set_iscsi_boot_info(task, macs, iqn, lun, ip,"},{"line_number":142,"context_line":"                                           port, None, None, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_e88c7081","line":142,"range":{"start_line":141,"start_character":12,"end_line":142,"end_character":66},"updated":"2016-12-02 12:14:50.000000000","message":"Ditto.","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b297e8f206ff938bf2f22073498d59d3caab0e88","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                           port, auth, username,"},{"line_number":139,"context_line":"                                           password)"},{"line_number":140,"context_line":"        else:"},{"line_number":141,"context_line":"            ilo_common.set_iscsi_boot_info(task, macs, iqn, lun, ip,"},{"line_number":142,"context_line":"                                           port, None, None, None)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        deploy_utils.try_set_boot_device(task, boot_devices.ISCSI)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_8948b8b4","line":142,"range":{"start_line":141,"start_character":12,"end_line":142,"end_character":66},"in_reply_to":"3a71b18c_e88c7081","updated":"2016-12-07 09:19:27.000000000","message":"Done","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"11fdc1549d4fb6165b9ada741071aede8c19966c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        :returns: None"},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        # macs \u003d get_mac(task)"},{"line_number":155,"context_line":"        # ilo_common.set_iscsi_boot_info(task, macs, None, None, None, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_a8ab58d5","line":155,"range":{"start_line":155,"start_character":10,"end_line":155,"end_character":76},"updated":"2016-12-02 12:14:50.000000000","message":"Ditto. And please remove anything related to ilo from this file which i might have overlooked to point out.","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b297e8f206ff938bf2f22073498d59d3caab0e88","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        :returns: None"},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        # macs \u003d get_mac(task)"},{"line_number":155,"context_line":"        # ilo_common.set_iscsi_boot_info(task, macs, None, None, None, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_a9c9f427","line":155,"range":{"start_line":155,"start_character":10,"end_line":155,"end_character":76},"in_reply_to":"3a71b18c_a8ab58d5","updated":"2016-12-07 09:19:27.000000000","message":"Done","commit_id":"12aa7dfa973403673554d8bc639b70d5121bbc40"}]}
