)]}'
{"ironic/conf/pxe.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"3d43aa1e9aff13f5e35b5331a807b7d0000986d7","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":24,"context_line":"# This is acceptable for now as a future refactoring into"},{"line_number":25,"context_line":"# separate boot and deploy interfaces is planned, and moving config"},{"line_number":26,"context_line":"# options twice is not recommended.  Hence we would move the parameters"},{"line_number":27,"context_line":"# to the appropriate place in the final refactoring."},{"line_number":28,"context_line":"pxe_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_8ba13cac","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":52},"updated":"2016-04-25 04:32:49.000000000","message":"I think we can remove this comment because boot and deploy interfaces separation had been done in Mitaka, and pxe_opts in both iscsi_deploy.py and pxe.py are merged into this file.","commit_id":"f919d369ae8f6ca25c26f60f19053ab943a30f60"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"bec32dbc2c8d2781e2695e02d2b25eba6ae80601","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":24,"context_line":"# This is acceptable for now as a future refactoring into"},{"line_number":25,"context_line":"# separate boot and deploy interfaces is planned, and moving config"},{"line_number":26,"context_line":"# options twice is not recommended.  Hence we would move the parameters"},{"line_number":27,"context_line":"# to the appropriate place in the final refactoring."},{"line_number":28,"context_line":"pxe_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4eba80e2","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":52},"in_reply_to":"1a122d0e_8ba13cac","updated":"2016-04-25 17:44:35.000000000","message":"Done. Thanks.","commit_id":"f919d369ae8f6ca25c26f60f19053ab943a30f60"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"061cd688cac26961ab21af10fb88019080239d31","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                      \u0027cache.\u0027)),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027disk_devices\u0027,"},{"line_number":56,"context_line":"               default\u003d\u0027cciss/c0d0,sda,hda,vda\u0027,"},{"line_number":57,"context_line":"               help\u003d_(\u0027The disk devices to scan while doing the deploy.\u0027)),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027pxe_config_template\u0027,"},{"line_number":59,"context_line":"               default\u003dos.path.join("},{"line_number":60,"context_line":"                   \u0027$pybasedir\u0027, \u0027drivers/modules/pxe_config.template\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_34d8b5ef","line":57,"updated":"2016-07-27 18:30:36.000000000","message":"That NOTE from ramesh refers to everything (or some of the options) up to here. Not sure what to do about it. Either 1. remove the comment, or 2. move the comment to above line 29 and add a blank line to separate the above from the below. Or ??\n\nMaybe deleting the comment might be easier. Not sure what others think.","commit_id":"f4ab3ebc256105089384ec34017488ff55050716"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c34173c7e37bad1dc83ac615ff692b20b9e57e3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to only some of the options"},{"line_number":30,"context_line":"    # below."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_3dfe8e38","line":30,"updated":"2016-07-29 00:08:55.000000000","message":"i think we should be a bit more accurate since I think Ramesh\u0027s comment will be hard to understand anyway.\n\nHow about \u0027The above comment pertains to (some of the) options from pxe_append_params up to and including disk_devices.\u0027","commit_id":"c382353605f350ac3a2c71e5bcf3a670c6805bb8"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"2fc45b7ffdc727f19f819f34247f4fcbdca512a4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to only some of the options"},{"line_number":30,"context_line":"    # below."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_72b3e8e9","line":30,"in_reply_to":"bacf61ea_3dfe8e38","updated":"2016-07-29 18:20:43.000000000","message":"Done","commit_id":"c382353605f350ac3a2c71e5bcf3a670c6805bb8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c34173c7e37bad1dc83ac615ff692b20b9e57e3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.StrOpt(\u0027disk_devices\u0027,"},{"line_number":59,"context_line":"               default\u003d\u0027cciss/c0d0,sda,hda,vda\u0027,"},{"line_number":60,"context_line":"               help\u003d_(\u0027The disk devices to scan while doing the deploy.\u0027)),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027pxe_config_template\u0027,"},{"line_number":62,"context_line":"               default\u003dos.path.join("},{"line_number":63,"context_line":"                   \u0027$pybasedir\u0027, \u0027drivers/modules/pxe_config.template\u0027),"},{"line_number":64,"context_line":"               help\u003d_(\u0027On ironic-conductor node, template file for PXE \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_9dfdfa3c","line":61,"updated":"2016-07-29 00:08:55.000000000","message":"please add a blank line above this, to further indicate the separation wrt Ramesh\u0027s comment.","commit_id":"c382353605f350ac3a2c71e5bcf3a670c6805bb8"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"2fc45b7ffdc727f19f819f34247f4fcbdca512a4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.StrOpt(\u0027disk_devices\u0027,"},{"line_number":59,"context_line":"               default\u003d\u0027cciss/c0d0,sda,hda,vda\u0027,"},{"line_number":60,"context_line":"               help\u003d_(\u0027The disk devices to scan while doing the deploy.\u0027)),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027pxe_config_template\u0027,"},{"line_number":62,"context_line":"               default\u003dos.path.join("},{"line_number":63,"context_line":"                   \u0027$pybasedir\u0027, \u0027drivers/modules/pxe_config.template\u0027),"},{"line_number":64,"context_line":"               help\u003d_(\u0027On ironic-conductor node, template file for PXE \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_d241f4aa","line":61,"in_reply_to":"bacf61ea_9dfdfa3c","updated":"2016-07-29 18:20:43.000000000","message":"Done","commit_id":"c382353605f350ac3a2c71e5bcf3a670c6805bb8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cef4cc477267fbe37f42e588ca2bf6715ecc4398","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"opts \u003d ["},{"line_number":24,"context_line":"    # NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":25,"context_line":"    # This is acceptable for now as a future refactoring into"},{"line_number":26,"context_line":"    # separate boot and deploy interfaces is planned, and moving config"},{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to (some of the) options from"},{"line_number":30,"context_line":"    # pxe_append_params up to and including disk_devices."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_6ef4675a","line":30,"range":{"start_line":24,"start_character":4,"end_line":30,"end_character":57},"updated":"2016-08-11 11:52:10.000000000","message":"Please remove this comment, it\u0027s all centralized now.","commit_id":"1d8496c517dc138798b148414db0310fac2a39fb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b7ef992b262f0f67d0d10cd36b79ef80359d8399","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"opts \u003d ["},{"line_number":24,"context_line":"    # NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":25,"context_line":"    # This is acceptable for now as a future refactoring into"},{"line_number":26,"context_line":"    # separate boot and deploy interfaces is planned, and moving config"},{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to (some of the) options from"},{"line_number":30,"context_line":"    # pxe_append_params up to and including disk_devices."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_e4618106","line":30,"range":{"start_line":24,"start_character":4,"end_line":30,"end_character":57},"in_reply_to":"9ad45d7e_09494eb7","updated":"2016-08-11 17:58:32.000000000","message":"Ah, okay, I see, that was not clear from the first glance. Some of them indeed make more sense in deploy section.","commit_id":"1d8496c517dc138798b148414db0310fac2a39fb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"717766ab2b86005ef7830f557916076bd170cc6c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"opts \u003d ["},{"line_number":24,"context_line":"    # NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":25,"context_line":"    # This is acceptable for now as a future refactoring into"},{"line_number":26,"context_line":"    # separate boot and deploy interfaces is planned, and moving config"},{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to (some of the) options from"},{"line_number":30,"context_line":"    # pxe_append_params up to and including disk_devices."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_7a235c56","line":30,"range":{"start_line":24,"start_character":4,"end_line":30,"end_character":57},"in_reply_to":"9ad45d7e_3bcc53ba","updated":"2016-08-11 22:01:39.000000000","message":"I am wondering if it would be easier to understand if Rama\u0027s note was above Ramesh\u0027s note. I don\u0027t know that I want to try to summarize what Ramesh meant. Vlad, will that help? (Maybe nothing will...) E.g.:\n\nrameshg87\u0027s comment below was carried over from file iscsi_deploy.py. It pertains to (some of) the options from \u0027pxe_append_params\u0027 up to and including \u0027disk_devices\u0027.","commit_id":"1d8496c517dc138798b148414db0310fac2a39fb"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"860b8559120473d5e2f9fbbbcd3854c34979ff3a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"opts \u003d ["},{"line_number":24,"context_line":"    # NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":25,"context_line":"    # This is acceptable for now as a future refactoring into"},{"line_number":26,"context_line":"    # separate boot and deploy interfaces is planned, and moving config"},{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to (some of the) options from"},{"line_number":30,"context_line":"    # pxe_append_params up to and including disk_devices."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_ae11285f","line":30,"range":{"start_line":24,"start_character":4,"end_line":30,"end_character":57},"in_reply_to":"9ad45d7e_6ef4675a","updated":"2016-08-11 17:30:40.000000000","message":"Hi, the comment talks about a future refactoring into boot and deploy interfaces. That is the reason why I left the comment and added my comment to indicate the options the original comment was meant for (per Ruby\u0027s suggestion).","commit_id":"1d8496c517dc138798b148414db0310fac2a39fb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"783ae3c9bbca1a9fd1b03a771ecbcab3c0af1662","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"opts \u003d ["},{"line_number":24,"context_line":"    # NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":25,"context_line":"    # This is acceptable for now as a future refactoring into"},{"line_number":26,"context_line":"    # separate boot and deploy interfaces is planned, and moving config"},{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to (some of the) options from"},{"line_number":30,"context_line":"    # pxe_append_params up to and including disk_devices."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_5ac81855","line":30,"range":{"start_line":24,"start_character":4,"end_line":30,"end_character":57},"in_reply_to":"9ad45d7e_7a235c56","updated":"2016-08-11 22:03:29.000000000","message":"Sigh. You know what. I think we should just delete the NOTE. I think it is too confusing. It is unclear when/if further work will be done. If no one does it or no one notices that any of these config options ought to be moved to a different group, then it wasn\u0027t meant to be.","commit_id":"1d8496c517dc138798b148414db0310fac2a39fb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1d456496c249fc571e841a449b68ffc9287a9ea3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"opts \u003d ["},{"line_number":24,"context_line":"    # NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":25,"context_line":"    # This is acceptable for now as a future refactoring into"},{"line_number":26,"context_line":"    # separate boot and deploy interfaces is planned, and moving config"},{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to (some of the) options from"},{"line_number":30,"context_line":"    # pxe_append_params up to and including disk_devices."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_e9fcbab9","line":30,"range":{"start_line":24,"start_character":4,"end_line":30,"end_character":57},"in_reply_to":"9ad45d7e_ae11285f","updated":"2016-08-11 17:36:04.000000000","message":"Well, we did the split and the options are all in one place now, so dunno what value does it bring to the developer. If you really want to leave it for some reason, it needs to be changed, because \"this file\" in the note refers to a iscsi_deploy module. I\u0027d just remove it.","commit_id":"1d8496c517dc138798b148414db0310fac2a39fb"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"c01692ce328cd4069c49970b59736b6278d93281","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"opts \u003d ["},{"line_number":24,"context_line":"    # NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":25,"context_line":"    # This is acceptable for now as a future refactoring into"},{"line_number":26,"context_line":"    # separate boot and deploy interfaces is planned, and moving config"},{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to (some of the) options from"},{"line_number":30,"context_line":"    # pxe_append_params up to and including disk_devices."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_3bcc53ba","line":30,"range":{"start_line":24,"start_character":4,"end_line":30,"end_character":57},"in_reply_to":"9ad45d7e_e4618106","updated":"2016-08-11 18:25:04.000000000","message":"I could put in a new comment summarizing the intent of the original comment:\n\n\nNOTE(rama_y): This file now registers all of the options in the [pxe] group. However, a future refactoring into separate boot and deploy interfaces is planned(rameshg87), for some of the options from \u0027pxe_append_params\u0027 to \u0027disk_devices\u0027 below.","commit_id":"1d8496c517dc138798b148414db0310fac2a39fb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"aedfcaf7886f38ddb7a004291afedc66ec7d5212","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"opts \u003d ["},{"line_number":24,"context_line":"    # NOTE(rameshg87): This file now registers some of opts in pxe group."},{"line_number":25,"context_line":"    # This is acceptable for now as a future refactoring into"},{"line_number":26,"context_line":"    # separate boot and deploy interfaces is planned, and moving config"},{"line_number":27,"context_line":"    # options twice is not recommended.  Hence we would move the parameters"},{"line_number":28,"context_line":"    # to the appropriate place in the final refactoring."},{"line_number":29,"context_line":"    # NOTE(rama_y): The above comment pertains to (some of the) options from"},{"line_number":30,"context_line":"    # pxe_append_params up to and including disk_devices."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027pxe_append_params\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027nofb nomodeset vga\u003dnormal\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_09494eb7","line":30,"range":{"start_line":24,"start_character":4,"end_line":30,"end_character":57},"in_reply_to":"9ad45d7e_e9fcbab9","updated":"2016-08-11 17:42:53.000000000","message":"hmm, Vlad, my interpretation of Ramesh\u0027s note is that some of these configs should go into an eg [boot] or [deploy] config group, but honestly, I\u0027m not totally sure what he meant.\n\nI\u0027m fine with deleting it too, if no one knows what it means.","commit_id":"1d8496c517dc138798b148414db0310fac2a39fb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"717766ab2b86005ef7830f557916076bd170cc6c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.StrOpt(\u0027disk_devices\u0027,"},{"line_number":59,"context_line":"               default\u003d\u0027cciss/c0d0,sda,hda,vda\u0027,"},{"line_number":60,"context_line":"               help\u003d_(\u0027The disk devices to scan while doing the deploy.\u0027)),"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027pxe_config_template\u0027,"},{"line_number":63,"context_line":"               default\u003dos.path.join("},{"line_number":64,"context_line":"                   \u0027$pybasedir\u0027, \u0027drivers/modules/pxe_config.template\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9ad45d7e_baf034ca","line":61,"updated":"2016-08-11 22:01:39.000000000","message":"Maybe add a comment here, \u0027End of section related to the above NOTE by rameshg87.\u0027","commit_id":"1d8496c517dc138798b148414db0310fac2a39fb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"29a7a6477fc08eab85683b38e8fed268cb591310","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               default\u003d10080,"},{"line_number":48,"context_line":"               help\u003d_(\u0027Maximum TTL (in minutes) for old master images in \u0027"},{"line_number":49,"context_line":"                      \u0027cache.\u0027)),"},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027disk_devices\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027cciss/c0d0,sda,hda,vda\u0027,"},{"line_number":52,"context_line":"               help\u003d_(\u0027The disk devices to scan while doing the deploy.\u0027)),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027pxe_config_template\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9ad45d7e_e7a96292","line":50,"updated":"2016-08-12 08:36:37.000000000","message":"Disk devices option has to be removed now - https://review.openstack.org/354308","commit_id":"81dd724863220e481c96cc3951750e27ed162cbb"}]}
