)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Devananda van der Veen \u003cdevananda.vdv@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-05 16:25:13 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the api-ref documentation for Root and Nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates the API root documentation, which was non-existent,"},{"line_number":10,"context_line":"and the Node documentation significantly, replacing many of the samples"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_ffc60115","line":7,"updated":"2016-05-06 07:41:59.000000000","message":"Also chassis","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"}],"api-ref/source/baremetal-api-v1-chassis.inc":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":39,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"   - uuid: uuid"},{"line_number":42,"context_line":"   - chassis: chassis"},{"line_number":43,"context_line":"   - description: description"},{"line_number":44,"context_line":"   - extra: extra"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_ea9c626b","line":42,"updated":"2016-05-06 18:00:07.000000000","message":"good idea -- I\u0027ll do that in another patch, when I update the chassis docs","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":39,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"   - uuid: uuid"},{"line_number":42,"context_line":"   - chassis: chassis"},{"line_number":43,"context_line":"   - description: description"},{"line_number":44,"context_line":"   - extra: extra"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_0440db55","line":42,"range":{"start_line":42,"start_character":14,"end_line":42,"end_character":21},"updated":"2016-05-06 07:41:59.000000000","message":"my concern is such as samples/chassis-list-details-response.json, we have \n{\"chassis\": [{\"description\": \"Sample chassis\", \n              \"uuid\": \"fake-uuid\",\n              \"extra\": {}}\n            ]\n}\nextra/uuid/description are part of chassis parameter but we list here like they are the same level.\nSo maybe like \n   - chassis: chassis\n     * uuid: uuid\n     * description: description\n     * extra: extra","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":73,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"   - uuid: uuid"},{"line_number":76,"context_line":"   - chassis: chassis"},{"line_number":77,"context_line":"   - description: description"},{"line_number":78,"context_line":"   - extra: extra"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_4a880e23","line":76,"updated":"2016-05-06 18:00:07.000000000","message":"ditto","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":73,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"   - uuid: uuid"},{"line_number":76,"context_line":"   - chassis: chassis"},{"line_number":77,"context_line":"   - description: description"},{"line_number":78,"context_line":"   - extra: extra"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_ff2442b0","line":76,"range":{"start_line":76,"start_character":3,"end_line":76,"end_character":21},"updated":"2016-05-06 07:41:59.000000000","message":"not return this value in response.","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":109,"context_line":"   :language: javascript"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Response Parameters"},{"line_number":112,"context_line":"-------------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_ffce02b3","line":112,"updated":"2016-05-06 07:41:59.000000000","message":"This should return the same value of \"Show chassis details\" so there is no need to list links/created_at/updated_at/nodes","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":118,"context_line":"   - extra: extra"},{"line_number":119,"context_line":"   - created_at: created_at"},{"line_number":120,"context_line":"   - updated_at: updated_at"},{"line_number":121,"context_line":"   - chassis: chassis"},{"line_number":122,"context_line":"   - nodes: nodes"},{"line_number":123,"context_line":"   - uuid: uuid"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_3f936aa5","line":121,"range":{"start_line":121,"start_character":3,"end_line":121,"end_character":21},"updated":"2016-05-06 07:41:59.000000000","message":"not return this value","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"   - description: description"},{"line_number":174,"context_line":"   - links: links"},{"line_number":175,"context_line":"   - extra: extra"},{"line_number":176,"context_line":"   - created_at: created_at"},{"line_number":177,"context_line":"   - updated_at: updated_at"},{"line_number":178,"context_line":"   - nodes: nodes"},{"line_number":179,"context_line":"   - uuid: uuid"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"List chassis"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_bfd75a22","line":179,"range":{"start_line":173,"start_character":0,"end_line":179,"end_character":15},"updated":"2016-05-06 07:41:59.000000000","message":"ditto","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":177,"context_line":"   - updated_at: updated_at"},{"line_number":178,"context_line":"   - nodes: nodes"},{"line_number":179,"context_line":"   - uuid: uuid"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"List chassis"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_9f1a5616","line":180,"updated":"2016-05-06 07:41:59.000000000","message":"Response Example\n----------------\n\n.. literalinclude:: samples/chassis-show-response.json\n   :language: javascript","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":207,"context_line":"   - uuid: uuid"},{"line_number":208,"context_line":"   - chassis: chassis"},{"line_number":209,"context_line":"   - description: description"},{"line_number":210,"context_line":"   - extra: extra"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Response Example"},{"line_number":213,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_3f79aa30","line":210,"range":{"start_line":210,"start_character":5,"end_line":210,"end_character":17},"updated":"2016-05-06 07:41:59.000000000","message":"no extra parameter in response.","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":213,"context_line":"----------------"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":".. literalinclude:: samples/chassis-list-response.json"},{"line_number":216,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_3fa08a90","line":216,"updated":"2016-05-06 07:41:59.000000000","message":"miss endpoint of \"GET /v1/chassis/(chassis_uuid)/nodes\" or we have this in node.inc?","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"}],"api-ref/source/baremetal-api-v1-node-management.inc":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2c40db6aef149b3aad10b763d5b123f46cfb7f7a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"For example, a Node in the AVAILABLE state can have an instance deployed to it (made \"active\")"},{"line_number":28,"context_line":"by requesting the provision state of ACTIVE. During this transition, the Node\u0027s"},{"line_number":29,"context_line":"provision_state will temporarily become DEPLOYING, and depending on the driver,"},{"line_number":30,"context_line":"it may also become DEPLOYWAIT. To destroy the instance, request the provision"},{"line_number":31,"context_line":"state of DELETE. During this transition, the Node may or may not go through a"},{"line_number":32,"context_line":"CLEANING state, depending on the service configuration."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_b1e90a1d","line":30,"range":{"start_line":30,"start_character":29,"end_line":30,"end_character":30},"updated":"2016-05-09 09:17:18.000000000","message":"Mostly a nit, but would be good to clarify that after the transition is completed, target_provision_state will be set to None.","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7c29bdb9109c2470ff1c8737140a3e16e7a5ace2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"For example, a Node in the AVAILABLE state can have an instance deployed to it (made \"active\")"},{"line_number":28,"context_line":"by requesting the provision state of ACTIVE. During this transition, the Node\u0027s"},{"line_number":29,"context_line":"provision_state will temporarily become DEPLOYING, and depending on the driver,"},{"line_number":30,"context_line":"it may also become DEPLOYWAIT. To destroy the instance, request the provision"},{"line_number":31,"context_line":"state of DELETE. During this transition, the Node may or may not go through a"},{"line_number":32,"context_line":"CLEANING state, depending on the service configuration."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_cefe4dad","line":30,"updated":"2016-05-10 19:11:59.000000000","message":"done","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e9a1eaefde91b03cff29e66f267fb2d47f126eec","unresolved":false,"context_lines":[{"line_number":106,"context_line":".. rest_method:: DELETE /v1/nodes/{node_ident}/maintenance"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"The maintenance flag is unset by sending a DELETE request to this endpoint."},{"line_number":109,"context_line":"If the request is accepted, Ironic will also clearthe ``maintenance_reason``"},{"line_number":110,"context_line":"field."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Normal response code: 202"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_deaf4428","line":109,"range":{"start_line":109,"start_character":45,"end_line":109,"end_character":53},"updated":"2016-05-10 08:29:39.000000000","message":"s/clearthe/clear the/","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7c29bdb9109c2470ff1c8737140a3e16e7a5ace2","unresolved":false,"context_lines":[{"line_number":124,"context_line":".. rest_method:: PUT /v1/nodes/{node_ident}/management/boot_device"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Set the boot device for the given Node, and set it persistently or for one-time"},{"line_number":127,"context_line":"boot. The exact behavior of this depends on the hardware driver."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"NOTE: In some drivers, eg. \"ipmitool\", this method initiates a synchronous call"},{"line_number":130,"context_line":"to the hardware management device (BMC). It should be used with caution! This"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_2e2ef942","line":127,"updated":"2016-05-10 19:11:59.000000000","message":"done","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e9a1eaefde91b03cff29e66f267fb2d47f126eec","unresolved":false,"context_lines":[{"line_number":124,"context_line":".. rest_method:: PUT /v1/nodes/{node_ident}/management/boot_device"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Set the boot device for the given Node, and set it persistently or for one-time"},{"line_number":127,"context_line":"boot. The exact behavior of this depends on the hardware driver."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"NOTE: In some drivers, eg. \"ipmitool\", this method initiates a synchronous call"},{"line_number":130,"context_line":"to the hardware management device (BMC). It should be used with caution! This"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_beb40082","line":127,"range":{"start_line":127,"start_character":16,"end_line":127,"end_character":24},"updated":"2016-05-10 08:29:39.000000000","message":"s/behavior/behaviour","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"bb9d68e4974e5b9f79a1d7ada8e7ce183c592b66","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"For example, a Node in the AVAILABLE state can have an instance deployed to it (made \"active\")"},{"line_number":28,"context_line":"by requesting the provision state of ACTIVE. During this transition, the Node\u0027s"},{"line_number":29,"context_line":"``provision_state` will temporarily become DEPLOYING, and depending on the driver,"},{"line_number":30,"context_line":"it may also become DEPLOYWAIT. When the transition is complete, ``target_provision_state``"},{"line_number":31,"context_line":"will be set to \"None\". To destroy the instance, request the provision"},{"line_number":32,"context_line":"state of DELETE. During this transition, the Node may or may not go through a"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"dab17558_b974e835","line":29,"range":{"start_line":29,"start_character":17,"end_line":29,"end_character":18},"updated":"2016-05-11 02:59:06.000000000","message":"s/\u0027/\u0027\u0027/\nThis will cause a format issue","commit_id":"50b56ab07b9f5ea2fb8d49029047d20651199dfd"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"by requesting the provision state of ACTIVE. During this transition, the Node\u0027s"},{"line_number":29,"context_line":"``provision_state`` will temporarily become DEPLOYING, and depending on the driver,"},{"line_number":30,"context_line":"it may also become DEPLOYWAIT. When the transition is complete, ``target_provision_state``"},{"line_number":31,"context_line":"will be set to \"None\". To destroy the instance, request the provision"},{"line_number":32,"context_line":"state of DELETE. During this transition, the Node may or may not go through a"},{"line_number":33,"context_line":"CLEANING state, depending on the service configuration."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_7f458d15","line":31,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"by requesting the provision state of ACTIVE. During this transition, the Node\u0027s"},{"line_number":29,"context_line":"``provision_state`` will temporarily become DEPLOYING, and depending on the driver,"},{"line_number":30,"context_line":"it may also become DEPLOYWAIT. When the transition is complete, ``target_provision_state``"},{"line_number":31,"context_line":"will be set to \"None\". To destroy the instance, request the provision"},{"line_number":32,"context_line":"state of DELETE. During this transition, the Node may or may not go through a"},{"line_number":33,"context_line":"CLEANING state, depending on the service configuration."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_9cf1c2d0","line":31,"updated":"2016-05-18 09:13:58.000000000","message":"nit: ``None``","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Request that Ironic set the maintenance flag on the Node. This will disable"},{"line_number":86,"context_line":"certain automatic actions that the Node\u0027s driver may take, and remove"},{"line_number":87,"context_line":"the Node from Nova\u0027s available resource pool."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Normal response code: 202"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_7cee9eed","line":87,"updated":"2016-05-18 09:13:58.000000000","message":"Maybe elaborate here (even if we do it somewhere else) on what maintenance is for?","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"Set the boot device for the given Node, and set it persistently or for one-time"},{"line_number":127,"context_line":"boot. The exact behaviour of this depends on the hardware driver."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"NOTE: In some drivers, eg. \"ipmitool\", this method initiates a synchronous call"},{"line_number":130,"context_line":"to the hardware management device (BMC). It should be used with caution! This"},{"line_number":131,"context_line":"is `a known bug \u003chttps://bugs.launchpad.net/ironic/+bug/1427923\u003e`_."},{"line_number":132,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_dcb98aee","line":129,"updated":"2016-05-18 09:13:58.000000000","message":"1. maybe use an RST .. note:: syntax?\n\n2. s/\"ipmitool\"/the ``*_ipmitool`` family/","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":130,"context_line":"to the hardware management device (BMC). It should be used with caution! This"},{"line_number":131,"context_line":"is `a known bug \u003chttps://bugs.launchpad.net/ironic/+bug/1427923\u003e`_."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"NOTE: Some drivers do not support one-time boot, and always set the boot device"},{"line_number":134,"context_line":"persistently."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Normal response code: 204"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_bcbe46d2","line":133,"updated":"2016-05-18 09:13:58.000000000","message":"ditto about note syntax","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"to the hardware management device (BMC). It should be used with caution! This"},{"line_number":131,"context_line":"is `a known bug \u003chttps://bugs.launchpad.net/ironic/+bug/1427923\u003e`_."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"NOTE: Some drivers do not support one-time boot, and always set the boot device"},{"line_number":134,"context_line":"persistently."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Normal response code: 204"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_df4c7944","line":133,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Get the current boot device for the given Node."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"NOTE: In some drivers, eg. \"ipmitool\", this method initiates a synchronous call"},{"line_number":160,"context_line":"to the hardware management device (BMC). It should be used with caution! This"},{"line_number":161,"context_line":"is `a known bug \u003chttps://bugs.launchpad.net/ironic/+bug/1427923\u003e`_."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_1cb4b2f0","line":159,"updated":"2016-05-18 09:13:58.000000000","message":"ditto as above","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Get the current boot device for the given Node."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"NOTE: In some drivers, eg. \"ipmitool\", this method initiates a synchronous call"},{"line_number":160,"context_line":"to the hardware management device (BMC). It should be used with caution! This"},{"line_number":161,"context_line":"is `a known bug \u003chttps://bugs.launchpad.net/ironic/+bug/1427923\u003e`_."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_bf47f51b","line":159,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Normal response code: 202"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Error codes: 409 (NodeLocked, ClientError) 400 (InvalidState, NodeInMaintenance) 406 (NotAcceptable) 503 (NoFreeConductorWorkers)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"Request"},{"line_number":289,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_fcb8cee7","line":286,"updated":"2016-05-18 09:13:58.000000000","message":"please convert this to a list","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Normal response code: 202"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Error codes: 409 (NodeLocked, ClientError) 400 (InvalidState, NodeInMaintenance) 406 (NotAcceptable) 503 (NoFreeConductorWorkers)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"Request"},{"line_number":289,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_1f5721cf","line":286,"updated":"2016-05-19 18:10:31.000000000","message":"this formatting is copied from the Nova API Ref","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Set the target RAID config of the Node. The ``target_raid_config`` property"},{"line_number":313,"context_line":"is structured JSON, and is validated by the driver upon receipt. The request"},{"line_number":314,"context_line":"schema is defined in the `documentation for the RAID feature \u003chttp://docs.openstack.org/developer/ironic/deploy/raid.html\u003e`_"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"Added in API microversion: 1.12"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_5cce3a84","line":314,"updated":"2016-05-18 09:13:58.000000000","message":"Lets explicitly mention that this call does not apply the configuration, only stores it.","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Set the target RAID config of the Node. The ``target_raid_config`` property"},{"line_number":313,"context_line":"is structured JSON, and is validated by the driver upon receipt. The request"},{"line_number":314,"context_line":"schema is defined in the `documentation for the RAID feature \u003chttp://docs.openstack.org/developer/ironic/deploy/raid.html\u003e`_"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"Added in API microversion: 1.12"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_ff517dd9","line":314,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":347,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    - node_ident: node_ident"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Start/Stop Console"},{"line_number":353,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_3ccb7674","line":350,"updated":"2016-05-18 09:13:58.000000000","message":"Response?","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":347,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    - node_ident: node_ident"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"Start/Stop Console"},{"line_number":353,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_5f5fe9e4","line":350,"updated":"2016-05-19 18:10:31.000000000","message":"see the TODO above -- I didn\u0027t have ready access to a system to generate samples for these calls that are actually representative of using them, and do not want to put in completely fictitious data.\n\nResponse samples should be added, but in another patch, or by someone who can generate them, or after I figure out how to.","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e65a523ad4b1147a299a4640e90357635836d39","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Request that Ironic set the maintenance flag on the Node. This will disable"},{"line_number":86,"context_line":"certain automatic actions that the Node\u0027s driver may take, and remove"},{"line_number":87,"context_line":"the Node from Nova\u0027s available resource pool."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Normal response code: 202"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bab6814e_ace698ad","line":87,"updated":"2016-05-20 08:18:27.000000000","message":"I\u0027d still like to see explanation here what maintenance is about.","commit_id":"8de8b6bfd939e43dd86aa73cdd92819194297260"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"b88fd0690573fdc866f19f8eff8241ab5e95e991","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Request that Ironic set the maintenance flag on the Node. This will disable"},{"line_number":86,"context_line":"certain automatic actions that the Node\u0027s driver may take, and remove"},{"line_number":87,"context_line":"the Node from Nova\u0027s available resource pool."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Normal response code: 202"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bab6814e_23f8ddc2","line":87,"updated":"2016-05-20 15:35:12.000000000","message":"I\u0027ve searched our docs but all I see right now is this:\nhttp://docs.openstack.org/developer/ironic/deploy/install-guide.html?highlight\u003dmaintenance#maintenance-mode\n\nI think we need better docs on what Maintenance Mode is, but I don\u0027t think this is the right place for it.","commit_id":"8de8b6bfd939e43dd86aa73cdd92819194297260"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e65a523ad4b1147a299a4640e90357635836d39","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Normal response code: 202"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Error codes: 409 (NodeLocked, ClientError) 400 (InvalidState, NodeInMaintenance) 406 (NotAcceptable) 503 (NoFreeConductorWorkers)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"Request"},{"line_number":289,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bab6814e_0c8fe4cc","line":286,"updated":"2016-05-20 08:18:27.000000000","message":"I understand it\u0027s copied, but it looks super ugly. Lets fix it eventually.","commit_id":"8de8b6bfd939e43dd86aa73cdd92819194297260"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"b88fd0690573fdc866f19f8eff8241ab5e95e991","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Normal response code: 202"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Error codes: 409 (NodeLocked, ClientError) 400 (InvalidState, NodeInMaintenance) 406 (NotAcceptable) 503 (NoFreeConductorWorkers)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"Request"},{"line_number":289,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bab6814e_8301c9b1","line":286,"updated":"2016-05-20 15:35:12.000000000","message":"done","commit_id":"8de8b6bfd939e43dd86aa73cdd92819194297260"}],"api-ref/source/baremetal-api-v1-node-passthru.inc":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":38,"context_line":"**Example vendor passthru methods:**"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. literalinclude: samples/node-vendor-passthru-response.json"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_2a8dca31","line":41,"updated":"2016-05-06 18:00:07.000000000","message":"ah! thanks for spotting that","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":38,"context_line":"**Example vendor passthru methods:**"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. literalinclude: samples/node-vendor-passthru-response.json"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_1fa4a555","line":41,"updated":"2016-05-06 07:41:59.000000000","message":"miss endpoint:\n/v1/nodes/(node_ident)/vendor_passthru/method","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"**Example passthru methods listing:**"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. literalinclude: samples/node-vendor-passthru-response.json"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Call a Method"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_ffba1d09","line":49,"updated":"2016-05-19 18:10:31.000000000","message":"oops - missing the double colon. Fixed it.","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"**Example passthru methods listing:**"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. literalinclude: samples/node-vendor-passthru-response.json"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Call a Method"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_1cddd242","line":49,"updated":"2016-05-18 09:13:58.000000000","message":"this renders empty: http://docs-draft.openstack.org/95/312795/6/check/gate-ironic-api-ref/bd851db//api-ref/build/html/#list-methods","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"}],"api-ref/source/baremetal-api-v1-nodes.inc":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    - console_enabled: console_enabled"},{"line_number":75,"context_line":"    - clean_step: clean_step"},{"line_number":76,"context_line":"    - raid_config: raid_config"},{"line_number":77,"context_line":"    - target_raid_config: target_raid_config"},{"line_number":78,"context_line":"    - links: links"},{"line_number":79,"context_line":"    - ports: n_ports"},{"line_number":80,"context_line":"    - states: n_states"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_aacb7a71","line":77,"updated":"2016-05-06 18:00:07.000000000","message":"done","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    - instance_uuid: instance_uuid"},{"line_number":74,"context_line":"    - console_enabled: console_enabled"},{"line_number":75,"context_line":"    - clean_step: clean_step"},{"line_number":76,"context_line":"    - raid_config: raid_config"},{"line_number":77,"context_line":"    - target_raid_config: target_raid_config"},{"line_number":78,"context_line":"    - links: links"},{"line_number":79,"context_line":"    - ports: n_ports"},{"line_number":80,"context_line":"    - states: n_states"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_7f417139","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":44},"updated":"2016-05-06 07:41:59.000000000","message":"these two are only available after API microversion 1.12, better to explain it somewhere.","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    - target_raid_config: target_raid_config"},{"line_number":78,"context_line":"    - links: links"},{"line_number":79,"context_line":"    - ports: n_ports"},{"line_number":80,"context_line":"    - states: n_states"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"**Example JSON representation of a Node:**"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_0ac9e678","line":80,"updated":"2016-05-06 18:00:07.000000000","message":"done","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    - target_raid_config: target_raid_config"},{"line_number":78,"context_line":"    - links: links"},{"line_number":79,"context_line":"    - ports: n_ports"},{"line_number":80,"context_line":"    - states: n_states"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"**Example JSON representation of a Node:**"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_bf647a49","line":80,"updated":"2016-05-06 07:41:59.000000000","message":"miss two paramters: extra and chassis_uuid","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2ec6e1b32f8d93fe8f56721f85b4e9bd142ff18","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Normal response codes: 200"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Error response codes: 413,405,404,403,401,400,503,"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Request"},{"line_number":107,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_a8e27d9d","line":104,"range":{"start_line":104,"start_character":30,"end_line":104,"end_character":33},"updated":"2016-05-06 09:05:58.000000000","message":"I don\u0027t think we will ever get a 404 by a GET in this endpoint, since it\u0027s a collection of items if no item is present it will return an empty list","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2ec6e1b32f8d93fe8f56721f85b4e9bd142ff18","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Normal response codes: 200"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Error response codes: 413,405,404,403,401,400,503,"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Request"},{"line_number":107,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_4844b173","line":104,"range":{"start_line":104,"start_character":46,"end_line":104,"end_character":49},"updated":"2016-05-06 09:05:58.000000000","message":"Not sure if we should have 5xx errors here, I mean it\u0027s not part of the API if it\u0027s unavailable. \n\nThe way I see APIs is that it should never return 5xx intentionally, these errors are always a bug.","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Normal response codes: 200"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Error response codes: 413,405,404,403,401,400,503,"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Request"},{"line_number":107,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_eac5825b","line":104,"updated":"2016-05-06 18:00:07.000000000","message":"yea ... I\u0027m just going to delete all of these, since I haven\u0027t audited them","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2ec6e1b32f8d93fe8f56721f85b4e9bd142ff18","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Normal response codes: 200 OK"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Error response codes: 413,405,404,403,401,400,503,"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Request"},{"line_number":154,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_089589e3","line":151,"range":{"start_line":151,"start_character":30,"end_line":151,"end_character":33},"updated":"2016-05-06 09:05:58.000000000","message":"ditto 404","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2ec6e1b32f8d93fe8f56721f85b4e9bd142ff18","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Normal response codes: 200 OK"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Error response codes: 413,405,404,403,401,400,503,"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Request"},{"line_number":154,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_c858a159","line":151,"range":{"start_line":151,"start_character":46,"end_line":151,"end_character":49},"updated":"2016-05-06 09:05:58.000000000","message":"ditto 5xx errors","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Normal response codes: 200 OK"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Error response codes: 413,405,404,403,401,400,503,"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Request"},{"line_number":154,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_4aa12ea9","line":151,"updated":"2016-05-06 18:00:07.000000000","message":"ditto removing for now, we should add in a follow on patch after auditing it","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    - target_raid_config: target_raid_config"},{"line_number":193,"context_line":"    - links: links"},{"line_number":194,"context_line":"    - ports: n_ports"},{"line_number":195,"context_line":"    - states: n_states"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"**Example detailed list of Nodes:**"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_3f6ec9c9","line":195,"updated":"2016-05-06 07:41:59.000000000","message":"ditto for extra and chassis_uuid","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    - target_raid_config: target_raid_config"},{"line_number":193,"context_line":"    - links: links"},{"line_number":194,"context_line":"    - ports: n_ports"},{"line_number":195,"context_line":"    - states: n_states"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"**Example detailed list of Nodes:**"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_2aa66ac1","line":195,"updated":"2016-05-06 18:00:07.000000000","message":"done","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2ec6e1b32f8d93fe8f56721f85b4e9bd142ff18","unresolved":false,"context_lines":[{"line_number":203,"context_line":"Show Node Details"},{"line_number":204,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":".. rest_method::  GET /v1/nodes/{node_ident}"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Shows details for a node. By default, this will return the full representation"},{"line_number":209,"context_line":"of the resource; an optional ``fields`` parameter can be supplied to return"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_888979cd","line":206,"range":{"start_line":206,"start_character":33,"end_line":206,"end_character":43},"updated":"2016-05-06 09:05:58.000000000","message":"Quick q: Not sure if needed, but would be good to say that node_ident can be either the UUID (canonical identifier) or the name of the node?","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":203,"context_line":"Show Node Details"},{"line_number":204,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":".. rest_method::  GET /v1/nodes/{node_ident}"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Shows details for a node. By default, this will return the full representation"},{"line_number":209,"context_line":"of the resource; an optional ``fields`` parameter can be supplied to return"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_8aab1689","line":206,"updated":"2016-05-06 18:00:07.000000000","message":"There is an explanation of this at the top of this document, and the rendered table for the Request parameter list also explains what node_ident is.\n\nSo I don\u0027t feel like it\u0027s needed to repeat it in this paragraph, personally.","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2ec6e1b32f8d93fe8f56721f85b4e9bd142ff18","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Normal response codes: 200 OK"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Error response codes: 413,405,404,403,401,400,503,"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Request"},{"line_number":217,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_0831090c","line":214,"range":{"start_line":214,"start_character":46,"end_line":214,"end_character":49},"updated":"2016-05-06 09:05:58.000000000","message":"ditto 5xx errors","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"Normal response codes: 200 OK"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Error response codes: 413,405,404,403,401,400,503,"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Request"},{"line_number":217,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_6ab072f5","line":214,"updated":"2016-05-06 18:00:07.000000000","message":"ditto removing","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    - node_ident: node_ident"},{"line_number":222,"context_line":"    - fields: fields"},{"line_number":223,"context_line":"    - instance_uuid: r_instance_uuid"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Response Example"},{"line_number":226,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_ca951e41","line":223,"updated":"2016-05-06 18:00:07.000000000","message":"Oh - good catch. That doesn\u0027t belong here. instance_uuid filtering does not happen when there is a {node_ident} in the query string.","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    - node_ident: node_ident"},{"line_number":222,"context_line":"    - fields: fields"},{"line_number":223,"context_line":"    - instance_uuid: r_instance_uuid"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Response Example"},{"line_number":226,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_bfbe39fd","line":223,"updated":"2016-05-06 07:41:59.000000000","message":"better to explain how to make use this above too.\nBut I am not quite sure we should add it here because the endpoint is:\nGET /v1/nodes/detail?instance_uuid\nGET /v1/nodes/?instance_uuid\u0026fields","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    - target_raid_config: target_raid_config"},{"line_number":250,"context_line":"    - links: links"},{"line_number":251,"context_line":"    - ports: n_ports"},{"line_number":252,"context_line":"    - states: n_states"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"**Example JSON representation of a Node:**"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_ffcf21b1","line":252,"updated":"2016-05-06 07:41:59.000000000","message":"ditto for extra and chassis_uuid","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    - target_raid_config: target_raid_config"},{"line_number":250,"context_line":"    - links: links"},{"line_number":251,"context_line":"    - ports: n_ports"},{"line_number":252,"context_line":"    - states: n_states"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"**Example JSON representation of a Node:**"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_aa925a55","line":252,"updated":"2016-05-06 18:00:07.000000000","message":"done","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2ec6e1b32f8d93fe8f56721f85b4e9bd142ff18","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"Normal response codes: 204 NO CONTENT"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"Error response codes: 413,415,405,404,403,401,400,503,409,"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"Request"},{"line_number":335,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_e835a5f7","line":332,"range":{"start_line":332,"start_character":50,"end_line":332,"end_character":53},"updated":"2016-05-06 09:05:58.000000000","message":"ditto 5xx errors","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d9372885e70df6ebc69aecd828acba8d425f9f81","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"   - node_ident: node_ident"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_0aa0c69e","line":339,"updated":"2016-05-06 18:00:07.000000000","message":"good catch, thanks. adding in a new file in the next patch","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91fcc84cd12232ff1a677397bb8cb6ffa71b9f24","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"   - node_ident: node_ident"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_7f6df131","line":339,"updated":"2016-05-06 07:41:59.000000000","message":"miss endpoint\nGET /v1/nodes/node_ident/ports\nGET /v1/nodes/node_ident/ports/details","commit_id":"3af2ccf8d9d24faf25734942354f15769f541661"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7c29bdb9109c2470ff1c8737140a3e16e7a5ace2","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example JSON representation of a Node:**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: samples/node-show-response.json"},{"line_number":100,"context_line":"   :language: javascript"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_8ef8c5c4","line":99,"updated":"2016-05-10 19:11:59.000000000","message":"done","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"5245e20ea31bc841e50dcb507312ce7ad277b3a2","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example JSON representation of a Node:**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: samples/node-show-response.json"},{"line_number":100,"context_line":"   :language: javascript"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_2bfac7bd","line":99,"range":{"start_line":99,"start_character":20,"end_line":99,"end_character":51},"updated":"2016-05-09 07:55:22.000000000","message":"you have node-create-response.json but use node-show-response.json here? either you should use node-create-response.json or delete it.","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2c40db6aef149b3aad10b763d5b123f46cfb7f7a","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example JSON representation of a Node:**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: samples/node-show-response.json"},{"line_number":100,"context_line":"   :language: javascript"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_7104c2bf","line":99,"range":{"start_line":99,"start_character":20,"end_line":99,"end_character":51},"in_reply_to":"dab17558_2bfac7bd","updated":"2016-05-09 09:17:18.000000000","message":"I believe node-node-create-response.json still valid for things like \"updated_at\" that should be None at creation time, but will probably be set on the node-show (due the periodic tasks).\n\nLooking at the json, node-show-response.json do have update_at set, so it\u0027s a inconsistent here.","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"use the new \"Available\" state name."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"API microversion 1.11 changed the default initial state of newly-created Nodes"},{"line_number":37,"context_line":"from \"Available\" to the \"Enroll\" state."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Normal response codes: 201"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_3c1d3610","line":37,"updated":"2016-05-18 09:13:58.000000000","message":"I\u0027d prefer states to be all lower case, just as we return them. I\u0027d personally also format them somehow, e.g. ``enroll``.","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":52,"context_line":".. literalinclude:: samples/node-create-request.json"},{"line_number":53,"context_line":"   :language: javascript"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Response Example"},{"line_number":56,"context_line":"----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The response will contain the complete Node record, with the supplied data,"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_7fce2db5","line":55,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":52,"context_line":".. literalinclude:: samples/node-create-request.json"},{"line_number":53,"context_line":"   :language: javascript"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Response Example"},{"line_number":56,"context_line":"----------------"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The response will contain the complete Node record, with the supplied data,"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_9c1a6216","line":55,"updated":"2016-05-18 09:13:58.000000000","message":"s/Example//\n\nthis section is not only about an example really (the same applies everywhere)","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"and any defaults added for non-specified fields. Most fields default to \"null\""},{"line_number":60,"context_line":"or \"\"."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"API microversion 1.5 introduced the ``node_name`` field."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"API microversion 1.7 introduced the ``clean_step`` field`"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_dfc5998e","line":62,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"and any defaults added for non-specified fields. Most fields default to \"null\""},{"line_number":60,"context_line":"or \"\"."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"API microversion 1.5 introduced the ``node_name`` field."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"API microversion 1.7 introduced the ``clean_step`` field`"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_7c17beed","line":62,"updated":"2016-05-18 09:13:58.000000000","message":"s/node_name/name/","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    - ports: n_ports"},{"line_number":95,"context_line":"    - states: n_states"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example JSON representation of a Node:**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: samples/node-create-response.json"},{"line_number":100,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_bfc0957d","line":97,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    - ports: n_ports"},{"line_number":95,"context_line":"    - states: n_states"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**Example JSON representation of a Node:**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. literalinclude:: samples/node-create-response.json"},{"line_number":100,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_dcd22a34","line":97,"updated":"2016-05-18 09:13:58.000000000","message":"please mention the API version with which this example was created","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"status of each Node. Some filtering is possible by passing in flags with the"},{"line_number":110,"context_line":"request."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"By default, this query will return the name, uuid, instance uuid, power status,"},{"line_number":113,"context_line":"provision status, and maintenance status for each Node."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"API microversion 1.8 added the ``fields`` Request parameter. When specified,"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_1fc0c17a","line":112,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"status of each Node. Some filtering is possible by passing in flags with the"},{"line_number":110,"context_line":"request."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"By default, this query will return the name, uuid, instance uuid, power status,"},{"line_number":113,"context_line":"provision status, and maintenance status for each Node."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"API microversion 1.8 added the ``fields`` Request parameter. When specified,"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bab6814e_bcd76622","line":112,"updated":"2016-05-18 09:13:58.000000000","message":"s/power status/power state/, ditto for provision","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e65a523ad4b1147a299a4640e90357635836d39","unresolved":false,"context_lines":[{"line_number":34,"context_line":"use the new \"Available\" state name."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"API microversion 1.11 changed the default initial state of newly-created Nodes"},{"line_number":37,"context_line":"from \"Available\" to the \"Enroll\" state."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Normal response codes: 201"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bab6814e_0c54041f","line":37,"range":{"start_line":37,"start_character":5,"end_line":37,"end_character":33},"updated":"2016-05-20 08:18:27.000000000","message":"I\u0027d prefer states to be all lower case, just as we return them. I\u0027d personally also format them somehow, e.g. ``enroll``.","commit_id":"8de8b6bfd939e43dd86aa73cdd92819194297260"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"b88fd0690573fdc866f19f8eff8241ab5e95e991","unresolved":false,"context_lines":[{"line_number":34,"context_line":"use the new \"Available\" state name."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"API microversion 1.11 changed the default initial state of newly-created Nodes"},{"line_number":37,"context_line":"from \"Available\" to the \"Enroll\" state."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Normal response codes: 201"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bab6814e_e311b505","line":37,"updated":"2016-05-20 15:35:12.000000000","message":"done","commit_id":"8de8b6bfd939e43dd86aa73cdd92819194297260"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e65a523ad4b1147a299a4640e90357635836d39","unresolved":false,"context_lines":[{"line_number":66,"context_line":"API microversion 1.12 introduced support for the ``raid_config`` and"},{"line_number":67,"context_line":"``target_raid_config`` fields."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The list and example below are representative of the response as of API microversion 1.16"},{"line_number":70,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    - uuid: node_uuid"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bab6814e_6c331015","line":69,"updated":"2016-05-20 08:18:27.000000000","message":"nit: dot in the end\n\nnot a nit: a newline is required, otherwise rest_parameters does not render","commit_id":"8de8b6bfd939e43dd86aa73cdd92819194297260"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"b88fd0690573fdc866f19f8eff8241ab5e95e991","unresolved":false,"context_lines":[{"line_number":66,"context_line":"API microversion 1.12 introduced support for the ``raid_config`` and"},{"line_number":67,"context_line":"``target_raid_config`` fields."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The list and example below are representative of the response as of API microversion 1.16"},{"line_number":70,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    - uuid: node_uuid"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bab6814e_43fb61c1","line":69,"updated":"2016-05-20 15:35:12.000000000","message":"oops!","commit_id":"8de8b6bfd939e43dd86aa73cdd92819194297260"}],"api-ref/source/baremetal-api-versions.inc":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7c29bdb9109c2470ff1c8737140a3e16e7a5ace2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Beginning with the Kilo release, all API requests support the"},{"line_number":18,"context_line":"``X-OpenStack-Ironic-API-Version`` header. This header SHOULD be supplied"},{"line_number":19,"context_line":"with every request; in the absense of this header, each request is treated"},{"line_number":20,"context_line":"as though coming from an older pre-Kilo client. This was done to preserve"},{"line_number":21,"context_line":"backwards compatibility as we introduced new features in the server."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_ee0191b0","line":19,"updated":"2016-05-10 19:11:59.000000000","message":"done","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e9a1eaefde91b03cff29e66f267fb2d47f126eec","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Beginning with the Kilo release, all API requests support the"},{"line_number":18,"context_line":"``X-OpenStack-Ironic-API-Version`` header. This header SHOULD be supplied"},{"line_number":19,"context_line":"with every request; in the absense of this header, each request is treated"},{"line_number":20,"context_line":"as though coming from an older pre-Kilo client. This was done to preserve"},{"line_number":21,"context_line":"backwards compatibility as we introduced new features in the server."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_f9150240","line":19,"range":{"start_line":19,"start_character":27,"end_line":19,"end_character":34},"updated":"2016-05-10 08:29:39.000000000","message":"s/absense/absence/","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# variables in header"},{"line_number":2,"context_line":"x-openstack-request-id:"},{"line_number":3,"context_line":"  description: \u003e"},{"line_number":4,"context_line":"    A unique ID for tracking the request. The request ID associated with the request"},{"line_number":5,"context_line":"    appears in the log lines for that request. By default, the middleware configuration"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_ca3781e1","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":23},"updated":"2016-05-05 09:23:55.000000000","message":"This seems out-of-date, ironic receive Openstack-Request-Id follow the HTTP header guidelines https://specs.openstack.org/openstack/api-wg/guidelines/headers.html","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  in: header"},{"line_number":19,"context_line":"  required: true"},{"line_number":20,"context_line":"  type: string"},{"line_number":21,"context_line":"header_version:"},{"line_number":22,"context_line":"  description: |"},{"line_number":23,"context_line":"    Specific API microversion used to generate this response."},{"line_number":24,"context_line":"  in: header"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_8a0d8991","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":14},"updated":"2016-05-05 09:23:55.000000000","message":"This is the same x-openstack-ironic-api-version header but in response, do we need to add a new attribute to indicate the parameter is in response or request?","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  in: header"},{"line_number":25,"context_line":"  required: true"},{"line_number":26,"context_line":"  type: string"},{"line_number":27,"context_line":"min_version:"},{"line_number":28,"context_line":"  description: |"},{"line_number":29,"context_line":"    Minimum API microversion supported by this endpoint, eg. \"1.1\""},{"line_number":30,"context_line":"  in: header"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_4abff1cf","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":11},"updated":"2016-05-05 09:23:55.000000000","message":"s/min_version/X-Openstack-Ironic-Api-Minimal-Version","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8327cdb404405d65a53eb2313ec524e78c88f311","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  in: header"},{"line_number":31,"context_line":"  required: true"},{"line_number":32,"context_line":"  type: string"},{"line_number":33,"context_line":"max_version:"},{"line_number":34,"context_line":"  description: |"},{"line_number":35,"context_line":"    Maximum API microversion supported by this endpoint, eg. \"1.16\""},{"line_number":36,"context_line":"  in: header"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_7cd89fef","line":33,"updated":"2016-05-05 17:34:01.000000000","message":"ditto","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  in: header"},{"line_number":31,"context_line":"  required: true"},{"line_number":32,"context_line":"  type: string"},{"line_number":33,"context_line":"max_version:"},{"line_number":34,"context_line":"  description: |"},{"line_number":35,"context_line":"    Maximum API microversion supported by this endpoint, eg. \"1.16\""},{"line_number":36,"context_line":"  in: header"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_eae7dd0f","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":11},"updated":"2016-05-05 09:23:55.000000000","message":"s/max_version/X-Openstack-Ironic-Api-Maximum-Version/","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  type: string"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# variables in path"},{"line_number":41,"context_line":"driver_ident:"},{"line_number":42,"context_line":"  description: |"},{"line_number":43,"context_line":"    The name of the driver."},{"line_number":44,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_ea77ddd1","line":41,"updated":"2016-05-05 09:23:55.000000000","message":"I am not quite understand why do you change the name of variables because we only have driver_name in code, especially you used node_id and node_ident and the later one support both of name and UUID. I am afraid there will mislead users.","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8327cdb404405d65a53eb2313ec524e78c88f311","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  type: string"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# variables in path"},{"line_number":41,"context_line":"driver_ident:"},{"line_number":42,"context_line":"  description: |"},{"line_number":43,"context_line":"    The name of the driver."},{"line_number":44,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_dce1f39c","line":41,"updated":"2016-05-05 17:34:01.000000000","message":"again, these are variable names, referenced from the .inc files. I use different names here to differentiate between situations where it is in the path or the body, and where the description is different.","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  in: path"},{"line_number":57,"context_line":"  required: true"},{"line_number":58,"context_line":"  type: string"},{"line_number":59,"context_line":"port_ident:"},{"line_number":60,"context_line":"  description: |"},{"line_number":61,"context_line":"    The UUID of the port."},{"line_number":62,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_0a8df9d2","line":59,"updated":"2016-05-05 09:23:55.000000000","message":"ditto we only have port_uuid","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  in: path"},{"line_number":63,"context_line":"  required: true"},{"line_number":64,"context_line":"  type: string"},{"line_number":65,"context_line":"chassis_ident:"},{"line_number":66,"context_line":"  description: |"},{"line_number":67,"context_line":"    The UUID of the chassis."},{"line_number":68,"context_line":"  in: path"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_ea023d3d","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":13},"updated":"2016-05-05 09:23:55.000000000","message":"ditto we only have chassis_uuid","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8327cdb404405d65a53eb2313ec524e78c88f311","unresolved":false,"context_lines":[{"line_number":74,"context_line":"r_maintenance:"},{"line_number":75,"context_line":"  description: |"},{"line_number":76,"context_line":"    Filter the list of returned nodes and only return those with"},{"line_number":77,"context_line":"    ``maintenance`` set to to ``True`` or ``False``."},{"line_number":78,"context_line":"  in: query"},{"line_number":79,"context_line":"  required: false"},{"line_number":80,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_bcdeb7d7","line":77,"updated":"2016-05-05 17:34:01.000000000","message":"done","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"r_maintenance:"},{"line_number":75,"context_line":"  description: |"},{"line_number":76,"context_line":"    Filter the list of returned nodes and only return those with"},{"line_number":77,"context_line":"    ``maintenance`` set to to ``True`` or ``False``."},{"line_number":78,"context_line":"  in: query"},{"line_number":79,"context_line":"  required: false"},{"line_number":80,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_7eeeee22","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":29},"updated":"2016-05-05 09:23:55.000000000","message":"s/to//","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8327cdb404405d65a53eb2313ec524e78c88f311","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  type: string"},{"line_number":102,"context_line":"r_instance_uuid:"},{"line_number":103,"context_line":"  description: |"},{"line_number":104,"context_line":"    UUID of an instance"},{"line_number":105,"context_line":"  in: query"},{"line_number":106,"context_line":"  required: false"},{"line_number":107,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_1ceecb8a","line":104,"updated":"2016-05-05 17:34:01.000000000","message":"done","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  type: string"},{"line_number":102,"context_line":"r_instance_uuid:"},{"line_number":103,"context_line":"  description: |"},{"line_number":104,"context_line":"    UUID of an instance"},{"line_number":105,"context_line":"  in: query"},{"line_number":106,"context_line":"  required: false"},{"line_number":107,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_7ed8ae53","line":104,"range":{"start_line":104,"start_character":4,"end_line":104,"end_character":22},"updated":"2016-05-05 09:23:55.000000000","message":"retrieve a node by its instance uuid","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8327cdb404405d65a53eb2313ec524e78c88f311","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    bookmark links."},{"line_number":196,"context_line":"  in: body"},{"line_number":197,"context_line":"  required: true"},{"line_number":198,"context_line":"  type: array"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# variables when creating or updating a Node"},{"line_number":201,"context_line":"r_driver_name:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_fcf2ef6d","line":198,"updated":"2016-05-05 17:34:01.000000000","message":"I don\u0027t understand your question ... these are just variables, not related to the output formatting.","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    bookmark links."},{"line_number":196,"context_line":"  in: body"},{"line_number":197,"context_line":"  required: true"},{"line_number":198,"context_line":"  type: array"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# variables when creating or updating a Node"},{"line_number":201,"context_line":"r_driver_name:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_fe6afe18","line":198,"updated":"2016-05-05 09:23:55.000000000","message":"id/links/version and the miss variables status/min_versions are part of `versions`, should we list here like here as the same level of description/name/versions or describe them in \u0027versions\u0027?","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8327cdb404405d65a53eb2313ec524e78c88f311","unresolved":false,"context_lines":[{"line_number":198,"context_line":"  type: array"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# variables when creating or updating a Node"},{"line_number":201,"context_line":"r_driver_name:"},{"line_number":202,"context_line":"  description: |"},{"line_number":203,"context_line":"    The name of the driver used to manage this Node."},{"line_number":204,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_5ce4c3a6","line":201,"updated":"2016-05-05 17:34:01.000000000","message":"again, just a variable name ... not the actual display text","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":198,"context_line":"  type: array"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# variables when creating or updating a Node"},{"line_number":201,"context_line":"r_driver_name:"},{"line_number":202,"context_line":"  description: |"},{"line_number":203,"context_line":"    The name of the driver used to manage this Node."},{"line_number":204,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_9eee6a89","line":201,"updated":"2016-05-05 09:23:55.000000000","message":"s/driver_name/driver/","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8327cdb404405d65a53eb2313ec524e78c88f311","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  type: string"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# variables in the Node responses"},{"line_number":209,"context_line":"node_uuid:"},{"line_number":210,"context_line":"  description: |"},{"line_number":211,"context_line":"    UUID of the Node resource."},{"line_number":212,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_3ce90780","line":209,"updated":"2016-05-05 17:34:01.000000000","message":"nope - this is a variable name. it gets displayed in the output as just \"uuid\" though :)","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"  type: string"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# variables in the Node responses"},{"line_number":209,"context_line":"node_uuid:"},{"line_number":210,"context_line":"  description: |"},{"line_number":211,"context_line":"    UUID of the Node resource."},{"line_number":212,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_bee9a681","line":209,"updated":"2016-05-05 09:23:55.000000000","message":"s/node_uuid/uuid","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":212,"context_line":"  in: body"},{"line_number":213,"context_line":"  required: true"},{"line_number":214,"context_line":"  type: string"},{"line_number":215,"context_line":"node_name:"},{"line_number":216,"context_line":"  description: |"},{"line_number":217,"context_line":"    Human-readable identifier for the Node resource. May be undefined. Certain"},{"line_number":218,"context_line":"    words are reserved. Added in API microversion 1.5"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_fed83ef1","line":215,"updated":"2016-05-05 09:23:55.000000000","message":"s/node_name/name/","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8327cdb404405d65a53eb2313ec524e78c88f311","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  type: string"},{"line_number":228,"context_line":"power_state:"},{"line_number":229,"context_line":"  description: |"},{"line_number":230,"context_line":"    The current power state of this Node. Usually, \"ON\" or \"OFF\", but may be \"None\""},{"line_number":231,"context_line":"    if Ironic is unable to determine the power state (eg, due to hardware failure)."},{"line_number":232,"context_line":"  in: body"},{"line_number":233,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_9c02db3c","line":230,"updated":"2016-05-05 17:34:01.000000000","message":"done","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  type: string"},{"line_number":228,"context_line":"power_state:"},{"line_number":229,"context_line":"  description: |"},{"line_number":230,"context_line":"    The current power state of this Node. Usually, \"ON\" or \"OFF\", but may be \"None\""},{"line_number":231,"context_line":"    if Ironic is unable to determine the power state (eg, due to hardware failure)."},{"line_number":232,"context_line":"  in: body"},{"line_number":233,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_3e7bd6bf","line":230,"updated":"2016-05-05 09:23:55.000000000","message":"s/ON/power on/\ns/OFF/power off/","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"8327cdb404405d65a53eb2313ec524e78c88f311","unresolved":false,"context_lines":[{"line_number":340,"context_line":"  in: body"},{"line_number":341,"context_line":"  required: true"},{"line_number":342,"context_line":"  type: JSON"},{"line_number":343,"context_line":"n_properties:"},{"line_number":344,"context_line":"  description: |"},{"line_number":345,"context_line":"    Physical characteristics of this Node. Populated by ironic-inspector during"},{"line_number":346,"context_line":"    inspection. May be edited via the REST API at any time."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_7cffff33","line":343,"updated":"2016-05-05 17:34:01.000000000","message":"I prefixed this variable name with \"n_\" to differentiate it from driver/properties -- though I haven\u0027t added that to this file yet, I will.","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9c7dcaec9876ce27bb86462bea1e67315965d54e","unresolved":false,"context_lines":[{"line_number":340,"context_line":"  in: body"},{"line_number":341,"context_line":"  required: true"},{"line_number":342,"context_line":"  type: JSON"},{"line_number":343,"context_line":"n_properties:"},{"line_number":344,"context_line":"  description: |"},{"line_number":345,"context_line":"    Physical characteristics of this Node. Populated by ironic-inspector during"},{"line_number":346,"context_line":"    inspection. May be edited via the REST API at any time."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_213bbbd2","line":343,"range":{"start_line":343,"start_character":0,"end_line":343,"end_character":13},"updated":"2016-05-05 09:23:55.000000000","message":"n_properties? what\u0027s the meaning of prefix n here?","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"3ede36bd2cafe3a425563024d3634cd4005a7e23","unresolved":false,"context_lines":[{"line_number":349,"context_line":"  type: JSON"},{"line_number":350,"context_line":"maintenance_reason:"},{"line_number":351,"context_line":"  description: |"},{"line_number":352,"context_line":"    User-settable description of the reason why this Node was placed into"},{"line_number":353,"context_line":"     maintenance mode"},{"line_number":354,"context_line":"  in: body"},{"line_number":355,"context_line":"  required: false"},{"line_number":356,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_adffa300","line":353,"range":{"start_line":352,"start_character":4,"end_line":353,"end_character":21},"updated":"2016-05-05 20:14:24.000000000","message":"Indentation here","commit_id":"5e902c672d6709820aeda8fd26eaf13db39f3333"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    One or more fields to be returned in the response."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    For example, the following request returns only the ``uuid``"},{"line_number":117,"context_line":"    and ``description`` fields for each node:"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    ::"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_5f3889a0","line":117,"updated":"2016-05-19 18:10:31.000000000","message":"oh thanks, I missed this in the import. clearly a bad example.","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    One or more fields to be returned in the response."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    For example, the following request returns only the ``uuid``"},{"line_number":117,"context_line":"    and ``description`` fields for each node:"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    ::"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_fce1eeff","line":117,"updated":"2016-05-18 09:13:58.000000000","message":"there is no description on a node, lets maybe use name?","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":286,"context_line":"  type: boolean"},{"line_number":287,"context_line":"last_error:"},{"line_number":288,"context_line":"  description: |"},{"line_number":289,"context_line":"    Any error from the most recent (last) asynchronous transaction that started but failed to finish."},{"line_number":290,"context_line":"  in: body"},{"line_number":291,"context_line":"  required: true"},{"line_number":292,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_3f3b059e","line":289,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":286,"context_line":"  type: boolean"},{"line_number":287,"context_line":"last_error:"},{"line_number":288,"context_line":"  description: |"},{"line_number":289,"context_line":"    Any error from the most recent (last) asynchronous transaction that started but failed to finish."},{"line_number":290,"context_line":"  in: body"},{"line_number":291,"context_line":"  required: true"},{"line_number":292,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_5ce75a12","line":289,"updated":"2016-05-18 09:13:58.000000000","message":"not necessary asynchronous IIRC","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"035b721fc8354b31c192e3424cf26a754385af5f","unresolved":false,"context_lines":[{"line_number":369,"context_line":"maintenance_reason:"},{"line_number":370,"context_line":"  description: |"},{"line_number":371,"context_line":"    User-settable description of the reason why this Node was placed into"},{"line_number":372,"context_line":"     maintenance mode"},{"line_number":373,"context_line":"  in: body"},{"line_number":374,"context_line":"  required: false"},{"line_number":375,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_9f42f10e","line":372,"updated":"2016-05-19 18:10:31.000000000","message":"done","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30af206081891c45f3ffda9d94c5286df1af66a6","unresolved":false,"context_lines":[{"line_number":369,"context_line":"maintenance_reason:"},{"line_number":370,"context_line":"  description: |"},{"line_number":371,"context_line":"    User-settable description of the reason why this Node was placed into"},{"line_number":372,"context_line":"     maintenance mode"},{"line_number":373,"context_line":"  in: body"},{"line_number":374,"context_line":"  required: false"},{"line_number":375,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_3ce4160c","line":372,"updated":"2016-05-18 09:13:58.000000000","message":"redundant space before \"maintenance\" causes this to render as definition list (looks weird)","commit_id":"10d829974c27bf233ab9745249b17ce2b11916f9"}],"api-ref/source/samples/node-vendor-passthru-response.json":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2c40db6aef149b3aad10b763d5b123f46cfb7f7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"   \"bmc_reset\" : {"},{"line_number":3,"context_line":"      \"async\" : true,"},{"line_number":4,"context_line":"      \"description\" : \"\","},{"line_number":5,"context_line":"      \"http_methods\" : ["},{"line_number":6,"context_line":"         \"POST\""},{"line_number":7,"context_line":"      ],"}],"source_content_type":"application/json","patch_set":4,"id":"dab17558_b1374aaf","line":4,"updated":"2016-05-09 09:17:18.000000000","message":"sad we do not add any description on such methods (nothing to do with this patch)","commit_id":"ca8cbf612396701d9cd12bd2b8dc26286f3be821"}]}