)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"eef5241274a9a7db42141fdddb3be3940f9b8162","unresolved":false,"context_lines":[{"line_number":938,"context_line":"    \"\"\"A flag to indicate if the requests to this controller are coming"},{"line_number":939,"context_line":"    from the top-level resource Chassis\"\"\""},{"line_number":940,"context_line":""},{"line_number":941,"context_line":"    # NOTE(lucasagomes): For future reference. If we happen"},{"line_number":942,"context_line":"    # to need to add another sub-controller in this class let\u0027s"},{"line_number":943,"context_line":"    # try to make it a parameter instead of an endpoint due"},{"line_number":944,"context_line":"    # https://bugs.launchpad.net/ironic/+bug/1572651, e.g, instead of"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_e6bcad08","line":941,"updated":"2016-06-15 15:29:25.000000000","message":"should be removed too.","commit_id":"ac5d03e2f4ac51b8a675e86aec6881ab7124354c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"eef5241274a9a7db42141fdddb3be3940f9b8162","unresolved":false,"context_lines":[{"line_number":954,"context_line":""},{"line_number":955,"context_line":"    @pecan.expose()"},{"line_number":956,"context_line":"    def _lookup(self, ident, subres, *remainder):"},{"line_number":957,"context_line":"        # Subresources that don\u0027t always need a node"},{"line_number":958,"context_line":"        if subres \u003d\u003d \"ports\":"},{"line_number":959,"context_line":"            return port.PortsController(ident), remainder"},{"line_number":960,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_e6494d62","line":957,"updated":"2016-06-15 15:29:25.000000000","message":"I don\u0027t get what you mean in this comment, it is a nodes controller, you have a node for all of these.","commit_id":"ac5d03e2f4ac51b8a675e86aec6881ab7124354c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"eef5241274a9a7db42141fdddb3be3940f9b8162","unresolved":false,"context_lines":[{"line_number":959,"context_line":"            return port.PortsController(ident), remainder"},{"line_number":960,"context_line":""},{"line_number":961,"context_line":"        # Subresources that always require a node"},{"line_number":962,"context_line":"        self._set_routing_args(pecan.request, (ident,))"},{"line_number":963,"context_line":"        if subres \u003d\u003d \"maintenance\":"},{"line_number":964,"context_line":"            return NodeMaintenanceController(), remainder"},{"line_number":965,"context_line":"        elif subres \u003d\u003d \"management\":"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_1cecac91","line":962,"updated":"2016-06-15 15:29:25.000000000","message":"I\u0027m not sure how this thing works, need to look closer at pecan code, but I would like to avoid calling private methods not described in the docs. Maybe we could do the same thing for these controllers as with ports controller, just add an ident to __init__?","commit_id":"ac5d03e2f4ac51b8a675e86aec6881ab7124354c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cf06287dc85160211f666d2ae84e703c0ee56f64","unresolved":false,"context_lines":[{"line_number":1174,"context_line":"                                          driver, resource_url)"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"    @expose.expose(wtypes.text, types.uuid_or_name, types.uuid)"},{"line_number":1177,"context_line":"    def validate(self, node\u003dNone, node_uuid\u003dNone):"},{"line_number":1178,"context_line":"        \"\"\"Validate the driver interfaces, using the node\u0027s UUID or name."},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        Note that the \u0027node_uuid\u0027 interface is deprecated in favour"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_4d1ab918","line":1177,"updated":"2016-06-16 17:40:55.000000000","message":"One more thing, just spotted that - with this change, for some reason, validate call stopped understanding node names, it only works with UUIDs oO","commit_id":"ac5d03e2f4ac51b8a675e86aec6881ab7124354c"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def supported(self):"},{"line_number":249,"context_line":"        \"\"\"Get a list of the supported boot devices."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":252,"context_line":"        :returns: A json object with the list of supported boot"},{"line_number":253,"context_line":"                  devices."},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_e6985f1e","line":251,"range":{"start_line":251,"start_character":15,"end_line":251,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"This should be removed.","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def supported(self):"},{"line_number":249,"context_line":"        \"\"\"Get a list of the supported boot devices."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":252,"context_line":"        :returns: A json object with the list of supported boot"},{"line_number":253,"context_line":"                  devices."},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_8e482989","line":251,"range":{"start_line":251,"start_character":15,"end_line":251,"end_character":25},"in_reply_to":"ba5201f7_e6985f1e","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    def get(self):"},{"line_number":292,"context_line":"        \"\"\"Get connection information about the console."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":295,"context_line":"        \"\"\""},{"line_number":296,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":297,"context_line":"        policy.authorize(\u0027baremetal:node:get_console\u0027, cdict, cdict)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_069e4307","line":294,"range":{"start_line":294,"start_character":15,"end_line":294,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    def get(self):"},{"line_number":292,"context_line":"        \"\"\"Get connection information about the console."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":295,"context_line":"        \"\"\""},{"line_number":296,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":297,"context_line":"        policy.authorize(\u0027baremetal:node:get_console\u0027, cdict, cdict)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_ee30cd03","line":294,"range":{"start_line":294,"start_character":15,"end_line":294,"end_character":25},"in_reply_to":"ba5201f7_069e4307","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    def put(self, enabled):"},{"line_number":314,"context_line":"        \"\"\"Start and stop the node console."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":317,"context_line":"        :param enabled: Boolean value; whether to enable or disable the"},{"line_number":318,"context_line":"                console."},{"line_number":319,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_c6ba7b71","line":316,"range":{"start_line":316,"start_character":15,"end_line":316,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    def put(self, enabled):"},{"line_number":314,"context_line":"        \"\"\"Start and stop the node console."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":317,"context_line":"        :param enabled: Boolean value; whether to enable or disable the"},{"line_number":318,"context_line":"                console."},{"line_number":319,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_2e19f588","line":316,"range":{"start_line":316,"start_character":15,"end_line":316,"end_character":25},"in_reply_to":"ba5201f7_c6ba7b71","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    def get(self):"},{"line_number":408,"context_line":"        \"\"\"List the states of the node."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        :param node_ident: the UUID or logical_name of a node."},{"line_number":411,"context_line":"        \"\"\""},{"line_number":412,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":413,"context_line":"        policy.authorize(\u0027baremetal:node:get_states\u0027, cdict, cdict)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_267187e1","line":410,"range":{"start_line":410,"start_character":15,"end_line":410,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    def get(self):"},{"line_number":408,"context_line":"        \"\"\"List the states of the node."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        :param node_ident: the UUID or logical_name of a node."},{"line_number":411,"context_line":"        \"\"\""},{"line_number":412,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":413,"context_line":"        policy.authorize(\u0027baremetal:node:get_states\u0027, cdict, cdict)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_6e13fd66","line":410,"range":{"start_line":410,"start_character":15,"end_line":410,"end_character":25},"in_reply_to":"ba5201f7_267187e1","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    def raid(self, target_raid_config):"},{"line_number":424,"context_line":"        \"\"\"Set the target raid config of the node."},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":427,"context_line":"        :param target_raid_config: Desired target RAID configuration of"},{"line_number":428,"context_line":"            the node. It may be an empty dictionary as well."},{"line_number":429,"context_line":"        :raises: UnsupportedDriverExtension, if the node\u0027s driver doesn\u0027t"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_66738fe8","line":426,"range":{"start_line":426,"start_character":15,"end_line":426,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    def raid(self, target_raid_config):"},{"line_number":424,"context_line":"        \"\"\"Set the target raid config of the node."},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":427,"context_line":"        :param target_raid_config: Desired target RAID configuration of"},{"line_number":428,"context_line":"            the node. It may be an empty dictionary as well."},{"line_number":429,"context_line":"        :raises: UnsupportedDriverExtension, if the node\u0027s driver doesn\u0027t"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_ae0de53f","line":426,"range":{"start_line":426,"start_character":15,"end_line":426,"end_character":25},"in_reply_to":"ba5201f7_66738fe8","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    def power(self, target, timeout\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Set the power state of the node."},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":460,"context_line":"        :param target: The desired power state of the node."},{"line_number":461,"context_line":"        :param timeout: timeout (in seconds) positive integer (\u003e 0) for any"},{"line_number":462,"context_line":"          power state. ``None`` indicates to use default timeout."}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_8676b304","line":459,"range":{"start_line":459,"start_character":9,"end_line":459,"end_character":61},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    def power(self, target, timeout\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Set the power state of the node."},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":460,"context_line":"        :param target: The desired power state of the node."},{"line_number":461,"context_line":"        :param timeout: timeout (in seconds) positive integer (\u003e 0) for any"},{"line_number":462,"context_line":"          power state. ``None`` indicates to use default timeout."}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_29000f01","line":459,"range":{"start_line":459,"start_character":9,"end_line":459,"end_character":61},"in_reply_to":"ba5201f7_8676b304","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        continue to GET the status of this node to observe the status"},{"line_number":521,"context_line":"        of the requested action."},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":524,"context_line":"        :param target: The desired provision state of the node or verb."},{"line_number":525,"context_line":"        :param configdrive: Optional. A gzipped and base64 encoded"},{"line_number":526,"context_line":"            configdrive. Only valid when setting provision state"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_465dab47","line":523,"range":{"start_line":523,"start_character":15,"end_line":523,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        continue to GET the status of this node to observe the status"},{"line_number":521,"context_line":"        of the requested action."},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":524,"context_line":"        :param target: The desired provision state of the node or verb."},{"line_number":525,"context_line":"        :param configdrive: Optional. A gzipped and base64 encoded"},{"line_number":526,"context_line":"            configdrive. Only valid when setting provision state"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_49039b0d","line":523,"range":{"start_line":523,"start_character":15,"end_line":523,"end_character":25},"in_reply_to":"ba5201f7_465dab47","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":989,"context_line":"    def methods(self):"},{"line_number":990,"context_line":"        \"\"\"Retrieve information about vendor methods of the given node."},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":993,"context_line":"        :returns: dictionary with \u003cvendor method name\u003e:\u003cmethod metadata\u003e"},{"line_number":994,"context_line":"                  entries."},{"line_number":995,"context_line":"        :raises: NodeNotFound if the node is not found."}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_263fc7d7","line":992,"range":{"start_line":992,"start_character":15,"end_line":992,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":989,"context_line":"    def methods(self):"},{"line_number":990,"context_line":"        \"\"\"Retrieve information about vendor methods of the given node."},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":993,"context_line":"        :returns: dictionary with \u003cvendor method name\u003e:\u003cmethod metadata\u003e"},{"line_number":994,"context_line":"                  entries."},{"line_number":995,"context_line":"        :raises: NodeNotFound if the node is not found."}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_690a1723","line":992,"range":{"start_line":992,"start_character":15,"end_line":992,"end_character":25},"in_reply_to":"ba5201f7_263fc7d7","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"    def _default(self, method, data\u003dNone):"},{"line_number":1015,"context_line":"        \"\"\"Call a vendor extension."},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":1018,"context_line":"        :param method: name of the method in vendor driver."},{"line_number":1019,"context_line":"        :param data: body of data to supply to the specified method."},{"line_number":1020,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_6621cfb4","line":1017,"range":{"start_line":1017,"start_character":15,"end_line":1017,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"    def _default(self, method, data\u003dNone):"},{"line_number":1015,"context_line":"        \"\"\"Call a vendor extension."},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":1018,"context_line":"        :param method: name of the method in vendor driver."},{"line_number":1019,"context_line":"        :param data: body of data to supply to the specified method."},{"line_number":1020,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_a914ff43","line":1017,"range":{"start_line":1017,"start_character":15,"end_line":1017,"end_character":25},"in_reply_to":"ba5201f7_6621cfb4","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"    def put(self, reason\u003dNone):"},{"line_number":1057,"context_line":"        \"\"\"Put the node in maintenance mode."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"        :param node_ident: the UUID or logical_name of a node."},{"line_number":1060,"context_line":"        :param reason: Optional, the reason why it\u0027s in maintenance."},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_0611e35d","line":1059,"range":{"start_line":1059,"start_character":15,"end_line":1059,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"    def put(self, reason\u003dNone):"},{"line_number":1057,"context_line":"        \"\"\"Put the node in maintenance mode."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"        :param node_ident: the UUID or logical_name of a node."},{"line_number":1060,"context_line":"        :param reason: Optional, the reason why it\u0027s in maintenance."},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_091a736e","line":1059,"range":{"start_line":1059,"start_character":15,"end_line":1059,"end_character":25},"in_reply_to":"ba5201f7_0611e35d","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"30306d5a44f8bbcaf468631050680ef81a5c1ad5","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"    def delete(self):"},{"line_number":1071,"context_line":"        \"\"\"Remove the node from maintenance mode."},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":"        \"\"\""},{"line_number":1076,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5201f7_6608ef2e","line":1073,"range":{"start_line":1073,"start_character":15,"end_line":1073,"end_character":25},"updated":"2017-01-09 14:39:14.000000000","message":"ditto","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b5d02786ee05209744049a472e18e0a25b789e87","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"    def delete(self):"},{"line_number":1071,"context_line":"        \"\"\"Remove the node from maintenance mode."},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":"        \"\"\""},{"line_number":1076,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a461143_29272fb7","line":1073,"range":{"start_line":1073,"start_character":15,"end_line":1073,"end_character":25},"in_reply_to":"ba5201f7_6608ef2e","updated":"2017-01-27 16:13:23.000000000","message":"Done","commit_id":"5a028961523fca24122d583381e0c983eca62844"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"59ef91c905049f5a53f8a7f3cc4e05fb7f4cb0c0","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        self.parent_node_ident \u003d node_ident"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _get_rpc_node(self):"},{"line_number":171,"context_line":"        return api_utils.get_rpc_node(self.parent_node_ident)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def _get_rpc_node_and_topic(self):"},{"line_number":174,"context_line":"        rpc_node \u003d self._get_rpc_node()"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_c0901246","line":171,"updated":"2017-01-30 09:31:54.000000000","message":"nit - do we really need this one liner? :)","commit_id":"be5ab84b93643c6267ec3f9122e6c1dd1d01be2e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"59ef91c905049f5a53f8a7f3cc4e05fb7f4cb0c0","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        try:"},{"line_number":176,"context_line":"            topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":177,"context_line":"        except exception.NoValidHost as e:"},{"line_number":178,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":179,"context_line":"            raise"},{"line_number":180,"context_line":"        return rpc_node, topic"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_806a8a7f","line":178,"updated":"2017-01-30 09:31:54.000000000","message":"Ugh, the problem with this is, it changes the response codes for some of the controllers, that were not changing the response code previously, like eg L182. If done this way, this change will need a microversion :(","commit_id":"be5ab84b93643c6267ec3f9122e6c1dd1d01be2e"}],"ironic/tests/unit/api/v1/test_nodes.py":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"688e919926e8eaeee023822d466526ce40c8482a","unresolved":false,"context_lines":[{"line_number":752,"context_line":"        mock_gci.assert_called_once_with(mock.ANY, node.uuid, \u0027test-topic\u0027)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027get_console_information\u0027)"},{"line_number":755,"context_line":"    def test_get_console_information_by_name_states(self, mock_gci):"},{"line_number":756,"context_line":"        node \u003d obj_utils.create_test_node(self.context, name\u003d\u0027states\u0027)"},{"line_number":757,"context_line":"        expected_console_info \u003d {\u0027test\u0027: \u0027test-data\u0027}"},{"line_number":758,"context_line":"        expected_data \u003d {\u0027console_enabled\u0027: True,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_b614e94c","line":755,"updated":"2016-06-01 12:14:22.000000000","message":"I think we should extract the test like the other ones below, and have it take a name parameter, in order to avoid duplication with \"test_get_console_information_by_name\".","commit_id":"78162b7c913e84368d1377b1b2ef390effd54ae8"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"fc4d2da07eb6e04af6e354bd6eb67347fe2a37f3","unresolved":false,"context_lines":[{"line_number":752,"context_line":"        mock_gci.assert_called_once_with(mock.ANY, node.uuid, \u0027test-topic\u0027)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027get_console_information\u0027)"},{"line_number":755,"context_line":"    def test_get_console_information_by_name_states(self, mock_gci):"},{"line_number":756,"context_line":"        node \u003d obj_utils.create_test_node(self.context, name\u003d\u0027states\u0027)"},{"line_number":757,"context_line":"        expected_console_info \u003d {\u0027test\u0027: \u0027test-data\u0027}"},{"line_number":758,"context_line":"        expected_data \u003d {\u0027console_enabled\u0027: True,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_f7a4994b","line":755,"in_reply_to":"9abb7d3a_b614e94c","updated":"2016-06-01 18:05:41.000000000","message":"Done","commit_id":"78162b7c913e84368d1377b1b2ef390effd54ae8"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"688e919926e8eaeee023822d466526ce40c8482a","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        mock_gbd.assert_called_once_with(mock.ANY, node.uuid, \u0027test-topic\u0027)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027get_boot_device\u0027)"},{"line_number":809,"context_line":"    def test_get_boot_device_by_name_management(self, mock_gbd):"},{"line_number":810,"context_line":"        node \u003d obj_utils.create_test_node(self.context, name\u003d\u0027management\u0027)"},{"line_number":811,"context_line":"        expected_data \u003d {\u0027boot_device\u0027: boot_devices.PXE, \u0027persistent\u0027: True}"},{"line_number":812,"context_line":"        mock_gbd.return_value \u003d expected_data"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_36011907","line":809,"updated":"2016-06-01 12:14:22.000000000","message":"Same","commit_id":"78162b7c913e84368d1377b1b2ef390effd54ae8"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"fc4d2da07eb6e04af6e354bd6eb67347fe2a37f3","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        mock_gbd.assert_called_once_with(mock.ANY, node.uuid, \u0027test-topic\u0027)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027get_boot_device\u0027)"},{"line_number":809,"context_line":"    def test_get_boot_device_by_name_management(self, mock_gbd):"},{"line_number":810,"context_line":"        node \u003d obj_utils.create_test_node(self.context, name\u003d\u0027management\u0027)"},{"line_number":811,"context_line":"        expected_data \u003d {\u0027boot_device\u0027: boot_devices.PXE, \u0027persistent\u0027: True}"},{"line_number":812,"context_line":"        mock_gbd.return_value \u003d expected_data"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_73243c0c","line":809,"in_reply_to":"9abb7d3a_36011907","updated":"2016-06-01 18:05:41.000000000","message":"Done","commit_id":"78162b7c913e84368d1377b1b2ef390effd54ae8"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"688e919926e8eaeee023822d466526ce40c8482a","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        self.mock_update_node.assert_called_once_with("},{"line_number":1257,"context_line":"            mock.ANY, mock.ANY, \u0027test-topic\u0027)"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"    def test_replace_maintenance_by_name_maintenance(self):"},{"line_number":1260,"context_line":"        node \u003d obj_utils.create_test_node(self.context,"},{"line_number":1261,"context_line":"                                          uuid\u003duuidutils.generate_uuid(),"},{"line_number":1262,"context_line":"                                          name\u003d\"maintenance\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_7905520f","line":1259,"updated":"2016-06-01 12:14:22.000000000","message":"Same","commit_id":"78162b7c913e84368d1377b1b2ef390effd54ae8"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"fc4d2da07eb6e04af6e354bd6eb67347fe2a37f3","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        self.mock_update_node.assert_called_once_with("},{"line_number":1257,"context_line":"            mock.ANY, mock.ANY, \u0027test-topic\u0027)"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"    def test_replace_maintenance_by_name_maintenance(self):"},{"line_number":1260,"context_line":"        node \u003d obj_utils.create_test_node(self.context,"},{"line_number":1261,"context_line":"                                          uuid\u003duuidutils.generate_uuid(),"},{"line_number":1262,"context_line":"                                          name\u003d\"maintenance\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_bcfdd1b2","line":1259,"in_reply_to":"9abb7d3a_7905520f","updated":"2016-06-01 18:05:41.000000000","message":"Done","commit_id":"78162b7c913e84368d1377b1b2ef390effd54ae8"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"688e919926e8eaeee023822d466526ce40c8482a","unresolved":false,"context_lines":[{"line_number":1643,"context_line":"    def test_vendor_passthru_by_name(self, mock_vendor):"},{"line_number":1644,"context_line":"        self._test_vendor_passthru_ok_by_name(mock_vendor, \"node-97\")"},{"line_number":1645,"context_line":""},{"line_number":1646,"context_line":"    # TODO(sambetts): Follow up if vendor_passthru is a valid name or not"},{"line_number":1647,"context_line":"    # @mock.patch.object(rpcapi.ConductorAPI, \u0027vendor_passthru\u0027)"},{"line_number":1648,"context_line":"    # def test_vendor_passthru_by_name(self, mock_vendor):"},{"line_number":1649,"context_line":"    #     self._test_vendor_passthru_ok_by_name(mock_vendor, \"vendor_passthru\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_9977569f","line":1646,"updated":"2016-06-01 12:14:22.000000000","message":"Calling vendor_passthru for a node called \"vendor_passthru\"? Sounds legit to me.","commit_id":"78162b7c913e84368d1377b1b2ef390effd54ae8"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"fc4d2da07eb6e04af6e354bd6eb67347fe2a37f3","unresolved":false,"context_lines":[{"line_number":1643,"context_line":"    def test_vendor_passthru_by_name(self, mock_vendor):"},{"line_number":1644,"context_line":"        self._test_vendor_passthru_ok_by_name(mock_vendor, \"node-97\")"},{"line_number":1645,"context_line":""},{"line_number":1646,"context_line":"    # TODO(sambetts): Follow up if vendor_passthru is a valid name or not"},{"line_number":1647,"context_line":"    # @mock.patch.object(rpcapi.ConductorAPI, \u0027vendor_passthru\u0027)"},{"line_number":1648,"context_line":"    # def test_vendor_passthru_by_name(self, mock_vendor):"},{"line_number":1649,"context_line":"    #     self._test_vendor_passthru_ok_by_name(mock_vendor, \"vendor_passthru\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_1c2fbd3f","line":1646,"in_reply_to":"9abb7d3a_9977569f","updated":"2016-06-01 18:05:41.000000000","message":"Done","commit_id":"78162b7c913e84368d1377b1b2ef390effd54ae8"}],"releasenotes/notes/fix-more-url-collisions-a047f468c260cd23.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b65a7912d9a6374c321ad703db94c3af275233ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed invalid API URLs:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``v1/nodes/ports``"},{"line_number":7,"context_line":"    * ``v1/nodes/maintenance``"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3a461143_3c33a863","line":4,"updated":"2017-01-30 20:48:03.000000000","message":"This should be active tense; removes.","commit_id":"be5ab84b93643c6267ec3f9122e6c1dd1d01be2e"}]}
