)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b946c0276be8cefb6a44645e9c7f58baf5c4f0ba","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Right now v1/chassis/\u003cuuid_id\u003e/nodes and"},{"line_number":10,"context_line":"v1/chassis/nodes/\u003cuuid_id\u003e both work as a URLs in our API, the second"},{"line_number":11,"context_line":"version of the URL does the same as the first, however it shouldn\u0027t even"},{"line_number":12,"context_line":"exist as it exists purly as a side effect of how we\u0027ve programmed the"},{"line_number":13,"context_line":"API controllers. This patch corrects the controllers to ensure only"},{"line_number":14,"context_line":"supported routes work."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_96583758","line":12,"updated":"2016-05-13 16:04:59.000000000","message":"Typo: \"purely\", but I\u0027d reword the sentence as follows:\n\n\"Currently the two routes\n\nv1/chassis/\u003cchassis_uuid\u003e/nodes\nv1/chassis/nodes/\u003cchassis_uuid\u003e\n\nare supported and have identical behavior. The second only exists as a side-effect of our implementation, and should not be supported. This patch removes the second route.\"","commit_id":"792a274e655f0aa861d19f74cc568a3b641cecb6"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"305ff97069e84de45e59f13432a21b01e3986e7b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Right now v1/chassis/\u003cuuid_id\u003e/nodes and"},{"line_number":10,"context_line":"v1/chassis/nodes/\u003cuuid_id\u003e both work as a URLs in our API, the second"},{"line_number":11,"context_line":"version of the URL does the same as the first, however it shouldn\u0027t even"},{"line_number":12,"context_line":"exist as it exists purly as a side effect of how we\u0027ve programmed the"},{"line_number":13,"context_line":"API controllers. This patch corrects the controllers to ensure only"},{"line_number":14,"context_line":"supported routes work."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_25a94a7c","line":12,"in_reply_to":"dab17558_96583758","updated":"2016-05-13 18:01:08.000000000","message":"Done","commit_id":"792a274e655f0aa861d19f74cc568a3b641cecb6"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"c3f49582bcc09ec76237e6ae61474c5c5aaaf8af","unresolved":false,"context_lines":[{"line_number":15,"context_line":"side-effect of our implementation, and should not be supported. This"},{"line_number":16,"context_line":"patch removes the second route."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I9885feef5fb305e87faeff3deec0a78015c565b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5a9d85d2_68686cf6","line":18,"updated":"2016-06-20 20:59:28.000000000","message":"Nit: can you add \"Partial-Bug: 1580997\" above here? I believe this is in response to this bug: https://bugs.launchpad.net/ironic/+bug/1580997\n\nThanks!","commit_id":"820025fb417fc9c34460b293e4d41167317cc4d0"}],"ironic/api/controllers/v1/chassis.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3d27054cbcaa91124b145593a6c86f0288bc6c00","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @pecan.expose()"},{"line_number":168,"context_line":"    def _lookup(self, ident, subres, *remainder):"},{"line_number":169,"context_line":"        if subres \u003d\u003d \"nodes\":"},{"line_number":170,"context_line":"            return node.NodesController(chassis_uuid\u003dident), remainder"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def _get_chassis_collection(self, marker, limit, sort_key, sort_dir,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_939f8702","line":169,"updated":"2016-09-01 11:34:01.000000000","message":"We need to validate that ident is a valid UUID here, also please consider https://review.openstack.org/364222 when adding this.","commit_id":"29111ba5fbdd68609639f6070216243bdc4ab75b"}],"ironic/tests/unit/api/v1/test_chassis.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b946c0276be8cefb6a44645e9c7f58baf5c4f0ba","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                                     \u0027op\u0027: \u0027add\u0027}], expect_errors\u003dTrue)"},{"line_number":370,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def test_patch_nodes_subresource_node_uuid(self):"},{"line_number":373,"context_line":"        node \u003d obj_utils.create_test_node(self.context, chassis_id\u003dself.chassis.id)"},{"line_number":374,"context_line":"        response \u003d self.patch_json("},{"line_number":375,"context_line":"            \u0027/chassis/%s/nodes/%s\u0027 % (self.chassis.uuid, node.uuid),"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_79b94415","line":372,"updated":"2016-05-13 16:04:59.000000000","message":"Can you add a test that GET /chassis/nodes/\u003cchassis_uuid\u003e now 404s?","commit_id":"792a274e655f0aa861d19f74cc568a3b641cecb6"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"305ff97069e84de45e59f13432a21b01e3986e7b","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                                     \u0027op\u0027: \u0027add\u0027}], expect_errors\u003dTrue)"},{"line_number":370,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def test_patch_nodes_subresource_node_uuid(self):"},{"line_number":373,"context_line":"        node \u003d obj_utils.create_test_node(self.context, chassis_id\u003dself.chassis.id)"},{"line_number":374,"context_line":"        response \u003d self.patch_json("},{"line_number":375,"context_line":"            \u0027/chassis/%s/nodes/%s\u0027 % (self.chassis.uuid, node.uuid),"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a501ba6c","line":372,"in_reply_to":"dab17558_79b94415","updated":"2016-05-13 18:01:08.000000000","message":"Done","commit_id":"792a274e655f0aa861d19f74cc568a3b641cecb6"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"21c1a14f5aef87f37ba3387ee4f4c6f2f9c3ec55","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, response.status_int)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def test_patch_nodes_subresource_node_uuid(self):"},{"line_number":380,"context_line":"        node \u003d obj_utils.create_test_node(self.context, chassis_id\u003dself.chassis.id)"},{"line_number":381,"context_line":"        response \u003d self.patch_json("},{"line_number":382,"context_line":"            \u0027/chassis/%s/nodes/%s\u0027 % (self.chassis.uuid, node.uuid),"},{"line_number":383,"context_line":"            [{\u0027path\u0027: \u0027/extra/foo\u0027, \u0027value\u0027: \u0027bar\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_952ad72a","line":380,"updated":"2016-05-19 16:43:10.000000000","message":"PEP8 - line too long.","commit_id":"0b0a3c43ed85489c336d009302a2b6965d648c6b"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"21c1a14f5aef87f37ba3387ee4f4c6f2f9c3ec55","unresolved":false,"context_lines":[{"line_number":506,"context_line":"    def test_delete_nodes_subresource_with_node(self):"},{"line_number":507,"context_line":"        chassis \u003d obj_utils.create_test_chassis(self.context)"},{"line_number":508,"context_line":"        node \u003d obj_utils.create_test_node(self.context, chassis_id\u003dchassis.id)"},{"line_number":509,"context_line":"        response \u003d self.delete(\u0027/chassis/%s/nodes/%s\u0027 % (chassis.uuid, node.uuid),"},{"line_number":510,"context_line":"                               expect_errors\u003dTrue)"},{"line_number":511,"context_line":"        self.assertEqual(http_client.FORBIDDEN, response.status_int)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_35f32bd8","line":509,"updated":"2016-05-19 16:43:10.000000000","message":"PEP8 - line too long","commit_id":"0b0a3c43ed85489c336d009302a2b6965d648c6b"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"64826cbac0738e295f2f69f61c52a7577e351e1f","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def setUp(self):"},{"line_number":248,"context_line":"        super(TestPatch, self).setUp()"},{"line_number":249,"context_line":"        self.chassis \u003d obj_utils.create_test_chassis(self.context)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_update_not_found(self):"},{"line_number":252,"context_line":"        uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_16199f79","line":249,"updated":"2016-10-19 22:14:02.000000000","message":"Can you reuse this across other tests you added that require a test chassis (i.e. L384)?","commit_id":"99737afac32fd3e897ce1297e5c1e6544b4f2eed"}],"ironic/tests/unit/objects/utils.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b946c0276be8cefb6a44645e9c7f58baf5c4f0ba","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    Create a chassis in the DB and return a Chassis object with appropriate"},{"line_number":95,"context_line":"    attributes."},{"line_number":96,"context_line":"    \"\"\""},{"line_number":97,"context_line":"    print(kw)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    chassis \u003d get_test_chassis(ctxt, **kw)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_79e2e430","line":97,"updated":"2016-05-13 16:04:59.000000000","message":"It looks like you\u0027ve committed debugging code here. Also, I think this amount of vertical whitespace is overkill.","commit_id":"792a274e655f0aa861d19f74cc568a3b641cecb6"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"305ff97069e84de45e59f13432a21b01e3986e7b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    Create a chassis in the DB and return a Chassis object with appropriate"},{"line_number":95,"context_line":"    attributes."},{"line_number":96,"context_line":"    \"\"\""},{"line_number":97,"context_line":"    print(kw)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    chassis \u003d get_test_chassis(ctxt, **kw)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_054086a4","line":97,"in_reply_to":"dab17558_79e2e430","updated":"2016-05-13 18:01:08.000000000","message":"Done","commit_id":"792a274e655f0aa861d19f74cc568a3b641cecb6"}],"releasenotes/notes/fix-more-url-collisions-a047f468c260cd23.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b9ffc84810ad9cbc02a2f1c8d73850903e12626f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed invalid API URLs:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``v1/nodes/ports``"},{"line_number":7,"context_line":"    * ``v1/nodes/maintenance``"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a461143_dc5d4416","line":4,"updated":"2017-01-30 20:33:46.000000000","message":"nit: this should\u0027ve always been present tense","commit_id":"b7cf9b269c305b8d08a03f4829b8cf8c840fbc4c"}]}
