)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"9d21d65ca78d96060aa55dae74789fd9cc156acd","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        vbmc_port\u003d$((vbmc_port+1))"},{"line_number":737,"context_line":"    done"},{"line_number":738,"context_line":"    local ironic_net_id"},{"line_number":739,"context_line":"    ironic_net_id\u003d$(neutron net-list | grep private | get_field 1)"},{"line_number":740,"context_line":"    die_if_not_set $LINENO ironic_net_id \"Failed to get ironic network id\""},{"line_number":741,"context_line":"    create_ovs_taps $ironic_net_id"},{"line_number":742,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dab17558_dc83b001","line":739,"updated":"2016-05-16 16:01:59.000000000","message":"What\u0027s the point of moving this logic outside the function? Is the plan to refer to this network ID again later?","commit_id":"4e5bf3e4410f5e165818f0d8d9be1446ad2068ec"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8d1fc7ba81a4fb1f99e589611cbea81eba2d1c1b","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        vbmc_port\u003d$((vbmc_port+1))"},{"line_number":737,"context_line":"    done"},{"line_number":738,"context_line":"    local ironic_net_id"},{"line_number":739,"context_line":"    ironic_net_id\u003d$(neutron net-list | grep private | get_field 1)"},{"line_number":740,"context_line":"    die_if_not_set $LINENO ironic_net_id \"Failed to get ironic network id\""},{"line_number":741,"context_line":"    create_ovs_taps $ironic_net_id"},{"line_number":742,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dab17558_eb3ce4e2","line":739,"in_reply_to":"dab17558_dc83b001","updated":"2016-05-16 17:38:58.000000000","message":"See: \n\nhttps://review.openstack.org/#/c/316234/6/devstack/upgrade/resources.sh\n\nLine 34","commit_id":"4e5bf3e4410f5e165818f0d8d9be1446ad2068ec"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"9e4d7378748285332e1361c13d8dd6b3a4709414","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        vbmc_port\u003d$((vbmc_port+1))"},{"line_number":737,"context_line":"    done"},{"line_number":738,"context_line":"    local ironic_net_id"},{"line_number":739,"context_line":"    ironic_net_id\u003d$(neutron net-list | grep private | get_field 1)"},{"line_number":740,"context_line":"    die_if_not_set $LINENO ironic_net_id \"Failed to get ironic network id\""},{"line_number":741,"context_line":"    create_ovs_taps $ironic_net_id"},{"line_number":742,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dab17558_7c0d37e7","line":739,"in_reply_to":"dab17558_eb3ce4e2","updated":"2016-05-17 11:33:14.000000000","message":"Oh, right. *smacks forehead*.","commit_id":"4e5bf3e4410f5e165818f0d8d9be1446ad2068ec"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"9d21d65ca78d96060aa55dae74789fd9cc156acd","unresolved":false,"context_lines":[{"line_number":737,"context_line":"    done"},{"line_number":738,"context_line":"    local ironic_net_id"},{"line_number":739,"context_line":"    ironic_net_id\u003d$(neutron net-list | grep private | get_field 1)"},{"line_number":740,"context_line":"    die_if_not_set $LINENO ironic_net_id \"Failed to get ironic network id\""},{"line_number":741,"context_line":"    create_ovs_taps $ironic_net_id"},{"line_number":742,"context_line":"}"},{"line_number":743,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dab17558_1ce53808","line":740,"updated":"2016-05-16 16:01:59.000000000","message":"This line is now duplicated.","commit_id":"4e5bf3e4410f5e165818f0d8d9be1446ad2068ec"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8d1fc7ba81a4fb1f99e589611cbea81eba2d1c1b","unresolved":false,"context_lines":[{"line_number":737,"context_line":"    done"},{"line_number":738,"context_line":"    local ironic_net_id"},{"line_number":739,"context_line":"    ironic_net_id\u003d$(neutron net-list | grep private | get_field 1)"},{"line_number":740,"context_line":"    die_if_not_set $LINENO ironic_net_id \"Failed to get ironic network id\""},{"line_number":741,"context_line":"    create_ovs_taps $ironic_net_id"},{"line_number":742,"context_line":"}"},{"line_number":743,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"dab17558_0b0fa839","line":740,"in_reply_to":"dab17558_1ce53808","updated":"2016-05-16 17:38:58.000000000","message":"I guess this could be deleted.","commit_id":"4e5bf3e4410f5e165818f0d8d9be1446ad2068ec"}],"devstack/upgrade/resources.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40d70088f92214e9772ecb60866fb9a622f6423e","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"source $TOP_DIR/openrc admin admin"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"IRONIC_DEVSTACK_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":26,"context_line":"source $IRONIC_DEVSTACK_DIR/lib/ironic"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"set -o xtrace"}],"source_content_type":"text/x-sh","patch_set":7,"id":"dab17558_5b1cc669","line":25,"updated":"2016-05-17 08:16:39.000000000","message":"IRONIC_DEVSTACK_DIR\u003d$(dirname \"$0\")","commit_id":"f0beeada9da02461374c20ba14c190da4d393abe"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"54f82897df3b5211a76937a03a9b3c6d0a7e591b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"source $TOP_DIR/openrc admin admin"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"IRONIC_DEVSTACK_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":26,"context_line":"source $IRONIC_DEVSTACK_DIR/lib/ironic"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"set -o xtrace"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"dab17558_6555bcc0","line":26,"updated":"2016-05-16 20:31:50.000000000","message":"I wonder if there\u0027s any harm in doing this, e.g. we\u0027re pulling in a lot of extra variables, functions, etc. Hopefully nothing will conflict with grenade :)\n\n(alternative is put this method in a separate file that can be sourced by this script and lib/ironic)","commit_id":"f0beeada9da02461374c20ba14c190da4d393abe"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f38a4731ca70f530055454ff8fe916025c1ce8e7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"source $TOP_DIR/openrc admin admin"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"IRONIC_DEVSTACK_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":26,"context_line":"source $IRONIC_DEVSTACK_DIR/lib/ironic"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"set -o xtrace"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"dab17558_a04cb242","line":26,"in_reply_to":"dab17558_4514f84b","updated":"2016-05-16 20:50:36.000000000","message":"This resources.sh file is executed by grenade. It is not sourced.\n\nSo anything done here will not bubble up to grenade.\n\nBut I could put it into a separate file.","commit_id":"f0beeada9da02461374c20ba14c190da4d393abe"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"77fa3a416d01c28a96c46a334bde05112df244b2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"source $TOP_DIR/openrc admin admin"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"IRONIC_DEVSTACK_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":26,"context_line":"source $IRONIC_DEVSTACK_DIR/lib/ironic"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"set -o xtrace"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"dab17558_4514f84b","line":26,"in_reply_to":"dab17558_6555bcc0","updated":"2016-05-16 20:42:11.000000000","message":"separate file sounds reasonable to me.","commit_id":"f0beeada9da02461374c20ba14c190da4d393abe"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"55fa4ec707ce6a55b74688cb49e19ae51071a699","unresolved":false,"context_lines":[{"line_number":23,"context_line":"source $TOP_DIR/openrc admin admin"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"IRONIC_DEVSTACK_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":26,"context_line":"source $IRONIC_DEVSTACK_DIR/lib/ironic"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"set -o xtrace"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"dab17558_20d4421e","line":26,"in_reply_to":"dab17558_a04cb242","updated":"2016-05-16 20:53:46.000000000","message":"Sweeeeeeet.","commit_id":"f0beeada9da02461374c20ba14c190da4d393abe"}]}