)]}'
{"ironic/common/neutron.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dba978c6c004347bee506cb0bd04d9bdc5defb73","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":43,"context_line":"               choices\u003d[\u0027keystone\u0027, \u0027noauth\u0027],"},{"line_number":44,"context_line":"               help\u003d_(\u0027Default authentication strategy to use when connecting \u0027"},{"line_number":45,"context_line":"                      \u0027to neutron. Can be either \"keystone\" or \"noauth\". \u0027"},{"line_number":46,"context_line":"                      \u0027Running neutron in noauth mode (related to but not \u0027"},{"line_number":47,"context_line":"                      \u0027affected by this setting) is insecure and should only \u0027"},{"line_number":48,"context_line":"                      \u0027be used for testing.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f5b2d547","line":45,"updated":"2016-05-17 14:07:43.000000000","message":"Ruby\u0027s comment from PS 39\n\nNo need for \u0027Can be either ...\u0027 sentence. The \u0027choices\u0027 in line 43 provides this information.","commit_id":"5c1b2869de969cb4dcd456e46493d275f721e789"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"134b9eb2689e522e88e56237e02be4ee57cfa972","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":43,"context_line":"               choices\u003d[\u0027keystone\u0027, \u0027noauth\u0027],"},{"line_number":44,"context_line":"               help\u003d_(\u0027Default authentication strategy to use when connecting \u0027"},{"line_number":45,"context_line":"                      \u0027to neutron. Can be either \"keystone\" or \"noauth\". \u0027"},{"line_number":46,"context_line":"                      \u0027Running neutron in noauth mode (related to but not \u0027"},{"line_number":47,"context_line":"                      \u0027affected by this setting) is insecure and should only \u0027"},{"line_number":48,"context_line":"                      \u0027be used for testing.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_9bdf30d5","line":45,"in_reply_to":"dab17558_f5b2d547","updated":"2016-05-24 16:14:34.000000000","message":"Done","commit_id":"5c1b2869de969cb4dcd456e46493d275f721e789"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"91a3a81fab987b8098fd6fcfcb396a49858a65ab","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027auth_strategy\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":43,"context_line":"               choices\u003d[\u0027keystone\u0027, \u0027noauth\u0027],"},{"line_number":44,"context_line":"               help\u003d_(\u0027Default authentication strategy to use when connecting \u0027"},{"line_number":45,"context_line":"                      \u0027to Neutron. Running neutron in noauth mode (related to \u0027"},{"line_number":46,"context_line":"                      \u0027but not affected by this setting) is insecure and \u0027"},{"line_number":47,"context_line":"                      \u0027should only be used for testing.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_9d842f5e","line":44,"updated":"2016-06-15 08:48:40.000000000","message":"s/Default authentication strategy/Authentication strategy","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1b9fefe34abf51a5c135703d2f456af4fddc0154","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027auth_strategy\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":43,"context_line":"               choices\u003d[\u0027keystone\u0027, \u0027noauth\u0027],"},{"line_number":44,"context_line":"               help\u003d_(\u0027Default authentication strategy to use when connecting \u0027"},{"line_number":45,"context_line":"                      \u0027to Neutron. Running neutron in noauth mode (related to \u0027"},{"line_number":46,"context_line":"                      \u0027but not affected by this setting) is insecure and \u0027"},{"line_number":47,"context_line":"                      \u0027should only be used for testing.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_521c1612","line":44,"in_reply_to":"5a9d85d2_220dc63e","updated":"2016-06-21 14:48:22.000000000","message":"Done","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"846d99d8c4faf59e72ffde3657e2c3a360f49663","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027auth_strategy\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":43,"context_line":"               choices\u003d[\u0027keystone\u0027, \u0027noauth\u0027],"},{"line_number":44,"context_line":"               help\u003d_(\u0027Default authentication strategy to use when connecting \u0027"},{"line_number":45,"context_line":"                      \u0027to Neutron. Running neutron in noauth mode (related to \u0027"},{"line_number":46,"context_line":"                      \u0027but not affected by this setting) is insecure and \u0027"},{"line_number":47,"context_line":"                      \u0027should only be used for testing.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_220dc63e","line":44,"in_reply_to":"7aa08908_9d842f5e","updated":"2016-06-21 11:16:53.000000000","message":"++","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1893649b09411478f09ef9df0d65c07abbcafafe","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":43,"context_line":"               choices\u003d[\u0027keystone\u0027, \u0027noauth\u0027],"},{"line_number":44,"context_line":"               help\u003d_(\u0027Default authentication strategy to use when connecting \u0027"},{"line_number":45,"context_line":"                      \u0027to Neutron. Running neutron in noauth mode (related to \u0027"},{"line_number":46,"context_line":"                      \u0027but not affected by this setting) is insecure and \u0027"},{"line_number":47,"context_line":"                      \u0027should only be used for testing.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027cleaning_network_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_68ea38ae","line":45,"updated":"2016-06-15 22:06:02.000000000","message":"s/Neutron/neutron/.\n\nIt was originally lowercased and should stay lowercased as per guidelines [1], although I see it uppercased elsewhere.\n\n[1] http://docs.openstack.org/contributor-guide/writing-style/openstack-components.html","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1b9fefe34abf51a5c135703d2f456af4fddc0154","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":43,"context_line":"               choices\u003d[\u0027keystone\u0027, \u0027noauth\u0027],"},{"line_number":44,"context_line":"               help\u003d_(\u0027Default authentication strategy to use when connecting \u0027"},{"line_number":45,"context_line":"                      \u0027to Neutron. Running neutron in noauth mode (related to \u0027"},{"line_number":46,"context_line":"                      \u0027but not affected by this setting) is insecure and \u0027"},{"line_number":47,"context_line":"                      \u0027should only be used for testing.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027cleaning_network_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_92bb1ee5","line":45,"in_reply_to":"5a9d85d2_cd7fd364","updated":"2016-06-21 14:48:22.000000000","message":"Done","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"846d99d8c4faf59e72ffde3657e2c3a360f49663","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":43,"context_line":"               choices\u003d[\u0027keystone\u0027, \u0027noauth\u0027],"},{"line_number":44,"context_line":"               help\u003d_(\u0027Default authentication strategy to use when connecting \u0027"},{"line_number":45,"context_line":"                      \u0027to Neutron. Running neutron in noauth mode (related to \u0027"},{"line_number":46,"context_line":"                      \u0027but not affected by this setting) is insecure and \u0027"},{"line_number":47,"context_line":"                      \u0027should only be used for testing.\u0027)),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027cleaning_network_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_cd7fd364","line":45,"in_reply_to":"7aa08908_68ea38ae","updated":"2016-06-21 11:16:53.000000000","message":"++ for consistency","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1893649b09411478f09ef9df0d65c07abbcafafe","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027cleaning_network_uuid\u0027,"},{"line_number":49,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":50,"context_line":"                      \u0027into for cleaning nodes. Required for flat and \u0027"},{"line_number":51,"context_line":"                      \u0027neutron network drivers.\u0027))"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"CONF.register_opts(neutron_opts, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_e36769b5","line":51,"updated":"2016-06-15 22:06:02.000000000","message":"but is it required if cleaning is turned off?\n\nDo we have flat and neutron network drivers? I thought that would come later in this chain.\n\nSo that we don\u0027t bikeshed and delay getting this in, maybe just leave the wording that was there before, since the patch is meant to just move the code to a different location.","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1b9fefe34abf51a5c135703d2f456af4fddc0154","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027cleaning_network_uuid\u0027,"},{"line_number":49,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":50,"context_line":"                      \u0027into for cleaning nodes. Required for flat and \u0027"},{"line_number":51,"context_line":"                      \u0027neutron network drivers.\u0027))"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"CONF.register_opts(neutron_opts, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_32034a11","line":51,"in_reply_to":"5a9d85d2_4d192379","updated":"2016-06-21 14:48:22.000000000","message":"It is required in the case of network_interface, it is checked in __init__, please comment on the further patches now :)","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"846d99d8c4faf59e72ffde3657e2c3a360f49663","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027cleaning_network_uuid\u0027,"},{"line_number":49,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":50,"context_line":"                      \u0027into for cleaning nodes. Required for flat and \u0027"},{"line_number":51,"context_line":"                      \u0027neutron network drivers.\u0027))"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"CONF.register_opts(neutron_opts, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_4d192379","line":51,"in_reply_to":"7aa08908_e36769b5","updated":"2016-06-21 11:16:53.000000000","message":"I think it\u0027s not, or at least should be not required if cleaning is disabled.","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"cbced64151bb46f60df08278439cf6de61eb7be8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        params[\u0027endpoint_url\u0027] \u003d CONF.neutron.url"},{"line_number":67,"context_line":"        params[\u0027auth_strategy\u0027] \u003d \u0027noauth\u0027"},{"line_number":68,"context_line":"    else:"},{"line_number":69,"context_line":"        params[\u0027endpoint_url\u0027] \u003d ("},{"line_number":70,"context_line":"            CONF.neutron.url or"},{"line_number":71,"context_line":"            keystone.get_service_url(service_type\u003d\u0027network\u0027))"},{"line_number":72,"context_line":"        params[\u0027username\u0027] \u003d CONF.keystone_authtoken.admin_user"},{"line_number":73,"context_line":"        params[\u0027tenant_name\u0027] \u003d CONF.keystone_authtoken.admin_tenant_name"},{"line_number":74,"context_line":"        params[\u0027password\u0027] \u003d CONF.keystone_authtoken.admin_password"},{"line_number":75,"context_line":"        params[\u0027auth_url\u0027] \u003d (CONF.keystone_authtoken.auth_uri or \u0027\u0027)"},{"line_number":76,"context_line":"        if CONF.keystone.region_name:"},{"line_number":77,"context_line":"            params[\u0027region_name\u0027] \u003d CONF.keystone.region_name"},{"line_number":78,"context_line":"        params[\u0027token\u0027] \u003d token"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    return clientv20.Client(**params)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_00fee837","line":78,"range":{"start_line":69,"start_character":0,"end_line":78,"end_character":31},"updated":"2016-06-15 23:08:47.000000000","message":"why don\u0027t you use \n\nfrom keystoneauth1 import loading as ks_loading\nfrom keystoneauth1 import session\n_SESSION \u003d ks_loading.load_session_from_conf_options(\nauth_plugin \u003d ks_loading.load_auth_from_conf_options(conf, NEUTRON_GROUP)\n\nto load the session from config instead of getting each parameter.\n\nsee the nova code example \nhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L87-88\nhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L96","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1cf4af6ff09f166e1e5531412fba2ef266f79178","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        params[\u0027endpoint_url\u0027] \u003d CONF.neutron.url"},{"line_number":67,"context_line":"        params[\u0027auth_strategy\u0027] \u003d \u0027noauth\u0027"},{"line_number":68,"context_line":"    else:"},{"line_number":69,"context_line":"        params[\u0027endpoint_url\u0027] \u003d ("},{"line_number":70,"context_line":"            CONF.neutron.url or"},{"line_number":71,"context_line":"            keystone.get_service_url(service_type\u003d\u0027network\u0027))"},{"line_number":72,"context_line":"        params[\u0027username\u0027] \u003d CONF.keystone_authtoken.admin_user"},{"line_number":73,"context_line":"        params[\u0027tenant_name\u0027] \u003d CONF.keystone_authtoken.admin_tenant_name"},{"line_number":74,"context_line":"        params[\u0027password\u0027] \u003d CONF.keystone_authtoken.admin_password"},{"line_number":75,"context_line":"        params[\u0027auth_url\u0027] \u003d (CONF.keystone_authtoken.auth_uri or \u0027\u0027)"},{"line_number":76,"context_line":"        if CONF.keystone.region_name:"},{"line_number":77,"context_line":"            params[\u0027region_name\u0027] \u003d CONF.keystone.region_name"},{"line_number":78,"context_line":"        params[\u0027token\u0027] \u003d token"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    return clientv20.Client(**params)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_6917dc51","line":78,"range":{"start_line":69,"start_character":0,"end_line":78,"end_character":31},"in_reply_to":"7aa08908_00fee837","updated":"2016-06-20 17:04:40.000000000","message":"Moshe, there\u0027s an patch series that moves whole Ironic to use keystoneauth https://review.openstack.org/#/q/topic:use-ksa+project:openstack/ironic\n\nbut it is true, these two are not dependent on each other, so who ever merges first, the other would need to rebase and I\u0027l look into it.","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"}],"ironic/dhcp/neutron.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1390b569c46bd0005ed815c71b999832c3ad233f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from ironic import objects"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONF \u003d cfg.CONF"},{"line_number":35,"context_line":"CONF.import_opt(\u0027port_setup_delay\u0027, \u0027ironic.common.neutron\u0027, \u0027neutron\u0027)"},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_e25ed6e7","line":35,"updated":"2016-05-26 11:57:12.000000000","message":"No need to do import_opt, you already import the whole module.","commit_id":"cb8118d0c08c0409b20544dd5670f5489cffd520"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"eab7ed5ac51ce7371fbabe6292ae738000687c3f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from ironic import objects"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONF \u003d cfg.CONF"},{"line_number":35,"context_line":"CONF.import_opt(\u0027port_setup_delay\u0027, \u0027ironic.common.neutron\u0027, \u0027neutron\u0027)"},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_360c9ceb","line":35,"in_reply_to":"bab6814e_e25ed6e7","updated":"2016-05-26 14:57:13.000000000","message":"Done","commit_id":"cb8118d0c08c0409b20544dd5670f5489cffd520"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"cbced64151bb46f60df08278439cf6de61eb7be8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        port_req_body \u003d {\u0027port\u0027: {\u0027extra_dhcp_opts\u0027: dhcp_options}}"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            neutron.get_client(token).update_port(port_id, port_req_body)"},{"line_number":67,"context_line":"        except neutron_client_exc.NeutronClientException:"},{"line_number":68,"context_line":"            LOG.exception(_LE(\"Failed to update Neutron port %s.\"), port_id)"},{"line_number":69,"context_line":"            raise exception.FailedToUpdateDHCPOptOnPort(port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_003b8839","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":31},"updated":"2016-06-15 23:08:47.000000000","message":"this will create client every call, why not once \nlike it done in nova\nhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L144-L145","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1b9fefe34abf51a5c135703d2f456af4fddc0154","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        port_req_body \u003d {\u0027port\u0027: {\u0027extra_dhcp_opts\u0027: dhcp_options}}"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            neutron.get_client(token).update_port(port_id, port_req_body)"},{"line_number":67,"context_line":"        except neutron_client_exc.NeutronClientException:"},{"line_number":68,"context_line":"            LOG.exception(_LE(\"Failed to update Neutron port %s.\"), port_id)"},{"line_number":69,"context_line":"            raise exception.FailedToUpdateDHCPOptOnPort(port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_a28ff621","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":31},"in_reply_to":"7aa08908_003b8839","updated":"2016-06-21 14:48:22.000000000","message":"I\u0027d like this patch to be minimal to get it in as fast as possible. We can optimize afterwards.","commit_id":"84d80fd7a26e358059cf4bf8a5e656c1dcdc7652"}],"releasenotes/notes/dhcp-providers-interface-change-53a2f48a292c9a6e.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"948ad4bd0efd298b786b01e5065d553aa101c9ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The BaseDHCP.update_dhcp_opts() vifs parameter was changed to:"},{"line_number":5,"context_line":"    ``{\u0027ports\u0027: {\u0027port.uuid\u0027: vif.id}, \u0027portgroups\u0027: {\u0027portgroup.uuid\u0027: vif.id}}``."},{"line_number":6,"context_line":"    This is a breaking change for out-of-tree DHCP providers."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5a9d85d2_d2276662","line":4,"updated":"2016-06-21 14:43:36.000000000","message":"This comes from one of the old patches that did it, not sure if we want to keep it.","commit_id":"4fdf1eac61a95cddc155fe60c761a2c954ef2157"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4c8d8c1dcda8ecc12aa6d0a5b387fe6d57802339","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The BaseDHCP.update_dhcp_opts() vifs parameter was changed to:"},{"line_number":5,"context_line":"    ``{\u0027ports\u0027: {\u0027port.uuid\u0027: vif.id}, \u0027portgroups\u0027: {\u0027portgroup.uuid\u0027: vif.id}}``."},{"line_number":6,"context_line":"    This is a breaking change for out-of-tree DHCP providers."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3aaa91ec_b841000e","line":6,"updated":"2016-06-22 13:49:47.000000000","message":"What does this have to do with this patch?","commit_id":"67536637ac3092ae86b51074ead91d4fed6cabc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3d2cc6c9369544799a7a0a914c92a39d46b719e7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The BaseDHCP.update_dhcp_opts() vifs parameter was changed to:"},{"line_number":5,"context_line":"    ``{\u0027ports\u0027: {\u0027port.uuid\u0027: vif.id}, \u0027portgroups\u0027: {\u0027portgroup.uuid\u0027: vif.id}}``."},{"line_number":6,"context_line":"    This is a breaking change for out-of-tree DHCP providers."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3aaa91ec_2822b400","line":6,"in_reply_to":"3aaa91ec_b841000e","updated":"2016-06-23 09:20:11.000000000","message":"Done","commit_id":"67536637ac3092ae86b51074ead91d4fed6cabc4"}]}
