)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"67a0c3f859ef3082fb60f4968777cc9928917ab6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add network_interface node field DB, OBJ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new filed \u0027network_interface\u0027 to node object."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id9b9f4199c2640ca30b2d87c3a517c65f9cb5527"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_39af13e5","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":27},"updated":"2016-05-18 03:41:39.000000000","message":"nit: s/filed/field","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b4960f8051f0ea2fe205a6b7269d4a5791ba4a8c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add network_interface node field DB, OBJ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new filed \u0027network_interface\u0027 to node object."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id9b9f4199c2640ca30b2d87c3a517c65f9cb5527"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_11595f35","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":27},"in_reply_to":"bab6814e_39af13e5","updated":"2016-05-24 16:15:08.000000000","message":"Done","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"925e8aa663ee0481a0556b4ad4cccbb58adf76f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-24 13:33:13 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add network_interface node field DB, OBJ"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new field \u0027network_interface\u0027 to node object."},{"line_number":10,"context_line":"Its default value depends on which DHCP provider is being used"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3aaa91ec_f4231054","line":7,"updated":"2016-06-24 15:08:39.000000000","message":"s/DB, OBJ/to DB and object/ if you have enough characters.","commit_id":"61f078e752c3f908ecdf055ced728c7a66fb4700"}],"ironic/db/sqlalchemy/alembic/versions/e294876e8028_add_node_network_interface.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"02141ade63189528de353139fa53eb0ce0ee4774","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF.import_opt(\u0027dhcp_provider\u0027, \u0027ironic.common.dhcp_factory\u0027, group\u003d\u0027dhcp\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_8233ae61","line":32,"updated":"2016-06-23 15:01:41.000000000","message":"We can switch to importing ironic.conf.CONF and drop this import_opt","commit_id":"9e29d46ead677f0435c2152ab8e9f044a785b3ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"989f83930d45a9b0df0aef693c094b3eb2141621","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                  column(\u0027network_interface\u0027, sa.String(255)))"},{"line_number":38,"context_line":"    op.execute("},{"line_number":39,"context_line":"        nodes.update().values("},{"line_number":40,"context_line":"            {\u0027network_interface\u0027: models.get_network_interface()}))"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_104d7972","line":40,"updated":"2016-06-28 15:22:28.000000000","message":"we should leave NULL values there (meaning \"use the default\", where the default is probably configurable or can be taken from the configuration)","commit_id":"d056459ade1e05d52ebe0ba09eedb135b7299052"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7126454f6108a32c879d22678c7139e12a77dc2a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                  column(\u0027network_interface\u0027, sa.String(255)))"},{"line_number":38,"context_line":"    op.execute("},{"line_number":39,"context_line":"        nodes.update().values("},{"line_number":40,"context_line":"            {\u0027network_interface\u0027: models.get_network_interface()}))"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_d6a76a09","line":40,"in_reply_to":"3aaa91ec_104d7972","updated":"2016-06-28 15:40:29.000000000","message":"Dmitry raises a good point that this should likely be configurable.  I kind of think it might be fine as-is since this is the introduction of the field, but eventually site defaults might be something that an operator may want to be able to assert.","commit_id":"d056459ade1e05d52ebe0ba09eedb135b7299052"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a8a9624ec6ab88d0e5088c9ccd9ebbbe36c8473f","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":152,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    network_interface \u003d Column(String(255), default\u003d\u0027flat\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_44d20cd2","line":154,"range":{"start_line":154,"start_character":44,"end_line":154,"end_character":58},"updated":"2016-05-17 15:02:51.000000000","message":"This default is not covered by any test.","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"67a0c3f859ef3082fb60f4968777cc9928917ab6","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":152,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    network_interface \u003d Column(String(255), default\u003d\u0027flat\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_d913670c","line":154,"range":{"start_line":154,"start_character":44,"end_line":154,"end_character":58},"in_reply_to":"dab17558_44d20cd2","updated":"2016-05-18 03:41:39.000000000","message":"+1","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b4960f8051f0ea2fe205a6b7269d4a5791ba4a8c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":152,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    network_interface \u003d Column(String(255), default\u003d\u0027flat\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0098e71a","line":154,"range":{"start_line":154,"start_character":44,"end_line":154,"end_character":58},"in_reply_to":"dab17558_44d20cd2","updated":"2016-05-24 16:15:08.000000000","message":"Done","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6e06b75b53326e9dd5cb04f8f26b9017cd3c96e7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":144,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    network_interface \u003d Column(String(255), default\u003d\u0027flat\u0027)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_597d6db0","line":146,"range":{"start_line":146,"start_character":44,"end_line":146,"end_character":58},"updated":"2016-06-22 19:59:33.000000000","message":"To satisfy standalone we need this default to change based on if CONF.dhcp.dhcp_provider \u003d\u003d \u0027none\u0027 so new nodes that are created maintain the expected behaviour.","commit_id":"ccebe97582ae1aee5232957d02821a40d9c24c93"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e67cab6c52da5562b8379a2cb06cfb213a65df5","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":144,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    network_interface \u003d Column(String(255), default\u003d\u0027flat\u0027)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_e840aca7","line":146,"range":{"start_line":146,"start_character":44,"end_line":146,"end_character":58},"in_reply_to":"3aaa91ec_597d6db0","updated":"2016-06-23 09:19:34.000000000","message":"Good idea, done!","commit_id":"ccebe97582ae1aee5232957d02821a40d9c24c93"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fa6edcbf50fe22465e9f9fd9487543476865bc2e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":144,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    default_network_interface \u003d (\u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027"},{"line_number":147,"context_line":"                                 else \u0027none\u0027)"},{"line_number":148,"context_line":"    network_interface \u003d Column(String(255), default\u003ddefault_network_interface)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_c31caa15","line":146,"range":{"start_line":146,"start_character":43,"end_line":146,"end_character":66},"updated":"2016-06-23 11:50:07.000000000","message":"Please import this option.","commit_id":"9e29d46ead677f0435c2152ab8e9f044a785b3ad"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"40f2ad2bfc1854dfe7ee56781bfd3e77047347aa","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":144,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    default_network_interface \u003d (\u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027"},{"line_number":147,"context_line":"                                 else \u0027none\u0027)"},{"line_number":148,"context_line":"    network_interface \u003d Column(String(255), default\u003ddefault_network_interface)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_3f8ad31b","line":146,"range":{"start_line":146,"start_character":43,"end_line":146,"end_character":66},"in_reply_to":"3aaa91ec_c31caa15","updated":"2016-06-23 14:49:39.000000000","message":"Looks like not needed we have now dhcp option in centralized config.","commit_id":"9e29d46ead677f0435c2152ab8e9f044a785b3ad"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"02141ade63189528de353139fa53eb0ce0ee4774","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":144,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    default_network_interface \u003d (\u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027"},{"line_number":147,"context_line":"                                 else \u0027none\u0027)"},{"line_number":148,"context_line":"    network_interface \u003d Column(String(255), default\u003ddefault_network_interface)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_c2cc966c","line":146,"range":{"start_line":146,"start_character":43,"end_line":146,"end_character":66},"in_reply_to":"3aaa91ec_c31caa15","updated":"2016-06-23 15:01:41.000000000","message":"We have ironic.conf import at the top, which in turn imports ironic.conf.dhcp, so we should be OK without import_opt.","commit_id":"9e29d46ead677f0435c2152ab8e9f044a785b3ad"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fa6edcbf50fe22465e9f9fd9487543476865bc2e","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    default_network_interface \u003d (\u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027"},{"line_number":147,"context_line":"                                 else \u0027none\u0027)"},{"line_number":148,"context_line":"    network_interface \u003d Column(String(255), default\u003ddefault_network_interface)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_0374f2fa","line":148,"updated":"2016-06-23 11:50:07.000000000","message":"Better use default parameter as function here, I\u0027m not sure that config file parsed at moment when we define default_network_interface.","commit_id":"9e29d46ead677f0435c2152ab8e9f044a785b3ad"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cc8be62d50b1836134c9dd32f278e50895f3fd22","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    default_network_interface \u003d (\u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027"},{"line_number":147,"context_line":"                                 else \u0027none\u0027)"},{"line_number":148,"context_line":"    network_interface \u003d Column(String(255), default\u003ddefault_network_interface)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_2f62afad","line":148,"in_reply_to":"3aaa91ec_0374f2fa","updated":"2016-06-23 12:37:05.000000000","message":"And furthermore, it seems that if we add the default logic here, we can drop it from the migration, I\u0027ll test this locally too.","commit_id":"9e29d46ead677f0435c2152ab8e9f044a785b3ad"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"02141ade63189528de353139fa53eb0ce0ee4774","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    default_network_interface \u003d (\u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027"},{"line_number":147,"context_line":"                                 else \u0027none\u0027)"},{"line_number":148,"context_line":"    network_interface \u003d Column(String(255), default\u003ddefault_network_interface)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_22e47adf","line":148,"in_reply_to":"3aaa91ec_2f62afad","updated":"2016-06-23 15:01:41.000000000","message":"Unfortunately, this is not the case, we should have it both here and in migration :(","commit_id":"9e29d46ead677f0435c2152ab8e9f044a785b3ad"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"cb636ee98e349d78936e737dd209fc6fa9d61114","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    return None"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def get_network_interface():"},{"line_number":49,"context_line":"    return \u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027 else \u0027none\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_ca32c80f","line":48,"updated":"2016-06-24 07:29:56.000000000","message":"nit: better mark this function as module \"private\" with \"_\" prefix.","commit_id":"982773da4fabc862c60df849de57218c72657d92"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"742f6467c440b444db45cb666d0a3ed8bc17e5f6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    return None"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def get_network_interface():"},{"line_number":49,"context_line":"    return \u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027 else \u0027none\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_cd749037","line":48,"in_reply_to":"3aaa91ec_ca32c80f","updated":"2016-06-24 14:03:21.000000000","message":"To deduplicate this logic from migration, I\u0027ve used this function there too.","commit_id":"982773da4fabc862c60df849de57218c72657d92"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"308e9fc8dd28ee4f81138636c0c08e17aa270e31","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    inspection_finished_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":143,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":144,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    network_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_0bf7c48b","line":145,"updated":"2016-06-29 19:44:58.000000000","message":"nit: Not sure why a blank line","commit_id":"b186297f324231db43f77999359714c67aa45973"}],"ironic/objects/node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"343f1cc702395d5ef224d6a02c81ced7f8b31d99","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # composable interfaces"},{"line_number":107,"context_line":"        \u0027network_interface\u0027: object_fields.StringField(),"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_55a3e0ff","line":106,"updated":"2016-05-17 14:08:17.000000000","message":"Ruby\u0027s comment from PS 39\n\nwhat do you mean by \u0027composable\u0027? Isn\u0027t this going to be one of the values from CONF.enabled_network_drivers?","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b4960f8051f0ea2fe205a6b7269d4a5791ba4a8c","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # composable interfaces"},{"line_number":107,"context_line":"        \u0027network_interface\u0027: object_fields.StringField(),"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_20a1ab46","line":106,"in_reply_to":"dab17558_55a3e0ff","updated":"2016-05-24 16:15:08.000000000","message":"Done","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"}],"ironic/tests/unit/api/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4d5ad66d41f7214e7273fb50d0f6174da66fce65","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    node.pop(\u0027chassis_id\u0027)"},{"line_number":96,"context_line":"    node.pop(\u0027tags\u0027)"},{"line_number":97,"context_line":"    if \u0027network_interface\u0027 not in kw:"},{"line_number":98,"context_line":"        node.pop(\u0027network_interface\u0027)"},{"line_number":99,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":100,"context_line":"    return remove_internal(node, internal)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_7f07701d","line":98,"updated":"2016-06-28 14:53:13.000000000","message":"I\u0027m not sure why you\u0027d remove network_interface. It will be part of the API object, won\u0027t it? Or are you doing this for now, and then adding it back in when we add it to the API object? (Maybe a #TODO or comment would help.)","commit_id":"d056459ade1e05d52ebe0ba09eedb135b7299052"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d4a4d27427c7c7642cf2edfb4d13496b36ba129d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    node.pop(\u0027chassis_id\u0027)"},{"line_number":96,"context_line":"    node.pop(\u0027tags\u0027)"},{"line_number":97,"context_line":"    if \u0027network_interface\u0027 not in kw:"},{"line_number":98,"context_line":"        node.pop(\u0027network_interface\u0027)"},{"line_number":99,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":100,"context_line":"    return remove_internal(node, internal)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_70b9562e","line":98,"in_reply_to":"3aaa91ec_75ab0f1f","updated":"2016-06-28 17:17:21.000000000","message":"It will be removed when network_interface field is added to a node, otherwise all the unittests creating a node will complain about unknown attribute. I\u0027ll add a TODO.","commit_id":"d056459ade1e05d52ebe0ba09eedb135b7299052"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7126454f6108a32c879d22678c7139e12a77dc2a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    node.pop(\u0027chassis_id\u0027)"},{"line_number":96,"context_line":"    node.pop(\u0027tags\u0027)"},{"line_number":97,"context_line":"    if \u0027network_interface\u0027 not in kw:"},{"line_number":98,"context_line":"        node.pop(\u0027network_interface\u0027)"},{"line_number":99,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":100,"context_line":"    return remove_internal(node, internal)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_75ab0f1f","line":98,"in_reply_to":"3aaa91ec_7f07701d","updated":"2016-06-28 15:40:29.000000000","message":"Agreed, a little confused why the lines added on line 107 are also removed in later revisions, but not this.","commit_id":"d056459ade1e05d52ebe0ba09eedb135b7299052"}],"ironic/tests/unit/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"343f1cc702395d5ef224d6a02c81ced7f8b31d99","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        self.assertIn(\u0027network_interface\u0027, col_names)"},{"line_number":421,"context_line":"        self.assertIsInstance(nodes.c.network_interface.type,"},{"line_number":422,"context_line":"                              sqlalchemy.types.String)"},{"line_number":423,"context_line":"        # TODO(vdrok): add a check that vaulue is \u0027flat\u0027"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_upgrade_and_version(self):"},{"line_number":426,"context_line":"        with patch_with_engine(self.engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f562d4ab","line":423,"updated":"2016-05-17 14:08:17.000000000","message":"Now we should definitely change this test, as there is a conditional in migration now.","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b1d20f4e7b88a8c3a996133c4c5f41fd1965900e","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        self.assertIn(\u0027network_interface\u0027, col_names)"},{"line_number":421,"context_line":"        self.assertIsInstance(nodes.c.network_interface.type,"},{"line_number":422,"context_line":"                              sqlalchemy.types.String)"},{"line_number":423,"context_line":"        # TODO(vdrok): add a check that vaulue is \u0027flat\u0027"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_upgrade_and_version(self):"},{"line_number":426,"context_line":"        with patch_with_engine(self.engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_af6f5129","line":423,"in_reply_to":"dab17558_f562d4ab","updated":"2016-05-17 15:19:37.000000000","message":"+1","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b4960f8051f0ea2fe205a6b7269d4a5791ba4a8c","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        self.assertIn(\u0027network_interface\u0027, col_names)"},{"line_number":421,"context_line":"        self.assertIsInstance(nodes.c.network_interface.type,"},{"line_number":422,"context_line":"                              sqlalchemy.types.String)"},{"line_number":423,"context_line":"        # TODO(vdrok): add a check that vaulue is \u0027flat\u0027"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_upgrade_and_version(self):"},{"line_number":426,"context_line":"        with patch_with_engine(self.engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_a000fb02","line":423,"in_reply_to":"dab17558_f562d4ab","updated":"2016-05-24 16:15:08.000000000","message":"I have added tests for default case, when dhcp_provider is neutron. Unfortunately current test model doesn\u0027t allow to launch several different tests for specific upgrade.","commit_id":"1f49c9fb75fed65123fe6711b218e9107910c9d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c80d60a32073c5e5380926573a9724df6f1da534","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        # multi tests per upgrade."},{"line_number":433,"context_line":"        result \u003d nodes.select("},{"line_number":434,"context_line":"            nodes.c.uuid \u003d\u003d data[0][\u0027uuid\u0027]).execute().first()"},{"line_number":435,"context_line":"        self.assertEqual(\u0027flat\u0027, result[\u0027network_interface\u0027])"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def test_upgrade_and_version(self):"},{"line_number":438,"context_line":"        with patch_with_engine(self.engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_bbc9177c","line":435,"updated":"2016-06-15 17:43:55.000000000","message":"I truly think we need to test when the dhcp driver is configured for none as well because we have a decently sized operator user base at this point in time that are using ironic in a stand-alone mode without the other services.","commit_id":"3969d1aee10fe33d1116d51516e831eeb2b432c1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"506c9aab43b30851cb16342dfefa8046ffc6cf5c","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        # multi tests per upgrade."},{"line_number":433,"context_line":"        result \u003d nodes.select("},{"line_number":434,"context_line":"            nodes.c.uuid \u003d\u003d data[0][\u0027uuid\u0027]).execute().first()"},{"line_number":435,"context_line":"        self.assertEqual(\u0027flat\u0027, result[\u0027network_interface\u0027])"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def test_upgrade_and_version(self):"},{"line_number":438,"context_line":"        with patch_with_engine(self.engine):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a9d85d2_fd64f3e5","line":435,"in_reply_to":"7aa08908_bbc9177c","updated":"2016-06-21 14:50:49.000000000","message":"I agree with that, but it is the way our migrations work now - you cant run the same migration twice - once with dhcp provider neutron, and then with flat. It is handled by just one if, so I hope this is acceptable :)","commit_id":"3969d1aee10fe33d1116d51516e831eeb2b432c1"}]}
