)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4277bc7b75fd0fa54ac9d78684d9944fd826e48d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Expose node\u0027s network_interface field in API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch also adds restrictions on the node states in which network"},{"line_number":10,"context_line":"interface change is possible and whether the network interface is"},{"line_number":11,"context_line":"enabled on the conductor side."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1526403"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1aa78d24_6eb57deb","line":10,"updated":"2016-07-13 01:45:04.000000000","message":"nit: I think s/network\\ interface/requested\\ network\\ interface/ may read a little more clearly.","commit_id":"b31590ccdca6d29715b15f4b08e0355394e65df6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8886c7206de3b0d9cef0d46b9831e6bf67e7316b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Expose node\u0027s network_interface field in API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch also adds restrictions on the node states in which network"},{"line_number":10,"context_line":"interface change is possible and whether the network interface is"},{"line_number":11,"context_line":"enabled on the conductor side."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1526403"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1aa78d24_71426c69","line":10,"in_reply_to":"1aa78d24_6eb57deb","updated":"2016-07-13 10:45:14.000000000","message":"Done","commit_id":"b31590ccdca6d29715b15f4b08e0355394e65df6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f681a124b04c5ce66fbd1663dfe51b409d4fdc34","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Expose node\u0027s network_interface field in API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch also adds restrictions on the node states in which network"},{"line_number":10,"context_line":"interface change is possible and whether the requested network"},{"line_number":11,"context_line":"interface is enabled on the conductor side."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1aa78d24_e948d98c","line":9,"updated":"2016-07-14 20:01:13.000000000","message":"It would be good to repeat (sorry) what is in the title above, and mention that it bumps API version to 1.20.","commit_id":"4bf0486f263891e9a104ff0bb003168691f22895"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f681a124b04c5ce66fbd1663dfe51b409d4fdc34","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch also adds restrictions on the node states in which network"},{"line_number":10,"context_line":"interface change is possible and whether the requested network"},{"line_number":11,"context_line":"interface is enabled on the conductor side."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1526403"},{"line_number":14,"context_line":"Co-Authored-By: Om Kumar \u003com.kumar@hp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1aa78d24_695d0948","line":11,"updated":"2016-07-14 20:01:13.000000000","message":"hmm, might want to update this part.","commit_id":"4bf0486f263891e9a104ff0bb003168691f22895"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c45c2c733ee1a14d1335f81caf3d800027962c75","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch also adds restrictions on the node states in which network"},{"line_number":10,"context_line":"interface change is possible and whether the requested network"},{"line_number":11,"context_line":"interface is enabled on the conductor side."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-bug: #1526403"},{"line_number":14,"context_line":"Co-Authored-By: Om Kumar \u003com.kumar@hp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1aa78d24_8ceb23dc","line":11,"in_reply_to":"1aa78d24_695d0948","updated":"2016-07-14 20:30:17.000000000","message":"Yeah, I kind of agree with that, however I can live with the commit message being slightly off in the interest of moving things forward.","commit_id":"4bf0486f263891e9a104ff0bb003168691f22895"}],"doc/source/webapi/v1.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85189876eb8c125873673ab7ca7ba263331cf08e","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"**1.20**"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    This API version adds the ``network_interface`` attribute to a node."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"**1.19**"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"1aa78d24_fa09f585","line":37,"updated":"2016-07-13 21:50:22.000000000","message":"I took a look at the existing descriptions, we use \u0027field\u0027 instead of \u0027attribute\u0027. To make it consistent with some of the others (eg see 1.7 \u0026 1.3) how about\n\nAdd node ``network_interface`` field.","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ff612c4133bedddc0a1b18d1ae3d6ac4fdd00737","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"**1.20**"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    This API version adds the ``network_interface`` attribute to a node."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"**1.19**"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"1aa78d24_154bdd60","line":37,"in_reply_to":"1aa78d24_fa09f585","updated":"2016-07-14 11:02:48.000000000","message":"Done","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"8b8eaae2df2d1a43e6c61957048e63a5a72b7122","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        obj.raid_config \u003d wsme.Unset"},{"line_number":124,"context_line":"        obj.target_raid_config \u003d wsme.Unset"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    if not api_utils.allow_network_interface():"},{"line_number":127,"context_line":"        obj.network_interface \u003d wsme.Unset"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f0278bc7","line":126,"updated":"2016-05-17 11:56:09.000000000","message":"For clarity and consistency, I think this should directly rely on an API version instead.","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1df083e755478bfb117c4f982d56651185fe0f38","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        obj.raid_config \u003d wsme.Unset"},{"line_number":124,"context_line":"        obj.target_raid_config \u003d wsme.Unset"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    if not api_utils.allow_network_interface():"},{"line_number":127,"context_line":"        obj.network_interface \u003d wsme.Unset"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_935d214b","line":126,"in_reply_to":"dab17558_f0278bc7","updated":"2016-05-24 16:15:24.000000000","message":"Done","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"51d7433f7103b2cfa7b0692052cf83ade98f28f6","unresolved":false,"context_lines":[{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"        n_interface \u003d node.as_dict().get(\u0027network_interface\u0027)"},{"line_number":1249,"context_line":"        if (not api_utils.allow_network_interface() and n_interface):"},{"line_number":1250,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"        # NOTE(deva): get_topic_for checks if node.driver is in the hash ring"},{"line_number":1253,"context_line":"        #             and raises NoValidHost if it is not."}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_fae00228","line":1250,"updated":"2016-05-17 14:10:22.000000000","message":"There was a part here checking that network interface is valid, it\u0027s lost.\n\nRuby\u0027s comments from PS 39 regarding this lost part:\n\ns/a/an/\nAlthough this might make more sense: s/a/the/\nThe user may not know the valid values -- should we output those too, eg \u0027Valid network interfaces are: ....\u0027.\n\nmaybe put single quotes around the interface value or do something like s/invalid/invalid value: / ?\nOtherwise it\u0027ll look something like \u0027to invalid foo\u0027 which might be hard to understand.","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1df083e755478bfb117c4f982d56651185fe0f38","unresolved":false,"context_lines":[{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        n_interfaces \u003d api_utils.get_patch_values(patch, \u0027/network_interface\u0027)"},{"line_number":1292,"context_line":"        if (not api_utils.allow_network_interface() and n_interfaces):"},{"line_number":1293,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"},{"line_number":1296,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_cf537d6b","line":1293,"updated":"2016-05-24 16:15:24.000000000","message":"Ruby\u0027s comments from PS 39 regarding this lost part:\n\nmaybe put single quotes around the interface value or do something like s/invalid/invalid value: / ?\n\nOtherwise it\u0027ll look something like \u0027to invalid foo\u0027 which might be hard to understand.\n\nDone","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fdc0c200711ef4013d613d1265f00e7175e0966e","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"        if self.from_chassis:"},{"line_number":1244,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"        n_interface \u003d node.as_dict().get(\u0027network_interface\u0027)"},{"line_number":1247,"context_line":"        if (not api_utils.allow_network_interface() and n_interface):"},{"line_number":1248,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1249,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_45f6cc8f","line":1246,"updated":"2016-05-26 12:24:55.000000000","message":"Why not just node.network_interface? It can have value wsme.Unset, if you need None, you can do \"node.network_interface or None\", that should work.","commit_id":"07d891d0aa790008d190a228cad61fe4af913b47"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6486d01a99b85dc7c74c2acfc0ff16eb4e5ff3e6","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"        if self.from_chassis:"},{"line_number":1244,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"        n_interface \u003d node.as_dict().get(\u0027network_interface\u0027)"},{"line_number":1247,"context_line":"        if (not api_utils.allow_network_interface() and n_interface):"},{"line_number":1248,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1249,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_513dea29","line":1246,"in_reply_to":"bab6814e_45f6cc8f","updated":"2016-05-26 14:58:29.000000000","message":"Done","commit_id":"07d891d0aa790008d190a228cad61fe4af913b47"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fdc0c200711ef4013d613d1265f00e7175e0966e","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"        if (not api_utils.allow_network_interface() and n_interface):"},{"line_number":1248,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":"        if (n_interface is not None and"},{"line_number":1251,"context_line":"                not api_utils.is_valid_network_interface(n_interface)):"},{"line_number":1252,"context_line":"            error_msg \u003d _(\"Cannot create node with the invalid network \""},{"line_number":1253,"context_line":"                          \"interface %(n_interface)s. Enabled network \""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_8548b4b4","line":1250,"updated":"2016-05-26 12:24:55.000000000","message":"Here you check is is not None, on L1247 you just check \"if n_interface\"","commit_id":"07d891d0aa790008d190a228cad61fe4af913b47"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6486d01a99b85dc7c74c2acfc0ff16eb4e5ff3e6","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"        if (not api_utils.allow_network_interface() and n_interface):"},{"line_number":1248,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":"        if (n_interface is not None and"},{"line_number":1251,"context_line":"                not api_utils.is_valid_network_interface(n_interface)):"},{"line_number":1252,"context_line":"            error_msg \u003d _(\"Cannot create node with the invalid network \""},{"line_number":1253,"context_line":"                          \"interface %(n_interface)s. Enabled network \""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_f1605e37","line":1250,"in_reply_to":"bab6814e_8548b4b4","updated":"2016-05-26 14:58:29.000000000","message":"Done","commit_id":"07d891d0aa790008d190a228cad61fe4af913b47"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fdc0c200711ef4013d613d1265f00e7175e0966e","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"            raise exception.OperationNotPermitted"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"        n_interfaces \u003d api_utils.get_patch_values(patch, \u0027/network_interface\u0027)"},{"line_number":1300,"context_line":"        if (not api_utils.allow_network_interface() and n_interfaces):"},{"line_number":1301,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"        for n_interface in n_interfaces:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_e59540e4","line":1300,"updated":"2016-05-26 12:24:55.000000000","message":"In this case it should be OK as n_interfaces is a list.","commit_id":"07d891d0aa790008d190a228cad61fe4af913b47"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"07d66acd28b115cd69461a3f50afb85b79312bb0","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"                error_msg % {\u0027n_interface\u0027: n_interface,"},{"line_number":1273,"context_line":"                             \u0027enabled_int\u0027: CONF.enabled_network_interfaces},"},{"line_number":1274,"context_line":"                status_code\u003dhttp_client.BAD_REQUEST)"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":"        # NOTE(deva): get_topic_for checks if node.driver is in the hash ring"},{"line_number":1277,"context_line":"        #             and raises NoValidHost if it is not."},{"line_number":1278,"context_line":"        #             We need to ensure that node has a UUID before it can"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_2314b54b","line":1275,"updated":"2016-06-16 12:11:14.000000000","message":"Looks like we\u0027re missing application of some sort of default, if no setting is supplied by an older unaware api client.  If done in the API, It makes sense to have code like that here.","commit_id":"324969ed68d713d60ab3cafdfe3425d5ba9021ef"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"38df9257358b347852574ef91d86e7c7c393ab67","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"                error_msg % {\u0027n_interface\u0027: n_interface,"},{"line_number":1273,"context_line":"                             \u0027enabled_int\u0027: CONF.enabled_network_interfaces},"},{"line_number":1274,"context_line":"                status_code\u003dhttp_client.BAD_REQUEST)"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":"        # NOTE(deva): get_topic_for checks if node.driver is in the hash ring"},{"line_number":1277,"context_line":"        #             and raises NoValidHost if it is not."},{"line_number":1278,"context_line":"        #             We need to ensure that node has a UUID before it can"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a9d85d2_01599ffe","line":1275,"in_reply_to":"7aa08908_2314b54b","updated":"2016-06-21 14:51:55.000000000","message":"I think the default should be set on conductor side, e.g. I think API should not know dhcp_provider that is set in config. Tho we do that for enabled_network_interfaces :( Maybe we should introduce an rpc all for that?","commit_id":"324969ed68d713d60ab3cafdfe3425d5ba9021ef"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"d3dfca8722dd066cb7775836c50c1dc26de5fb95","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1262,"context_line":"            raise"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        enabled_network_interfaces \u003d rpcapi.get_enabled_network_interfaces("},{"line_number":1265,"context_line":"            pecan.request.context, topic\u003dtopic)"},{"line_number":1266,"context_line":"        if (n_interface is not wtypes.Unset and"},{"line_number":1267,"context_line":"                n_interface not in enabled_network_interfaces):"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_cd23a0a9","line":1264,"updated":"2016-07-13 20:49:19.000000000","message":"Shouldn\u0027t this be done at node-validate, not in the node create?\n\nMy primary concern is that this introduces a new potential error for node creation -- if the corresponding conductor doesn\u0027t have any available worker threads, it won\u0027t respond to this call. (or it will take a very long time to respond). So now the client, which previously could enroll many Nodes very quickly, has to wait for the conductor to have free worker threads.....","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"15a563fdab0891603a1bacffbff87d6269a162f0","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1262,"context_line":"            raise"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        enabled_network_interfaces \u003d rpcapi.get_enabled_network_interfaces("},{"line_number":1265,"context_line":"            pecan.request.context, topic\u003dtopic)"},{"line_number":1266,"context_line":"        if (n_interface is not wtypes.Unset and"},{"line_number":1267,"context_line":"                n_interface not in enabled_network_interfaces):"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_071f25b8","line":1264,"in_reply_to":"1aa78d24_9e58858c","updated":"2016-07-14 13:04:04.000000000","message":"\"Also it is impossible to perform any operation on node with non-existed/non-enabled network_interface like update/delete\".\n\nThat\u0027s per-si seems to be a bug, no? We should be able to update the node independently.","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ff612c4133bedddc0a1b18d1ae3d6ac4fdd00737","unresolved":false,"context_lines":[{"line_number":1261,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1262,"context_line":"            raise"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        enabled_network_interfaces \u003d rpcapi.get_enabled_network_interfaces("},{"line_number":1265,"context_line":"            pecan.request.context, topic\u003dtopic)"},{"line_number":1266,"context_line":"        if (n_interface is not wtypes.Unset and"},{"line_number":1267,"context_line":"                n_interface not in enabled_network_interfaces):"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_9e58858c","line":1264,"in_reply_to":"1aa78d24_cd23a0a9","updated":"2016-07-14 11:02:48.000000000","message":"Devananda, the validate() will not help. Since validate() is called on instance of a driver. But conductor will fail to create it. Also it is impossible to perform any operation on node with non-existed/non-enabled network_interface like update/delete. Please have look at the trace [0] \n\nIf performance is the only one concern, we may try to cache list of enabled_network_interfaces on API side during start. But there will be problems when new network_interfaces were added on conductor, but API wasn\u0027t restarted.\n\nThe issue will be fixed permanently when driver-composition-reform from dtantsur takes affect [1].\n\nFor now I inclined to Rubby suggestion, there will be no performance impact on enrolling nodes when network_interface is not used. \n\nif n_interface is not wtypes.Unset:\n        enabled_network_interfaces \u003d rpcapi.get_enabled_network_interfacs()\n        if n_interface not in ...\n\nReference:\n[0] http://paste.openstack.org/show/532762/\n[1] https://review.openstack.org/#/c/188370/20/specs/approved/driver-composition-reform.rst@223","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85189876eb8c125873673ab7ca7ba263331cf08e","unresolved":false,"context_lines":[{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        enabled_network_interfaces \u003d rpcapi.get_enabled_network_interfaces("},{"line_number":1265,"context_line":"            pecan.request.context, topic\u003dtopic)"},{"line_number":1266,"context_line":"        if (n_interface is not wtypes.Unset and"},{"line_number":1267,"context_line":"                n_interface not in enabled_network_interfaces):"},{"line_number":1268,"context_line":"            error_msg \u003d _(\"Cannot create node with the invalid network \""},{"line_number":1269,"context_line":"                          \"interface %(n_interface)s. Enabled network \""}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_6050b8d5","line":1266,"updated":"2016-07-13 21:50:22.000000000","message":"We shouldn\u0027t get the list of enabled network interfaces unless we need them, so I\u0027d make that rpc call in this if ..:\n    if n_interface is not wtypes.Unset:\n        enabled_network_interfaces \u003d rpcapi.get_enabled_network_interfacs()\n        if n_interface not in ...\n\nI am also wondering whether we should be doing the check here, versus in the conductor. We\u0027re going to have to handle this for the driver composition reform, might be worth asking dtantsur where he was going to make these checks. This is also going to depend on the driver/hardware type.\n\nI suppose for now, this is OK. It may mean that we added an RPC call that we may not use in the future.","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f4e85fef9c5f13d5d54b0384ea67a284d0aa755c","unresolved":false,"context_lines":[{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"        if n_interface is not wtypes.Unset:"},{"line_number":1267,"context_line":"            enabled_network_interfaces \u003d rpcapi.get_enabled_network_interfaces("},{"line_number":1268,"context_line":"                pecan.request.context, topic\u003dtopic)"},{"line_number":1269,"context_line":"            if n_interface not in enabled_network_interfaces:"},{"line_number":1270,"context_line":"                error_msg \u003d _(\"Cannot create node with the invalid network \""},{"line_number":1271,"context_line":"                              \"interface %(n_interface)s. Enabled network \""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_4eeaeaad","line":1268,"updated":"2016-07-14 12:10:01.000000000","message":"I think the problems with this actually go deeper than just having to wait on the conductor to return this info.\n\nIn an environment with multiple conductors if any are configured with different network_interfaces enabled, but the same driver enabled, then based on which conductor your node lands on your node create will succeed or fail.\n\nSo you could make the same node-create call twice, and one will pass and one won\u0027t.\n\nWe can\u0027t enforce all conductors have the same enabled_interfaces, because that would be impossible for enabling rolling upgrades of conductors.\n\nAnother solution would be to take into account the interfaces during node to conductor placement like we do the drivers.\n\nI\u0027m not sure how we want to handle this.","commit_id":"8d4446d48be510141eca2954a75365c27e358a98"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"22abce55d0995900c69c7a31b6e10fd693190273","unresolved":false,"context_lines":[{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"        if n_interface is not wtypes.Unset:"},{"line_number":1267,"context_line":"            enabled_network_interfaces \u003d rpcapi.get_enabled_network_interfaces("},{"line_number":1268,"context_line":"                pecan.request.context, topic\u003dtopic)"},{"line_number":1269,"context_line":"            if n_interface not in enabled_network_interfaces:"},{"line_number":1270,"context_line":"                error_msg \u003d _(\"Cannot create node with the invalid network \""},{"line_number":1271,"context_line":"                              \"interface %(n_interface)s. Enabled network \""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_36736817","line":1268,"in_reply_to":"1aa78d24_271b4182","updated":"2016-07-14 15:52:21.000000000","message":"Per IRC discussion it was decided to keep the same list of enabled_network_interfaces on conductor and api nodes. The validation is performed on API side by comparing new network_interface value with value from config.","commit_id":"8d4446d48be510141eca2954a75365c27e358a98"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f1c0f6f4e67980f7bf6e1e3132e8cc312865dbb4","unresolved":false,"context_lines":[{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"        if n_interface is not wtypes.Unset:"},{"line_number":1267,"context_line":"            enabled_network_interfaces \u003d rpcapi.get_enabled_network_interfaces("},{"line_number":1268,"context_line":"                pecan.request.context, topic\u003dtopic)"},{"line_number":1269,"context_line":"            if n_interface not in enabled_network_interfaces:"},{"line_number":1270,"context_line":"                error_msg \u003d _(\"Cannot create node with the invalid network \""},{"line_number":1271,"context_line":"                              \"interface %(n_interface)s. Enabled network \""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_271b4182","line":1268,"in_reply_to":"1aa78d24_4eeaeaad","updated":"2016-07-14 13:08:56.000000000","message":"Agreed, the design of Ironic right now allows ironic conductors to have different configuration files (different drivers enabled and so on, that\u0027s why we have a hash ring).\n\nIf only a conductor with a certain network interface can manage a node that should be considered part of the hash ring so that we make sure that we are routing the requests to act on that node to a conductor that is capable of doing it.","commit_id":"8d4446d48be510141eca2954a75365c27e358a98"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d6d380c9c66c0897b496590b879dd23acafa5dfe","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"        if (n_interface is not wtypes.Unset and"},{"line_number":1255,"context_line":"            not api_utils.is_valid_network_interface(n_interface)):"},{"line_number":1256,"context_line":"            error_msg \u003d _(\"Cannot create node with the invalid network \""},{"line_number":1257,"context_line":"                          \"interface %(n_interface)s. Enabled network \""},{"line_number":1258,"context_line":"                          \"interfaces are: %(enabled_int)s\")"},{"line_number":1259,"context_line":"            raise wsme.exc.ClientSideError("},{"line_number":1260,"context_line":"                error_msg % {\u0027n_interface\u0027: n_interface,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_1688ecc5","line":1257,"updated":"2016-07-14 16:39:19.000000000","message":"nit: I\u0027d put the invalid value in quotes, eg, s/%(n_interface)s/\u0027%(n_interface)s\u0027/","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a40a5761ffcefca91c17c21639f8319a662b97c","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"        if (n_interface is not wtypes.Unset and"},{"line_number":1255,"context_line":"            not api_utils.is_valid_network_interface(n_interface)):"},{"line_number":1256,"context_line":"            error_msg \u003d _(\"Cannot create node with the invalid network \""},{"line_number":1257,"context_line":"                          \"interface %(n_interface)s. Enabled network \""},{"line_number":1258,"context_line":"                          \"interfaces are: %(enabled_int)s\")"},{"line_number":1259,"context_line":"            raise wsme.exc.ClientSideError("},{"line_number":1260,"context_line":"                error_msg % {\u0027n_interface\u0027: n_interface,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_a3755233","line":1257,"in_reply_to":"1aa78d24_1688ecc5","updated":"2016-07-14 19:22:08.000000000","message":"Done","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d6d380c9c66c0897b496590b879dd23acafa5dfe","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"        if self.from_chassis:"},{"line_number":1301,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"        n_interfaces \u003d api_utils.get_patch_values(patch, \u0027/network_interface\u0027)"},{"line_number":1304,"context_line":"        if n_interfaces and not api_utils.allow_network_interface():"},{"line_number":1305,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1306,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_8ae79045","line":1303,"updated":"2016-07-14 16:39:19.000000000","message":"just wondering (or maybe I forgot). The node can only have one network interface specified. In a patch, do we allow them to specify more than one, and then if they do, we ... use the last value? but still process/check all of them?","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a40a5761ffcefca91c17c21639f8319a662b97c","unresolved":false,"context_lines":[{"line_number":1300,"context_line":"        if self.from_chassis:"},{"line_number":1301,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"        n_interfaces \u003d api_utils.get_patch_values(patch, \u0027/network_interface\u0027)"},{"line_number":1304,"context_line":"        if n_interfaces and not api_utils.allow_network_interface():"},{"line_number":1305,"context_line":"            raise exception.NotAcceptable()"},{"line_number":1306,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_0611d404","line":1303,"in_reply_to":"1aa78d24_8ae79045","updated":"2016-07-14 19:22:08.000000000","message":"yes, it is possible to specify field multiple times, and the latest will be used. We usint the same logic for names L1339, all of them should be valid.","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"51d7433f7103b2cfa7b0692052cf83ade98f28f6","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    \"\"\""},{"line_number":255,"context_line":"    if (fields is not None and pecan.request.version.minor \u003c"},{"line_number":256,"context_line":"            versions.MINOR_8_FETCHING_SUBSET_OF_FIELDS):"},{"line_number":257,"context_line":"        raise exception.NotAcceptable()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"def check_allow_management_verbs(verb):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_1aace68a","line":257,"updated":"2016-05-17 14:10:22.000000000","message":"Ruby\u0027s comment from PS 39\n\nWhat I was thinking, is that this method could be expanded. So if it is OK to specify the fields, then we could add a check here, something like\nWell, before line 254, check this so we don\u0027t have to worry about it again: if fields is None: return\nThen here:\n    if \u0027network_interface\u0027 in fields and not api_utils.allow_network_interface():\n        raise exception.NotAcceptable()\nHmm. Nothing in this code checks that fields is a list (I\u0027m assuming it is a list?)","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1df083e755478bfb117c4f982d56651185fe0f38","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    \"\"\""},{"line_number":255,"context_line":"    if (fields is not None and pecan.request.version.minor \u003c"},{"line_number":256,"context_line":"            versions.MINOR_8_FETCHING_SUBSET_OF_FIELDS):"},{"line_number":257,"context_line":"        raise exception.NotAcceptable()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"def check_allow_management_verbs(verb):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_ae4a7eaa","line":257,"in_reply_to":"dab17558_1aace68a","updated":"2016-05-24 16:15:24.000000000","message":"Yes, it is a list please have look: https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L1085","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"51d7433f7103b2cfa7b0692052cf83ade98f28f6","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    return (pecan.request.version.minor \u003e\u003d"},{"line_number":330,"context_line":"            versions.MINOR_17_PORTGROUP)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"def allow_network_interface():"},{"line_number":334,"context_line":"    \"\"\"Check if we should support network_interface field."},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_1a6b4686","line":332,"updated":"2016-05-17 14:10:22.000000000","message":"ditto here,  is_valid_network_interface function lost","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1df083e755478bfb117c4f982d56651185fe0f38","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    return (pecan.request.version.minor \u003e\u003d"},{"line_number":330,"context_line":"            versions.MINOR_17_PORTGROUP)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"def allow_network_interface():"},{"line_number":334,"context_line":"    \"\"\"Check if we should support network_interface field."},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_6c5edf77","line":332,"in_reply_to":"dab17558_1a6b4686","updated":"2016-05-24 16:15:24.000000000","message":"Done","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f85e442fd305b9be943efa20b806a5ad9ea18b53","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return utils.is_valid_logical_name(name)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"def is_valid_network_interface(network_interface):"},{"line_number":159,"context_line":"    \"\"\"Determine if the provided network_interface is a valid."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    Check to see that the provided network_interface is in the enabled"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a9d85d2_fd919353","line":158,"updated":"2016-06-21 14:55:06.000000000","message":"Is it OK to do so, or we should do an RPC call or..?","commit_id":"88f4e3b174ef7a87388f14a553983023d9abf2e4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bf12b0a1d9506b25679c160475e53b3d2965abd7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    :param: network_interface: the node network interface to check."},{"line_number":165,"context_line":"    :returns: True if the network_interface is valid, False otherwise."},{"line_number":166,"context_line":"    \"\"\""},{"line_number":167,"context_line":"    return network_interface in CONF.enabled_network_interfaces"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def vendor_passthru(ident, method, topic, data\u003dNone, driver_passthru\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1aa78d24_7a059cc0","line":167,"updated":"2016-07-11 12:13:43.000000000","message":"According to driver composition spec [0] the validation should be performed at the conductor side. The option enabled_network_interfaces should be added under [conductor] group afaik.\n\nhttps://review.openstack.org/#/c/188370/20/specs/approved/driver-composition-reform.rst L198","commit_id":"b1c1014753534f85de2dfab4300130b0a471436d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f1f995b56efda60b8f9b6c91ea97b22294b159cd","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    :param: network_interface: the node network interface to check."},{"line_number":165,"context_line":"    :returns: True if the network_interface is valid, False otherwise."},{"line_number":166,"context_line":"    \"\"\""},{"line_number":167,"context_line":"    return network_interface in CONF.enabled_network_interfaces"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def vendor_passthru(ident, method, topic, data\u003dNone, driver_passthru\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1aa78d24_f4184a86","line":167,"in_reply_to":"1aa78d24_7a059cc0","updated":"2016-07-12 12:36:49.000000000","message":"There is nothing about the conductor section there, and it does not really matter how the section is called, only what service uses it, so I\u0027d keep it in the default section as is the case with drivers right now.\n\nWill add the remote method.","commit_id":"b1c1014753534f85de2dfab4300130b0a471436d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e6b0933acdf1f6837d0dfe739c652e47e9b1157b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    :param: network_interface: the node network interface to check."},{"line_number":165,"context_line":"    :returns: True if the network_interface is valid, False otherwise."},{"line_number":166,"context_line":"    \"\"\""},{"line_number":167,"context_line":"    return network_interface in CONF.enabled_network_interfaces"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def vendor_passthru(ident, method, topic, data\u003dNone, driver_passthru\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1aa78d24_ef64b049","line":167,"in_reply_to":"1aa78d24_80cb4871","updated":"2016-07-13 13:14:47.000000000","message":"Validation should be performed on the conductor side because conductors could be running with different drivers, and the operator needs some re-assurance that it will work because if the configurations are split, either by separate file or by api/conductors being isolated from each other with minimal configurations, then issues are likely to arise.\n\nAdditionally, the examples show such items under the default section for the configuration, so I think moving it is wrong.  Personally, I think what is in revision 19 on this patchset is ideal.\n\nDriver composition example config: \nhttps://review.openstack.org/#/c/188370/20/specs/approved/driver-composition-reform.rst@507","commit_id":"b1c1014753534f85de2dfab4300130b0a471436d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"082f667e710ea98bcdc864716e1e94705160f0fb","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    :param: network_interface: the node network interface to check."},{"line_number":165,"context_line":"    :returns: True if the network_interface is valid, False otherwise."},{"line_number":166,"context_line":"    \"\"\""},{"line_number":167,"context_line":"    return network_interface in CONF.enabled_network_interfaces"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def vendor_passthru(ident, method, topic, data\u003dNone, driver_passthru\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1aa78d24_80cb4871","line":167,"in_reply_to":"1aa78d24_f4184a86","updated":"2016-07-13 09:36:23.000000000","message":"In my understanding section name specifies which services/parts are using this options. When option belongs to DEFAULT group, it means that it may be used by api/conductor as well. That is why I\u0027m thinking to move this option to conductor section. For deployment engineers it will be clear where option should be configured.","commit_id":"b1c1014753534f85de2dfab4300130b0a471436d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85189876eb8c125873673ab7ca7ba263331cf08e","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    if fields is not None:"},{"line_number":240,"context_line":"        if (\u0027network_interface\u0027 in fields and"},{"line_number":241,"context_line":"                not allow_network_interface()):"},{"line_number":242,"context_line":"            raise exception.NotAcceptable()"},{"line_number":243,"context_line":"        if (pecan.request.version.minor \u003c"},{"line_number":244,"context_line":"                versions.MINOR_8_FETCHING_SUBSET_OF_FIELDS):"},{"line_number":245,"context_line":"            raise exception.NotAcceptable()"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_40ae5c30","line":242,"updated":"2016-07-13 21:50:22.000000000","message":"My concern with putting this here, is that check_allow_specify_fields() is called by more than the node. chassis and port also call it. But \u0027network_interface\u0027 doesn\u0027t make sense for chassis or port.","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ff612c4133bedddc0a1b18d1ae3d6ac4fdd00737","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    if fields is not None:"},{"line_number":240,"context_line":"        if (\u0027network_interface\u0027 in fields and"},{"line_number":241,"context_line":"                not allow_network_interface()):"},{"line_number":242,"context_line":"            raise exception.NotAcceptable()"},{"line_number":243,"context_line":"        if (pecan.request.version.minor \u003c"},{"line_number":244,"context_line":"                versions.MINOR_8_FETCHING_SUBSET_OF_FIELDS):"},{"line_number":245,"context_line":"            raise exception.NotAcceptable()"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_2f85e558","line":242,"in_reply_to":"1aa78d24_40ae5c30","updated":"2016-07-14 11:02:48.000000000","message":"Done","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85189876eb8c125873673ab7ca7ba263331cf08e","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"def allow_network_interface():"},{"line_number":331,"context_line":"    \"\"\"Check if we should support network_interface field."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    Version 1.20 of the API added support for network interfaces."},{"line_number":334,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_0039f4f2","line":331,"updated":"2016-07-13 21:50:22.000000000","message":"should mention for a node.","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ff612c4133bedddc0a1b18d1ae3d6ac4fdd00737","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"def allow_network_interface():"},{"line_number":331,"context_line":"    \"\"\"Check if we should support network_interface field."},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    Version 1.20 of the API added support for network interfaces."},{"line_number":334,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_3544191a","line":331,"in_reply_to":"1aa78d24_0039f4f2","updated":"2016-07-14 11:02:48.000000000","message":"Done","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d6d380c9c66c0897b496590b879dd23acafa5dfe","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"def is_valid_network_interface(network_interface):"},{"line_number":257,"context_line":"    \"\"\"Determine if the provided network_interface is a valid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Check to see that the provided network_interface is in the enabled"},{"line_number":260,"context_line":"    network interfaces list."}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_2a681c87","line":257,"updated":"2016-07-14 16:39:19.000000000","message":"s/is a/is/","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d6d380c9c66c0897b496590b879dd23acafa5dfe","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    \"\"\"Determine if the provided network_interface is a valid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Check to see that the provided network_interface is in the enabled"},{"line_number":260,"context_line":"    network interfaces list."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    :param: network_interface: the node network interface to check."},{"line_number":263,"context_line":"    :returns: True if the network_interface is valid, False otherwise."}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_6ae064cd","line":260,"updated":"2016-07-14 16:39:19.000000000","message":"you have a NOTE in node.py, but I think it would be useful to put a similar note here too, that this is temporary and assumes the CONF value is the same for both api \u0026 conductor.","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a40a5761ffcefca91c17c21639f8319a662b97c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    \"\"\"Determine if the provided network_interface is a valid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Check to see that the provided network_interface is in the enabled"},{"line_number":260,"context_line":"    network interfaces list."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    :param: network_interface: the node network interface to check."},{"line_number":263,"context_line":"    :returns: True if the network_interface is valid, False otherwise."}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_a6b8c02b","line":260,"in_reply_to":"1aa78d24_6ae064cd","updated":"2016-07-14 19:22:08.000000000","message":"Done","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f681a124b04c5ce66fbd1663dfe51b409d4fdc34","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# NOTE(vsaienko) The validation is performed on API side, all conductors"},{"line_number":257,"context_line":"# and api should have the same list of enabled_network_interfaces."},{"line_number":258,"context_line":"# TODO(vsaienko) remove it once driver-composition-reform is implemented."},{"line_number":259,"context_line":"def is_valid_network_interface(network_interface):"},{"line_number":260,"context_line":"    \"\"\"Determine if the provided network_interface is valid."},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1aa78d24_8999557c","line":258,"updated":"2016-07-14 20:01:13.000000000","message":"I would have put the NOTE inside the method, but this is fine if others understand.\n\nwrt the TODO. It is probably fine but there is the possibility that this method will still be called, we\u0027d just change the code to check the values from the db instead of the config value. Well, actually, it\u0027d have to be changed because the hardware type needs to be known. Anyway. the TODO indicates that something will be changed :)","commit_id":"4bf0486f263891e9a104ff0bb003168691f22895"}],"ironic/api/controllers/v1/versions.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85189876eb8c125873673ab7ca7ba263331cf08e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# v1.17: Add \u0027adopt\u0027 verb for ADOPTING active nodes."},{"line_number":50,"context_line":"# v1.18: Add port.internal_info."},{"line_number":51,"context_line":"# v1.19: Add port.local_link_connection and port.pxe_enabled."},{"line_number":52,"context_line":"# v1.20: Add network interface attribute to node."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"MINOR_0_JUNO \u003d 0"},{"line_number":55,"context_line":"MINOR_1_INITIAL_VERSION \u003d 1"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_e014a84e","line":52,"updated":"2016-07-13 21:50:22.000000000","message":"maybe \u0027Add node.network_interface\u0027\n\n(similar to v1.3, 1.7, 1.18 above)","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ff612c4133bedddc0a1b18d1ae3d6ac4fdd00737","unresolved":false,"context_lines":[{"line_number":49,"context_line":"# v1.17: Add \u0027adopt\u0027 verb for ADOPTING active nodes."},{"line_number":50,"context_line":"# v1.18: Add port.internal_info."},{"line_number":51,"context_line":"# v1.19: Add port.local_link_connection and port.pxe_enabled."},{"line_number":52,"context_line":"# v1.20: Add network interface attribute to node."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"MINOR_0_JUNO \u003d 0"},{"line_number":55,"context_line":"MINOR_1_INITIAL_VERSION \u003d 1"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_2fd32561","line":52,"in_reply_to":"1aa78d24_e014a84e","updated":"2016-07-14 11:02:48.000000000","message":"Done","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"}],"ironic/common/driver_factory.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d6d380c9c66c0897b496590b879dd23acafa5dfe","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                       \u0027list of network interfaces present on your system may \u0027"},{"line_number":53,"context_line":"                       \u0027be found by enumerating the \u0027"},{"line_number":54,"context_line":"                       \u0027\"ironic.hardware.interfaces.network\" entrypoint.\u0027"},{"line_number":55,"context_line":"                       \u0027Is used on API side to validate new/updated node \u0027"},{"line_number":56,"context_line":"                       \u0027\"network_interface\" value. Should be the same on all \u0027"},{"line_number":57,"context_line":"                       \u0027conductors and APIs.\u0027)),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027default_network_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_8a2950f5","line":55,"updated":"2016-07-14 16:39:19.000000000","message":"Maybe \u0027This value must be the same on all ironic-conductor and ironic-api services, because it is used by ironic-api service to validate a new or updated node\u0027s network_interface value.\u0027","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a40a5761ffcefca91c17c21639f8319a662b97c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                       \u0027list of network interfaces present on your system may \u0027"},{"line_number":53,"context_line":"                       \u0027be found by enumerating the \u0027"},{"line_number":54,"context_line":"                       \u0027\"ironic.hardware.interfaces.network\" entrypoint.\u0027"},{"line_number":55,"context_line":"                       \u0027Is used on API side to validate new/updated node \u0027"},{"line_number":56,"context_line":"                       \u0027\"network_interface\" value. Should be the same on all \u0027"},{"line_number":57,"context_line":"                       \u0027conductors and APIs.\u0027)),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027default_network_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_a3f1d297","line":55,"in_reply_to":"1aa78d24_8a2950f5","updated":"2016-07-14 19:22:08.000000000","message":"Done","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c45c2c733ee1a14d1335f81caf3d800027962c75","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                       \u0027production-oriented network interfaces. A complete \u0027"},{"line_number":52,"context_line":"                       \u0027list of network interfaces present on your system may \u0027"},{"line_number":53,"context_line":"                       \u0027be found by enumerating the \u0027"},{"line_number":54,"context_line":"                       \u0027\"ironic.hardware.interfaces.network\" entrypoint.\u0027"},{"line_number":55,"context_line":"                       \u0027This value must be the same on all ironic-conductor \u0027"},{"line_number":56,"context_line":"                       \u0027and ironic-api services, because it is used by \u0027"},{"line_number":57,"context_line":"                       \u0027ironic-api service to validate a new or updated \u0027"}],"source_content_type":"text/x-python","patch_set":23,"id":"1aa78d24_8cf6835b","line":54,"range":{"start_line":54,"start_character":71,"end_line":54,"end_character":73},"updated":"2016-07-14 20:30:17.000000000","message":"This needs to be followed up, but we need a space after the period.  Otherwise it ends up being \"entrypoint.This\"","commit_id":"4bf0486f263891e9a104ff0bb003168691f22895"}],"ironic/conductor/manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85189876eb8c125873673ab7ca7ba263331cf08e","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"        return ret_dict"},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"    def get_enabled_network_interfaces(self, context):"},{"line_number":1430,"context_line":"        \"\"\"Get the properties of the driver."},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"        :param context: request context."},{"line_number":1433,"context_line":"        :returns: a list containing all the enabled network interfaces\u0027 names."}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_7444f9b6","line":1430,"updated":"2016-07-13 21:50:22.000000000","message":"This should be changed. Was this a copy/paste from somewhere?","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ff612c4133bedddc0a1b18d1ae3d6ac4fdd00737","unresolved":false,"context_lines":[{"line_number":1427,"context_line":"        return ret_dict"},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"    def get_enabled_network_interfaces(self, context):"},{"line_number":1430,"context_line":"        \"\"\"Get the properties of the driver."},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"        :param context: request context."},{"line_number":1433,"context_line":"        :returns: a list containing all the enabled network interfaces\u0027 names."}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_6f440d1b","line":1430,"in_reply_to":"1aa78d24_7444f9b6","updated":"2016-07-14 11:02:48.000000000","message":"Done","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d6d380c9c66c0897b496590b879dd23acafa5dfe","unresolved":false,"context_lines":[{"line_number":1426,"context_line":"                    ret_dict[iface_name][\u0027reason\u0027] \u003d reason"},{"line_number":1427,"context_line":"        return ret_dict"},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"    def get_enabled_network_interfaces(self, context):"},{"line_number":1430,"context_line":"        \"\"\"Get the enabled network_interfaces."},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_6d023e0b","line":1429,"updated":"2016-07-14 16:39:19.000000000","message":"we don\u0027t need this any more?","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a40a5761ffcefca91c17c21639f8319a662b97c","unresolved":false,"context_lines":[{"line_number":1426,"context_line":"                    ret_dict[iface_name][\u0027reason\u0027] \u003d reason"},{"line_number":1427,"context_line":"        return ret_dict"},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"    def get_enabled_network_interfaces(self, context):"},{"line_number":1430,"context_line":"        \"\"\"Get the enabled network_interfaces."},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_a348b2cd","line":1429,"in_reply_to":"1aa78d24_6d023e0b","updated":"2016-07-14 19:22:08.000000000","message":"no it is not needed.","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d6d380c9c66c0897b496590b879dd23acafa5dfe","unresolved":false,"context_lines":[{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"    def get_enabled_network_interfaces(self, context):"},{"line_number":1430,"context_line":"        \"\"\"Get the enabled network_interfaces."},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"        :param context: request context."},{"line_number":1433,"context_line":"        :returns: a list containing all the enabled network interfaces\u0027 names."},{"line_number":1434,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_0d6c5a35","line":1431,"updated":"2016-07-14 16:39:19.000000000","message":"I haven\u0027t totally thought through this new change. Even though the network interface is being checked at the API side; should we also check it on the conductor side, in eg validate(), just in case?","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a40a5761ffcefca91c17c21639f8319a662b97c","unresolved":false,"context_lines":[{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"    def get_enabled_network_interfaces(self, context):"},{"line_number":1430,"context_line":"        \"\"\"Get the enabled network_interfaces."},{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"        :param context: request context."},{"line_number":1433,"context_line":"        :returns: a list containing all the enabled network interfaces\u0027 names."},{"line_number":1434,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_c3969eee","line":1431,"in_reply_to":"1aa78d24_0d6c5a35","updated":"2016-07-14 19:22:08.000000000","message":"There is no need, since if we set network_interface to not valid value, or removed it from conductor, after node was created we will not able to perform any operation with node, since it will be not possible to create TaskManager instance. There is the trace [0], [1]\n\nReference:\n[0] http://paste.openstack.org/show/532762/\n[1] https://github.com/openstack/ironic/blob/master/ironic/conductor/task_manager.py#L220","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d6d380c9c66c0897b496590b879dd23acafa5dfe","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    |    1.32 - Add do_node_clean"},{"line_number":82,"context_line":"    |    1.33 - Added update and destroy portgroup."},{"line_number":83,"context_line":"    |    1.34 - Added heartbeat"},{"line_number":84,"context_line":"    |    1.35 - Added get_enabled_network_interfaces"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_cd07f216","line":84,"updated":"2016-07-14 16:39:19.000000000","message":"we don\u0027t need this any more?","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a40a5761ffcefca91c17c21639f8319a662b97c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    |    1.32 - Add do_node_clean"},{"line_number":82,"context_line":"    |    1.33 - Added update and destroy portgroup."},{"line_number":83,"context_line":"    |    1.34 - Added heartbeat"},{"line_number":84,"context_line":"    |    1.35 - Added get_enabled_network_interfaces"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_e69928d2","line":84,"in_reply_to":"1aa78d24_cd07f216","updated":"2016-07-14 19:22:08.000000000","message":"Done","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d6d380c9c66c0897b496590b879dd23acafa5dfe","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        return cctxt.call(context, \u0027validate_driver_interfaces\u0027,"},{"line_number":376,"context_line":"                          node_id\u003dnode_id)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def get_enabled_network_interfaces(self, context, topic\u003dNone):"},{"line_number":379,"context_line":"        \"\"\"Get the list of network interfaces enabled in the conductor."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_2d3036e8","line":378,"updated":"2016-07-14 16:39:19.000000000","message":"we don\u0027t need this any more?","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9a40a5761ffcefca91c17c21639f8319a662b97c","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        return cctxt.call(context, \u0027validate_driver_interfaces\u0027,"},{"line_number":376,"context_line":"                          node_id\u003dnode_id)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def get_enabled_network_interfaces(self, context, topic\u003dNone):"},{"line_number":379,"context_line":"        \"\"\"Get the list of network interfaces enabled in the conductor."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_e3611a13","line":378,"in_reply_to":"1aa78d24_2d3036e8","updated":"2016-07-14 19:22:08.000000000","message":"right, removed.","commit_id":"caf7550a6bf6baaa8e444db70649470bdc247163"}],"ironic/tests/unit/api/v1/test_nodes.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85189876eb8c125873673ab7ca7ba263331cf08e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.assertIn(\u0027inspection_finished_at\u0027, data)"},{"line_number":136,"context_line":"        self.assertIn(\u0027inspection_started_at\u0027, data)"},{"line_number":137,"context_line":"        self.assertIn(\u0027clean_step\u0027, data)"},{"line_number":138,"context_line":"        self.assertIn(\u0027states\u0027, data)"},{"line_number":139,"context_line":"        # never expose the chassis_id"},{"line_number":140,"context_line":"        self.assertNotIn(\u0027chassis_id\u0027, data)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_94040519","line":138,"updated":"2016-07-13 21:50:22.000000000","message":"should we add self.assertIn(\u0027network_interface\u0027, data) ?","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ff612c4133bedddc0a1b18d1ae3d6ac4fdd00737","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.assertIn(\u0027inspection_finished_at\u0027, data)"},{"line_number":136,"context_line":"        self.assertIn(\u0027inspection_started_at\u0027, data)"},{"line_number":137,"context_line":"        self.assertIn(\u0027clean_step\u0027, data)"},{"line_number":138,"context_line":"        self.assertIn(\u0027states\u0027, data)"},{"line_number":139,"context_line":"        # never expose the chassis_id"},{"line_number":140,"context_line":"        self.assertNotIn(\u0027chassis_id\u0027, data)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_8f5699cc","line":138,"in_reply_to":"1aa78d24_94040519","updated":"2016-07-14 11:02:48.000000000","message":"Done","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85189876eb8c125873673ab7ca7ba263331cf08e","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.assertIn(\u0027inspection_finished_at\u0027, data[\u0027nodes\u0027][0])"},{"line_number":230,"context_line":"        self.assertIn(\u0027inspection_started_at\u0027, data[\u0027nodes\u0027][0])"},{"line_number":231,"context_line":"        self.assertIn(\u0027raid_config\u0027, data[\u0027nodes\u0027][0])"},{"line_number":232,"context_line":"        self.assertIn(\u0027target_raid_config\u0027, data[\u0027nodes\u0027][0])"},{"line_number":233,"context_line":"        # never expose the chassis_id"},{"line_number":234,"context_line":"        self.assertNotIn(\u0027chassis_id\u0027, data[\u0027nodes\u0027][0])"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_7746bb50","line":232,"updated":"2016-07-13 21:50:22.000000000","message":"check that network_interface is here?","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ff612c4133bedddc0a1b18d1ae3d6ac4fdd00737","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.assertIn(\u0027inspection_finished_at\u0027, data[\u0027nodes\u0027][0])"},{"line_number":230,"context_line":"        self.assertIn(\u0027inspection_started_at\u0027, data[\u0027nodes\u0027][0])"},{"line_number":231,"context_line":"        self.assertIn(\u0027raid_config\u0027, data[\u0027nodes\u0027][0])"},{"line_number":232,"context_line":"        self.assertIn(\u0027target_raid_config\u0027, data[\u0027nodes\u0027][0])"},{"line_number":233,"context_line":"        # never expose the chassis_id"},{"line_number":234,"context_line":"        self.assertNotIn(\u0027chassis_id\u0027, data[\u0027nodes\u0027][0])"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_6f29ad37","line":232,"in_reply_to":"1aa78d24_7746bb50","updated":"2016-07-14 11:02:48.000000000","message":"Done","commit_id":"fe0e3e79496d5bc94a097a6dc58e21e1049df0c1"}],"releasenotes/notes/add-network-interface-api-a3a56b8d0c796d88.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"51d7433f7103b2cfa7b0692052cf83ade98f28f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API mothods to work with ``network_interface``"},{"line_number":4,"context_line":"    node object field, that allows to specify network"},{"line_number":5,"context_line":"    driver to use."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dab17558_dad09e21","line":4,"updated":"2016-05-17 14:10:22.000000000","message":"Comment from Ruby on PS 39:\n\nhow about s/that allows to specify network driver to use/that specifies the network driver to use for that node/","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1df083e755478bfb117c4f982d56651185fe0f38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API mothods to work with ``network_interface``"},{"line_number":4,"context_line":"    node object field, that allows to specify network"},{"line_number":5,"context_line":"    driver to use."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_ccda6be9","line":4,"in_reply_to":"dab17558_dad09e21","updated":"2016-05-24 16:15:24.000000000","message":"Done","commit_id":"5ab80d7b2cf6360680e347b462d675078bde3136"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fdc0c200711ef4013d613d1265f00e7175e0966e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API mothods to work with ``network_interface``"},{"line_number":4,"context_line":"    node object field, that specifies the network driver"},{"line_number":5,"context_line":"    to use for that node."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_05b84474","line":3,"updated":"2016-05-26 12:24:55.000000000","message":"methods","commit_id":"07d891d0aa790008d190a228cad61fe4af913b47"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6486d01a99b85dc7c74c2acfc0ff16eb4e5ff3e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API mothods to work with ``network_interface``"},{"line_number":4,"context_line":"    node object field, that specifies the network driver"},{"line_number":5,"context_line":"    to use for that node."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_f195fee3","line":3,"in_reply_to":"bab6814e_05b84474","updated":"2016-05-26 14:58:29.000000000","message":"Done","commit_id":"07d891d0aa790008d190a228cad61fe4af913b47"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"07d66acd28b115cd69461a3f50afb85b79312bb0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API methods to work with ``network_interface``"},{"line_number":4,"context_line":"    node object field, that specifies the network driver"},{"line_number":5,"context_line":"    to use for that node."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_66624bdb","line":5,"updated":"2016-06-16 12:11:14.000000000","message":"Nit: It might be good to list the options in case a user only reads the release notes.","commit_id":"324969ed68d713d60ab3cafdfe3425d5ba9021ef"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"38df9257358b347852574ef91d86e7c7c393ab67","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API methods to work with ``network_interface``"},{"line_number":4,"context_line":"    node object field, that specifies the network driver"},{"line_number":5,"context_line":"    to use for that node."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5a9d85d2_a986b110","line":5,"in_reply_to":"7aa08908_66624bdb","updated":"2016-06-21 14:51:55.000000000","message":"Done","commit_id":"324969ed68d713d60ab3cafdfe3425d5ba9021ef"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4277bc7b75fd0fa54ac9d78684d9944fd826e48d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API methods to work with ``network_interface`` node object field,"},{"line_number":4,"context_line":"    that specifies the network interface to use for that node. Its value"},{"line_number":5,"context_line":"    should be present in the ``[DEFAULT]enabled_network_interfaces`` list"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_ae93e5a1","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2016-07-13 01:45:04.000000000","message":"nit: I\u0027m not sure upgrade is the right section for this since action is not necessary.  This seems more like a feature","commit_id":"b31590ccdca6d29715b15f4b08e0355394e65df6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8886c7206de3b0d9cef0d46b9831e6bf67e7316b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API methods to work with ``network_interface`` node object field,"},{"line_number":4,"context_line":"    that specifies the network interface to use for that node. Its value"},{"line_number":5,"context_line":"    should be present in the ``[DEFAULT]enabled_network_interfaces`` list"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_f1fadc41","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"1aa78d24_ae93e5a1","updated":"2016-07-13 10:45:14.000000000","message":"Done","commit_id":"b31590ccdca6d29715b15f4b08e0355394e65df6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4277bc7b75fd0fa54ac9d78684d9944fd826e48d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API methods to work with ``network_interface`` node object field,"},{"line_number":4,"context_line":"    that specifies the network interface to use for that node. Its value"},{"line_number":5,"context_line":"    should be present in the ``[DEFAULT]enabled_network_interfaces`` list"},{"line_number":6,"context_line":"    option on the conductor."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_6e6f3dc4","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":10},"updated":"2016-07-13 01:45:04.000000000","message":"nit: s/should/must/","commit_id":"b31590ccdca6d29715b15f4b08e0355394e65df6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8886c7206de3b0d9cef0d46b9831e6bf67e7316b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Added API methods to work with ``network_interface`` node object field,"},{"line_number":4,"context_line":"    that specifies the network interface to use for that node. Its value"},{"line_number":5,"context_line":"    should be present in the ``[DEFAULT]enabled_network_interfaces`` list"},{"line_number":6,"context_line":"    option on the conductor."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_d1f52051","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":10},"in_reply_to":"1aa78d24_6e6f3dc4","updated":"2016-07-13 10:45:14.000000000","message":"Done","commit_id":"b31590ccdca6d29715b15f4b08e0355394e65df6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4277bc7b75fd0fa54ac9d78684d9944fd826e48d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added API methods to work with ``network_interface`` node object field,"},{"line_number":4,"context_line":"    that specifies the network interface to use for that node. Its value"},{"line_number":5,"context_line":"    should be present in the ``[DEFAULT]enabled_network_interfaces`` list"},{"line_number":6,"context_line":"    option on the conductor."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_4eeb6113","line":6,"updated":"2016-07-13 01:45:04.000000000","message":"nit: We should specify the API version in which this functionality appears.","commit_id":"b31590ccdca6d29715b15f4b08e0355394e65df6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8886c7206de3b0d9cef0d46b9831e6bf67e7316b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added API methods to work with ``network_interface`` node object field,"},{"line_number":4,"context_line":"    that specifies the network interface to use for that node. Its value"},{"line_number":5,"context_line":"    should be present in the ``[DEFAULT]enabled_network_interfaces`` list"},{"line_number":6,"context_line":"    option on the conductor."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_319744ed","line":6,"in_reply_to":"1aa78d24_4eeb6113","updated":"2016-07-13 10:45:14.000000000","message":"Done","commit_id":"b31590ccdca6d29715b15f4b08e0355394e65df6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c45c2c733ee1a14d1335f81caf3d800027962c75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Bumped API version to 1.20. It adds API methods to work with"},{"line_number":4,"context_line":"    ``network_interface`` node object field, that specifies the network"},{"line_number":5,"context_line":"    interface to use for that node. Its value must be identical and"},{"line_number":6,"context_line":"    present in the ``[DEFAULT]enabled_network_interfaces`` list option"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"1aa78d24_8c29639e","line":3,"range":{"start_line":3,"start_character":32,"end_line":3,"end_character":34},"updated":"2016-07-14 20:30:17.000000000","message":"nit: what is it? When reading the release notes, there is no context into what \"it\" really is. :(","commit_id":"4bf0486f263891e9a104ff0bb003168691f22895"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f681a124b04c5ce66fbd1663dfe51b409d4fdc34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"1aa78d24_4983eda9","line":8,"updated":"2016-07-14 20:01:13.000000000","message":"Deva suggested something for the port.local_link_connection etc. Using that as a template :), how about\n\nExposes the ``network_interface`` field of the Node resource to the REST API, raising the API maximum version to 1.20. This field is the network interface to use for a node. Its possible values are from the configuration option ``[DEFAULT]enabled_network_interfaces``. Note that the value of this option must be the same on all the ironic-conductor and ironic-api service nodes.","commit_id":"4bf0486f263891e9a104ff0bb003168691f22895"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c45c2c733ee1a14d1335f81caf3d800027962c75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"1aa78d24_4c065b22","line":8,"in_reply_to":"1aa78d24_4983eda9","updated":"2016-07-14 20:30:17.000000000","message":"++ and this can be updated in a follow-up \\o/","commit_id":"4bf0486f263891e9a104ff0bb003168691f22895"}]}
