)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add \u0027neutron\u0027 network interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a \u0027neutron\u0027 network interface."},{"line_number":10,"context_line":"The driver allows to provision/clean nodes in separate networks."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-bug: #1526403"},{"line_number":13,"context_line":"Co-Authored-By: Vladyslav Drok \u003cvdrok@mirantis.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1aa78d24_9cb591ee","line":10,"updated":"2016-07-12 21:00:38.000000000","message":"Maybe\n\nThis interface supports separate networks, one for provisioning and another for cleaning of nodes.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add \u0027neutron\u0027 network interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a \u0027neutron\u0027 network interface."},{"line_number":10,"context_line":"The driver allows to provision/clean nodes in separate networks."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-bug: #1526403"},{"line_number":13,"context_line":"Co-Authored-By: Vladyslav Drok \u003cvdrok@mirantis.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1aa78d24_2bdfd50d","line":10,"in_reply_to":"1aa78d24_9cb591ee","updated":"2016-07-13 10:40:42.000000000","message":"Done","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"}],"ironic/common/network.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    for port in task.ports:"},{"line_number":46,"context_line":"        vif \u003d (port.internal_info.get(\u0027cleaning_vif_port_id\u0027) or"},{"line_number":47,"context_line":"               port.internal_info.get(\u0027provisioning_vif_port_id\u0027) or"},{"line_number":48,"context_line":"               port.extra.get(\u0027vif_port_id\u0027))"},{"line_number":49,"context_line":"        if vif:"},{"line_number":50,"context_line":"            port_vifs[port.uuid] \u003d vif"},{"line_number":51,"context_line":"    vifs[\u0027ports\u0027] \u003d port_vifs"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_9c9ab160","line":48,"updated":"2016-07-12 21:00:38.000000000","message":"If we do this a lot, we might want to consider a helper function eg get_curr_vif(port) to get the port\u0027s \u0027current\u0027 VIF. (But in a separate patch.) OR could we add a port.get_current_vif()?","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"}],"ironic/common/neutron.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8afd61b6fea260f2277a117f8b701dce7903f916","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.StrOpt(\u0027provisioning_network_uuid\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":60,"context_line":"                      \u0027into for provisioning nodes. Required for neutron \u0027"},{"line_number":61,"context_line":"                      \u0027network driver.\u0027)),"},{"line_number":62,"context_line":"]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"CONF.register_opts(neutron_opts, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_c422c9a2","line":61,"updated":"2016-06-29 20:34:40.000000000","message":"it is only required for neutron network interface. Ignored by other network interfaces?","commit_id":"91cb5ae8e36a24cd924c23bab56750cd8c9955bc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"abc39054e2190fb76fb5eeccb787cfb9e4bb5884","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.StrOpt(\u0027provisioning_network_uuid\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":60,"context_line":"                      \u0027into for provisioning nodes. Required for neutron \u0027"},{"line_number":61,"context_line":"                      \u0027network driver.\u0027)),"},{"line_number":62,"context_line":"]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"CONF.register_opts(neutron_opts, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_161dc30e","line":61,"in_reply_to":"3aaa91ec_c422c9a2","updated":"2016-07-01 13:10:22.000000000","message":"correct","commit_id":"91cb5ae8e36a24cd924c23bab56750cd8c9955bc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                      \u0027should only be used for testing.\u0027)),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027cleaning_network_uuid\u0027,"},{"line_number":53,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":54,"context_line":"                      \u0027into for cleaning nodes. Required for neutron network \u0027"},{"line_number":55,"context_line":"                      \u0027interface, and, if cleaning (either automatic or \u0027"},{"line_number":56,"context_line":"                      \u0027manual) is run, for flat network interface and \u0027"},{"line_number":57,"context_line":"                      \u0027neutron DHCP provider.\u0027)),"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_3c1f3db8","line":54,"updated":"2016-07-12 21:00:38.000000000","message":"I think it would be useful to put neutron in quotes, eg s/neutron/\"neutron\"/\n\nAlso, maybe s/cleaning/(automatic or manual) cleaning of nodes/","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                      \u0027into for cleaning nodes. Required for neutron network \u0027"},{"line_number":55,"context_line":"                      \u0027interface, and, if cleaning (either automatic or \u0027"},{"line_number":56,"context_line":"                      \u0027manual) is run, for flat network interface and \u0027"},{"line_number":57,"context_line":"                      \u0027neutron DHCP provider.\u0027)),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027provisioning_network_uuid\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":60,"context_line":"                      \u0027into for provisioning nodes. Required for neutron \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_7cbee565","line":57,"updated":"2016-07-12 21:00:38.000000000","message":"Instead of the \u0027and, ...\u0027, maybe:\n\nIt is also required if cleaning nodes when using ``flat`` network interface or neutron DHCP provider.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                      \u0027into for cleaning nodes. Required for neutron network \u0027"},{"line_number":55,"context_line":"                      \u0027interface, and, if cleaning (either automatic or \u0027"},{"line_number":56,"context_line":"                      \u0027manual) is run, for flat network interface and \u0027"},{"line_number":57,"context_line":"                      \u0027neutron DHCP provider.\u0027)),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027provisioning_network_uuid\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":60,"context_line":"                      \u0027into for provisioning nodes. Required for neutron \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_ab4105ab","line":57,"in_reply_to":"1aa78d24_7cbee565","updated":"2016-07-13 10:40:42.000000000","message":"Much better, thanks!","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                      \u0027neutron DHCP provider.\u0027)),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027provisioning_network_uuid\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":60,"context_line":"                      \u0027into for provisioning nodes. Required for neutron \u0027"},{"line_number":61,"context_line":"                      \u0027network interface.\u0027)),"},{"line_number":62,"context_line":"]"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_9cb75184","line":60,"updated":"2016-07-12 21:00:38.000000000","message":"maybe s/neutron/\"neutron\"/","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                      \u0027neutron DHCP provider.\u0027)),"},{"line_number":58,"context_line":"    cfg.StrOpt(\u0027provisioning_network_uuid\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Neutron network UUID for the ramdisk to be booted \u0027"},{"line_number":60,"context_line":"                      \u0027into for provisioning nodes. Required for neutron \u0027"},{"line_number":61,"context_line":"                      \u0027network interface.\u0027)),"},{"line_number":62,"context_line":"]"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_cb19f1d2","line":60,"in_reply_to":"1aa78d24_9cb75184","updated":"2016-07-13 10:40:42.000000000","message":"Done","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"}],"ironic/drivers/modules/network/neutron.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1db29c696cb5b3d74379d29063c9ce881fc63ce4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        # number of Neutron ports will match the number of physical ports."},{"line_number":128,"context_line":"        # Instead, we should probably list ports for this instance in"},{"line_number":129,"context_line":"        # Neutron and update all of those with the appropriate portmap."},{"line_number":130,"context_line":"        ports \u003d objects.Port.list_by_node_id(task.context, node.id)"},{"line_number":131,"context_line":"        if not ports:"},{"line_number":132,"context_line":"            msg \u003d _(\"No public network ports to activate attached to \""},{"line_number":133,"context_line":"                    \"node %s\") % node.uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_9b5893fc","line":130,"updated":"2016-05-18 14:34:05.000000000","message":"Task manager instance already contains list of port for node.","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1176473d2603c1780cb2273750d2788f47e82781","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        # number of Neutron ports will match the number of physical ports."},{"line_number":128,"context_line":"        # Instead, we should probably list ports for this instance in"},{"line_number":129,"context_line":"        # Neutron and update all of those with the appropriate portmap."},{"line_number":130,"context_line":"        ports \u003d objects.Port.list_by_node_id(task.context, node.id)"},{"line_number":131,"context_line":"        if not ports:"},{"line_number":132,"context_line":"            msg \u003d _(\"No public network ports to activate attached to \""},{"line_number":133,"context_line":"                    \"node %s\") % node.uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0631eaec","line":130,"in_reply_to":"bab6814e_9b5893fc","updated":"2016-05-24 16:15:30.000000000","message":"Done","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1db29c696cb5b3d74379d29063c9ce881fc63ce4","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # Neutron and update all of those with the appropriate portmap."},{"line_number":130,"context_line":"        ports \u003d objects.Port.list_by_node_id(task.context, node.id)"},{"line_number":131,"context_line":"        if not ports:"},{"line_number":132,"context_line":"            msg \u003d _(\"No public network ports to activate attached to \""},{"line_number":133,"context_line":"                    \"node %s\") % node.uuid"},{"line_number":134,"context_line":"            LOG.error(msg)"},{"line_number":135,"context_line":"            raise exception.NetworkError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_bbc75744","line":132,"updated":"2016-05-18 14:34:05.000000000","message":"Ironic does not use term \"public\" for ports, IMO better drop this word.","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1176473d2603c1780cb2273750d2788f47e82781","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # Neutron and update all of those with the appropriate portmap."},{"line_number":130,"context_line":"        ports \u003d objects.Port.list_by_node_id(task.context, node.id)"},{"line_number":131,"context_line":"        if not ports:"},{"line_number":132,"context_line":"            msg \u003d _(\"No public network ports to activate attached to \""},{"line_number":133,"context_line":"                    \"node %s\") % node.uuid"},{"line_number":134,"context_line":"            LOG.error(msg)"},{"line_number":135,"context_line":"            raise exception.NetworkError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_6681d64d","line":132,"in_reply_to":"bab6814e_bbc75744","updated":"2016-05-24 16:15:30.000000000","message":"Done","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1db29c696cb5b3d74379d29063c9ce881fc63ce4","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            LOG.error(msg)"},{"line_number":135,"context_line":"            raise exception.NetworkError(msg)"},{"line_number":136,"context_line":"        ports \u003d [p for p in ports if not p.portgroup_id]"},{"line_number":137,"context_line":"        portgroups \u003d objects.Portgroup.list_by_node_id(task.context, node.id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        portmap \u003d neutron.get_node_portmap(task)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_9bd1b3d0","line":137,"updated":"2016-05-18 14:34:05.000000000","message":"There is attribute \"portgroups\" in task manager instance.","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1176473d2603c1780cb2273750d2788f47e82781","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            LOG.error(msg)"},{"line_number":135,"context_line":"            raise exception.NetworkError(msg)"},{"line_number":136,"context_line":"        ports \u003d [p for p in ports if not p.portgroup_id]"},{"line_number":137,"context_line":"        portgroups \u003d objects.Portgroup.list_by_node_id(task.context, node.id)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        portmap \u003d neutron.get_node_portmap(task)"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_26906e95","line":137,"in_reply_to":"bab6814e_9bd1b3d0","updated":"2016-05-24 16:15:30.000000000","message":"Done","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd9827ef7df5a18ca9f2a59bcb179a0bf386dd38","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            if not vif_port_id:"},{"line_number":146,"context_line":"                LOG.warning(_LW(\u0027Node %(node)s port has no vif id in extra: \u0027"},{"line_number":147,"context_line":"                                \u0027%(extra)s\u0027),"},{"line_number":148,"context_line":"                            {\u0027extra\u0027: port_like_obj.extra, \u0027node\u0027: node.uuid})"},{"line_number":149,"context_line":"                continue"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            LOG.debug(\u0027Mapping tenant port %(vif_port_id)s to node \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_b52dec90","line":148,"updated":"2016-05-17 14:11:09.000000000","message":"Ruby\u0027s comment from PS 39\n\nwould it be useful to have the ID or UUID of the questionable port_like_obj? Hmm, and/or if it is a port or a portgroup?","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1176473d2603c1780cb2273750d2788f47e82781","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            if not vif_port_id:"},{"line_number":146,"context_line":"                LOG.warning(_LW(\u0027Node %(node)s port has no vif id in extra: \u0027"},{"line_number":147,"context_line":"                                \u0027%(extra)s\u0027),"},{"line_number":148,"context_line":"                            {\u0027extra\u0027: port_like_obj.extra, \u0027node\u0027: node.uuid})"},{"line_number":149,"context_line":"                continue"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            LOG.debug(\u0027Mapping tenant port %(vif_port_id)s to node \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_86e15a01","line":148,"in_reply_to":"dab17558_b52dec90","updated":"2016-05-24 16:15:30.000000000","message":"Done","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd9827ef7df5a18ca9f2a59bcb179a0bf386dd38","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def unconfigure_tenant_networks(self, task):"},{"line_number":189,"context_line":"        \"\"\"Unconfigure tenant networks for a node."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        Nova takes care of port removal from tenant network, but we should"},{"line_number":192,"context_line":"        remove it ourselves, so that ironic port could not be bound to tenant"},{"line_number":193,"context_line":"        and cleaning network at the same time."},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_b544cc46","line":191,"updated":"2016-05-17 14:11:09.000000000","message":"Ruby\u0027s comment from PS 39\n\nHow about \u0027Even though nova takes care of port removal from tenant network, we remove it here/now to avoid the possibility of the ironic port being bound to the tenant and cleaning networks at the same time.\u0027","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1176473d2603c1780cb2273750d2788f47e82781","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def unconfigure_tenant_networks(self, task):"},{"line_number":189,"context_line":"        \"\"\"Unconfigure tenant networks for a node."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        Nova takes care of port removal from tenant network, but we should"},{"line_number":192,"context_line":"        remove it ourselves, so that ironic port could not be bound to tenant"},{"line_number":193,"context_line":"        and cleaning network at the same time."},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_66871613","line":191,"in_reply_to":"dab17558_b544cc46","updated":"2016-05-24 16:15:30.000000000","message":"Done","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1cda1e2fafebb3296db0f3ef0cf262f667384890","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        LOG.info(_LI(\u0027Unmapping instance ports from node %s\u0027), node.uuid)"},{"line_number":202,"context_line":"        params \u003d {\u0027device_id\u0027: node.instance_uuid or node.uuid}"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        neutron.remove_neutron_ports(params, node.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_a0002867","line":204,"updated":"2016-06-01 10:02:37.000000000","message":"signature has been changed, missed task parameter.","commit_id":"525ab9c23040055518067d370c0402373b222a85"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"825a3a99e28b652ada7ee43e48e9e02c7f81eafe","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        LOG.info(_LI(\u0027Unmapping instance ports from node %s\u0027), node.uuid)"},{"line_number":202,"context_line":"        params \u003d {\u0027device_id\u0027: node.instance_uuid or node.uuid}"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        neutron.remove_neutron_ports(params, node.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_007bf4c1","line":204,"in_reply_to":"9abb7d3a_a0002867","updated":"2016-06-01 10:07:03.000000000","message":"Done","commit_id":"525ab9c23040055518067d370c0402373b222a85"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"cc4096a334769c6b3f7c2aee34384ffeb64daea0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                      {\u0027vif_port_id\u0027: vif_port_id, \u0027node_id\u0027: node.uuid})"},{"line_number":156,"context_line":"            local_link_info \u003d []"},{"line_number":157,"context_line":"            if isinstance(port_like_obj, objects.Portgroup):"},{"line_number":158,"context_line":"                pg_ports \u003d objects.Port.list_by_portgroup_id(task.context,"},{"line_number":159,"context_line":"                                                             port_like_obj.id)"},{"line_number":160,"context_line":"                for port in pg_ports:"},{"line_number":161,"context_line":"                    local_link_info.append(portmap[port.uuid])"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_a5175ba1","line":158,"updated":"2016-06-27 11:02:43.000000000","message":"I think we can remove this DB query and create pg_ports from task.ports.","commit_id":"7a06e92c0076a2d680f050b9edd2f0483e3379e5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"dfdcbda6d2ffa41040598fa5018e2c6bf3aab0f3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":162,"context_line":"            else:"},{"line_number":163,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":164,"context_line":"                #  that it is a port"},{"line_number":165,"context_line":"                local_link_info.append(portmap[port_like_obj.uuid])"},{"line_number":166,"context_line":"            body \u003d {"},{"line_number":167,"context_line":"                \u0027port\u0027: {"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_e0e02afd","line":164,"updated":"2016-06-27 13:03:32.000000000","message":"nit: extra space","commit_id":"7a06e92c0076a2d680f050b9edd2f0483e3379e5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"cac8e692b501ba2e2f7b53832ee78c648d1cb3d7","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                      {\u0027vif_port_id\u0027: vif_port_id, \u0027node_id\u0027: node.uuid})"},{"line_number":156,"context_line":"            local_link_info \u003d []"},{"line_number":157,"context_line":"            if isinstance(port_like_obj, objects.Portgroup):"},{"line_number":158,"context_line":"                pg_ports \u003d objects.Port.list_by_portgroup_id(task.context,"},{"line_number":159,"context_line":"                                                             port_like_obj.id)"},{"line_number":160,"context_line":"                for port in pg_ports:"},{"line_number":161,"context_line":"                    local_link_info.append(portmap[port.uuid])"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_ee9a6d6d","line":158,"updated":"2016-06-29 08:57:50.000000000","message":"This line causes unneeded DB query.\n\n pg_ports \u003d [p for p in task.ports if port_like_obj.id \u003d\u003d p.portgroup_id]","commit_id":"8e5b83e46e875d58593d7f9939473e9569099316"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"72d097e5dd889760acd1779f8f2523eab27669f6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                      {\u0027vif_port_id\u0027: vif_port_id, \u0027node_id\u0027: node.uuid})"},{"line_number":156,"context_line":"            local_link_info \u003d []"},{"line_number":157,"context_line":"            if isinstance(port_like_obj, objects.Portgroup):"},{"line_number":158,"context_line":"                pg_ports \u003d objects.Port.list_by_portgroup_id(task.context,"},{"line_number":159,"context_line":"                                                             port_like_obj.id)"},{"line_number":160,"context_line":"                for port in pg_ports:"},{"line_number":161,"context_line":"                    local_link_info.append(portmap[port.uuid])"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_7cb61efa","line":158,"in_reply_to":"3aaa91ec_ee9a6d6d","updated":"2016-06-29 15:08:00.000000000","message":"Done","commit_id":"8e5b83e46e875d58593d7f9939473e9569099316"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        if failures:"},{"line_number":49,"context_line":"            raise exception.DriverLoadError("},{"line_number":50,"context_line":"                driver\u003dself.__class__.__name__,"},{"line_number":51,"context_line":"                reason\u003d(_(\u0027The following [neutron] group config options have \u0027"},{"line_number":52,"context_line":"                          \u0027incorrect values, they are required for this \u0027"},{"line_number":53,"context_line":"                          \u0027network driver and must be UUIDs: %s\u0027) %"},{"line_number":54,"context_line":"                        \u0027, \u0027.join(failures)))"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_8dbefd62","line":51,"updated":"2016-07-12 21:00:38.000000000","message":"nit s/config/configuration/","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        if failures:"},{"line_number":49,"context_line":"            raise exception.DriverLoadError("},{"line_number":50,"context_line":"                driver\u003dself.__class__.__name__,"},{"line_number":51,"context_line":"                reason\u003d(_(\u0027The following [neutron] group config options have \u0027"},{"line_number":52,"context_line":"                          \u0027incorrect values, they are required for this \u0027"},{"line_number":53,"context_line":"                          \u0027network driver and must be UUIDs: %s\u0027) %"},{"line_number":54,"context_line":"                        \u0027, \u0027.join(failures)))"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_660d94e7","line":51,"in_reply_to":"1aa78d24_8dbefd62","updated":"2016-07-13 10:40:42.000000000","message":"Done","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                driver\u003dself.__class__.__name__,"},{"line_number":51,"context_line":"                reason\u003d(_(\u0027The following [neutron] group config options have \u0027"},{"line_number":52,"context_line":"                          \u0027incorrect values, they are required for this \u0027"},{"line_number":53,"context_line":"                          \u0027network driver and must be UUIDs: %s\u0027) %"},{"line_number":54,"context_line":"                        \u0027, \u0027.join(failures)))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def add_provisioning_network(self, task):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_68529f14","line":53,"updated":"2016-07-12 21:00:38.000000000","message":"This exception will have \u0027Driver neutron? could not be loaded. Reason: \u0027 So I think it should be enough to put\n\n\u0027the following [neutron] group configuration options are incorrect; they must be valid UUIDs.: \u0027","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                driver\u003dself.__class__.__name__,"},{"line_number":51,"context_line":"                reason\u003d(_(\u0027The following [neutron] group config options have \u0027"},{"line_number":52,"context_line":"                          \u0027incorrect values, they are required for this \u0027"},{"line_number":53,"context_line":"                          \u0027network driver and must be UUIDs: %s\u0027) %"},{"line_number":54,"context_line":"                        \u0027, \u0027.join(failures)))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def add_provisioning_network(self, task):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_46105800","line":53,"in_reply_to":"1aa78d24_2bcd2c66","updated":"2016-07-13 10:40:42.000000000","message":"Done","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2536d3346545d1faa750b182df839d1d1b6cbde6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                driver\u003dself.__class__.__name__,"},{"line_number":51,"context_line":"                reason\u003d(_(\u0027The following [neutron] group config options have \u0027"},{"line_number":52,"context_line":"                          \u0027incorrect values, they are required for this \u0027"},{"line_number":53,"context_line":"                          \u0027network driver and must be UUIDs: %s\u0027) %"},{"line_number":54,"context_line":"                        \u0027, \u0027.join(failures)))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def add_provisioning_network(self, task):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_2bcd2c66","line":53,"in_reply_to":"1aa78d24_68529f14","updated":"2016-07-12 23:12:05.000000000","message":"Personally I kind of like the more verbose reason, but that is just me.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        LOG.info(_LI(\u0027Removing provisioning network from node %s\u0027),"},{"line_number":80,"context_line":"                 task.node.uuid)"},{"line_number":81,"context_line":"        neutron.remove_ports_from_network("},{"line_number":82,"context_line":"            task, CONF.neutron.provisioning_network_uuid)"},{"line_number":83,"context_line":"        for port in task.ports:"},{"line_number":84,"context_line":"            if \u0027provisioning_vif_port_id\u0027 in port.internal_info:"},{"line_number":85,"context_line":"                internal_info \u003d port.internal_info"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_68d8df53","line":82,"updated":"2016-07-12 21:00:38.000000000","message":"this is fine for now, but i wonder in the future, if someone is doing an upgrade and/or changes this config value, *after* the provisioning network was added to the node, then restarts the conductor, then this is called, this will be the wrong value.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f44497f3164b72e73dde804fe4a916ba7b58af28","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        LOG.info(_LI(\u0027Removing provisioning network from node %s\u0027),"},{"line_number":80,"context_line":"                 task.node.uuid)"},{"line_number":81,"context_line":"        neutron.remove_ports_from_network("},{"line_number":82,"context_line":"            task, CONF.neutron.provisioning_network_uuid)"},{"line_number":83,"context_line":"        for port in task.ports:"},{"line_number":84,"context_line":"            if \u0027provisioning_vif_port_id\u0027 in port.internal_info:"},{"line_number":85,"context_line":"                internal_info \u003d port.internal_info"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_b9e316a3","line":82,"in_reply_to":"1aa78d24_46de983e","updated":"2016-07-13 12:22:41.000000000","message":"I think it would be one of those \"We hope you really know what your doing!\" things, but those things do happen in data centers, like upgrading the TOR.  Anyway, nothing to block on, just thoughts for later.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2536d3346545d1faa750b182df839d1d1b6cbde6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        LOG.info(_LI(\u0027Removing provisioning network from node %s\u0027),"},{"line_number":80,"context_line":"                 task.node.uuid)"},{"line_number":81,"context_line":"        neutron.remove_ports_from_network("},{"line_number":82,"context_line":"            task, CONF.neutron.provisioning_network_uuid)"},{"line_number":83,"context_line":"        for port in task.ports:"},{"line_number":84,"context_line":"            if \u0027provisioning_vif_port_id\u0027 in port.internal_info:"},{"line_number":85,"context_line":"                internal_info \u003d port.internal_info"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_abbc7cdc","line":82,"in_reply_to":"1aa78d24_68d8df53","updated":"2016-07-12 23:12:05.000000000","message":"I think we likely need to follow-up once the base functionality is landed with code to at least check neutron port configuration and possibly update it if things are horribly wrong.  But agreed, this is totally a later thing.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        LOG.info(_LI(\u0027Removing provisioning network from node %s\u0027),"},{"line_number":80,"context_line":"                 task.node.uuid)"},{"line_number":81,"context_line":"        neutron.remove_ports_from_network("},{"line_number":82,"context_line":"            task, CONF.neutron.provisioning_network_uuid)"},{"line_number":83,"context_line":"        for port in task.ports:"},{"line_number":84,"context_line":"            if \u0027provisioning_vif_port_id\u0027 in port.internal_info:"},{"line_number":85,"context_line":"                internal_info \u003d port.internal_info"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_46de983e","line":82,"in_reply_to":"1aa78d24_abbc7cdc","updated":"2016-07-13 10:40:42.000000000","message":"Umm, upgrade from old way? they will have to not only upgrade, but set neutron network_interface in the node, and I really think it will be their big problem if they do it :D","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"83fb8a79796a2a8de04b3f18868be3a15777a5cb","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        LOG.info(_LI(\u0027Removing provisioning network from node %s\u0027),"},{"line_number":80,"context_line":"                 task.node.uuid)"},{"line_number":81,"context_line":"        neutron.remove_ports_from_network("},{"line_number":82,"context_line":"            task, CONF.neutron.provisioning_network_uuid)"},{"line_number":83,"context_line":"        for port in task.ports:"},{"line_number":84,"context_line":"            if \u0027provisioning_vif_port_id\u0027 in port.internal_info:"},{"line_number":85,"context_line":"                internal_info \u003d port.internal_info"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_ef35d0f6","line":82,"in_reply_to":"1aa78d24_b9e316a3","updated":"2016-07-13 13:10:01.000000000","message":"So maybe mentioning \u0027upgrade\u0027 is a red herring here. What I meant was: if someone changes the value for the config value, between adding and removing the provisioning network, this won\u0027t work. I think we should stash the config value in node.driver_internal_info when adding the network; and then use that value when removing. [But in a future patch.]","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # Neutron and update all of those with the appropriate portmap."},{"line_number":141,"context_line":"        if not ports:"},{"line_number":142,"context_line":"            msg \u003d _(\"No Neutron ports are associated with node: \""},{"line_number":143,"context_line":"                    \"node %s\") % node.uuid"},{"line_number":144,"context_line":"            LOG.error(msg)"},{"line_number":145,"context_line":"            raise exception.NetworkError(msg)"},{"line_number":146,"context_line":"        ports \u003d [p for p in ports if not p.portgroup_id]"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_dc1ef45d","line":143,"updated":"2016-07-12 21:00:38.000000000","message":"is there an extra \u0027node\u0027 here? Looks like \u0027.. associated with node: node \u003cuuid\u003e\u0027.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # Neutron and update all of those with the appropriate portmap."},{"line_number":141,"context_line":"        if not ports:"},{"line_number":142,"context_line":"            msg \u003d _(\"No Neutron ports are associated with node: \""},{"line_number":143,"context_line":"                    \"node %s\") % node.uuid"},{"line_number":144,"context_line":"            LOG.error(msg)"},{"line_number":145,"context_line":"            raise exception.NetworkError(msg)"},{"line_number":146,"context_line":"        ports \u003d [p for p in ports if not p.portgroup_id]"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_e6c6a466","line":143,"in_reply_to":"1aa78d24_6be454ab","updated":"2016-07-13 10:40:42.000000000","message":"Yup!","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2536d3346545d1faa750b182df839d1d1b6cbde6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        # Neutron and update all of those with the appropriate portmap."},{"line_number":141,"context_line":"        if not ports:"},{"line_number":142,"context_line":"            msg \u003d _(\"No Neutron ports are associated with node: \""},{"line_number":143,"context_line":"                    \"node %s\") % node.uuid"},{"line_number":144,"context_line":"            LOG.error(msg)"},{"line_number":145,"context_line":"            raise exception.NetworkError(msg)"},{"line_number":146,"context_line":"        ports \u003d [p for p in ports if not p.portgroup_id]"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_6be454ab","line":143,"in_reply_to":"1aa78d24_dc1ef45d","updated":"2016-07-12 23:12:05.000000000","message":"That it does appear to be.\n\nAdditionally, wouldn\u0027t these ports be ports belonging to the node, not ports in neutron?","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                    _LW(\u0027Node %(node)s %(port_like_object)s has no \u0027"},{"line_number":158,"context_line":"                        \u0027vif id in extra: %(extra)s\u0027),"},{"line_number":159,"context_line":"                    {\u0027port_like_object\u0027: port_like_obj.__class__.__name__,"},{"line_number":160,"context_line":"                     \u0027extra\u0027: port_like_obj.extra, \u0027node\u0027: node.uuid})"},{"line_number":161,"context_line":"                continue"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            LOG.debug(\u0027Mapping tenant port %(vif_port_id)s to node \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_fcc77042","line":160,"updated":"2016-07-12 21:00:38.000000000","message":"If I read this correctly, I wonder if we can make it more useful. I think it\u0027ll look like\n\nNode \u003cuuid\u003e port-or-portgroup has no vif id in extra: {extra stuff}.\n\nWould the port or portgroup uuid be useful too?\n\nMaybe something like\n\nport-or-portgroup \u003cuuid\u003e in node \u003cuuid\u003e has no VIF ID in extra: \u003cextra stuff\u003e.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                    _LW(\u0027Node %(node)s %(port_like_object)s has no \u0027"},{"line_number":158,"context_line":"                        \u0027vif id in extra: %(extra)s\u0027),"},{"line_number":159,"context_line":"                    {\u0027port_like_object\u0027: port_like_obj.__class__.__name__,"},{"line_number":160,"context_line":"                     \u0027extra\u0027: port_like_obj.extra, \u0027node\u0027: node.uuid})"},{"line_number":161,"context_line":"                continue"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            LOG.debug(\u0027Mapping tenant port %(vif_port_id)s to node \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_a6a5bca2","line":160,"in_reply_to":"1aa78d24_468a2f65","updated":"2016-07-13 10:40:42.000000000","message":"There will be additional vars to accumulate uuids and type, I\u0027d just fix the message :)","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2536d3346545d1faa750b182df839d1d1b6cbde6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                    _LW(\u0027Node %(node)s %(port_like_object)s has no \u0027"},{"line_number":158,"context_line":"                        \u0027vif id in extra: %(extra)s\u0027),"},{"line_number":159,"context_line":"                    {\u0027port_like_object\u0027: port_like_obj.__class__.__name__,"},{"line_number":160,"context_line":"                     \u0027extra\u0027: port_like_obj.extra, \u0027node\u0027: node.uuid})"},{"line_number":161,"context_line":"                continue"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"            LOG.debug(\u0027Mapping tenant port %(vif_port_id)s to node \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_468a2f65","line":160,"in_reply_to":"1aa78d24_fcc77042","updated":"2016-07-12 23:12:05.000000000","message":"I think it should explicitly state the key name of vif_port_id to allow someone to understand exactly what is missing.  It also seems slightly un-necessary to list the contents of extra when we\u0027re just missing a vif in extra.  Besides, this is in a loop enumerating through all ports and portgroups, what if there is only a single vif assigned and 6 ethernet ports?  On second thought, maybe a further improvement, generate a list of ports that are lacking vifs and log it once.\n\nPerhaps:\n\nNode \u003cuuid\u003e port or portgroup \u003cport_like_object\u003e is missing the vif_port_id value in extra field.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                pg_ports \u003d [p for p in task.ports"},{"line_number":169,"context_line":"                            if p.portgroup_id \u003d\u003d port_like_obj.id]"},{"line_number":170,"context_line":"                for port in pg_ports:"},{"line_number":171,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_7c1d4072","line":171,"updated":"2016-07-12 21:00:38.000000000","message":"maybe a dumb question, but do we need portmap? Isn\u0027t this just\n\ns/portmap[port.uuid]/port.local_link_connection/","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                pg_ports \u003d [p for p in task.ports"},{"line_number":169,"context_line":"                            if p.portgroup_id \u003d\u003d port_like_obj.id]"},{"line_number":170,"context_line":"                for port in pg_ports:"},{"line_number":171,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_c68c48d9","line":171,"in_reply_to":"1aa78d24_2698c377","updated":"2016-07-13 10:40:42.000000000","message":"Yes we can, but it\u0027s what the get_node_portmap function does, and it might be we add some new logic there so that not change it everywhere (it\u0027s used in multiple places)? dunno really whether change it or not.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2536d3346545d1faa750b182df839d1d1b6cbde6","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                pg_ports \u003d [p for p in task.ports"},{"line_number":169,"context_line":"                            if p.portgroup_id \u003d\u003d port_like_obj.id]"},{"line_number":170,"context_line":"                for port in pg_ports:"},{"line_number":171,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_2698c377","line":171,"in_reply_to":"1aa78d24_7c1d4072","updated":"2016-07-12 23:12:05.000000000","message":"Good question, I don\u0027t think we do..","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"83fb8a79796a2a8de04b3f18868be3a15777a5cb","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                pg_ports \u003d [p for p in task.ports"},{"line_number":169,"context_line":"                            if p.portgroup_id \u003d\u003d port_like_obj.id]"},{"line_number":170,"context_line":"                for port in pg_ports:"},{"line_number":171,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_8a151a41","line":171,"in_reply_to":"1aa78d24_c68c48d9","updated":"2016-07-13 13:10:01.000000000","message":"I didn\u0027t have time to look at what uses get_node_portmap (I was thinking maybe it wasn\u0027t needed). It is OK to leave this here for now.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"},{"line_number":175,"context_line":"                local_link_info.append(portmap[port_like_obj.uuid])"},{"line_number":176,"context_line":"            body \u003d {"},{"line_number":177,"context_line":"                \u0027port\u0027: {"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_fc23f002","line":174,"updated":"2016-07-12 21:00:38.000000000","message":"I\u0027m not sure this comment is correct. Isn\u0027t this just a port? No iterating or portgroups here.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"},{"line_number":175,"context_line":"                local_link_info.append(portmap[port_like_obj.uuid])"},{"line_number":176,"context_line":"            body \u003d {"},{"line_number":177,"context_line":"                \u0027port\u0027: {"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_46ffb865","line":174,"in_reply_to":"1aa78d24_461a2fc7","updated":"2016-07-13 10:40:42.000000000","message":"Not sure what is incorrect here - it\u0027s either port or portgroup, so no need to check the type here, just \u0027else\u0027 is enough, no elif isinstance ...","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"83fb8a79796a2a8de04b3f18868be3a15777a5cb","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"},{"line_number":175,"context_line":"                local_link_info.append(portmap[port_like_obj.uuid])"},{"line_number":176,"context_line":"            body \u003d {"},{"line_number":177,"context_line":"                \u0027port\u0027: {"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_ca49e261","line":174,"in_reply_to":"1aa78d24_46ffb865","updated":"2016-07-13 13:10:01.000000000","message":"NO, it isn\u0027t a portgroup. At this point, we know this is a port. Which is why the comment doesn\u0027t make sense. There is no iteration going on here, you\u0027re just appending port.local_link_info (from the portmap).","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2e3fe7e35fd6bf155545cafdeb86cc5927a09809","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"},{"line_number":175,"context_line":"                local_link_info.append(portmap[port_like_obj.uuid])"},{"line_number":176,"context_line":"            body \u003d {"},{"line_number":177,"context_line":"                \u0027port\u0027: {"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_0ca6650e","line":174,"in_reply_to":"1aa78d24_ca49e261","updated":"2016-07-13 13:35:02.000000000","message":"Gotcha, will fix in the followup.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2536d3346545d1faa750b182df839d1d1b6cbde6","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                    local_link_info.append(portmap[port.uuid])"},{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"},{"line_number":175,"context_line":"                local_link_info.append(portmap[port_like_obj.uuid])"},{"line_number":176,"context_line":"            body \u003d {"},{"line_number":177,"context_line":"                \u0027port\u0027: {"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_461a2fc7","line":174,"in_reply_to":"1aa78d24_fc23f002","updated":"2016-07-12 23:12:05.000000000","message":"Well, line 152, but it does look like the comment is wrong.  Maybe it was meant since \"We only iterate further on portgroups, so no need to check that it is a port\"","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"},{"line_number":175,"context_line":"                local_link_info.append(portmap[port_like_obj.uuid])"},{"line_number":176,"context_line":"            body \u003d {"},{"line_number":177,"context_line":"                \u0027port\u0027: {"},{"line_number":178,"context_line":"                    \u0027device_owner\u0027: \u0027baremetal:none\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_9f01fe07","line":175,"updated":"2016-07-12 21:00:38.000000000","message":"same question about needing portmap. Is this the same as\n\ns/portmap[port_like_obj.uuid]/port_like_obj.local_link_connection/","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            else:"},{"line_number":173,"context_line":"                # We iterate only on ports or portgroups, no need to check"},{"line_number":174,"context_line":"                # that it is a port"},{"line_number":175,"context_line":"                local_link_info.append(portmap[port_like_obj.uuid])"},{"line_number":176,"context_line":"            body \u003d {"},{"line_number":177,"context_line":"                \u0027port\u0027: {"},{"line_number":178,"context_line":"                    \u0027device_owner\u0027: \u0027baremetal:none\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_916f1891","line":175,"in_reply_to":"1aa78d24_9f01fe07","updated":"2016-07-13 10:40:42.000000000","message":"ditto, I\u0027ll leave it for now, please comment if you think it should be removed.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d023679d307e500da8278c8396abd4b522771af4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        :returns: a dictionary in the form {port.uuid: neutron_port[\u0027id\u0027]}"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        # If we have left over ports from a previous cleaning, remove them"},{"line_number":97,"context_line":"        neutron.rollback_ports(task, CONF.neutron.cleaning_network_uuid)"},{"line_number":98,"context_line":"        LOG.info(_LI(\u0027Adding cleaning network to node %s\u0027), task.node.uuid)"},{"line_number":99,"context_line":"        vifs \u003d neutron.add_ports_to_network(task,"},{"line_number":100,"context_line":"                                            CONF.neutron.cleaning_network_uuid)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_d84b7385","line":97,"updated":"2016-07-13 14:48:02.000000000","message":"Why we do rollback_ports() only for cleaning network? Work with provisioning network is the case like this.","commit_id":"ab97fa0f1f9ed6acb78c1ceadec8b333eac73254"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"38fc3307b9317bb8a09ae92f190586223da1411d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        :returns: a dictionary in the form {port.uuid: neutron_port[\u0027id\u0027]}"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        # If we have left over ports from a previous cleaning, remove them"},{"line_number":97,"context_line":"        neutron.rollback_ports(task, CONF.neutron.cleaning_network_uuid)"},{"line_number":98,"context_line":"        LOG.info(_LI(\u0027Adding cleaning network to node %s\u0027), task.node.uuid)"},{"line_number":99,"context_line":"        vifs \u003d neutron.add_ports_to_network(task,"},{"line_number":100,"context_line":"                                            CONF.neutron.cleaning_network_uuid)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_7a0185af","line":97,"in_reply_to":"1aa78d24_d84b7385","updated":"2016-07-13 19:00:47.000000000","message":"I would think it is because that cleaning could be retried and re-entered.  I feel like we need a method that sanity checks and then corrects any neutron ports attached to machines, but I think that is a next week thing in my mind.  In any event, Ruby and I both believe the rollback is purely for the case that cleaning may need to be retried.","commit_id":"ab97fa0f1f9ed6acb78c1ceadec8b333eac73254"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a33d62d2d099fef87311f604c8c67b4f4731a565","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            if not vif_port_id:"},{"line_number":154,"context_line":"                LOG.warning("},{"line_number":155,"context_line":"                    _LW(\u0027%(port_like_object)s %(pobj_uuid)s in node %(node)s \u0027"},{"line_number":156,"context_line":"                        \u0027has no vif_port_id value in extra field.\u0027),"},{"line_number":157,"context_line":"                    {\u0027port_like_object\u0027: port_like_obj.__class__.__name__,"},{"line_number":158,"context_line":"                     \u0027pobj_uuid\u0027: port_like_obj.uuid, \u0027node\u0027: node.uuid})"},{"line_number":159,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_4fcfc428","line":156,"updated":"2016-07-13 13:10:55.000000000","message":"nits: \ns/vif_port_id/\"vif_port_id\"/\n\ns/extra/\"extra\"/\n\nOr I suppose we could do port.extra[\u0027vif_port_id\u0027] does not exist for port .. in node ...\n\nBut this is good for now :) Someone can update it later if they want.","commit_id":"ab97fa0f1f9ed6acb78c1ceadec8b333eac73254"}],"ironic/tests/unit/common/test_network.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                    \u0027ports\u0027: {port.uuid: \u0027test-vif-A\u0027}}"},{"line_number":120,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":121,"context_line":"            result \u003d network.get_node_vif_ids(task)"},{"line_number":122,"context_line":"        self.assertEqual(expected, result)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_fc0e5539","line":122,"updated":"2016-07-12 21:00:38.000000000","message":"just a note that you could put in a helper function with parameter internal_info_key string. That seems to be the only difference between the above two tests.\n\nBut this is OK :)","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                    \u0027ports\u0027: {port.uuid: \u0027test-vif-A\u0027}}"},{"line_number":120,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":121,"context_line":"            result \u003d network.get_node_vif_ids(task)"},{"line_number":122,"context_line":"        self.assertEqual(expected, result)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_e6b7c437","line":122,"in_reply_to":"1aa78d24_fc0e5539","updated":"2016-07-13 10:40:42.000000000","message":"Done","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"}],"ironic/tests/unit/drivers/modules/network/test_neutron.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_init_incorrect_provisioning_net(self):"},{"line_number":48,"context_line":"        self.config(provisioning_network_uuid\u003dNone, group\u003d\u0027neutron\u0027)"},{"line_number":49,"context_line":"        self.assertRaises(exception.DriverLoadError,"},{"line_number":50,"context_line":"                          neutron.NeutronNetwork)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @mock.patch.object(neutron_common, \u0027add_ports_to_network\u0027)"},{"line_number":53,"context_line":"    def test_add_provisioning_network(self, add_ports_mock):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_1fc7ce96","line":50,"updated":"2016-07-12 21:00:38.000000000","message":"I didn\u0027t try this out but I am wondering, did it assert because of the provisioning_network_uuid or because of the cleaning_network_uuid config option? They\u0027re both set to empty, right?","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2536d3346545d1faa750b182df839d1d1b6cbde6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_init_incorrect_provisioning_net(self):"},{"line_number":48,"context_line":"        self.config(provisioning_network_uuid\u003dNone, group\u003d\u0027neutron\u0027)"},{"line_number":49,"context_line":"        self.assertRaises(exception.DriverLoadError,"},{"line_number":50,"context_line":"                          neutron.NeutronNetwork)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @mock.patch.object(neutron_common, \u0027add_ports_to_network\u0027)"},{"line_number":53,"context_line":"    def test_add_provisioning_network(self, add_ports_mock):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_213d4dc4","line":50,"in_reply_to":"1aa78d24_1fc7ce96","updated":"2016-07-12 23:12:05.000000000","message":"Good catch.  I think we ought to be testing for both conditions.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_init_incorrect_provisioning_net(self):"},{"line_number":48,"context_line":"        self.config(provisioning_network_uuid\u003dNone, group\u003d\u0027neutron\u0027)"},{"line_number":49,"context_line":"        self.assertRaises(exception.DriverLoadError,"},{"line_number":50,"context_line":"                          neutron.NeutronNetwork)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @mock.patch.object(neutron_common, \u0027add_ports_to_network\u0027)"},{"line_number":53,"context_line":"    def test_add_provisioning_network(self, add_ports_mock):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_2b97d5ec","line":50,"in_reply_to":"1aa78d24_213d4dc4","updated":"2016-07-13 10:40:42.000000000","message":"No, they are both set in the base test class, as neutron is added to enabled_network_interfaces. I\u0027ll add another test for second option.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @mock.patch.object(neutron_common, \u0027remove_ports_from_network\u0027)"},{"line_number":64,"context_line":"    def test_remove_provisioning_network(self, remove_ports_mock):"},{"line_number":65,"context_line":"        self.port.internal_info \u003d {\u0027provisioning_vif_port_id\u0027: \u0027vif-port-id\u0027}"},{"line_number":66,"context_line":"        with task_manager.acquire(self.context, self.node.id) as task:"},{"line_number":67,"context_line":"            self.interface.remove_provisioning_network(task)"},{"line_number":68,"context_line":"            remove_ports_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_ff512263","line":65,"updated":"2016-07-12 21:00:38.000000000","message":"You\u0027ll have to do self.port.save(), otherwise this won\u0027t actually stick.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @mock.patch.object(neutron_common, \u0027remove_ports_from_network\u0027)"},{"line_number":64,"context_line":"    def test_remove_provisioning_network(self, remove_ports_mock):"},{"line_number":65,"context_line":"        self.port.internal_info \u003d {\u0027provisioning_vif_port_id\u0027: \u0027vif-port-id\u0027}"},{"line_number":66,"context_line":"        with task_manager.acquire(self.context, self.node.id) as task:"},{"line_number":67,"context_line":"            self.interface.remove_provisioning_network(task)"},{"line_number":68,"context_line":"            remove_ports_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_6b427d69","line":65,"in_reply_to":"1aa78d24_ff512263","updated":"2016-07-13 10:40:42.000000000","message":"Good catch!","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @mock.patch.object(neutron_common, \u0027remove_ports_from_network\u0027)"},{"line_number":87,"context_line":"    def test_remove_cleaning_network(self, remove_ports_mock):"},{"line_number":88,"context_line":"        self.port.internal_info \u003d {\u0027cleaning_vif_port_id\u0027: \u0027vif-port-id\u0027}"},{"line_number":89,"context_line":"        with task_manager.acquire(self.context, self.node.id) as task:"},{"line_number":90,"context_line":"            self.interface.remove_cleaning_network(task)"},{"line_number":91,"context_line":"            remove_ports_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_df6b86ef","line":88,"updated":"2016-07-12 21:00:38.000000000","message":"ditto about self.port.save()","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @mock.patch.object(neutron_common, \u0027remove_ports_from_network\u0027)"},{"line_number":87,"context_line":"    def test_remove_cleaning_network(self, remove_ports_mock):"},{"line_number":88,"context_line":"        self.port.internal_info \u003d {\u0027cleaning_vif_port_id\u0027: \u0027vif-port-id\u0027}"},{"line_number":89,"context_line":"        with task_manager.acquire(self.context, self.node.id) as task:"},{"line_number":90,"context_line":"            self.interface.remove_cleaning_network(task)"},{"line_number":91,"context_line":"            remove_ports_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_eb2dcda8","line":88,"in_reply_to":"1aa78d24_df6b86ef","updated":"2016-07-13 10:40:42.000000000","message":"Done","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a33d62d2d099fef87311f604c8c67b4f4731a565","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_init_incorrect_provisioning_net(self):"},{"line_number":48,"context_line":"        self.config(provisioning_network_uuid\u003dNone, group\u003d\u0027neutron\u0027)"},{"line_number":49,"context_line":"        self.assertRaises(exception.DriverLoadError, neutron.NeutronNetwork)"},{"line_number":50,"context_line":"        self.config(provisioning_network_uuid\u003duuidutils.generate_uuid(),"},{"line_number":51,"context_line":"                    group\u003d\u0027neutron\u0027)"},{"line_number":52,"context_line":"        self.config(cleaning_network_uuid\u003d\u0027asdf\u0027, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_0a912a47","line":49,"updated":"2016-07-13 13:10:55.000000000","message":"So my comment here from previous revision relates to the provisioning_network_uuid above being set to None. What is the cleaning_network_uuid set to? If it is empty, then this exception is raised cuz of both bad configs. The way it is written, it looks like it is only because of provisioning_network_uuid.\n\nYou could also use the .assertRaisesRegex() to verify which configs were the culprits.","commit_id":"ab97fa0f1f9ed6acb78c1ceadec8b333eac73254"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2a3b9ca4c3f3738622be28dc1419ef1b7487e7c0","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_init_incorrect_provisioning_net(self):"},{"line_number":48,"context_line":"        self.config(provisioning_network_uuid\u003dNone, group\u003d\u0027neutron\u0027)"},{"line_number":49,"context_line":"        self.assertRaises(exception.DriverLoadError, neutron.NeutronNetwork)"},{"line_number":50,"context_line":"        self.config(provisioning_network_uuid\u003duuidutils.generate_uuid(),"},{"line_number":51,"context_line":"                    group\u003d\u0027neutron\u0027)"},{"line_number":52,"context_line":"        self.config(cleaning_network_uuid\u003d\u0027asdf\u0027, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_69271bca","line":49,"in_reply_to":"1aa78d24_0a912a47","updated":"2016-07-13 13:32:52.000000000","message":"They both are set here - https://review.openstack.org/#/c/317393/18/ironic/tests/base.py@122, will change to regexp in the followup","commit_id":"ab97fa0f1f9ed6acb78c1ceadec8b333eac73254"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52dff9d60d587a6be778e1770831025cae0c98d5","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_init_incorrect_provisioning_net(self):"},{"line_number":48,"context_line":"        self.config(provisioning_network_uuid\u003dNone, group\u003d\u0027neutron\u0027)"},{"line_number":49,"context_line":"        self.assertRaises(exception.DriverLoadError, neutron.NeutronNetwork)"},{"line_number":50,"context_line":"        self.config(provisioning_network_uuid\u003duuidutils.generate_uuid(),"},{"line_number":51,"context_line":"                    group\u003d\u0027neutron\u0027)"},{"line_number":52,"context_line":"        self.config(cleaning_network_uuid\u003d\u0027asdf\u0027, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_83fce0b5","line":49,"in_reply_to":"1aa78d24_69271bca","updated":"2016-07-13 14:51:29.000000000","message":"Oh, sorry about that. My bad.","commit_id":"ab97fa0f1f9ed6acb78c1ceadec8b333eac73254"}],"releasenotes/notes/add-neutron-network-driver-aa9e7e65011ab8cd.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd9827ef7df5a18ca9f2a59bcb179a0bf386dd38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``neutron`` network driver implementation. The"},{"line_number":4,"context_line":"    driver allows to provision/clean node is separate"},{"line_number":5,"context_line":"    networks."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dab17558_5a2dcefc","line":4,"updated":"2016-05-17 14:11:09.000000000","message":"You need to mention here in upgrades section that provisioning_net_uuid is required for the neutron net driver.","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1176473d2603c1780cb2273750d2788f47e82781","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``neutron`` network driver implementation. The"},{"line_number":4,"context_line":"    driver allows to provision/clean node is separate"},{"line_number":5,"context_line":"    networks."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_41e11cd0","line":4,"in_reply_to":"dab17558_5a2dcefc","updated":"2016-05-24 16:15:30.000000000","message":"Done","commit_id":"053bb2d2185786eda0bc60bfafd5c5e98b817f21"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8afd61b6fea260f2277a117f8b701dce7903f916","unresolved":false,"context_lines":[{"line_number":7,"context_line":"upgrades:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    ``[neutron]provisioning_network_uuid`` config option is required"},{"line_number":10,"context_line":"    for ``neutron`` network driver, if it is missed conductor will"},{"line_number":11,"context_line":"    fail to start."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3aaa91ec_8950dc33","line":10,"updated":"2016-06-29 20:34:40.000000000","message":"s/missed/not specified/","commit_id":"91cb5ae8e36a24cd924c23bab56750cd8c9955bc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"abc39054e2190fb76fb5eeccb787cfb9e4bb5884","unresolved":false,"context_lines":[{"line_number":7,"context_line":"upgrades:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    ``[neutron]provisioning_network_uuid`` config option is required"},{"line_number":10,"context_line":"    for ``neutron`` network driver, if it is missed conductor will"},{"line_number":11,"context_line":"    fail to start."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3aaa91ec_36743f66","line":10,"in_reply_to":"3aaa91ec_8950dc33","updated":"2016-07-01 13:10:22.000000000","message":"Done","commit_id":"91cb5ae8e36a24cd924c23bab56750cd8c9955bc"}],"releasenotes/notes/add-neutron-network-interface-aa9e7e65011ab8cd.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c6cc1b468173b1baaf69bfc51783079f5b883e17","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``[neutron]cleaning_network_uuid`` config options are required for"},{"line_number":11,"context_line":"    ``neutron`` network interface, if this interface is in the"},{"line_number":12,"context_line":"    ``[DEFAULT]enabled_network_interfaces`` and the options are not specified,"},{"line_number":13,"context_line":"    conductor will fail to start."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_bc0dede9","line":13,"updated":"2016-07-12 21:00:38.000000000","message":"maybe (if you do another revision)\n\nIf ``neutron`` network interface is specified in [DEFAULT]enabled_network_interfaces, [neutron]provisioning_network_uuid \u0026 cleaning_uuid configuration options are required. If both are not specified, the ironic-conductor service will fail to start.","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e100656d571944d9ac471d0f8a000bb5de774587","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``[neutron]cleaning_network_uuid`` config options are required for"},{"line_number":11,"context_line":"    ``neutron`` network interface, if this interface is in the"},{"line_number":12,"context_line":"    ``[DEFAULT]enabled_network_interfaces`` and the options are not specified,"},{"line_number":13,"context_line":"    conductor will fail to start."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_4bd221d2","line":13,"in_reply_to":"1aa78d24_6692cbf7","updated":"2016-07-13 10:40:42.000000000","message":"Done","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2536d3346545d1faa750b182df839d1d1b6cbde6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``[neutron]cleaning_network_uuid`` config options are required for"},{"line_number":11,"context_line":"    ``neutron`` network interface, if this interface is in the"},{"line_number":12,"context_line":"    ``[DEFAULT]enabled_network_interfaces`` and the options are not specified,"},{"line_number":13,"context_line":"    conductor will fail to start."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_6692cbf7","line":13,"in_reply_to":"1aa78d24_bc0dede9","updated":"2016-07-12 23:12:05.000000000","message":"+1","commit_id":"d35f7bef9e7cee36309b929220c85df9dd55c0e7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0d4155aef52af999e4551067ce1946f50b7ac36d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    If ``neutron`` network interface is specified in"},{"line_number":10,"context_line":"    ``[DEFAULT]enabled_network_interfaces``,"},{"line_number":11,"context_line":"    ``[neutron]provisioning_network_uuid`` and"},{"line_number":12,"context_line":"    ``[neutron]cleaning_network_uuid`` configuration options are required. If"},{"line_number":13,"context_line":"    any of them is not specified, the ironic-conductor service will fail to"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1aa78d24_9928da98","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":44},"updated":"2016-07-13 12:31:39.000000000","message":"s/,/, then the/","commit_id":"ab97fa0f1f9ed6acb78c1ceadec8b333eac73254"}],"setup.cfg":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8afd61b6fea260f2277a117f8b701dce7903f916","unresolved":false,"context_lines":[{"line_number":90,"context_line":"ironic.hardware.interfaces.network \u003d"},{"line_number":91,"context_line":"    flat \u003d ironic.drivers.modules.network.flat:FlatNetwork"},{"line_number":92,"context_line":"    none \u003d ironic.drivers.modules.network.none:NoneNetwork"},{"line_number":93,"context_line":"    neutron \u003d ironic.drivers.modules.network.neutron:NeutronV2Network"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"ironic.database.migration_backend \u003d"},{"line_number":96,"context_line":"    sqlalchemy \u003d ironic.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"3aaa91ec_a964b821","line":93,"updated":"2016-06-29 20:34:40.000000000","message":"do we think there might be a v3? If so, maybe \u0027neutronv2\u0027 for this? Or maybe not worry about it until there is a v3...","commit_id":"91cb5ae8e36a24cd924c23bab56750cd8c9955bc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"abc39054e2190fb76fb5eeccb787cfb9e4bb5884","unresolved":false,"context_lines":[{"line_number":90,"context_line":"ironic.hardware.interfaces.network \u003d"},{"line_number":91,"context_line":"    flat \u003d ironic.drivers.modules.network.flat:FlatNetwork"},{"line_number":92,"context_line":"    none \u003d ironic.drivers.modules.network.none:NoneNetwork"},{"line_number":93,"context_line":"    neutron \u003d ironic.drivers.modules.network.neutron:NeutronV2Network"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"ironic.database.migration_backend \u003d"},{"line_number":96,"context_line":"    sqlalchemy \u003d ironic.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"3aaa91ec_b65f8fe3","line":93,"in_reply_to":"3aaa91ec_a964b821","updated":"2016-07-01 13:10:22.000000000","message":"dunno, I\u0027ll let others to take a look at this, does not seem to me like it will be v3 in any near future.","commit_id":"91cb5ae8e36a24cd924c23bab56750cd8c9955bc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"898e15a8582ac9508bb77372e626459d80b44787","unresolved":false,"context_lines":[{"line_number":90,"context_line":"ironic.hardware.interfaces.network \u003d"},{"line_number":91,"context_line":"    flat \u003d ironic.drivers.modules.network.flat:FlatNetwork"},{"line_number":92,"context_line":"    none \u003d ironic.drivers.modules.network.none:NoneNetwork"},{"line_number":93,"context_line":"    neutron \u003d ironic.drivers.modules.network.neutron:NeutronV2Network"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"ironic.database.migration_backend \u003d"},{"line_number":96,"context_line":"    sqlalchemy \u003d ironic.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"1aa78d24_5b853305","line":93,"in_reply_to":"3aaa91ec_b65f8fe3","updated":"2016-07-05 22:21:42.000000000","message":"I\u0027m in the not worry until a v3 appears boat, but I think if it is not already explicitly documented, that it should be documented.  We have defaulted ourselves to using v2 via ironic/common/neutron.py, so it would be a refactoring effort at that point to adapt or to optionally leverage a v3 API if/when that occurs.\n\nIt could be called just \u0027NeutronNetwork\u0027 instead of \u0027NeutronV2Network\u0027, or \u0027neutronv2\u0027 but I think an operator at this point in time will just default to associating v2 with neutron in general.  Besides, when a v3 api comes out, we likely may want to make that opt-in since it would likely represent behavior changes that we would otherwise have to account for automatically.","commit_id":"91cb5ae8e36a24cd924c23bab56750cd8c9955bc"}]}
