)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e798842328a05267fcd1c860efa4045bd31fe668","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-20 16:23:46 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make sure create_ovs_taps createse uniq taps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During grenade several networks is used. We need to have access"},{"line_number":10,"context_line":"from control plane to all of them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_90e2b02d","line":7,"updated":"2016-05-20 14:28:13.000000000","message":"creates unique","commit_id":"a28b55ddf60c0b3bfb03a2555ccfc4b055f535bd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e798842328a05267fcd1c860efa4045bd31fe668","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During grenade several networks is used. We need to have access"},{"line_number":10,"context_line":"from control plane to all of them."},{"line_number":11,"context_line":"This patch ensures that taps are uniq for each new network."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6b9ac22d726a052f781b2580b8ffd8f90e4bf648"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_50c32889","line":11,"updated":"2016-05-20 14:28:13.000000000","message":"ditto unique","commit_id":"a28b55ddf60c0b3bfb03a2555ccfc4b055f535bd"}],"devstack/lib/ironic":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e798842328a05267fcd1c860efa4045bd31fe668","unresolved":false,"context_lines":[{"line_number":669,"context_line":"#"},{"line_number":670,"context_line":"# create_ovs_taps ironic_network_id"},{"line_number":671,"context_line":"# NOTE(vsaienko) Ironic supports only flat Neutron network."},{"line_number":672,"context_line":"# In meantime the following magic should be replaced with flat networks."},{"line_number":673,"context_line":"function create_ovs_taps {"},{"line_number":674,"context_line":"    local ironic_net_id"},{"line_number":675,"context_line":"    ironic_net_id\u003d$1"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bab6814e_90b47035","line":672,"updated":"2016-05-20 14:28:13.000000000","message":"Not sure what you mean here, may need to be rewritten.","commit_id":"a28b55ddf60c0b3bfb03a2555ccfc4b055f535bd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4f2b25350e7b0c0811b7ca4347125b6f714bbe33","unresolved":false,"context_lines":[{"line_number":697,"context_line":"    die_if_not_set $LINENO tag_id \"Failed to get tag id\""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    # make sure veth pair is not existing, otherwise delete its links"},{"line_number":700,"context_line":"    sudo ip link show ovs-$tag_id-tap1 \u0026\u0026 sudo ip link delete ovs-$tag_id-tap1"},{"line_number":701,"context_line":"    sudo ip link show brbm-$tag_id-tap1 \u0026\u0026 sudo ip link delete brbm-$tag_id-tap1"},{"line_number":702,"context_line":"    # create veth pair for future interconnection between br-int and brbm"},{"line_number":703,"context_line":"    sudo ip link add brbm-$tag_id-tap1 type veth peer name ovs-$tag_id-tap1"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bab6814e_a38b1ec2","line":700,"range":{"start_line":700,"start_character":26,"end_line":700,"end_character":38},"updated":"2016-05-20 22:03:02.000000000","message":"How about:\n\n ${tag_id}-tap1\n\nHelps to make it clear which variable we are dealing with.","commit_id":"9a9642bccc0bb23979bb6e515fb61a9418c89c00"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"858470ad35dde9fa94895d4b15c80c18f5370027","unresolved":false,"context_lines":[{"line_number":697,"context_line":"    die_if_not_set $LINENO tag_id \"Failed to get tag id\""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    # make sure veth pair is not existing, otherwise delete its links"},{"line_number":700,"context_line":"    sudo ip link show ovs-$tag_id-tap1 \u0026\u0026 sudo ip link delete ovs-$tag_id-tap1"},{"line_number":701,"context_line":"    sudo ip link show brbm-$tag_id-tap1 \u0026\u0026 sudo ip link delete brbm-$tag_id-tap1"},{"line_number":702,"context_line":"    # create veth pair for future interconnection between br-int and brbm"},{"line_number":703,"context_line":"    sudo ip link add brbm-$tag_id-tap1 type veth peer name ovs-$tag_id-tap1"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bab6814e_389d345a","line":700,"in_reply_to":"bab6814e_17392442","updated":"2016-05-24 10:06:49.000000000","message":"Sure, the names you\u0027re generating are fine; I just think it would be a bit neater to generate them once rather than six times each :-) Particularly if there\u0027s confusion about how the string-interpolation is happening.\n\nJust to be clear, I\u0027m literally asking for\n\n    local ovs_tap\u003dovs-${tag_id}-tap1\n    local brbm_tap\u003dbrbm-${tag_id}-tap1\n    sudo ip link show $ovs_tap \u0026\u0026 sudo ip link delete $ovs_tap\n    sudo ip link show $brbm_tap \u0026\u0026 sudo ip link delete $brbm_tap\n    [etc.]\n\nIt\u0027s not a big deal, though.","commit_id":"9a9642bccc0bb23979bb6e515fb61a9418c89c00"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2f8332cf1d7ecdf831c186739e1a635701c93ea4","unresolved":false,"context_lines":[{"line_number":697,"context_line":"    die_if_not_set $LINENO tag_id \"Failed to get tag id\""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    # make sure veth pair is not existing, otherwise delete its links"},{"line_number":700,"context_line":"    sudo ip link show ovs-$tag_id-tap1 \u0026\u0026 sudo ip link delete ovs-$tag_id-tap1"},{"line_number":701,"context_line":"    sudo ip link show brbm-$tag_id-tap1 \u0026\u0026 sudo ip link delete brbm-$tag_id-tap1"},{"line_number":702,"context_line":"    # create veth pair for future interconnection between br-int and brbm"},{"line_number":703,"context_line":"    sudo ip link add brbm-$tag_id-tap1 type veth peer name ovs-$tag_id-tap1"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bab6814e_3b4939b8","line":700,"in_reply_to":"bab6814e_389d345a","updated":"2016-05-26 07:04:38.000000000","message":"Done","commit_id":"9a9642bccc0bb23979bb6e515fb61a9418c89c00"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2a88152d5ee21cf7ef3aa0b870f677ec55910c85","unresolved":false,"context_lines":[{"line_number":697,"context_line":"    die_if_not_set $LINENO tag_id \"Failed to get tag id\""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    # make sure veth pair is not existing, otherwise delete its links"},{"line_number":700,"context_line":"    sudo ip link show ovs-$tag_id-tap1 \u0026\u0026 sudo ip link delete ovs-$tag_id-tap1"},{"line_number":701,"context_line":"    sudo ip link show brbm-$tag_id-tap1 \u0026\u0026 sudo ip link delete brbm-$tag_id-tap1"},{"line_number":702,"context_line":"    # create veth pair for future interconnection between br-int and brbm"},{"line_number":703,"context_line":"    sudo ip link add brbm-$tag_id-tap1 type veth peer name ovs-$tag_id-tap1"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bab6814e_e504d515","line":700,"in_reply_to":"bab6814e_a38b1ec2","updated":"2016-05-23 14:08:27.000000000","message":"Also, maybe factor out $br_tap and $ovs_tap variables?","commit_id":"9a9642bccc0bb23979bb6e515fb61a9418c89c00"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9379a5f923072f3d9cb16bd37e7b10050ef1c049","unresolved":false,"context_lines":[{"line_number":697,"context_line":"    die_if_not_set $LINENO tag_id \"Failed to get tag id\""},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    # make sure veth pair is not existing, otherwise delete its links"},{"line_number":700,"context_line":"    sudo ip link show ovs-$tag_id-tap1 \u0026\u0026 sudo ip link delete ovs-$tag_id-tap1"},{"line_number":701,"context_line":"    sudo ip link show brbm-$tag_id-tap1 \u0026\u0026 sudo ip link delete brbm-$tag_id-tap1"},{"line_number":702,"context_line":"    # create veth pair for future interconnection between br-int and brbm"},{"line_number":703,"context_line":"    sudo ip link add brbm-$tag_id-tap1 type veth peer name ovs-$tag_id-tap1"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bab6814e_17392442","line":700,"range":{"start_line":700,"start_character":26,"end_line":700,"end_character":38},"in_reply_to":"bab6814e_a38b1ec2","updated":"2016-05-24 08:21:05.000000000","message":"I don\u0027t think we need a new name here. ovs-$tag_id-tap1 is connected to OVS switch, please have look L707, so it has ovs in the name.\nOn my mind I have newer looked at this interfaces during development, so I\u0027m not sure that name is very important here. Besides I hope that we will switch to Neutron Flat network in nearest future since it is officially supported case by Ironic and this \u0027work with taps\u0027 will not be needed.","commit_id":"9a9642bccc0bb23979bb6e515fb61a9418c89c00"}]}
