)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a48e50cc7d7d419ba51ce34e4294f61b67222ab7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Gracefully degrade start_iscsi_target for Mitaka ramdisk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently calling this code blows up if using an older ramdisk. If we"},{"line_number":10,"context_line":"get an exception back from iscsi.start_iscsi_target, try without the"},{"line_number":11,"context_line":"\u0027wipe_disk_metadata\u0027 and \u0027portal_port\u0027 parameter in the hope that"},{"line_number":12,"context_line":"it\u0027s an older ramdisk and the second call will work."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bab6814e_685727ca","line":10,"updated":"2016-05-23 11:37:18.000000000","message":"Instead of getting exception we comparing command_status output.","commit_id":"53d35cf3635db5709c66b950ffae3b39eba1e81c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8f924f59bd7e995925a6bc9169c2b2e78677eb8d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Gracefully degrade start_iscsi_target for Mitaka ramdisk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently calling this code blows up if using an older ramdisk. If we"},{"line_number":10,"context_line":"get an exception back from iscsi.start_iscsi_target, try without the"},{"line_number":11,"context_line":"\u0027wipe_disk_metadata\u0027 and \u0027portal_port\u0027 parameter in the hope that"},{"line_number":12,"context_line":"it\u0027s an older ramdisk and the second call will work."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bab6814e_1e3deedc","line":10,"in_reply_to":"bab6814e_685727ca","updated":"2016-05-23 13:04:06.000000000","message":"Well, initially it was an exception :)","commit_id":"53d35cf3635db5709c66b950ffae3b39eba1e81c"}],"ironic/drivers/modules/agent_client.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c4fbfd3d4af2ab32ab675a1f70ec011bc0592c11","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                                 params\u003dparams,"},{"line_number":151,"context_line":"                                 wait\u003dTrue)"},{"line_number":152,"context_line":"        except exception.IronicException as e:"},{"line_number":153,"context_line":"            LOG.debug(\u0027start_iscsi_target failed, trying again without \u0027"},{"line_number":154,"context_line":"                      \u0027wipe_disk_metadata (unsupported on ramdisks before \u0027"},{"line_number":155,"context_line":"                      \u0027Newton release)\u0027)"},{"line_number":156,"context_line":"            params \u003d {\u0027iqn\u0027: iqn,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_796bc685","line":153,"updated":"2016-05-20 10:42:57.000000000","message":"Can we be more specific here? Like maybe assert that wipe_disk_metadata is in e.message?","commit_id":"739e55703c86a7765b372a9072e790db0b676231"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"13762f9ed4d97e307a70a09930a39cf93c6bfd47","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                             wait\u003dwait)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start_iscsi_target(self, node, iqn, portal_port\u003d3260,"},{"line_number":134,"context_line":"                           wipe_disk_metadata\u003dFalse, old_agent\u003dFalse):"},{"line_number":135,"context_line":"        \"\"\"Expose the node\u0027s disk as an ISCSI target."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        :param node: an Ironic node object"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_296d17cc","line":134,"updated":"2016-05-23 14:53:32.000000000","message":"I think \"old_agent\" parameter not needed at all. These defaults not used, values passed here https://review.openstack.org/#/c/319183/5/ironic/drivers/modules/iscsi_deploy.py obviously. Therefore can use None as defaults here, and update param if it\u0027s not None.","commit_id":"53d35cf3635db5709c66b950ffae3b39eba1e81c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"67f5823929f4fd0efa8618f3d32ab2237bab9f49","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                             wait\u003dwait)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start_iscsi_target(self, node, iqn, portal_port\u003d3260,"},{"line_number":134,"context_line":"                           wipe_disk_metadata\u003dFalse, old_agent\u003dFalse):"},{"line_number":135,"context_line":"        \"\"\"Expose the node\u0027s disk as an ISCSI target."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        :param node: an Ironic node object"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_50eab3db","line":134,"in_reply_to":"bab6814e_296d17cc","updated":"2016-05-23 17:05:01.000000000","message":"Not sure about changing the defaults, I\u0027d rather pass None to say \u0027don\u0027t pass these to agent\u0027","commit_id":"53d35cf3635db5709c66b950ffae3b39eba1e81c"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e849b30ab228159fd5df1810167d1a08e1b7001e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                             params\u003dparams,"},{"line_number":131,"context_line":"                             wait\u003dwait)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start_iscsi_target(self, node, iqn, portal_port\u003d3260,"},{"line_number":134,"context_line":"                           wipe_disk_metadata\u003dFalse):"},{"line_number":135,"context_line":"        \"\"\"Expose the node\u0027s disk as an ISCSI target."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_5aae42e8","line":133,"updated":"2016-05-23 22:49:32.000000000","message":"nit: could leave these two lines unchanged.","commit_id":"ec333b03e25653908ee9beab5e76db2f551422ca"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6f96682d63cec8b867497c62f66a910d39faf9bd","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                             params\u003dparams,"},{"line_number":131,"context_line":"                             wait\u003dwait)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start_iscsi_target(self, node, iqn, portal_port\u003d3260,"},{"line_number":134,"context_line":"                           wipe_disk_metadata\u003dFalse):"},{"line_number":135,"context_line":"        \"\"\"Expose the node\u0027s disk as an ISCSI target."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_73851dac","line":133,"in_reply_to":"bab6814e_5aae42e8","updated":"2016-05-24 10:45:04.000000000","message":"+1","commit_id":"ec333b03e25653908ee9beab5e76db2f551422ca"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e849b30ab228159fd5df1810167d1a08e1b7001e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        disk magic strings like the partition table, RAID or filesystem"},{"line_number":143,"context_line":"        signature, setting it to None means \u0027don\u0027t pass it to ramdisk, it"},{"line_number":144,"context_line":"        does not support this parameter\u0027"},{"line_number":145,"context_line":"        \"\"\""},{"line_number":146,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":147,"context_line":"        if portal_port is not None:"},{"line_number":148,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_da80724c","line":145,"updated":"2016-05-23 22:49:32.000000000","message":"Is there a reason we don\u0027t do the retry in this function? Seems like it would be simpler to only modify this one function.","commit_id":"ec333b03e25653908ee9beab5e76db2f551422ca"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6f96682d63cec8b867497c62f66a910d39faf9bd","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        disk magic strings like the partition table, RAID or filesystem"},{"line_number":143,"context_line":"        signature, setting it to None means \u0027don\u0027t pass it to ramdisk, it"},{"line_number":144,"context_line":"        does not support this parameter\u0027"},{"line_number":145,"context_line":"        \"\"\""},{"line_number":146,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":147,"context_line":"        if portal_port is not None:"},{"line_number":148,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_ec476f49","line":145,"in_reply_to":"bab6814e_da80724c","updated":"2016-05-24 10:45:04.000000000","message":"I guess it depends if we want the agent client to gracefully degrade or if we want the driver to gracefully degrade, I\u0027m not sure which should be in charge of handling that. \n\nThe driver is the one who decides whether wipe_disk_metadata\u003dTrue/False, so I guess it maybe should be the one to enforce, handle and know if that option hasn\u0027t worked when it asked for it.","commit_id":"ec333b03e25653908ee9beab5e76db2f551422ca"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6572f483556349b432551fed18120d001f3df382","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        disk magic strings like the partition table, RAID or filesystem"},{"line_number":143,"context_line":"        signature, setting it to None means \u0027don\u0027t pass it to ramdisk, it"},{"line_number":144,"context_line":"        does not support this parameter\u0027"},{"line_number":145,"context_line":"        \"\"\""},{"line_number":146,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":147,"context_line":"        if portal_port is not None:"},{"line_number":148,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_4cc67b17","line":145,"in_reply_to":"bab6814e_ec476f49","updated":"2016-05-24 10:53:14.000000000","message":"+1 to Sam.","commit_id":"ec333b03e25653908ee9beab5e76db2f551422ca"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e072d0e513c6343c9975cc2af6790e30a8f4c9e7","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed, trying again without \u0027"},{"line_number":159,"context_line":"                         \u0027wipe_disk_metadata and portal_port (unsupported on \u0027"},{"line_number":160,"context_line":"                         \u0027ramdisks before Newton release). If you want to use \u0027"},{"line_number":161,"context_line":"                         \u0027these new capabilities, please update the ramdisk.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_b64ac925","line":158,"updated":"2016-05-24 13:09:12.000000000","message":"I think the node\u0027s UUID should be part of this log message.","commit_id":"623a964d55da0a27042a49163e0cb4f46899c8f3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"948a6a22f43a91cdd84f75447ebc4a4aa725d858","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed, trying again without \u0027"},{"line_number":159,"context_line":"                         \u0027wipe_disk_metadata and portal_port (unsupported on \u0027"},{"line_number":160,"context_line":"                         \u0027ramdisks before Newton release). If you want to use \u0027"},{"line_number":161,"context_line":"                         \u0027these new capabilities, please update the ramdisk.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_f6da9116","line":158,"in_reply_to":"bab6814e_b64ac925","updated":"2016-05-24 13:12:43.000000000","message":"Done","commit_id":"623a964d55da0a27042a49163e0cb4f46899c8f3"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9797cda1aab8ebf62f13201c7787b6e9f2cda1d0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed for node %s, trying again \u0027"},{"line_number":159,"context_line":"                         \u0027without wipe_disk_metadata and portal_port \u0027"},{"line_number":160,"context_line":"                         \u0027(unsupported on ramdisks before Newton release). If \u0027"},{"line_number":161,"context_line":"                         \u0027you want to use these new capabilities, please \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_9e499791","line":158,"updated":"2016-05-24 14:47:29.000000000","message":"Not sure about \"info\" log level https://wiki.openstack.org/wiki/LoggingStandards","commit_id":"3082ae7c8b7ea08e8edd46857b1995cdf3646168"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2ed9b4524f9d9cfddde153cf26428246c8ad9ca4","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed for node %s, trying again \u0027"},{"line_number":159,"context_line":"                         \u0027without wipe_disk_metadata and portal_port \u0027"},{"line_number":160,"context_line":"                         \u0027(unsupported on ramdisks before Newton release). If \u0027"},{"line_number":161,"context_line":"                         \u0027you want to use these new capabilities, please \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_0a141342","line":158,"updated":"2016-05-25 11:16:04.000000000","message":"heh, I was going to suggest WARNING actually :) this is about us refusing to do what a user/operator configured us to do, so I strongly thing this message must stand out","commit_id":"3082ae7c8b7ea08e8edd46857b1995cdf3646168"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ea9fa2a3c5afe09009b7e116a3648d92de3ed355","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed for node %s, trying again \u0027"},{"line_number":159,"context_line":"                         \u0027without wipe_disk_metadata and portal_port \u0027"},{"line_number":160,"context_line":"                         \u0027(unsupported on ramdisks before Newton release). If \u0027"},{"line_number":161,"context_line":"                         \u0027you want to use these new capabilities, please \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_bc68a322","line":158,"in_reply_to":"bab6814e_0a141342","updated":"2016-05-25 15:05:22.000000000","message":"Actually, we\u0027re trying to pass the default values, they might or might not be provided by the operator, which is why I\u0027m hesitant about this.","commit_id":"3082ae7c8b7ea08e8edd46857b1995cdf3646168"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"91e04b00fac58524b4d783bbc253a8c404ad42de","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed for node %s, trying again \u0027"},{"line_number":159,"context_line":"                         \u0027without wipe_disk_metadata and portal_port \u0027"},{"line_number":160,"context_line":"                         \u0027(unsupported on ramdisks before Newton release). If \u0027"},{"line_number":161,"context_line":"                         \u0027you want to use these new capabilities, please \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_e0b2a0e4","line":158,"in_reply_to":"bab6814e_3d3b3bed","updated":"2016-05-25 06:11:09.000000000","message":"-1 for debug.\nDebug level means this messages will deliver to users only if they enable debug\u003dTrue. I am not sure will operators enable it or not. But if they disable this option  in production cloud, they will miss the messages.","commit_id":"3082ae7c8b7ea08e8edd46857b1995cdf3646168"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6f544d862fa5bc5ddb86e36f9f3a5c8c3cd2c947","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed for node %s, trying again \u0027"},{"line_number":159,"context_line":"                         \u0027without wipe_disk_metadata and portal_port \u0027"},{"line_number":160,"context_line":"                         \u0027(unsupported on ramdisks before Newton release). If \u0027"},{"line_number":161,"context_line":"                         \u0027you want to use these new capabilities, please \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_b2876ad6","line":158,"in_reply_to":"bab6814e_9e499791","updated":"2016-05-24 15:43:10.000000000","message":"Yep, it does not comply with those requirements, but here it is a special case, eg this is not a \u0027potential failure\u0027 either so I think warning is not suitable here too. Maybe we should leave this as debug as it was before? If an operator needs a new ramdisk, he will know about it himself. Let\u0027s see what others think.","commit_id":"3082ae7c8b7ea08e8edd46857b1995cdf3646168"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d4738e680f98884a403b8c09143a045d2a977d7a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed for node %s, trying again \u0027"},{"line_number":159,"context_line":"                         \u0027without wipe_disk_metadata and portal_port \u0027"},{"line_number":160,"context_line":"                         \u0027(unsupported on ramdisks before Newton release). If \u0027"},{"line_number":161,"context_line":"                         \u0027you want to use these new capabilities, please \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_3d3b3bed","line":158,"in_reply_to":"bab6814e_b2876ad6","updated":"2016-05-24 23:46:30.000000000","message":"Debug level sounds about right. But I don\u0027t have a strong opinion about it.","commit_id":"3082ae7c8b7ea08e8edd46857b1995cdf3646168"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"65a3d2ac6872a972d5449894ceb0c40c564cd51f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed for node %s, trying again \u0027"},{"line_number":159,"context_line":"                         \u0027without wipe_disk_metadata and portal_port \u0027"},{"line_number":160,"context_line":"                         \u0027(unsupported on ramdisks before Newton release). If \u0027"},{"line_number":161,"context_line":"                         \u0027you want to use these new capabilities, please \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_7f0f4d88","line":158,"in_reply_to":"bab6814e_bc68a322","updated":"2016-05-25 15:18:43.000000000","message":"I understand. Still, we fall back to an option which is likely to fail for some users (that\u0027s why we introduced wipe_disk_metadata)","commit_id":"3082ae7c8b7ea08e8edd46857b1995cdf3646168"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ca8ac738cbba701c1de50fc7ed01752ed0a00da9","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed for node %s, trying again \u0027"},{"line_number":159,"context_line":"                         \u0027without wipe_disk_metadata and portal_port \u0027"},{"line_number":160,"context_line":"                         \u0027(unsupported on ramdisks before Newton release). If \u0027"},{"line_number":161,"context_line":"                         \u0027you want to use these new capabilities, please \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_9fb031df","line":158,"in_reply_to":"bab6814e_bc68a322","updated":"2016-05-25 15:18:17.000000000","message":"I would say warning is correct here too. Thanks for the link @yuriy, that\u0027s useful.\n\nPersonally, in my understanding, the logs goes like:\n\n* WARNING for failures that will be automatic retried or fallback somehow.\n\n* INFO for success.\n\n* ERROR for failures that only affects that operation.\n\n* CRITICAL for errors that compromise the whole service.\n\n* DEBUG for the rest.","commit_id":"3082ae7c8b7ea08e8edd46857b1995cdf3646168"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e927a06ef5dccd8428c7e428d33ef02850a85e81","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                 u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":156,"context_line":"            # Both attributes were introduced in Newton, so we should look out"},{"line_number":157,"context_line":"            # for both of them"},{"line_number":158,"context_line":"            LOG.info(_LI(\u0027start_iscsi_target failed for node %s, trying again \u0027"},{"line_number":159,"context_line":"                         \u0027without wipe_disk_metadata and portal_port \u0027"},{"line_number":160,"context_line":"                         \u0027(unsupported on ramdisks before Newton release). If \u0027"},{"line_number":161,"context_line":"                         \u0027you want to use these new capabilities, please \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_1468c220","line":158,"in_reply_to":"bab6814e_e0b2a0e4","updated":"2016-05-25 08:10:28.000000000","message":"-1 for debug too.","commit_id":"3082ae7c8b7ea08e8edd46857b1995cdf3646168"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"89d70a69001cc84658b0bfa3ef4c9c17fb1c0425","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEFAULT_PORTAL_PORT \u003d 3260"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class AgentClient(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_db24740e","line":36,"updated":"2016-05-26 03:04:19.000000000","message":"do you think we should directly use [iscsi]/portal_port here? This seems duplicate and both use the same default value.\nFor example, if we call start_iscsi_target(node, iqn) without portal_port, and admin change the option value, then the port value is the default value 3260.\nSo I think we should bind this two value together.\nWDYT?","commit_id":"264b3f35d1aeafcaff1d2ec5f108b874408c429f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c6bc918e00a568b5d84ba9bdf1c9e25661fad3b0","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEFAULT_PORTAL_PORT \u003d 3260"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class AgentClient(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_fcde7d3c","line":36,"in_reply_to":"bab6814e_db24740e","updated":"2016-05-26 11:20:36.000000000","message":"The problem is, we can\u0027t import iscsi_deploy module here, it causes circular import. So we should either set the default here and in iscsi_deploy do\n\niscsi_opts \u003d [\n    cfg.PortOpt(\u0027portal_port\u0027,\n                default\u003dagent_client.DEFAULT_PORTAL_PORT,\n                help\u003d_(\u0027The port number on which the iSCSI portal listens \u0027\n                       \u0027for incoming connections.\u0027)),\n]\n\nwhich I personally don\u0027t like :) (why would we define iscsi default in agent_client) or, we can leave things as is here, assuming that default iscsi port won\u0027t change any time soon.","commit_id":"264b3f35d1aeafcaff1d2ec5f108b874408c429f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"aa7df175fa80bc9911e6c1ad325bfb133331e947","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                               params\u003dparams,"},{"line_number":160,"context_line":"                               wait\u003dTrue)"},{"line_number":161,"context_line":"        if (result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027 and"},{"line_number":162,"context_line":"                (u\u0027wipe_disk_metadata\u0027 in result[\u0027command_error\u0027][\u0027message\u0027] or"},{"line_number":163,"context_line":"                 u\u0027portal_port\u0027 in result[\u0027command_error\u0027][\u0027message\u0027]) and"},{"line_number":164,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d u\u0027TypeError\u0027):"},{"line_number":165,"context_line":"            # It means that the user requested some things not available on the"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_b67eccac","line":162,"updated":"2016-05-26 13:17:23.000000000","message":"nit: \u0027u\u0027 prefix is not needed, works with PY2:\n\nPython 2.7.6 (default, Jun 22 2015, 17:58:13) \n[GCC 4.8.2] on linux2\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e u\u0027port\u0027 \u003d\u003d \u0027port\u0027\nTrue\n\u003e\u003e\u003e \u0027port\u0027 in (u\u0027port\u0027,)\nTrue\n\u003e\u003e\u003e \u0027port\u0027 in u\u0027port123\u0027\nTrue","commit_id":"cdfc4b9c3b8485d1decaba59b6203ce685209103"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c8cadb77446b850a412f293fb000835114f0774f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                \u0027start_iscsi_target failed for node %(node)s, additional \u0027"},{"line_number":165,"context_line":"                \u0027parameters %(sub_msg)s are requested, which are not \u0027"},{"line_number":166,"context_line":"                \u0027supported by the ramdisk being used. Please update the \u0027"},{"line_number":167,"context_line":"                \u0027ramdisk to use IPA at least of Newton version.\u0027),"},{"line_number":168,"context_line":"                {\u0027node\u0027: node.uuid, \u0027sub_msg\u0027: \u0027, \u0027.join(additional_params)})"},{"line_number":169,"context_line":"        return result"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_47f5f2ea","line":167,"range":{"start_line":167,"start_character":32,"end_line":167,"end_character":35},"updated":"2016-06-02 04:38:18.000000000","message":"Please say Ironic Python Agent. I worry users won\u0027t know what IPA means.","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"10ea1b3c52d630115313d0f42d4dcf0559eb32ac","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                \u0027start_iscsi_target failed for node %(node)s, additional \u0027"},{"line_number":165,"context_line":"                \u0027parameters %(sub_msg)s are requested, which are not \u0027"},{"line_number":166,"context_line":"                \u0027supported by the ramdisk being used. Please update the \u0027"},{"line_number":167,"context_line":"                \u0027ramdisk to use IPA at least of Newton version.\u0027),"},{"line_number":168,"context_line":"                {\u0027node\u0027: node.uuid, \u0027sub_msg\u0027: \u0027, \u0027.join(additional_params)})"},{"line_number":169,"context_line":"        return result"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_6de5abda","line":167,"updated":"2016-05-31 23:18:02.000000000","message":"There is no Newton version (yet)?","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e8acc525312e2d713a309aef870d6a2084aabd48","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                \u0027start_iscsi_target failed for node %(node)s, additional \u0027"},{"line_number":165,"context_line":"                \u0027parameters %(sub_msg)s are requested, which are not \u0027"},{"line_number":166,"context_line":"                \u0027supported by the ramdisk being used. Please update the \u0027"},{"line_number":167,"context_line":"                \u0027ramdisk to use IPA at least of Newton version.\u0027),"},{"line_number":168,"context_line":"                {\u0027node\u0027: node.uuid, \u0027sub_msg\u0027: \u0027, \u0027.join(additional_params)})"},{"line_number":169,"context_line":"        return result"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_6d6d30cc","line":167,"range":{"start_line":167,"start_character":32,"end_line":167,"end_character":35},"in_reply_to":"9abb7d3a_47f5f2ea","updated":"2016-06-02 19:38:54.000000000","message":"how about\n\nThe (ironic python) agent in the ramdisk on node %node.. failed to start the iSCSI target because the agent doesn\u0027t support these parameters: %(params)s. Please update the ramdisk to use version 1.3 (Newton, or higher) of \u0027ironic python agent\u0027.\n\nyeah, I don\u0027t like \u0027sub_msg\u0027, those are just parameters.","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8daf6700c17d25dff083721696bad821f2a8e809","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                \u0027start_iscsi_target failed for node %(node)s, additional \u0027"},{"line_number":165,"context_line":"                \u0027parameters %(sub_msg)s are requested, which are not \u0027"},{"line_number":166,"context_line":"                \u0027supported by the ramdisk being used. Please update the \u0027"},{"line_number":167,"context_line":"                \u0027ramdisk to use IPA at least of Newton version.\u0027),"},{"line_number":168,"context_line":"                {\u0027node\u0027: node.uuid, \u0027sub_msg\u0027: \u0027, \u0027.join(additional_params)})"},{"line_number":169,"context_line":"        return result"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_f10a0025","line":167,"in_reply_to":"9abb7d3a_6de5abda","updated":"2016-06-01 11:06:34.000000000","message":"Yeah, I\u0027ll change it to \"newer than Mitaka\" either in this change or in the followup, thanks.","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"f5e2109f9f37c25281a8f32677ef1c29ac282318","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":144,"context_line":"        additional_params \u003d []"},{"line_number":145,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":146,"context_line":"        if portal_port !\u003d DEFAULT_PORTAL_PORT:"},{"line_number":147,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":148,"context_line":"            additional_params.append(\u0027portal_port\u003d%s\u0027 % portal_port)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7aa08908_6956b7d3","line":145,"updated":"2016-06-06 13:30:38.000000000","message":"Should we make a note this is to be removed in ocata?","commit_id":"99319a78b078390a8eb3f05a839371d775e10b31"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"38cd5fb2190b395c64a8d4cc390d2d7c4fb7ed8d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":144,"context_line":"        additional_params \u003d []"},{"line_number":145,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":146,"context_line":"        if portal_port !\u003d DEFAULT_PORTAL_PORT:"},{"line_number":147,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":148,"context_line":"            additional_params.append(\u0027portal_port\u003d%s\u0027 % portal_port)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7aa08908_b41116af","line":145,"in_reply_to":"7aa08908_6956b7d3","updated":"2016-06-06 13:42:00.000000000","message":"+1","commit_id":"99319a78b078390a8eb3f05a839371d775e10b31"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2813de2d3d2837f68f0ccea3371041664ff93995","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":144,"context_line":"        additional_params \u003d []"},{"line_number":145,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":146,"context_line":"        if portal_port !\u003d DEFAULT_PORTAL_PORT:"},{"line_number":147,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":148,"context_line":"            additional_params.append(\u0027portal_port\u003d%s\u0027 % portal_port)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7aa08908_d49f8201","line":145,"in_reply_to":"7aa08908_b41116af","updated":"2016-06-06 13:44:16.000000000","message":"It\u0027s already mentioned in config option description and release note, can also add it here in a followup :)","commit_id":"99319a78b078390a8eb3f05a839371d775e10b31"},{"author":{"_account_id":19153,"name":"jingtao liang","email":"liang.jingtao@zte.com.cn","username":"liangjingtao"},"change_message_id":"00bcbc673341cf6f38ab592586b159e7f019edc0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027):"},{"line_number":161,"context_line":"            # It means that the user requested some things not available on the"},{"line_number":162,"context_line":"            # old ramdisk, tell them they should update it"},{"line_number":163,"context_line":"            LOG.error(_LE("},{"line_number":164,"context_line":"                \u0027The ironic python agent in the ramdisk on node %(node)s \u0027"},{"line_number":165,"context_line":"                \u0027failed to start the iSCSI target because the agent doesn\\\u0027t \u0027"},{"line_number":166,"context_line":"                \u0027support these parameters: %(params)s. Please update the \u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"7aa08908_ad09d233","line":163,"updated":"2016-06-06 11:50:20.000000000","message":"The codes should obey the pep8.","commit_id":"99319a78b078390a8eb3f05a839371d775e10b31"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"98cb425fc9a4d56aa3ceda0f27014209204b80c0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027):"},{"line_number":161,"context_line":"            # It means that the user requested some things not available on the"},{"line_number":162,"context_line":"            # old ramdisk, tell them they should update it"},{"line_number":163,"context_line":"            LOG.error(_LE("},{"line_number":164,"context_line":"                \u0027The ironic python agent in the ramdisk on node %(node)s \u0027"},{"line_number":165,"context_line":"                \u0027failed to start the iSCSI target because the agent doesn\\\u0027t \u0027"},{"line_number":166,"context_line":"                \u0027support these parameters: %(params)s. Please update the \u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"7aa08908_28303056","line":163,"in_reply_to":"7aa08908_ad09d233","updated":"2016-06-06 12:00:41.000000000","message":"Dunno what you mean here, it is a valid formatting and it passed pep8, also I did run flake8 locally, it gave me no errors.","commit_id":"99319a78b078390a8eb3f05a839371d775e10b31"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4cf73d09d7942a80569e7e6d2b2f330f81d88295","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027):"},{"line_number":161,"context_line":"            # It means that the user requested some things not available on the"},{"line_number":162,"context_line":"            # old ramdisk, tell them they should update it"},{"line_number":163,"context_line":"            LOG.error(_LE("},{"line_number":164,"context_line":"                \u0027The ironic python agent in the ramdisk on node %(node)s \u0027"},{"line_number":165,"context_line":"                \u0027failed to start the iSCSI target because the agent doesn\\\u0027t \u0027"},{"line_number":166,"context_line":"                \u0027support these parameters: %(params)s. Please update the \u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"7aa08908_c8952c41","line":163,"in_reply_to":"7aa08908_ad09d233","updated":"2016-06-06 11:57:20.000000000","message":"This patch has passed pep8 gate, why do you -1 it?","commit_id":"99319a78b078390a8eb3f05a839371d775e10b31"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"7297e426b79a875e5f76afac781c305611f99636","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEFAULT_PORTAL_PORT \u003d 3260"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class AgentClient(object):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_38083f91","line":36,"updated":"2016-06-07 11:43:25.000000000","message":"I wonder if we need a note here saying that this is the default value according to the ironic python agent, not according to Ironic, the Ironic one defined in iscsi_deploy could change independently of the value defined by IPA, but this needs to remain the same as IPA for the graceful degradation to work.","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"928a46b59be60e631b5b3256404cdefd9c98669d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEFAULT_PORTAL_PORT \u003d 3260"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class AgentClient(object):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_3e930751","line":36,"in_reply_to":"7aa08908_38083f91","updated":"2016-06-07 12:16:22.000000000","message":"Done","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0947219d23647543fd898a6d23d13de148b4bd58","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        signature."},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":144,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":145,"context_line":"        if portal_port !\u003d DEFAULT_PORTAL_PORT:"},{"line_number":146,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":147,"context_line":"        if wipe_disk_metadata:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_53ca5a6e","line":144,"updated":"2016-06-07 08:35:32.000000000","message":"When this workaround should be removed?","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"928a46b59be60e631b5b3256404cdefd9c98669d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        signature."},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":144,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":145,"context_line":"        if portal_port !\u003d DEFAULT_PORTAL_PORT:"},{"line_number":146,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":147,"context_line":"        if wipe_disk_metadata:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_1ea1eba3","line":144,"in_reply_to":"7aa08908_1892a39e","updated":"2016-06-07 12:16:22.000000000","message":"Done","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3ca9cd5e85e0b2522f7734cf5bb3d4e823811c5a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        signature."},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":144,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":145,"context_line":"        if portal_port !\u003d DEFAULT_PORTAL_PORT:"},{"line_number":146,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":147,"context_line":"        if wipe_disk_metadata:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_797db7e6","line":144,"in_reply_to":"7aa08908_53ca5a6e","updated":"2016-06-07 09:01:02.000000000","message":"As this does not break anything out anyone, we can remove it with mitaka eol, what do you think?","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8afb077021557adb05588eaac72236522272ac60","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        signature."},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":144,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":145,"context_line":"        if portal_port !\u003d DEFAULT_PORTAL_PORT:"},{"line_number":146,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":147,"context_line":"        if wipe_disk_metadata:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_c75afd4f","line":144,"in_reply_to":"7aa08908_797db7e6","updated":"2016-06-07 10:08:56.000000000","message":"Will wait for more comments, can add this in the followup.","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"7297e426b79a875e5f76afac781c305611f99636","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        signature."},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":144,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":145,"context_line":"        if portal_port !\u003d DEFAULT_PORTAL_PORT:"},{"line_number":146,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":147,"context_line":"        if wipe_disk_metadata:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_1892a39e","line":144,"in_reply_to":"7aa08908_c75afd4f","updated":"2016-06-07 11:43:25.000000000","message":"We only support -1 named release for upgrades, so I think that this can be removed in the Ocata cycle because Mitaka to Ocata upgrades aren\u0027t supported, therefore anyone using Ocata should be using at least the newton ramdisk, which will support this feature.","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0947219d23647543fd898a6d23d13de148b4bd58","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                   wait\u003dTrue)"},{"line_number":164,"context_line":"        if (result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027 and"},{"line_number":165,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027 and"},{"line_number":166,"context_line":"                \u0027portal_port\u0027 in result[\u0027command_error\u0027][\u0027message\u0027]):"},{"line_number":167,"context_line":"            # It means that the user has explicitly requested some things"},{"line_number":168,"context_line":"            # not available on the old ramdisk, tell them they should"},{"line_number":169,"context_line":"            # update it"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_b3b45ed1","line":166,"updated":"2016-06-07 08:35:32.000000000","message":"Maybe create internal helper function for these \"if\"?","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"7297e426b79a875e5f76afac781c305611f99636","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                   wait\u003dTrue)"},{"line_number":164,"context_line":"        if (result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027 and"},{"line_number":165,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027 and"},{"line_number":166,"context_line":"                \u0027portal_port\u0027 in result[\u0027command_error\u0027][\u0027message\u0027]):"},{"line_number":167,"context_line":"            # It means that the user has explicitly requested some things"},{"line_number":168,"context_line":"            # not available on the old ramdisk, tell them they should"},{"line_number":169,"context_line":"            # update it"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_9b1050aa","line":166,"in_reply_to":"7aa08908_9961833c","updated":"2016-06-07 11:43:25.000000000","message":"You can use a helper function internal to this function, then no one outside this function can use it. Or I wonder if the whole function can be reworked something like this to reduce duplication:\n\ndef start_iscsi_target(self, node, iqn, portal_port\u003dDEFAULT_PORTAL_PORT,\n                       wipe_disk_metadata\u003dFalse):\n    params \u003d {\u0027iqn\u0027: iqn}\n    if wipe_disk_metadata:\n        params[\u0027wipe_disk_metadata\u0027] \u003d wipe_disk_metadata\n    if portal_port !\u003d DEFAULT_PORTAL_PORT:\n        params[\u0027portal_port\u0027] \u003d portal_port\n    result \u003d None\n    while True:\n        result \u003d self._command(node\u003dnode,\n                               method\u003d\u0027iscsi.start_iscsi_target\u0027,\n                               params\u003dparams,\n                               wait\u003dTrue)\n        if (result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027 and\n            result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027):\n            message \u003d result[\u0027command_error\u0027][\u0027message\u0027]\n            if \u0027wipe_disk_metadata\u0027 in message:\n                del params[\u0027wipe_disk_metadata\u0027]\n                continue\n            elif \u0027portal_port\u0027 in message:\n                LOG.error(_LE(\n                    \u0027The ironic python agent in the ramdisk on node %(node)s \u0027\n                    \u0027failed to start the iSCSI target because the agent \u0027\n                    \u0027doesn\\\u0027t support portal_port parameter. Please update \u0027\n                    \u0027the ramdisk to use version \u003e\u003d 1.3 (Newton, or higher) \u0027\n                    \u0027of ironic python agent, or use the default value of \u0027\n                    \u0027[iscsi]portal_port config option.\u0027), {\u0027node\u0027: node.uuid})\n        break\n    return result","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3ca9cd5e85e0b2522f7734cf5bb3d4e823811c5a","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                   wait\u003dTrue)"},{"line_number":164,"context_line":"        if (result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027 and"},{"line_number":165,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027 and"},{"line_number":166,"context_line":"                \u0027portal_port\u0027 in result[\u0027command_error\u0027][\u0027message\u0027]):"},{"line_number":167,"context_line":"            # It means that the user has explicitly requested some things"},{"line_number":168,"context_line":"            # not available on the old ramdisk, tell them they should"},{"line_number":169,"context_line":"            # update it"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_9961833c","line":166,"in_reply_to":"7aa08908_b3b45ed1","updated":"2016-06-07 09:01:02.000000000","message":"I hope we won\u0027t do this anymore, that\u0027s the reason I didn\u0027t want to introduce the function, so that noone will have the temptation to use it :)","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"7297e426b79a875e5f76afac781c305611f99636","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        if (result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027 and"},{"line_number":165,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027 and"},{"line_number":166,"context_line":"                \u0027portal_port\u0027 in result[\u0027command_error\u0027][\u0027message\u0027]):"},{"line_number":167,"context_line":"            # It means that the user has explicitly requested some things"},{"line_number":168,"context_line":"            # not available on the old ramdisk, tell them they should"},{"line_number":169,"context_line":"            # update it"},{"line_number":170,"context_line":"            LOG.error(_LE("}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_b6b561ef","line":167,"range":{"start_line":167,"start_character":32,"end_line":167,"end_character":36},"updated":"2016-06-07 11:43:25.000000000","message":"We need to be careful when we refer to the \"user\" it can have multiple meanings, and often leads to confusion. In this case I would reword this to say that Ironic has been configured in a way incompatible with the older ramdisks.","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f196d452bc4ba23fcc2f4ddbe73df070c6f76911","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        if (result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027 and"},{"line_number":165,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027 and"},{"line_number":166,"context_line":"                \u0027portal_port\u0027 in result[\u0027command_error\u0027][\u0027message\u0027]):"},{"line_number":167,"context_line":"            # It means that the user has explicitly requested some things"},{"line_number":168,"context_line":"            # not available on the old ramdisk, tell them they should"},{"line_number":169,"context_line":"            # update it"},{"line_number":170,"context_line":"            LOG.error(_LE("}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_bbab89d5","line":167,"range":{"start_line":167,"start_character":32,"end_line":167,"end_character":36},"in_reply_to":"7aa08908_b6b561ef","updated":"2016-06-07 11:49:53.000000000","message":"+1","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"928a46b59be60e631b5b3256404cdefd9c98669d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        if (result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027 and"},{"line_number":165,"context_line":"                result[\u0027command_error\u0027][\u0027type\u0027] \u003d\u003d \u0027TypeError\u0027 and"},{"line_number":166,"context_line":"                \u0027portal_port\u0027 in result[\u0027command_error\u0027][\u0027message\u0027]):"},{"line_number":167,"context_line":"            # It means that the user has explicitly requested some things"},{"line_number":168,"context_line":"            # not available on the old ramdisk, tell them they should"},{"line_number":169,"context_line":"            # update it"},{"line_number":170,"context_line":"            LOG.error(_LE("}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_7eaf4f94","line":167,"range":{"start_line":167,"start_character":32,"end_line":167,"end_character":36},"in_reply_to":"7aa08908_bbab89d5","updated":"2016-06-07 12:16:22.000000000","message":"Done","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"7297e426b79a875e5f76afac781c305611f99636","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # update it"},{"line_number":170,"context_line":"            LOG.error(_LE("},{"line_number":171,"context_line":"                \u0027The ironic python agent in the ramdisk on node %(node)s \u0027"},{"line_number":172,"context_line":"                \u0027failed to start the iSCSI target because the agent \u0027"},{"line_number":173,"context_line":"                \u0027doesn\\\u0027t support portal_port parameter. Please update \u0027"},{"line_number":174,"context_line":"                \u0027the ramdisk to use version \u003e\u003d 1.3 (Newton, or higher) \u0027"},{"line_number":175,"context_line":"                \u0027of ironic python agent, or use the default value of \u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_f696c94a","line":172,"range":{"start_line":172,"start_character":62,"end_line":172,"end_character":67},"updated":"2016-06-07 11:43:25.000000000","message":"the configured agent","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"928a46b59be60e631b5b3256404cdefd9c98669d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # update it"},{"line_number":170,"context_line":"            LOG.error(_LE("},{"line_number":171,"context_line":"                \u0027The ironic python agent in the ramdisk on node %(node)s \u0027"},{"line_number":172,"context_line":"                \u0027failed to start the iSCSI target because the agent \u0027"},{"line_number":173,"context_line":"                \u0027doesn\\\u0027t support portal_port parameter. Please update \u0027"},{"line_number":174,"context_line":"                \u0027the ramdisk to use version \u003e\u003d 1.3 (Newton, or higher) \u0027"},{"line_number":175,"context_line":"                \u0027of ironic python agent, or use the default value of \u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_3ea5c7b4","line":172,"range":{"start_line":172,"start_character":62,"end_line":172,"end_character":67},"in_reply_to":"7aa08908_f696c94a","updated":"2016-06-07 12:16:22.000000000","message":"Done","commit_id":"cad1dc90959f7ae949bd9a9489d3a10811e20fc4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"700bc110e08ddaec419b24a05f64088fa217065b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                message \u003d result[\u0027command_error\u0027][\u0027message\u0027]"},{"line_number":159,"context_line":"                if \u0027wipe_disk_metadata\u0027 in message:"},{"line_number":160,"context_line":"                    # wipe_disk_metadata was introduced after portal_port, so"},{"line_number":161,"context_line":"                    # portal_port might still work"},{"line_number":162,"context_line":"                    params \u003d params.copy()"},{"line_number":163,"context_line":"                    del params[\u0027wipe_disk_metadata\u0027]"},{"line_number":164,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_8db5abef","line":161,"updated":"2016-06-07 13:11:16.000000000","message":"We should log a warning here so the operator knows the ramdisk needs an update.","commit_id":"5480893d6b71c688b1538e65f736cbdf13eb1c02"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d381117b3d6e430939891c2085744b13bf3e0483","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                    # wipe_disk_metadata was introduced after portal_port, so"},{"line_number":161,"context_line":"                    # portal_port might still work"},{"line_number":162,"context_line":"                    params \u003d params.copy()"},{"line_number":163,"context_line":"                    del params[\u0027wipe_disk_metadata\u0027]"},{"line_number":164,"context_line":"                    continue"},{"line_number":165,"context_line":"                elif \u0027portal_port\u0027 in message:"},{"line_number":166,"context_line":"                    # It means that ironic is configured in a way that the"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_2da597b4","line":163,"range":{"start_line":163,"start_character":20,"end_line":163,"end_character":52},"updated":"2016-06-07 13:11:52.000000000","message":"we diverge from the default (and expected) behavior, so this needs LOG.warning","commit_id":"5480893d6b71c688b1538e65f736cbdf13eb1c02"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e93d604600aaae1653164f045415e9b616f8e995","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                        \u0027Please update the ramdisk to use version \u003e\u003d 1.3 \u0027"},{"line_number":174,"context_line":"                        \u0027(Newton, or higher) of ironic python agent, or use \u0027"},{"line_number":175,"context_line":"                        \u0027the default value of [iscsi]portal_port config \u0027"},{"line_number":176,"context_line":"                        \u0027option.\u0027), {\u0027node\u0027: node.uuid})"},{"line_number":177,"context_line":"            return result"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def install_bootloader(self, node, root_uuid, efi_system_part_uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_8c83f103","line":176,"updated":"2016-06-07 12:35:55.000000000","message":"missing a break here so this will loop forever","commit_id":"5480893d6b71c688b1538e65f736cbdf13eb1c02"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"534bd67f821c56ca5fa22d6738743ee027cdbda2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                        \u0027Please update the ramdisk to use version \u003e\u003d 1.3 \u0027"},{"line_number":174,"context_line":"                        \u0027(Newton, or higher) of ironic python agent, or use \u0027"},{"line_number":175,"context_line":"                        \u0027the default value of [iscsi]portal_port config \u0027"},{"line_number":176,"context_line":"                        \u0027option.\u0027), {\u0027node\u0027: node.uuid})"},{"line_number":177,"context_line":"            return result"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def install_bootloader(self, node, root_uuid, efi_system_part_uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_a73d26bd","line":176,"in_reply_to":"7aa08908_8c365150","updated":"2016-06-07 12:43:29.000000000","message":"My mistake, I misread the indentation :)","commit_id":"5480893d6b71c688b1538e65f736cbdf13eb1c02"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6d0cbd19985a06c8fab299bbe03150a859e75ff2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                        \u0027Please update the ramdisk to use version \u003e\u003d 1.3 \u0027"},{"line_number":174,"context_line":"                        \u0027(Newton, or higher) of ironic python agent, or use \u0027"},{"line_number":175,"context_line":"                        \u0027the default value of [iscsi]portal_port config \u0027"},{"line_number":176,"context_line":"                        \u0027option.\u0027), {\u0027node\u0027: node.uuid})"},{"line_number":177,"context_line":"            return result"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def install_bootloader(self, node, root_uuid, efi_system_part_uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_8c365150","line":176,"in_reply_to":"7aa08908_8c83f103","updated":"2016-06-07 12:38:22.000000000","message":"There is a return result inside the loop.","commit_id":"5480893d6b71c688b1538e65f736cbdf13eb1c02"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4bb93c1ffcb3737fceabeb8a51176fd7a10acfa4","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                        \u0027Please update the ramdisk to use version \u003e\u003d 1.3 \u0027"},{"line_number":174,"context_line":"                        \u0027(Newton, or higher) of ironic python agent, or use \u0027"},{"line_number":175,"context_line":"                        \u0027the default value of [iscsi]portal_port config \u0027"},{"line_number":176,"context_line":"                        \u0027option.\u0027), {\u0027node\u0027: node.uuid})"},{"line_number":177,"context_line":"            return result"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def install_bootloader(self, node, root_uuid, efi_system_part_uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_b2aba6d5","line":176,"in_reply_to":"7aa08908_a73d26bd","updated":"2016-06-07 12:57:43.000000000","message":"Looks like this code is little harder to read compared to previous version but does the same.","commit_id":"5480893d6b71c688b1538e65f736cbdf13eb1c02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b6ce4a5c19cfe549af0de77b462952129b4e34f5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":146,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":147,"context_line":"        # TODO(vdrok): remove this workaround in Ocata release"},{"line_number":148,"context_line":"        if portal_port !\u003d DEFAULT_IPA_PORTAL_PORT:"},{"line_number":149,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":150,"context_line":"        if wipe_disk_metadata:"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_2dce292e","line":147,"updated":"2016-06-07 16:13:28.000000000","message":"we are assuming that we will not support an N-2 IPA with an N ironic, right?","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a268b78f06bb601aa06be273221293260a65346a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"        params \u003d {\u0027iqn\u0027: iqn}"},{"line_number":146,"context_line":"        # This is to workaround passing default values to an old ramdisk"},{"line_number":147,"context_line":"        # TODO(vdrok): remove this workaround in Ocata release"},{"line_number":148,"context_line":"        if portal_port !\u003d DEFAULT_IPA_PORTAL_PORT:"},{"line_number":149,"context_line":"            params[\u0027portal_port\u0027] \u003d portal_port"},{"line_number":150,"context_line":"        if wipe_disk_metadata:"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_288f3476","line":147,"in_reply_to":"7aa08908_2dce292e","updated":"2016-06-07 17:52:00.000000000","message":"Correct. We need to add it in docs somewhere.","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b6ce4a5c19cfe549af0de77b462952129b4e34f5","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                        {\u0027node\u0027: node.uuid})"},{"line_number":170,"context_line":"                    # wipe_disk_metadata was introduced after portal_port, so"},{"line_number":171,"context_line":"                    # portal_port might still work"},{"line_number":172,"context_line":"                    params \u003d params.copy()"},{"line_number":173,"context_line":"                    del params[\u0027wipe_disk_metadata\u0027]"},{"line_number":174,"context_line":"                    continue"},{"line_number":175,"context_line":"                elif \u0027portal_port\u0027 in message:"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_f85d0116","line":172,"updated":"2016-06-07 16:13:28.000000000","message":"why do we need to make a copy of it?","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a268b78f06bb601aa06be273221293260a65346a","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                        {\u0027node\u0027: node.uuid})"},{"line_number":170,"context_line":"                    # wipe_disk_metadata was introduced after portal_port, so"},{"line_number":171,"context_line":"                    # portal_port might still work"},{"line_number":172,"context_line":"                    params \u003d params.copy()"},{"line_number":173,"context_line":"                    del params[\u0027wipe_disk_metadata\u0027]"},{"line_number":174,"context_line":"                    continue"},{"line_number":175,"context_line":"                elif \u0027portal_port\u0027 in message:"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_148c117e","line":172,"in_reply_to":"7aa08908_f85d0116","updated":"2016-06-07 17:52:00.000000000","message":"Will add a comment. No todo as this code will be removed anyway.","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b6ce4a5c19cfe549af0de77b462952129b4e34f5","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                        \"Please update the ramdisk to use version \u003e\u003d 1.3 \""},{"line_number":184,"context_line":"                        \"(Newton, or higher) of ironic python agent, or use \""},{"line_number":185,"context_line":"                        \"the default value of [iscsi]portal_port config \""},{"line_number":186,"context_line":"                        \"option.\"), {\u0027node\u0027: node.uuid})"},{"line_number":187,"context_line":"            return result"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def install_bootloader(self, node, root_uuid, efi_system_part_uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_f8c34155","line":186,"updated":"2016-06-07 16:13:28.000000000","message":"Isn\u0027t it going to loop forever here? I would have thought you would del params[\u0027portal_port\u0027]?","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d696471c5159ee4e3a8cd15a315fa0d9b33c98f4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                        \"Please update the ramdisk to use version \u003e\u003d 1.3 \""},{"line_number":184,"context_line":"                        \"(Newton, or higher) of ironic python agent, or use \""},{"line_number":185,"context_line":"                        \"the default value of [iscsi]portal_port config \""},{"line_number":186,"context_line":"                        \"option.\"), {\u0027node\u0027: node.uuid})"},{"line_number":187,"context_line":"            return result"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def install_bootloader(self, node, root_uuid, efi_system_part_uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_5ec99a25","line":186,"in_reply_to":"7aa08908_785d9178","updated":"2016-06-07 17:28:37.000000000","message":"Oh, I see the \u0027return result\u0027 is at the same level as the \u0027if\u0027 on L157","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"294724c6ba53c46efbb54cb515144edc9769e7b0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                        \"Please update the ramdisk to use version \u003e\u003d 1.3 \""},{"line_number":184,"context_line":"                        \"(Newton, or higher) of ironic python agent, or use \""},{"line_number":185,"context_line":"                        \"the default value of [iscsi]portal_port config \""},{"line_number":186,"context_line":"                        \"option.\"), {\u0027node\u0027: node.uuid})"},{"line_number":187,"context_line":"            return result"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def install_bootloader(self, node, root_uuid, efi_system_part_uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_785d9178","line":186,"in_reply_to":"7aa08908_f8c34155","updated":"2016-06-07 16:20:19.000000000","message":"++\n\n/me worries about this. Maybe there should be a break at the bottom of all this. So unless an explicit continue we fall out.","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b5e8e9a0137bf80c5b692072a5140311190efacc","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                        \"Please update the ramdisk to use version \u003e\u003d 1.3 \""},{"line_number":184,"context_line":"                        \"(Newton, or higher) of ironic python agent, or use \""},{"line_number":185,"context_line":"                        \"the default value of [iscsi]portal_port config \""},{"line_number":186,"context_line":"                        \"option.\"), {\u0027node\u0027: node.uuid})"},{"line_number":187,"context_line":"            return result"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def install_bootloader(self, node, root_uuid, efi_system_part_uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_98815dc6","line":186,"in_reply_to":"7aa08908_f8c34155","updated":"2016-06-07 16:19:48.000000000","message":"Sorry, my bad. You don\u0027t want it to continue.","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f44cef100fd368aaff1e90916fd2d44fb485f65c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                        \"please update the ramdisk to use version \u003e\u003d 1.3 \""},{"line_number":170,"context_line":"                        \"(Newton, or higher) of ironic python agent.\"),"},{"line_number":171,"context_line":"                        {\u0027node\u0027: node.uuid})"},{"line_number":172,"context_line":"                    # This is needed to make assert_has_calls work, otherwise"},{"line_number":173,"context_line":"                    # it will report it was called without wipe_disk_metadata"},{"line_number":174,"context_line":"                    # both times as params is stored by reference in mock"},{"line_number":175,"context_line":"                    params \u003d params.copy()"}],"source_content_type":"text/x-python","patch_set":23,"id":"7aa08908_4f543fc9","line":172,"updated":"2016-06-07 19:21:46.000000000","message":"s/make/make unit test\u0027s/\n\nShould probably be a NOTE(vdrok) too but anyway. if you do another revision.","commit_id":"387220eae05ffab0fec436df6edb2197b0009add"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"44c19a4a3a55a3d7d9abcbf4beeaf87b5fd2c091","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                        \"please update the ramdisk to use version \u003e\u003d 1.3 \""},{"line_number":170,"context_line":"                        \"(Newton, or higher) of ironic python agent.\"),"},{"line_number":171,"context_line":"                        {\u0027node\u0027: node.uuid})"},{"line_number":172,"context_line":"                    # This is needed to make assert_has_calls work, otherwise"},{"line_number":173,"context_line":"                    # it will report it was called without wipe_disk_metadata"},{"line_number":174,"context_line":"                    # both times as params is stored by reference in mock"},{"line_number":175,"context_line":"                    params \u003d params.copy()"}],"source_content_type":"text/x-python","patch_set":23,"id":"7aa08908_019966c4","line":172,"in_reply_to":"7aa08908_4f543fc9","updated":"2016-06-07 21:13:03.000000000","message":"Done","commit_id":"387220eae05ffab0fec436df6edb2197b0009add"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f44cef100fd368aaff1e90916fd2d44fb485f65c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                elif \u0027portal_port\u0027 in message:"},{"line_number":179,"context_line":"                    # It means that ironic is configured in a way that the"},{"line_number":180,"context_line":"                    # deploy driver has requested some things not available"},{"line_number":181,"context_line":"                    # on the old ramdisk"},{"line_number":182,"context_line":"                    LOG.error(_LE("},{"line_number":183,"context_line":"                        \"The ironic python agent in the ramdisk on node \""},{"line_number":184,"context_line":"                        \"%(node)s failed to start the iSCSI target because \""}],"source_content_type":"text/x-python","patch_set":23,"id":"7aa08908_2fd733ee","line":181,"updated":"2016-06-07 19:21:46.000000000","message":"Given the confusion (or not obvious) coding of if/elif, it\u0027d be good to have a comment here that we aren\u0027t going to retry w/o the portal_port.\n\n\neg, add something like \". Since the user specified a non-default portal_port, we do not try again with the default value. Instead, the user needs to take some explicit action.\u0027","commit_id":"387220eae05ffab0fec436df6edb2197b0009add"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"44c19a4a3a55a3d7d9abcbf4beeaf87b5fd2c091","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                elif \u0027portal_port\u0027 in message:"},{"line_number":179,"context_line":"                    # It means that ironic is configured in a way that the"},{"line_number":180,"context_line":"                    # deploy driver has requested some things not available"},{"line_number":181,"context_line":"                    # on the old ramdisk"},{"line_number":182,"context_line":"                    LOG.error(_LE("},{"line_number":183,"context_line":"                        \"The ironic python agent in the ramdisk on node \""},{"line_number":184,"context_line":"                        \"%(node)s failed to start the iSCSI target because \""}],"source_content_type":"text/x-python","patch_set":23,"id":"7aa08908_e1953a87","line":181,"in_reply_to":"7aa08908_2fd733ee","updated":"2016-06-07 21:13:03.000000000","message":"Done","commit_id":"387220eae05ffab0fec436df6edb2197b0009add"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"9fbbc721223d62bfab7e636e535e60f99a02e810","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if wipe_disk_metadata:"},{"line_number":151,"context_line":"            params[\u0027wipe_disk_metadata\u0027] \u003d wipe_disk_metadata"},{"line_number":152,"context_line":"        while True:"},{"line_number":153,"context_line":"            result \u003d self._command(node\u003dnode,"},{"line_number":154,"context_line":"                                   method\u003d\u0027iscsi.start_iscsi_target\u0027,"},{"line_number":155,"context_line":"                                   params\u003dparams,"},{"line_number":156,"context_line":"                                   wait\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7aa08908_8b2a898e","line":153,"range":{"start_line":153,"start_character":26,"end_line":153,"end_character":34},"updated":"2016-06-08 04:29:34.000000000","message":"Why pass incompatible params and fail.. is there no way to check the IPA version and then pass the correct params?","commit_id":"bdaf5a8c56a84a17113703f942f6d595b996fd60"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b1d29713bbea2988d19fef2c382a2f6c2e397795","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if wipe_disk_metadata:"},{"line_number":151,"context_line":"            params[\u0027wipe_disk_metadata\u0027] \u003d wipe_disk_metadata"},{"line_number":152,"context_line":"        while True:"},{"line_number":153,"context_line":"            result \u003d self._command(node\u003dnode,"},{"line_number":154,"context_line":"                                   method\u003d\u0027iscsi.start_iscsi_target\u0027,"},{"line_number":155,"context_line":"                                   params\u003dparams,"},{"line_number":156,"context_line":"                                   wait\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7aa08908_b147f6ba","line":153,"range":{"start_line":153,"start_character":26,"end_line":153,"end_character":34},"in_reply_to":"7aa08908_8b2a898e","updated":"2016-06-08 05:42:34.000000000","message":"At the moment IPA doesn\u0027t support versioning. There is a corresponding thread at openstack-dev.","commit_id":"bdaf5a8c56a84a17113703f942f6d595b996fd60"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9cdebed307766e91de325b77a6dc074e044f2b8c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                        \"The ironic python agent in the ramdisk on node \""},{"line_number":165,"context_line":"                        \"%(node)s failed to start the iSCSI target because \""},{"line_number":166,"context_line":"                        \"it doesn\u0027t support wipe_disk_metadata parameter, \""},{"line_number":167,"context_line":"                        \"retrying without passing it. If you need to have \""},{"line_number":168,"context_line":"                        \"node\u0027s root disk wiped before exposing it via iSCSI, \""},{"line_number":169,"context_line":"                        \"please update the ramdisk to use version \u003e\u003d 1.3 \""},{"line_number":170,"context_line":"                        \"(Newton, or higher) of ironic python agent.\"),"},{"line_number":171,"context_line":"                        {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":24,"id":"7aa08908_dd61f03a","line":168,"range":{"start_line":167,"start_character":54,"end_line":168,"end_character":77},"updated":"2016-06-08 08:17:31.000000000","message":"User may not knows need or not need this wipe for own Ironic configuration, update recommended because it fix a bug (1550604).","commit_id":"bdaf5a8c56a84a17113703f942f6d595b996fd60"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0a382e6a953fa4c2801b6f2ee47632fa829cecf9","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                        \"The ironic python agent in the ramdisk on node \""},{"line_number":165,"context_line":"                        \"%(node)s failed to start the iSCSI target because \""},{"line_number":166,"context_line":"                        \"it doesn\u0027t support wipe_disk_metadata parameter, \""},{"line_number":167,"context_line":"                        \"retrying without passing it. If you need to have \""},{"line_number":168,"context_line":"                        \"node\u0027s root disk wiped before exposing it via iSCSI, \""},{"line_number":169,"context_line":"                        \"please update the ramdisk to use version \u003e\u003d 1.3 \""},{"line_number":170,"context_line":"                        \"(Newton, or higher) of ironic python agent.\"),"},{"line_number":171,"context_line":"                        {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":24,"id":"7aa08908_7a39d4d6","line":168,"range":{"start_line":167,"start_character":54,"end_line":168,"end_character":77},"in_reply_to":"7aa08908_dd61f03a","updated":"2016-06-08 09:56:25.000000000","message":"Done","commit_id":"bdaf5a8c56a84a17113703f942f6d595b996fd60"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"044799df38fb0bbc099ff3dcf991c2e83992ace3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                        \"or because https://bugs.launchpad.net/bugs/1550604 \""},{"line_number":170,"context_line":"                        \"affects you, please update the ramdisk to use \""},{"line_number":171,"context_line":"                        \"version \u003e\u003d 1.3 (Newton, or higher) of ironic python \""},{"line_number":172,"context_line":"                        \"agent.\"), {\u0027node\u0027: node.uuid})"},{"line_number":173,"context_line":"                    # NOTE(vdrok): This is needed to make unit test\u0027s"},{"line_number":174,"context_line":"                    # assert_has_calls work, otherwise it will report it was"},{"line_number":175,"context_line":"                    # called without wipe_disk_metadata both times as \"params\""}],"source_content_type":"text/x-python","patch_set":25,"id":"7aa08908_604913d0","line":172,"updated":"2016-06-08 13:48:42.000000000","message":"I think this wins the prize for longest warning string :)","commit_id":"ba83fb1bb45b63e056c87c3bbf42cabaade7865c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a19e4ddc2d7d80f78efe007371080562babff8b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                        \"or because https://bugs.launchpad.net/bugs/1550604 \""},{"line_number":170,"context_line":"                        \"affects you, please update the ramdisk to use \""},{"line_number":171,"context_line":"                        \"version \u003e\u003d 1.3 (Newton, or higher) of ironic python \""},{"line_number":172,"context_line":"                        \"agent.\"), {\u0027node\u0027: node.uuid})"},{"line_number":173,"context_line":"                    # NOTE(vdrok): This is needed to make unit test\u0027s"},{"line_number":174,"context_line":"                    # assert_has_calls work, otherwise it will report it was"},{"line_number":175,"context_line":"                    # called without wipe_disk_metadata both times as \"params\""}],"source_content_type":"text/x-python","patch_set":25,"id":"7aa08908_738e0f2f","line":172,"in_reply_to":"7aa08908_604913d0","updated":"2016-06-08 13:59:24.000000000","message":"This will be the reason for upgrade IPA :)","commit_id":"ba83fb1bb45b63e056c87c3bbf42cabaade7865c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"44a9c4ea1f711f6fe45451ff55f9786809898889","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                        \"or because https://bugs.launchpad.net/bugs/1550604 \""},{"line_number":170,"context_line":"                        \"affects you, please update the ramdisk to use \""},{"line_number":171,"context_line":"                        \"version \u003e\u003d 1.3 (Newton, or higher) of ironic python \""},{"line_number":172,"context_line":"                        \"agent.\"), {\u0027node\u0027: node.uuid})"},{"line_number":173,"context_line":"                    # NOTE(vdrok): This is needed to make unit test\u0027s"},{"line_number":174,"context_line":"                    # assert_has_calls work, otherwise it will report it was"},{"line_number":175,"context_line":"                    # called without wipe_disk_metadata both times as \"params\""}],"source_content_type":"text/x-python","patch_set":25,"id":"7aa08908_cc22c0a2","line":172,"in_reply_to":"7aa08908_738e0f2f","updated":"2016-06-08 14:34:20.000000000","message":"Excellent idea! :)","commit_id":"ba83fb1bb45b63e056c87c3bbf42cabaade7865c"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"13762f9ed4d97e307a70a09930a39cf93c6bfd47","unresolved":false,"context_lines":[{"line_number":354,"context_line":"             u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":355,"context_line":"        # Both attributes were introduced in Newton, so we should look out"},{"line_number":356,"context_line":"        # for both of them"},{"line_number":357,"context_line":"        LOG.debug(\u0027start_iscsi_target failed, trying again without \u0027"},{"line_number":358,"context_line":"                  \u0027wipe_disk_metadata and portal_port (unsupported on \u0027"},{"line_number":359,"context_line":"                  \u0027ramdisks before Newton release)\u0027)"},{"line_number":360,"context_line":"        result \u003d agent_client.start_iscsi_target("}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_e665fc1d","line":357,"updated":"2016-05-23 14:53:32.000000000","message":"Looks like a warning should be here, like \"Please update ramdisk etc.\"","commit_id":"53d35cf3635db5709c66b950ffae3b39eba1e81c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"67f5823929f4fd0efa8618f3d32ab2237bab9f49","unresolved":false,"context_lines":[{"line_number":354,"context_line":"             u\u0027portal_port\u0027 in six.text_type(result))):"},{"line_number":355,"context_line":"        # Both attributes were introduced in Newton, so we should look out"},{"line_number":356,"context_line":"        # for both of them"},{"line_number":357,"context_line":"        LOG.debug(\u0027start_iscsi_target failed, trying again without \u0027"},{"line_number":358,"context_line":"                  \u0027wipe_disk_metadata and portal_port (unsupported on \u0027"},{"line_number":359,"context_line":"                  \u0027ramdisks before Newton release)\u0027)"},{"line_number":360,"context_line":"        result \u003d agent_client.start_iscsi_target("}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_40cf8855","line":357,"in_reply_to":"bab6814e_e665fc1d","updated":"2016-05-23 17:05:01.000000000","message":"If one does not need these capabilities, why update? People should be able to use new code with old ramdisk, in this case I think it\u0027s our problem to deal with that.","commit_id":"53d35cf3635db5709c66b950ffae3b39eba1e81c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"149a3f63b3231e9daefc0d93e8067956cbec9ac1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                help\u003d_(\u0027The port number on which the iSCSI portal listens \u0027"},{"line_number":84,"context_line":"                       \u0027for incoming connections.\u0027)),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027wipe_disk_partitions\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\u0027If set to True, wipe the root disk partitions before \u0027"},{"line_number":88,"context_line":"                       \u0027exposing it over iSCSI.\u0027)),"},{"line_number":89,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9abb7d3a_83e3b304","line":86,"updated":"2016-05-31 09:08:18.000000000","message":"Looks like set default to false re-introduce bug https://bugs.launchpad.net/ironic-lib/+bug/1550604","commit_id":"ca008b654c43685872b4fec65f35ffab23eed206"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ea2112a9611a6fc3cfe4edc67a5be8163d31c9b3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                help\u003d_(\u0027The port number on which the iSCSI portal listens \u0027"},{"line_number":84,"context_line":"                       \u0027for incoming connections.\u0027)),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027wipe_disk_partitions\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\u0027If set to True, wipe the root disk partitions before \u0027"},{"line_number":88,"context_line":"                       \u0027exposing it over iSCSI.\u0027)),"},{"line_number":89,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9abb7d3a_63d20fd4","line":86,"in_reply_to":"9abb7d3a_83e3b304","updated":"2016-05-31 09:14:44.000000000","message":"It provides the way to fix it and to avoid problems with upgrade. I\u0027ll update the release note.","commit_id":"ca008b654c43685872b4fec65f35ffab23eed206"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"960a0c669aa82a6db159b3a0cffe1762e3b07686","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027wipe_disk_partitions\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\u0027If set to True, wipe the root disk partitions before \u0027"},{"line_number":88,"context_line":"                       \u0027exposing it over iSCSI.\u0027)),"},{"line_number":89,"context_line":"]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":15,"id":"9abb7d3a_e31b9f19","line":88,"updated":"2016-05-31 09:09:43.000000000","message":"I would like to see 1a4bf23ce5773726fc776369b483254d13d54f2b reverted. The fix for https://bugs.launchpad.net/ironic-lib/+bug/1550604 introduce a new compatibility bug https://bugs.launchpad.net/ironic/+bug/1584005 that is higher by priority than original.","commit_id":"ca008b654c43685872b4fec65f35ffab23eed206"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ea2112a9611a6fc3cfe4edc67a5be8163d31c9b3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027wipe_disk_partitions\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\u0027If set to True, wipe the root disk partitions before \u0027"},{"line_number":88,"context_line":"                       \u0027exposing it over iSCSI.\u0027)),"},{"line_number":89,"context_line":"]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":15,"id":"9abb7d3a_c38f7bca","line":88,"in_reply_to":"9abb7d3a_e31b9f19","updated":"2016-05-31 09:14:44.000000000","message":"OK, I\u0027ll update that change too, let\u0027s see what others think.","commit_id":"ca008b654c43685872b4fec65f35ffab23eed206"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e5f276ea787d380c7c0fcf8c78ffbfb6f0ddeb29","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027The port number on which the iSCSI portal listens \u0027"},{"line_number":84,"context_line":"                       \u0027for incoming connections.\u0027)),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027wipe_disk_partitions\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\u0027If set to True, wipe the root disk partitions before \u0027"},{"line_number":88,"context_line":"                       \u0027exposing it over iSCSI.\u0027)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_fac77d93","line":85,"updated":"2016-06-01 09:21:31.000000000","message":"Do you plan to deprecate this option in the future? If yes, please add comment.","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ef299c714c988425cfd6c2949a758c51b2ddf140","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                default\u003d3260,"},{"line_number":83,"context_line":"                help\u003d_(\u0027The port number on which the iSCSI portal listens \u0027"},{"line_number":84,"context_line":"                       \u0027for incoming connections.\u0027)),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027wipe_disk_partitions\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\u0027If set to True, wipe the root disk partitions before \u0027"},{"line_number":88,"context_line":"                       \u0027exposing it over iSCSI.\u0027)),"}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_c0344c4b","line":85,"in_reply_to":"9abb7d3a_fac77d93","updated":"2016-06-01 10:04:15.000000000","message":"I\u0027m not sure, should we add it as deprecated right from the beginning? For how long should we keep it? To answer these questions we need to decide for how many releases we should support backwards compatibility.","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"92b50c112236f2fd7148b12c01837f6216ac4473","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                                    \u0027release cycle to fix the compatibility \u0027"},{"line_number":90,"context_line":"                                    \u0027of ironic with old ironic python agent \u0027"},{"line_number":91,"context_line":"                                    \u0027ramdisks. It will be removed in Ocata.\u0027),"},{"line_number":92,"context_line":"                help\u003d_(\u0027If set to True, wipe the root disk partitions before \u0027"},{"line_number":93,"context_line":"                       \u0027exposing it over iSCSI.\u0027)),"},{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7aa08908_d8f989ca","line":92,"updated":"2016-06-06 08:39:35.000000000","message":"Because default setting is not optimal for production environments with new ramdisk maybe add something like \"Recommended set to True if Newton or higher version IPA ramdisk used.\"","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2b643f214ba247f85506ae315efb1b1a90a8a2df","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                                    \u0027release cycle to fix the compatibility \u0027"},{"line_number":90,"context_line":"                                    \u0027of ironic with old ironic python agent \u0027"},{"line_number":91,"context_line":"                                    \u0027ramdisks. It will be removed in Ocata.\u0027),"},{"line_number":92,"context_line":"                help\u003d_(\u0027If set to True, wipe the root disk partitions before \u0027"},{"line_number":93,"context_line":"                       \u0027exposing it over iSCSI.\u0027)),"},{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7aa08908_d2483d5e","line":92,"in_reply_to":"7aa08908_d8f989ca","updated":"2016-06-06 11:12:19.000000000","message":"Done","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"}],"ironic/tests/unit/drivers/modules/test_agent_client.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e50089facd0c577d89f903b00b73e1493baebc14","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            node\u003dself.node, method\u003d\u0027standby.prepare_image\u0027,"},{"line_number":175,"context_line":"            params\u003dparams, wait\u003dFalse)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @mock.patch(\u0027uuid.uuid4\u0027, mock.MagicMock(spec_set\u003d[], return_value\u003d\u0027uuid\u0027))"},{"line_number":178,"context_line":"    def test_start_iscsi_target(self):"},{"line_number":179,"context_line":"        self.client._command \u003d mock.MagicMock(spec_set\u003d[])"},{"line_number":180,"context_line":"        iqn \u003d \u0027fake-iqn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_be6b0284","side":"PARENT","line":177,"updated":"2016-05-23 13:02:13.000000000","message":"I\u0027m confused to why we are removing this from the existing test, seems unrelated to the change being made.","commit_id":"5123c755a90a3a5ad7c3f18ce5ed69b3e176777a"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1683137b5ac354c652883f46a80ef716f2f4b8d6","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            node\u003dself.node, method\u003d\u0027standby.prepare_image\u0027,"},{"line_number":175,"context_line":"            params\u003dparams, wait\u003dFalse)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @mock.patch(\u0027uuid.uuid4\u0027, mock.MagicMock(spec_set\u003d[], return_value\u003d\u0027uuid\u0027))"},{"line_number":178,"context_line":"    def test_start_iscsi_target(self):"},{"line_number":179,"context_line":"        self.client._command \u003d mock.MagicMock(spec_set\u003d[])"},{"line_number":180,"context_line":"        iqn \u003d \u0027fake-iqn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_ef6316af","side":"PARENT","line":177,"in_reply_to":"bab6814e_340bb17e","updated":"2016-05-23 13:38:06.000000000","message":"+1","commit_id":"5123c755a90a3a5ad7c3f18ce5ed69b3e176777a"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"93d7cbd1c8a167f4afbf32a8dab4f27ee3bd099f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            node\u003dself.node, method\u003d\u0027standby.prepare_image\u0027,"},{"line_number":175,"context_line":"            params\u003dparams, wait\u003dFalse)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @mock.patch(\u0027uuid.uuid4\u0027, mock.MagicMock(spec_set\u003d[], return_value\u003d\u0027uuid\u0027))"},{"line_number":178,"context_line":"    def test_start_iscsi_target(self):"},{"line_number":179,"context_line":"        self.client._command \u003d mock.MagicMock(spec_set\u003d[])"},{"line_number":180,"context_line":"        iqn \u003d \u0027fake-iqn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_f40769c7","side":"PARENT","line":177,"in_reply_to":"bab6814e_516647ed","updated":"2016-05-23 13:27:27.000000000","message":"It was added in d87309e6 along with the rest of the test, but AFAICT it\u0027s not needed here.","commit_id":"5123c755a90a3a5ad7c3f18ce5ed69b3e176777a"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"875b2b06104f2afd38ace428484d31c0f807525b","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            node\u003dself.node, method\u003d\u0027standby.prepare_image\u0027,"},{"line_number":175,"context_line":"            params\u003dparams, wait\u003dFalse)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @mock.patch(\u0027uuid.uuid4\u0027, mock.MagicMock(spec_set\u003d[], return_value\u003d\u0027uuid\u0027))"},{"line_number":178,"context_line":"    def test_start_iscsi_target(self):"},{"line_number":179,"context_line":"        self.client._command \u003d mock.MagicMock(spec_set\u003d[])"},{"line_number":180,"context_line":"        iqn \u003d \u0027fake-iqn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_516647ed","side":"PARENT","line":177,"in_reply_to":"bab6814e_be2e62a2","updated":"2016-05-23 13:06:35.000000000","message":"I\u0027m a little confused why we don\u0027t need it for the new test, as far as I can see nothing has changed in the code that would stop this being required if it was required before.","commit_id":"5123c755a90a3a5ad7c3f18ce5ed69b3e176777a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8f924f59bd7e995925a6bc9169c2b2e78677eb8d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            node\u003dself.node, method\u003d\u0027standby.prepare_image\u0027,"},{"line_number":175,"context_line":"            params\u003dparams, wait\u003dFalse)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @mock.patch(\u0027uuid.uuid4\u0027, mock.MagicMock(spec_set\u003d[], return_value\u003d\u0027uuid\u0027))"},{"line_number":178,"context_line":"    def test_start_iscsi_target(self):"},{"line_number":179,"context_line":"        self.client._command \u003d mock.MagicMock(spec_set\u003d[])"},{"line_number":180,"context_line":"        iqn \u003d \u0027fake-iqn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_be2e62a2","side":"PARENT","line":177,"in_reply_to":"bab6814e_be6b0284","updated":"2016-05-23 13:04:06.000000000","message":"It is, I just wanted the following test looks similar, so I decided to remove it from here for consistency.","commit_id":"5123c755a90a3a5ad7c3f18ce5ed69b3e176777a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6b4680b76b7a1089360eb218620bd0b816ca8302","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            node\u003dself.node, method\u003d\u0027standby.prepare_image\u0027,"},{"line_number":175,"context_line":"            params\u003dparams, wait\u003dFalse)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @mock.patch(\u0027uuid.uuid4\u0027, mock.MagicMock(spec_set\u003d[], return_value\u003d\u0027uuid\u0027))"},{"line_number":178,"context_line":"    def test_start_iscsi_target(self):"},{"line_number":179,"context_line":"        self.client._command \u003d mock.MagicMock(spec_set\u003d[])"},{"line_number":180,"context_line":"        iqn \u003d \u0027fake-iqn\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_340bb17e","side":"PARENT","line":177,"in_reply_to":"bab6814e_f40769c7","updated":"2016-05-23 13:28:17.000000000","message":"I\u0027ll remove all the others in the followup, unless there are more things to fix here.","commit_id":"5123c755a90a3a5ad7c3f18ce5ed69b3e176777a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b5e8e9a0137bf80c5b692072a5140311190efacc","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        params \u003d {\u0027iqn\u0027: iqn, \u0027wipe_disk_metadata\u0027: True}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        self.client.start_iscsi_target(self.node, iqn, port,"},{"line_number":181,"context_line":"                                       wipe_disk_metadata)"},{"line_number":182,"context_line":"        self.client._command.assert_called_once_with("},{"line_number":183,"context_line":"            node\u003dself.node, method\u003d\u0027iscsi.start_iscsi_target\u0027,"},{"line_number":184,"context_line":"            params\u003dparams, wait\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_f8a86179","line":181,"updated":"2016-06-07 16:19:48.000000000","message":"just a nit, but it would be better to do \u0027wipe_disk_metadata\u003dwipe_disk_metadata\u0027.","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a268b78f06bb601aa06be273221293260a65346a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        params \u003d {\u0027iqn\u0027: iqn, \u0027wipe_disk_metadata\u0027: True}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        self.client.start_iscsi_target(self.node, iqn, port,"},{"line_number":181,"context_line":"                                       wipe_disk_metadata)"},{"line_number":182,"context_line":"        self.client._command.assert_called_once_with("},{"line_number":183,"context_line":"            node\u003dself.node, method\u003d\u0027iscsi.start_iscsi_target\u0027,"},{"line_number":184,"context_line":"            params\u003dparams, wait\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_b47a5d75","line":181,"in_reply_to":"7aa08908_f8a86179","updated":"2016-06-07 17:52:00.000000000","message":"Done","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b5e8e9a0137bf80c5b692072a5140311190efacc","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.client._command.assert_called_once_with("},{"line_number":183,"context_line":"            node\u003dself.node, method\u003d\u0027iscsi.start_iscsi_target\u0027,"},{"line_number":184,"context_line":"            params\u003dparams, wait\u003dTrue)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @mock.patch.object(agent_client, \u0027LOG\u0027)"},{"line_number":187,"context_line":"    def test_start_iscsi_target_old_agent_custom_options(self, log_mock):"},{"line_number":188,"context_line":"        self.client._command \u003d mock.MagicMock("}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_18f1ed95","line":185,"updated":"2016-06-07 16:19:48.000000000","message":"might be good to have another test with port !\u003d 3260","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6a960b9ebfac0d8f88afa27915e124c6318f5c65","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.client._command.assert_called_once_with("},{"line_number":183,"context_line":"            node\u003dself.node, method\u003d\u0027iscsi.start_iscsi_target\u0027,"},{"line_number":184,"context_line":"            params\u003dparams, wait\u003dTrue)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @mock.patch.object(agent_client, \u0027LOG\u0027)"},{"line_number":187,"context_line":"    def test_start_iscsi_target_old_agent_custom_options(self, log_mock):"},{"line_number":188,"context_line":"        self.client._command \u003d mock.MagicMock("}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_eff7eb88","line":185,"in_reply_to":"7aa08908_14b53130","updated":"2016-06-07 19:22:02.000000000","message":"no, i meant not 3260, since 3260 is the default value and that is tested above (line 176).","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a268b78f06bb601aa06be273221293260a65346a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.client._command.assert_called_once_with("},{"line_number":183,"context_line":"            node\u003dself.node, method\u003d\u0027iscsi.start_iscsi_target\u0027,"},{"line_number":184,"context_line":"            params\u003dparams, wait\u003dTrue)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @mock.patch.object(agent_client, \u0027LOG\u0027)"},{"line_number":187,"context_line":"    def test_start_iscsi_target_old_agent_custom_options(self, log_mock):"},{"line_number":188,"context_line":"        self.client._command \u003d mock.MagicMock("}],"source_content_type":"text/x-python","patch_set":21,"id":"7aa08908_14b53130","line":185,"in_reply_to":"7aa08908_18f1ed95","updated":"2016-06-07 17:52:00.000000000","message":"I think you meant \u003d\u003d 3260 :)","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f44cef100fd368aaff1e90916fd2d44fb485f65c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            params\u003dparams, wait\u003dTrue)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @mock.patch.object(agent_client, \u0027LOG\u0027)"},{"line_number":187,"context_line":"    def test_start_iscsi_target_old_agent_only_wipe(self, log_mock):"},{"line_number":188,"context_line":"        self.client._command \u003d mock.MagicMock("},{"line_number":189,"context_line":"            spec_set\u003d[],"},{"line_number":190,"context_line":"            side_effect\u003d["}],"source_content_type":"text/x-python","patch_set":23,"id":"7aa08908_cf0aef78","line":187,"updated":"2016-06-07 19:21:46.000000000","message":"Sorry, this test is good. but I was thinking of a test like the above test_start_iscsi_target, with the port \u003d eg 3100","commit_id":"387220eae05ffab0fec436df6edb2197b0009add"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"44c19a4a3a55a3d7d9abcbf4beeaf87b5fd2c091","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            params\u003dparams, wait\u003dTrue)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @mock.patch.object(agent_client, \u0027LOG\u0027)"},{"line_number":187,"context_line":"    def test_start_iscsi_target_old_agent_only_wipe(self, log_mock):"},{"line_number":188,"context_line":"        self.client._command \u003d mock.MagicMock("},{"line_number":189,"context_line":"            spec_set\u003d[],"},{"line_number":190,"context_line":"            side_effect\u003d["}],"source_content_type":"text/x-python","patch_set":23,"id":"7aa08908_a17fb264","line":187,"in_reply_to":"7aa08908_cf0aef78","updated":"2016-06-07 21:13:03.000000000","message":"Done","commit_id":"387220eae05ffab0fec436df6edb2197b0009add"}],"releasenotes/notes/fix-mitaka-ipa-iscsi.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e8acc525312e2d713a309aef870d6a2084aabd48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Fixed mitaka IPA ramdisk iSCSI deploy compatibility with newer versions"},{"line_number":4,"context_line":"    of ironic by adding [iscsi]wipe_disk_partitions ironic config option"},{"line_number":5,"context_line":"    (False by default) and do not pass extra parameters to IPA ramdisk if"},{"line_number":6,"context_line":"    they have default values. If you rely on the wiping root disk partitions"},{"line_number":7,"context_line":"    before exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9abb7d3a_37625717","line":4,"updated":"2016-06-02 19:38:54.000000000","message":"nit, this is in ironic, so s/ironic config/config/ is sufficient.","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7e93392f65523f153a6c98da2ed4951827621d51","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Fixed mitaka IPA ramdisk iSCSI deploy compatibility with newer versions"},{"line_number":4,"context_line":"    of ironic by adding [iscsi]wipe_disk_partitions ironic config option"},{"line_number":5,"context_line":"    (False by default) and do not pass extra parameters to IPA ramdisk if"},{"line_number":6,"context_line":"    they have default values. If you rely on the wiping root disk partitions"},{"line_number":7,"context_line":"    before exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9abb7d3a_c95510c7","line":4,"in_reply_to":"9abb7d3a_37625717","updated":"2016-06-03 09:23:49.000000000","message":"Done","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e8acc525312e2d713a309aef870d6a2084aabd48","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    (False by default) and do not pass extra parameters to IPA ramdisk if"},{"line_number":6,"context_line":"    they have default values. If you rely on the wiping root disk partitions"},{"line_number":7,"context_line":"    before exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions"},{"line_number":8,"context_line":"    to True in ironic config file and ensure that you are using at least newton"},{"line_number":9,"context_line":"    release of IPA in deploy ramdisk."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9abb7d3a_d72b0b93","line":8,"updated":"2016-06-02 19:38:54.000000000","message":"s/newton/Newton/","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7e93392f65523f153a6c98da2ed4951827621d51","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    (False by default) and do not pass extra parameters to IPA ramdisk if"},{"line_number":6,"context_line":"    they have default values. If you rely on the wiping root disk partitions"},{"line_number":7,"context_line":"    before exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions"},{"line_number":8,"context_line":"    to True in ironic config file and ensure that you are using at least newton"},{"line_number":9,"context_line":"    release of IPA in deploy ramdisk."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9abb7d3a_095ef8e8","line":8,"in_reply_to":"9abb7d3a_d72b0b93","updated":"2016-06-03 09:23:49.000000000","message":"Done","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e8acc525312e2d713a309aef870d6a2084aabd48","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    they have default values. If you rely on the wiping root disk partitions"},{"line_number":7,"context_line":"    before exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions"},{"line_number":8,"context_line":"    to True in ironic config file and ensure that you are using at least newton"},{"line_number":9,"context_line":"    release of IPA in deploy ramdisk."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9abb7d3a_4a0db236","line":9,"updated":"2016-06-02 19:38:54.000000000","message":"have we released a Newton-IPA yet? Doesn\u0027t look like it. Maybe add \u0027(1.3 or higher)\u0027 since 1.3 will be the release version.","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7e93392f65523f153a6c98da2ed4951827621d51","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    they have default values. If you rely on the wiping root disk partitions"},{"line_number":7,"context_line":"    before exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions"},{"line_number":8,"context_line":"    to True in ironic config file and ensure that you are using at least newton"},{"line_number":9,"context_line":"    release of IPA in deploy ramdisk."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9abb7d3a_495800fb","line":9,"in_reply_to":"9abb7d3a_4a0db236","updated":"2016-06-03 09:23:49.000000000","message":"Done","commit_id":"b014e62a7995f3a2150cd1f0f04d557d330fe4f9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fc896de92ae0598844566343671873da14a87a05","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Fixed mitaka IPA ramdisk iSCSI deploy compatibility with newer versions"},{"line_number":4,"context_line":"    of ironic by adding [iscsi]wipe_disk_partitions config option (False by"},{"line_number":5,"context_line":"    default) and do not pass extra parameters to IPA ramdisk if they have"},{"line_number":6,"context_line":"    default values. If you rely on the wiping root disk partitions before"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9abb7d3a_1b457ab2","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":16},"updated":"2016-06-03 18:24:18.000000000","message":"s/mitaka/Mitaka/","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2b643f214ba247f85506ae315efb1b1a90a8a2df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Fixed mitaka IPA ramdisk iSCSI deploy compatibility with newer versions"},{"line_number":4,"context_line":"    of ironic by adding [iscsi]wipe_disk_partitions config option (False by"},{"line_number":5,"context_line":"    default) and do not pass extra parameters to IPA ramdisk if they have"},{"line_number":6,"context_line":"    default values. If you rely on the wiping root disk partitions before"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7aa08908_7257c902","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":16},"in_reply_to":"9abb7d3a_1b457ab2","updated":"2016-06-06 11:12:19.000000000","message":"Done","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fc896de92ae0598844566343671873da14a87a05","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    default) and do not pass extra parameters to IPA ramdisk if they have"},{"line_number":6,"context_line":"    default values. If you rely on the wiping root disk partitions before"},{"line_number":7,"context_line":"    exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions to"},{"line_number":8,"context_line":"    True in ironic config file and ensure that you are using at least Newton"},{"line_number":9,"context_line":"    (1.3 or higher) release of IPA in deploy ramdisk. This option will be"},{"line_number":10,"context_line":"    removed in the Ocata release and root disk partitions will be wiped by"},{"line_number":11,"context_line":"    defualt before iSCSI target start, forcing operators to update the deploy"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9abb7d3a_5602390a","line":8,"range":{"start_line":8,"start_character":12,"end_line":8,"end_character":18},"updated":"2016-06-03 18:24:18.000000000","message":"s/ironic/the/","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2b643f214ba247f85506ae315efb1b1a90a8a2df","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    default) and do not pass extra parameters to IPA ramdisk if they have"},{"line_number":6,"context_line":"    default values. If you rely on the wiping root disk partitions before"},{"line_number":7,"context_line":"    exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions to"},{"line_number":8,"context_line":"    True in ironic config file and ensure that you are using at least Newton"},{"line_number":9,"context_line":"    (1.3 or higher) release of IPA in deploy ramdisk. This option will be"},{"line_number":10,"context_line":"    removed in the Ocata release and root disk partitions will be wiped by"},{"line_number":11,"context_line":"    defualt before iSCSI target start, forcing operators to update the deploy"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7aa08908_525c4d25","line":8,"range":{"start_line":8,"start_character":12,"end_line":8,"end_character":18},"in_reply_to":"9abb7d3a_5602390a","updated":"2016-06-06 11:12:19.000000000","message":"Done","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fc896de92ae0598844566343671873da14a87a05","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    default values. If you rely on the wiping root disk partitions before"},{"line_number":7,"context_line":"    exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions to"},{"line_number":8,"context_line":"    True in ironic config file and ensure that you are using at least Newton"},{"line_number":9,"context_line":"    (1.3 or higher) release of IPA in deploy ramdisk. This option will be"},{"line_number":10,"context_line":"    removed in the Ocata release and root disk partitions will be wiped by"},{"line_number":11,"context_line":"    defualt before iSCSI target start, forcing operators to update the deploy"},{"line_number":12,"context_line":"    images when they upgrade ironic."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9abb7d3a_f641ad3a","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":45},"updated":"2016-06-03 18:24:18.000000000","message":"in the deploy","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2b643f214ba247f85506ae315efb1b1a90a8a2df","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    default values. If you rely on the wiping root disk partitions before"},{"line_number":7,"context_line":"    exposing it over iSCSI, you should set [iscsi]wipe_disk_partitions to"},{"line_number":8,"context_line":"    True in ironic config file and ensure that you are using at least Newton"},{"line_number":9,"context_line":"    (1.3 or higher) release of IPA in deploy ramdisk. This option will be"},{"line_number":10,"context_line":"    removed in the Ocata release and root disk partitions will be wiped by"},{"line_number":11,"context_line":"    defualt before iSCSI target start, forcing operators to update the deploy"},{"line_number":12,"context_line":"    images when they upgrade ironic."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7aa08908_b241313c","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":45},"in_reply_to":"9abb7d3a_f641ad3a","updated":"2016-06-06 11:12:19.000000000","message":"Done","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fc896de92ae0598844566343671873da14a87a05","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    True in ironic config file and ensure that you are using at least Newton"},{"line_number":9,"context_line":"    (1.3 or higher) release of IPA in deploy ramdisk. This option will be"},{"line_number":10,"context_line":"    removed in the Ocata release and root disk partitions will be wiped by"},{"line_number":11,"context_line":"    defualt before iSCSI target start, forcing operators to update the deploy"},{"line_number":12,"context_line":"    images when they upgrade ironic."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9abb7d3a_1ba9fa7b","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":11},"updated":"2016-06-03 18:24:18.000000000","message":"s/defualt/default/","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2b643f214ba247f85506ae315efb1b1a90a8a2df","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    True in ironic config file and ensure that you are using at least Newton"},{"line_number":9,"context_line":"    (1.3 or higher) release of IPA in deploy ramdisk. This option will be"},{"line_number":10,"context_line":"    removed in the Ocata release and root disk partitions will be wiped by"},{"line_number":11,"context_line":"    defualt before iSCSI target start, forcing operators to update the deploy"},{"line_number":12,"context_line":"    images when they upgrade ironic."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7aa08908_923eb5b6","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":11},"in_reply_to":"9abb7d3a_1ba9fa7b","updated":"2016-06-06 11:12:19.000000000","message":"Done","commit_id":"a4376a51189ff1fe126afcb07971d768232a200b"},{"author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"change_message_id":"11ff30945315aaf2268694f6afa64a807191d52f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Fixed Mitaka ironic python agent ramdisk iSCSI deploy compatibility with"},{"line_number":4,"context_line":"    newer versions of ironic by loggnig the warning and retrying the deploy if"},{"line_number":5,"context_line":"    wiping root disk metadata before exposing it over iSCSI fails. If custom"},{"line_number":6,"context_line":"    iSCSI port is requested, an error clarifying the issue is logged and the"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7aa08908_4d2d75fd","line":3,"range":{"start_line":3,"start_character":36,"end_line":3,"end_character":37},"updated":"2016-06-07 16:01:41.000000000","message":"2 spaces?","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cba9e1dcc6bf633139108cc3d82ec64aa1bbcdfd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Fixed Mitaka ironic python agent ramdisk iSCSI deploy compatibility with"},{"line_number":4,"context_line":"    newer versions of ironic by loggnig the warning and retrying the deploy if"},{"line_number":5,"context_line":"    wiping root disk metadata before exposing it over iSCSI fails. If custom"},{"line_number":6,"context_line":"    iSCSI port is requested, an error clarifying the issue is logged and the"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7aa08908_382dc995","line":3,"range":{"start_line":3,"start_character":36,"end_line":3,"end_character":37},"in_reply_to":"7aa08908_4d2d75fd","updated":"2016-06-07 16:09:12.000000000","message":"Don\u0027t see it","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"change_message_id":"11ff30945315aaf2268694f6afa64a807191d52f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Fixed Mitaka ironic python agent ramdisk iSCSI deploy compatibility with"},{"line_number":4,"context_line":"    newer versions of ironic by loggnig the warning and retrying the deploy if"},{"line_number":5,"context_line":"    wiping root disk metadata before exposing it over iSCSI fails. If custom"},{"line_number":6,"context_line":"    iSCSI port is requested, an error clarifying the issue is logged and the"},{"line_number":7,"context_line":"    operator is requested either to use the default iSCSI portal port, or to"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7aa08908_cd4165ab","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":39},"updated":"2016-06-07 16:01:41.000000000","message":"logging","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cba9e1dcc6bf633139108cc3d82ec64aa1bbcdfd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Fixed Mitaka ironic python agent ramdisk iSCSI deploy compatibility with"},{"line_number":4,"context_line":"    newer versions of ironic by loggnig the warning and retrying the deploy if"},{"line_number":5,"context_line":"    wiping root disk metadata before exposing it over iSCSI fails. If custom"},{"line_number":6,"context_line":"    iSCSI port is requested, an error clarifying the issue is logged and the"},{"line_number":7,"context_line":"    operator is requested either to use the default iSCSI portal port, or to"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7aa08908_1861edd3","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":39},"in_reply_to":"7aa08908_cd4165ab","updated":"2016-06-07 16:09:12.000000000","message":"I\u0027d fix it in a followup if there are no more things here, as grenade run started, if I upload a new change, it will be cancelled again.","commit_id":"afad7dd6628bc19efa95c5bb67b974ae41a41c06"}]}
