)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"557965594c651c148c4ace26b7a875cdf13993b4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move create-node.sh to create_vms func"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is not possible to access to env variables from"},{"line_number":10,"context_line":"create-nodes.sh script. Due to it we need to pass every"},{"line_number":11,"context_line":"new variable to scrip via parameter."},{"line_number":12,"context_line":"It makes implementation of new features that require to"},{"line_number":13,"context_line":"change create-node logic very hard."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abb7d3a_beb2f349","line":10,"updated":"2016-06-01 14:48:52.000000000","message":"It\u0027s not impossible, but it requires us to export all these variables. Still, I find it\u0027s easier to work with this bash code if it\u0027s in one file, so I agree with this change.","commit_id":"06fd18a8dfc35fe9371fb68ef6ae28a44de62b55"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ece57236903ece77c0931a9a7114b541442569b4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"change create-node logic very hard."},{"line_number":14,"context_line":"This patch moves create-node.sh logic into devstack/lib/ironic"},{"line_number":15,"context_line":"create_vms function."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iea1ef16629497026917fa28ce4baa359ac024148"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_20ca0450","line":16,"updated":"2016-06-10 00:17:49.000000000","message":"Maybe:\n\n    Move create-node.sh to create_vms function\n    \n    It is not possible to access environment variables from the\n    create-nodes.sh script. Due to that we need to pass every needed\n    variable to the script via a parameter.  It makes implementation of\n    new features that require changes to create-node logic very hard.\n    \n    This patch moves create-node.sh logic into devstack/lib/ironic\n    create_vms function.","commit_id":"06fd18a8dfc35fe9371fb68ef6ae28a44de62b55"}],"devstack/lib/ironic":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed1f856c7d67fc7b19e54a6f6a7a2bd302f12b72","unresolved":false,"context_lines":[{"line_number":762,"context_line":"}"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"function create_vms {"},{"line_number":765,"context_line":"    LIBVIRT_NIC_DRIVER\u003d${LIBVIRT_NIC_DRIVER:-\"virtio\"}"},{"line_number":766,"context_line":"    LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":767,"context_line":"    LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":768,"context_line":"    export VIRSH_DEFAULT_CONNECT_URI\u003d$LIBVIRT_CONNECT_URI"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9abb7d3a_f797cb45","line":765,"updated":"2016-05-31 12:26:52.000000000","message":"probably this variables should be moved to the top of the file.","commit_id":"d3ff506f6418947cf24f29a33d0c242b2ac95acf"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed1f856c7d67fc7b19e54a6f6a7a2bd302f12b72","unresolved":false,"context_lines":[{"line_number":765,"context_line":"    LIBVIRT_NIC_DRIVER\u003d${LIBVIRT_NIC_DRIVER:-\"virtio\"}"},{"line_number":766,"context_line":"    LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":767,"context_line":"    LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":768,"context_line":"    export VIRSH_DEFAULT_CONNECT_URI\u003d$LIBVIRT_CONNECT_URI"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    local vm_name\u003d$1"},{"line_number":771,"context_line":"    local vm_vbmc_port\u003d$2"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9abb7d3a_d7c9e75a","line":768,"updated":"2016-05-31 12:26:52.000000000","message":"it seems this export is not used","commit_id":"d3ff506f6418947cf24f29a33d0c242b2ac95acf"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"180cf247558edbf892481372e4943a28fe7cd1ca","unresolved":false,"context_lines":[{"line_number":764,"context_line":"function create_vms {"},{"line_number":765,"context_line":"    LIBVIRT_NIC_DRIVER\u003d${LIBVIRT_NIC_DRIVER:-\"virtio\"}"},{"line_number":766,"context_line":"    LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":767,"context_line":"    LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    local vm_name\u003d$1"},{"line_number":770,"context_line":"    local vm_vbmc_port\u003d$2"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7aa08908_80d77822","line":767,"updated":"2016-06-10 00:14:14.000000000","message":"This isn\u0027t used because the export was dropped from patchset 2.\n\nMaybe it should have as the next line:\n\n export LIBVIRT_DEFAULT_URI\u003d${LIBVIRT_CONNECT_URI}\n\nAnd probably a comment so people don\u0027t delete it.\n\nReference: https://libvirt.org/uri.html#URI_virsh","commit_id":"06fd18a8dfc35fe9371fb68ef6ae28a44de62b55"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a9e5277b817bb9b89deb00f260585454f757f3eb","unresolved":false,"context_lines":[{"line_number":764,"context_line":"function create_vms {"},{"line_number":765,"context_line":"    LIBVIRT_NIC_DRIVER\u003d${LIBVIRT_NIC_DRIVER:-\"virtio\"}"},{"line_number":766,"context_line":"    LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":767,"context_line":"    LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    local vm_name\u003d$1"},{"line_number":770,"context_line":"    local vm_vbmc_port\u003d$2"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7aa08908_91f7c1f4","line":767,"in_reply_to":"7aa08908_80d77822","updated":"2016-06-10 11:02:31.000000000","message":"John, it looks that this variable wasn\u0027t work, for a long time. Since libvirt looking for LIBVIRT_DEFAULT_URI. What do you think if we just drop it as it is not used?","commit_id":"06fd18a8dfc35fe9371fb68ef6ae28a44de62b55"}],"devstack/tools/ironic/scripts/create-node.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"180cf247558edbf892481372e4943a28fe7cd1ca","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":27,"context_line":"LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export VIRSH_DEFAULT_CONNECT_URI\u003d$LIBVIRT_CONNECT_URI"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if ! virsh pool-list --all | grep -q $LIBVIRT_STORAGE_POOL; then"},{"line_number":32,"context_line":"    virsh pool-define-as --name $LIBVIRT_STORAGE_POOL dir --target /var/lib/libvirt/images \u003e\u00262"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7aa08908_a02b9432","side":"PARENT","line":29,"updated":"2016-06-10 00:14:14.000000000","message":"So this should remain or export LIBVIRT_DEFAULT_URI\n\nhttps://libvirt.org/uri.html#URI_virsh","commit_id":"8a7f4dfcb55b1dc15b1b86844e432a30da9c9078"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a9e5277b817bb9b89deb00f260585454f757f3eb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":27,"context_line":"LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export VIRSH_DEFAULT_CONNECT_URI\u003d$LIBVIRT_CONNECT_URI"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if ! virsh pool-list --all | grep -q $LIBVIRT_STORAGE_POOL; then"},{"line_number":32,"context_line":"    virsh pool-define-as --name $LIBVIRT_STORAGE_POOL dir --target /var/lib/libvirt/images \u003e\u00262"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7aa08908_d164a9e6","side":"PARENT","line":29,"in_reply_to":"7aa08908_a02b9432","updated":"2016-06-10 11:02:31.000000000","message":"I don\u0027t see that VIRSH_DEFAULT_CONNECT_URI is used anywhere in the code. And according to documentation the variable name should be LIBVIRT_DEFAULT_URI. Since this didn\u0027t work for a long time, might be it makes sense to drop it, since nobody uses it?","commit_id":"8a7f4dfcb55b1dc15b1b86844e432a30da9c9078"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"84f19653cbe897bbafbd83495e73ba72a6f787c6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":27,"context_line":"LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export VIRSH_DEFAULT_CONNECT_URI\u003d$LIBVIRT_CONNECT_URI"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if ! virsh pool-list --all | grep -q $LIBVIRT_STORAGE_POOL; then"},{"line_number":32,"context_line":"    virsh pool-define-as --name $LIBVIRT_STORAGE_POOL dir --target /var/lib/libvirt/images \u003e\u00262"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7aa08908_14e28e01","side":"PARENT","line":29,"in_reply_to":"7aa08908_d164a9e6","updated":"2016-06-10 13:57:39.000000000","message":"The docs for virsh say that it will use VIRSH_DEFAULT_CONNECT_URI but that it has been deprecated and should use the LIBVIRT_DEFAULT_URI instead.\n\nThis is used when any call to \u0027virsh\u0027 is made. So it is used in that sense. Unsure if it is needed though.","commit_id":"8a7f4dfcb55b1dc15b1b86844e432a30da9c9078"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"90a8dd284981c9855839586252c36003b2e2a125","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LIBVIRT_NIC_DRIVER\u003d${LIBVIRT_NIC_DRIVER:-\"virtio\"}"},{"line_number":26,"context_line":"LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":27,"context_line":"LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export VIRSH_DEFAULT_CONNECT_URI\u003d$LIBVIRT_CONNECT_URI"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7aa08908_3d9ac26e","side":"PARENT","line":27,"updated":"2016-06-13 14:10:23.000000000","message":"This line has disappeared","commit_id":"8a7f4dfcb55b1dc15b1b86844e432a30da9c9078"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"12cc3a7dbef3cabc7852a95e7ddf9d44236cd0bc","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LIBVIRT_NIC_DRIVER\u003d${LIBVIRT_NIC_DRIVER:-\"virtio\"}"},{"line_number":26,"context_line":"LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":27,"context_line":"LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export VIRSH_DEFAULT_CONNECT_URI\u003d$LIBVIRT_CONNECT_URI"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7aa08908_5fbe98ae","side":"PARENT","line":27,"in_reply_to":"7aa08908_3d9ac26e","updated":"2016-06-13 18:23:41.000000000","message":"virsh will fallback to uri_default config parameter if LIBVIRT_DEFAULT_URI is not set. Please have look at /etc/libvirt/libvirt.conf. The uri_default is set to qemu:///system by default.","commit_id":"8a7f4dfcb55b1dc15b1b86844e432a30da9c9078"}]}
