)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7bd9409e447b0c776f02bef409e7debf5bb0ad70","unresolved":false,"context_lines":[{"line_number":7,"context_line":"adding back the inspect_ports as an optional parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit I37eb1dda649d4d21681555339c9ece8a18216f95"},{"line_number":10,"context_line":"which introduced a bug 1588177. Which will add back the"},{"line_number":11,"context_line":"inspect_ports as an optional parameter in ilo."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: 1588177"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_0139b1a3","line":11,"range":{"start_line":10,"start_character":32,"end_line":11,"end_character":45},"updated":"2016-06-16 12:44:59.000000000","message":"Most a nit: Can we briefly extend this to explain why reverting this commit is important?","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"04ef894f1504b5473e5e8a4fd93e29685aef2ca2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"adding back the inspect_ports as an optional parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit I37eb1dda649d4d21681555339c9ece8a18216f95"},{"line_number":10,"context_line":"which introduced a bug 1588177. Which will add back the"},{"line_number":11,"context_line":"inspect_ports as an optional parameter in ilo."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: 1588177"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_b4dbba20","line":11,"range":{"start_line":10,"start_character":32,"end_line":11,"end_character":45},"in_reply_to":"7aa08908_0139b1a3","updated":"2016-06-21 12:17:49.000000000","message":"Done","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":20,"context_line":"choose/specify if they want the port to be created for"},{"line_number":21,"context_line":"all the NICs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-bug: 1588177"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I6ef017cd0837a419beee2025b6e8232e685b58c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3aaa91ec_d0268015","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":19},"updated":"2016-06-22 08:05:01.000000000","message":"I suppose this should be RFE.","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"choose/specify if they want the port to be created for"},{"line_number":21,"context_line":"all the NICs."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-bug: 1588177"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I6ef017cd0837a419beee2025b6e8232e685b58c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3aaa91ec_b942740e","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":19},"in_reply_to":"3aaa91ec_d0268015","updated":"2016-06-29 11:30:47.000000000","message":"it is a bug, as it was implemented earlier but deleted afterwards","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"}],"doc/source/drivers/ilo.rst":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6f0a6a069af84ddf054c318b7a742f3b38166ea7","unresolved":false,"context_lines":[{"line_number":292,"context_line":"  using a custom port on the iLO.  Default port used is 443."},{"line_number":293,"context_line":"- ``client_timeout``: (optional) Timeout for iLO operations. Default timeout"},{"line_number":294,"context_line":"  is 60 seconds."},{"line_number":295,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to "},{"line_number":296,"context_line":"  be identified for creating node ports. Valid values may be inspect_ports \u003d \u00271,2,...n\u0027 or"},{"line_number":297,"context_line":"  inspect_ports \u003d \u0027all\u0027 or inspect_ports \u003d \u0027none\u0027. Required only for inspection."},{"line_number":298,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_7cb10901","line":295,"range":{"start_line":295,"start_character":75,"end_line":295,"end_character":76},"updated":"2016-06-29 12:03:19.000000000","message":"whitespace","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"c8210e880cc2bf5d461e92402d806cf7678dda21","unresolved":false,"context_lines":[{"line_number":292,"context_line":"  using a custom port on the iLO.  Default port used is 443."},{"line_number":293,"context_line":"- ``client_timeout``: (optional) Timeout for iLO operations. Default timeout"},{"line_number":294,"context_line":"  is 60 seconds."},{"line_number":295,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to "},{"line_number":296,"context_line":"  be identified for creating node ports. Valid values may be inspect_ports \u003d \u00271,2,...n\u0027 or"},{"line_number":297,"context_line":"  inspect_ports \u003d \u0027all\u0027 or inspect_ports \u003d \u0027none\u0027. Required only for inspection."},{"line_number":298,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_be0933df","line":295,"range":{"start_line":295,"start_character":75,"end_line":295,"end_character":76},"in_reply_to":"3aaa91ec_7cb10901","updated":"2016-07-01 09:45:19.000000000","message":"Done","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6f0a6a069af84ddf054c318b7a742f3b38166ea7","unresolved":false,"context_lines":[{"line_number":293,"context_line":"- ``client_timeout``: (optional) Timeout for iLO operations. Default timeout"},{"line_number":294,"context_line":"  is 60 seconds."},{"line_number":295,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to "},{"line_number":296,"context_line":"  be identified for creating node ports. Valid values may be inspect_ports \u003d \u00271,2,...n\u0027 or"},{"line_number":297,"context_line":"  inspect_ports \u003d \u0027all\u0027 or inspect_ports \u003d \u0027none\u0027. Required only for inspection."},{"line_number":298,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":299,"context_line":"  port on the ironic conductor node may be used."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_7ca8e98c","line":296,"updated":"2016-06-29 12:03:19.000000000","message":"what this numbers means? port number eg eth1, eth2, eth3?","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"c8210e880cc2bf5d461e92402d806cf7678dda21","unresolved":false,"context_lines":[{"line_number":293,"context_line":"- ``client_timeout``: (optional) Timeout for iLO operations. Default timeout"},{"line_number":294,"context_line":"  is 60 seconds."},{"line_number":295,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to "},{"line_number":296,"context_line":"  be identified for creating node ports. Valid values may be inspect_ports \u003d \u00271,2,...n\u0027 or"},{"line_number":297,"context_line":"  inspect_ports \u003d \u0027all\u0027 or inspect_ports \u003d \u0027none\u0027. Required only for inspection."},{"line_number":298,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":299,"context_line":"  port on the ironic conductor node may be used."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_3ef6e3d6","line":296,"in_reply_to":"3aaa91ec_7ca8e98c","updated":"2016-07-01 09:45:19.000000000","message":"yes","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":294,"context_line":"  is 60 seconds."},{"line_number":295,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to "},{"line_number":296,"context_line":"  be identified for creating node ports. Valid values may be inspect_ports \u003d \u00271,2,...n\u0027 or"},{"line_number":297,"context_line":"  inspect_ports \u003d \u0027all\u0027 or inspect_ports \u003d \u0027none\u0027. Required only for inspection."},{"line_number":298,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":299,"context_line":"  port on the ironic conductor node may be used."},{"line_number":300,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_30654445","line":297,"range":{"start_line":297,"start_character":18,"end_line":297,"end_character":49},"updated":"2016-06-22 08:05:01.000000000","message":"Need to add a note on  how the special words \u0027all\u0027 and \u0027none\u0027 interpreted by the driver.","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":294,"context_line":"  is 60 seconds."},{"line_number":295,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to "},{"line_number":296,"context_line":"  be identified for creating node ports. Valid values may be inspect_ports \u003d \u00271,2,...n\u0027 or"},{"line_number":297,"context_line":"  inspect_ports \u003d \u0027all\u0027 or inspect_ports \u003d \u0027none\u0027. Required only for inspection."},{"line_number":298,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":299,"context_line":"  port on the ironic conductor node may be used."},{"line_number":300,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_5e21ddfb","line":297,"range":{"start_line":297,"start_character":18,"end_line":297,"end_character":49},"in_reply_to":"3aaa91ec_30654445","updated":"2016-06-29 11:30:47.000000000","message":"Done","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":434,"context_line":"  is 60 seconds."},{"line_number":435,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to"},{"line_number":436,"context_line":"  be identified for creating node ports. Valid values may be inspect_ports \u003d \u00271,2,...n\u0027 or"},{"line_number":437,"context_line":"  inspect_ports \u003d \u0027all\u0027 or inspect_ports \u003d \u0027none\u0027. Required only for inspection."},{"line_number":438,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":439,"context_line":"  port on the ironic conductor node may be used."},{"line_number":440,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_3917efa4","line":437,"range":{"start_line":437,"start_character":18,"end_line":437,"end_character":50},"updated":"2016-06-22 08:05:01.000000000","message":"ditto.","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":434,"context_line":"  is 60 seconds."},{"line_number":435,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to"},{"line_number":436,"context_line":"  be identified for creating node ports. Valid values may be inspect_ports \u003d \u00271,2,...n\u0027 or"},{"line_number":437,"context_line":"  inspect_ports \u003d \u0027all\u0027 or inspect_ports \u003d \u0027none\u0027. Required only for inspection."},{"line_number":438,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":439,"context_line":"  port on the ironic conductor node may be used."},{"line_number":440,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3aaa91ec_fe7889fa","line":437,"range":{"start_line":437,"start_character":18,"end_line":437,"end_character":50},"in_reply_to":"3aaa91ec_3917efa4","updated":"2016-06-29 11:30:47.000000000","message":"Done","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":299,"context_line":"- ``client_timeout``: (optional) Timeout for iLO operations. Default timeout"},{"line_number":300,"context_line":"  is 60 seconds."},{"line_number":301,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to"},{"line_number":302,"context_line":"  be identified for creating node ports. Valid values for this option are"},{"line_number":303,"context_line":"  ``inspect_ports\u003d[1,2,3,..n]`` or ``inspect_ports\u003d\u0027all\u0027``, which will"},{"line_number":304,"context_line":"  create node ports for all the discovered nic ports or"},{"line_number":305,"context_line":"  ``inspect_ports\u003d\u0027none\u0027``, which will not create any node ports. Required"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7ffa3b31_26a5efb5","line":302,"range":{"start_line":302,"start_character":29,"end_line":302,"end_character":33},"updated":"2017-04-19 09:31:30.000000000","message":"s/ node / Ironic /","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":300,"context_line":"  is 60 seconds."},{"line_number":301,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to"},{"line_number":302,"context_line":"  be identified for creating node ports. Valid values for this option are"},{"line_number":303,"context_line":"  ``inspect_ports\u003d[1,2,3,..n]`` or ``inspect_ports\u003d\u0027all\u0027``, which will"},{"line_number":304,"context_line":"  create node ports for all the discovered nic ports or"},{"line_number":305,"context_line":"  ``inspect_ports\u003d\u0027none\u0027``, which will not create any node ports. Required"},{"line_number":306,"context_line":"  only for node inspection. Default option will be set to ``all``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7ffa3b31_a690df4f","line":303,"range":{"start_line":303,"start_character":37,"end_line":303,"end_character":51},"updated":"2017-04-19 09:31:30.000000000","message":"s/ \u0027inspect_ports\u003d\u0027 //","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":300,"context_line":"  is 60 seconds."},{"line_number":301,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to"},{"line_number":302,"context_line":"  be identified for creating node ports. Valid values for this option are"},{"line_number":303,"context_line":"  ``inspect_ports\u003d[1,2,3,..n]`` or ``inspect_ports\u003d\u0027all\u0027``, which will"},{"line_number":304,"context_line":"  create node ports for all the discovered nic ports or"},{"line_number":305,"context_line":"  ``inspect_ports\u003d\u0027none\u0027``, which will not create any node ports. Required"},{"line_number":306,"context_line":"  only for node inspection. Default option will be set to ``all``."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7ffa3b31_c6952b42","line":303,"range":{"start_line":303,"start_character":4,"end_line":303,"end_character":18},"updated":"2017-04-19 09:31:30.000000000","message":"s/ \u0027inspect_ports\u003d\u0027 //","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":302,"context_line":"  be identified for creating node ports. Valid values for this option are"},{"line_number":303,"context_line":"  ``inspect_ports\u003d[1,2,3,..n]`` or ``inspect_ports\u003d\u0027all\u0027``, which will"},{"line_number":304,"context_line":"  create node ports for all the discovered nic ports or"},{"line_number":305,"context_line":"  ``inspect_ports\u003d\u0027none\u0027``, which will not create any node ports. Required"},{"line_number":306,"context_line":"  only for node inspection. Default option will be set to ``all``."},{"line_number":307,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":308,"context_line":"  port on the ironic conductor node may be used."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7ffa3b31_468b5b1e","line":305,"range":{"start_line":305,"start_character":4,"end_line":305,"end_character":18},"updated":"2017-04-19 09:31:30.000000000","message":"s/ \u0027inspect_ports\u003d\u0027 //","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":303,"context_line":"  ``inspect_ports\u003d[1,2,3,..n]`` or ``inspect_ports\u003d\u0027all\u0027``, which will"},{"line_number":304,"context_line":"  create node ports for all the discovered nic ports or"},{"line_number":305,"context_line":"  ``inspect_ports\u003d\u0027none\u0027``, which will not create any node ports. Required"},{"line_number":306,"context_line":"  only for node inspection. Default option will be set to ``all``."},{"line_number":307,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":308,"context_line":"  port on the ironic conductor node may be used."},{"line_number":309,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7ffa3b31_069af361","line":306,"range":{"start_line":306,"start_character":43,"end_line":306,"end_character":57},"updated":"2017-04-19 09:31:30.000000000","message":"s/ \u0027will be set to ``all`` \u0027/ \u0027used is ``all`` \u0027","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":461,"context_line":"  using a custom port on the iLO.  Default port used is 443."},{"line_number":462,"context_line":"- ``client_timeout``: (optional) Timeout for iLO operations. Default timeout"},{"line_number":463,"context_line":"  is 60 seconds."},{"line_number":464,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to"},{"line_number":465,"context_line":"  be identified for creating node ports. Valid values for this option are"},{"line_number":466,"context_line":"  ``inspect_ports\u003d[1,2,3,..n]`` or ``inspect_ports\u003d\u0027all\u0027``, which will"},{"line_number":467,"context_line":"  create node ports for all the discovered nic ports or"},{"line_number":468,"context_line":"  ``inspect_ports\u003d\u0027none\u0027``, which will not create any node ports. Required"},{"line_number":469,"context_line":"  only for node inspection. Default option will be set to ``all``."},{"line_number":470,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":471,"context_line":"  port on the ironic conductor node may be used."},{"line_number":472,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7ffa3b31_e69ca75e","line":469,"range":{"start_line":464,"start_character":2,"end_line":469,"end_character":65},"updated":"2017-04-19 09:31:30.000000000","message":"ditto","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":604,"context_line":"  using a custom port on the iLO. Default port used is 443."},{"line_number":605,"context_line":"- ``client_timeout``: (optional) Timeout for iLO operations. Default timeout"},{"line_number":606,"context_line":"  is 60 seconds."},{"line_number":607,"context_line":"- ``inspect_ports``: (optional) Comma-separated values of ethernet ports to"},{"line_number":608,"context_line":"  be identified for creating node ports. Valid values for this option are"},{"line_number":609,"context_line":"  ``inspect_ports\u003d[1,2,3,..n]`` or ``inspect_ports\u003d\u0027all\u0027``, which will"},{"line_number":610,"context_line":"  create node ports for all the discovered nic ports or"},{"line_number":611,"context_line":"  ``inspect_ports\u003d\u0027none\u0027``, which will not create any node ports. Required"},{"line_number":612,"context_line":"  only for node inspection. Default option will be set to ``all``."},{"line_number":613,"context_line":"- ``console_port``: (optional) Node\u0027s UDP port for console access. Any unused"},{"line_number":614,"context_line":"  port on the ironic conductor node may be used."},{"line_number":615,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7ffa3b31_a69e9f51","line":612,"range":{"start_line":607,"start_character":2,"end_line":612,"end_character":65},"updated":"2017-04-19 09:31:30.000000000","message":"ditto","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7bd9409e447b0c776f02bef409e7debf5bb0ad70","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                      \"console access.\")"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":"INSPECT_PROPERTIES \u003d {"},{"line_number":96,"context_line":"    \u0027inspect_ports\u0027: _(\"Comma-separated values of ethernet ports \""},{"line_number":97,"context_line":"                       \"to be identified for creating node \""},{"line_number":98,"context_line":"                       \"ports. Valid values may be \""},{"line_number":99,"context_line":"                       \"inspect_ports \u003d \u00271,2,...n\u0027 or \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_6159958e","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":46},"updated":"2016-06-16 12:44:59.000000000","message":"Ironic API now does accept a proper list as value of an attribute. Perhaps we should use that? I understand this is a revert, but it\u0027s a revert from 1+ year ago so I think we should use the \"new goodies\".","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"fecf46aaf3cdb5330b5a5a7b11562a47d60d4cb6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                      \"console access.\")"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":"INSPECT_PROPERTIES \u003d {"},{"line_number":96,"context_line":"    \u0027inspect_ports\u0027: _(\"Comma-separated values of ethernet ports \""},{"line_number":97,"context_line":"                       \"to be identified for creating node \""},{"line_number":98,"context_line":"                       \"ports. Valid values may be \""},{"line_number":99,"context_line":"                       \"inspect_ports \u003d \u00271,2,...n\u0027 or \""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_bd3657b2","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":46},"in_reply_to":"7aa08908_6159958e","updated":"2016-07-17 17:48:34.000000000","message":"implemented list to take the inspect_ports value","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                       \"to be identified for creating node \""},{"line_number":98,"context_line":"                       \"ports. Valid values may be \""},{"line_number":99,"context_line":"                       \"inspect_ports \u003d \u00271,2,...n\u0027 or \""},{"line_number":100,"context_line":"                       \"inspect_ports \u003d \u0027all\u0027 or \""},{"line_number":101,"context_line":"                       \"inspect_ports \u003d \u0027none\u0027. \""},{"line_number":102,"context_line":"                       \"Required only for inspection.\")"},{"line_number":103,"context_line":"}"},{"line_number":104,"context_line":"CLEAN_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_998383cc","line":101,"range":{"start_line":100,"start_character":23,"end_line":101,"end_character":48},"updated":"2016-06-22 08:05:01.000000000","message":"Elaborate on \u0027all\u0027 and \u0027none\u0027 values.","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                       \"to be identified for creating node \""},{"line_number":98,"context_line":"                       \"ports. Valid values may be \""},{"line_number":99,"context_line":"                       \"inspect_ports \u003d \u00271,2,...n\u0027 or \""},{"line_number":100,"context_line":"                       \"inspect_ports \u003d \u0027all\u0027 or \""},{"line_number":101,"context_line":"                       \"inspect_ports \u003d \u0027none\u0027. \""},{"line_number":102,"context_line":"                       \"Required only for inspection.\")"},{"line_number":103,"context_line":"}"},{"line_number":104,"context_line":"CLEAN_PROPERTIES \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_19380f3d","line":101,"range":{"start_line":100,"start_character":23,"end_line":101,"end_character":48},"in_reply_to":"3aaa91ec_998383cc","updated":"2016-06-29 11:30:47.000000000","message":"Done","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                       \"inspect_ports \u003d \u00271,2,...n\u0027 or \""},{"line_number":100,"context_line":"                       \"inspect_ports \u003d \u0027all\u0027 or \""},{"line_number":101,"context_line":"                       \"inspect_ports \u003d \u0027none\u0027. \""},{"line_number":102,"context_line":"                       \"Required only for inspection.\")"},{"line_number":103,"context_line":"}"},{"line_number":104,"context_line":"CLEAN_PROPERTIES \u003d {"},{"line_number":105,"context_line":"    \u0027ilo_change_password\u0027: _(\"new password for iLO. Required if the clean \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_59959be2","line":102,"range":{"start_line":102,"start_character":22,"end_line":102,"end_character":54},"updated":"2016-06-22 08:05:01.000000000","message":"Why it should be mandatory? In the absence of this parameter, can\u0027t be default behavior be equivalent to \"inspect_ports\u003d\u0027all\u0027\". It would not force users to add this new property upon upgrade unless they wish to use it.","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                       \"inspect_ports \u003d \u00271,2,...n\u0027 or \""},{"line_number":100,"context_line":"                       \"inspect_ports \u003d \u0027all\u0027 or \""},{"line_number":101,"context_line":"                       \"inspect_ports \u003d \u0027none\u0027. \""},{"line_number":102,"context_line":"                       \"Required only for inspection.\")"},{"line_number":103,"context_line":"}"},{"line_number":104,"context_line":"CLEAN_PROPERTIES \u003d {"},{"line_number":105,"context_line":"    \u0027ilo_change_password\u0027: _(\"new password for iLO. Required if the clean \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_b949fbd2","line":102,"range":{"start_line":102,"start_character":22,"end_line":102,"end_character":54},"in_reply_to":"3aaa91ec_59959be2","updated":"2016-06-29 11:30:47.000000000","message":"Done","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"797e7a21882b3a3cfe261ffd0f218f79c77a24bf","unresolved":false,"context_lines":[{"line_number":65,"context_line":"INSPECT_PROPERTIES \u003d {"},{"line_number":66,"context_line":"    \u0027inspect_ports\u0027: _(\"List of ethernet ports to be identified for\""},{"line_number":67,"context_line":"                       \"creating node ports. Valid values can be\""},{"line_number":68,"context_line":"                       \"inspect_ports \u003d [1,2,...n] or\""},{"line_number":69,"context_line":"                       \"inspect_ports \u003d [\u0027all\u0027] inspects all ports or\""},{"line_number":70,"context_line":"                       \"inspect_ports \u003d [\u0027none\u0027] which will ignore the ports\""},{"line_number":71,"context_line":"                       \"during inspection.\""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a95cdbc_d6e0d498","line":68,"range":{"start_line":68,"start_character":48,"end_line":68,"end_character":49},"updated":"2016-10-07 20:51:28.000000000","message":"What will \u0027n\u0027 be? Curious to know shall there be any check on number of ports?","commit_id":"da05f8fc48e81fc9241c85be9c67e2b8afac7bb9"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5a5c453950dbca91987f84f155c41d385c038516","unresolved":false,"context_lines":[{"line_number":65,"context_line":"INSPECT_PROPERTIES \u003d {"},{"line_number":66,"context_line":"    \u0027inspect_ports\u0027: _(\"List of ethernet ports to be identified for\""},{"line_number":67,"context_line":"                       \"creating node ports. Valid values can be\""},{"line_number":68,"context_line":"                       \"inspect_ports \u003d [1,2,...n] or\""},{"line_number":69,"context_line":"                       \"inspect_ports \u003d [\u0027all\u0027] inspects all ports or\""},{"line_number":70,"context_line":"                       \"inspect_ports \u003d [\u0027none\u0027] which will ignore the ports\""},{"line_number":71,"context_line":"                       \"during inspection.\""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_ca0f4c37","line":68,"range":{"start_line":68,"start_character":48,"end_line":68,"end_character":49},"in_reply_to":"1a95cdbc_d6e0d498","updated":"2016-11-17 18:28:28.000000000","message":"n can be any number. Why there should be any check on number of ports? Does ironic has that limit? Ironic allows you to create as many ports possible for the node.","commit_id":"da05f8fc48e81fc9241c85be9c67e2b8afac7bb9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":86,"context_line":"INSPECT_PROPERTIES \u003d {"},{"line_number":87,"context_line":"    \u0027inspect_ports\u0027: _(\"List of ethernet ports to be identified for\""},{"line_number":88,"context_line":"                       \"creating node ports. Valid values can be\""},{"line_number":89,"context_line":"                       \"inspect_ports \u003d [1,2,...n] or\""},{"line_number":90,"context_line":"                       \"inspect_ports \u003d [\u0027all\u0027] inspects all ports or\""},{"line_number":91,"context_line":"                       \"inspect_ports \u003d [\u0027none\u0027] which will ignore the ports\""},{"line_number":92,"context_line":"                       \"during inspection.\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7ffa3b31_1707bc84","line":89,"range":{"start_line":89,"start_character":24,"end_line":89,"end_character":40},"updated":"2017-04-19 09:31:30.000000000","message":"s/ \u0027inspect_ports \u003d \u0027//","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    \u0027inspect_ports\u0027: _(\"List of ethernet ports to be identified for\""},{"line_number":88,"context_line":"                       \"creating node ports. Valid values can be\""},{"line_number":89,"context_line":"                       \"inspect_ports \u003d [1,2,...n] or\""},{"line_number":90,"context_line":"                       \"inspect_ports \u003d [\u0027all\u0027] inspects all ports or\""},{"line_number":91,"context_line":"                       \"inspect_ports \u003d [\u0027none\u0027] which will ignore the ports\""},{"line_number":92,"context_line":"                       \"during inspection.\""},{"line_number":93,"context_line":"                       \"Required only for inspection.\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7ffa3b31_d700346a","line":90,"range":{"start_line":90,"start_character":24,"end_line":90,"end_character":40},"updated":"2017-04-19 09:31:30.000000000","message":"s/ \u0027inspect_ports \u003d \u0027//","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                       \"creating node ports. Valid values can be\""},{"line_number":89,"context_line":"                       \"inspect_ports \u003d [1,2,...n] or\""},{"line_number":90,"context_line":"                       \"inspect_ports \u003d [\u0027all\u0027] inspects all ports or\""},{"line_number":91,"context_line":"                       \"inspect_ports \u003d [\u0027none\u0027] which will ignore the ports\""},{"line_number":92,"context_line":"                       \"during inspection.\""},{"line_number":93,"context_line":"                       \"Required only for inspection.\""},{"line_number":94,"context_line":"                       \"Default value is inspect_ports\u003d[\u0027all\u0027]\")"}],"source_content_type":"text/x-python","patch_set":22,"id":"7ffa3b31_97faac72","line":91,"range":{"start_line":91,"start_character":24,"end_line":91,"end_character":40},"updated":"2017-04-19 09:31:30.000000000","message":"ditto","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                       \"inspect_ports \u003d [\u0027none\u0027] which will ignore the ports\""},{"line_number":92,"context_line":"                       \"during inspection.\""},{"line_number":93,"context_line":"                       \"Required only for inspection.\""},{"line_number":94,"context_line":"                       \"Default value is inspect_ports\u003d[\u0027all\u0027]\")"},{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":"CLEAN_PROPERTIES \u003d {"},{"line_number":97,"context_line":"    \u0027ilo_change_password\u0027: _(\"new password for iLO. Required if the clean \""}],"source_content_type":"text/x-python","patch_set":22,"id":"7ffa3b31_37ef58b1","line":94,"range":{"start_line":94,"start_character":41,"end_line":94,"end_character":55},"updated":"2017-04-19 09:31:30.000000000","message":"ditto","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"}],"ironic/drivers/modules/ilo/inspect.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7bd9409e447b0c776f02bef409e7debf5bb0ad70","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                     % {\u0027ports\u0027: non_existing_ports, \u0027node\u0027: node.uuid})"},{"line_number":209,"context_line":"            raise exception.HardwareInspectionFailure(error\u003derror)"},{"line_number":210,"context_line":"    return to_be_created_macs"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"def _get_capabilities(node, ilo_object):"},{"line_number":214,"context_line":"    \"\"\"inspects hardware and gets additional capabilities."}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_21030d78","line":211,"updated":"2016-06-16 12:44:59.000000000","message":"We need to add unittests for this method","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"04ef894f1504b5473e5e8a4fd93e29685aef2ca2","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                     % {\u0027ports\u0027: non_existing_ports, \u0027node\u0027: node.uuid})"},{"line_number":209,"context_line":"            raise exception.HardwareInspectionFailure(error\u003derror)"},{"line_number":210,"context_line":"    return to_be_created_macs"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"def _get_capabilities(node, ilo_object):"},{"line_number":214,"context_line":"    \"\"\"inspects hardware and gets additional capabilities."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_9fba1022","line":211,"in_reply_to":"7aa08908_21030d78","updated":"2016-06-21 12:17:49.000000000","message":"Done","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7bd9409e447b0c776f02bef409e7debf5bb0ad70","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                    \"port numbers, or a single port number, or \u0027all\u0027 \""},{"line_number":263,"context_line":"                    \"or \u0027none\u0027. %(value)s given for node %(node)s \""},{"line_number":264,"context_line":"                    \"driver_info[\u0027inspect_ports\u0027]\")"},{"line_number":265,"context_line":"                    % {\u0027value\u0027: value, \u0027node\u0027: node})"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def inspect_hardware(self, task):"},{"line_number":268,"context_line":"        \"\"\"Inspect hardware to get the hardware properties."}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_a1f7fd8a","line":265,"updated":"2016-06-16 12:44:59.000000000","message":"ditto unittests for both of these errors","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"04ef894f1504b5473e5e8a4fd93e29685aef2ca2","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                    \"port numbers, or a single port number, or \u0027all\u0027 \""},{"line_number":263,"context_line":"                    \"or \u0027none\u0027. %(value)s given for node %(node)s \""},{"line_number":264,"context_line":"                    \"driver_info[\u0027inspect_ports\u0027]\")"},{"line_number":265,"context_line":"                    % {\u0027value\u0027: value, \u0027node\u0027: node})"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def inspect_hardware(self, task):"},{"line_number":268,"context_line":"        \"\"\"Inspect hardware to get the hardware properties."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_3fd95c84","line":265,"in_reply_to":"7aa08908_a1f7fd8a","updated":"2016-06-21 12:17:49.000000000","message":"Done","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7bd9409e447b0c776f02bef409e7debf5bb0ad70","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"            if macs_input_given:"},{"line_number":340,"context_line":"                # Create ports only for the requested ports."},{"line_number":341,"context_line":"                _create_ports_if_not_exist(task.node, macs_input_given)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        LOG.debug((\"Node properties for %(node)s are updated as \""},{"line_number":344,"context_line":"                   \"%(properties)s\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_6134f549","line":341,"updated":"2016-06-16 12:44:59.000000000","message":"ditto","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"04ef894f1504b5473e5e8a4fd93e29685aef2ca2","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"            if macs_input_given:"},{"line_number":340,"context_line":"                # Create ports only for the requested ports."},{"line_number":341,"context_line":"                _create_ports_if_not_exist(task.node, macs_input_given)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        LOG.debug((\"Node properties for %(node)s are updated as \""},{"line_number":344,"context_line":"                   \"%(properties)s\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_df05b8c2","line":341,"in_reply_to":"7aa08908_6134f549","updated":"2016-06-21 12:17:49.000000000","message":"Done","commit_id":"303b48ace33d22ebe8395ccd87cd7592f8631395"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":261,"context_line":"                    \"inspect_ports can accept either comma separated \""},{"line_number":262,"context_line":"                    \"port numbers, or a single port number, or \u0027all\u0027 \""},{"line_number":263,"context_line":"                    \"or \u0027none\u0027. %(value)s given for node %(node)s \""},{"line_number":264,"context_line":"                    \"driver_info[\u0027inspect_ports\u0027]\")"},{"line_number":265,"context_line":"                    % {\u0027value\u0027: value, \u0027node\u0027: node})"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_852b1430","line":263,"range":{"start_line":263,"start_character":31,"end_line":263,"end_character":67},"updated":"2016-06-22 08:05:01.000000000","message":"This sentence looks incomplete. May be you mean:-\n\u0027%(value)s given for inspect_ports for node %(node)s are incorrect.\u0027","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":261,"context_line":"                    \"inspect_ports can accept either comma separated \""},{"line_number":262,"context_line":"                    \"port numbers, or a single port number, or \u0027all\u0027 \""},{"line_number":263,"context_line":"                    \"or \u0027none\u0027. %(value)s given for node %(node)s \""},{"line_number":264,"context_line":"                    \"driver_info[\u0027inspect_ports\u0027]\")"},{"line_number":265,"context_line":"                    % {\u0027value\u0027: value, \u0027node\u0027: node})"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_b981fb91","line":263,"range":{"start_line":263,"start_character":31,"end_line":263,"end_character":67},"in_reply_to":"3aaa91ec_852b1430","updated":"2016-06-29 11:30:47.000000000","message":"Done","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        Inspects hardware to get the essential and additional hardware"},{"line_number":271,"context_line":"        properties. It fails if any of the essential properties"},{"line_number":272,"context_line":"        are not received from the node or if \u0027inspect_ports\u0027 is"},{"line_number":273,"context_line":"        not provided in driver_info. It doesn\u0027t fail if node fails"},{"line_number":274,"context_line":"        to return any capabilities as the capabilities differ from hardware"},{"line_number":275,"context_line":"        to hardware mostly."},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_c5ffdc32","line":273,"range":{"start_line":272,"start_character":39,"end_line":273,"end_character":36},"updated":"2016-06-22 08:05:01.000000000","message":"Check for presence of driver_info/inspect_ports is made in validate() not in this method.","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        Inspects hardware to get the essential and additional hardware"},{"line_number":271,"context_line":"        properties. It fails if any of the essential properties"},{"line_number":272,"context_line":"        are not received from the node or if \u0027inspect_ports\u0027 is"},{"line_number":273,"context_line":"        not provided in driver_info. It doesn\u0027t fail if node fails"},{"line_number":274,"context_line":"        to return any capabilities as the capabilities differ from hardware"},{"line_number":275,"context_line":"        to hardware mostly."},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_eb9d6abc","line":273,"range":{"start_line":272,"start_character":39,"end_line":273,"end_character":36},"in_reply_to":"3aaa91ec_c5ffdc32","updated":"2016-06-29 11:30:47.000000000","message":"Done","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6748e5882a26f9456c293ae40d01c0977d144606","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # If the operator has given \u0027all\u0027 just return all the macs"},{"line_number":183,"context_line":"    # returned by inspection."},{"line_number":184,"context_line":"    if desired_macs \u003d\u003d [\u0027all\u0027]:"},{"line_number":185,"context_line":"        to_be_created_macs \u003d macs"},{"line_number":186,"context_line":"    else:"},{"line_number":187,"context_line":"        to_be_created_macs \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_15982569","line":184,"range":{"start_line":184,"start_character":7,"end_line":184,"end_character":30},"updated":"2016-08-02 09:48:35.000000000","message":"Suggestion: Using a list for listing the port numbers, but maybe \"all\" and \"none\" should just be a string... Anyway it\u0027s not a big deal.","commit_id":"573b89eab96eba1228dfb7df455f009f1a12a8fe"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ecf5d9b04036e8c2188b1b468ae778b5f64c5bef","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def get_properties(self):"},{"line_number":167,"context_line":"        d \u003d ilo_common.REQUIRED_PROPERTIES.copy()"},{"line_number":168,"context_line":"        d.update(ilo_common.INSPECT_PROPERTIES)"},{"line_number":169,"context_line":"        return d"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @METRICS.timer(\u0027IloInspect.validate\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_56d777ec","line":168,"range":{"start_line":168,"start_character":17,"end_line":168,"end_character":46},"updated":"2016-12-05 14:57:40.000000000","message":"Please use this parameter from inspect_utils instead.","commit_id":"568de8630504fd7702c31e2a67e1640036ef17f2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ecf5d9b04036e8c2188b1b468ae778b5f64c5bef","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            driver_info \u003d task.node.driver_info"},{"line_number":269,"context_line":"            if \u0027inspect_ports\u0027 in driver_info:"},{"line_number":270,"context_line":"                macs_requested \u003d None"},{"line_number":271,"context_line":"                if driver_info[\u0027inspect_ports\u0027] !\u003d \"none\":"},{"line_number":272,"context_line":"                    macs_requested \u003d ("},{"line_number":273,"context_line":"                        inspect_utils.get_macs_for_desired_ports("},{"line_number":274,"context_line":"                            task.node, result[\u0027macs\u0027]))"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"            if macs_requested:"},{"line_number":277,"context_line":"                _create_ports_if_not_exist(task, macs_requested)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_361f5bb8","line":274,"range":{"start_line":271,"start_character":16,"end_line":274,"end_character":55},"updated":"2016-12-05 14:57:40.000000000","message":"I don\u0027t really like this, I\u0027d prefer all the logic regarding handling of inspect_ports be in one place, in inspect_utils.get_macs_for_desired_ports, instead of leaving bits of it in different places.","commit_id":"568de8630504fd7702c31e2a67e1640036ef17f2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            for port in value:"},{"line_number":140,"context_line":"                if not isinstance(port, int):"},{"line_number":141,"context_line":"                    raise exception.InvalidParameterValue(_("},{"line_number":142,"context_line":"                        \"Value \u0027%(value)s\u0027 given for \u0027inspect_ports\u0027 for node \""},{"line_number":143,"context_line":"                        \"%(node)s is invalid. Valid values for \""},{"line_number":144,"context_line":"                        \"\u0027inspect_ports\u0027 are list of port numbers or \u0027all\u0027 or \""},{"line_number":145,"context_line":"                        \"\u0027none\u0027. \")"}],"source_content_type":"text/x-python","patch_set":22,"id":"7ffa3b31_57778403","line":142,"range":{"start_line":142,"start_character":54,"end_line":142,"end_character":67},"updated":"2017-04-19 09:31:30.000000000","message":"s/ \u0027inspect_ports\u0027 / \u0027driver_info/inspect_ports\u0027 /","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            if current_local_gb:"},{"line_number":303,"context_line":"                if properties[\u0027local_gb\u0027] \u003d\u003d 0 and current_local_gb \u003e 0:"},{"line_number":304,"context_line":"                    properties[\u0027local_gb\u0027] \u003d current_local_gb"},{"line_number":305,"context_line":"                    LOG.warning(_LW(\u0027Could not discover size of disk on the \u0027"},{"line_number":306,"context_line":"                                    \u0027node %s. Value of `properties/local_gb` \u0027"},{"line_number":307,"context_line":"                                    \u0027of the node is not overwritten.\u0027),"},{"line_number":308,"context_line":"                                task.node.uuid)"}],"source_content_type":"text/x-python","patch_set":22,"id":"7ffa3b31_e2092c2c","line":305,"range":{"start_line":305,"start_character":32,"end_line":305,"end_character":35},"updated":"2017-04-19 09:31:30.000000000","message":"Remove log translation.","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                      {\u0027properties\u0027: inspected_properties,"},{"line_number":352,"context_line":"                       \u0027node\u0027: task.node.uuid})"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"            LOG.info(_LI(\"Inspection for node %s is complete.\"),"},{"line_number":355,"context_line":"                     task.node.uuid)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":22,"id":"7ffa3b31_820ee82f","line":354,"range":{"start_line":354,"start_character":21,"end_line":354,"end_character":24},"updated":"2017-04-19 09:31:30.000000000","message":"ditto","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a55db3a6c6c2def40667f948052ec3d04f81a911","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        finally:"},{"line_number":358,"context_line":"            if power_turned_on:"},{"line_number":359,"context_line":"                conductor_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":360,"context_line":"                LOG.info(_LI(\"The node %s was powered on for inspection. \""},{"line_number":361,"context_line":"                             \"Node is being powered off.\"),"},{"line_number":362,"context_line":"                         task.node.uuid)"},{"line_number":363,"context_line":"        return states.MANAGEABLE"}],"source_content_type":"text/x-python","patch_set":22,"id":"7ffa3b31_22003401","line":360,"range":{"start_line":360,"start_character":25,"end_line":360,"end_character":28},"updated":"2017-04-19 09:31:30.000000000","message":"Remove log translation.","commit_id":"7626f85bf4c1347d983163f2b398760367bba939"}],"ironic/drivers/modules/inspect_utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ecf5d9b04036e8c2188b1b468ae778b5f64c5bef","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            if value !\u003d \u0027all\u0027 and value !\u003d \u0027none\u0027:"},{"line_number":63,"context_line":"                if not value:"},{"line_number":64,"context_line":"                    raise exception.InvalidParameterValue(msg)"},{"line_number":65,"context_line":"                for port in value:"},{"line_number":66,"context_line":"                    if not isinstance(port, int):"},{"line_number":67,"context_line":"                        raise exception.InvalidParameterValue(msg)"},{"line_number":68,"context_line":"            if value:"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_73c9e525","line":65,"range":{"start_line":65,"start_character":28,"end_line":65,"end_character":33},"updated":"2016-12-05 14:57:40.000000000","message":"nit - you could do (value or []) here and remove L63-64.","commit_id":"568de8630504fd7702c31e2a67e1640036ef17f2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ecf5d9b04036e8c2188b1b468ae778b5f64c5bef","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                if not value:"},{"line_number":64,"context_line":"                    raise exception.InvalidParameterValue(msg)"},{"line_number":65,"context_line":"                for port in value:"},{"line_number":66,"context_line":"                    if not isinstance(port, int):"},{"line_number":67,"context_line":"                        raise exception.InvalidParameterValue(msg)"},{"line_number":68,"context_line":"            if value:"},{"line_number":69,"context_line":"                d_info[param] \u003d value"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_7365651c","line":66,"range":{"start_line":66,"start_character":27,"end_line":66,"end_character":48},"updated":"2016-12-05 14:57:40.000000000","message":"the comments in rfe mention that the solution should be generic. Do you think it covers all cases?","commit_id":"568de8630504fd7702c31e2a67e1640036ef17f2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ecf5d9b04036e8c2188b1b468ae778b5f64c5bef","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                       \"\u0027inspect_ports\u0027 on the system. Discovered NIC ports \""},{"line_number":134,"context_line":"                       \"on the system are \u0027%(avbl)s\u0027.\") %"},{"line_number":135,"context_line":"                     {\u0027ports\u0027: invalid_ports,"},{"line_number":136,"context_line":"                      \u0027avbl\u0027: [int(p.replace(\u0027Port \u0027, \u0027\u0027)) for p in macs]})"},{"line_number":137,"context_line":"            raise exception.HardwareInspectionFailure(error\u003derror)"},{"line_number":138,"context_line":"    return create_macs"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_76d5531a","line":136,"range":{"start_line":136,"start_character":45,"end_line":136,"end_character":56},"updated":"2016-12-05 14:57:40.000000000","message":"this assumes very specific format of returned data. Could we just introduce another method in proliantutils to return properly formatted data? Eg .\n\nmaybe just assume that the key of this dict is formatted the same way as it is provided in inspect_ports parameter, the value is mac.","commit_id":"568de8630504fd7702c31e2a67e1640036ef17f2"}],"ironic/tests/unit/drivers/modules/ilo/test_inspect.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ecf5d9b04036e8c2188b1b468ae778b5f64c5bef","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            msg \u003d \"Value \u0027abc\u0027 given for \u0027inspect_ports\u0027\""},{"line_number":94,"context_line":"            d_info_mock.side_effect \u003d exception.InvalidParameterValue(msg)"},{"line_number":95,"context_line":"            self.assertRaisesRegex(exception.InvalidParameterValue,"},{"line_number":96,"context_line":"                                   \"Value \u0027abc\u0027 given for \u0027inspect_ports\u0027\","},{"line_number":97,"context_line":"                                   task.driver.inspect.validate, task)"},{"line_number":98,"context_line":"            d_info_mock.assert_called_once_with(task.node)"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_160c1f40","line":96,"range":{"start_line":96,"start_character":35,"end_line":96,"end_character":74},"updated":"2016-12-05 14:57:40.000000000","message":"msg here","commit_id":"568de8630504fd7702c31e2a67e1640036ef17f2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ecf5d9b04036e8c2188b1b468ae778b5f64c5bef","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":104,"context_line":"            msg \u003d \"Value \u0027\\[\\]\u0027 given for \u0027inspect_ports\u0027\""},{"line_number":105,"context_line":"            d_info_mock.side_effect \u003d exception.InvalidParameterValue(msg)"},{"line_number":106,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"},{"line_number":107,"context_line":"                              task.driver.inspect.validate, task)"},{"line_number":108,"context_line":"            d_info_mock.assert_called_once_with(task.node)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_b11e155d","line":106,"range":{"start_line":106,"start_character":17,"end_line":106,"end_character":29},"updated":"2016-12-05 14:57:40.000000000","message":"you don\u0027t assert the message printed here.","commit_id":"568de8630504fd7702c31e2a67e1640036ef17f2"}],"ironic/tests/unit/drivers/modules/test_inspect_utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ecf5d9b04036e8c2188b1b468ae778b5f64c5bef","unresolved":false,"context_lines":[{"line_number":26,"context_line":"INFO_DICT \u003d db_utils.get_test_ilo_info()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TestInspectPrivateMethods(db_base.DbTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestInspectPrivateMethods, self).setUp()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a71b18c_f1432d40","line":29,"range":{"start_line":29,"start_character":17,"end_line":29,"end_character":24},"updated":"2016-12-05 14:57:40.000000000","message":"they are not private","commit_id":"568de8630504fd7702c31e2a67e1640036ef17f2"}],"releasenotes/notes/adding-back-the-inspect_ports-e77583e0c1869a33.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adding back the \"inspect_ports\" as an optional parameter"},{"line_number":4,"context_line":"    which allow ilo drivers to choose the ports to be inspected."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3aaa91ec_c55b5c53","line":3,"range":{"start_line":3,"start_character":42,"end_line":3,"end_character":60},"updated":"2016-06-22 08:05:01.000000000","message":"In the code its is being treated as a mandatory property.","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adding back the \"inspect_ports\" as an optional parameter"},{"line_number":4,"context_line":"    which allow ilo drivers to choose the ports to be inspected."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3aaa91ec_454f6c92","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":15},"updated":"2016-06-22 08:05:01.000000000","message":"It was never released.","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adding back the \"inspect_ports\" as an optional parameter"},{"line_number":4,"context_line":"    which allow ilo drivers to choose the ports to be inspected."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3aaa91ec_cbc86e77","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":15},"in_reply_to":"3aaa91ec_454f6c92","updated":"2016-06-29 11:30:47.000000000","message":"inspect_ports as a parameter was implemented earlier but deleted afterwards","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adding back the \"inspect_ports\" as an optional parameter"},{"line_number":4,"context_line":"    which allow ilo drivers to choose the ports to be inspected."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3aaa91ec_6b905a4f","line":3,"range":{"start_line":3,"start_character":42,"end_line":3,"end_character":60},"in_reply_to":"3aaa91ec_c55b5c53","updated":"2016-06-29 11:30:47.000000000","message":"setting the default value \u0027all\u0027 to optional_parameter, by which it will acts as an optional parameter.","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32dd96d9a450f5628ec32cbed99b82928f5b9662","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adding back the \"inspect_ports\" as an optional parameter"},{"line_number":4,"context_line":"    which allow ilo drivers to choose the ports to be inspected."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3aaa91ec_a5129060","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":19},"updated":"2016-06-22 08:05:01.000000000","message":"nit: ilo/iLO","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"48a25fffe670fbfea1ec7379340c13c4a16af59e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adding back the \"inspect_ports\" as an optional parameter"},{"line_number":4,"context_line":"    which allow ilo drivers to choose the ports to be inspected."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3aaa91ec_cbe7ce3e","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":19},"in_reply_to":"3aaa91ec_a5129060","updated":"2016-06-29 11:30:47.000000000","message":"Done","commit_id":"e4dedca09bb8e5abf4784ee376aa32117ee4f20f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6748e5882a26f9456c293ae40d01c0977d144606","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adding back the \"inspect_ports\" as an optional parameter"},{"line_number":4,"context_line":"    which allow iLo drivers to choose the ports to be inspected."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bacf61ea_951ff5b5","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":15},"updated":"2016-08-02 09:48:35.000000000","message":"I would rather say it\u0027s a new thing, \"inspect_ports\" was removed long ago and had a different format for the ports (a list of comma-separated string.","commit_id":"573b89eab96eba1228dfb7df455f009f1a12a8fe"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"017241c578a0d9f271771561245cfccf38c7ec8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adding back the \"inspect_ports\" as an optional parameter"},{"line_number":4,"context_line":"    which allow iLo drivers to choose the ports to be inspected."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bacf61ea_889eb7b6","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":15},"in_reply_to":"bacf61ea_951ff5b5","updated":"2016-08-02 12:12:24.000000000","message":"Done","commit_id":"573b89eab96eba1228dfb7df455f009f1a12a8fe"}],"releasenotes/notes/inspect_ports-for-ilo-drivers-e77583e0c1869a33.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ecf5d9b04036e8c2188b1b468ae778b5f64c5bef","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Added \u0027inspect_ports\u0027 as an optional parameter to"},{"line_number":4,"context_line":"    \u0027driver_info\u0027 for iLO drivers."},{"line_number":5,"context_line":"    If this parameter is provided, Ironic would create ports"},{"line_number":6,"context_line":"    only for the specified ports. Valid values for"},{"line_number":7,"context_line":"    \u0027inspect_ports\u0027 are list of port numbers, \u0027all\u0027 or \u0027none\u0027."},{"line_number":8,"context_line":"    If this parameter is not specified, Ironic would create"},{"line_number":9,"context_line":"    ports for all the discovered NIC ports."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3a71b18c_316125d4","line":6,"range":{"start_line":6,"start_character":27,"end_line":6,"end_character":32},"updated":"2016-12-05 14:57:40.000000000","message":"NICs","commit_id":"568de8630504fd7702c31e2a67e1640036ef17f2"}]}
