)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b056ddcb45c66e2e0216a1cb498107f486a5e05c","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        except Exception as e:"},{"line_number":1006,"context_line":"            msg \u003d (_(\u0027Failed to tear down from cleaning for node %(node)s, \u0027"},{"line_number":1007,"context_line":"                     \u0027reason: %(err)s\u0027)"},{"line_number":1008,"context_line":"                   % {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"},{"line_number":1009,"context_line":"            LOG.exception(msg)"},{"line_number":1010,"context_line":"            return utils.cleaning_error_handler(task, msg,"},{"line_number":1011,"context_line":"                                                tear_down_cleaning\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_0ef555ca","line":1008,"updated":"2016-06-07 00:40:23.000000000","message":"Hmm. It makes no sense to mention the node UUID in the node\u0027s last_error. It seems like there should be two different strings, one that we log and one that is used for last_error.\n\nHaving said that, the node UUID was already there. \n\nI thought that the last error wasn\u0027t meant to include details (debugging) because it was meant for the \u0027end user\u0027. I looked through, and we are not consistent with what we put in last error nor do I know if we documented it so...","commit_id":"86a9897769466374fc5ea0629788048836a717e7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"219d5b6a1ff1169b22f0437c2b940e133ca0694d","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        except Exception as e:"},{"line_number":1006,"context_line":"            msg \u003d (_(\u0027Failed to tear down from cleaning for node %(node)s, \u0027"},{"line_number":1007,"context_line":"                     \u0027reason: %(err)s\u0027)"},{"line_number":1008,"context_line":"                   % {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"},{"line_number":1009,"context_line":"            LOG.exception(msg)"},{"line_number":1010,"context_line":"            return utils.cleaning_error_handler(task, msg,"},{"line_number":1011,"context_line":"                                                tear_down_cleaning\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_5ba548b3","line":1008,"in_reply_to":"7aa08908_0ef555ca","updated":"2016-06-07 11:03:23.000000000","message":"\u003e It makes no sense to mention the node UUID in the node\u0027s last_error\n\nI agree, but we do it everywhere :(\n\n\u003e I thought that the last error wasn\u0027t meant to include details\n\nI tend to disagree with this one, cause what users see is what ends up on my bug reports :)","commit_id":"86a9897769466374fc5ea0629788048836a717e7"}]}
