)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5fa2afa5d548f8fa32c24a4724fd12a3b5a7afda","unresolved":false,"context_lines":[{"line_number":297,"context_line":"# check if Ubuntu needs the \u0027pxelinux\u0027 package"},{"line_number":298,"context_line":"# NOTE(pas-ha) since Ubuntu 15.04 \u0027pxelinux.0\u0027 file is provided by"},{"line_number":299,"context_line":"# \u0027pxelinux\u0027 package instead of \u0027syslinux-common\u0027,"},{"line_number":300,"context_line":"# and its required modules have also moved around."},{"line_number":301,"context_line":"function ubuntu_needs_pxelinux {"},{"line_number":302,"context_line":"    vercmp \"$os_RELEASE\" \"\u003e\u003d\" \"15.04\""},{"line_number":303,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a89bdaa_d2a45c4c","line":300,"updated":"2016-09-13 11:49:09.000000000","message":"If that package exists in 14.04 (or if devstack will ignore missing packages), we should just put this in devstack/files for consistency.","commit_id":"a24995d1005a91dd405c6bf7e50b42c23f60abfd"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"8a27c9eab6830786640b70f4e97ef400fcebc14a","unresolved":false,"context_lines":[{"line_number":297,"context_line":"# check if Ubuntu needs the \u0027pxelinux\u0027 package"},{"line_number":298,"context_line":"# NOTE(pas-ha) since Ubuntu 15.04 \u0027pxelinux.0\u0027 file is provided by"},{"line_number":299,"context_line":"# \u0027pxelinux\u0027 package instead of \u0027syslinux-common\u0027,"},{"line_number":300,"context_line":"# and its required modules have also moved around."},{"line_number":301,"context_line":"function ubuntu_needs_pxelinux {"},{"line_number":302,"context_line":"    vercmp \"$os_RELEASE\" \"\u003e\u003d\" \"15.04\""},{"line_number":303,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a8ec9b2_c277c900","line":300,"in_reply_to":"9a89bdaa_bce16a2c","updated":"2016-09-14 12:00:26.000000000","message":"Jim, as Mathieu says, the package does not exist on 14.04, and devstack is not ignoring missing packages on install (we\u0027ve once had similar problem with openvswitch-datapath-dkms that we insisted on installing but it is not there on Xenial at all, bug 1580101)\n\nSo however ugly it seems, we still have to have this check to install packages *only* when required (or somehow make the \"debs\" file more resembling the requirements.txt re allowing distro/version conditionals)","commit_id":"a24995d1005a91dd405c6bf7e50b42c23f60abfd"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"8248af77cc72b2d8f1adeb8017af3c531bc3b25f","unresolved":false,"context_lines":[{"line_number":297,"context_line":"# check if Ubuntu needs the \u0027pxelinux\u0027 package"},{"line_number":298,"context_line":"# NOTE(pas-ha) since Ubuntu 15.04 \u0027pxelinux.0\u0027 file is provided by"},{"line_number":299,"context_line":"# \u0027pxelinux\u0027 package instead of \u0027syslinux-common\u0027,"},{"line_number":300,"context_line":"# and its required modules have also moved around."},{"line_number":301,"context_line":"function ubuntu_needs_pxelinux {"},{"line_number":302,"context_line":"    vercmp \"$os_RELEASE\" \"\u003e\u003d\" \"15.04\""},{"line_number":303,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a89bdaa_bce16a2c","line":300,"in_reply_to":"9a89bdaa_d2a45c4c","updated":"2016-09-13 12:22:48.000000000","message":"pxelinux did not exist in 14.04.","commit_id":"a24995d1005a91dd405c6bf7e50b42c23f60abfd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"06359ceefe004d908c913f4c13769c58739be9a9","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":322,"context_line":"        echo \"/usr/share/syslinux/pxelinux.0\""},{"line_number":323,"context_line":"    fi"},{"line_number":324,"context_line":"}"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"function get_ipxe_boot_file {"},{"line_number":327,"context_line":"    if is_ubuntu; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a89bdaa_fa00e4ac","line":324,"updated":"2016-09-05 09:28:27.000000000","message":"Instead of look what distro is what, what about we just give it a list of directories to search for the file ?\n\ne.g\n\n PXEFILES\u003d\"/usr/lib/PXELINUX/pxelinux.0 \\\n           /usr/lib/syslinux/pxelinux.0 \\\n           /usr/share/syslinux/pxelinux.0\"\n\n for f in $PXEFILES; do\n     if [ -f ${f} ]; then\n         echo ${f}\n         break;\n     fi\n     die $LINENO \"Couldn\u0027t find the PXE ...\"\n done\n\nI think it\u0027s much easier to read the code and to extend (it\u0027s distro agnostic)\n\n(we should do the same for the iPXE (undionly.kpxe) file)","commit_id":"a24995d1005a91dd405c6bf7e50b42c23f60abfd"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"8a27c9eab6830786640b70f4e97ef400fcebc14a","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":322,"context_line":"        echo \"/usr/share/syslinux/pxelinux.0\""},{"line_number":323,"context_line":"    fi"},{"line_number":324,"context_line":"}"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"function get_ipxe_boot_file {"},{"line_number":327,"context_line":"    if is_ubuntu; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a8ec9b2_181764a4","line":324,"in_reply_to":"9a89bdaa_326ae8ed","updated":"2016-09-14 12:00:26.000000000","message":"Done. I\u0027m also doing the *.c32 module copying in the same style","commit_id":"a24995d1005a91dd405c6bf7e50b42c23f60abfd"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5fa2afa5d548f8fa32c24a4724fd12a3b5a7afda","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":322,"context_line":"        echo \"/usr/share/syslinux/pxelinux.0\""},{"line_number":323,"context_line":"    fi"},{"line_number":324,"context_line":"}"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"function get_ipxe_boot_file {"},{"line_number":327,"context_line":"    if is_ubuntu; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a89bdaa_326ae8ed","line":324,"in_reply_to":"9a89bdaa_fa00e4ac","updated":"2016-09-13 11:49:09.000000000","message":"++","commit_id":"a24995d1005a91dd405c6bf7e50b42c23f60abfd"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"745c67323a462b47bdd5f6c282bd69214b4ee407","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            echo ${f}"},{"line_number":325,"context_line":"            break;"},{"line_number":326,"context_line":"        fi"},{"line_number":327,"context_line":"        die $LINENO \"Could not find PXE boot file in any of default locations\""},{"line_number":328,"context_line":"    done"},{"line_number":329,"context_line":"}"},{"line_number":330,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a8ec9b2_855a044f","line":327,"updated":"2016-09-14 17:05:11.000000000","message":"when the first line/path checked does not exist, this die still executes.\n\nwas passing on my env with Xenial, obviously does not pass anywhere else :facepalm:","commit_id":"b6584bcbf1e502b503f26ae8f741a733e1a0e798"}]}
