)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b1a84124edb2f90dec169e97cd08860151903614","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from the ironic.common.context.RequestContext class.  The"},{"line_number":22,"context_line":"NOTE: needs unit tests"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I48493c53971cdab3b9122897e51322e19ce2f600"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_d557c723","line":24,"updated":"2016-06-08 23:33:58.000000000","message":"JFYI it\u0027ll be bug 1526752 for this","commit_id":"5d2211c9b9932cf5f1114f8d0e929546cab6819a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"55b1033aa2f73d2bfc6fe63fabb399b6a4ef21c6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"As a result of this cleanup, the ironic-specific"},{"line_number":21,"context_line":"RequestContext.show_password property is removed."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partial-bug: #1526752"},{"line_number":24,"context_line":"Change-Id: I48493c53971cdab3b9122897e51322e19ce2f600"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9ad45d7e_21e0a6cc","line":23,"updated":"2016-08-11 19:25:52.000000000","message":"Does it also address https://bugs.launchpad.net/ironic/+bug/1530972 ?","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"975b814874e238114ab14a19cae0c19178b3a9ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Devananda van der Veen \u003cdevananda.vdv@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-16 16:49:28 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ask instance secrets in API responses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new policy setting, \"show_instance_secrets\", whose"},{"line_number":10,"context_line":"behavior mirrors that of the existing \"show_passwords\" policy setting."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3ac371cc_1a9c4d0e","line":7,"updated":"2016-08-17 00:24:41.000000000","message":"Lost an M?","commit_id":"00d93d7c010316d5369ce14f95a51454249d8c2a"}],"etc/ironic/policy.json.sample":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34adfb4cd99b3af3e7284bd884bd0a9a1ab18875","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\"admin_api\": \"role:admin or role:administrator\""},{"line_number":3,"context_line":"# Internal flag for public API routes"},{"line_number":4,"context_line":"\"public_api\": \"is_public_api:True\""},{"line_number":5,"context_line":"# Show or mask secrets within driver_info in API responses"},{"line_number":6,"context_line":"\"show_password\": \"!\""},{"line_number":7,"context_line":"# Show or mask secrets within instance_info in API responses"},{"line_number":8,"context_line":"\"show_instance_secrets\": \"!\""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3ac371cc_041fa06c","line":5,"updated":"2016-08-17 18:43:18.000000000","message":"maybe we should be more specific, s/driver_info/node.driver_info/ ?\nOr eg \u0027Show or mask secrets within driver information for nodes, in API responses\u0027.","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34adfb4cd99b3af3e7284bd884bd0a9a1ab18875","unresolved":false,"context_lines":[{"line_number":4,"context_line":"\"public_api\": \"is_public_api:True\""},{"line_number":5,"context_line":"# Show or mask secrets within driver_info in API responses"},{"line_number":6,"context_line":"\"show_password\": \"!\""},{"line_number":7,"context_line":"# Show or mask secrets within instance_info in API responses"},{"line_number":8,"context_line":"\"show_instance_secrets\": \"!\""},{"line_number":9,"context_line":"# May be used to restrict access to specific tenants"},{"line_number":10,"context_line":"\"is_member\": \"tenant:demo or tenant:baremetal\""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"3ac371cc_840b9029","line":7,"updated":"2016-08-17 18:43:18.000000000","message":"ditto","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2b8df86312ed527db61ad2eb040950448844c185","unresolved":false,"context_lines":[{"line_number":4,"context_line":"\"public_api\": \"is_public_api:True\""},{"line_number":5,"context_line":"# Show or mask secrets within driver_info in API responses"},{"line_number":6,"context_line":"\"show_password\": \"!\""},{"line_number":7,"context_line":"# Show or mask secrets within instance_info in API responses"},{"line_number":8,"context_line":"\"show_instance_secrets\": \"!\""},{"line_number":9,"context_line":"# May be used to restrict access to specific tenants"},{"line_number":10,"context_line":"\"is_member\": \"tenant:demo or tenant:baremetal\""}],"source_content_type":"application/octet-stream","patch_set":16,"id":"fa7ab95a_f689d3cb","line":7,"updated":"2016-08-26 15:31:15.000000000","message":"done","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7d2a630d03ab63b4504a9f28502ba93e21e7525c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# Set maintenance flag, taking a Node out of service"},{"line_number":30,"context_line":"\"baremetal:node:set_maintenance\": \"rule:is_admin\""},{"line_number":31,"context_line":"# Clear maintenance flag, placing the Node into service again"},{"line_number":32,"context_line":"\"baremetal:node:clear_maintenance\": \"rule:is_admin\""},{"line_number":33,"context_line":"# Change Node boot device"},{"line_number":34,"context_line":"\"baremetal:node:set_boot_device\": \"rule:is_admin\""},{"line_number":35,"context_line":"# Change Node power status"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"fa7ab95a_d9c9145b","line":32,"updated":"2016-08-29 12:23:27.000000000","message":"nit: ideally such things should go to separate patches","commit_id":"dc0dad97737dcd0dadd1a56eb094cd76207229f0"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"55b1033aa2f73d2bfc6fe63fabb399b6a4ef21c6","unresolved":false,"context_lines":[{"line_number":826,"context_line":"                node.driver_info, \"******\")"},{"line_number":827,"context_line":"        if not show_configdrive and node.instance_info !\u003d wtypes.Unset:"},{"line_number":828,"context_line":"            node.instance_info \u003d strutils.mask_dict_password("},{"line_number":829,"context_line":"                node.instance_info, \"******\")"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        update_state_in_older_versions(node)"},{"line_number":832,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_21bf0662","line":829,"updated":"2016-08-11 19:25:52.000000000","message":"I thought that show_configdrive was used to show or not show the configdrive contents. Does this do that, or just mask any password that might be present in the configdrive? Also, this code is touching all of instance_info, don\u0027t we just want to touch instance_info[\u0027configdrive\u0027] if that exists?","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8f20f04dcd5d21f28ae8c9c6e393eeb22fbe7f21","unresolved":false,"context_lines":[{"line_number":826,"context_line":"                node.driver_info, \"******\")"},{"line_number":827,"context_line":"        if not show_configdrive and node.instance_info !\u003d wtypes.Unset:"},{"line_number":828,"context_line":"            node.instance_info \u003d strutils.mask_dict_password("},{"line_number":829,"context_line":"                node.instance_info, \"******\")"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        update_state_in_older_versions(node)"},{"line_number":832,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_7849a430","line":829,"updated":"2016-08-11 22:39:32.000000000","message":"Ruby, This will mask out any suspected passwords in node.instance_info. The mask_dict_password() function considers \u0027configdrive\u0027 as indicative of a password. So it will mask out the contents of that entry, which in this case is the entire configdrive. https://github.com/openstack/oslo.utils/blob/b04c94d44393c6951f41322ff644e2100baa2c30/oslo_utils/strutils.py#L59","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"93ffc41e46e392fc46973c887fd9cfa94accc2ed","unresolved":false,"context_lines":[{"line_number":826,"context_line":"                node.driver_info, \"******\")"},{"line_number":827,"context_line":"        if not show_configdrive and node.instance_info !\u003d wtypes.Unset:"},{"line_number":828,"context_line":"            node.instance_info \u003d strutils.mask_dict_password("},{"line_number":829,"context_line":"                node.instance_info, \"******\")"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        update_state_in_older_versions(node)"},{"line_number":832,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_05924c57","line":829,"in_reply_to":"3ac371cc_b0f3df09","updated":"2016-08-16 14:35:04.000000000","message":"Good points Ruby,\n\nThe word \"configdrive\" was included in the list of key words in oslo because it\u0027s considered a secret. The thing is, a configdrive may contain passwords (e.g nova could inject a root password for that instance into it).\n\nI\u0027ve another suggestion on top of deva\u0027s one:\n\n- Have only one option \"show_secrets\" that would hide passwords/configdrives etc... in both driver_info and instance_info (actually in the whole API response, independent of the field).","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8f1bce9f1d58fffd8d5be54effe4488281ac238d","unresolved":false,"context_lines":[{"line_number":826,"context_line":"                node.driver_info, \"******\")"},{"line_number":827,"context_line":"        if not show_configdrive and node.instance_info !\u003d wtypes.Unset:"},{"line_number":828,"context_line":"            node.instance_info \u003d strutils.mask_dict_password("},{"line_number":829,"context_line":"                node.instance_info, \"******\")"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        update_state_in_older_versions(node)"},{"line_number":832,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_b0f3df09","line":829,"in_reply_to":"9ad45d7e_094e29c1","updated":"2016-08-15 20:53:02.000000000","message":"I\u0027m not an operator and don\u0027t know how operators think about this. My personal opinion is that a password is different from a configdrive. Our configdrive value is either a URL or the contents-of-a-config-drive. I looked to see why configdrive was added to the oslo code [1], and it was Lucas that added it. Presumably to do this? @Lucas, I\u0027m guessing the way it is coded here, is what you wanted?\n\n - wrt your first option. Maybe also confusing if configdrive is a URL\n - wrt your second option. To address your con, I think we could add code to also sanitize instance_info (if there were passwords outside of config drive) if show_passwords is set\nwrt your third option. Ugh. That means if we introduce some other field with password-related info, we\u0027d need to add a third option. Also, \u0027show_passwords_in_instance_info\u0027 might not address my concern if I don\u0027t think of \u0027configdrive\u0027 as having password info. (And I also thought it was sophisticated, and bleeped out only the password part of the config drive.)\n\nSo if I think of password being different from configdrive, then I\u0027d go with option 2. If I think of \u0027any place there is password-related info, and urls that shouldn\u0027t be shown\u0027, then I\u0027d go with option 1 but should we rename it then (show_sensitive_info?), or just describe it better.\n\n[1] https://review.openstack.org/#/c/263811/","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"80b34221b336069c4e789f676396894bb39cf602","unresolved":false,"context_lines":[{"line_number":826,"context_line":"                node.driver_info, \"******\")"},{"line_number":827,"context_line":"        if not show_configdrive and node.instance_info !\u003d wtypes.Unset:"},{"line_number":828,"context_line":"            node.instance_info \u003d strutils.mask_dict_password("},{"line_number":829,"context_line":"                node.instance_info, \"******\")"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        update_state_in_older_versions(node)"},{"line_number":832,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_e9cca836","line":829,"in_reply_to":"9ad45d7e_7849a430","updated":"2016-08-12 00:07:16.000000000","message":"You\u0027re kidding me. You\u0027re not. Wow.\n\nWell, here\u0027s my other issue with this. What if node.instance_info[\u0027token\u0027] existed. That shouldn\u0027t be masked out if show_configdrive is true, only if show_password is true. We don\u0027t have (I don\u0027t think) any other secret-related stuff in node.instance_info, but if we did in the future, this would be wrong. And anyway, why do extra processing when we could just do instance_info[\u0027config_drive\u0027] \u003d \u0027******\u0027.\n\nAlso makes me wonder, why not use the same \u0027show_password\u0027 policy for the configdrive too then? Well, I can answer that, cuz I wouldn\u0027t have expected show_password to apply to the configdrive, even if oslo library does :-)","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"b88ce515daa9453a121751ce9839cb4c15ce6e51","unresolved":false,"context_lines":[{"line_number":826,"context_line":"                node.driver_info, \"******\")"},{"line_number":827,"context_line":"        if not show_configdrive and node.instance_info !\u003d wtypes.Unset:"},{"line_number":828,"context_line":"            node.instance_info \u003d strutils.mask_dict_password("},{"line_number":829,"context_line":"                node.instance_info, \"******\")"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        update_state_in_older_versions(node)"},{"line_number":832,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_094e29c1","line":829,"in_reply_to":"9ad45d7e_e9cca836","updated":"2016-08-12 17:48:52.000000000","message":"Here are other approaches that I think we could take:\n\n- apply the existing show_passwords option to both driver_info and instance_info. this will have the effect of also sanitizing instance_info[\u0027config_drive\u0027].\n  pro: no new config option, better sanitization\n  con: confusing, since \"configdrive\" doesn\u0027t seem like a password, unless you already know that it probably contains the root password...\n\n- apply show_configdrive specifically to instance_info[\u0027config_drive\u0027]\n  pro: option does what it says it does\n  con: we don\u0027t start sanitizing the rest of instance_info\n\n- rename the options\n  s/show_password/show_passwords_in_driver_info/ \n  s/show_configdrive/show_passwords_in_instance_info/\n  (or something like that)","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6f2b6c0b035b0e2a438d0e9b5069e80a65f21736","unresolved":false,"context_lines":[{"line_number":831,"context_line":"                node.driver_info, \"******\")"},{"line_number":832,"context_line":"        if not show_instance_secrets and node.instance_info !\u003d wtypes.Unset:"},{"line_number":833,"context_line":"            node.instance_info \u003d strutils.mask_dict_password("},{"line_number":834,"context_line":"                node.instance_info, \"******\")"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"        update_state_in_older_versions(node)"},{"line_number":837,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3ac371cc_147b848d","line":834,"updated":"2016-08-16 22:49:44.000000000","message":"Is this going to catch the case mentioned by mat128 in IRC of the image_url? This is also an instance secret that should be excluded by this option.","commit_id":"c11bb036e661b1e959d68460d24a5245275cdc68"}],"ironic/common/context.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2b8df86312ed527db61ad2eb040950448844c185","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def __init__(self, auth_token\u003dNone, domain_id\u003dNone, domain_name\u003dNone,"},{"line_number":22,"context_line":"                 user\u003dNone, tenant\u003dNone, is_admin\u003dFalse, is_public_api\u003dFalse,"},{"line_number":23,"context_line":"                 read_only\u003dFalse, show_deleted\u003dFalse, request_id\u003dNone,"},{"line_number":24,"context_line":"                 roles\u003dNone, overwrite\u003dTrue):"},{"line_number":25,"context_line":"        \"\"\"Initialize the RequestContext"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param auth_token: The authentication token of the current request."}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_b6b66b88","line":24,"updated":"2016-08-26 15:31:15.000000000","message":"I don\u0027t expect RequestContext to be used outside of ironic tree. Do you think this change will affect out-of-tree drivers? Or something else?","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9fa65381366ba2321c90f46c1327f2d929680ed","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def __init__(self, auth_token\u003dNone, domain_id\u003dNone, domain_name\u003dNone,"},{"line_number":22,"context_line":"                 user\u003dNone, tenant\u003dNone, is_admin\u003dFalse, is_public_api\u003dFalse,"},{"line_number":23,"context_line":"                 read_only\u003dFalse, show_deleted\u003dFalse, request_id\u003dNone,"},{"line_number":24,"context_line":"                 roles\u003dNone, overwrite\u003dTrue):"},{"line_number":25,"context_line":"        \"\"\"Initialize the RequestContext"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        :param auth_token: The authentication token of the current request."}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_203a5e99","line":24,"updated":"2016-08-18 10:28:41.000000000","message":"I\u0027m not sure about this place, do we care about backwards compatibility here? I have a patch adding user/project domains to the context, but I was still leaving things like domain_id and domain_name (which are in fact user domain_id/name in ironic) here just in case someone is using them.","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"}],"ironic/common/policy.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"55b1033aa2f73d2bfc6fe63fabb399b6a4ef21c6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    policy.RuleDefault(\u0027show_password\u0027,"},{"line_number":43,"context_line":"                       \u0027!\u0027,"},{"line_number":44,"context_line":"                       description\u003d\u0027Show or mask passwords in API responses\u0027),"},{"line_number":45,"context_line":"    # Generic default to hide configrdive contents"},{"line_number":46,"context_line":"    policy.RuleDefault(\u0027show_configdrive\u0027,"},{"line_number":47,"context_line":"                       \u0027!\u0027,"},{"line_number":48,"context_line":"                       description\u003d\u0027Show or mask configdrive contents in API responses\u0027),  # noqa"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_21f1c66b","line":45,"updated":"2016-08-11 19:25:52.000000000","message":"s/configrdrive/configdrive/","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2b8df86312ed527db61ad2eb040950448844c185","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    policy.RuleDefault(\u0027public_api\u0027,"},{"line_number":39,"context_line":"                       \u0027is_public_api:True\u0027,"},{"line_number":40,"context_line":"                       description\u003d\u0027Internal flag for public API routes\u0027),"},{"line_number":41,"context_line":"    # Generic default to hide passwords"},{"line_number":42,"context_line":"    # NOTE(deva): the \u0027show_password\u0027 policy setting hides secrets in"},{"line_number":43,"context_line":"    #             driver_info. However, the name exists for legacy"},{"line_number":44,"context_line":"    #             purposes and can not be changed. Changing it will cause"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_56919fef","line":41,"updated":"2016-08-26 15:31:15.000000000","message":"also updating this comment","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34adfb4cd99b3af3e7284bd884bd0a9a1ab18875","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    policy.RuleDefault(\u0027show_password\u0027,"},{"line_number":48,"context_line":"                       \u0027!\u0027,"},{"line_number":49,"context_line":"                       description\u003d\u0027Show or mask secrets within driver_info in API responses\u0027),  # noqa"},{"line_number":50,"context_line":"    # Generic default to hide configdrive contents"},{"line_number":51,"context_line":"    policy.RuleDefault(\u0027show_instance_secrets\u0027,"},{"line_number":52,"context_line":"                       \u0027!\u0027,"},{"line_number":53,"context_line":"                       description\u003d\u0027Show or mask secrets within instance_info in API responses\u0027),  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_7f4a5d27","line":50,"updated":"2016-08-17 18:43:18.000000000","message":"not just configdrive contents.","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2b8df86312ed527db61ad2eb040950448844c185","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    policy.RuleDefault(\u0027show_password\u0027,"},{"line_number":48,"context_line":"                       \u0027!\u0027,"},{"line_number":49,"context_line":"                       description\u003d\u0027Show or mask secrets within driver_info in API responses\u0027),  # noqa"},{"line_number":50,"context_line":"    # Generic default to hide configdrive contents"},{"line_number":51,"context_line":"    policy.RuleDefault(\u0027show_instance_secrets\u0027,"},{"line_number":52,"context_line":"                       \u0027!\u0027,"},{"line_number":53,"context_line":"                       description\u003d\u0027Show or mask secrets within instance_info in API responses\u0027),  # noqa"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_76bce36c","line":50,"updated":"2016-08-26 15:31:15.000000000","message":"updated","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0b281fb56c8f69b84badcd65c47dd63e0b8c4ed6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    #             the value of this field"},{"line_number":47,"context_line":"    policy.RuleDefault(\u0027show_password\u0027,"},{"line_number":48,"context_line":"                       \u0027!\u0027,"},{"line_number":49,"context_line":"                       description\u003d\u0027Show or mask secrets within node driver information in API responses\u0027),  # noqa"},{"line_number":50,"context_line":"    # Generic default to hide instance secrets"},{"line_number":51,"context_line":"    policy.RuleDefault(\u0027show_instance_secrets\u0027,"},{"line_number":52,"context_line":"                       \u0027!\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_7002e370","line":49,"updated":"2016-08-29 09:54:50.000000000","message":"Nit: would be better to just break it in two lines since it\u0027s easy (it\u0027s a string) then using \"# noqa\" IMO","commit_id":"dc0dad97737dcd0dadd1a56eb094cd76207229f0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0b281fb56c8f69b84badcd65c47dd63e0b8c4ed6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    # Generic default to hide instance secrets"},{"line_number":51,"context_line":"    policy.RuleDefault(\u0027show_instance_secrets\u0027,"},{"line_number":52,"context_line":"                       \u0027!\u0027,"},{"line_number":53,"context_line":"                       description\u003d\u0027Show or mask secrets within instance information in API responses\u0027),  # noqa"},{"line_number":54,"context_line":"    # Roles likely to be overriden by operator"},{"line_number":55,"context_line":"    policy.RuleDefault(\u0027is_member\u0027,"},{"line_number":56,"context_line":"                       \u0027tenant:demo or tenant:baremetal\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_d0f3af9c","line":53,"updated":"2016-08-29 09:54:50.000000000","message":"ditto","commit_id":"dc0dad97737dcd0dadd1a56eb094cd76207229f0"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"55b1033aa2f73d2bfc6fe63fabb399b6a4ef21c6","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        if not show_password:"},{"line_number":811,"context_line":"            ndict[\u0027driver_info\u0027] \u003d strutils.mask_dict_password("},{"line_number":812,"context_line":"                ndict[\u0027driver_info\u0027], \"******\")"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"        return {"},{"line_number":815,"context_line":"            # heartbeat_timeout is a config, so moving it into the"},{"line_number":816,"context_line":"            # config namespace. Instead of a separate deprecation,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_2429d48a","line":813,"updated":"2016-08-11 19:25:52.000000000","message":"Should we do a similar thing for configdrive?","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2b8df86312ed527db61ad2eb040950448844c185","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        if not show_driver_secrets:"},{"line_number":811,"context_line":"            ndict[\u0027driver_info\u0027] \u003d strutils.mask_dict_password("},{"line_number":812,"context_line":"                ndict[\u0027driver_info\u0027], \"******\")"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"        return {"},{"line_number":815,"context_line":"            # heartbeat_timeout is a config, so moving it into the"},{"line_number":816,"context_line":"            # config namespace. Instead of a separate deprecation,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_96c167e7","line":813,"updated":"2016-08-26 15:31:15.000000000","message":"No, I don\u0027t think so. AIUI, /lookup is used by the agent to fetch the configdrive, so it needs to return instance secrets, but it should not return driver_info secrets.","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34adfb4cd99b3af3e7284bd884bd0a9a1ab18875","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        if not show_driver_secrets:"},{"line_number":811,"context_line":"            ndict[\u0027driver_info\u0027] \u003d strutils.mask_dict_password("},{"line_number":812,"context_line":"                ndict[\u0027driver_info\u0027], \"******\")"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"        return {"},{"line_number":815,"context_line":"            # heartbeat_timeout is a config, so moving it into the"},{"line_number":816,"context_line":"            # config namespace. Instead of a separate deprecation,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_1fbc09db","line":813,"updated":"2016-08-17 18:43:18.000000000","message":"Should we do a similar thing for show_instance_secrets, in ndict[\u0027instance_info\u0027] if it exists?","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9fa65381366ba2321c90f46c1327f2d929680ed","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        if not show_driver_secrets:"},{"line_number":811,"context_line":"            ndict[\u0027driver_info\u0027] \u003d strutils.mask_dict_password("},{"line_number":812,"context_line":"                ndict[\u0027driver_info\u0027], \"******\")"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"        return {"},{"line_number":815,"context_line":"            # heartbeat_timeout is a config, so moving it into the"},{"line_number":816,"context_line":"            # config namespace. Instead of a separate deprecation,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_e09e8661","line":813,"in_reply_to":"3ac371cc_1fbc09db","updated":"2016-08-18 10:28:41.000000000","message":"++, also if instance secrets should be hidden here, /lookup endpoint should hide them too, as instance_info is in _LOOKUP_RETURN_FIELDS.","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5a33e554415eb6959dddd91ac7b4747571e4625a","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        if not show_driver_secrets:"},{"line_number":811,"context_line":"            ndict[\u0027driver_info\u0027] \u003d strutils.mask_dict_password("},{"line_number":812,"context_line":"                ndict[\u0027driver_info\u0027], \"******\")"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"        return {"},{"line_number":815,"context_line":"            # heartbeat_timeout is a config, so moving it into the"},{"line_number":816,"context_line":"            # config namespace. Instead of a separate deprecation,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa7ab95a_e0dd7e15","line":813,"in_reply_to":"fa7ab95a_96c167e7","updated":"2016-08-26 17:59:33.000000000","message":"+1 Deva\u0027s comment is correct","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"}],"releasenotes/notes/mask-configdrive-contents-77fc557d6bc63b2b.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"edff30bc45bb0f70b1d3d5d755c78d429cb5221e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    are already masked."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - After this change, configdrive contents will, by default, be masked in API"},{"line_number":10,"context_line":"    responses.  Operators wishing to expose the configdrive contents to"},{"line_number":11,"context_line":"    specific users will need to update their policy.json file and grant the"},{"line_number":12,"context_line":"    relevant keystone roles."},{"line_number":13,"context_line":"security:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9ad45d7e_3ff29f9a","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":16},"updated":"2016-08-11 10:18:12.000000000","message":"nit: extra space","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"edff30bc45bb0f70b1d3d5d755c78d429cb5221e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"security:"},{"line_number":14,"context_line":"  - Configdrive contents often contain sensitive information. This information"},{"line_number":15,"context_line":"    may be selectively exposed to privileged users, but should not necessarily"},{"line_number":16,"context_line":"    be exposed to every authenticated user.  This change improves security by"},{"line_number":17,"context_line":"    allowing a cloud operator to restrict the set of users who have access to"},{"line_number":18,"context_line":"    view the configdrive contents."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9ad45d7e_9f374b4c","line":16,"range":{"start_line":16,"start_character":43,"end_line":16,"end_character":45},"updated":"2016-08-11 10:18:12.000000000","message":"nit: extra space","commit_id":"ae72d9512e96ce49d645ebabc696ebef45709875"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34adfb4cd99b3af3e7284bd884bd0a9a1ab18875","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The contents of an instance confidrive, stored at"},{"line_number":4,"context_line":"    node/instance_info[\u0027configdrive\u0027], may be quite large and, if used, will"},{"line_number":5,"context_line":"    currently bloat API responses. This change adds a new policy rule that may"},{"line_number":6,"context_line":"    be used to mask configdrive contents in API responses, much like passwords"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3ac371cc_dffa7142","line":3,"updated":"2016-08-17 18:43:18.000000000","message":"s/confidrive/configdrive/\n\nDo we want to mention image_url? We\u0027re doing this not because configdrive is large, but because it most likely will include sensitive information. Maybe we should just generalize it. Might be useful to mention the new \u0027show_instance_secrets\u0027 rule/thing.","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34adfb4cd99b3af3e7284bd884bd0a9a1ab18875","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  - After this change, configdrive contents will, by default, be masked in API"},{"line_number":10,"context_line":"    responses.  Operators wishing to expose the configdrive contents to"},{"line_number":11,"context_line":"    specific users will need to update their policy.json file and grant the"},{"line_number":12,"context_line":"    relevant keystone roles."},{"line_number":13,"context_line":"security:"},{"line_number":14,"context_line":"  - Configdrive contents often contain sensitive information. This information"},{"line_number":15,"context_line":"    may be selectively exposed to privileged users, but should not necessarily"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3ac371cc_ff692dfa","line":12,"updated":"2016-08-17 18:43:18.000000000","message":"Maybe generalize this to instance information that is sensitive, such as configdrive and image URL.","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2b8df86312ed527db61ad2eb040950448844c185","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  - After this change, configdrive contents will, by default, be masked in API"},{"line_number":10,"context_line":"    responses.  Operators wishing to expose the configdrive contents to"},{"line_number":11,"context_line":"    specific users will need to update their policy.json file and grant the"},{"line_number":12,"context_line":"    relevant keystone roles."},{"line_number":13,"context_line":"security:"},{"line_number":14,"context_line":"  - Configdrive contents often contain sensitive information. This information"},{"line_number":15,"context_line":"    may be selectively exposed to privileged users, but should not necessarily"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"fa7ab95a_168717b6","line":12,"updated":"2016-08-26 15:31:15.000000000","message":"done","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"34adfb4cd99b3af3e7284bd884bd0a9a1ab18875","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    may be selectively exposed to privileged users, but should not necessarily"},{"line_number":16,"context_line":"    be exposed to every authenticated user.  This change improves security by"},{"line_number":17,"context_line":"    allowing a cloud operator to restrict the set of users who have access to"},{"line_number":18,"context_line":"    view the configdrive contents."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3ac371cc_ff500d34","line":18,"updated":"2016-08-17 18:43:18.000000000","message":"ditto about generalizing and/or including image_url.","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2b8df86312ed527db61ad2eb040950448844c185","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    may be selectively exposed to privileged users, but should not necessarily"},{"line_number":16,"context_line":"    be exposed to every authenticated user.  This change improves security by"},{"line_number":17,"context_line":"    allowing a cloud operator to restrict the set of users who have access to"},{"line_number":18,"context_line":"    view the configdrive contents."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"fa7ab95a_36941be1","line":18,"updated":"2016-08-26 15:31:15.000000000","message":"done","commit_id":"1bd21656b341b1b8980375826f9b1f81530063ac"}]}
