)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"08644c76e8f5db4be26c7636ff035ef12f3c4136","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add cleanwait timeout cleanup process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously, if a node in a cleaning state timed out, the timeout"},{"line_number":10,"context_line":"process would not purce certain items from the node\u0027s configuration"},{"line_number":11,"context_line":"which resulted in a short circuiting of the logic cleaning being"},{"line_number":12,"context_line":"retried. This was a result of the node clean_step configuration"},{"line_number":13,"context_line":"not being purged upon a timeout occuring."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_ffa144f8","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":23},"updated":"2016-06-13 20:45:09.000000000","message":"nit: s/purce/purge/","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b307c5cd7cd4d1ad9c79abab1fef58797c880a01","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add cleanwait timeout cleanup process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously, if a node in a cleaning state timed out, the timeout"},{"line_number":10,"context_line":"process would not purce certain items from the node\u0027s configuration"},{"line_number":11,"context_line":"which resulted in a short circuiting of the logic cleaning being"},{"line_number":12,"context_line":"retried. This was a result of the node clean_step configuration"},{"line_number":13,"context_line":"not being purged upon a timeout occuring."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_b3dc10e5","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":23},"in_reply_to":"7aa08908_ffa144f8","updated":"2016-06-13 21:16:41.000000000","message":"Done","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"}],"ironic/conductor/utils.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"17b5cf77dee82933fcd5a92e9643f05e188c8408","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    \"\"\""},{"line_number":210,"context_line":"    last_error \u003d _(\"Timeout reached while cleaning the node. Please \""},{"line_number":211,"context_line":"                   \"check if the ramdisk responsible for the cleaning is \""},{"line_number":212,"context_line":"                   \"running on the node.\")"},{"line_number":213,"context_line":"    cleaning_error_handler(task, msg\u003dlast_error,"},{"line_number":214,"context_line":"                           set_fail_state\u003dTrue)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0e321c5e","line":212,"updated":"2016-06-13 20:15:32.000000000","message":"Can we throw node.clean_step in here so we don\u0027t lose that info from a debuggability standpoint?","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"08644c76e8f5db4be26c7636ff035ef12f3c4136","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            states.CLEANING,"},{"line_number":223,"context_line":"            states.CLEANWAIT,"},{"line_number":224,"context_line":"            states.CLEANFAIL):"},{"line_number":225,"context_line":"        # Clear clean step, msg should already include current step"},{"line_number":226,"context_line":"        node.clean_step \u003d {}"},{"line_number":227,"context_line":"        info \u003d node.driver_internal_info"},{"line_number":228,"context_line":"        info.pop(\u0027clean_step_index\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_100a3a8a","line":225,"updated":"2016-06-13 20:45:09.000000000","message":"Seems to imply that the clean_step should be part of the message.","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b307c5cd7cd4d1ad9c79abab1fef58797c880a01","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            states.CLEANING,"},{"line_number":223,"context_line":"            states.CLEANWAIT,"},{"line_number":224,"context_line":"            states.CLEANFAIL):"},{"line_number":225,"context_line":"        # Clear clean step, msg should already include current step"},{"line_number":226,"context_line":"        node.clean_step \u003d {}"},{"line_number":227,"context_line":"        info \u003d node.driver_internal_info"},{"line_number":228,"context_line":"        info.pop(\u0027clean_step_index\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f3c5f85b","line":225,"in_reply_to":"7aa08908_100a3a8a","updated":"2016-06-13 21:16:41.000000000","message":"Should be addressed by new revision.","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"08644c76e8f5db4be26c7636ff035ef12f3c4136","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        self.assertEqual(states.CLEANFAIL, node.provision_state)"},{"line_number":1115,"context_line":"        self.assertEqual(tgt_prov_state, node.target_provision_state)"},{"line_number":1116,"context_line":"        self.assertIsNotNone(node.last_error)"},{"line_number":1117,"context_line":"        # Test that cleaning paramters have been purged in order"},{"line_number":1118,"context_line":"        # to prevent looping of the cleaning sequence"},{"line_number":1119,"context_line":"        self.assertEqual({}, node.clean_step)"},{"line_number":1120,"context_line":"        self.assertFalse(\u0027clean_step_index\u0027 in node.driver_internal_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_5f14d8e7","line":1117,"range":{"start_line":1117,"start_character":29,"end_line":1117,"end_character":38},"updated":"2016-06-13 20:45:09.000000000","message":"nit: s/paramters/parameters/","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b307c5cd7cd4d1ad9c79abab1fef58797c880a01","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        self.assertEqual(states.CLEANFAIL, node.provision_state)"},{"line_number":1115,"context_line":"        self.assertEqual(tgt_prov_state, node.target_provision_state)"},{"line_number":1116,"context_line":"        self.assertIsNotNone(node.last_error)"},{"line_number":1117,"context_line":"        # Test that cleaning paramters have been purged in order"},{"line_number":1118,"context_line":"        # to prevent looping of the cleaning sequence"},{"line_number":1119,"context_line":"        self.assertEqual({}, node.clean_step)"},{"line_number":1120,"context_line":"        self.assertFalse(\u0027clean_step_index\u0027 in node.driver_internal_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f3efb8ae","line":1117,"range":{"start_line":1117,"start_character":29,"end_line":1117,"end_character":38},"in_reply_to":"7aa08908_5f14d8e7","updated":"2016-06-13 21:16:41.000000000","message":"Done","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"08644c76e8f5db4be26c7636ff035ef12f3c4136","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"        # Test that cleaning paramters have been purged in order"},{"line_number":1118,"context_line":"        # to prevent looping of the cleaning sequence"},{"line_number":1119,"context_line":"        self.assertEqual({}, node.clean_step)"},{"line_number":1120,"context_line":"        self.assertFalse(\u0027clean_step_index\u0027 in node.driver_internal_info)"},{"line_number":1121,"context_line":"        self.assertFalse(\u0027cleaning_reboot\u0027 in node.driver_internal_info)"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def test__check_cleanwait_timeouts_automated_clean(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_b03b66d0","line":1120,"updated":"2016-06-13 20:45:09.000000000","message":"nit:\n\n self.assertNotIn(\u0027clean_step_index\u0027, node.driver_internal_info)\n\nProvides a little bit better error message if it fails.","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b307c5cd7cd4d1ad9c79abab1fef58797c880a01","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"        # Test that cleaning paramters have been purged in order"},{"line_number":1118,"context_line":"        # to prevent looping of the cleaning sequence"},{"line_number":1119,"context_line":"        self.assertEqual({}, node.clean_step)"},{"line_number":1120,"context_line":"        self.assertFalse(\u0027clean_step_index\u0027 in node.driver_internal_info)"},{"line_number":1121,"context_line":"        self.assertFalse(\u0027cleaning_reboot\u0027 in node.driver_internal_info)"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def test__check_cleanwait_timeouts_automated_clean(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d3ec3cbd","line":1120,"in_reply_to":"7aa08908_b03b66d0","updated":"2016-06-13 21:16:41.000000000","message":"Done","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"08644c76e8f5db4be26c7636ff035ef12f3c4136","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"        # to prevent looping of the cleaning sequence"},{"line_number":1119,"context_line":"        self.assertEqual({}, node.clean_step)"},{"line_number":1120,"context_line":"        self.assertFalse(\u0027clean_step_index\u0027 in node.driver_internal_info)"},{"line_number":1121,"context_line":"        self.assertFalse(\u0027cleaning_reboot\u0027 in node.driver_internal_info)"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def test__check_cleanwait_timeouts_automated_clean(self):"},{"line_number":1124,"context_line":"        self._check_cleanwait_timeouts()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f0316eee","line":1121,"updated":"2016-06-13 20:45:09.000000000","message":"nit:\n\nassertNotIn","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b307c5cd7cd4d1ad9c79abab1fef58797c880a01","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"        # to prevent looping of the cleaning sequence"},{"line_number":1119,"context_line":"        self.assertEqual({}, node.clean_step)"},{"line_number":1120,"context_line":"        self.assertFalse(\u0027clean_step_index\u0027 in node.driver_internal_info)"},{"line_number":1121,"context_line":"        self.assertFalse(\u0027cleaning_reboot\u0027 in node.driver_internal_info)"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def test__check_cleanwait_timeouts_automated_clean(self):"},{"line_number":1124,"context_line":"        self._check_cleanwait_timeouts()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_332ca001","line":1121,"in_reply_to":"7aa08908_f0316eee","updated":"2016-06-13 21:16:41.000000000","message":"Done","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"}],"ironic/tests/unit/conductor/test_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"08644c76e8f5db4be26c7636ff035ef12f3c4136","unresolved":false,"context_lines":[{"line_number":594,"context_line":"            \u0027clean_step_index\u0027: 0}"},{"line_number":595,"context_line":"        conductor_utils.cleanup_cleanwait_timeout(self.task)"},{"line_number":596,"context_line":"        self.assertEqual({}, self.node.clean_step)"},{"line_number":597,"context_line":"        self.assertFalse(\u0027clean_step_index\u0027 in self.node.driver_internal_info)"},{"line_number":598,"context_line":"        self.task.process_event.assert_called_once()"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def test_cleaning_error_handler(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f0484e5e","line":597,"updated":"2016-06-13 20:45:09.000000000","message":"self.AssertNotIn\n\nhttps://testtools.readthedocs.io/en/latest/for-test-authors.html","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"db6a673e5075ba492ef2c54e4d7813a95bf20a6e","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        conductor_utils.cleanup_cleanwait_timeout(self.task)"},{"line_number":596,"context_line":"        self.assertEqual({}, self.node.clean_step)"},{"line_number":597,"context_line":"        self.assertFalse(\u0027clean_step_index\u0027 in self.node.driver_internal_info)"},{"line_number":598,"context_line":"        self.task.process_event.assert_called_once()"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def test_cleaning_error_handler(self):"},{"line_number":601,"context_line":"        self.node.provision_state \u003d states.CLEANING"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e3dc6248","line":598,"updated":"2016-06-10 15:19:57.000000000","message":"NIT: we could check that maintenance mode and maintenance reason are correctly set. But as that is tested below in the next test I am okay with it as is.","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b307c5cd7cd4d1ad9c79abab1fef58797c880a01","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        conductor_utils.cleanup_cleanwait_timeout(self.task)"},{"line_number":596,"context_line":"        self.assertEqual({}, self.node.clean_step)"},{"line_number":597,"context_line":"        self.assertFalse(\u0027clean_step_index\u0027 in self.node.driver_internal_info)"},{"line_number":598,"context_line":"        self.task.process_event.assert_called_once()"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def test_cleaning_error_handler(self):"},{"line_number":601,"context_line":"        self.node.provision_state \u003d states.CLEANING"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_137fe4e0","line":598,"in_reply_to":"7aa08908_e3dc6248","updated":"2016-06-13 21:16:41.000000000","message":"Done","commit_id":"22e3d9e1b5615f92d74b9aa95b1a5ae0dc334011"}],"releasenotes/notes/cleaning-retry-fix-89a5d0e65920a064.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a82722f09cf49bfe058355b0508d5e7d97b9962f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - A bug has been corrected where a node\u0027s current clean_step"},{"line_number":4,"context_line":"    was not purged upon that node timing out from a CLEANWAIT state."},{"line_number":5,"context_line":"    Previously, this bug would prevent a user from retrying cleaning"},{"line_number":6,"context_line":"    operations."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_da653645","line":3,"updated":"2016-06-08 22:52:57.000000000","message":"Shouldn\u0027t we put the bug number in the reno?","commit_id":"a0dfeeef5770a50cac444881ce68a85c991d2cc6"}]}
