)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40473bc65b428ea9a6eb6a9678fd45fee60a28c3","unresolved":false,"context_lines":[{"line_number":136,"context_line":"# If not use DIB, these files are used as deploy ramdisk/kernel."},{"line_number":137,"context_line":"# (The value must be an absolute path)"},{"line_number":138,"context_line":"IRONIC_DEPLOY_RAMDISK\u003d${IRONIC_DEPLOY_RAMDISK:-}"},{"line_number":139,"context_line":"IRONIC_DEPLOY_KERNEL\u003d${IRONIC_DEPLOY_KERNEL:-}"},{"line_number":140,"context_line":"IRONIC_DEPLOY_ELEMENT\u003d${IRONIC_DEPLOY_ELEMENT:-deploy-ironic}"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# NOTE(jroll) this needs to be updated when stable branches are cut"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_83da3076","line":139,"updated":"2016-06-14 16:35:52.000000000","message":"we can also set these 2 files to local paths, we should check if they\u0027re empty as well","commit_id":"3c1dea3e9d086a4fa90ba4f49b792dcb5c08f380"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"09859aaa0a858476e88f6589dea79e04602d84f7","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"# Configure URLs required to download ramdisk if we\u0027re not building it, and"},{"line_number":152,"context_line":"# IRONIC_DEPLOY_RAMDISK/KERNEL have not been preconfigured."},{"line_number":153,"context_line":"if [ \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d \"False\" ] \u0026\u0026 [ -z \"$IRONIC_DEPLOY_RAMDISK\" ] \u0026\u0026 [ -z \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":154,"context_line":"    case $IRONIC_RAMDISK_TYPE in"},{"line_number":155,"context_line":"        coreos)"},{"line_number":156,"context_line":"            IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-https://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe-${IPA_DOWNLOAD_BRANCH}.vmlinuz}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3aaa91ec_252cef49","line":153,"updated":"2016-06-21 23:53:55.000000000","message":"What if someone set IRONIC_AGENT_KERNEL_URL (and RAMDISK_URL), shouldn\u0027t we not fail them out or send them down this codepath at all?\n\nIt\u0027s clearly supported today in the existing code, even if unintended.","commit_id":"30a8bfbfbd520298b9aae43f2efbdb1cbb025497"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"3270213c6a3a36e7f2bf69c0b44c2ed9947d0abd","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"# Configure URLs required to download ramdisk if we\u0027re not building it, and"},{"line_number":152,"context_line":"# IRONIC_DEPLOY_RAMDISK/KERNEL have not been preconfigured."},{"line_number":153,"context_line":"if [ \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d \"False\" ] \u0026\u0026 [ -z \"$IRONIC_DEPLOY_RAMDISK\" ] \u0026\u0026 [ -z \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":154,"context_line":"    case $IRONIC_RAMDISK_TYPE in"},{"line_number":155,"context_line":"        coreos)"},{"line_number":156,"context_line":"            IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-https://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe-${IPA_DOWNLOAD_BRANCH}.vmlinuz}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3aaa91ec_97ee9889","line":153,"in_reply_to":"3aaa91ec_252cef49","updated":"2016-06-22 12:31:55.000000000","message":"IRONIC_BUILD_DEPLOY_RAMDISK\u003d\"True\"\nand\nIRONIC_AGENT_KERNEL/RAMDISK_URL is set in local.conf?\n\nThe current behaviour of our devstack plugin is that if IRONIC_BUILD_DEPLOY_RAMDISK\u003d\u003d\"True\" the URLs are ignored.\n\nCurrently the only point this changes the behaviour is if someone provides custom URLs but has IRONIC_BUILD_DEPLOY_RAMDISK\u003d\u003d\"False\" and IRONIC_RAMDISK_TYPE \u003d\u003d dib. In which case it dies, so I think I need to change that.","commit_id":"30a8bfbfbd520298b9aae43f2efbdb1cbb025497"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"60da74e8796e5530d8a376503a195fe23b7cbb78","unresolved":false,"context_lines":[{"line_number":131,"context_line":"IRONIC_BUILD_DEPLOY_RAMDISK\u003d$(trueorfalse True IRONIC_BUILD_DEPLOY_RAMDISK)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"# Ironic IPA ramdisk type, supported types are:"},{"line_number":134,"context_line":"SUPPORTED_RAMDISK_TYPES\u003d\"coreos tinyipa dib\""},{"line_number":135,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-tinyipa}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Confirm we have a supported ramdisk type or fail early."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_9ef1d797","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":23},"updated":"2016-06-27 08:41:53.000000000","message":"nit: s/SUPPORTED_RAMDISK_TYPES/IRONIC_SUPPORTED_RAMDISK_TYPES because perhaps this will be deprecated with other projects.","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"789b3c1ab2143bb56c9aac8a77f60456516b12a3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"IRONIC_BUILD_DEPLOY_RAMDISK\u003d$(trueorfalse True IRONIC_BUILD_DEPLOY_RAMDISK)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"# Ironic IPA ramdisk type, supported types are:"},{"line_number":134,"context_line":"SUPPORTED_RAMDISK_TYPES\u003d\"coreos tinyipa dib\""},{"line_number":135,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-tinyipa}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Confirm we have a supported ramdisk type or fail early."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_a58d9b32","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":23},"in_reply_to":"3aaa91ec_9ef1d797","updated":"2016-06-27 11:01:35.000000000","message":"Done","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395bdc2778b5d1b1bd3046aac9436f4b9a56e997","unresolved":false,"context_lines":[{"line_number":135,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-tinyipa}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":138,"context_line":"if [[ ! $SUPPORTED_RAMDISK_TYPES \u003d~ (^| )$IRONIC_RAMDISK_TYPE( |$) ]]; then"},{"line_number":139,"context_line":"    die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""},{"line_number":140,"context_line":"fi"},{"line_number":141,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_5d3355ab","line":138,"range":{"start_line":138,"start_character":36,"end_line":138,"end_character":66},"updated":"2016-06-23 20:40:00.000000000","message":"I would prefer this to be wrapped in double quotes\n\nAlso, what do you think of this?\n\n SUPPORTED_RAMDISK_TYPES_RE\u003d\"(coreos|tinyipa|dib)\"\n if [[ ! $IRONIC_RAMDISK_TYPE \u003d~ $SUPPORTED_RAMDISK_TYPES_RE ]]; then","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"789b3c1ab2143bb56c9aac8a77f60456516b12a3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-tinyipa}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":138,"context_line":"if [[ ! $SUPPORTED_RAMDISK_TYPES \u003d~ (^| )$IRONIC_RAMDISK_TYPE( |$) ]]; then"},{"line_number":139,"context_line":"    die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""},{"line_number":140,"context_line":"fi"},{"line_number":141,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_05aaaf84","line":138,"range":{"start_line":138,"start_character":36,"end_line":138,"end_character":66},"in_reply_to":"3aaa91ec_5d3355ab","updated":"2016-06-27 11:01:35.000000000","message":"Done","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395bdc2778b5d1b1bd3046aac9436f4b9a56e997","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":138,"context_line":"if [[ ! $SUPPORTED_RAMDISK_TYPES \u003d~ (^| )$IRONIC_RAMDISK_TYPE( |$) ]]; then"},{"line_number":139,"context_line":"    die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""},{"line_number":140,"context_line":"fi"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# If present, these files are used as deploy ramdisk/kernel."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_7d061187","line":139,"range":{"start_line":139,"start_character":17,"end_line":139,"end_character":29},"updated":"2016-06-23 20:40:00.000000000","message":"Unrecognized ;)","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"789b3c1ab2143bb56c9aac8a77f60456516b12a3","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":138,"context_line":"if [[ ! $SUPPORTED_RAMDISK_TYPES \u003d~ (^| )$IRONIC_RAMDISK_TYPE( |$) ]]; then"},{"line_number":139,"context_line":"    die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""},{"line_number":140,"context_line":"fi"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# If present, these files are used as deploy ramdisk/kernel."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_25936b5c","line":139,"range":{"start_line":139,"start_character":17,"end_line":139,"end_character":29},"in_reply_to":"3aaa91ec_7d061187","updated":"2016-06-27 11:01:35.000000000","message":"Done","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395bdc2778b5d1b1bd3046aac9436f4b9a56e997","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.gz}"},{"line_number":165,"context_line":"        ;;"},{"line_number":166,"context_line":"        dib)"},{"line_number":167,"context_line":"            die \"IRONIC_RAMDISK_TYPE \u0027dib\u0027 has no offical pre-built \"\\"},{"line_number":168,"context_line":"                \"images, select a different ramdisk type, set \"\\"},{"line_number":169,"context_line":"                \"IRONIC_BUILD_DEPLOY_RAMDISK\u003dTrue, or manually configure \"\\"},{"line_number":170,"context_line":"                \"IRONIC_DEPLOY_RAMDISK(_URL) and IRONIC_DEPLOY_KERNEL(_URL) \"\\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_5d8075c0","line":167,"range":{"start_line":167,"start_character":50,"end_line":167,"end_character":57},"updated":"2016-06-23 20:40:00.000000000","message":"official","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"789b3c1ab2143bb56c9aac8a77f60456516b12a3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-https://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.gz}"},{"line_number":165,"context_line":"        ;;"},{"line_number":166,"context_line":"        dib)"},{"line_number":167,"context_line":"            die \"IRONIC_RAMDISK_TYPE \u0027dib\u0027 has no offical pre-built \"\\"},{"line_number":168,"context_line":"                \"images, select a different ramdisk type, set \"\\"},{"line_number":169,"context_line":"                \"IRONIC_BUILD_DEPLOY_RAMDISK\u003dTrue, or manually configure \"\\"},{"line_number":170,"context_line":"                \"IRONIC_DEPLOY_RAMDISK(_URL) and IRONIC_DEPLOY_KERNEL(_URL) \"\\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_457f9714","line":167,"range":{"start_line":167,"start_character":50,"end_line":167,"end_character":57},"in_reply_to":"3aaa91ec_5d8075c0","updated":"2016-06-27 11:01:35.000000000","message":"Done","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"395bdc2778b5d1b1bd3046aac9436f4b9a56e997","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        ;;"},{"line_number":166,"context_line":"        dib)"},{"line_number":167,"context_line":"            die \"IRONIC_RAMDISK_TYPE \u0027dib\u0027 has no offical pre-built \"\\"},{"line_number":168,"context_line":"                \"images, select a different ramdisk type, set \"\\"},{"line_number":169,"context_line":"                \"IRONIC_BUILD_DEPLOY_RAMDISK\u003dTrue, or manually configure \"\\"},{"line_number":170,"context_line":"                \"IRONIC_DEPLOY_RAMDISK(_URL) and IRONIC_DEPLOY_KERNEL(_URL) \"\\"},{"line_number":171,"context_line":"                \"to use your own pre-built ramdisk.\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_dd0bc528","line":168,"range":{"start_line":168,"start_character":25,"end_line":168,"end_character":34},"updated":"2016-06-23 20:40:00.000000000","message":"to fix this select a ...","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"789b3c1ab2143bb56c9aac8a77f60456516b12a3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        ;;"},{"line_number":166,"context_line":"        dib)"},{"line_number":167,"context_line":"            die \"IRONIC_RAMDISK_TYPE \u0027dib\u0027 has no offical pre-built \"\\"},{"line_number":168,"context_line":"                \"images, select a different ramdisk type, set \"\\"},{"line_number":169,"context_line":"                \"IRONIC_BUILD_DEPLOY_RAMDISK\u003dTrue, or manually configure \"\\"},{"line_number":170,"context_line":"                \"IRONIC_DEPLOY_RAMDISK(_URL) and IRONIC_DEPLOY_KERNEL(_URL) \"\\"},{"line_number":171,"context_line":"                \"to use your own pre-built ramdisk.\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3aaa91ec_a5e2bbd2","line":168,"range":{"start_line":168,"start_character":25,"end_line":168,"end_character":34},"in_reply_to":"3aaa91ec_dd0bc528","updated":"2016-06-27 11:01:35.000000000","message":"Done","commit_id":"56f6c511e91b3708cac4b424581e4805b0140de7"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b3daea45c3ca2d037b534acd34f40c43c4473a2f","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":138,"context_line":"if [[ ! \"$IRONIC_RAMDISK_TYPE\" \u003d~ $IRONIC_SUPPORTED_RAMDISK_TYPES_RE ]]; then"},{"line_number":139,"context_line":"    die $LINENO \"Unrecognized IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""},{"line_number":140,"context_line":"fi"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# If present, these files are used as deploy ramdisk/kernel."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_20707971","line":139,"updated":"2016-06-27 11:17:41.000000000","message":"once we have IRONIC_SUPPORTED_RAMDISK_TYPES_RE regexp, what do you think to s/Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027/Expected ramdisk types regex is: $IRONIC_SUPPORTED_RAMDISK_TYPES_RE/","commit_id":"13d25d4788ac5009f9afe73111bdc6766ff271fb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"15a5c7951731d8ada93b0bc9c3aeae2bccc51774","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":138,"context_line":"if [[ ! \"$IRONIC_RAMDISK_TYPE\" \u003d~ $IRONIC_SUPPORTED_RAMDISK_TYPES_RE ]]; then"},{"line_number":139,"context_line":"    die $LINENO \"Unrecognized IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027, \u0027tinyipa\u0027 or \u0027dib\u0027\""},{"line_number":140,"context_line":"fi"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# If present, these files are used as deploy ramdisk/kernel."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_99670aea","line":139,"in_reply_to":"3aaa91ec_20707971","updated":"2016-06-27 19:33:35.000000000","message":"I think exposing a regex might create more confusion than it would prevent for users who are \"getting started\".  I think the error message, as is, is quite friendly to users.","commit_id":"13d25d4788ac5009f9afe73111bdc6766ff271fb"}]}