)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"89425833d61a28adbcb843eab0211c54cccf8f68","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cpshchelokovskyy@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-17 14:27:45 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deny some driver_info updates when console is on"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As driver_info changes may change console-related properties,"},{"line_number":10,"context_line":"forbid node updates that touch such properties when console is enabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_64cff27f","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":9},"updated":"2016-06-22 14:45:21.000000000","message":"Aren\u0027t you denying all changes to driver_info fields?","commit_id":"c80e216482589d13302bd7c2b3b44cee26b7ed6a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"32999e509265d1bf13d34389c80e281aa44af030","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cpshchelokovskyy@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-17 14:27:45 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deny some driver_info updates when console is on"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As driver_info changes may change console-related properties,"},{"line_number":10,"context_line":"forbid node updates that touch such properties when console is enabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_7942f33f","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":9},"in_reply_to":"3aaa91ec_64cff27f","updated":"2016-06-22 16:20:05.000000000","message":"no, see my comment in ironic/conductor/manager.py","commit_id":"c80e216482589d13302bd7c2b3b44cee26b7ed6a"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"89425833d61a28adbcb843eab0211c54cccf8f68","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deny some driver_info updates when console is on"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As driver_info changes may change console-related properties,"},{"line_number":10,"context_line":"forbid node updates that touch such properties when console is enabled"},{"line_number":11,"context_line":"on the node."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iceef006ee3140ed558cd31bd9f1fd91502938632"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_4422b602","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":46},"updated":"2016-06-22 14:45:21.000000000","message":"s/such properties/driver_info fields/\nI think it\u0027s more clear that way, what do you think?","commit_id":"c80e216482589d13302bd7c2b3b44cee26b7ed6a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"32999e509265d1bf13d34389c80e281aa44af030","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deny some driver_info updates when console is on"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As driver_info changes may change console-related properties,"},{"line_number":10,"context_line":"forbid node updates that touch such properties when console is enabled"},{"line_number":11,"context_line":"on the node."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iceef006ee3140ed558cd31bd9f1fd91502938632"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_1972cfad","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":46},"in_reply_to":"3aaa91ec_4422b602","updated":"2016-06-22 16:20:05.000000000","message":"will change to \n\"console driver interface properties\"","commit_id":"c80e216482589d13302bd7c2b3b44cee26b7ed6a"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f76f8736fbb41f567397e69e9897d968313cb6c6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"on the node, resulting in HTTP 409 (Conflict) response to API call."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Iceef006ee3140ed558cd31bd9f1fd91502938632"},{"line_number":23,"context_line":"Closes-Bug: #1569254"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7f287b81_87e3c7a4","line":23,"updated":"2017-09-04 07:24:44.000000000","message":"Can we close this bug without any implementation?","commit_id":"14b813d55a027fe55f8417a7540e937af3f0d860"}],"ironic/common/exception.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2d997bfd7a250ec569153f6514f98298d216953c","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    _msg_fmt \u003d _(\"Console access is not enabled on node %(node)s\")"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"class NodeConsoleEnabled(Conflict):"},{"line_number":339,"context_line":"    _msg_fmt \u003d _(\"Console access is enabled on node %(node)s - %(err)s\")"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_8987f85f","line":338,"updated":"2016-09-13 15:58:32.000000000","message":"Enabled console is not \"temporary\" state like power transition or DB node update. As you mentioned ironic clients by default makes retries on 409, this can produce a lot of unnecessary retries in mass update case.","commit_id":"43cb6b53dfdeb361d8bf3f954d2da2abed72c2de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"3c7fedffce810cab15c09f9ec020058b007995cf","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    _msg_fmt \u003d _(\"Console access is not enabled on node %(node)s\")"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"class NodeConsoleEnabled(Conflict):"},{"line_number":339,"context_line":"    _msg_fmt \u003d _(\"Console access is enabled on node %(node)s - %(err)s\")"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_ff635b3f","line":338,"in_reply_to":"7a8ec9b2_2523febe","updated":"2016-09-14 16:35:48.000000000","message":"Having re-read HTTP codes definitions RFC \nhttps://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html\nI now tend to disagree.\n\nConflict IS the error to return in this situation:\n\n  This code is only allowed in situations where it is expected\n  that the user might be able to resolve the conflict and\n  resubmit the request.\n\nwhich exactly fits \"please disable console and try again\".\n\nThe fact that we are abusing code 409 for situations when user actually can not do anything but wait, and our default client relies on that, just means that our API and client are not fully compliant with this RFC.","commit_id":"43cb6b53dfdeb361d8bf3f954d2da2abed72c2de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"aefcbf27ea5143b44bf306e1f8bee48de8a0ab2d","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    _msg_fmt \u003d _(\"Console access is not enabled on node %(node)s\")"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"class NodeConsoleEnabled(Conflict):"},{"line_number":339,"context_line":"    _msg_fmt \u003d _(\"Console access is enabled on node %(node)s - %(err)s\")"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_2523febe","line":338,"in_reply_to":"9a89bdaa_8987f85f","updated":"2016-09-14 14:22:48.000000000","message":"Agree to some extent, will change to Invalid.","commit_id":"43cb6b53dfdeb361d8bf3f954d2da2abed72c2de"}],"ironic/conductor/manager.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"32999e509265d1bf13d34389c80e281aa44af030","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            if (console_interface and"},{"line_number":229,"context_line":"                node.console_enabled and"},{"line_number":230,"context_line":"                \u0027driver_info\u0027 in delta):"},{"line_number":231,"context_line":"                    props \u003d console_interface.get_properties()"},{"line_number":232,"context_line":"                    changed \u003d [p for p in props"},{"line_number":233,"context_line":"                               if node.driver_info[p] !\u003d"},{"line_number":234,"context_line":"                               node_obj.driver_info[p]]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9e54e521","line":231,"updated":"2016-06-22 16:20:05.000000000","message":"here, I get only those properties that are exposed by console interface, so those driver_info fields that do not affect console interface e.g deploy_ramdisk for agent_ipmitool driver can still be changed.","commit_id":"c80e216482589d13302bd7c2b3b44cee26b7ed6a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ef846675c0b49b6f3f239a954abf3782a5bc798a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    if changed:"},{"line_number":153,"context_line":"                        raise exception.NodeConsoleEnabled("},{"line_number":154,"context_line":"                            node\u003dnode_id,"},{"line_number":155,"context_line":"                            err\u003d_(\"Update to driver_info fields %s \""},{"line_number":156,"context_line":"                                  \"is not possible.\") % \", \".join(changed))"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"            node_obj.save()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_fc13f8b5","line":155,"range":{"start_line":155,"start_character":35,"end_line":155,"end_character":64},"updated":"2016-08-01 10:08:56.000000000","message":"It would be useful, if error message includes suggestion to disable console before updating console related fields.\n\nWill it be bad idea to restart console here?  \n   task.driver.console.stop_console(task)\n   task.driver.console.start_console(task)","commit_id":"ddfbd5c91744524aa65d863210ccf3682b019617"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"27bde3e1df7abb873d91418bc0fdf3dc5ded9cd3","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    if changed:"},{"line_number":153,"context_line":"                        raise exception.NodeConsoleEnabled("},{"line_number":154,"context_line":"                            node\u003dnode_id,"},{"line_number":155,"context_line":"                            err\u003d_(\"Update to driver_info fields %s \""},{"line_number":156,"context_line":"                                  \"is not possible.\") % \", \".join(changed))"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"            node_obj.save()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_72df2f69","line":155,"range":{"start_line":155,"start_character":35,"end_line":155,"end_character":64},"in_reply_to":"bacf61ea_fc13f8b5","updated":"2016-08-01 10:36:15.000000000","message":"I will include such mention.\n\nRestarting the console might indeed be a bad idea, as there can be multiple users of Ironic service, and someone else might be currently using this console.","commit_id":"ddfbd5c91744524aa65d863210ccf3682b019617"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"02e228410917087ad3ce8d9cc544a4b52ce837bb","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                            err\u003d_(\"Update to driver_info fields %s \""},{"line_number":156,"context_line":"                                  \"is not possible. \""},{"line_number":157,"context_line":"                                  \"Please stop the console before updating \""},{"line_number":158,"context_line":"                                  \"these fileds.\") % \", \".join(changed))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            node_obj.save()"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_db557ac2","line":158,"range":{"start_line":158,"start_character":41,"end_line":158,"end_character":47},"updated":"2016-08-04 22:50:45.000000000","message":"fields","commit_id":"6528ffa540231a47be262a3eb99b6c6502b14fa6"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"e391550b5e04352192fd7f4b6a561658e0e3550c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                            err\u003d_(\"Update to driver_info fields %s \""},{"line_number":156,"context_line":"                                  \"is not possible. \""},{"line_number":157,"context_line":"                                  \"Please stop the console before updating \""},{"line_number":158,"context_line":"                                  \"these fileds.\") % \", \".join(changed))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            node_obj.save()"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_5a6b2fb9","line":158,"range":{"start_line":158,"start_character":41,"end_line":158,"end_character":47},"in_reply_to":"bacf61ea_db557ac2","updated":"2016-08-05 10:16:17.000000000","message":"Done","commit_id":"6528ffa540231a47be262a3eb99b6c6502b14fa6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba107513ad743ee328277ff4c380a47380267ac9","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            console_interface \u003d getattr(task.driver, \u0027console\u0027, None)"},{"line_number":145,"context_line":"            if (console_interface and"},{"line_number":146,"context_line":"                node.console_enabled and"},{"line_number":147,"context_line":"                \u0027driver_info\u0027 in delta):"},{"line_number":148,"context_line":"                    props \u003d console_interface.get_properties()"},{"line_number":149,"context_line":"                    changed \u003d [p for p in props"},{"line_number":150,"context_line":"                               if node.driver_info.get(p) !\u003d"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_c061d206","line":147,"updated":"2016-08-11 16:10:14.000000000","message":"maybe just an optimization. but you could get console_interface in the if statement. I don\u0027t see how node.console_enabled could be true w/o a console interface existing...","commit_id":"de210e1498be163eaaa088b5717c7d6fe3809404"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"d343da05c5a0f56428278ee19c2e4d8d23cd9d64","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            console_interface \u003d getattr(task.driver, \u0027console\u0027, None)"},{"line_number":145,"context_line":"            if (console_interface and"},{"line_number":146,"context_line":"                node.console_enabled and"},{"line_number":147,"context_line":"                \u0027driver_info\u0027 in delta):"},{"line_number":148,"context_line":"                    props \u003d console_interface.get_properties()"},{"line_number":149,"context_line":"                    changed \u003d [p for p in props"},{"line_number":150,"context_line":"                               if node.driver_info.get(p) !\u003d"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_b0c9c328","line":147,"in_reply_to":"9ad45d7e_c061d206","updated":"2016-08-17 12:12:06.000000000","message":"indeed, setting console on will not succeed when the console interface is missing in the first place.\n\nwill move inside the if.. block","commit_id":"de210e1498be163eaaa088b5717c7d6fe3809404"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba107513ad743ee328277ff4c380a47380267ac9","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            if (console_interface and"},{"line_number":146,"context_line":"                node.console_enabled and"},{"line_number":147,"context_line":"                \u0027driver_info\u0027 in delta):"},{"line_number":148,"context_line":"                    props \u003d console_interface.get_properties()"},{"line_number":149,"context_line":"                    changed \u003d [p for p in props"},{"line_number":150,"context_line":"                               if node.driver_info.get(p) !\u003d"},{"line_number":151,"context_line":"                               node_obj.driver_info.get(p)]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_46b97acb","line":148,"updated":"2016-08-11 16:10:14.000000000","message":"This makes sense, although I looked at eg ipminative, and the optional ipmi_force_boot_device is included. Whoa, and ipmitool has a whole bunch of optional properties. Should they be included here?","commit_id":"de210e1498be163eaaa088b5717c7d6fe3809404"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"d343da05c5a0f56428278ee19c2e4d8d23cd9d64","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            if (console_interface and"},{"line_number":146,"context_line":"                node.console_enabled and"},{"line_number":147,"context_line":"                \u0027driver_info\u0027 in delta):"},{"line_number":148,"context_line":"                    props \u003d console_interface.get_properties()"},{"line_number":149,"context_line":"                    changed \u003d [p for p in props"},{"line_number":150,"context_line":"                               if node.driver_info.get(p) !\u003d"},{"line_number":151,"context_line":"                               node_obj.driver_info.get(p)]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_636b0786","line":148,"in_reply_to":"9ad45d7e_46b97acb","updated":"2016-08-17 12:12:06.000000000","message":"here I check whatever the driver\u0027s console interface is returning as it\u0027s properties as these are considered as needed/used by this interface. if there are extra fields returned that are actually not needed, it must be fixed on the particular interface\u0027s side as there is no way to understand what options are used by the interface except to ask the interface itself.\n\nin fact, most of the optional properties of the ipmitool are indeed used in the console interface (probably except for the same force_boot_device).\nhttp://git.openstack.org/cgit/openstack/ironic/tree/ironic/drivers/modules/ipmitool.py#n119\nhttp://git.openstack.org/cgit/openstack/ironic/tree/ironic/drivers/modules/ipmitool.py#n1211\n\nCleaning up those reported but not needed console properties might be a topic for another couple of patches :)","commit_id":"de210e1498be163eaaa088b5717c7d6fe3809404"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba107513ad743ee328277ff4c380a47380267ac9","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                                  \"is not possible. \""},{"line_number":157,"context_line":"                                  \"Please stop the console before updating \""},{"line_number":158,"context_line":"                                  \"these fields.\") % \", \".join(changed))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            node_obj.save()"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        return node_obj"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_8bfd3b70","line":159,"updated":"2016-08-11 16:10:14.000000000","message":"We seem to be checking for things at the API level as well. It isn\u0027t clear to me whether this goes here or there, although maybe it makes sense for the check to be in both places. Anyway, this is good for now :)","commit_id":"de210e1498be163eaaa088b5717c7d6fe3809404"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"d343da05c5a0f56428278ee19c2e4d8d23cd9d64","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                                  \"is not possible. \""},{"line_number":157,"context_line":"                                  \"Please stop the console before updating \""},{"line_number":158,"context_line":"                                  \"these fields.\") % \", \".join(changed))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            node_obj.save()"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        return node_obj"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_900be78d","line":159,"in_reply_to":"9ad45d7e_8bfd3b70","updated":"2016-08-17 12:12:06.000000000","message":"at the API level, we do not have access to the task.driver object to get its properties, so I do the check over RPC and add this new exception to the list of expected RPC exceptions that are than handled correctly in API (returning 409 as declared in the exception class).","commit_id":"de210e1498be163eaaa088b5717c7d6fe3809404"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"a4084955fb483e6025b8fdf4b9aa24b9894d7b99","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                # NOTE(pas-ha) console can not be enabled w/o console"},{"line_number":146,"context_line":"                # interface so we are sure it is present in the driver"},{"line_number":147,"context_line":"                props \u003d task.driver.console.get_properties()"},{"line_number":148,"context_line":"                changed \u003d [p for p in props"},{"line_number":149,"context_line":"                           if node.driver_info.get(p) !\u003d"},{"line_number":150,"context_line":"                           node_obj.driver_info.get(p)]"},{"line_number":151,"context_line":"                if changed:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_472eee43","line":148,"updated":"2016-08-22 19:04:35.000000000","message":"Can\u0027t you just look in the delta variable for this?","commit_id":"668dfadd1f302675cc2a1e3f276bcf25c423f5b0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"0e24086f336408b80410df8d659986445de819fc","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                # NOTE(pas-ha) console can not be enabled w/o console"},{"line_number":146,"context_line":"                # interface so we are sure it is present in the driver"},{"line_number":147,"context_line":"                props \u003d task.driver.console.get_properties()"},{"line_number":148,"context_line":"                changed \u003d [p for p in props"},{"line_number":149,"context_line":"                           if node.driver_info.get(p) !\u003d"},{"line_number":150,"context_line":"                           node_obj.driver_info.get(p)]"},{"line_number":151,"context_line":"                if changed:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_33e1a9d1","line":148,"in_reply_to":"1ac06dbe_472eee43","updated":"2016-09-09 09:13:28.000000000","message":"because obj_what_changed is only doing a shallow comparison, delta is a set of top-level field names of node object (driver_info, instance info etc).","commit_id":"668dfadd1f302675cc2a1e3f276bcf25c423f5b0"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2d997bfd7a250ec569153f6514f98298d216953c","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                           if node.driver_info.get(p) !\u003d"},{"line_number":150,"context_line":"                           node_obj.driver_info.get(p)]"},{"line_number":151,"context_line":"                if changed:"},{"line_number":152,"context_line":"                    raise exception.NodeConsoleEnabled("},{"line_number":153,"context_line":"                        node\u003dnode_id,"},{"line_number":154,"context_line":"                        err\u003d_(\"Update to driver_info fields %s \""},{"line_number":155,"context_line":"                              \"is not possible. \""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_c984a0d4","line":152,"updated":"2016-09-13 15:58:32.000000000","message":"IMO operator should be able to change this in maintenance mode (when a node gets stuck with the console enabled for example from Mario\u0027s comment).","commit_id":"43cb6b53dfdeb361d8bf3f954d2da2abed72c2de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"aefcbf27ea5143b44bf306e1f8bee48de8a0ab2d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                           if node.driver_info.get(p) !\u003d"},{"line_number":150,"context_line":"                           node_obj.driver_info.get(p)]"},{"line_number":151,"context_line":"                if changed:"},{"line_number":152,"context_line":"                    raise exception.NodeConsoleEnabled("},{"line_number":153,"context_line":"                        node\u003dnode_id,"},{"line_number":154,"context_line":"                        err\u003d_(\"Update to driver_info fields %s \""},{"line_number":155,"context_line":"                              \"is not possible. \""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_0578c2c3","line":152,"in_reply_to":"9a89bdaa_c984a0d4","updated":"2016-09-14 14:22:48.000000000","message":"agree, will add \"not node.maintenance\" to the if clause","commit_id":"43cb6b53dfdeb361d8bf3f954d2da2abed72c2de"}],"ironic/drivers/base.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c41259f3e81137e73023fe3c6800c21154a4e098","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        When console is enabled, updates to these driver properties"},{"line_number":582,"context_line":"        will be denied."},{"line_number":583,"context_line":"        \"\"\""},{"line_number":584,"context_line":"        return {}"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_5bf65cd8","line":584,"updated":"2016-09-13 20:57:58.000000000","message":"Looks like should return list.","commit_id":"43cb6b53dfdeb361d8bf3f954d2da2abed72c2de"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"250c47d0305c0049a9359f56a6efc9cb40dd9bda","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        When console is enabled, updates to these driver properties"},{"line_number":582,"context_line":"        will be denied."},{"line_number":583,"context_line":"        \"\"\""},{"line_number":584,"context_line":"        return {}"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f287b81_66444b1c","line":584,"in_reply_to":"7a8ec9b2_25005e34","updated":"2017-08-24 12:47:57.000000000","message":"Would it make sense to return a `frozenset()` here instead of a `dict? The rationale would be:\n\n* the dict values are (presumably) never used, just keys\n* returning an immutable object may be theoretically \n  safer (no accidental in-place modification/side-effects)","commit_id":"43cb6b53dfdeb361d8bf3f954d2da2abed72c2de"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"aefcbf27ea5143b44bf306e1f8bee48de8a0ab2d","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        When console is enabled, updates to these driver properties"},{"line_number":582,"context_line":"        will be denied."},{"line_number":583,"context_line":"        \"\"\""},{"line_number":584,"context_line":"        return {}"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_25005e34","line":584,"in_reply_to":"7a8ec9b2_5bf65cd8","updated":"2016-09-14 14:22:48.000000000","message":"no. This is meant to be a \"sub-set\" of what gets returned from self.get_properties, which is dict(option\u003ddescription,...)\n\n\"for i in dict\" would iterate over keys of dict the same as list (just w/o strict order)","commit_id":"43cb6b53dfdeb361d8bf3f954d2da2abed72c2de"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"06a1c39e63ac69614ad9aa29c888bdcd2d0c2e50","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        When console is enabled, updates to these driver properties"},{"line_number":558,"context_line":"        will be denied."},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        Expected to return a sub-dictionary of that returned by"},{"line_number":561,"context_line":"        ``self.get_properties()``."},{"line_number":562,"context_line":"        \"\"\""},{"line_number":563,"context_line":"        return {}"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f287b81_97eff91b","line":560,"range":{"start_line":560,"start_character":29,"end_line":560,"end_character":43},"updated":"2017-09-08 09:59:03.000000000","message":"Return of dictionary here is not makes any sense. Only keys used in the new code.","commit_id":"14b813d55a027fe55f8417a7540e937af3f0d860"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f76f8736fbb41f567397e69e9897d968313cb6c6","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        Expected to return a sub-dictionary of that returned by"},{"line_number":561,"context_line":"        ``self.get_properties()``."},{"line_number":562,"context_line":"        \"\"\""},{"line_number":563,"context_line":"        return {}"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"class RescueInterface(BaseInterface):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f287b81_4a9a86c5","line":563,"updated":"2017-09-04 07:24:44.000000000","message":"Should it be a dictionary with property description? A list of property names seems enough.","commit_id":"14b813d55a027fe55f8417a7540e937af3f0d860"}]}
