)]}'
{"doc/source/webapi/v1.rst":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"bd82dfb8282b8bbed422172e27ea227c618a6e01","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"**1.18**"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Added internal endpoints for deployment ramdisks."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"**1.17**"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1aa78d24_fb919b53","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":18},"updated":"2016-07-05 14:54:21.000000000","message":"It\u0027s not internal from API point of view.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"105bc114e502f499b4f60b21dbfae7836780222a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"**1.18**"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Added internal endpoints for deployment ramdisks."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"**1.17**"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1aa78d24_0bcdb930","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":18},"in_reply_to":"1aa78d24_fb919b53","updated":"2016-07-07 13:46:52.000000000","message":"Done","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"37c8212dea84e15380e3d48eca5c0948ad835fa7","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"# should not be an \"admin\" endpoint, as it should be"},{"line_number":1300,"context_line":"# accessible by all end users. Unauthenticated clients are"},{"line_number":1301,"context_line":"# redirected to this endpoint to authenticate. Although this"},{"line_number":1302,"context_line":"# endpoint should  ideally be unversioned, client support in"},{"line_number":1303,"context_line":"# the wild varies.  If you\u0027re using a versioned v2 endpoint"},{"line_number":1304,"context_line":"# here, then this  should *not* be the same endpoint the"},{"line_number":1305,"context_line":"# service user utilizes  for validating tokens, because normal"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"1aa78d24_1d63f242","line":1302,"updated":"2016-07-14 17:03:05.000000000","message":"This doesn\u0027t look related - I\u0027m guessing keystonemiddleware got updated behind our backs and running `tox -e genconfig` picked up the change?","commit_id":"3bc56489a818c6cbc118b1eb9b657d4a21f24815"}],"ironic/api/config.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"bd82dfb8282b8bbed422172e27ea227c618a6e01","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # IPA ramdisk methods"},{"line_number":34,"context_line":"        \u0027/v1/lookup\u0027,"},{"line_number":35,"context_line":"        \u0027/v1/heartbeat/[a-z0-9\\-]+\u0027,"},{"line_number":36,"context_line":"        \u0027/v1/drivers/[a-z0-9_]*/vendor_passthru/lookup\u0027,"},{"line_number":37,"context_line":"        \u0027/v1/nodes/[a-z0-9\\-]+/vendor_passthru/heartbeat\u0027,"},{"line_number":38,"context_line":"    ],"},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_8d64a122","line":37,"range":{"start_line":36,"start_character":8,"end_line":37,"end_character":58},"updated":"2016-07-05 14:54:21.000000000","message":"Please add todo about remove this routes after deprecations period.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"105bc114e502f499b4f60b21dbfae7836780222a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # IPA ramdisk methods"},{"line_number":34,"context_line":"        \u0027/v1/lookup\u0027,"},{"line_number":35,"context_line":"        \u0027/v1/heartbeat/[a-z0-9\\-]+\u0027,"},{"line_number":36,"context_line":"        \u0027/v1/drivers/[a-z0-9_]*/vendor_passthru/lookup\u0027,"},{"line_number":37,"context_line":"        \u0027/v1/nodes/[a-z0-9\\-]+/vendor_passthru/heartbeat\u0027,"},{"line_number":38,"context_line":"    ],"},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_4bea2175","line":37,"range":{"start_line":36,"start_character":8,"end_line":37,"end_character":58},"in_reply_to":"1aa78d24_8d64a122","updated":"2016-07-07 13:46:52.000000000","message":"Done","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"448da13cbe0bade294b37ccee5f4538cffb45363","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # IPA ramdisk methods"},{"line_number":34,"context_line":"        \u0027/v1/lookup\u0027,"},{"line_number":35,"context_line":"        \u0027/v1/heartbeat/[a-z0-9\\-]+\u0027,"},{"line_number":36,"context_line":"        # Old IPA ramdisk methods - will be removed later"},{"line_number":37,"context_line":"        \u0027/v1/drivers/[a-z0-9_]*/vendor_passthru/lookup\u0027,"},{"line_number":38,"context_line":"        \u0027/v1/nodes/[a-z0-9\\-]+/vendor_passthru/heartbeat\u0027,"},{"line_number":39,"context_line":"    ],"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_876bc0b8","line":36,"updated":"2016-08-04 14:24:05.000000000","message":"Here we should mentioned when exactly we expecting to remove them, probably after P release?","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"461db2c3474ccbac6dce2098016cca1367bf8661","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # IPA ramdisk methods"},{"line_number":34,"context_line":"        \u0027/v1/lookup\u0027,"},{"line_number":35,"context_line":"        \u0027/v1/heartbeat/[a-z0-9\\-]+\u0027,"},{"line_number":36,"context_line":"        # Old IPA ramdisk methods - will be removed later"},{"line_number":37,"context_line":"        \u0027/v1/drivers/[a-z0-9_]*/vendor_passthru/lookup\u0027,"},{"line_number":38,"context_line":"        \u0027/v1/nodes/[a-z0-9\\-]+/vendor_passthru/heartbeat\u0027,"},{"line_number":39,"context_line":"    ],"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_1f9d5466","line":36,"in_reply_to":"bacf61ea_876bc0b8","updated":"2016-08-04 14:57:50.000000000","message":"Ocata - see the patch that deprecates them, it\u0027s on top of this one.","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"}],"ironic/api/controllers/v1/__init__.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"37c8212dea84e15380e3d48eca5c0948ad835fa7","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                          \u0027drivers\u0027, \u0027\u0027,"},{"line_number":128,"context_line":"                                          bookmark\u003dTrue)"},{"line_number":129,"context_line":"                      ]"},{"line_number":130,"context_line":"        v1.lookup \u003d [link.Link.make_link(\u0027self\u0027, pecan.request.public_url,"},{"line_number":131,"context_line":"                                         \u0027lookup\u0027, \u0027\u0027),"},{"line_number":132,"context_line":"                     link.Link.make_link(\u0027bookmark\u0027,"},{"line_number":133,"context_line":"                                         pecan.request.public_url,"}],"source_content_type":"text/x-python","patch_set":26,"id":"1aa78d24_1d4db299","line":130,"updated":"2016-07-14 17:03:05.000000000","message":"This \"list of link and bookmark link\" pattern should probably be factored out into a helper method, but that\u0027s out of scope for this patch.","commit_id":"3bc56489a818c6cbc118b1eb9b657d4a21f24815"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"beae9288d9fb2934f9a4ffb6e54247edde322166","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                          \u0027drivers\u0027, \u0027\u0027,"},{"line_number":128,"context_line":"                                          bookmark\u003dTrue)"},{"line_number":129,"context_line":"                      ]"},{"line_number":130,"context_line":"        v1.lookup \u003d [link.Link.make_link(\u0027self\u0027, pecan.request.public_url,"},{"line_number":131,"context_line":"                                         \u0027lookup\u0027, \u0027\u0027),"},{"line_number":132,"context_line":"                     link.Link.make_link(\u0027bookmark\u0027,"},{"line_number":133,"context_line":"                                         pecan.request.public_url,"}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_bc156ee6","line":130,"updated":"2016-08-03 16:30:44.000000000","message":"Should we only add these if api version is high enough?","commit_id":"4cc0bec5dcf5a84eec1b136fe1844cf09c993855"}],"ironic/api/controllers/v1/ramdisk.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"528a5908a619e6086d594358cdd13081db203c99","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @classmethod"},{"line_number":66,"context_line":"    def sample(cls):"},{"line_number":67,"context_line":"        return cls(node\u003dnode_ctl.Node.sample(),"},{"line_number":68,"context_line":"                   config\u003d{\u0027heartbeat_timeout\u0027: 600})"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_f0c6da47","line":67,"updated":"2016-07-05 13:51:18.000000000","message":"sample will contain all the fields but this object will only contain _LOOKUP_RETURN_FIELDS.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"105bc114e502f499b4f60b21dbfae7836780222a","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @classmethod"},{"line_number":66,"context_line":"    def sample(cls):"},{"line_number":67,"context_line":"        return cls(node\u003dnode_ctl.Node.sample(),"},{"line_number":68,"context_line":"                   config\u003d{\u0027heartbeat_timeout\u0027: 600})"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_cb29f19c","line":67,"in_reply_to":"1aa78d24_f0c6da47","updated":"2016-07-07 13:46:52.000000000","message":"This object contains the whole node, we only strip fields when serializing it.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"bd82dfb8282b8bbed422172e27ea227c618a6e01","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        \"\"\"Look up a node."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param addresses: list of MAC addresses for a node."},{"line_number":84,"context_line":"        :param node_uuid: UUID of a node."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":87,"context_line":"            raise exception.NotAcceptable()"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_9b833756","line":84,"updated":"2016-07-05 14:54:21.000000000","message":"raises","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"105bc114e502f499b4f60b21dbfae7836780222a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        \"\"\"Look up a node."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param addresses: list of MAC addresses for a node."},{"line_number":84,"context_line":"        :param node_uuid: UUID of a node."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":87,"context_line":"            raise exception.NotAcceptable()"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_0b1e596f","line":84,"in_reply_to":"1aa78d24_9b833756","updated":"2016-07-07 13:46:52.000000000","message":"Done","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"528a5908a619e6086d594358cdd13081db203c99","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        :param node_uuid: UUID of a node."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":87,"context_line":"            raise exception.NotAcceptable()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if node_uuid:"},{"line_number":90,"context_line":"            node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_3b5fa30f","line":87,"updated":"2016-07-05 13:51:18.000000000","message":"This was in the spec, but maybe 404 is better fit here","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"db95ec74c75eddd93e10ba737f3b613a6a5df04c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        :param node_uuid: UUID of a node."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":87,"context_line":"            raise exception.NotAcceptable()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if node_uuid:"},{"line_number":90,"context_line":"            node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_c1ce72b3","line":87,"in_reply_to":"1aa78d24_3b5fa30f","updated":"2016-07-05 14:04:38.000000000","message":"that\u0027s how we do API versioning, I can\u0027t change it :)","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"105bc114e502f499b4f60b21dbfae7836780222a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        :param node_uuid: UUID of a node."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":87,"context_line":"            raise exception.NotAcceptable()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if node_uuid:"},{"line_number":90,"context_line":"            node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_ab7aa5ba","line":87,"in_reply_to":"1aa78d24_3c55d91c","updated":"2016-07-07 13:46:52.000000000","message":"It\u0027s not correct, because it will still be listed in the parent endpoint (/v1 in this case). I\u0027ll comment on the portgroups patch.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7a3ad49568b18f6bf9bb92d0dd9723b1e2a6bff4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        :param node_uuid: UUID of a node."},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":87,"context_line":"            raise exception.NotAcceptable()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if node_uuid:"},{"line_number":90,"context_line":"            node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_3c55d91c","line":87,"in_reply_to":"1aa78d24_c1ce72b3","updated":"2016-07-05 14:35:18.000000000","message":"Well, for portgroups we decided to go with 404 as it is completely new endpoint.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"528a5908a619e6086d594358cdd13081db203c99","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if (CONF.api.restrict_lookup and"},{"line_number":96,"context_line":"                node.provision_state not in _LOOKUP_ALLOWED_STATES):"},{"line_number":97,"context_line":"            raise exception.NotFound()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return LookupResult.convert_with_links(node)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_50a1aea2","line":97,"updated":"2016-07-05 13:51:18.000000000","message":"I wonder should it be 400 instead","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"bd82dfb8282b8bbed422172e27ea227c618a6e01","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if (CONF.api.restrict_lookup and"},{"line_number":96,"context_line":"                node.provision_state not in _LOOKUP_ALLOWED_STATES):"},{"line_number":97,"context_line":"            raise exception.NotFound()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return LookupResult.convert_with_links(node)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_db213fa1","line":97,"updated":"2016-07-05 14:54:21.000000000","message":"Yes better InvalidState with HTTP 409","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"8ebcc43aafc404a75cf2ffabea12264aeefeb40b","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if (CONF.api.restrict_lookup and"},{"line_number":96,"context_line":"                node.provision_state not in _LOOKUP_ALLOWED_STATES):"},{"line_number":97,"context_line":"            raise exception.NotFound()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return LookupResult.convert_with_links(node)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_c6fe8337","line":97,"in_reply_to":"1aa78d24_4608d391","updated":"2016-07-05 15:17:03.000000000","message":"OK agree.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"db95ec74c75eddd93e10ba737f3b613a6a5df04c","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if (CONF.api.restrict_lookup and"},{"line_number":96,"context_line":"                node.provision_state not in _LOOKUP_ALLOWED_STATES):"},{"line_number":97,"context_line":"            raise exception.NotFound()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return LookupResult.convert_with_links(node)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_e110ce03","line":97,"in_reply_to":"1aa78d24_50a1aea2","updated":"2016-07-05 14:04:38.000000000","message":"Well, it\u0027s not a bad request. In a sense that the same request in 5 minutes may succeed. If you understand lookup as \"find a node *under provisioning* matching these specs\", then answer \"not found\" sounds pretty sane. WDYT?","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"15d4185804103a7d282ad228410611888f6626af","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if (CONF.api.restrict_lookup and"},{"line_number":96,"context_line":"                node.provision_state not in _LOOKUP_ALLOWED_STATES):"},{"line_number":97,"context_line":"            raise exception.NotFound()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return LookupResult.convert_with_links(node)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_4608d391","line":97,"in_reply_to":"1aa78d24_865c7bee","updated":"2016-07-05 15:14:26.000000000","message":"Why? You\u0027re asking: \"give me a node in provisioning state with these MAC addresses\". You get the response: \"node not found\". What\u0027s wrong with it? There is no node in provisioning state with such MAC addresses indeed, there are only nodes in other states.\n\nI\u0027d also prefer not to disclose too much information on the non-authenticated endpoint.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1caef6830d7ace1d83a42ebda5b30350b8d323ea","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if (CONF.api.restrict_lookup and"},{"line_number":96,"context_line":"                node.provision_state not in _LOOKUP_ALLOWED_STATES):"},{"line_number":97,"context_line":"            raise exception.NotFound()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return LookupResult.convert_with_links(node)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_f3b1bf90","line":97,"in_reply_to":"1aa78d24_db213fa1","updated":"2016-07-05 15:01:55.000000000","message":"Oh no please, lets not abuse conflict any more. This is what we return on node locked errors, and most of the clients retry it, which is not correct here.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7a3ad49568b18f6bf9bb92d0dd9723b1e2a6bff4","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if (CONF.api.restrict_lookup and"},{"line_number":96,"context_line":"                node.provision_state not in _LOOKUP_ALLOWED_STATES):"},{"line_number":97,"context_line":"            raise exception.NotFound()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return LookupResult.convert_with_links(node)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_5003690d","line":97,"in_reply_to":"1aa78d24_e110ce03","updated":"2016-07-05 14:35:18.000000000","message":"Yeah, agree, 400 is not good; maybe conflict - \"The request could not be completed due to a conflict with the current state of the target resource\"","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"61f470921680a58511b28f331434f0cb39b7236c","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if (CONF.api.restrict_lookup and"},{"line_number":96,"context_line":"                node.provision_state not in _LOOKUP_ALLOWED_STATES):"},{"line_number":97,"context_line":"            raise exception.NotFound()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return LookupResult.convert_with_links(node)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_865c7bee","line":97,"in_reply_to":"1aa78d24_f3b1bf90","updated":"2016-07-05 15:10:24.000000000","message":"Default exception message \"Resource could not be found.\" for NotFound misinforms here.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"bd82dfb8282b8bbed422172e27ea227c618a6e01","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\"Process a heartbeat from the deploy ramdisk."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":111,"context_line":"        :param callback_url: the URL to reach back to the ramdisk."},{"line_number":112,"context_line":"        \"\"\""},{"line_number":113,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":114,"context_line":"            raise exception.NotAcceptable()"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_7bedab24","line":111,"updated":"2016-07-05 14:54:21.000000000","message":"raises","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fa49578fd5178c7a548069b8967c65f5c25b64f9","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def _config():"},{"line_number":53,"context_line":"    return {\u0027heartbeat_timeout\u0027: CONF.agent.heartbeat_timeout}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class LookupResult(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_eb1a1b6e","line":53,"range":{"start_line":53,"start_character":38,"end_line":53,"end_character":43},"updated":"2016-07-12 14:40:28.000000000","message":"Should not be \"agent\" group option because this is generic API now, but can be done later as part of deprecations.","commit_id":"14fa54328927e7906e2a8c86c610158dd89373ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"34e83c6e3c96e266f609121f06de78a51996b0cf","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def _config():"},{"line_number":53,"context_line":"    return {\u0027heartbeat_timeout\u0027: CONF.agent.heartbeat_timeout}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class LookupResult(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_ee4756ba","line":53,"range":{"start_line":53,"start_character":38,"end_line":53,"end_character":43},"in_reply_to":"1aa78d24_eb1a1b6e","updated":"2016-07-14 12:10:49.000000000","message":"Done","commit_id":"14fa54328927e7906e2a8c86c610158dd89373ad"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fa49578fd5178c7a548069b8967c65f5c25b64f9","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":126,"context_line":"        except exception.NoValidHost as e:"},{"line_number":127,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":128,"context_line":"            raise e"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        pecan.request.rpcapi.heartbeat(pecan.request.context,"},{"line_number":131,"context_line":"                                       rpc_node.uuid, callback_url,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_7a7f1717","line":128,"updated":"2016-07-12 14:40:28.000000000","message":"Only \"raise\", https://review.openstack.org/#/c/339431/","commit_id":"14fa54328927e7906e2a8c86c610158dd89373ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"34e83c6e3c96e266f609121f06de78a51996b0cf","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":126,"context_line":"        except exception.NoValidHost as e:"},{"line_number":127,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":128,"context_line":"            raise e"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        pecan.request.rpcapi.heartbeat(pecan.request.context,"},{"line_number":131,"context_line":"                                       rpc_node.uuid, callback_url,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1aa78d24_ae3d4e2e","line":128,"in_reply_to":"1aa78d24_7a7f1717","updated":"2016-07-14 12:10:49.000000000","message":"Done","commit_id":"14fa54328927e7906e2a8c86c610158dd89373ad"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"beae9288d9fb2934f9a4ffb6e54247edde322166","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        :raises: NotFound if suitable node was not found."},{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":81,"context_line":"            raise exception.NotAcceptable()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if node_uuid:"},{"line_number":84,"context_line":"            node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_bce0ce97","line":81,"updated":"2016-08-03 16:30:44.000000000","message":"Hm, I feel like this should 404 as that would be the previous behavior. Might be okay though. Have we added a new endpoint in a microversion before?","commit_id":"4cc0bec5dcf5a84eec1b136fe1844cf09c993855"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"10f13869ef5545bfeb1a8c5ad26f675526863e86","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        :raises: NotFound if suitable node was not found."},{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":81,"context_line":"            raise exception.NotAcceptable()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if node_uuid:"},{"line_number":84,"context_line":"            node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_366d1633","line":81,"in_reply_to":"bacf61ea_bce0ce97","updated":"2016-08-03 17:55:20.000000000","message":"Chatted with sdague, he agreed that a 404 sounds right here.","commit_id":"4cc0bec5dcf5a84eec1b136fe1844cf09c993855"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"beae9288d9fb2934f9a4ffb6e54247edde322166","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        :param callback_url: the URL to reach back to the ramdisk."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":108,"context_line":"            raise exception.NotAcceptable()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_9c022a3d","line":108,"updated":"2016-08-03 16:30:44.000000000","message":"Ditto","commit_id":"4cc0bec5dcf5a84eec1b136fe1844cf09c993855"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ccef8bddff4df44d648827245c4d330a9a39f142","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _config():"},{"line_number":41,"context_line":"    return {\u0027heartbeat_timeout\u0027: CONF.api.ramdisk_heartbeat_timeout}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class LookupResult(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_4da289af","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":68},"updated":"2016-08-04 14:43:11.000000000","message":"missing new metrics configs here","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"461db2c3474ccbac6dce2098016cca1367bf8661","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _config():"},{"line_number":41,"context_line":"    return {\u0027heartbeat_timeout\u0027: CONF.api.ramdisk_heartbeat_timeout}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class LookupResult(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_9fb14404","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":68},"in_reply_to":"bacf61ea_4da289af","updated":"2016-08-04 14:57:50.000000000","message":"Ouch, my fault","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"637fcd0a5b040a728d756c472f2bb10a626f4595","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _config():"},{"line_number":41,"context_line":"    return {\u0027heartbeat_timeout\u0027: CONF.api.ramdisk_heartbeat_timeout}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class LookupResult(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_027cdbb3","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":68},"in_reply_to":"bacf61ea_9fb14404","updated":"2016-08-04 15:28:00.000000000","message":"++ needs metrics","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"786f5a563612e13858301d955b9bccb62e2f2a5c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def convert_with_links(cls, node):"},{"line_number":60,"context_line":"        node \u003d node_ctl.Node.convert_with_links(node, _LOOKUP_RETURN_FIELDS)"},{"line_number":61,"context_line":"        return cls(node\u003dnode, config\u003d_config())"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_9223fc57","line":60,"updated":"2016-08-04 14:29:53.000000000","message":"For anyone wondering, this ^ will ensure passwords are hidden. I verified this will not cause a regression on bug 1572796.","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"461db2c3474ccbac6dce2098016cca1367bf8661","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def convert_with_links(cls, node):"},{"line_number":60,"context_line":"        node \u003d node_ctl.Node.convert_with_links(node, _LOOKUP_RETURN_FIELDS)"},{"line_number":61,"context_line":"        return cls(node\u003dnode, config\u003d_config())"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_bfe5280a","line":60,"in_reply_to":"bacf61ea_9223fc57","updated":"2016-08-04 14:57:50.000000000","message":"++","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c2b304ebd0b95818069f248fa990f700521302ca","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"\"\"Controller handling node lookup for a deploy ramdisk.\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @expose.expose(LookupResult, types.list_of_macaddress, types.uuid)"},{"line_number":81,"context_line":"    def get_all(self, addresses, node_uuid\u003dNone):"},{"line_number":82,"context_line":"        \"\"\"Look up a node by its MAC addresses and optionally UUID."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        If the \"restrict_lookup\" option is set to True (the default), limit"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_b05a6ef0","line":81,"updated":"2016-08-04 17:49:09.000000000","message":"the addresses field is not optional here, however, in the original code, in agent_vendor_base.py, it was actually optional. A client _could_ pass just the node_uuid and get a valid response from lookup.\n\nSo this is an undocumented behavioral change -- I don\u0027t know if it was intended or not?","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40adc23df56cc1902c655912eaa1facf53056df5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"\"\"Controller handling node lookup for a deploy ramdisk.\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @expose.expose(LookupResult, types.list_of_macaddress, types.uuid)"},{"line_number":81,"context_line":"    def get_all(self, addresses, node_uuid\u003dNone):"},{"line_number":82,"context_line":"        \"\"\"Look up a node by its MAC addresses and optionally UUID."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        If the \"restrict_lookup\" option is set to True (the default), limit"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_0c7a2988","line":81,"in_reply_to":"bacf61ea_b05a6ef0","updated":"2016-08-05 09:42:13.000000000","message":"Well, provided that we don\u0027t use addresses when node_uuid is provided, it\u0027s sane to make it optional.","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"c2b304ebd0b95818069f248fa990f700521302ca","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        if node_uuid:"},{"line_number":97,"context_line":"            node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"},{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            node \u003d objects.Node.get_by_port_addresses(pecan.request.context,"},{"line_number":100,"context_line":"                                                      addresses)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if (CONF.api.restrict_lookup and"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_9005aa7b","line":99,"updated":"2016-08-04 17:49:09.000000000","message":"this method may raise a 404 error NodeNotFound, but with a custom error string being set from within db/sqlalchemy/api.py. For example:\n\n  curl -v -s -H \"X-Auth-Token: $OS_AUTH_TOKEN\" -H \u0027X-OpenStack-Ironic-API-Version: 1.22\u0027 ${IRONIC_URL}v1/lookup?addresses\u003d\u0027aa:bb:aa:bb:cc:cd\u0027\n\n  Node with port addresses [u\u0027aa:bb:aa:bb:cc:cd\u0027] was not found\n\nHowever, when lookup is invoked for a Node inthe wrong state, the 404 contains a different body:\n\n  curl -v -s -H \"X-Auth-Token: $OS_AUTH_TOKEN\" -H \u0027X-OpenStack-Ironic-API-Version: 1.22\u0027 ${IRONIC_URL}v1/lookup?addresses\u003d\u0027aa:bb:aa:bb:cc:cc\u0027\n\n  Resource could not be found.\n\nThis is an unintentional exposure of otherwise private data -- the existence of a Node with address ending in \u0027cc:cc\u0027 can be inferred because it returns a different message body.","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40adc23df56cc1902c655912eaa1facf53056df5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        if node_uuid:"},{"line_number":97,"context_line":"            node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"},{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            node \u003d objects.Node.get_by_port_addresses(pecan.request.context,"},{"line_number":100,"context_line":"                                                      addresses)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if (CONF.api.restrict_lookup and"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_6c1da561","line":99,"in_reply_to":"bacf61ea_9005aa7b","updated":"2016-08-05 09:42:13.000000000","message":"Hmm, I was thinking about that.. Let me just reraise generic NotFound here...","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"60cd95fd201fc88b79a870f4c5a96f533c8ce04a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    pecan.request.context, node_uuid)"},{"line_number":104,"context_line":"            else:"},{"line_number":105,"context_line":"                node \u003d objects.Node.get_by_port_addresses("},{"line_number":106,"context_line":"                    pecan.request.context, addresses)"},{"line_number":107,"context_line":"        except exception.NotFound:"},{"line_number":108,"context_line":"            # NOTE(dtantsur): we are reraising the same exception to make sure"},{"line_number":109,"context_line":"            # we don\u0027t disclose the difference between nodes that are not found"}],"source_content_type":"text/x-python","patch_set":33,"id":"bacf61ea_4fe9b3b6","line":106,"updated":"2016-08-05 10:10:56.000000000","message":"Hm, can we add an early \"if not addresses and not node_uuid: raise NotFound()\", so we aren\u0027t hitting the db for a null address? I think this case needs a unit test too.","commit_id":"d3e100e1466d18317c3fe041d5408cf7e0269906"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"77c4d011cc6559b473254405a09797d7799f94b9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    @classmethod"},{"line_number":68,"context_line":"    def sample(cls):"},{"line_number":69,"context_line":"        return cls(node\u003dnode_ctl.Node.sample(),"},{"line_number":70,"context_line":"                   config\u003d{\u0027heartbeat_timeout\u0027: 600})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @classmethod"},{"line_number":73,"context_line":"    def convert_with_links(cls, node):"}],"source_content_type":"text/x-python","patch_set":34,"id":"bacf61ea_a1d5dbe5","line":70,"range":{"start_line":70,"start_character":26,"end_line":70,"end_character":52},"updated":"2016-08-05 13:01:54.000000000","message":"This does not correspond to what will be returned, I\u0027d just do config() here too.","commit_id":"8bdd538c0c387c8c2633c8615f2a15a31918a548"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"77c4d011cc6559b473254405a09797d7799f94b9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        :param node_uuid: UUID of a node."},{"line_number":90,"context_line":"        :raises: NotFound if requested API version does not allow this"},{"line_number":91,"context_line":"            endpoint."},{"line_number":92,"context_line":"        :raises: NotFound if suitable node was not found."},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":95,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":34,"id":"bacf61ea_61ae432f","line":92,"updated":"2016-08-05 13:01:54.000000000","message":"IncompleteLookup too","commit_id":"8bdd538c0c387c8c2633c8615f2a15a31918a548"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"77c4d011cc6559b473254405a09797d7799f94b9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"\"\"Process a heartbeat from the deploy ramdisk."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":132,"context_line":"        :param callback_url: the URL to reach back to the ramdisk."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":"        if not api_utils.allow_ramdisk_endpoints():"},{"line_number":135,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":34,"id":"bacf61ea_e16873f7","line":132,"updated":"2016-08-05 13:01:54.000000000","message":"ditto raises","commit_id":"8bdd538c0c387c8c2633c8615f2a15a31918a548"}],"ironic/api/controllers/v1/types.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"bd82dfb8282b8bbed422172e27ea227c618a6e01","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return ListType.validate(value)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class ListOfMacAddressesType(ListType):"},{"line_number":180,"context_line":"    \"\"\"List of MAC addresses.\"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_dbff7f65","line":179,"updated":"2016-07-05 14:54:21.000000000","message":"This code is not covered by unit tests.","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"105bc114e502f499b4f60b21dbfae7836780222a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return ListType.validate(value)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class ListOfMacAddressesType(ListType):"},{"line_number":180,"context_line":"    \"\"\"List of MAC addresses.\"\"\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_46adf899","line":179,"in_reply_to":"1aa78d24_dbff7f65","updated":"2016-07-07 13:46:52.000000000","message":"Done","commit_id":"652ac7abbdf0f8d4887200cca3710431f1285b05"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"37c8212dea84e15380e3d48eca5c0948ad835fa7","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        \"\"\"Validate and convert the input to a ListOfMacAddressesType."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        :param value: A comma separated string of MAC addresses"},{"line_number":187,"context_line":"        :returns: A list of unique MACs, whose order is not guaranteed."},{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        items \u003d ListType.validate(value)"},{"line_number":190,"context_line":"        return [MacAddressType.validate(item) for item in items]"}],"source_content_type":"text/x-python","patch_set":26,"id":"1aa78d24_0001c139","line":187,"updated":"2016-07-14 17:03:05.000000000","message":"If order isn\u0027t guaranteed, why are you using a list and not a set?","commit_id":"3bc56489a818c6cbc118b1eb9b657d4a21f24815"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"448da13cbe0bade294b37ccee5f4538cffb45363","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def validate(value):"},{"line_number":184,"context_line":"        \"\"\"Validate and convert the input to a ListOfMacAddressesType."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        :param value: A comma separated string of MAC addresses"},{"line_number":187,"context_line":"        :returns: A list of unique MACs, whose order is not guaranteed."},{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        items \u003d ListType.validate(value)"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_873e2089","line":186,"updated":"2016-08-04 14:24:05.000000000","message":"nit: dot at the end, to be consistent with L189","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"}],"ironic/conf/api.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"448da13cbe0bade294b37ccee5f4538cffb45363","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d_(\u0027Whether to restrict the lookup API to only nodes \u0027"},{"line_number":55,"context_line":"                       \u0027in certain states.\u0027)),"},{"line_number":56,"context_line":"    cfg.IntOpt(\u0027ramdisk_heartbeat_timeout\u0027,"},{"line_number":57,"context_line":"               default\u003d300,"},{"line_number":58,"context_line":"               deprecated_group\u003d\u0027agent\u0027, deprecated_name\u003d\u0027heartbeat_timeout\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Maximum interval (in seconds) for agent heartbeats.\u0027)),"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_e748bcb5","line":56,"updated":"2016-08-04 14:24:05.000000000","message":"during tests hearbeat_timeout is decreased to 30, we should made the change to devstack plugin, probably follow-up or separate commit is enough. https://github.com/openstack/ironic/blob/ff24dc2d9315ae0bce782407a33d60cd226df7e4/devstack/lib/ironic#L685","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"637fcd0a5b040a728d756c472f2bb10a626f4595","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d_(\u0027Whether to restrict the lookup API to only nodes \u0027"},{"line_number":55,"context_line":"                       \u0027in certain states.\u0027)),"},{"line_number":56,"context_line":"    cfg.IntOpt(\u0027ramdisk_heartbeat_timeout\u0027,"},{"line_number":57,"context_line":"               default\u003d300,"},{"line_number":58,"context_line":"               deprecated_group\u003d\u0027agent\u0027, deprecated_name\u003d\u0027heartbeat_timeout\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Maximum interval (in seconds) for agent heartbeats.\u0027)),"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_a20fcf37","line":56,"in_reply_to":"bacf61ea_5f906c43","updated":"2016-08-04 15:28:00.000000000","message":"I\u0027m less convinced of this. Agent with heartbeat about 3 times in a heartbeat_timeout. 300 is a little high, but 30 is very low; meaning all running agents will heartbeat every 10 seconds. Something like 60-90s seems more reasonable to me. Either way, another commit is the better place to do this.","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cb3a28ab54fa585bc44c5aadc7d627d24229779a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d_(\u0027Whether to restrict the lookup API to only nodes \u0027"},{"line_number":55,"context_line":"                       \u0027in certain states.\u0027)),"},{"line_number":56,"context_line":"    cfg.IntOpt(\u0027ramdisk_heartbeat_timeout\u0027,"},{"line_number":57,"context_line":"               default\u003d300,"},{"line_number":58,"context_line":"               deprecated_group\u003d\u0027agent\u0027, deprecated_name\u003d\u0027heartbeat_timeout\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Maximum interval (in seconds) for agent heartbeats.\u0027)),"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_2eb7483b","line":56,"in_reply_to":"bacf61ea_a20fcf37","updated":"2016-08-04 16:07:42.000000000","message":"What Vasyl is saying is we should update the devstack plugin to use the new location of this config, instead of the old deprecated location. :)","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"461db2c3474ccbac6dce2098016cca1367bf8661","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d_(\u0027Whether to restrict the lookup API to only nodes \u0027"},{"line_number":55,"context_line":"                       \u0027in certain states.\u0027)),"},{"line_number":56,"context_line":"    cfg.IntOpt(\u0027ramdisk_heartbeat_timeout\u0027,"},{"line_number":57,"context_line":"               default\u003d300,"},{"line_number":58,"context_line":"               deprecated_group\u003d\u0027agent\u0027, deprecated_name\u003d\u0027heartbeat_timeout\u0027,"},{"line_number":59,"context_line":"               help\u003d_(\u0027Maximum interval (in seconds) for agent heartbeats.\u0027)),"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_5f906c43","line":56,"in_reply_to":"bacf61ea_e748bcb5","updated":"2016-08-04 14:57:50.000000000","message":"+1","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"}],"ironic/tests/unit/api/test_root.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"77c4d011cc6559b473254405a09797d7799f94b9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # Check if all known resources are present and there are no extra ones."},{"line_number":64,"context_line":"        not_resources \u003d (\u0027id\u0027, \u0027links\u0027, \u0027media_types\u0027)"},{"line_number":65,"context_line":"        actual_resources \u003d tuple(set(data.keys()) - set(not_resources))"},{"line_number":66,"context_line":"        expected_resources \u003d (\u0027chassis\u0027, \u0027drivers\u0027, \u0027heartbeat\u0027,"},{"line_number":67,"context_line":"                              \u0027lookup\u0027, \u0027nodes\u0027, \u0027ports\u0027)"},{"line_number":68,"context_line":"        self.assertEqual(sorted(expected_resources), sorted(actual_resources))"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"bacf61ea_bce4e03b","line":66,"updated":"2016-08-05 13:01:54.000000000","message":"I\u0027d prefer a set here too, then there would be no need to sort :)","commit_id":"8bdd538c0c387c8c2633c8615f2a15a31918a548"}],"ironic/tests/unit/api/v1/test_ramdisk.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"637fcd0a5b040a728d756c472f2bb10a626f4595","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                         set(data[\u0027node\u0027]))"},{"line_number":104,"context_line":"        self.assertEqual("},{"line_number":105,"context_line":"            {\u0027heartbeat_timeout\u0027: CONF.api.ramdisk_heartbeat_timeout},"},{"line_number":106,"context_line":"            data[\u0027config\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"@mock.patch.object(rpcapi.ConductorAPI, \u0027get_topic_for\u0027,"}],"source_content_type":"text/x-python","patch_set":31,"id":"bacf61ea_75ad8f9a","line":106,"updated":"2016-08-04 15:28:00.000000000","message":"This will need to be updated with metrics config too, obviously","commit_id":"d2c87141b5b6199ec009d505284dab943a4ca9c9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1076cf9a39fc2ed4ca37235c7685449100ebbb9c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            expect_errors\u003dTrue)"},{"line_number":51,"context_line":"        self.assertEqual(http_client.NOT_FOUND, response.status_int)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_old_api_version(self):"},{"line_number":54,"context_line":"        response \u003d self.get_json("},{"line_number":55,"context_line":"            \u0027/lookup?addresses\u003d%s\u0027 % \u0027,\u0027.join(self.addresses),"},{"line_number":56,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MIN_VER)},"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_f97851c6","line":53,"updated":"2016-08-04 19:04:36.000000000","message":"this test is asserting that the same error is raised when searching for a non-existent Port as when requesting access to this endpoint with an old API version AND when the port doesn\u0027t exist.\n\nI would prefer that you add obj_utils.create_test_port() to this test case, and then make two calls -- one with api_v1.MIN_VER that errors, and one with api_v1.MAX_VER that passes. In this way, you will actually assert the error is raised _because_ of the version -- not because hte port doesn\u0027t exist.\n\nIncidentally, I also find it strange that the error code is the same -- but I have confirmed that behavior with other endpoints, so this is self-consistent and I am, therefor, OK with it.","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40adc23df56cc1902c655912eaa1facf53056df5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            expect_errors\u003dTrue)"},{"line_number":51,"context_line":"        self.assertEqual(http_client.NOT_FOUND, response.status_int)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_old_api_version(self):"},{"line_number":54,"context_line":"        response \u003d self.get_json("},{"line_number":55,"context_line":"            \u0027/lookup?addresses\u003d%s\u0027 % \u0027,\u0027.join(self.addresses),"},{"line_number":56,"context_line":"            headers\u003d{api_base.Version.string: str(api_v1.MIN_VER)},"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_ac4cbd42","line":53,"in_reply_to":"bacf61ea_f97851c6","updated":"2016-08-05 09:42:13.000000000","message":"Oh, this was not intended, good catch!","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1076cf9a39fc2ed4ca37235c7685449100ebbb9c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            CONF.api.ramdisk_heartbeat_timeout,"},{"line_number":73,"context_line":"            data[\u0027config\u0027][\u0027heartbeat_timeout\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_found_by_uuid(self):"},{"line_number":76,"context_line":"        data \u003d self.get_json("},{"line_number":77,"context_line":"            \u0027/lookup?addresses\u003d%s\u0026node_uuid\u003d%s\u0027 %"},{"line_number":78,"context_line":"            (\u0027,\u0027.join(self.addresses), self.node.uuid),"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_f9dcd1e5","line":75,"updated":"2016-08-04 19:04:36.000000000","message":"this is actually testing if the node is found by both address AND uuid, not just by uuid.","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40adc23df56cc1902c655912eaa1facf53056df5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            CONF.api.ramdisk_heartbeat_timeout,"},{"line_number":73,"context_line":"            data[\u0027config\u0027][\u0027heartbeat_timeout\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_found_by_uuid(self):"},{"line_number":76,"context_line":"        data \u003d self.get_json("},{"line_number":77,"context_line":"            \u0027/lookup?addresses\u003d%s\u0026node_uuid\u003d%s\u0027 %"},{"line_number":78,"context_line":"            (\u0027,\u0027.join(self.addresses), self.node.uuid),"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_2c5f2de6","line":75,"in_reply_to":"bacf61ea_f9dcd1e5","updated":"2016-08-05 09:42:13.000000000","message":"I guess I\u0027ll make two tests, one for just UUID, one proving that UUID has priority.","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"521dd31e8dae4ec7fa2e82bb11ed3c31c07a52ce","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                         set(data[\u0027node\u0027]))"},{"line_number":104,"context_line":"        self.assertEqual("},{"line_number":105,"context_line":"            CONF.api.ramdisk_heartbeat_timeout,"},{"line_number":106,"context_line":"            data[\u0027config\u0027][\u0027heartbeat_timeout\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"@mock.patch.object(rpcapi.ConductorAPI, \u0027get_topic_for\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_d8d2b2ff","line":106,"updated":"2016-08-04 15:45:06.000000000","message":"A little weird that we validate heartbeat_timeout is sent, but not metrics config. Not really a big deal though.","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40adc23df56cc1902c655912eaa1facf53056df5","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                         set(data[\u0027node\u0027]))"},{"line_number":104,"context_line":"        self.assertEqual("},{"line_number":105,"context_line":"            CONF.api.ramdisk_heartbeat_timeout,"},{"line_number":106,"context_line":"            data[\u0027config\u0027][\u0027heartbeat_timeout\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"@mock.patch.object(rpcapi.ConductorAPI, \u0027get_topic_for\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_4c5a61f3","line":106,"in_reply_to":"bacf61ea_ae3e9888","updated":"2016-08-05 09:42:13.000000000","message":"Done","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"79a66b44a7cdb14f5e093b4143d77d15874c99b0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                         set(data[\u0027node\u0027]))"},{"line_number":104,"context_line":"        self.assertEqual("},{"line_number":105,"context_line":"            CONF.api.ramdisk_heartbeat_timeout,"},{"line_number":106,"context_line":"            data[\u0027config\u0027][\u0027heartbeat_timeout\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"@mock.patch.object(rpcapi.ConductorAPI, \u0027get_topic_for\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"bacf61ea_ae3e9888","line":106,"in_reply_to":"bacf61ea_d8d2b2ff","updated":"2016-08-04 16:10:26.000000000","message":"Yeah, actually I\u0027d like to fix this so that we don\u0027t lose it when we drop the vendor passthru. Following patch is fine though.","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"77c4d011cc6559b473254405a09797d7799f94b9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestLookup(test_api_base.BaseApiTest):"},{"line_number":35,"context_line":"    addresses \u003d [\u002711:22:33:44:55:66\u0027, \u002766:55:44:33:22:11\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"bacf61ea_fcbad8df","line":34,"updated":"2016-08-05 13:01:54.000000000","message":"Would be nice to assert that policy.authorize is called.","commit_id":"8bdd538c0c387c8c2633c8615f2a15a31918a548"}],"releasenotes/notes/lookup-heartbeat-f9772521d12a0549.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"beae9288d9fb2934f9a4ffb6e54247edde322166","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"bacf61ea_a29d48bd","line":8,"updated":"2016-08-03 16:30:44.000000000","message":"Also need to add the bit about the new config that restricts lookup","commit_id":"4cc0bec5dcf5a84eec1b136fe1844cf09c993855"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"1076cf9a39fc2ed4ca37235c7685449100ebbb9c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - New API endpoint for deploy ramdisk lookup ``/v1/lookup``."},{"line_number":4,"context_line":"  - New API endpoint for deploy ramdisk heartbeat ``/v1/heartbeat/\u003cNODE\u003e``."},{"line_number":5,"context_line":"deprecations:"},{"line_number":6,"context_line":"  - The configuration option ``[agent]heartbeat_timeout`` was renamed to"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bacf61ea_d90aad25","line":3,"updated":"2016-08-04 19:04:36.000000000","message":"I think this should clearly indicate that these are unrestricted / unauthenticated endpoints, especially since they are now discoverable from \"/\"","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40adc23df56cc1902c655912eaa1facf53056df5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - New API endpoint for deploy ramdisk lookup ``/v1/lookup``."},{"line_number":4,"context_line":"  - New API endpoint for deploy ramdisk heartbeat ``/v1/heartbeat/\u003cNODE\u003e``."},{"line_number":5,"context_line":"deprecations:"},{"line_number":6,"context_line":"  - The configuration option ``[agent]heartbeat_timeout`` was renamed to"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bacf61ea_8cdbb97b","line":3,"in_reply_to":"bacf61ea_d90aad25","updated":"2016-08-05 09:42:13.000000000","message":"Done","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"40adc23df56cc1902c655912eaa1facf53056df5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - The configuration option ``[agent]heartbeat_timeout`` was renamed to"},{"line_number":7,"context_line":"    ``[api]ramdisk_heartbeat_timeout``. The old variant is deprecated."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - A new configuration option ``[api]restrict_lookup is added, which restricts"},{"line_number":10,"context_line":"    the lookup API (normally only used by ramdisks) to only work when the node"},{"line_number":11,"context_line":"    is in specific states used by the ramdisk, and defaults to True. Operators"},{"line_number":12,"context_line":"    that need this endpoint to work in any state may set this to False, though"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"bacf61ea_cce1312c","line":9,"updated":"2016-08-05 09:42:13.000000000","message":"bug: unfinished ``","commit_id":"884aa918fb0b11be7aee5e04cb828d4464749a8e"}]}
