)]}'
{"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d497e9cfde200c922b50893d00151b9d49bc23ab","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"    i_info[\u0027ephemeral_mb\u0027] \u003d 1024 * int(i_info[\u0027ephemeral_gb\u0027])"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    if iwdi:"},{"line_number":1146,"context_line":"        if int(i_info[\u0027swap_mb\u0027]) \u003e 0 or int(i_info[\u0027ephemeral_gb\u0027]) \u003e 0:"},{"line_number":1147,"context_line":"            err_msg_invalid \u003d _(\"Cannot deploy whole disk image with \""},{"line_number":1148,"context_line":"                                \"swap or ephemeral size set\")"},{"line_number":1149,"context_line":"            raise exception.InvalidParameterValue(err_msg_invalid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_d462add8","line":1146,"updated":"2016-06-16 20:51:29.000000000","message":"s/int(i_info[\u0027swap_mb\u0027])/i_info[\u0027swap_mb\u0027]/\n\nAnd you could change s/int(i_info[\u0027ephemeral_gb\u0027])/i_info[\u0027ephemeral_mb\u0027]/","commit_id":"12057d2cc4ae1b408b54fa9ad1246ff2c53b5b8f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dd1317dd2c604c1e5df868cf190e01665e1bb71e","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"    i_info[\u0027ephemeral_mb\u0027] \u003d 1024 * int(i_info[\u0027ephemeral_gb\u0027])"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    if iwdi:"},{"line_number":1146,"context_line":"        if int(i_info[\u0027swap_mb\u0027]) \u003e 0 or int(i_info[\u0027ephemeral_gb\u0027]) \u003e 0:"},{"line_number":1147,"context_line":"            err_msg_invalid \u003d _(\"Cannot deploy whole disk image with \""},{"line_number":1148,"context_line":"                                \"swap or ephemeral size set\")"},{"line_number":1149,"context_line":"            raise exception.InvalidParameterValue(err_msg_invalid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_b8ced957","line":1146,"in_reply_to":"7aa08908_d462add8","updated":"2016-06-17 11:23:41.000000000","message":"I agree about removing int() casts. As for changing ephemeral_gb to ephemeral_mb in the checks, it will also work, but:\n\n1. ephemeral_gb is what is inside of DISK_LAYOUT_PARAMS, as it is what comes in from nova, along with ephemeral_format.\n\n2. Because of that, ephemeral_gb, not ephemeral_mb is what is checked in _check_disk_layout_unchanged.\n\nSo I\u0027d rather leave the checks for the values that were provided, not the values that were computed based on them, WDYT?\n\nAll of this is pretty confusing tho :(","commit_id":"12057d2cc4ae1b408b54fa9ad1246ff2c53b5b8f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d497e9cfde200c922b50893d00151b9d49bc23ab","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"    i_info[\u0027ephemeral_format\u0027] \u003d info.get(\u0027ephemeral_format\u0027)"},{"line_number":1151,"context_line":"    i_info[\u0027configdrive\u0027] \u003d info.get(\u0027configdrive\u0027)"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"    if i_info[\u0027ephemeral_gb\u0027] and not i_info[\u0027ephemeral_format\u0027]:"},{"line_number":1154,"context_line":"        i_info[\u0027ephemeral_format\u0027] \u003d CONF.pxe.default_ephemeral_format"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    preserve_ephemeral \u003d info.get(\u0027preserve_ephemeral\u0027, False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_34be91ff","line":1153,"updated":"2016-06-16 20:51:29.000000000","message":"if you do the change i suggested above, i\u0027d probably change this to s/ephemeral_gb/ephemeral_mb/","commit_id":"12057d2cc4ae1b408b54fa9ad1246ff2c53b5b8f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1ae001c3a6c3b292a09685e11b567f455f764969","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                    i_info[\u0027image_source\u0027])):"},{"line_number":1118,"context_line":"            i_info[\u0027kernel\u0027] \u003d info.get(\u0027kernel\u0027)"},{"line_number":1119,"context_line":"            i_info[\u0027ramdisk\u0027] \u003d info.get(\u0027ramdisk\u0027)"},{"line_number":1120,"context_line":"    i_info[\u0027root_gb\u0027] \u003d info.get(\u0027root_gb\u0027)"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    error_msg \u003d _(\"Cannot validate driver deploy. Some parameters were missing\""},{"line_number":1123,"context_line":"                  \" in node\u0027s instance_info\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_2ddb4def","line":1120,"updated":"2016-06-18 18:04:10.000000000","message":"If do as my suggestion in L1134, then this would not be needed.","commit_id":"3c24dc0ddbf0c2430e0bb77187e928a0ac196650"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"17656f6997a43aa7ef36d5eba6dc2b6b5b34df37","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"                        \"Invalid parameter %(param)s. Reason: %(reason)s\")"},{"line_number":1132,"context_line":"    for param in DISK_LAYOUT_PARAMS:"},{"line_number":1133,"context_line":"        try:"},{"line_number":1134,"context_line":"            int(i_info[param])"},{"line_number":1135,"context_line":"        except ValueError:"},{"line_number":1136,"context_line":"            reason \u003d _(\"%s is not an integer value.\") % i_info[param]"},{"line_number":1137,"context_line":"            raise exception.InvalidParameterValue(err_msg_invalid %"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_0dce515a","line":1134,"updated":"2016-06-18 17:42:03.000000000","message":"Is there a reason not to do.\n\n int(i_info[param])\n i_info[param] \u003d int(i_info[param])\n\nor as one line:\n  i_info[param] \u003d int(i_info[param])","commit_id":"3c24dc0ddbf0c2430e0bb77187e928a0ac196650"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1ae001c3a6c3b292a09685e11b567f455f764969","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"                        \"Invalid parameter %(param)s. Reason: %(reason)s\")"},{"line_number":1132,"context_line":"    for param in DISK_LAYOUT_PARAMS:"},{"line_number":1133,"context_line":"        try:"},{"line_number":1134,"context_line":"            int(i_info[param])"},{"line_number":1135,"context_line":"        except ValueError:"},{"line_number":1136,"context_line":"            reason \u003d _(\"%s is not an integer value.\") % i_info[param]"},{"line_number":1137,"context_line":"            raise exception.InvalidParameterValue(err_msg_invalid %"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_8d64014a","line":1134,"in_reply_to":"5a9d85d2_0dce515a","updated":"2016-06-18 18:04:10.000000000","message":"Or:\n\n i_info[param] \u003d int(i_info.get(param, 0))","commit_id":"3c24dc0ddbf0c2430e0bb77187e928a0ac196650"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a291c8ebffcbc1943daa3e194eaf66a3c59ab978","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"                        \"Invalid parameter %(param)s. Reason: %(reason)s\")"},{"line_number":1132,"context_line":"    for param in DISK_LAYOUT_PARAMS:"},{"line_number":1133,"context_line":"        try:"},{"line_number":1134,"context_line":"            int(i_info[param])"},{"line_number":1135,"context_line":"        except ValueError:"},{"line_number":1136,"context_line":"            reason \u003d _(\"%s is not an integer value.\") % i_info[param]"},{"line_number":1137,"context_line":"            raise exception.InvalidParameterValue(err_msg_invalid %"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_e15f650c","line":1134,"in_reply_to":"5a9d85d2_8d64014a","updated":"2016-06-22 09:54:11.000000000","message":"We should not default root_gb to 0, hence we\u0027d have to introduce another \u0027if\u0027 for that, so I\u0027d like to leave it as is at least in this commit, we can make it prettier afterwards.","commit_id":"3c24dc0ddbf0c2430e0bb77187e928a0ac196650"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"17656f6997a43aa7ef36d5eba6dc2b6b5b34df37","unresolved":false,"context_lines":[{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"    i_info[\u0027root_mb\u0027] \u003d 1024 * int(i_info[\u0027root_gb\u0027])"},{"line_number":1142,"context_line":"    i_info[\u0027swap_mb\u0027] \u003d int(i_info[\u0027swap_mb\u0027])"},{"line_number":1143,"context_line":"    i_info[\u0027ephemeral_mb\u0027] \u003d 1024 * int(i_info[\u0027ephemeral_gb\u0027])"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    if iwdi:"},{"line_number":1146,"context_line":"        if i_info[\u0027swap_mb\u0027] \u003e 0 or i_info[\u0027ephemeral_gb\u0027] \u003e 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_ad03bd75","line":1143,"updated":"2016-06-18 17:42:03.000000000","message":"We have lost converting ephemeral_GB to an int. Is that a problem?","commit_id":"3c24dc0ddbf0c2430e0bb77187e928a0ac196650"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1ae001c3a6c3b292a09685e11b567f455f764969","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"    i_info[\u0027ephemeral_mb\u0027] \u003d 1024 * int(i_info[\u0027ephemeral_gb\u0027])"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    if iwdi:"},{"line_number":1146,"context_line":"        if i_info[\u0027swap_mb\u0027] \u003e 0 or i_info[\u0027ephemeral_gb\u0027] \u003e 0:"},{"line_number":1147,"context_line":"            err_msg_invalid \u003d _(\"Cannot deploy whole disk image with \""},{"line_number":1148,"context_line":"                                \"swap or ephemeral size set\")"},{"line_number":1149,"context_line":"            raise exception.InvalidParameterValue(err_msg_invalid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_6de555a7","line":1146,"updated":"2016-06-18 18:04:10.000000000","message":"Where was \u0027ephermal_gb\u0027 converted to an int?","commit_id":"3c24dc0ddbf0c2430e0bb77187e928a0ac196650"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a291c8ebffcbc1943daa3e194eaf66a3c59ab978","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"    i_info[\u0027ephemeral_mb\u0027] \u003d 1024 * int(i_info[\u0027ephemeral_gb\u0027])"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"    if iwdi:"},{"line_number":1146,"context_line":"        if i_info[\u0027swap_mb\u0027] \u003e 0 or i_info[\u0027ephemeral_gb\u0027] \u003e 0:"},{"line_number":1147,"context_line":"            err_msg_invalid \u003d _(\"Cannot deploy whole disk image with \""},{"line_number":1148,"context_line":"                                \"swap or ephemeral size set\")"},{"line_number":1149,"context_line":"            raise exception.InvalidParameterValue(err_msg_invalid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_e62c9bad","line":1146,"in_reply_to":"5a9d85d2_6de555a7","updated":"2016-06-22 09:54:11.000000000","message":"Yeah, good catch John, thanks!","commit_id":"3c24dc0ddbf0c2430e0bb77187e928a0ac196650"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6718045aad48b75c2d508a35bd08f9246efe731b","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"    i_info[\u0027ephemeral_format\u0027] \u003d info.get(\u0027ephemeral_format\u0027)"},{"line_number":1151,"context_line":"    i_info[\u0027configdrive\u0027] \u003d info.get(\u0027configdrive\u0027)"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"    if i_info[\u0027ephemeral_gb\u0027] and not i_info[\u0027ephemeral_format\u0027]:"},{"line_number":1154,"context_line":"        i_info[\u0027ephemeral_format\u0027] \u003d CONF.pxe.default_ephemeral_format"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    preserve_ephemeral \u003d info.get(\u0027preserve_ephemeral\u0027, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_28e82de2","line":1153,"updated":"2016-06-22 10:59:40.000000000","message":"Patch changes behavior of this code if \u0027ephemeral_gb\u0027 is \"0\".","commit_id":"2e0716720a91030d9600d40dc949c27ff62bc43b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"afa5d4af15782094239d0d6d452ba391f40779e3","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"    i_info[\u0027ephemeral_format\u0027] \u003d info.get(\u0027ephemeral_format\u0027)"},{"line_number":1151,"context_line":"    i_info[\u0027configdrive\u0027] \u003d info.get(\u0027configdrive\u0027)"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"    if i_info[\u0027ephemeral_gb\u0027] and not i_info[\u0027ephemeral_format\u0027]:"},{"line_number":1154,"context_line":"        i_info[\u0027ephemeral_format\u0027] \u003d CONF.pxe.default_ephemeral_format"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    preserve_ephemeral \u003d info.get(\u0027preserve_ephemeral\u0027, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_314c14c7","line":1153,"in_reply_to":"3aaa91ec_28e82de2","updated":"2016-06-22 11:59:57.000000000","message":"You\u0027re right, thanks for review! This behavior was present earlier, as ephemeral_gb was not written back to i_info after conversion, so passing \"0\" previously had the same drawback. I\u0027ll fix it in a followup.","commit_id":"2e0716720a91030d9600d40dc949c27ff62bc43b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"33f2a684e3f02a908466297b2bf1b3ea99c924bf","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"    i_info[\u0027ephemeral_format\u0027] \u003d info.get(\u0027ephemeral_format\u0027)"},{"line_number":1151,"context_line":"    i_info[\u0027configdrive\u0027] \u003d info.get(\u0027configdrive\u0027)"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"    if i_info[\u0027ephemeral_gb\u0027] and not i_info[\u0027ephemeral_format\u0027]:"},{"line_number":1154,"context_line":"        i_info[\u0027ephemeral_format\u0027] \u003d CONF.pxe.default_ephemeral_format"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    preserve_ephemeral \u003d info.get(\u0027preserve_ephemeral\u0027, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_fc6543e1","line":1153,"in_reply_to":"3aaa91ec_314c14c7","updated":"2016-06-22 12:03:42.000000000","message":"Yes, it works as earlier.","commit_id":"2e0716720a91030d9600d40dc949c27ff62bc43b"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d497e9cfde200c922b50893d00151b9d49bc23ab","unresolved":false,"context_lines":[{"line_number":2123,"context_line":"                          utils.parse_instance_info,"},{"line_number":2124,"context_line":"                          node)"},{"line_number":2125,"context_line":""},{"line_number":2126,"context_line":"    def test_parse_instance_info_valid_ephemeral_gb(self):"},{"line_number":2127,"context_line":"        ephemeral_gb \u003d 10"},{"line_number":2128,"context_line":"        ephemeral_mb \u003d 1024 * ephemeral_gb"},{"line_number":2129,"context_line":"        ephemeral_fmt \u003d \u0027test-fmt\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_b40e01e3","line":2126,"updated":"2016-06-16 20:51:29.000000000","message":"i suppose we are testing both gb and mb, although this might be confusing, not sure.","commit_id":"12057d2cc4ae1b408b54fa9ad1246ff2c53b5b8f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dd1317dd2c604c1e5df868cf190e01665e1bb71e","unresolved":false,"context_lines":[{"line_number":2123,"context_line":"                          utils.parse_instance_info,"},{"line_number":2124,"context_line":"                          node)"},{"line_number":2125,"context_line":""},{"line_number":2126,"context_line":"    def test_parse_instance_info_valid_ephemeral_gb(self):"},{"line_number":2127,"context_line":"        ephemeral_gb \u003d 10"},{"line_number":2128,"context_line":"        ephemeral_mb \u003d 1024 * ephemeral_gb"},{"line_number":2129,"context_line":"        ephemeral_fmt \u003d \u0027test-fmt\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_3865c944","line":2126,"in_reply_to":"7aa08908_b40e01e3","updated":"2016-06-17 11:23:41.000000000","message":"ditto, we pass valid ephemeral_gb, that is why the test is called this way I think.","commit_id":"12057d2cc4ae1b408b54fa9ad1246ff2c53b5b8f"}],"releasenotes/notes/fix-ipa-ephemeral-partition-1f1e020727a49078.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d497e9cfde200c922b50893d00151b9d49bc23ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed a bug with ephemeral partition size not being passed correctly to"},{"line_number":4,"context_line":"    ironic python agent ramdisk."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_547b5df4","line":4,"updated":"2016-06-16 20:51:29.000000000","message":"maybe mention what the effect is of this. Eg\nFixed a bug where the ironic python agent ramdisk was not creating an ephemeral partition because the ephemeral partition size was not being passed correctly to the agent.","commit_id":"12057d2cc4ae1b408b54fa9ad1246ff2c53b5b8f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dd1317dd2c604c1e5df868cf190e01665e1bb71e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed a bug with ephemeral partition size not being passed correctly to"},{"line_number":4,"context_line":"    ironic python agent ramdisk."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aa08908_f8dea1d8","line":4,"in_reply_to":"7aa08908_547b5df4","updated":"2016-06-17 11:23:41.000000000","message":"Will do, thanks.","commit_id":"12057d2cc4ae1b408b54fa9ad1246ff2c53b5b8f"}]}
