)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48136118d21be7be53b9432c577ffce95261b4eb","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d${DEST})"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    # install diskimage-builder if not present"},{"line_number":1059,"context_line":"    if [[ $(type -P disk-image-create) \u003d\u003d \"\" ]]; then"},{"line_number":1060,"context_line":"        install_diskimage_builder"},{"line_number":1061,"context_line":"    fi"},{"line_number":1062,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_0106d184","line":1059,"updated":"2016-06-16 12:41:29.000000000","message":"this check does not look correct to me. At least on my system type -P does not return empty string on missing file, it fails with an error. The correct check is something like:\n\n  if ! $(type -P disk-image-builder \u003e /dev/null); then","commit_id":"67373f88979a655501b6d084f8b39654095bcf0d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d8c07e7d2dcaf1498c3d42ddd653797a17ce2552","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d${DEST})"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    # install diskimage-builder if not present"},{"line_number":1059,"context_line":"    if [[ $(type -P disk-image-create) \u003d\u003d \"\" ]]; then"},{"line_number":1060,"context_line":"        install_diskimage_builder"},{"line_number":1061,"context_line":"    fi"},{"line_number":1062,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_bb8d9e7d","line":1059,"in_reply_to":"7aa08908_0106d184","updated":"2016-06-22 01:12:36.000000000","message":"Done","commit_id":"67373f88979a655501b6d084f8b39654095bcf0d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fba6279819e4051786532e96e02f79d42da2b205","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d${DEST})"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    # install diskimage-builder if not present"},{"line_number":1059,"context_line":"    if [[ $(type -P disk-image-create) \u003d\u003d \"\" ]]; then"},{"line_number":1060,"context_line":"        install_diskimage_builder"},{"line_number":1061,"context_line":"    fi"},{"line_number":1062,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_ba3563a9","line":1059,"in_reply_to":"7aa08908_0106d184","updated":"2016-06-16 14:01:27.000000000","message":"I\u0027m with Dmitry since upon failure the command still returns a blank line, which shouldn\u0027t pass a string compare easily.  We should really avoid string comparisons when possible, and I think Dmitry\u0027s suggestion is best since return codes are returned appropriately if the command is or is not found in the path.","commit_id":"67373f88979a655501b6d084f8b39654095bcf0d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7274314418e5e001db6e9635d6d1f22a7e27ad53","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d${DEST})"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    # install diskimage-builder if not present"},{"line_number":1059,"context_line":"    if [[ $(type -P disk-image-create) \u003d\u003d \"\" ]]; then"},{"line_number":1060,"context_line":"        install_diskimage_builder"},{"line_number":1061,"context_line":"    fi"},{"line_number":1062,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_71e1592a","line":1059,"in_reply_to":"7aa08908_7a05bb12","updated":"2016-06-16 15:57:30.000000000","message":"This is how the test was done previously:\n\nhttps://github.com/openstack/ironic/commit/259a4922437288e9988aa7c201830792b5a0ad45#diff-fb50fd952d51d577ae0be49196b05e5aL1111","commit_id":"67373f88979a655501b6d084f8b39654095bcf0d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3e1f00ef97cb985fef1b0e01d41a54f88cee5a1a","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d${DEST})"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"    # install diskimage-builder if not present"},{"line_number":1059,"context_line":"    if [[ $(type -P disk-image-create) \u003d\u003d \"\" ]]; then"},{"line_number":1060,"context_line":"        install_diskimage_builder"},{"line_number":1061,"context_line":"    fi"},{"line_number":1062,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7aa08908_7a05bb12","line":1059,"in_reply_to":"7aa08908_ba3563a9","updated":"2016-06-16 14:08:20.000000000","message":"Okay, Cinerama has kindly pointed out that $() strips newline chars which I\u0027ve confirmed, so I think what is present here works.  Still not a fan of string compares, but that is just me personally.","commit_id":"67373f88979a655501b6d084f8b39654095bcf0d"}]}