)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"edd53fecb00f223ecdc60a1a2262b098bbb7cda5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    self.assertIsNone(dict.get(key))"},{"line_number":15,"context_line":"since it will pass if 1. the value is None or 2. if the key isn\u0027t"},{"line_number":16,"context_line":"in the dict."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia305a221389e39d759b0881620c200c625fc98e1"},{"line_number":19,"context_line":"Closes-Bug: #1590808"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_6bac888c","line":17,"updated":"2016-06-23 22:30:37.000000000","message":"Not sure if it matters, but some of the tests were changed to \u0027assertNotIn\u0027","commit_id":"4f173b44449b5b111296994f45bcd7751306b469"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ed74fc30c2cc848a2e2e28e8a959db661c110f98","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    self.assertIsNone(dict.get(key))"},{"line_number":15,"context_line":"since it will pass if 1. the value is None or 2. if the key isn\u0027t"},{"line_number":16,"context_line":"in the dict."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia305a221389e39d759b0881620c200c625fc98e1"},{"line_number":19,"context_line":"Closes-Bug: #1590808"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_e456e5cc","line":17,"in_reply_to":"3aaa91ec_6bac888c","updated":"2016-06-24 00:05:02.000000000","message":"Right, because for those tests, it was #2 above. dict.[key] is invalid cuz key is not in dict. So it is better to do assertNotIn. I can update the commit to be more explicit about that.","commit_id":"4f173b44449b5b111296994f45bcd7751306b469"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3795378a2f824567eb35a03d4aef3dd7175e42f7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    self.assertIsNone(dict.get(key))"},{"line_number":15,"context_line":"since it will pass if 1. the value is None or 2. if the key isn\u0027t"},{"line_number":16,"context_line":"in the dict."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia305a221389e39d759b0881620c200c625fc98e1"},{"line_number":19,"context_line":"Closes-Bug: #1590808"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_4402590c","line":17,"in_reply_to":"3aaa91ec_e456e5cc","updated":"2016-06-24 00:31:32.000000000","message":"I think commit message update would be good.","commit_id":"4f173b44449b5b111296994f45bcd7751306b469"}],"ironic/tests/unit/api/v1/test_nodes.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"76d37f52ee2393521d7ecfb53491c2e448400c15","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def test_unassociated_nodes_insensitive(self):"},{"line_number":557,"context_line":"        unassociated \u003d self._create_association_test_nodes()[\u0027unassociated\u0027]"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        data \u003d self.get_json(\u0027/nodes?associated\u003dfalse\u0027)"},{"line_number":560,"context_line":"        data1 \u003d self.get_json(\u0027/nodes?associated\u003dFALSE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_2b98c077","line":557,"updated":"2016-06-23 22:29:39.000000000","message":"Why was the name changed from \u0027unassociated_nodes\u0027 to \u0027unassociated\u0027?  But \u0027associated_nodes\u0027 was not changed","commit_id":"4f173b44449b5b111296994f45bcd7751306b469"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ed74fc30c2cc848a2e2e28e8a959db661c110f98","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def test_unassociated_nodes_insensitive(self):"},{"line_number":557,"context_line":"        unassociated \u003d self._create_association_test_nodes()[\u0027unassociated\u0027]"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        data \u003d self.get_json(\u0027/nodes?associated\u003dfalse\u0027)"},{"line_number":560,"context_line":"        data1 \u003d self.get_json(\u0027/nodes?associated\u003dFALSE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_e46c25d2","line":557,"in_reply_to":"3aaa91ec_2b98c077","updated":"2016-06-24 00:05:02.000000000","message":"because I couldn\u0027t find an indentation/formatting that I liked with \u0027unassociated_nodes\u0027 so I shortened it. Coding is easier than trying to indent/format nicely :-(","commit_id":"4f173b44449b5b111296994f45bcd7751306b469"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"aaffaa4e0905d4b0fdde8a77593ecbd44d28f501","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def test_unassociated_nodes_insensitive(self):"},{"line_number":557,"context_line":"        unassociated \u003d self._create_association_test_nodes()[\u0027unassociated\u0027]"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        data \u003d self.get_json(\u0027/nodes?associated\u003dfalse\u0027)"},{"line_number":560,"context_line":"        data1 \u003d self.get_json(\u0027/nodes?associated\u003dFALSE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_df80d2f9","line":557,"in_reply_to":"3aaa91ec_44541920","updated":"2016-06-24 00:46:44.000000000","message":"thx! (I really don\u0027t like all these line-continuation/indentation rules; it is like a new language...)","commit_id":"4f173b44449b5b111296994f45bcd7751306b469"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3795378a2f824567eb35a03d4aef3dd7175e42f7","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def test_unassociated_nodes_insensitive(self):"},{"line_number":557,"context_line":"        unassociated \u003d self._create_association_test_nodes()[\u0027unassociated\u0027]"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        data \u003d self.get_json(\u0027/nodes?associated\u003dfalse\u0027)"},{"line_number":560,"context_line":"        data1 \u003d self.get_json(\u0027/nodes?associated\u003dFALSE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_44541920","line":557,"in_reply_to":"3aaa91ec_e46c25d2","updated":"2016-06-24 00:31:32.000000000","message":"???\n\nunassociated_nodes \u003d (\n    self._create_association_test_nodes()[\u0027unassociated\u0027])","commit_id":"4f173b44449b5b111296994f45bcd7751306b469"}]}
