)]}'
{"ironic/api/middleware/auth_token.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"818f7604a5e1cf606e5e9dc51adf34fe583392a4","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    def __init__(self, app, conf, public_api_routes\u003dNone):"},{"line_number":35,"context_line":"        public_api_routes \u003d public_api_routes or []"},{"line_number":36,"context_line":"        self._ironic_app \u003d app"},{"line_number":37,"context_line":"        # TODO(mrda): Remove .xml and ensure that doesn\u0027t result in a"},{"line_number":38,"context_line":"        # 401 Authentication Required instead of 404 Not Found"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_e2f78cf3","line":35,"updated":"2016-06-19 13:37:25.000000000","message":"Doesn\u0027t allow user to pass in []\n\nUse:\n\n if public_api_routes is None:\n   public_api_routes \u003d []","commit_id":"c1f38e06873c4432de188359d933e15de2a57f20"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0cf507afe7eaa67c30e6dffae137100dc1003669","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    def __init__(self, app, conf, public_api_routes\u003dNone):"},{"line_number":35,"context_line":"        public_api_routes \u003d public_api_routes or []"},{"line_number":36,"context_line":"        self._ironic_app \u003d app"},{"line_number":37,"context_line":"        # TODO(mrda): Remove .xml and ensure that doesn\u0027t result in a"},{"line_number":38,"context_line":"        # 401 Authentication Required instead of 404 Not Found"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_e2ecac91","line":35,"in_reply_to":"5a9d85d2_e2f78cf3","updated":"2016-06-19 15:06:35.000000000","message":"Done","commit_id":"c1f38e06873c4432de188359d933e15de2a57f20"}],"ironic/common/service.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"818f7604a5e1cf606e5e9dc51adf34fe583392a4","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def prepare_service(argv\u003dNone):"},{"line_number":120,"context_line":"    argv \u003d argv or []"},{"line_number":121,"context_line":"    log.register_options(CONF)"},{"line_number":122,"context_line":"    log.set_defaults(default_log_levels\u003d[\u0027amqp\u003dWARNING\u0027,"},{"line_number":123,"context_line":"                                         \u0027amqplib\u003dWARNING\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_628d5c7b","line":120,"updated":"2016-06-19 13:37:25.000000000","message":"Doesn\u0027t allow user to pass in []\n\nUse:\n\n if argv is None:\n   argv \u003d []","commit_id":"c1f38e06873c4432de188359d933e15de2a57f20"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0cf507afe7eaa67c30e6dffae137100dc1003669","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def prepare_service(argv\u003dNone):"},{"line_number":120,"context_line":"    argv \u003d argv or []"},{"line_number":121,"context_line":"    log.register_options(CONF)"},{"line_number":122,"context_line":"    log.set_defaults(default_log_levels\u003d[\u0027amqp\u003dWARNING\u0027,"},{"line_number":123,"context_line":"                                         \u0027amqplib\u003dWARNING\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_4202e03f","line":120,"in_reply_to":"5a9d85d2_628d5c7b","updated":"2016-06-19 15:06:35.000000000","message":"Done","commit_id":"c1f38e06873c4432de188359d933e15de2a57f20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1bd0af8a4e2166cb7a5fc5fa61160626f505fbf5","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def prepare_service(argv\u003dNone):"},{"line_number":120,"context_line":"    argv \u003d [] if argv is None or argv"},{"line_number":121,"context_line":"    log.register_options(CONF)"},{"line_number":122,"context_line":"    log.set_defaults(default_log_levels\u003d[\u0027amqp\u003dWARNING\u0027,"},{"line_number":123,"context_line":"                                         \u0027amqplib\u003dWARNING\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_36ff1936","line":120,"updated":"2016-06-19 16:31:08.000000000","message":"s/or/else/\n\nor simply:\n\n argv \u003d argv or []","commit_id":"0d6855a2dce2f3f71e381ff71d0da77fc954a359"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d1d97f4ab64e659fbe61d1b3bd30738a39940fb3","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def prepare_service(argv\u003dNone):"},{"line_number":120,"context_line":"    argv \u003d [] if argv is None or argv"},{"line_number":121,"context_line":"    log.register_options(CONF)"},{"line_number":122,"context_line":"    log.set_defaults(default_log_levels\u003d[\u0027amqp\u003dWARNING\u0027,"},{"line_number":123,"context_line":"                                         \u0027amqplib\u003dWARNING\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_b9513a11","line":120,"in_reply_to":"5a9d85d2_36ff1936","updated":"2016-06-19 16:52:25.000000000","message":"I commented about this on patch set 1, disagreeing with that method.\n\nI don\u0027t like that, as user can\u0027t pass in [].  Basically saying that 0, \"\", {}, [], False will be converted to []\n\nMaybe it is me being pedantic. But the function definition is saying that None is the default value. So I believe we should only treat None as the default value.","commit_id":"0d6855a2dce2f3f71e381ff71d0da77fc954a359"}],"ironic/tests/unit/api/test_acl.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"818f7604a5e1cf606e5e9dc51adf34fe583392a4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return super(TestACL, self).get_json(path,"},{"line_number":43,"context_line":"                                             expect_errors\u003dexpect_errors,"},{"line_number":44,"context_line":"                                             headers\u003dheaders,"},{"line_number":45,"context_line":"                                             q\u003dq or [],"},{"line_number":46,"context_line":"                                             extra_environ\u003dself.environ,"},{"line_number":47,"context_line":"                                             **param)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_82904897","line":45,"updated":"2016-06-19 13:37:25.000000000","message":"Doesn\u0027t allow user to pass in []\n\nUse:\n\n if q is None:\n   q \u003d []","commit_id":"c1f38e06873c4432de188359d933e15de2a57f20"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0cf507afe7eaa67c30e6dffae137100dc1003669","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        return super(TestACL, self).get_json(path,"},{"line_number":43,"context_line":"                                             expect_errors\u003dexpect_errors,"},{"line_number":44,"context_line":"                                             headers\u003dheaders,"},{"line_number":45,"context_line":"                                             q\u003dq or [],"},{"line_number":46,"context_line":"                                             extra_environ\u003dself.environ,"},{"line_number":47,"context_line":"                                             **param)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_02e8d87b","line":45,"in_reply_to":"5a9d85d2_82904897","updated":"2016-06-19 15:06:35.000000000","message":"Done","commit_id":"c1f38e06873c4432de188359d933e15de2a57f20"}]}
