)]}'
{"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"970fbda4c8f05605cf3765c21afc04d4e8cd4394","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    task.node.save()"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"def _notify_conductor_resume_clean(task):"},{"line_number":175,"context_line":"    LOG.debug(\u0027Sending RPC to conductor to resume cleaning for node %s\u0027,"},{"line_number":176,"context_line":"              task.node.uuid)"},{"line_number":177,"context_line":"    uuid \u003d task.node.uuid"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_77da8ee9","line":174,"updated":"2016-07-20 22:11:09.000000000","message":"nit: please do not mark this function as private, it can be used in out of tree drivers.","commit_id":"a9216bb07f4ccd4dc202fd1f5c14b36a08ac6046"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2a8871b8ad1a9f0ae4bf5affc479f19ba52f3da9","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    task.node.save()"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"def _notify_conductor_resume_clean(task):"},{"line_number":175,"context_line":"    LOG.debug(\u0027Sending RPC to conductor to resume cleaning for node %s\u0027,"},{"line_number":176,"context_line":"              task.node.uuid)"},{"line_number":177,"context_line":"    uuid \u003d task.node.uuid"}],"source_content_type":"text/x-python","patch_set":19,"id":"dada55a8_9d15a141","line":174,"in_reply_to":"dada55a8_77da8ee9","updated":"2016-07-20 22:44:10.000000000","message":"And also add docstring.","commit_id":"a9216bb07f4ccd4dc202fd1f5c14b36a08ac6046"}],"ironic/drivers/modules/amt/vendor.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5860fef74249ae074b72b2f4e56e75b50fd4de74","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class AMTPXEVendorPassthru(iscsi_deploy.VendorPassthru):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":26,"context_line":"    def continue_deploy(self, task):"},{"line_number":27,"context_line":"        if deploy_utils.get_boot_option(task.node) \u003d\u003d \"netboot\":"},{"line_number":28,"context_line":"            task.driver.management.ensure_next_boot_device(task.node,"},{"line_number":29,"context_line":"                                                           boot_devices.PXE)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_56fec637","line":26,"updated":"2016-07-05 14:03:42.000000000","message":"So it seems that this change may break out of tree vendor interfaces, can we keep **kwargs for some time?","commit_id":"0a4d852a1e44546de9c264a52475b9d9372548a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"52d14755b4640364905e09e08072d200e0e99ab5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class AMTPXEVendorPassthru(iscsi_deploy.VendorPassthru):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":26,"context_line":"    def continue_deploy(self, task):"},{"line_number":27,"context_line":"        if deploy_utils.get_boot_option(task.node) \u003d\u003d \"netboot\":"},{"line_number":28,"context_line":"            task.driver.management.ensure_next_boot_device(task.node,"},{"line_number":29,"context_line":"                                                           boot_devices.PXE)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_1373ab4e","line":26,"in_reply_to":"1aa78d24_01923a57","updated":"2016-07-05 14:58:16.000000000","message":"Hmm, after a quick search in our docs, I don\u0027t see that our driver interface is not stable, but I do remember some discussion about it. It seems to be a good candidate for release note mention :)","commit_id":"0a4d852a1e44546de9c264a52475b9d9372548a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c150eca065bc266e7c2c3c4e616aad57496fbdb0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class AMTPXEVendorPassthru(iscsi_deploy.VendorPassthru):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":26,"context_line":"    def continue_deploy(self, task):"},{"line_number":27,"context_line":"        if deploy_utils.get_boot_option(task.node) \u003d\u003d \"netboot\":"},{"line_number":28,"context_line":"            task.driver.management.ensure_next_boot_device(task.node,"},{"line_number":29,"context_line":"                                                           boot_devices.PXE)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_01923a57","line":26,"in_reply_to":"1aa78d24_56fec637","updated":"2016-07-05 14:06:25.000000000","message":"I don\u0027t think so. We don\u0027t have a stable interface for drivers, and anyway we do folks a disservice carrying around kwargs that are not actually used.","commit_id":"0a4d852a1e44546de9c264a52475b9d9372548a7"}],"ironic/tests/unit/drivers/modules/test_agent.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"a3cf200e344b67fbb29242718b4978343843d65d","unresolved":false,"context_lines":[{"line_number":612,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":613,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":614,"context_line":"            self.driver.heartbeat(task, \u0027url\u0027)"},{"line_number":615,"context_line":"            self.assertFalse(task.shared)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"class TestAgentVendor(db_base.DbTestCase):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_028f1376","line":615,"range":{"start_line":615,"start_character":0,"end_line":615,"end_character":41},"updated":"2016-07-14 14:19:43.000000000","message":"this assertion isn\u0027t clear to me at the first glance, maybe add an explaining comment?","commit_id":"936cca326340d0dfc44269476dde6b82b7490fe6"}],"ironic/tests/unit/drivers/modules/test_iscsi_deploy.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"a3cf200e344b67fbb29242718b4978343843d65d","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":654,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":655,"context_line":"            self.driver.deploy.heartbeat(task, \u0027url\u0027)"},{"line_number":656,"context_line":"            self.assertFalse(task.shared)"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"class TestVendorPassthru(db_base.DbTestCase):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1aa78d24_3d934e02","line":656,"range":{"start_line":656,"start_character":0,"end_line":656,"end_character":41},"updated":"2016-07-14 14:19:43.000000000","message":"ditto with test_agent.py; not clear to me at first glance what is asserted; add a #note perhaps?","commit_id":"936cca326340d0dfc44269476dde6b82b7490fe6"}],"releasenotes/notes/agent-api-bf9f18d8d38075e4.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5860fef74249ae074b72b2f4e56e75b50fd4de74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The agent drivers now support the new family of ramdisk API (\"/v1/lookup\""},{"line_number":4,"context_line":"    and \"/v1/heartbeat\")."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_c124b2b0","line":3,"updated":"2016-07-05 14:03:42.000000000","message":"It\u0027s just a refactor now right? :)","commit_id":"0a4d852a1e44546de9c264a52475b9d9372548a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c150eca065bc266e7c2c3c4e616aad57496fbdb0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The agent drivers now support the new family of ramdisk API (\"/v1/lookup\""},{"line_number":4,"context_line":"    and \"/v1/heartbeat\")."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1aa78d24_818c6a36","line":3,"in_reply_to":"1aa78d24_c124b2b0","updated":"2016-07-05 14:06:25.000000000","message":"Correct, I think we should remove the release note (previously this patch was after API).","commit_id":"0a4d852a1e44546de9c264a52475b9d9372548a7"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"64aeccbfefe5d9e2cd96c946cd179c7b0bc655cb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - The \"continue_deploy\" and \"reboot_to_instance\" methods in the"},{"line_number":4,"context_line":"    \"BaseAgentVendor\" class stopped accepting ** arguments. They were never"},{"line_number":5,"context_line":"    used anyway; the drivers should stop passing anything there."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"dada55a8_80bc5f6d","line":5,"updated":"2016-07-25 18:17:38.000000000","message":"Should we add something about the classes moving around, and things that were subclassing may need to change?","commit_id":"a9216bb07f4ccd4dc202fd1f5c14b36a08ac6046"}]}