)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"626d810e6110f54d8ea31463b520e3f30de4393e","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"    if [[ -z \"$Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\" ]]; then"},{"line_number":1254,"context_line":"        Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\u003d\"flat_networks\u003d$IRONIC_FLAT_PHYSYCAL_NETWORK\""},{"line_number":1255,"context_line":"    else"},{"line_number":1256,"context_line":"        Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\u003d\"${Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS},${IRONIC_FLAT_PHYSYCAL_NETWORK}\""},{"line_number":1257,"context_line":"    fi"},{"line_number":1258,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE ovs bridge_mappings $OVS_BRIDGE_MAPPINGS"},{"line_number":1259,"context_line":"    populate_ml2_config /$Q_PLUGIN_CONF_FILE ml2_type_flat $Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_17a52ca1","line":1256,"updated":"2016-06-29 17:12:51.000000000","message":"Shouldn\u0027t it be flat_networks\u003d${IRONIC_FLAT_PHYSYCAL_NETWORK} here too?","commit_id":"7508fdb03881de127221638834dc5803992b03df"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2aa49552a0fd2fe65064709eabc07bb0f6a6cd71","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"    if [[ -z \"$Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\" ]]; then"},{"line_number":1254,"context_line":"        Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\u003d\"flat_networks\u003d$IRONIC_FLAT_PHYSYCAL_NETWORK\""},{"line_number":1255,"context_line":"    else"},{"line_number":1256,"context_line":"        Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\u003d\"${Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS},${IRONIC_FLAT_PHYSYCAL_NETWORK}\""},{"line_number":1257,"context_line":"    fi"},{"line_number":1258,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE ovs bridge_mappings $OVS_BRIDGE_MAPPINGS"},{"line_number":1259,"context_line":"    populate_ml2_config /$Q_PLUGIN_CONF_FILE ml2_type_flat $Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_ad178443","line":1256,"in_reply_to":"3aaa91ec_17a52ca1","updated":"2016-06-30 11:48:07.000000000","message":"If user configured Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS we assume that he knows what he doing. If flat network should be configured user may add if directly to Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS in local.conf.","commit_id":"7508fdb03881de127221638834dc5803992b03df"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"626d810e6110f54d8ea31463b520e3f30de4393e","unresolved":false,"context_lines":[{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"function ironic_cleanup_neutron_flat_network {"},{"line_number":1263,"context_line":"    sudo ip link del dev $IRONIC_FLAT_PHYSYCAL_INTERFACE"},{"line_number":1264,"context_line":"    sudo rmmod dummy"},{"line_number":1265,"context_line":"    sudo ovs-vsctl del-br $IRONIC_VM_NETWORK_BRIDGE"},{"line_number":1266,"context_line":"}"},{"line_number":1267,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_f7cfc053","line":1264,"updated":"2016-06-29 17:12:51.000000000","message":"Do we need to do this if it was enabled beforehand?","commit_id":"7508fdb03881de127221638834dc5803992b03df"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2aa49552a0fd2fe65064709eabc07bb0f6a6cd71","unresolved":false,"context_lines":[{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"function ironic_cleanup_neutron_flat_network {"},{"line_number":1263,"context_line":"    sudo ip link del dev $IRONIC_FLAT_PHYSYCAL_INTERFACE"},{"line_number":1264,"context_line":"    sudo rmmod dummy"},{"line_number":1265,"context_line":"    sudo ovs-vsctl del-br $IRONIC_VM_NETWORK_BRIDGE"},{"line_number":1266,"context_line":"}"},{"line_number":1267,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3aaa91ec_6d663cee","line":1264,"in_reply_to":"3aaa91ec_f7cfc053","updated":"2016-06-30 11:48:07.000000000","message":"Unfortunately there is no possibility to check we load dummy module. Better to left it loaded since it may harm.","commit_id":"7508fdb03881de127221638834dc5803992b03df"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3b6a33602b47e85c1ead30cc4c365f5ef92cd836","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3aaa91ec_a9060a83","updated":"2016-07-01 16:31:02.000000000","message":"Change all PHYSYCAL to PHYSICAL","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7a3cdbb9c37e4dedb98bc8a9a1567014a355ce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1aa78d24_f163933f","in_reply_to":"3aaa91ec_a9060a83","updated":"2016-07-05 07:47:14.000000000","message":"Done","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3b6a33602b47e85c1ead30cc4c365f5ef92cd836","unresolved":false,"context_lines":[{"line_number":93,"context_line":"if [ \"$IRONIC_USE_FLAT_NETWORK\" \u003d \"True\" ]; then"},{"line_number":94,"context_line":"    IRONIC_FLAT_NETWORK_NAME\u003d${IRONIC_FLAT_NETWORK_NAME:-ironic-flat}"},{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":"IRONIC_FLAT_PHYSYCAL_NETWORK\u003d${IRONIC_FLAT_PHYSYCAL_NETWORK:-physnet-ironic}"},{"line_number":97,"context_line":"# Physycal interface name to be used for ironic flat Neutron network."},{"line_number":98,"context_line":"# If interface doesn\u0027t exist dummy device will be created."},{"line_number":99,"context_line":"IRONIC_FLAT_PHYSYCAL_INTERFACE\u003d${IRONIC_FLAT_PHYSYCAL_INTERFACE:-dummy0}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_e99bf264","line":96,"updated":"2016-07-01 16:31:02.000000000","message":"PHYSICAL for both names","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7a3cdbb9c37e4dedb98bc8a9a1567014a355ce5","unresolved":false,"context_lines":[{"line_number":93,"context_line":"if [ \"$IRONIC_USE_FLAT_NETWORK\" \u003d \"True\" ]; then"},{"line_number":94,"context_line":"    IRONIC_FLAT_NETWORK_NAME\u003d${IRONIC_FLAT_NETWORK_NAME:-ironic-flat}"},{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":"IRONIC_FLAT_PHYSYCAL_NETWORK\u003d${IRONIC_FLAT_PHYSYCAL_NETWORK:-physnet-ironic}"},{"line_number":97,"context_line":"# Physycal interface name to be used for ironic flat Neutron network."},{"line_number":98,"context_line":"# If interface doesn\u0027t exist dummy device will be created."},{"line_number":99,"context_line":"IRONIC_FLAT_PHYSYCAL_INTERFACE\u003d${IRONIC_FLAT_PHYSYCAL_INTERFACE:-dummy0}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1aa78d24_9155ef51","line":96,"in_reply_to":"3aaa91ec_e99bf264","updated":"2016-07-05 07:47:14.000000000","message":"Done","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3b6a33602b47e85c1ead30cc4c365f5ef92cd836","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    IRONIC_FLAT_NETWORK_NAME\u003d${IRONIC_FLAT_NETWORK_NAME:-ironic-flat}"},{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":"IRONIC_FLAT_PHYSYCAL_NETWORK\u003d${IRONIC_FLAT_PHYSYCAL_NETWORK:-physnet-ironic}"},{"line_number":97,"context_line":"# Physycal interface name to be used for ironic flat Neutron network."},{"line_number":98,"context_line":"# If interface doesn\u0027t exist dummy device will be created."},{"line_number":99,"context_line":"IRONIC_FLAT_PHYSYCAL_INTERFACE\u003d${IRONIC_FLAT_PHYSYCAL_INTERFACE:-dummy0}"},{"line_number":100,"context_line":"IRONIC_FLAT_SUBNET\u003d${IRONIC_FLAT_SUBNET:-10.20.30.0/24}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_a9d56a1c","line":97,"range":{"start_line":97,"start_character":2,"end_line":97,"end_character":10},"updated":"2016-07-01 16:31:02.000000000","message":"Physical\n\nnit: Capitalize Ironic or don\u0027t capitalize Neutron","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7a3cdbb9c37e4dedb98bc8a9a1567014a355ce5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    IRONIC_FLAT_NETWORK_NAME\u003d${IRONIC_FLAT_NETWORK_NAME:-ironic-flat}"},{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":"IRONIC_FLAT_PHYSYCAL_NETWORK\u003d${IRONIC_FLAT_PHYSYCAL_NETWORK:-physnet-ironic}"},{"line_number":97,"context_line":"# Physycal interface name to be used for ironic flat Neutron network."},{"line_number":98,"context_line":"# If interface doesn\u0027t exist dummy device will be created."},{"line_number":99,"context_line":"IRONIC_FLAT_PHYSYCAL_INTERFACE\u003d${IRONIC_FLAT_PHYSYCAL_INTERFACE:-dummy0}"},{"line_number":100,"context_line":"IRONIC_FLAT_SUBNET\u003d${IRONIC_FLAT_SUBNET:-10.20.30.0/24}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1aa78d24_b1e10b9d","line":97,"range":{"start_line":97,"start_character":2,"end_line":97,"end_character":10},"in_reply_to":"3aaa91ec_a9d56a1c","updated":"2016-07-05 07:47:14.000000000","message":"Done","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3b6a33602b47e85c1ead30cc4c365f5ef92cd836","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"    fi"},{"line_number":1235,"context_line":"}"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"function ironic_configure_neutron_flat_network {"},{"line_number":1238,"context_line":"    local prefix"},{"line_number":1239,"context_line":"    prefix\u003d$(echo $IRONIC_FLAT_SUBNET | cut -d \u0027/\u0027 -f 2)"},{"line_number":1240,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_ecf5c0ed","line":1237,"updated":"2016-07-01 16:31:02.000000000","message":"I think we need more comments in this function on what it is doing. Maybe an overview of the goal of the function.","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3b6a33602b47e85c1ead30cc4c365f5ef92cd836","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"}"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"function ironic_configure_neutron_flat_network {"},{"line_number":1238,"context_line":"    local prefix"},{"line_number":1239,"context_line":"    prefix\u003d$(echo $IRONIC_FLAT_SUBNET | cut -d \u0027/\u0027 -f 2)"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    if ! $(ip link list |grep -q $IRONIC_FLAT_PHYSYCAL_INTERFACE); then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_ec0b0023","line":1238,"range":{"start_line":1238,"start_character":10,"end_line":1238,"end_character":16},"updated":"2016-07-01 16:31:02.000000000","message":"I\u0027d prefer \u0027subnet_mask\u0027 or \u0027net_mask\u0027 or \u0027cidr\u0027 or \u0027mask\u0027","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7a3cdbb9c37e4dedb98bc8a9a1567014a355ce5","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"}"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"function ironic_configure_neutron_flat_network {"},{"line_number":1238,"context_line":"    local prefix"},{"line_number":1239,"context_line":"    prefix\u003d$(echo $IRONIC_FLAT_SUBNET | cut -d \u0027/\u0027 -f 2)"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    if ! $(ip link list |grep -q $IRONIC_FLAT_PHYSYCAL_INTERFACE); then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1aa78d24_9502fa07","line":1238,"range":{"start_line":1238,"start_character":10,"end_line":1238,"end_character":16},"in_reply_to":"3aaa91ec_ec0b0023","updated":"2016-07-05 07:47:14.000000000","message":"In networking terms there is a difference between subnet mask and prefix. The prefix shows how many bits we using for subnet part eg: /24, while subnet mask is decimal representation: 255.255.255.0","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3b6a33602b47e85c1ead30cc4c365f5ef92cd836","unresolved":false,"context_lines":[{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    if ! $(ip link list |grep -q $IRONIC_FLAT_PHYSYCAL_INTERFACE); then"},{"line_number":1242,"context_line":"        lsmod |grep -q \"dummy\" || sudo modprobe dummy"},{"line_number":1243,"context_line":"        # NOTE(vsaienko) loading dummy module will create dummy0 by defaul."},{"line_number":1244,"context_line":"        # Ignoring \"RTNETLINK answers: File exists\" in this case."},{"line_number":1245,"context_line":"        sudo ip link add $IRONIC_FLAT_PHYSYCAL_INTERFACE type dummy || true"},{"line_number":1246,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_cc4a845b","line":1243,"range":{"start_line":1243,"start_character":68,"end_line":1243,"end_character":74},"updated":"2016-07-01 16:31:02.000000000","message":"default","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7a3cdbb9c37e4dedb98bc8a9a1567014a355ce5","unresolved":false,"context_lines":[{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    if ! $(ip link list |grep -q $IRONIC_FLAT_PHYSYCAL_INTERFACE); then"},{"line_number":1242,"context_line":"        lsmod |grep -q \"dummy\" || sudo modprobe dummy"},{"line_number":1243,"context_line":"        # NOTE(vsaienko) loading dummy module will create dummy0 by defaul."},{"line_number":1244,"context_line":"        # Ignoring \"RTNETLINK answers: File exists\" in this case."},{"line_number":1245,"context_line":"        sudo ip link add $IRONIC_FLAT_PHYSYCAL_INTERFACE type dummy || true"},{"line_number":1246,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1aa78d24_751e6e64","line":1243,"range":{"start_line":1243,"start_character":68,"end_line":1243,"end_character":74},"in_reply_to":"3aaa91ec_cc4a845b","updated":"2016-07-05 07:47:14.000000000","message":"Done","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3b6a33602b47e85c1ead30cc4c365f5ef92cd836","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"    if [[ -z \"$Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\" ]]; then"},{"line_number":1254,"context_line":"        Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\u003d\"flat_networks\u003d$IRONIC_FLAT_PHYSYCAL_NETWORK\""},{"line_number":1255,"context_line":"    fi"},{"line_number":1256,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE ovs bridge_mappings $OVS_BRIDGE_MAPPINGS"},{"line_number":1257,"context_line":"    populate_ml2_config /$Q_PLUGIN_CONF_FILE ml2_type_flat $Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS"},{"line_number":1258,"context_line":"}"},{"line_number":1259,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3aaa91ec_4cccd48a","line":1256,"updated":"2016-07-01 16:31:02.000000000","message":"Maybe this line could be put under 1252? Seems related to 1252 and would make it easier to read.","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7a3cdbb9c37e4dedb98bc8a9a1567014a355ce5","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"    if [[ -z \"$Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\" ]]; then"},{"line_number":1254,"context_line":"        Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS\u003d\"flat_networks\u003d$IRONIC_FLAT_PHYSYCAL_NETWORK\""},{"line_number":1255,"context_line":"    fi"},{"line_number":1256,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE ovs bridge_mappings $OVS_BRIDGE_MAPPINGS"},{"line_number":1257,"context_line":"    populate_ml2_config /$Q_PLUGIN_CONF_FILE ml2_type_flat $Q_ML2_PLUGIN_FLAT_TYPE_OPTIONS"},{"line_number":1258,"context_line":"}"},{"line_number":1259,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1aa78d24_d523e2a5","line":1256,"in_reply_to":"3aaa91ec_4cccd48a","updated":"2016-07-05 07:47:14.000000000","message":"Done","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"63ba65e9c17cef660d502dac1d1c3f008caa4759","unresolved":false,"context_lines":[{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"function ironic_add_neutron_flat_network {"},{"line_number":1266,"context_line":"    local subnet_id"},{"line_number":1267,"context_line":"    openstack network create  $IRONIC_FLAT_NETWORK_NAME --share --provider-network-type flat --provider-physical-network $IRONIC_FLAT_PHYSYCAL_NETWORK -f value -c id"},{"line_number":1268,"context_line":"    subnet_id\u003d$(openstack subnet create --dhcp $IRONIC_FLAT_SUBNET --network $IRONIC_FLAT_NETWORK_NAME --subnet-range $IRONIC_FLAT_SUBNET -f value -c id)"},{"line_number":1269,"context_line":"    neutron router-interface-add $Q_ROUTER_NAME $subnet_id"},{"line_number":1270,"context_line":"}"},{"line_number":1271,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1aa78d24_72e84ee3","line":1268,"range":{"start_line":1267,"start_character":4,"end_line":1268,"end_character":3},"updated":"2016-07-04 22:17:49.000000000","message":"nits: It is better that we need to check the result if the network/subnet is created and returned or not, for some reason, such as the wrong physical mapping case or other reasons, make sense?\n\ndie_if_not_set $LINENO subnet_id \"Failed to create subnet\"","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7a3cdbb9c37e4dedb98bc8a9a1567014a355ce5","unresolved":false,"context_lines":[{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"function ironic_add_neutron_flat_network {"},{"line_number":1266,"context_line":"    local subnet_id"},{"line_number":1267,"context_line":"    openstack network create  $IRONIC_FLAT_NETWORK_NAME --share --provider-network-type flat --provider-physical-network $IRONIC_FLAT_PHYSYCAL_NETWORK -f value -c id"},{"line_number":1268,"context_line":"    subnet_id\u003d$(openstack subnet create --dhcp $IRONIC_FLAT_SUBNET --network $IRONIC_FLAT_NETWORK_NAME --subnet-range $IRONIC_FLAT_SUBNET -f value -c id)"},{"line_number":1269,"context_line":"    neutron router-interface-add $Q_ROUTER_NAME $subnet_id"},{"line_number":1270,"context_line":"}"},{"line_number":1271,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1aa78d24_15c0ca7b","line":1268,"range":{"start_line":1267,"start_character":4,"end_line":1268,"end_character":3},"in_reply_to":"1aa78d24_72e84ee3","updated":"2016-07-05 07:47:14.000000000","message":"Done","commit_id":"8ae4ff8fd6ba393ba57c35e5b2703105091e65ac"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"8d622b84f0752a3587efbdbcd5b24ebc237bddc8","unresolved":false,"context_lines":[{"line_number":1590,"context_line":"}"},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"function ironic_cleanup_neutron_flat_network {"},{"line_number":1593,"context_line":"    sudo ovs-vsctl del-br $IRONIC_VM_NETWORK_BRIDGE"},{"line_number":1594,"context_line":"}"},{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"function ironic_add_neutron_flat_network {"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba5da102_7c436342","line":1593,"updated":"2016-11-02 14:37:57.000000000","message":"Hi, I added a comment about this change in child change: https://review.openstack.org/#/c/338117/","commit_id":"9f6637fc950f1c136405e04a4bb28457363370cd"}]}
