)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"31d931ad3d377385597a248bf7e649fd4f42f911","unresolved":false,"context_lines":[{"line_number":11,"context_line":"(partly affected by cloud-init scripts for the node)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch-set resizes nodes.instance_info to LONGTEXT which allows up"},{"line_number":14,"context_line":"to 4Gb of data to be stored in the column. This change is relevant only"},{"line_number":15,"context_line":"to mysql and does not affect postgres or any other DB flavor. The fix"},{"line_number":16,"context_line":"also addresses the upgrade process of the column."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_9999c771","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":6},"updated":"2016-07-18 14:54:00.000000000","message":"Gb or GB? Just making sure.","commit_id":"6d4cad6f18b7cfbd8a835c3c361f044a8c67bdbb"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"f2454b90f9be8c7c4b9cf6f58c982658984ff3dd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"(partly affected by cloud-init scripts for the node)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch-set resizes nodes.instance_info to LONGTEXT which allows up"},{"line_number":14,"context_line":"to 4Gb of data to be stored in the column. This change is relevant only"},{"line_number":15,"context_line":"to mysql and does not affect postgres or any other DB flavor. The fix"},{"line_number":16,"context_line":"also addresses the upgrade process of the column."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a89bdaa_cb2c4bae","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":6},"in_reply_to":"dada55a8_54ff1601","updated":"2016-09-04 10:21:58.000000000","message":"Done","commit_id":"6d4cad6f18b7cfbd8a835c3c361f044a8c67bdbb"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"2fce1551f9316462fa359e8784b03b32b13fabb4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"(partly affected by cloud-init scripts for the node)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch-set resizes nodes.instance_info to LONGTEXT which allows up"},{"line_number":14,"context_line":"to 4Gb of data to be stored in the column. This change is relevant only"},{"line_number":15,"context_line":"to mysql and does not affect postgres or any other DB flavor. The fix"},{"line_number":16,"context_line":"also addresses the upgrade process of the column."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_54ff1601","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":6},"in_reply_to":"dada55a8_9999c771","updated":"2016-07-18 15:02:30.000000000","message":"My bad. Thank you for pointing this out.\nIt\u0027s GB","commit_id":"6d4cad6f18b7cfbd8a835c3c361f044a8c67bdbb"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c282fe68be6d99f51714bf39e5156d1271e7908b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Edery \u003cdavid.edery@alcatel-lucent.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-09 01:08:25 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix non-deployed nodes due to short nodes.instance_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In mysql, the maximum size of TEXT is 64KiB. nodes.instance_info"},{"line_number":10,"context_line":"is defined as TEXT and can potentially hold big amount of data"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_a803940e","line":7,"updated":"2016-09-13 20:48:36.000000000","message":"I think it would be good to mention in the commit message that this allows the configdrive to be larger than 64KiB. As people may not realize that \u0027instance_info\u0027 is what stores the configdrive.","commit_id":"09c84ce72b5cdadb0f1713f02007045ed5f078d5"}],"ironic/db/sqlalchemy/alembic/versions/e918ff30eb42_resize_column_nodes_instance_info.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a3df2508f3d21947a0bded3cc9b51f206e3a9391","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"resize column nodes instance_info"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: e918ff30eb42"},{"line_number":16,"context_line":"Revises: f6fdb920c182"},{"line_number":17,"context_line":"Create Date: 2016-06-28 13:30:19.396203"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_9803a10d","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"updated":"2016-07-17 19:01:07.000000000","message":"You have two heads on alembic.\nThis value must change.","commit_id":"8f489a77c7440dc3403f11816dce85687e5ce9f1"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"19c3fe73a36533b67e723992af949182cb90f5ed","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"resize column nodes instance_info"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: e918ff30eb42"},{"line_number":16,"context_line":"Revises: f6fdb920c182"},{"line_number":17,"context_line":"Create Date: 2016-06-28 13:30:19.396203"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f8561d05","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"in_reply_to":"dada55a8_9803a10d","updated":"2016-07-17 19:17:49.000000000","message":"Should be 10b163d4481e\n\nDo: \"alembic heads\" to check that you have only one head","commit_id":"8f489a77c7440dc3403f11816dce85687e5ce9f1"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"80c8598bd4c0a423f966e8e32a787880a9cb3de0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"resize column nodes instance_info"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: e918ff30eb42"},{"line_number":16,"context_line":"Revises: f6fdb920c182"},{"line_number":17,"context_line":"Create Date: 2016-06-28 13:30:19.396203"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_784b4d5a","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"in_reply_to":"dada55a8_f8561d05","updated":"2016-07-17 19:22:26.000000000","message":"Done\n\nThank you :)","commit_id":"8f489a77c7440dc3403f11816dce85687e5ce9f1"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8e9cc4d57f52eb6ce8a2c12cf3d49d09ab0c16ef","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    target_provision_state \u003d Column(String(15), nullable\u003dTrue)"},{"line_number":137,"context_line":"    provision_updated_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":138,"context_line":"    last_error \u003d Column(Text, nullable\u003dTrue)"},{"line_number":139,"context_line":"    instance_info \u003d Column(db_types.JsonEncodedDict(mysql_as_long\u003dTrue))"},{"line_number":140,"context_line":"    properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":141,"context_line":"    driver \u003d Column(String(255))"},{"line_number":142,"context_line":"    driver_info \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa0c359_e04ca177","line":139,"updated":"2018-02-20 15:05:33.000000000","message":"I was trying to think about any ramifications wrt rolling upgrades; I saw David\u0027s comment in patch set 8. If JsonEncodedDict doesn\u0027t care about the text length (wrt reading from the DB), why would we need to make this change. jroll suggested that it is cuz this is needed to generate the schema for migrations and there may be some validation being done on writes.","commit_id":"c68c1681b0afe75fedb509aa44a73473a929e78c"}],"ironic/db/sqlalchemy/types.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"623a92d0f4d0c68ed32c1512a711e4052aab4d14","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sqlalchemy.dialects import mysql"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class JsonEncodedLongTextDict(db_types.JsonEncodedDict):"},{"line_number":27,"context_line":"    impl \u003d sa.Text().with_variant(mysql.LONGTEXT(), \u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_2ff10f6b","line":26,"updated":"2016-06-29 09:43:10.000000000","message":"It is better to add this type to oslo-db.","commit_id":"3f4060df4ee8e21c02bc95367a4caf333c2f2321"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"eb134bee4d812213432f21004c1025b21212bc05","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sqlalchemy.dialects import mysql"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class JsonEncodedLongTextDict(db_types.JsonEncodedDict):"},{"line_number":27,"context_line":"    impl \u003d sa.Text().with_variant(mysql.LONGTEXT(), \u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_a5769ba1","line":26,"in_reply_to":"1aa78d24_6e483988","updated":"2016-07-06 11:40:27.000000000","message":"David, since LongText is already defined in mistral definetly it should be moved to oslo-db.\nhttps://github.com/openstack/mistral/blob/master/mistral/db/sqlalchemy/types.py#L86\n\nI\u0027m ok to change instance_info type. Adding new field for config_drive may be considered as well.","commit_id":"3f4060df4ee8e21c02bc95367a4caf333c2f2321"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"c4c2becbed7d4b5063247e966fee12792e93a30e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sqlalchemy.dialects import mysql"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class JsonEncodedLongTextDict(db_types.JsonEncodedDict):"},{"line_number":27,"context_line":"    impl \u003d sa.Text().with_variant(mysql.LONGTEXT(), \u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_4347811d","line":26,"in_reply_to":"1aa78d24_a5769ba1","updated":"2016-07-08 04:03:14.000000000","message":"Done","commit_id":"3f4060df4ee8e21c02bc95367a4caf333c2f2321"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"96c8a3e0f5340f45a24c7bdb35a9a2a071af2f98","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sqlalchemy.dialects import mysql"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class JsonEncodedLongTextDict(db_types.JsonEncodedDict):"},{"line_number":27,"context_line":"    impl \u003d sa.Text().with_variant(mysql.LONGTEXT(), \u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3a156b9b","line":26,"in_reply_to":"1aa78d24_a5769ba1","updated":"2016-07-07 09:51:42.000000000","message":"Thank you.\n\nGiven that changing the instance_info type is the right way to go with this bug I don\u0027t understand why the suggested flow (add-type-to-oslo-db -\u003e change-ironic-using-oslo-db-definition) is better than change-ironic-using-local-definition -\u003e add-type-to-oslo-db -\u003e change-ironic-using-oslo-db-definition from a faster-solution pov.\n\nI totally agree that the right place for this type is oslo but there\u0027s a reason why Mistral chose to solve it locally (it was not accepted to oslo-db). I also agree that combining the two use-cases (for Ironic and Mistral) raises the chance for acceptance in oslo but it\u0027ll be a longer path to a simple solution.\n\nDon\u0027t get me wrong, I will try to push it to oslo based on two use-cases but I think that for the time being, until (and if) pushed to oslo, it\u0027s ok to add the type locally.","commit_id":"3f4060df4ee8e21c02bc95367a4caf333c2f2321"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"ba96b9d83b839dd92efe4c2c83b6764fbaab3e41","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sqlalchemy.dialects import mysql"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class JsonEncodedLongTextDict(db_types.JsonEncodedDict):"},{"line_number":27,"context_line":"    impl \u003d sa.Text().with_variant(mysql.LONGTEXT(), \u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_6e483988","line":26,"in_reply_to":"3aaa91ec_1761c5a8","updated":"2016-07-05 19:05:21.000000000","message":"Please clarify - given that this type is approved in oslo-db it\u0027s ok to use it for instance_info in the way that I\u0027ve suggested?\nIs it a matter of just placing the type in the correct project?\n(by the way, I\u0027m not sure that it\u0027ll be accepted to oslo-db from past experience of my colleagues)","commit_id":"3f4060df4ee8e21c02bc95367a4caf333c2f2321"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ecc91be16ae9f272d0fc80a55acf50b7408b6ff5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from sqlalchemy.dialects import mysql"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class JsonEncodedLongTextDict(db_types.JsonEncodedDict):"},{"line_number":27,"context_line":"    impl \u003d sa.Text().with_variant(mysql.LONGTEXT(), \u0027mysql\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1761c5a8","line":26,"in_reply_to":"3aaa91ec_2ff10f6b","updated":"2016-06-29 10:26:16.000000000","message":"Agree. And as workaround you may use \"configdrive_use_swift\" config option.\n\n@Vasyl \u003e In nova user-metadata is stored in separate key/value table [0]. I think it is good time to consider implement the same approach in ironic.\n\nIMO Ironic service should not use/store instance metadata obviously.","commit_id":"3f4060df4ee8e21c02bc95367a4caf333c2f2321"}],"ironic/tests/unit/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"31d931ad3d377385597a248bf7e649fd4f42f911","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            if _was_inserted(row[\u0027uuid\u0027]):"},{"line_number":415,"context_line":"                self.assertTrue(row[\u0027pxe_enabled\u0027])"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _check_e918ff30eb42(self, engine, data):"},{"line_number":418,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":419,"context_line":"        longtext \u003d \u0027a\u0027 * 1000000"},{"line_number":420,"context_line":"        uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_79ecd3c7","line":417,"updated":"2016-07-18 14:54:00.000000000","message":"Will this test the actual migration or just a new insert?\n\nI\u0027d like to make sure that an existing row still contains the same data post-migration.","commit_id":"6d4cad6f18b7cfbd8a835c3c361f044a8c67bdbb"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"2fce1551f9316462fa359e8784b03b32b13fabb4","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            if _was_inserted(row[\u0027uuid\u0027]):"},{"line_number":415,"context_line":"                self.assertTrue(row[\u0027pxe_enabled\u0027])"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _check_e918ff30eb42(self, engine, data):"},{"line_number":418,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":419,"context_line":"        longtext \u003d \u0027a\u0027 * 1000000"},{"line_number":420,"context_line":"        uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_946eaec7","line":417,"in_reply_to":"dada55a8_79ecd3c7","updated":"2016-07-18 15:02:30.000000000","message":"It checks row insertion.\nI manually checked the actual migration and the move from text to longtext doesn\u0027t change the content of the field.\nHow would you check that the content stays the same after altering the table in a test?","commit_id":"6d4cad6f18b7cfbd8a835c3c361f044a8c67bdbb"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"4d0a996b8efb2652b991540be162cad92aed3112","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            if _was_inserted(row[\u0027uuid\u0027]):"},{"line_number":415,"context_line":"                self.assertTrue(row[\u0027pxe_enabled\u0027])"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _check_e918ff30eb42(self, engine, data):"},{"line_number":418,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":419,"context_line":"        longtext \u003d \u0027a\u0027 * 1000000"},{"line_number":420,"context_line":"        uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_ed29e238","line":417,"in_reply_to":"dada55a8_946eaec7","updated":"2016-07-19 14:18:28.000000000","message":"I\u0027ve never done this with alembic before, but it looks like there\u0027s a test above (L271-301: _pre_upgrade_5674c57409b9 and _check_5674c57409b9) that does some inserts, runs the migration, and makes sure that certain rows changed as expected during the migration.\n\nI think you can do something similar with the _pre_upgrade prefix here.","commit_id":"6d4cad6f18b7cfbd8a835c3c361f044a8c67bdbb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"89a665cabbb111db7402feaf76d5acabbdef5b17","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            if _was_inserted(row[\u0027uuid\u0027]):"},{"line_number":415,"context_line":"                self.assertTrue(row[\u0027pxe_enabled\u0027])"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _check_e918ff30eb42(self, engine, data):"},{"line_number":418,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":419,"context_line":"        longtext \u003d \u0027a\u0027 * 1000000"},{"line_number":420,"context_line":"        uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_f110eaad","line":417,"in_reply_to":"dada55a8_ed29e238","updated":"2016-07-22 14:07:13.000000000","message":"Since we\u0027re using an abstraction layer, I think it would be good to have a before/after test to help ensure that we have no unexpected behavior of the database.","commit_id":"6d4cad6f18b7cfbd8a835c3c361f044a8c67bdbb"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"f2454b90f9be8c7c4b9cf6f58c982658984ff3dd","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            if _was_inserted(row[\u0027uuid\u0027]):"},{"line_number":415,"context_line":"                self.assertTrue(row[\u0027pxe_enabled\u0027])"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _check_e918ff30eb42(self, engine, data):"},{"line_number":418,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":419,"context_line":"        longtext \u003d \u0027a\u0027 * 1000000"},{"line_number":420,"context_line":"        uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_eb174f52","line":417,"in_reply_to":"dada55a8_f110eaad","updated":"2016-09-04 10:21:58.000000000","message":"Done","commit_id":"6d4cad6f18b7cfbd8a835c3c361f044a8c67bdbb"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"d0dead0e63e8c89c9f6cf256a049a8680fcb703f","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        mediumtext \u003d \u0027a\u0027 * (pow(2, 16) + 1)"},{"line_number":544,"context_line":"        uuid \u003d uuidutils.generate_uuid()"},{"line_number":545,"context_line":"        expected_to_fail_data \u003d {\u0027uuid\u0027: uuid, \u0027instance_info\u0027: mediumtext}"},{"line_number":546,"context_line":"        self.assertRaises(db_exc.DBError,"},{"line_number":547,"context_line":"                          nodes.insert().execute(expected_to_fail_data))"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        return valid_pre_upgrade_data"},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_cb036b0e","line":547,"range":{"start_line":546,"start_character":8,"end_line":547,"end_character":72},"updated":"2016-09-04 10:27:19.000000000","message":"So I hope I got this right.\nI couldn\u0027t find out how these tests are executed (what is the tox -e command - if any - that executes them).\n\nIf someone can point me to an explanation on how to execute the opportunistic tests I will check if the above insertion raises a DBError or something even more specific than that.\n\nThank you","commit_id":"9227d8f77dab0ad285c900ca00d6df321cd51d9b"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"804f33018b1716fefefae0a4b575a62068991c6e","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        mediumtext \u003d \u0027a\u0027 * (pow(2, 16) + 1)"},{"line_number":544,"context_line":"        uuid \u003d uuidutils.generate_uuid()"},{"line_number":545,"context_line":"        expected_to_fail_data \u003d {\u0027uuid\u0027: uuid, \u0027instance_info\u0027: mediumtext}"},{"line_number":546,"context_line":"        self.assertRaises(db_exc.DBError,"},{"line_number":547,"context_line":"                          nodes.insert().execute(expected_to_fail_data))"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        return valid_pre_upgrade_data"},{"line_number":550,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_66d1b6fb","line":547,"range":{"start_line":546,"start_character":8,"end_line":547,"end_character":72},"in_reply_to":"9a89bdaa_cb036b0e","updated":"2016-09-04 11:59:24.000000000","message":"Verified that it\u0027s DBError and not something more specific","commit_id":"9227d8f77dab0ad285c900ca00d6df321cd51d9b"}],"releasenotes/notes/bug-1596421-0cb8f59073f56240.yaml":[{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"d0dead0e63e8c89c9f6cf256a049a8680fcb703f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Extends the instance_info column in the nodes table for mysql DB"},{"line_number":4,"context_line":"    from 65KB to 4GB (type is changed from TEXT to LONGTEXT)"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - cloud-init script passed to the node can now be bigger than 65K"},{"line_number":7,"context_line":"    characters in case of mysql DB (up to mysql\u0027s LONGTEXT -"},{"line_number":8,"context_line":"    4G of characters). For more info, see"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a89bdaa_e6fea604","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":5},"updated":"2016-09-04 10:27:19.000000000","message":"I wasn\u0027t sure if I should use \"critical\" or \"fixes\" here. Looking at other release notes for bugs, some use fixes, some use critical.","commit_id":"9227d8f77dab0ad285c900ca00d6df321cd51d9b"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"2694ecd59ea48aedc962a7e765f68ef4d39b175c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Extends the instance_info column in the nodes table for mysql DB"},{"line_number":4,"context_line":"    from 65KB to 4GB (type is changed from TEXT to LONGTEXT)"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - cloud-init script passed to the node can now be bigger than 65K"},{"line_number":7,"context_line":"    characters in case of mysql DB (up to mysql\u0027s LONGTEXT -"},{"line_number":8,"context_line":"    4G of characters). For more info, see"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a89bdaa_b02be22f","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":5},"in_reply_to":"9a89bdaa_50e9b619","updated":"2016-09-05 08:31:31.000000000","message":"Agree, I looked at the output of the release notes gate and it looks appropriate","commit_id":"9227d8f77dab0ad285c900ca00d6df321cd51d9b"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"936c80d8c560328f7ee6829b9d0885696ea9275e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Extends the instance_info column in the nodes table for mysql DB"},{"line_number":4,"context_line":"    from 65KB to 4GB (type is changed from TEXT to LONGTEXT)"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - cloud-init script passed to the node can now be bigger than 65K"},{"line_number":7,"context_line":"    characters in case of mysql DB (up to mysql\u0027s LONGTEXT -"},{"line_number":8,"context_line":"    4G of characters). For more info, see"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a89bdaa_50e9b619","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":5},"in_reply_to":"9a89bdaa_e6fea604","updated":"2016-09-05 08:29:04.000000000","message":"IMO, fix is more appropriate.","commit_id":"9227d8f77dab0ad285c900ca00d6df321cd51d9b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"59706c307b9407214bdba40154c911ebf6ecd876","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Extends the instance_info column in the nodes table for mysql DB"},{"line_number":4,"context_line":"    from 65KB to 4GB (type is changed from TEXT to LONGTEXT)"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - cloud-init script passed to the node can now be bigger than 65K"},{"line_number":7,"context_line":"    characters in case of mysql DB (up to mysql\u0027s LONGTEXT -"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_0a3cdac6","line":4,"updated":"2016-09-07 14:08:20.000000000","message":"This should be 64 instead of 65 for use of KB... or KB could be changed to kB.  The entry should end with a period to align with the formatting of the other release notes.","commit_id":"a1238a99d1da5c4fdb4d2dec87d39aff16becc6b"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"cd601a054fe25ce685d4b9390c01ae40f33fc443","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Extends the instance_info column in the nodes table for mysql DB"},{"line_number":4,"context_line":"    from 65KB to 4GB (type is changed from TEXT to LONGTEXT)"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - cloud-init script passed to the node can now be bigger than 65K"},{"line_number":7,"context_line":"    characters in case of mysql DB (up to mysql\u0027s LONGTEXT -"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_09281f32","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":20},"updated":"2016-09-08 16:05:29.000000000","message":"This should be changed. The new field won\u0027t be 4GB. But it could grow up to that size. @Julia had investigated this before  and confirmed that the table won\u0027t grow if the user won\u0027t try to put so much data there. I\u0027ll try to provide documentation for this. In the mean time @David please update the release note accordingly.\n\nAlso, in the case of postgres there is only one TEXT type which by default can grow up to this size.","commit_id":"a1238a99d1da5c4fdb4d2dec87d39aff16becc6b"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"051b955b14f9b5096c1f0200a6bb75dee16cc7d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Extends the instance_info column in the nodes table for mysql DB"},{"line_number":4,"context_line":"    from 65KB to 4GB (type is changed from TEXT to LONGTEXT)"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - cloud-init script passed to the node can now be bigger than 65K"},{"line_number":7,"context_line":"    characters in case of mysql DB (up to mysql\u0027s LONGTEXT -"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_0e2ad32c","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":20},"in_reply_to":"9a89bdaa_09281f32","updated":"2016-09-08 22:09:59.000000000","message":"Agree with the comment for MYSQL and the notion of \"grow up to\" the size. Will update accordingly.\n\nAs for postgres, TEXT is defined as unlimited (grow up to any size). Please see https://www.postgresql.org/docs/9.1/static/datatype-character.html","commit_id":"a1238a99d1da5c4fdb4d2dec87d39aff16becc6b"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"051b955b14f9b5096c1f0200a6bb75dee16cc7d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Extends the instance_info column in the nodes table for mysql DB"},{"line_number":4,"context_line":"    from 65KB to 4GB (type is changed from TEXT to LONGTEXT)"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - cloud-init script passed to the node can now be bigger than 65K"},{"line_number":7,"context_line":"    characters in case of mysql DB (up to mysql\u0027s LONGTEXT -"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_2ea2379b","line":4,"in_reply_to":"9a89bdaa_0a3cdac6","updated":"2016-09-08 22:09:59.000000000","message":"Done","commit_id":"a1238a99d1da5c4fdb4d2dec87d39aff16becc6b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"59706c307b9407214bdba40154c911ebf6ecd876","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Extends the instance_info column in the nodes table for mysql DB"},{"line_number":4,"context_line":"    from 65KB to 4GB (type is changed from TEXT to LONGTEXT)"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - cloud-init script passed to the node can now be bigger than 65K"},{"line_number":7,"context_line":"    characters in case of mysql DB (up to mysql\u0027s LONGTEXT -"},{"line_number":8,"context_line":"    4G of characters). For more info, see"},{"line_number":9,"context_line":"    https://bugs.launchpad.net/ironic/+bug/1596421"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_ca791284","line":6,"range":{"start_line":6,"start_character":64,"end_line":6,"end_character":67},"updated":"2016-09-07 14:08:20.000000000","message":"Same basic issue as the upgrade entry in regards to the unit.  Truthfully it is the configuration drive size, since the formatting of what is actually stored in the field is the submitted configuration drive.\n\nNit: I think the sentence should start with \"The\".","commit_id":"a1238a99d1da5c4fdb4d2dec87d39aff16becc6b"},{"author":{"_account_id":15427,"name":"David Edery","email":"david.edery@gmail.com","username":"dedery"},"change_message_id":"051b955b14f9b5096c1f0200a6bb75dee16cc7d4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Extends the instance_info column in the nodes table for mysql DB"},{"line_number":4,"context_line":"    from 65KB to 4GB (type is changed from TEXT to LONGTEXT)"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - cloud-init script passed to the node can now be bigger than 65K"},{"line_number":7,"context_line":"    characters in case of mysql DB (up to mysql\u0027s LONGTEXT -"},{"line_number":8,"context_line":"    4G of characters). For more info, see"},{"line_number":9,"context_line":"    https://bugs.launchpad.net/ironic/+bug/1596421"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_8ea9837e","line":6,"range":{"start_line":6,"start_character":64,"end_line":6,"end_character":67},"in_reply_to":"9a89bdaa_ca791284","updated":"2016-09-08 22:09:59.000000000","message":"Done","commit_id":"a1238a99d1da5c4fdb4d2dec87d39aff16becc6b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5dd93db56ce88b7826b76f19033506ba2ebc628f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    from up to 64KiB to up to 4GiB (type is changed from TEXT to LONGTEXT)."},{"line_number":5,"context_line":"    This upgrade will not be executed on PostgreSQL as its TEXT is unlimited."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - The config drive passed to the node can now contain more than 64KiB"},{"line_number":8,"context_line":"    in case of MySQL/MariaDB. For more details see `bug 1596421"},{"line_number":9,"context_line":"    \u003chttps://bugs.launchpad.net/ironic/+bug/1596421\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa0c359_ade1c92c","line":7,"updated":"2018-02-19 18:44:22.000000000","message":"nit: I would say \"64KiB (compressed)\" maybe? I guess it doesn\u0027t matter, people that have seen the bug will get the point, people that have not won\u0027t care what the old max is. \n\nMaybe just if you re-spin the patch.","commit_id":"c68c1681b0afe75fedb509aa44a73473a929e78c"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ede83697a044e9a3d3ff0e90963cb6d943318e81","unresolved":false,"context_lines":[{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - The config drive passed to the node can now contain more than 64KiB"},{"line_number":8,"context_line":"    in case of MySQL/MariaDB. For more details see `bug 1596421"},{"line_number":9,"context_line":"    \u003chttps://bugs.launchpad.net/ironic/+bug/1596421\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa0c359_10ffa601","line":9,"updated":"2018-02-20 05:29:52.000000000","message":"This bug report looks a little confusing because the subject is \"[RFE] Stop storing configdrive in the database\". It would be better to update this bug report.","commit_id":"c68c1681b0afe75fedb509aa44a73473a929e78c"}]}