)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f882a50b0d181a87bb0157a7a805f330ba907d3b","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"# init_ironic() - Initialize databases, etc."},{"line_number":604,"context_line":"function init_ironic {"},{"line_number":605,"context_line":"    if is_service_enabled neutron \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]"},{"line_number":606,"context_line":"        # Save private network as cleaning network"},{"line_number":607,"context_line":"        local cleaning_network_uuid"},{"line_number":608,"context_line":"        cleaning_network_uuid\u003d$(openstack network show  \"$IRONIC_CLEAN_NET_NAME\" -c id -f value)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_8d3d96df","line":605,"updated":"2016-06-29 15:46:01.000000000","message":"Hm, IIUC that will break users that were setting IRONIC_CLEAN_NET_NAME in local.conf to be populated into ironic.conf.","commit_id":"c45b800c1da5894a2189799e91eb9c7aaf0b758b"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"a57ec7af1b27537bb4b900770acd9697e5ec5dac","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"# init_ironic() - Initialize databases, etc."},{"line_number":604,"context_line":"function init_ironic {"},{"line_number":605,"context_line":"    if is_service_enabled neutron \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]"},{"line_number":606,"context_line":"        # Save private network as cleaning network"},{"line_number":607,"context_line":"        local cleaning_network_uuid"},{"line_number":608,"context_line":"        cleaning_network_uuid\u003d$(openstack network show  \"$IRONIC_CLEAN_NET_NAME\" -c id -f value)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_9a7d956f","line":605,"in_reply_to":"3aaa91ec_37e02896","updated":"2016-06-30 13:35:43.000000000","message":"whoops! Done","commit_id":"c45b800c1da5894a2189799e91eb9c7aaf0b758b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f1e02dcbcfeef4a01e65ac03f78084b6c9c3645b","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"# init_ironic() - Initialize databases, etc."},{"line_number":604,"context_line":"function init_ironic {"},{"line_number":605,"context_line":"    if is_service_enabled neutron \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]"},{"line_number":606,"context_line":"        # Save private network as cleaning network"},{"line_number":607,"context_line":"        local cleaning_network_uuid"},{"line_number":608,"context_line":"        cleaning_network_uuid\u003d$(openstack network show  \"$IRONIC_CLEAN_NET_NAME\" -c id -f value)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_37e02896","line":605,"in_reply_to":"3aaa91ec_512d04a7","updated":"2016-06-29 17:08:33.000000000","message":"; then","commit_id":"c45b800c1da5894a2189799e91eb9c7aaf0b758b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8a46e9338a8afcff0614d7de0938c4530c6a2624","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"# init_ironic() - Initialize databases, etc."},{"line_number":604,"context_line":"function init_ironic {"},{"line_number":605,"context_line":"    if is_service_enabled neutron \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]"},{"line_number":606,"context_line":"        # Save private network as cleaning network"},{"line_number":607,"context_line":"        local cleaning_network_uuid"},{"line_number":608,"context_line":"        cleaning_network_uuid\u003d$(openstack network show  \"$IRONIC_CLEAN_NET_NAME\" -c id -f value)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_512d04a7","line":605,"in_reply_to":"3aaa91ec_6ecdc130","updated":"2016-06-29 16:34:21.000000000","message":"I was thinking about installing ironic standalone with devstack, alongside some installation without ironic. But looking at our devstack plugin, it seems that installing keystone is a requirement for ironic installation, and if we install another keystone, ironic won\u0027t be able to talk to old deployment\u0027s keystone without some config modifications, so this might be OK to do. I\u0027ll need to investigate this a bit more.","commit_id":"c45b800c1da5894a2189799e91eb9c7aaf0b758b"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"42f70a672b03c877cf57d84a52578abeabd9caa0","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"# init_ironic() - Initialize databases, etc."},{"line_number":604,"context_line":"function init_ironic {"},{"line_number":605,"context_line":"    if is_service_enabled neutron \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]"},{"line_number":606,"context_line":"        # Save private network as cleaning network"},{"line_number":607,"context_line":"        local cleaning_network_uuid"},{"line_number":608,"context_line":"        cleaning_network_uuid\u003d$(openstack network show  \"$IRONIC_CLEAN_NET_NAME\" -c id -f value)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_6ecdc130","line":605,"in_reply_to":"3aaa91ec_8d3d96df","updated":"2016-06-29 16:15:31.000000000","message":"Hey vlad thanks for the review! Could you elaborate as to why it would? NEUTRON_CREATE_INITIAL_NETWORKS has a default value of true so the behavior would only change if it\u0027s explicitly set to false.","commit_id":"c45b800c1da5894a2189799e91eb9c7aaf0b758b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f73784762d94e54bffa4cd5152bc32325e1bce6c","unresolved":false,"context_lines":[{"line_number":246,"context_line":"# PXE boot image"},{"line_number":247,"context_line":"IRONIC_PXE_BOOT_IMAGE\u003d${IRONIC_PXE_BOOT_IMAGE:-$(get_pxe_boot_file)}"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"IRONIC_AUTOMATED_CLEAN_ENABLED\u003d$(trueorfalse True IRONIC_AUTOMATED_CLEAN_ENABLED)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"# Functions"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1aa78d24_a4c70611","line":249,"updated":"2016-07-05 09:02:21.000000000","message":"here","commit_id":"e038a5cefce1e3a47b689fb391e06ea1b582767f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"4dc2ce94b733560604723120dc1e8feec47035de","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"# init_ironic() - Initialize databases, etc."},{"line_number":604,"context_line":"function init_ironic {"},{"line_number":605,"context_line":"    if is_service_enabled neutron \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]; then"},{"line_number":606,"context_line":"        # Save private network as cleaning network"},{"line_number":607,"context_line":"        local cleaning_network_uuid"},{"line_number":608,"context_line":"        cleaning_network_uuid\u003d$(openstack network show  \"$IRONIC_CLEAN_NET_NAME\" -c id -f value)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1aa78d24_e030e303","line":605,"range":{"start_line":605,"start_character":42,"end_line":605,"end_character":73},"updated":"2016-07-05 05:42:06.000000000","message":"Because tempest/scenario/test_server_basic_ops.py fails in http://logs.openstack.org/67/335567/2/check/gate-grenade-dsvm-ironic/e2d070e/console.html.gz , it seems that NEUTRON_CREATE_INITIAL_NETWORK need to be set True as default.\n\n Captured traceback:\n ~~~~~~~~~~~~~~~~~~~\n     Traceback (most recent call last):\n       File \"tempest/test.py\", line 106, in wrapper\n         return f(self, *func_args, **func_kwargs)\n       File \"tempest/scenario/test_server_basic_ops.py\", line 115, in test_server_basic_ops\n         wait_until\u003d\u0027ACTIVE\u0027)\n       File \"tempest/scenario/manager.py\", line 237, in create_server\n         image_id\u003dimage_id, **kwargs)\n       File \"tempest/common/compute.py\", line 157, in create_test_server\n         % server[\u0027id\u0027])\n       File \"/opt/stack/new/tempest/.tox/tempest/local/lib/python2.7/site-packages/oslo_utils/excutils.py\", line 221, in __exit__\n         self.force_reraise()\n       File \"/opt/stack/new/tempest/.tox/tempest/local/lib/python2.7/site-packages/oslo_utils/excutils.py\", line 197, in force_reraise\n         six.reraise(self.type_, self.value, self.tb)\n       File \"tempest/common/compute.py\", line 139, in create_test_server\n         clients.servers_client, server[\u0027id\u0027], wait_until)\n       File \"tempest/common/waiters.py\", line 77, in wait_for_server_status\n         server_id\u003dserver_id)\n     tempest.exceptions.BuildErrorException: Server d5bd8937-8c30-41e8-8d0a-477b3b6cb589 failed to build and is in ERROR status\n     Details: {u\u0027code\u0027: 500, u\u0027message\u0027: u\u0027Build of instance d5bd8937-8c30-41e8-8d0a-477b3b6cb589 aborted: Failed to allocate the network(s), not rescheduling.\u0027, u\u0027created\u0027: u\u00272016-06-30T15:06:21Z\u0027}","commit_id":"e038a5cefce1e3a47b689fb391e06ea1b582767f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f73784762d94e54bffa4cd5152bc32325e1bce6c","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"# init_ironic() - Initialize databases, etc."},{"line_number":604,"context_line":"function init_ironic {"},{"line_number":605,"context_line":"    if is_service_enabled neutron \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]; then"},{"line_number":606,"context_line":"        # Save private network as cleaning network"},{"line_number":607,"context_line":"        local cleaning_network_uuid"},{"line_number":608,"context_line":"        cleaning_network_uuid\u003d$(openstack network show  \"$IRONIC_CLEAN_NET_NAME\" -c id -f value)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1aa78d24_a49546e5","line":605,"range":{"start_line":605,"start_character":42,"end_line":605,"end_character":73},"in_reply_to":"1aa78d24_d135b7da","updated":"2016-07-05 09:02:21.000000000","message":"+1 for @Vasyl suggestion here. FWIW devstack does have a IRONIC_AUTOMATED_CLEAN_ENABLED variable, maybe we could use that ?","commit_id":"e038a5cefce1e3a47b689fb391e06ea1b582767f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"81ecb7db3508636f907ea87f555ab1874bc466e2","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"# init_ironic() - Initialize databases, etc."},{"line_number":604,"context_line":"function init_ironic {"},{"line_number":605,"context_line":"    if is_service_enabled neutron \u0026\u0026 [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]]; then"},{"line_number":606,"context_line":"        # Save private network as cleaning network"},{"line_number":607,"context_line":"        local cleaning_network_uuid"},{"line_number":608,"context_line":"        cleaning_network_uuid\u003d$(openstack network show  \"$IRONIC_CLEAN_NET_NAME\" -c id -f value)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1aa78d24_d135b7da","line":605,"range":{"start_line":605,"start_character":42,"end_line":605,"end_character":73},"in_reply_to":"1aa78d24_e030e303","updated":"2016-07-05 06:47:38.000000000","message":"I would suggest to have a new variable IRONIC_CLEANING_ENABLED which specifies if cleaning is enabled. Cleaning networks should be configured only when IRONIC_CLEANING_ENABLED\u003dTrue.\n\nEven if NEUTRON_CREATE_INITIAL_NETWORKS\u003dFalse, user may create network by other devstack plugins, such as neutron ML2 plugin, and override IRONIC_CLEAN_NET_NAME. I wouldn\u0027t rely on NEUTRON_CREATE_INITIAL_NETWORKS variable.","commit_id":"e038a5cefce1e3a47b689fb391e06ea1b582767f"}]}
