)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5711d4b386714302651ab32cbf1c1e28c8927414","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ramdisk. The logs can be collect for every deployment, upon a failure or"},{"line_number":11,"context_line":"never. By default, logs are collected upon a failure."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"After collection, logs can be storaged either in the local fileystem"},{"line_number":14,"context_line":"(default) or in Swift."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"If an error occurs when the logs are being collected, storaged or if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dada55a8_71b0508c","line":13,"range":{"start_line":13,"start_character":59,"end_line":13,"end_character":68},"updated":"2016-07-24 05:07:34.000000000","message":"s/fileystem/filesystem/","commit_id":"aa2c9f3acd13b5a47891884a8b1ff4a3641217b8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e6d5e6e3a7d13ec4a04401a68a4edf9a8db10dd7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"subsequent patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partil-Bug: #1587143"},{"line_number":24,"context_line":"Depends-On: Ie507e2e5c58cffa255bbfb2fa5ffb95cb98ed8c4"},{"line_number":25,"context_line":"Change-Id: I6da1110daa94ea25670f71f9862e51cc9bbc6f93"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bacf61ea_5f95fd30","line":24,"updated":"2016-08-04 19:43:57.000000000","message":"nits: s/Partil/Partial/\n\nAlso the patch you depend on is merged, you can remove this if you push a new patchset.","commit_id":"1ff6dc499950c1affcafaf0e0299e415a781d03b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f34d92bfd0c335c276ac40a774b7c6e308430068","unresolved":false,"context_lines":[{"line_number":21,"context_line":"subsequent patch."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partil-Bug: #1587143"},{"line_number":24,"context_line":"Depends-On: Ie507e2e5c58cffa255bbfb2fa5ffb95cb98ed8c4"},{"line_number":25,"context_line":"Change-Id: I6da1110daa94ea25670f71f9862e51cc9bbc6f93"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bacf61ea_696bd7b9","line":24,"in_reply_to":"bacf61ea_5f95fd30","updated":"2016-08-05 09:21:45.000000000","message":"Done","commit_id":"1ff6dc499950c1affcafaf0e0299e415a781d03b"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"7f36f125e3dab0cf57ff5fb63d28e5e74fd8259c","unresolved":false,"context_lines":[{"line_number":415,"context_line":"# Swift. If None, the logs will be kept forever or until"},{"line_number":416,"context_line":"# manually deleted. Used when the deploy_logs_storage_backend"},{"line_number":417,"context_line":"# is configured to \"swift\". (integer value)"},{"line_number":418,"context_line":"#deploy_logs_swift_days_to_expire \u003d 30"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"# API version to use for communicating with the ramdisk agent."},{"line_number":421,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1aa78d24_5a89a425","line":418,"updated":"2016-07-11 21:05:34.000000000","message":"It would be nice if there was a similar system to have local logs purged after a certain number of days.","commit_id":"a49d40eca5a08cab4b579e131d1645a2aa7aa098"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9be7b6b76a6cbf8a530e3d21a64c77fcba71a082","unresolved":false,"context_lines":[{"line_number":415,"context_line":"# Swift. If None, the logs will be kept forever or until"},{"line_number":416,"context_line":"# manually deleted. Used when the deploy_logs_storage_backend"},{"line_number":417,"context_line":"# is configured to \"swift\". (integer value)"},{"line_number":418,"context_line":"#deploy_logs_swift_days_to_expire \u003d 30"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"# API version to use for communicating with the ramdisk agent."},{"line_number":421,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1aa78d24_f37984fd","line":418,"in_reply_to":"1aa78d24_5a89a425","updated":"2016-07-12 09:46:06.000000000","message":"Yeah it would, we can probably enhance it later to have Ironic to do it. Or simply document how one could configure a cron job to do it too.","commit_id":"a49d40eca5a08cab4b579e131d1645a2aa7aa098"}],"ironic/conf/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    cfg.StrOpt(\u0027deploy_logs_collect\u0027,"},{"line_number":64,"context_line":"               choices\u003d[\u0027always\u0027, \u0027on_failure\u0027, \u0027never\u0027],"},{"line_number":65,"context_line":"               default\u003d\u0027on_failure\u0027,"},{"line_number":66,"context_line":"               help\u003d_(\u0027Whether Ironic should collect the deployment logs \u0027"},{"line_number":67,"context_line":"                      \u0027or not.\u0027)),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027deploy_logs_storage_backend\u0027,"},{"line_number":69,"context_line":"               choices\u003d[\u0027local\u0027, \u0027swift\u0027],"},{"line_number":70,"context_line":"               default\u003d\u0027local\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_a15cbb19","line":67,"range":{"start_line":66,"start_character":23,"end_line":67,"end_character":30},"updated":"2016-08-05 12:45:14.000000000","message":"I think this should be expanded to cover all options:\n \n Whether Ironic should collect the deployment logs on deployment failure (on_failure), always or never.","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    cfg.StrOpt(\u0027deploy_logs_collect\u0027,"},{"line_number":64,"context_line":"               choices\u003d[\u0027always\u0027, \u0027on_failure\u0027, \u0027never\u0027],"},{"line_number":65,"context_line":"               default\u003d\u0027on_failure\u0027,"},{"line_number":66,"context_line":"               help\u003d_(\u0027Whether Ironic should collect the deployment logs \u0027"},{"line_number":67,"context_line":"                      \u0027or not.\u0027)),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027deploy_logs_storage_backend\u0027,"},{"line_number":69,"context_line":"               choices\u003d[\u0027local\u0027, \u0027swift\u0027],"},{"line_number":70,"context_line":"               default\u003d\u0027local\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_6123e3bd","line":67,"range":{"start_line":66,"start_character":23,"end_line":67,"end_character":30},"in_reply_to":"bacf61ea_a15cbb19","updated":"2016-08-05 13:34:35.000000000","message":"Done","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"7f36f125e3dab0cf57ff5fb63d28e5e74fd8259c","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        node \u003d task.node"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        if CONF.agent.deploy_logs_collect \u003d\u003d \u0027always\u0027:"},{"line_number":783,"context_line":"            driver_utils.collect_ramdisk_logs(node)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        # Whether ironic should power off the node via out-of-band or"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_1a743c34","line":782,"updated":"2016-07-11 21:05:34.000000000","message":"Are there cases where we would want to collect logs if the deployment doesn\u0027t get to this point? I haven\u0027t followed all the deploy code exactly, just curious.","commit_id":"a49d40eca5a08cab4b579e131d1645a2aa7aa098"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9be7b6b76a6cbf8a530e3d21a64c77fcba71a082","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        node \u003d task.node"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        if CONF.agent.deploy_logs_collect \u003d\u003d \u0027always\u0027:"},{"line_number":783,"context_line":"            driver_utils.collect_ramdisk_logs(node)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        # Whether ironic should power off the node via out-of-band or"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_6ecbeb53","line":782,"in_reply_to":"1aa78d24_1a743c34","updated":"2016-07-12 09:46:06.000000000","message":"This will only capture the logs after the deployment has been completed but before the final reboot.\n\nNot sure if we need to collect it on different stages if the deployment is succeeding, on the other handy, if it\u0027s configured with \"always\" and the deployment fails at any stage we will collect the logs.","commit_id":"a49d40eca5a08cab4b579e131d1645a2aa7aa098"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"7f36f125e3dab0cf57ff5fb63d28e5e74fd8259c","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    \"\"\""},{"line_number":490,"context_line":"    node \u003d task.node"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    if CONF.agent.deploy_logs_collect in (\u0027on_failure\u0027, \u0027always\u0027):"},{"line_number":493,"context_line":"        driver_utils.collect_ramdisk_logs(node)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_1aab9c76","line":492,"updated":"2016-07-11 21:05:34.000000000","message":"Is there a risk we collect logs twice in the \"always\" case?","commit_id":"a49d40eca5a08cab4b579e131d1645a2aa7aa098"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9be7b6b76a6cbf8a530e3d21a64c77fcba71a082","unresolved":false,"context_lines":[{"line_number":489,"context_line":"    \"\"\""},{"line_number":490,"context_line":"    node \u003d task.node"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    if CONF.agent.deploy_logs_collect in (\u0027on_failure\u0027, \u0027always\u0027):"},{"line_number":493,"context_line":"        driver_utils.collect_ramdisk_logs(node)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_ce65bf45","line":492,"in_reply_to":"1aa78d24_1aab9c76","updated":"2016-07-12 09:46:06.000000000","message":"I think it might be possible if the deployment succeeded but it failed to reboot the node. Kinda rare since we\u0027ve already rebooted to start the deployment but there\u0027s definitely a window where the logs may be captured twice. But that should be OK because operators can then look at the reasons why the node failed to reboot at the end of a successful deployment.","commit_id":"a49d40eca5a08cab4b579e131d1645a2aa7aa098"}],"ironic/drivers/utils.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"7f36f125e3dab0cf57ff5fb63d28e5e74fd8259c","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    try:"},{"line_number":345,"context_line":"        store_ramdisk_logs(node, result[\u0027command_result\u0027][\u0027system_logs\u0027])"},{"line_number":346,"context_line":"    except Exception as e:"},{"line_number":347,"context_line":"        LOG.exception(_LE(\u0027Failed to store logs from the node %(node)s \u0027"},{"line_number":348,"context_line":"                          \u0027deployment. Error: %(error)s\u0027),"},{"line_number":349,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_dacbd451","line":347,"updated":"2016-07-11 21:05:34.000000000","message":"Is there a more specific exception that can be caught?","commit_id":"a49d40eca5a08cab4b579e131d1645a2aa7aa098"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9be7b6b76a6cbf8a530e3d21a64c77fcba71a082","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    try:"},{"line_number":345,"context_line":"        store_ramdisk_logs(node, result[\u0027command_result\u0027][\u0027system_logs\u0027])"},{"line_number":346,"context_line":"    except Exception as e:"},{"line_number":347,"context_line":"        LOG.exception(_LE(\u0027Failed to store logs from the node %(node)s \u0027"},{"line_number":348,"context_line":"                          \u0027deployment. Error: %(error)s\u0027),"},{"line_number":349,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_b3909cee","line":347,"in_reply_to":"1aa78d24_dacbd451","updated":"2016-07-12 09:46:06.000000000","message":"I was playing the safe card here because there\u0027s a couple of exceptions that could be raised such as Swift and filesystem related ones... I will try to be more specific here.","commit_id":"a49d40eca5a08cab4b579e131d1645a2aa7aa098"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9954812bddbd4df14f03556e0b6d91e9d747ec27","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    \"\"\""},{"line_number":297,"context_line":"    logs_file_name \u003d get_ramdisk_logs_file_name(node)"},{"line_number":298,"context_line":"    data \u003d six.BytesIO(base64.b64decode(logs))"},{"line_number":299,"context_line":"    gunzipped \u003d gzip.GzipFile(\u0027deploy_logs\u0027, \u0027rb\u0027, 9, data)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    if CONF.agent.deploy_logs_storage_backend \u003d\u003d \u0027local\u0027:"},{"line_number":302,"context_line":"        if not os.path.exists(CONF.agent.deploy_logs_local_path):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_fd9d4667","line":299,"updated":"2016-07-14 13:38:43.000000000","message":"I\u0027m not sure why you decided to unzip the tarball. It\u0027s not on the spec, and I\u0027m not sure how valuable it is (inspector does not do it, for example). We could save some space by not doing it.","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bc72b9bfe132e7f06f743d9350e074818420db8","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    \"\"\""},{"line_number":297,"context_line":"    logs_file_name \u003d get_ramdisk_logs_file_name(node)"},{"line_number":298,"context_line":"    data \u003d six.BytesIO(base64.b64decode(logs))"},{"line_number":299,"context_line":"    gunzipped \u003d gzip.GzipFile(\u0027deploy_logs\u0027, \u0027rb\u0027, 9, data)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    if CONF.agent.deploy_logs_storage_backend \u003d\u003d \u0027local\u0027:"},{"line_number":302,"context_line":"        if not os.path.exists(CONF.agent.deploy_logs_local_path):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_add3005f","line":299,"in_reply_to":"1aa78d24_fd9d4667","updated":"2016-07-21 09:31:41.000000000","message":"Yeah, indeed it would be better to just keep it as is.","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9954812bddbd4df14f03556e0b6d91e9d747ec27","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    elif CONF.agent.deploy_logs_storage_backend \u003d\u003d \u0027swift\u0027:"},{"line_number":312,"context_line":"        with tempfile.NamedTemporaryFile(dir\u003dCONF.tempdir) as f:"},{"line_number":313,"context_line":"            f.write(gunzipped.read())"},{"line_number":314,"context_line":"            f.flush()"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            # convert days to seconds"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_dd9a0a6e","line":313,"updated":"2016-07-14 13:38:43.000000000","message":"you don\u0027t explicitly close gunzipped in this branch (might be a good reason to use \u0027with\u0027 statement with it)","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bc72b9bfe132e7f06f743d9350e074818420db8","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    elif CONF.agent.deploy_logs_storage_backend \u003d\u003d \u0027swift\u0027:"},{"line_number":312,"context_line":"        with tempfile.NamedTemporaryFile(dir\u003dCONF.tempdir) as f:"},{"line_number":313,"context_line":"            f.write(gunzipped.read())"},{"line_number":314,"context_line":"            f.flush()"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            # convert days to seconds"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_0dc32c8a","line":313,"in_reply_to":"1aa78d24_dd9a0a6e","updated":"2016-07-21 09:31:41.000000000","message":"++","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9954812bddbd4df14f03556e0b6d91e9d747ec27","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            swift_api \u003d swift.SwiftAPI()"},{"line_number":320,"context_line":"            swift_api.create_object("},{"line_number":321,"context_line":"                CONF.agent.deploy_logs_swift_container, logs_file_name,"},{"line_number":322,"context_line":"                f.name, object_headers\u003dobject_headers)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def collect_ramdisk_logs(node):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_3d86ae16","line":322,"updated":"2016-07-14 13:38:43.000000000","message":"ditto, I don\u0027t see how storing .tar file is better than storing .tar.gz..","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bc72b9bfe132e7f06f743d9350e074818420db8","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            swift_api \u003d swift.SwiftAPI()"},{"line_number":320,"context_line":"            swift_api.create_object("},{"line_number":321,"context_line":"                CONF.agent.deploy_logs_swift_container, logs_file_name,"},{"line_number":322,"context_line":"                f.name, object_headers\u003dobject_headers)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"def collect_ramdisk_logs(node):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_2d4f1038","line":322,"in_reply_to":"1aa78d24_3d86ae16","updated":"2016-07-21 09:31:41.000000000","message":"++","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9954812bddbd4df14f03556e0b6d91e9d747ec27","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        LOG.exception(_LE(\u0027Failed to store the logs from the node %(node)s \u0027"},{"line_number":348,"context_line":"                          \u0027deployment in Swift. Error: %(error)s\u0027),"},{"line_number":349,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":350,"context_line":"    except (OSError, IOError) as e:"},{"line_number":351,"context_line":"        LOG.exception(_LE(\u0027Failed to store the logs from the node %(node)s \u0027"},{"line_number":352,"context_line":"                          \u0027deployment due a file-system related error. \u0027"},{"line_number":353,"context_line":"                          \u0027Error: %(error)s\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_1d8bf21f","line":350,"updated":"2016-07-14 13:38:43.000000000","message":"nit: OSError + IOError \u003d EnvironmentError","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    \"\"\""},{"line_number":332,"context_line":"    client \u003d agent_client.AgentClient()"},{"line_number":333,"context_line":"    result \u003d client.collect_system_logs(node)"},{"line_number":334,"context_line":"    error \u003d result.get(\u0027faultstring\u0027)"},{"line_number":335,"context_line":"    if error is not None:"},{"line_number":336,"context_line":"        LOG.error(_LE(\u0027Failed to collect logs from the node %(node)s \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_a1be7bab","line":333,"range":{"start_line":333,"start_character":20,"end_line":333,"end_character":39},"updated":"2016-08-05 12:45:14.000000000","message":"Can it actually raise something? I think at least network exceptions, right? In this case I\u0027d prefer we catch them, otherwise we\u0027ll hide the actual deployment failure.","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    \"\"\""},{"line_number":332,"context_line":"    client \u003d agent_client.AgentClient()"},{"line_number":333,"context_line":"    result \u003d client.collect_system_logs(node)"},{"line_number":334,"context_line":"    error \u003d result.get(\u0027faultstring\u0027)"},{"line_number":335,"context_line":"    if error is not None:"},{"line_number":336,"context_line":"        LOG.error(_LE(\u0027Failed to collect logs from the node %(node)s \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_610ac327","line":333,"range":{"start_line":333,"start_character":20,"end_line":333,"end_character":39},"in_reply_to":"bacf61ea_a1be7bab","updated":"2016-08-05 13:34:35.000000000","message":"Done","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    try:"},{"line_number":342,"context_line":"        store_ramdisk_logs(node, result[\u0027command_result\u0027][\u0027system_logs\u0027])"},{"line_number":343,"context_line":"    except exception.SwiftOperationError as e:"},{"line_number":344,"context_line":"        LOG.exception(_LE(\u0027Failed to store the logs from the node %(node)s \u0027"},{"line_number":345,"context_line":"                          \u0027deployment in Swift. Error: %(error)s\u0027),"},{"line_number":346,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":347,"context_line":"    except (OSError, IOError) as e:"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_81ded76a","line":344,"range":{"start_line":344,"start_character":12,"end_line":344,"end_character":21},"updated":"2016-08-05 12:45:14.000000000","message":"I don\u0027t think the traceback will be useful here, I\u0027d replace it with \"error\"","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    try:"},{"line_number":342,"context_line":"        store_ramdisk_logs(node, result[\u0027command_result\u0027][\u0027system_logs\u0027])"},{"line_number":343,"context_line":"    except exception.SwiftOperationError as e:"},{"line_number":344,"context_line":"        LOG.exception(_LE(\u0027Failed to store the logs from the node %(node)s \u0027"},{"line_number":345,"context_line":"                          \u0027deployment in Swift. Error: %(error)s\u0027),"},{"line_number":346,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":347,"context_line":"    except (OSError, IOError) as e:"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_21144b4b","line":344,"range":{"start_line":344,"start_character":12,"end_line":344,"end_character":21},"in_reply_to":"bacf61ea_81ded76a","updated":"2016-08-05 13:34:35.000000000","message":"Done","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        LOG.exception(_LE(\u0027Failed to store the logs from the node %(node)s \u0027"},{"line_number":345,"context_line":"                          \u0027deployment in Swift. Error: %(error)s\u0027),"},{"line_number":346,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":347,"context_line":"    except (OSError, IOError) as e:"},{"line_number":348,"context_line":"        LOG.exception(_LE(\u0027Failed to store the logs from the node %(node)s \u0027"},{"line_number":349,"context_line":"                          \u0027deployment due a file-system related error. \u0027"},{"line_number":350,"context_line":"                          \u0027Error: %(error)s\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_21cc4bba","line":347,"range":{"start_line":347,"start_character":11,"end_line":347,"end_character":29},"updated":"2016-08-05 12:45:14.000000000","message":"this is equivalent to EnvironmentError","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        LOG.exception(_LE(\u0027Failed to store the logs from the node %(node)s \u0027"},{"line_number":345,"context_line":"                          \u0027deployment in Swift. Error: %(error)s\u0027),"},{"line_number":346,"context_line":"                      {\u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":347,"context_line":"    except (OSError, IOError) as e:"},{"line_number":348,"context_line":"        LOG.exception(_LE(\u0027Failed to store the logs from the node %(node)s \u0027"},{"line_number":349,"context_line":"                          \u0027deployment due a file-system related error. \u0027"},{"line_number":350,"context_line":"                          \u0027Error: %(error)s\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_810d3740","line":347,"range":{"start_line":347,"start_character":11,"end_line":347,"end_character":29},"in_reply_to":"bacf61ea_21cc4bba","updated":"2016-08-05 13:34:35.000000000","message":"Done","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"}],"ironic/tests/unit/drivers/modules/oneview/test_vendor.py":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"2caf751a51cd8878580007ecdb27012375b79a7b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                mock.call(task, states.POWER_OFF)])"},{"line_number":182,"context_line":"            self.assertEqual(states.DEPLOYFAIL, task.node.provision_state)"},{"line_number":183,"context_line":"            self.assertEqual(states.ACTIVE, task.node.target_provision_state)"},{"line_number":184,"context_line":"            collect_ramdisk_logs_mock(task.node)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"},{"line_number":187,"context_line":"    @mock.patch.object(power.OneViewPower, \u0027get_power_state\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_93281b35","line":184,"updated":"2016-08-04 15:59:48.000000000","message":"This calls the mock. I guess it should have been something like .assert_called_with(task.node) ?","commit_id":"1ab465a31786313995d40250b8d7e208548f331c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"befe68e35afa0df4cfa19f8815e26f27a9229753","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                mock.call(task, states.POWER_OFF)])"},{"line_number":182,"context_line":"            self.assertEqual(states.DEPLOYFAIL, task.node.provision_state)"},{"line_number":183,"context_line":"            self.assertEqual(states.ACTIVE, task.node.target_provision_state)"},{"line_number":184,"context_line":"            collect_ramdisk_logs_mock(task.node)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"},{"line_number":187,"context_line":"    @mock.patch.object(power.OneViewPower, \u0027get_power_state\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_f36eb72d","line":184,"in_reply_to":"bacf61ea_93281b35","updated":"2016-08-04 16:01:23.000000000","message":"ops, totally... my bad","commit_id":"1ab465a31786313995d40250b8d7e208548f331c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            self.assertEqual(states.ACTIVE, task.node.provision_state)"},{"line_number":154,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":157,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":158,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"},{"line_number":159,"context_line":"    @mock.patch.object(power.OneViewPower, \u0027get_power_state\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_a1b83b12","line":156,"updated":"2016-08-05 12:45:14.000000000","message":"autospec\u003dTrue","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            self.assertEqual(states.ACTIVE, task.node.provision_state)"},{"line_number":154,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":157,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":158,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"},{"line_number":159,"context_line":"    @mock.patch.object(power.OneViewPower, \u0027get_power_state\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_9c5c7c1a","line":156,"in_reply_to":"bacf61ea_a1b83b12","updated":"2016-08-05 13:34:35.000000000","message":"Done","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"}],"ironic/tests/unit/drivers/modules/test_agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":901,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":902,"context_line":"            self.assertFalse(uuid_mock.called)"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":905,"context_line":"    @mock.patch.object(agent.AgentVendorInterface, \u0027_get_uuid_from_result\u0027,"},{"line_number":906,"context_line":"                       autospec\u003dTrue)"},{"line_number":907,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_413e9f8b","line":904,"updated":"2016-08-05 12:45:14.000000000","message":"autospec\u003dTrue","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":901,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":902,"context_line":"            self.assertFalse(uuid_mock.called)"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":905,"context_line":"    @mock.patch.object(agent.AgentVendorInterface, \u0027_get_uuid_from_result\u0027,"},{"line_number":906,"context_line":"                       autospec\u003dTrue)"},{"line_number":907,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_1ce9acb7","line":904,"in_reply_to":"bacf61ea_413e9f8b","updated":"2016-08-05 13:34:35.000000000","message":"Done","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"}],"ironic/tests/unit/drivers/modules/test_agent_base_vendor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        mock_touch.assert_called_once_with(mock.ANY)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":587,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":588,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"},{"line_number":589,"context_line":"    @mock.patch.object(fake.FakePower, \u0027get_power_state\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_814c1743","line":586,"updated":"2016-08-05 12:45:14.000000000","message":"autospec\u003dTrue (here and below)","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        mock_touch.assert_called_once_with(mock.ANY)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":587,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, lambda seconds: None)"},{"line_number":588,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, autospec\u003dTrue)"},{"line_number":589,"context_line":"    @mock.patch.object(fake.FakePower, \u0027get_power_state\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_bcd8601f","line":586,"in_reply_to":"bacf61ea_814c1743","updated":"2016-08-05 13:34:35.000000000","message":"Done","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"2caf751a51cd8878580007ecdb27012375b79a7b","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"        self.assertEqual(4, mock_collect.call_count)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":1319,"context_line":"    def test_set_failed_state_collect_deploy_logs(self, mock_collect):"},{"line_number":1320,"context_line":"        for opt in (\u0027always\u0027, \u0027on_failure\u0027):"},{"line_number":1321,"context_line":"            cfg.CONF.set_override(\u0027deploy_logs_collect\u0027, opt, \u0027agent\u0027)"},{"line_number":1322,"context_line":"            self._test_set_failed_state()"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_7305a778","line":1319,"updated":"2016-08-04 15:59:48.000000000","message":"Maybe a test for the \"never\" case? asserting it wasn\u0027t called?","commit_id":"1ab465a31786313995d40250b8d7e208548f331c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"befe68e35afa0df4cfa19f8815e26f27a9229753","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"        self.assertEqual(4, mock_collect.call_count)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":1319,"context_line":"    def test_set_failed_state_collect_deploy_logs(self, mock_collect):"},{"line_number":1320,"context_line":"        for opt in (\u0027always\u0027, \u0027on_failure\u0027):"},{"line_number":1321,"context_line":"            cfg.CONF.set_override(\u0027deploy_logs_collect\u0027, opt, \u0027agent\u0027)"},{"line_number":1322,"context_line":"            self._test_set_failed_state()"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_73612739","line":1319,"in_reply_to":"bacf61ea_7305a778","updated":"2016-08-04 16:01:23.000000000","message":"++","commit_id":"1ab465a31786313995d40250b8d7e208548f331c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"            else:"},{"line_number":1277,"context_line":"                self.assertFalse(mock_log.called)"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":1280,"context_line":"    def test_set_failed_state(self, mock_collect):"},{"line_number":1281,"context_line":"        exc_state \u003d exception.InvalidState(\u0027invalid state\u0027)"},{"line_number":1282,"context_line":"        exc_param \u003d exception.InvalidParameterValue(\u0027invalid parameter\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_4155ffbf","line":1279,"updated":"2016-08-05 12:45:14.000000000","message":"autospec\u003dTrue (here and below)","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"            else:"},{"line_number":1277,"context_line":"                self.assertFalse(mock_log.called)"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"    @mock.patch.object(driver_utils, \u0027collect_ramdisk_logs\u0027)"},{"line_number":1280,"context_line":"    def test_set_failed_state(self, mock_collect):"},{"line_number":1281,"context_line":"        exc_state \u003d exception.InvalidState(\u0027invalid state\u0027)"},{"line_number":1282,"context_line":"        exc_param \u003d exception.InvalidParameterValue(\u0027invalid parameter\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_5c1e840c","line":1279,"in_reply_to":"bacf61ea_4155ffbf","updated":"2016-08-05 13:34:35.000000000","message":"Done","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"}],"ironic/tests/unit/drivers/test_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9954812bddbd4df14f03556e0b6d91e9d747ec27","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        self.assertEqual(expected_name, name)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @mock.patch.object(driver_utils, \u0027store_ramdisk_logs\u0027)"},{"line_number":275,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027collect_system_logs\u0027)"},{"line_number":276,"context_line":"    def test_collect_ramdisk_logs(self, mock_collect, mock_store):"},{"line_number":277,"context_line":"        logs \u003d \u0027Gary the Snail\u0027"},{"line_number":278,"context_line":"        mock_collect.return_value \u003d {\u0027command_result\u0027: {\u0027system_logs\u0027: logs}}"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_5d857a05","line":275,"updated":"2016-07-14 13:38:43.000000000","message":"please use autospec\u003dTrue here and below","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bc72b9bfe132e7f06f743d9350e074818420db8","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        self.assertEqual(expected_name, name)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    @mock.patch.object(driver_utils, \u0027store_ramdisk_logs\u0027)"},{"line_number":275,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027collect_system_logs\u0027)"},{"line_number":276,"context_line":"    def test_collect_ramdisk_logs(self, mock_collect, mock_store):"},{"line_number":277,"context_line":"        logs \u003d \u0027Gary the Snail\u0027"},{"line_number":278,"context_line":"        mock_collect.return_value \u003d {\u0027command_result\u0027: {\u0027system_logs\u0027: logs}}"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_cd5ab4f1","line":275,"in_reply_to":"1aa78d24_5d857a05","updated":"2016-07-21 09:31:41.000000000","message":"Done","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        mock_utcnow.return_value \u003d datetime.datetime(2000, 1, 1, 0, 0)"},{"line_number":259,"context_line":"        name \u003d driver_utils.get_ramdisk_logs_file_name(self.node)"},{"line_number":260,"context_line":"        expected_name \u003d (\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123_\u0027"},{"line_number":261,"context_line":"                         \u00272000-01-01-00:00:00.tar.gz\u0027)"},{"line_number":262,"context_line":"        self.assertEqual(expected_name, name)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        # with instance_info"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_61f763d3","line":261,"range":{"start_line":261,"start_character":37,"end_line":261,"end_character":45},"updated":"2016-08-05 12:45:14.000000000","message":"I\u0027m not sure I like : in file names, imagine Windows users trying to copy such file to their machine..","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        mock_utcnow.return_value \u003d datetime.datetime(2000, 1, 1, 0, 0)"},{"line_number":259,"context_line":"        name \u003d driver_utils.get_ramdisk_logs_file_name(self.node)"},{"line_number":260,"context_line":"        expected_name \u003d (\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123_\u0027"},{"line_number":261,"context_line":"                         \u00272000-01-01-00:00:00.tar.gz\u0027)"},{"line_number":262,"context_line":"        self.assertEqual(expected_name, name)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        # with instance_info"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_1c9b6c67","line":261,"range":{"start_line":261,"start_character":37,"end_line":261,"end_character":45},"in_reply_to":"bacf61ea_61f763d3","updated":"2016-08-05 13:34:35.000000000","message":"Yeah, it\u0027s not perfect. I thought of using \u0027-\u0027 (dash) again but that would be confusing because of the date.\n\nUsers can just have the name quoted, it\u0027s not a big deal.","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"}],"releasenotes/notes/collect-deployment-logs-2ec1634847c3f6a5.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9954812bddbd4df14f03556e0b6d91e9d747ec27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support for collecting deployment logs from the IPA ramdisk."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_7d8036f8","line":3,"updated":"2016-07-14 13:38:43.000000000","message":"maybe add quick information on how to enable it? I would also appreciate the troubleshooting guide update btw.","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bc72b9bfe132e7f06f743d9350e074818420db8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support for collecting deployment logs from the IPA ramdisk."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dada55a8_cddf5438","line":3,"in_reply_to":"1aa78d24_7d8036f8","updated":"2016-07-21 09:31:41.000000000","message":"I\u0027m leaving the documentation to a separated patch because it usually requires few interactions before we get the docs correctly.","commit_id":"48ce1bc3a143e08a932e0dd186bfb4f5df1e5e29"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e6d5e6e3a7d13ec4a04401a68a4edf9a8db10dd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bacf61ea_1f4425b5","line":9,"updated":"2016-08-04 19:43:57.000000000","message":"Given we\u0027re enabling, by default, the collection of logs on deploy failure, we need to put a note here that operators upgrading should enable some form of log rotation or changing the option to swift, otherwise an operator might be in for a nasty disk-space-eating surprise on upgrade.","commit_id":"1ff6dc499950c1affcafaf0e0299e415a781d03b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f34d92bfd0c335c276ac40a774b7c6e308430068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bacf61ea_299c3fbf","line":9,"in_reply_to":"bacf61ea_1f4425b5","updated":"2016-08-05 09:21:45.000000000","message":"Good call, yeah I will add it to the release notes","commit_id":"1ff6dc499950c1affcafaf0e0299e415a781d03b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1dc6e7958bd9162d477848c32e0da5d7f014c90","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    for the logs or change the configuration to store the logs in Swift"},{"line_number":8,"context_line":"    and avoid disk space problems."},{"line_number":9,"context_line":"upgrades:"},{"line_number":10,"context_line":"  - Five new configuration added, [agent]/group"},{"line_number":11,"context_line":"    deploy_logs_collect, [agent]deploy_logs_storage_backend,"},{"line_number":12,"context_line":"    [agent]/deploy_logs_local_path, [agent]/deploy_logs_swift_container and"},{"line_number":13,"context_line":"    [agent]/deploy_logs_swift_days_to_expire."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_81cff77d","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":32},"updated":"2016-08-05 12:45:14.000000000","message":"This is not an upgrade concern, so it should go to the feature note above. On the other hand, a note about logs rotation should probably move to this section.","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f74f83b8e8b293227e98eed51218542ce7bfecb0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    for the logs or change the configuration to store the logs in Swift"},{"line_number":8,"context_line":"    and avoid disk space problems."},{"line_number":9,"context_line":"upgrades:"},{"line_number":10,"context_line":"  - Five new configuration added, [agent]/group"},{"line_number":11,"context_line":"    deploy_logs_collect, [agent]deploy_logs_storage_backend,"},{"line_number":12,"context_line":"    [agent]/deploy_logs_local_path, [agent]/deploy_logs_swift_container and"},{"line_number":13,"context_line":"    [agent]/deploy_logs_swift_days_to_expire."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_bcc18031","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":32},"in_reply_to":"bacf61ea_81cff77d","updated":"2016-08-05 13:34:35.000000000","message":"Done","commit_id":"327915dde2a0e9b4abf84f0e9f249def690a7f65"}]}
