)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"db8236054e102bbcfaf8162b89e6d17c44be621e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-07-01 14:59:59 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Officially deprecate agent passthru classes and API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If0d189ecdd4b84d1dbac274e6dec200e13dfe37c"},{"line_number":10,"context_line":"Depends-On: I7160c99ca63585fc333482fa578fdf5e0962b2b6"},{"line_number":11,"context_line":"Closes-Bug: #1570841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_3bd14c58","line":8,"updated":"2016-07-05 20:16:45.000000000","message":"It\u0027d be useful to elaborate on this for those that don\u0027t read the spec. basically heartbeat \u0026 lookup; what are their replacements? Slated for removal in Ocata, right?","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d4361efdfa3f3175c5eb371fa8afd8e6dcfcf409","unresolved":false,"context_lines":[{"line_number":570,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":571,"context_line":"        LOG.warning(_LW(\u0027AgentVendorInterface class will be removed in the \u0027"},{"line_number":572,"context_line":"                        \u0027Ocata release, drivers should stop relying on it\u0027))"},{"line_number":573,"context_line":"        super(AgentVendorInterface, self).__init__(*args, **kwargs)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"class AgentRAID(base.RAIDInterface):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_75dba47c","line":573,"updated":"2016-08-05 10:37:57.000000000","message":"I wonder if we could move this and the iSCSI vendor warning to BaseAgentVendor. Or maybe we should just also put it there?\n\nI\u0027m concerned about drivers that inherit from BaseAgentVendor instead of using e.g. this class.","commit_id":"23f7943366560f010163883f6abd5c0a9b27674a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9de15a63d6c1f2917c3a7118b0bc3ee63c197585","unresolved":false,"context_lines":[{"line_number":570,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":571,"context_line":"        LOG.warning(_LW(\u0027AgentVendorInterface class will be removed in the \u0027"},{"line_number":572,"context_line":"                        \u0027Ocata release, drivers should stop relying on it\u0027))"},{"line_number":573,"context_line":"        super(AgentVendorInterface, self).__init__(*args, **kwargs)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"class AgentRAID(base.RAIDInterface):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_75e56407","line":573,"in_reply_to":"bacf61ea_75dba47c","updated":"2016-08-05 10:40:01.000000000","message":"Then we\u0027ll get deprecation warnings in our logs, because we do use BaseAgentVendor. I think deprecation and removal of BaseAgentVendor should be the next step.","commit_id":"23f7943366560f010163883f6abd5c0a9b27674a"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9d8c387327d606a6b993e1652434670af0a0ef34","unresolved":false,"context_lines":[{"line_number":567,"context_line":"    Contains old lookup and heartbeat endpoints currently pending deprecation."},{"line_number":568,"context_line":"    \"\"\""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":571,"context_line":"        LOG.warning(_LW(\u0027AgentVendorInterface class will be removed in the \u0027"},{"line_number":572,"context_line":"                        \u0027Ocata release, drivers should stop relying on it\u0027))"},{"line_number":573,"context_line":"        super(AgentVendorInterface, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_9be62dae","line":570,"updated":"2016-08-05 20:20:50.000000000","message":"this warning is not actionable by operators, who are going to see it. according to project guidelines, we shouldn\u0027t log a warning that an operator can\u0027t act upon.\n\nit is only a note to driver developers, so I think it should be a NOTE with big bold letters in the class documentation string.","commit_id":"4865b222a2dc413ffbef913a33a6226bac953a71"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"db8236054e102bbcfaf8162b89e6d17c44be621e","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        \"\"\""},{"line_number":721,"context_line":"        LOG.warning(_LW(\u0027Agent heartbeat vendor passthru is deprecated and \u0027"},{"line_number":722,"context_line":"                        \u0027will be removed in the Ocata release; please update \u0027"},{"line_number":723,"context_line":"                        \u0027your ironic-python-agent image\u0027))"},{"line_number":724,"context_line":"        try:"},{"line_number":725,"context_line":"            callback_url \u003d kwargs[\u0027agent_url\u0027]"},{"line_number":726,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_3864b220","line":723,"updated":"2016-07-05 20:16:45.000000000","message":"update the image to do what? Use the latest (or some?) version of IPA? Or do a POST /v1/heartbeat/\u003cUUID\u003e?","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"700572f44f0e96b35c112408856e95219a99e66e","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        \"\"\""},{"line_number":721,"context_line":"        LOG.warning(_LW(\u0027Agent heartbeat vendor passthru is deprecated and \u0027"},{"line_number":722,"context_line":"                        \u0027will be removed in the Ocata release; please update \u0027"},{"line_number":723,"context_line":"                        \u0027your ironic-python-agent image\u0027))"},{"line_number":724,"context_line":"        try:"},{"line_number":725,"context_line":"            callback_url \u003d kwargs[\u0027agent_url\u0027]"},{"line_number":726,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_e4e2802e","line":723,"in_reply_to":"1aa78d24_3864b220","updated":"2016-07-05 23:49:11.000000000","message":"I understand the latest ipa image will remove such vendor passthru interface, right?","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f78055349ec4a3ea95d14420d6d9e489bce292f2","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        \"\"\""},{"line_number":721,"context_line":"        LOG.warning(_LW(\u0027Agent heartbeat vendor passthru is deprecated and \u0027"},{"line_number":722,"context_line":"                        \u0027will be removed in the Ocata release; please update \u0027"},{"line_number":723,"context_line":"                        \u0027your ironic-python-agent image\u0027))"},{"line_number":724,"context_line":"        try:"},{"line_number":725,"context_line":"            callback_url \u003d kwargs[\u0027agent_url\u0027]"},{"line_number":726,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_e5f1c302","line":723,"in_reply_to":"1aa78d24_d358da8c","updated":"2016-07-06 11:43:51.000000000","message":"Would it be better to mention minimum version of IPA that could be used to overcome this warning?","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5704e2389aa42f0ae55e99f95a401ce4edb3f276","unresolved":false,"context_lines":[{"line_number":720,"context_line":"        \"\"\""},{"line_number":721,"context_line":"        LOG.warning(_LW(\u0027Agent heartbeat vendor passthru is deprecated and \u0027"},{"line_number":722,"context_line":"                        \u0027will be removed in the Ocata release; please update \u0027"},{"line_number":723,"context_line":"                        \u0027your ironic-python-agent image\u0027))"},{"line_number":724,"context_line":"        try:"},{"line_number":725,"context_line":"            callback_url \u003d kwargs[\u0027agent_url\u0027]"},{"line_number":726,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_d358da8c","line":723,"in_reply_to":"1aa78d24_e4e2802e","updated":"2016-07-06 08:51:55.000000000","message":"Correct, the IPA image would use the endpoints (heartbeat and lookup) from the standard API instead of the vendor passthru ones.","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"db8236054e102bbcfaf8162b89e6d17c44be621e","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        \"\"\""},{"line_number":779,"context_line":"        LOG.warning(_LW(\u0027Agent lookup vendor passthru is deprecated and \u0027"},{"line_number":780,"context_line":"                        \u0027will be removed in the Ocata release; please update \u0027"},{"line_number":781,"context_line":"                        \u0027your ironic-python-agent image\u0027))"},{"line_number":782,"context_line":"        LOG.debug(\u0027Agent lookup using data %s\u0027, kwargs)"},{"line_number":783,"context_line":"        uuid \u003d kwargs.get(\u0027node_uuid\u0027)"},{"line_number":784,"context_line":"        if uuid:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_3832f210","line":781,"updated":"2016-07-05 20:16:45.000000000","message":"ditto","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d4361efdfa3f3175c5eb371fa8afd8e6dcfcf409","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        LOG.warning(_LW(\u0027Agent heartbeat vendor passthru is deprecated and \u0027"},{"line_number":711,"context_line":"                        \u0027will be removed in the Ocata release; please update \u0027"},{"line_number":712,"context_line":"                        \u0027your ironic-python-agent image to Newton version\u0027))"},{"line_number":713,"context_line":"        try:"},{"line_number":714,"context_line":"            callback_url \u003d kwargs[\u0027agent_url\u0027]"},{"line_number":715,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b5b87c12","line":712,"updated":"2016-08-05 10:37:57.000000000","message":"nit: s/Newton/the Newton/","commit_id":"23f7943366560f010163883f6abd5c0a9b27674a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9de15a63d6c1f2917c3a7118b0bc3ee63c197585","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        LOG.warning(_LW(\u0027Agent heartbeat vendor passthru is deprecated and \u0027"},{"line_number":711,"context_line":"                        \u0027will be removed in the Ocata release; please update \u0027"},{"line_number":712,"context_line":"                        \u0027your ironic-python-agent image to Newton version\u0027))"},{"line_number":713,"context_line":"        try:"},{"line_number":714,"context_line":"            callback_url \u003d kwargs[\u0027agent_url\u0027]"},{"line_number":715,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_f5bf94cd","line":712,"in_reply_to":"bacf61ea_b5b87c12","updated":"2016-08-05 10:40:01.000000000","message":"Done","commit_id":"23f7943366560f010163883f6abd5c0a9b27674a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d4361efdfa3f3175c5eb371fa8afd8e6dcfcf409","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        \"\"\""},{"line_number":772,"context_line":"        LOG.warning(_LW(\u0027Agent lookup vendor passthru is deprecated and \u0027"},{"line_number":773,"context_line":"                        \u0027will be removed in the Ocata release; please update \u0027"},{"line_number":774,"context_line":"                        \u0027your ironic-python-agent image to Newton version\u0027))"},{"line_number":775,"context_line":"        LOG.debug(\u0027Agent lookup using data %s\u0027, kwargs)"},{"line_number":776,"context_line":"        uuid \u003d kwargs.get(\u0027node_uuid\u0027)"},{"line_number":777,"context_line":"        if uuid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1538689f","line":774,"updated":"2016-08-05 10:37:57.000000000","message":"Ditto","commit_id":"23f7943366560f010163883f6abd5c0a9b27674a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9de15a63d6c1f2917c3a7118b0bc3ee63c197585","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        \"\"\""},{"line_number":772,"context_line":"        LOG.warning(_LW(\u0027Agent lookup vendor passthru is deprecated and \u0027"},{"line_number":773,"context_line":"                        \u0027will be removed in the Ocata release; please update \u0027"},{"line_number":774,"context_line":"                        \u0027your ironic-python-agent image to Newton version\u0027))"},{"line_number":775,"context_line":"        LOG.debug(\u0027Agent lookup using data %s\u0027, kwargs)"},{"line_number":776,"context_line":"        uuid \u003d kwargs.get(\u0027node_uuid\u0027)"},{"line_number":777,"context_line":"        if uuid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_55b14000","line":774,"in_reply_to":"bacf61ea_1538689f","updated":"2016-08-05 10:40:01.000000000","message":"Done","commit_id":"23f7943366560f010163883f6abd5c0a9b27674a"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6536b407600ac45931dc22243efdb5fb8a1f7c93","unresolved":false,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        AGENT_PORT defaults to 9999."},{"line_number":711,"context_line":"        \"\"\""},{"line_number":712,"context_line":"        LOG.warning("},{"line_number":713,"context_line":"            _LW(\u0027Agent heartbeat vendor passthru is deprecated and will be \u0027"},{"line_number":714,"context_line":"                \u0027removed in the Ocata release; please update your \u0027"},{"line_number":715,"context_line":"                \u0027ironic-python-agent image to the Newton version\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_b85b3753","line":712,"updated":"2016-08-05 20:01:45.000000000","message":"this is going to spam / fill up log files for anyone who happens to hit this code path, since it\u0027ll LOG.warning on *every* heartbeat from *every* ramdisk.","commit_id":"4865b222a2dc413ffbef913a33a6226bac953a71"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6536b407600ac45931dc22243efdb5fb8a1f7c93","unresolved":false,"context_lines":[{"line_number":772,"context_line":"        :raises: NotFound if no matching node is found."},{"line_number":773,"context_line":"        :raises: InvalidParameterValue with unknown payload version"},{"line_number":774,"context_line":"        \"\"\""},{"line_number":775,"context_line":"        LOG.warning("},{"line_number":776,"context_line":"            _LW(\u0027Agent lookup vendor passthru is deprecated and will be \u0027"},{"line_number":777,"context_line":"                \u0027removed in the Ocata release; please update your \u0027"},{"line_number":778,"context_line":"                \u0027ironic-python-agent image to the Newton version\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_1857e326","line":775,"updated":"2016-08-05 20:01:45.000000000","message":"ditto as above - going to spam a lot of logs","commit_id":"4865b222a2dc413ffbef913a33a6226bac953a71"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"35483493c6290dd692e934103b599b65dca8b54a","unresolved":false,"context_lines":[{"line_number":772,"context_line":"        :raises: NotFound if no matching node is found."},{"line_number":773,"context_line":"        :raises: InvalidParameterValue with unknown payload version"},{"line_number":774,"context_line":"        \"\"\""},{"line_number":775,"context_line":"        LOG.warning("},{"line_number":776,"context_line":"            _LW(\u0027Agent lookup vendor passthru is deprecated and will be \u0027"},{"line_number":777,"context_line":"                \u0027removed in the Ocata release; please update your \u0027"},{"line_number":778,"context_line":"                \u0027ironic-python-agent image to the Newton version\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_d57317b3","line":775,"in_reply_to":"bacf61ea_1857e326","updated":"2016-08-08 13:16:32.000000000","message":"Well, I thought we agreed in IRC to leave lookup, as it\u0027s the best way to know if a given node doesn\u0027t have an updated agent, right?\n\nI\u0027m updating this patch now, going to leave this here and just remove heartbeat.","commit_id":"4865b222a2dc413ffbef913a33a6226bac953a71"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8651cf9606c56cd60d1e62a21abd377110752249","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ironic.common import dhcp_factory"},{"line_number":26,"context_line":"from ironic.common import exception"},{"line_number":27,"context_line":"from ironic.common.i18n import _, _LW"},{"line_number":28,"context_line":"from ironic.common import states"},{"line_number":29,"context_line":"from ironic.common import utils"},{"line_number":30,"context_line":"from ironic.conductor import task_manager"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_b9b93d31","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":37},"updated":"2016-08-08 13:34:48.000000000","message":"seems to be not needed.","commit_id":"1c6b3bc799a55151725aad1b71c456a720630523"}],"releasenotes/notes/deprecate-agent-passthru-67d1e2cf25b30a30.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"db8236054e102bbcfaf8162b89e6d17c44be621e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Agent vendor passthru is deprecated and will be removed in Ocata release."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_d802ce0a","line":3,"updated":"2016-07-05 20:16:45.000000000","message":"Maybe we should mention what the operator should do/change.","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5704e2389aa42f0ae55e99f95a401ce4edb3f276","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Agent vendor passthru is deprecated and will be removed in Ocata release."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_b3d42ebd","line":3,"in_reply_to":"1aa78d24_8a9d830c","updated":"2016-07-06 08:51:55.000000000","message":"+1","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f78055349ec4a3ea95d14420d6d9e489bce292f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Agent vendor passthru is deprecated and will be removed in Ocata release."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_a5d21b5a","line":3,"in_reply_to":"1aa78d24_b3d42ebd","updated":"2016-07-06 11:43:51.000000000","message":"+1","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"c93cf21cb8b787c1571c0beaf1833f933cb627e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Agent vendor passthru is deprecated and will be removed in Ocata release."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_8a9d830c","line":3,"in_reply_to":"1aa78d24_d802ce0a","updated":"2016-07-06 01:37:10.000000000","message":"+1","commit_id":"10d254aeb62caee74681270d1c0868bd7b9e2ed5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d4361efdfa3f3175c5eb371fa8afd8e6dcfcf409","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Agent vendor passthru is deprecated and will be removed in Ocata release."},{"line_number":4,"context_line":"    Operators should update their IPA image to Newton version to use"},{"line_number":5,"context_line":"    the new replacement API. Driver developers should stop using the agent"},{"line_number":6,"context_line":"    vendor passthru."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_b54fdc32","line":4,"updated":"2016-08-05 10:37:57.000000000","message":"Ditto","commit_id":"23f7943366560f010163883f6abd5c0a9b27674a"}]}
