)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7d335b7ba1e6515422f270f07fab67b678e8f85d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable support for OSprofiler in Ironic."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add osprofiler wsgi middleware"},{"line_number":10,"context_line":"This middleware is used for 2 things:"},{"line_number":11,"context_line":"- It checks that person who want to trace is trusted and knows"},{"line_number":12,"context_line":"secret HMAC key."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_2a1c7611","line":9,"updated":"2016-08-09 23:32:25.000000000","message":"This content needs to be in the documentation.","commit_id":"7265a793fa2caf781e1e74bbeecbfd44260e2f4f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ramamani Yeleswarapu \u003cramamani.yeleswarapu@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-09 17:07:47 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable support for OSprofiler in Ironic."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add osprofiler wsgi middleware"},{"line_number":10,"context_line":"This middleware is used for 2 things:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_89390ba7","line":7,"updated":"2016-08-10 14:42:25.000000000","message":"no period at the end (see https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure)","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ramamani Yeleswarapu \u003cramamani.yeleswarapu@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-09 17:07:47 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable support for OSprofiler in Ironic."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add osprofiler wsgi middleware"},{"line_number":10,"context_line":"This middleware is used for 2 things:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3ac371cc_63bfeefb","line":7,"in_reply_to":"9ad45d7e_89390ba7","updated":"2016-08-15 17:17:44.000000000","message":"Done","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add osprofiler wsgi middleware"},{"line_number":10,"context_line":"This middleware is used for 2 things:"},{"line_number":11,"context_line":"- It checks that person who want to trace is trusted and knows"},{"line_number":12,"context_line":"secret HMAC key."},{"line_number":13,"context_line":"- It starts tracing in case of proper trace headers"},{"line_number":14,"context_line":"and adds first wsgi trace point, with info about HTTP request."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_2968df86","line":11,"updated":"2016-08-10 14:42:25.000000000","message":"s/want/wants/","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add osprofiler wsgi middleware"},{"line_number":10,"context_line":"This middleware is used for 2 things:"},{"line_number":11,"context_line":"- It checks that person who want to trace is trusted and knows"},{"line_number":12,"context_line":"secret HMAC key."},{"line_number":13,"context_line":"- It starts tracing in case of proper trace headers"},{"line_number":14,"context_line":"and adds first wsgi trace point, with info about HTTP request."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3ac371cc_43bc7205","line":11,"in_reply_to":"9ad45d7e_2968df86","updated":"2016-08-15 17:17:44.000000000","message":"Done","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This middleware is used for 2 things:"},{"line_number":11,"context_line":"- It checks that person who want to trace is trusted and knows"},{"line_number":12,"context_line":"secret HMAC key."},{"line_number":13,"context_line":"- It starts tracing in case of proper trace headers"},{"line_number":14,"context_line":"and adds first wsgi trace point, with info about HTTP request."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Add initialization of osprofiler at start of service"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_4919d321","line":13,"updated":"2016-08-10 14:42:25.000000000","message":"what do you mean by \u0027in case of\u0027 ?","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This middleware is used for 2 things:"},{"line_number":11,"context_line":"- It checks that person who want to trace is trusted and knows"},{"line_number":12,"context_line":"secret HMAC key."},{"line_number":13,"context_line":"- It starts tracing in case of proper trace headers"},{"line_number":14,"context_line":"and adds first wsgi trace point, with info about HTTP request."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Add initialization of osprofiler at start of service"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_410b1a24","line":13,"in_reply_to":"9ad45d7e_4919d321","updated":"2016-08-15 17:17:44.000000000","message":"trace headers are added by the client.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- Initialize and set an oslo.messaging based notifier instance"},{"line_number":18,"context_line":"to osprofiler, which will be used to send notifications to Ceilometer."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"NOTE to test this:"},{"line_number":21,"context_line":"1) Enable profiler option(s) in ironic.conf."},{"line_number":22,"context_line":"2) Enable the following services in localrc for devstack:"},{"line_number":23,"context_line":"  CEILOMETER_NOTIFICATION_TOPICS\u003dnotifications,profiler"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_097fdb15","line":20,"updated":"2016-08-10 14:42:25.000000000","message":"to test what? osprofiler being used to .. from ironic to ceilometer, using devstack?","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- Initialize and set an oslo.messaging based notifier instance"},{"line_number":18,"context_line":"to osprofiler, which will be used to send notifications to Ceilometer."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"NOTE to test this:"},{"line_number":21,"context_line":"1) Enable profiler option(s) in ironic.conf."},{"line_number":22,"context_line":"2) Enable the following services in localrc for devstack:"},{"line_number":23,"context_line":"  CEILOMETER_NOTIFICATION_TOPICS\u003dnotifications,profiler"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_012c8297","line":20,"in_reply_to":"9ad45d7e_097fdb15","updated":"2016-08-15 17:17:44.000000000","message":"Yes","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  $ osprofiler trace show --html \u003cTrace ID\u003e"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Change-Id: I0beb20c128f695872efe187e1bfa4390a61563a3"},{"line_number":38,"context_line":"Closes-Bug: #1560704"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_09423bae","line":38,"updated":"2016-08-10 14:42:25.000000000","message":"If there is going to be more than one patch to address this RFE, this should be \u0027Partial-Bug\u0027.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  $ osprofiler trace show --html \u003cTrace ID\u003e"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Change-Id: I0beb20c128f695872efe187e1bfa4390a61563a3"},{"line_number":38,"context_line":"Closes-Bug: #1560704"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3ac371cc_a35e06e7","line":38,"in_reply_to":"9ad45d7e_09423bae","updated":"2016-08-15 17:17:44.000000000","message":"Done","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"}],"ironic/cmd/api.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    # Enable object backporting via the conductor"},{"line_number":36,"context_line":"    base.IronicObject.indirection_api \u003d base.IronicObjectIndirectionAPI()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    setup_profiler.setup(\u0027ironic_api\u0027, CONF.host)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # Build and start the WSGI app"},{"line_number":41,"context_line":"    launcher \u003d ironic_service.process_launcher()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_89f0eb68","line":38,"updated":"2016-08-10 14:42:25.000000000","message":"just curious why you called it \u0027setup_profiler\u0027 instead of eg \u0027profiler\u0027. It seems odd to see setup twice here.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    # Enable object backporting via the conductor"},{"line_number":36,"context_line":"    base.IronicObject.indirection_api \u003d base.IronicObjectIndirectionAPI()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    setup_profiler.setup(\u0027ironic_api\u0027, CONF.host)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    # Build and start the WSGI app"},{"line_number":41,"context_line":"    launcher \u003d ironic_service.process_launcher()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_eea0e592","line":38,"in_reply_to":"9ad45d7e_89f0eb68","updated":"2016-08-15 17:17:44.000000000","message":"Renamed it.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"}],"ironic/common/profiler.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from oslo_log import log as logging"},{"line_number":15,"context_line":"import oslo_messaging"},{"line_number":16,"context_line":"import osprofiler.notifier"},{"line_number":17,"context_line":"from osprofiler import opts as profiler_opts"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"CONF \u003d cfg.CONF"},{"line_number":20,"context_line":"profiler_opts.set_defaults(CONF)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_0c4249ae","line":17,"updated":"2016-08-10 14:42:25.000000000","message":"seems inconsistent wrt how you are importing stuff from osprofiler. I also see that you are using osprofiler.web.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from oslo_log import log as logging"},{"line_number":15,"context_line":"import oslo_messaging"},{"line_number":16,"context_line":"import osprofiler.notifier"},{"line_number":17,"context_line":"from osprofiler import opts as profiler_opts"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"CONF \u003d cfg.CONF"},{"line_number":20,"context_line":"profiler_opts.set_defaults(CONF)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_ee6f4590","line":17,"in_reply_to":"9ad45d7e_0c4249ae","updated":"2016-08-15 17:17:44.000000000","message":"Done","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from osprofiler import opts as profiler_opts"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"CONF \u003d cfg.CONF"},{"line_number":20,"context_line":"profiler_opts.set_defaults(CONF)"},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_a947af75","line":20,"updated":"2016-08-10 14:42:25.000000000","message":"why do you do this here and in config.py?","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from osprofiler import opts as profiler_opts"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"CONF \u003d cfg.CONF"},{"line_number":20,"context_line":"profiler_opts.set_defaults(CONF)"},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_ae142df5","line":20,"in_reply_to":"9ad45d7e_a947af75","updated":"2016-08-15 17:17:44.000000000","message":"Not needed. Removed in the next patch.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    :param name: name of the service that will be profiled"},{"line_number":28,"context_line":"    :param host: hostname or host IP address that the service will be"},{"line_number":29,"context_line":"                 running on. By default host will be set to 0.0.0.0, but more"},{"line_number":30,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    if CONF.profiler.enabled:"},{"line_number":33,"context_line":"        _notifier \u003d osprofiler.notifier.create("}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_ecf895c5","line":30,"updated":"2016-08-10 14:42:25.000000000","message":"What are the name and host used for? Are they just strings that are used when emitting the traces, or are they used for other things? Eg, I\u0027m wondering if the host needs to be a valid host. Based on this description, it doesn\u0027t seem like it matters what it is.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    :param name: name of the service that will be profiled"},{"line_number":28,"context_line":"    :param host: hostname or host IP address that the service will be"},{"line_number":29,"context_line":"                 running on. By default host will be set to 0.0.0.0, but more"},{"line_number":30,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    if CONF.profiler.enabled:"},{"line_number":33,"context_line":"        _notifier \u003d osprofiler.notifier.create("}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_ce26c967","line":30,"in_reply_to":"9ad45d7e_ecf895c5","updated":"2016-08-15 17:17:44.000000000","message":"Yes.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    :param host: hostname or host IP address that the service will be"},{"line_number":29,"context_line":"                 running on. By default host will be set to 0.0.0.0, but more"},{"line_number":30,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    if CONF.profiler.enabled:"},{"line_number":33,"context_line":"        _notifier \u003d osprofiler.notifier.create("},{"line_number":34,"context_line":"            \"Messaging\", oslo_messaging, {},"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_0ce08928","line":31,"updated":"2016-08-10 14:42:25.000000000","message":"what happens if osprofiler cannot be set up? Will exceptions be raised? If so, what exceptions?","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    :param host: hostname or host IP address that the service will be"},{"line_number":29,"context_line":"                 running on. By default host will be set to 0.0.0.0, but more"},{"line_number":30,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    if CONF.profiler.enabled:"},{"line_number":33,"context_line":"        _notifier \u003d osprofiler.notifier.create("},{"line_number":34,"context_line":"            \"Messaging\", oslo_messaging, {},"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_6e94f536","line":31,"in_reply_to":"9ad45d7e_0ce08928","updated":"2016-08-15 17:17:44.000000000","message":"A TypeError is raised in case of invalid plugin name: https://github.com/openstack/osprofiler/blob/master/osprofiler/notifier.py#L52","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            oslo_messaging.get_transport(CONF), \"ironic\", name, host)"},{"line_number":36,"context_line":"        osprofiler.notifier.set(_notifier)"},{"line_number":37,"context_line":"        osprofiler.web.enable(CONF.profiler.hmac_keys)"},{"line_number":38,"context_line":"        LOG.info(\"OSProfiler is enabled.\\n\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_ec67f5e6","line":38,"updated":"2016-08-10 14:42:25.000000000","message":"Do you need the \u0027\\n\u0027? We don\u0027t typically do that.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            oslo_messaging.get_transport(CONF), \"ironic\", name, host)"},{"line_number":36,"context_line":"        osprofiler.notifier.set(_notifier)"},{"line_number":37,"context_line":"        osprofiler.web.enable(CONF.profiler.hmac_keys)"},{"line_number":38,"context_line":"        LOG.info(\"OSProfiler is enabled.\\n\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_c31182ae","line":38,"in_reply_to":"9ad45d7e_ec67f5e6","updated":"2016-08-15 17:17:44.000000000","message":"Done","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"605917dbf2c785a2ec4525e096340eda587f731d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    if CONF.profiler.enabled:"},{"line_number":32,"context_line":"        _notifier \u003d profiler_notifier.create("},{"line_number":33,"context_line":"            \"Messaging\", oslo_messaging, {},"},{"line_number":34,"context_line":"            oslo_messaging.get_transport(CONF), \"ironic\", name, host)"},{"line_number":35,"context_line":"        profiler_notifier.set(_notifier)"},{"line_number":36,"context_line":"        profiler_web.enable(CONF.profiler.hmac_keys)"},{"line_number":37,"context_line":"        LOG.info(\"OSProfiler is enabled.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_bd52bedb","line":37,"range":{"start_line":32,"start_character":1,"end_line":37,"end_character":42},"updated":"2016-08-15 08:54:12.000000000","message":"I suggest to use the initializer introduced in osprofiler 1.4.0 to do the setup. I have sent a patch to Neutron.\n\nhttps://review.openstack.org/353281","commit_id":"62fe6b3609a44e087b2dff8d6d989e0edecd4494"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"7fbdd30b3c9a3daa892d8d316443ef7ac78311ae","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    if CONF.profiler.enabled:"},{"line_number":32,"context_line":"        _notifier \u003d profiler_notifier.create("},{"line_number":33,"context_line":"            \"Messaging\", oslo_messaging, {},"},{"line_number":34,"context_line":"            oslo_messaging.get_transport(CONF), \"ironic\", name, host)"},{"line_number":35,"context_line":"        profiler_notifier.set(_notifier)"},{"line_number":36,"context_line":"        profiler_web.enable(CONF.profiler.hmac_keys)"},{"line_number":37,"context_line":"        LOG.info(\"OSProfiler is enabled.\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_6e099595","line":37,"range":{"start_line":32,"start_character":1,"end_line":37,"end_character":42},"in_reply_to":"3ac371cc_bd52bedb","updated":"2016-08-15 17:18:58.000000000","message":"Ok, thanks.","commit_id":"62fe6b3609a44e087b2dff8d6d989e0edecd4494"}],"ironic/common/service.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.workers \u003d (CONF.api.api_workers or"},{"line_number":145,"context_line":"                        processutils.get_worker_count())"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        setup_profiler.setup(name, CONF.host)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if self.workers and self.workers \u003c 1:"},{"line_number":150,"context_line":"            raise exception.ConfigInvalid("}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_8cf0f968","line":147,"updated":"2016-08-10 14:42:25.000000000","message":"why do you need to call this here and in ironic/cmd/api.py?","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.workers \u003d (CONF.api.api_workers or"},{"line_number":145,"context_line":"                        processutils.get_worker_count())"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        setup_profiler.setup(name, CONF.host)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if self.workers and self.workers \u003c 1:"},{"line_number":150,"context_line":"            raise exception.ConfigInvalid("}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_8365ca46","line":147,"in_reply_to":"9ad45d7e_8cf0f968","updated":"2016-08-15 17:17:44.000000000","message":"Notifier for the ironic api wsgi service is created here, without which trace cannot be done on ironic api.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"}],"releasenotes/notes/enable-osprofiler-support-0bbcb19bdb068cb8.yaml":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7d335b7ba1e6515422f270f07fab67b678e8f85d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OSprofiler support was added. This cross-project profiling library"},{"line_number":5,"context_line":"    allows to trace various OpenStack requests through all OpenStack"},{"line_number":6,"context_line":"    services that support it. To initiate OpenStack request tracing, "},{"line_number":7,"context_line":"    `--profile \u003cHMAC_KEY\u003e` option needs to be added to the CLI command. "},{"line_number":8,"context_line":"    This key needs to present one of the secret keys defined in "},{"line_number":9,"context_line":"    ironic.conf configuration file with `hmac_keys` option under the "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_cae31a04","line":6,"updated":"2016-08-09 23:32:25.000000000","message":"Trailing whitespace","commit_id":"7265a793fa2caf781e1e74bbeecbfd44260e2f4f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OSprofiler support was added. This cross-project profiling library"},{"line_number":5,"context_line":"    allows to trace various OpenStack requests through all OpenStack"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_8c9759eb","line":2,"updated":"2016-08-10 14:42:25.000000000","message":"this is a feature, not a bug.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OSprofiler support was added. This cross-project profiling library"},{"line_number":5,"context_line":"    allows to trace various OpenStack requests through all OpenStack"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_ae0eed31","line":2,"in_reply_to":"9ad45d7e_8c9759eb","updated":"2016-08-15 17:17:44.000000000","message":"Done","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OSprofiler support was added. This cross-project profiling library"},{"line_number":5,"context_line":"    allows to trace various OpenStack requests through all OpenStack"},{"line_number":6,"context_line":"    services that support it. To initiate OpenStack request tracing,"},{"line_number":7,"context_line":"    `--profile \u003cHMAC_KEY\u003e` option needs to be added to the CLI command."},{"line_number":8,"context_line":"    This key needs to present one of the secret keys defined in"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_ec2415c6","line":5,"updated":"2016-08-10 14:42:25.000000000","message":"s/allows/provides the ability/","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OSprofiler support was added. This cross-project profiling library"},{"line_number":5,"context_line":"    allows to trace various OpenStack requests through all OpenStack"},{"line_number":6,"context_line":"    services that support it. To initiate OpenStack request tracing,"},{"line_number":7,"context_line":"    `--profile \u003cHMAC_KEY\u003e` option needs to be added to the CLI command."},{"line_number":8,"context_line":"    This key needs to present one of the secret keys defined in"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_0e146142","line":5,"in_reply_to":"9ad45d7e_ec2415c6","updated":"2016-08-15 17:17:44.000000000","message":"Done","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    `$ ironic --profile SECRET_KEY \u003csubcommand\u003e`."},{"line_number":18,"context_line":"    As part of the output, there will be a message with \u003ctrace_id\u003e."},{"line_number":19,"context_line":"    To see the HTML graphs, the following command should be used -"},{"line_number":20,"context_line":"    `$ osprofiler trace show \u003ctrace_id\u003e --html --out result.html`."},{"line_number":21,"context_line":"upgrade:"},{"line_number":22,"context_line":"  - Added OSprofiler wsgi middleware support and enabled OSprofiler in Ironic."},{"line_number":23,"context_line":"security:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_6fa2d7fe","line":20,"updated":"2016-08-10 14:42:25.000000000","message":"I think there is too much detail here; we should put a link to documentation that includes this info.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    `$ ironic --profile SECRET_KEY \u003csubcommand\u003e`."},{"line_number":18,"context_line":"    As part of the output, there will be a message with \u003ctrace_id\u003e."},{"line_number":19,"context_line":"    To see the HTML graphs, the following command should be used -"},{"line_number":20,"context_line":"    `$ osprofiler trace show \u003ctrace_id\u003e --html --out result.html`."},{"line_number":21,"context_line":"upgrade:"},{"line_number":22,"context_line":"  - Added OSprofiler wsgi middleware support and enabled OSprofiler in Ironic."},{"line_number":23,"context_line":"security:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_8e2691b8","line":20,"in_reply_to":"9ad45d7e_6fa2d7fe","updated":"2016-08-15 17:17:44.000000000","message":"Done","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c29844f8715f5e733aeb4c83bc333c3cbf7fb48d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    To see the HTML graphs, the following command should be used -"},{"line_number":20,"context_line":"    `$ osprofiler trace show \u003ctrace_id\u003e --html --out result.html`."},{"line_number":21,"context_line":"upgrade:"},{"line_number":22,"context_line":"  - Added OSprofiler wsgi middleware support and enabled OSprofiler in Ironic."},{"line_number":23,"context_line":"security:"},{"line_number":24,"context_line":"  - OSprofiler support requires passing of trace information between"},{"line_number":25,"context_line":"    various OpenStack services. This information is securely signed"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_ef39a7d8","line":22,"updated":"2016-08-10 14:42:25.000000000","message":"I don\u0027t think the operator needs to do anything when upgrading ironic, wrt this feature, right? Is OSprofiler disabled by default? If so, I don\u0027t think an upgrade section is needed.","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"55b56f0ce209a3228ad2f757e67a67880674e07e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    To see the HTML graphs, the following command should be used -"},{"line_number":20,"context_line":"    `$ osprofiler trace show \u003ctrace_id\u003e --html --out result.html`."},{"line_number":21,"context_line":"upgrade:"},{"line_number":22,"context_line":"  - Added OSprofiler wsgi middleware support and enabled OSprofiler in Ironic."},{"line_number":23,"context_line":"security:"},{"line_number":24,"context_line":"  - OSprofiler support requires passing of trace information between"},{"line_number":25,"context_line":"    various OpenStack services. This information is securely signed"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3ac371cc_ce20899e","line":22,"in_reply_to":"9ad45d7e_ef39a7d8","updated":"2016-08-15 17:17:44.000000000","message":"Done","commit_id":"acaa0bd9a55629e5043f1918966e8b3129f2a30f"}],"requirements.txt":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"605917dbf2c785a2ec4525e096340eda587f731d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"oslo.serialization\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":32,"context_line":"oslo.service\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":33,"context_line":"oslo.utils\u003e\u003d3.16.0 # Apache-2.0"},{"line_number":34,"context_line":"osprofiler\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":35,"context_line":"pecan\u003e\u003d1.0.0 # BSD"},{"line_number":36,"context_line":"requests\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":37,"context_line":"six\u003e\u003d1.9.0 # MIT"}],"source_content_type":"text/plain","patch_set":8,"id":"3ac371cc_fd3b969a","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":16},"updated":"2016-08-15 08:54:12.000000000","message":"1.4.0 just released.","commit_id":"62fe6b3609a44e087b2dff8d6d989e0edecd4494"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"7fbdd30b3c9a3daa892d8d316443ef7ac78311ae","unresolved":false,"context_lines":[{"line_number":31,"context_line":"oslo.serialization\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":32,"context_line":"oslo.service\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":33,"context_line":"oslo.utils\u003e\u003d3.16.0 # Apache-2.0"},{"line_number":34,"context_line":"osprofiler\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":35,"context_line":"pecan\u003e\u003d1.0.0 # BSD"},{"line_number":36,"context_line":"requests\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":37,"context_line":"six\u003e\u003d1.9.0 # MIT"}],"source_content_type":"text/plain","patch_set":8,"id":"3ac371cc_ce352947","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":16},"in_reply_to":"3ac371cc_fd3b969a","updated":"2016-08-15 17:18:58.000000000","message":"ok, thanks.","commit_id":"62fe6b3609a44e087b2dff8d6d989e0edecd4494"}]}
