)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"825dbb82df34405e07bf6202f524471edad7a2c6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Follow-up patch of cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is a follow-up patch of"},{"line_number":10,"context_line":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3 addressing some the remaining"},{"line_number":11,"context_line":"comments after the patch was merged."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d269fd461c47d629328eba413eb4f5331a40de1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_0b564205","line":10,"updated":"2016-07-07 19:01:15.000000000","message":"This link cbe51c6a10d1fa68c7082af67827d8c0d8967fe3 leads to two search results; it would be helpful if this link directly pointed to the referred patch instead. Thanks.","commit_id":"7d1f5236edfd5fb04150d614a8e8604c1db3eea1"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"825dbb82df34405e07bf6202f524471edad7a2c6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Follow-up patch of cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is a follow-up patch of"},{"line_number":10,"context_line":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3 addressing some the remaining"},{"line_number":11,"context_line":"comments after the patch was merged."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d269fd461c47d629328eba413eb4f5331a40de1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_eb101602","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":60},"updated":"2016-07-07 19:01:15.000000000","message":"s/some the/some of the/\n\nIt would be great if all of the remaining comments are addressed. Thanks.","commit_id":"7d1f5236edfd5fb04150d614a8e8604c1db3eea1"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"87494236604c0b02e9ba924c1b92928e94e0eb7e","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            cmd_args.append(pw_file)"},{"line_number":424,"context_line":"            cmd_args.extend(command.split(\" \"))"},{"line_number":425,"context_line":"            try:"},{"line_number":426,"context_line":"                if check_exit_code:"},{"line_number":427,"context_line":"                    out, err \u003d utils.execute(*cmd_args,"},{"line_number":428,"context_line":"                                             check_exit_code\u003dcheck_exit_code)"},{"line_number":429,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_1937e1ff","line":426,"updated":"2016-07-07 09:04:20.000000000","message":"if check_exit_code is None:\n\nOtherwise someone passing \"False\" or \"0\" which are allowed values (as per docstring) won\u0027t actually enter this conditional.","commit_id":"bdd7a5c6b2a2908db9fa38ef30c758577cb08c3b"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6ece4cfe7f28971ec06f1122f788e50650aa7b8d","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            cmd_args.append(pw_file)"},{"line_number":424,"context_line":"            cmd_args.extend(command.split(\" \"))"},{"line_number":425,"context_line":"            try:"},{"line_number":426,"context_line":"                if check_exit_code:"},{"line_number":427,"context_line":"                    out, err \u003d utils.execute(*cmd_args,"},{"line_number":428,"context_line":"                                             check_exit_code\u003dcheck_exit_code)"},{"line_number":429,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_4ce997b6","line":426,"in_reply_to":"1aa78d24_1937e1ff","updated":"2016-07-07 14:09:58.000000000","message":"Done","commit_id":"bdd7a5c6b2a2908db9fa38ef30c758577cb08c3b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"87494236604c0b02e9ba924c1b92928e94e0eb7e","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                    out, err \u003d utils.execute(*cmd_args,"},{"line_number":428,"context_line":"                                             check_exit_code\u003dcheck_exit_code)"},{"line_number":429,"context_line":"                else:"},{"line_number":430,"context_line":"                    out, err \u003d utils.execute(*cmd_args)"},{"line_number":431,"context_line":"                return out, err"},{"line_number":432,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":433,"context_line":"                with excutils.save_and_reraise_exception() as ctxt:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_9438b8d4","line":430,"updated":"2016-07-07 09:04:20.000000000","message":"Suggestion:\n\nInstead of having a conditional for separating if the parameter has been passed or not we can make it as a dict which will be easily extendable later if more parameters are to be added:\n\nextra_args \u003d {}\nif check_exit_code is not None:\n   extra_args[\u0027check_exit_code\u0027]\u003d check_exit_code\n\nout, err \u003d utils.execute(*cmd_args, **extra_args)","commit_id":"bdd7a5c6b2a2908db9fa38ef30c758577cb08c3b"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6ece4cfe7f28971ec06f1122f788e50650aa7b8d","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                    out, err \u003d utils.execute(*cmd_args,"},{"line_number":428,"context_line":"                                             check_exit_code\u003dcheck_exit_code)"},{"line_number":429,"context_line":"                else:"},{"line_number":430,"context_line":"                    out, err \u003d utils.execute(*cmd_args)"},{"line_number":431,"context_line":"                return out, err"},{"line_number":432,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":433,"context_line":"                with excutils.save_and_reraise_exception() as ctxt:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_8ccfff54","line":430,"in_reply_to":"1aa78d24_9438b8d4","updated":"2016-07-07 14:09:58.000000000","message":"Done","commit_id":"bdd7a5c6b2a2908db9fa38ef30c758577cb08c3b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b2c8ff6354f8bc4937f8ddfd245e30d9ee9ca83b","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            cmd_args.extend(command.split(\" \"))"},{"line_number":428,"context_line":"            try:"},{"line_number":429,"context_line":"                out, err \u003d utils.execute(*cmd_args,"},{"line_number":430,"context_line":"                                         check_exit_code\u003dcheck_exit_code)"},{"line_number":431,"context_line":"                return out, err"},{"line_number":432,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":433,"context_line":"                with excutils.save_and_reraise_exception() as ctxt:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_60f61790","line":430,"updated":"2016-07-07 14:21:51.000000000","message":"we should use the extra_args here :-)\n\nout, err \u003d utils.execute(*cmd_args, **extra_args)","commit_id":"7d1f5236edfd5fb04150d614a8e8604c1db3eea1"}],"releasenotes/notes/add-socat-console-ipmitool-ab4402ec976c5c96.yaml":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ef30896d069c677299a921f64eb6f68ef81d59cf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds socat serial console support to IPMItool. New drivers"},{"line_number":4,"context_line":"    pxe_ipmitool_socat for PXE + IPMItool + socat and agent_ipmitool_socat"},{"line_number":5,"context_line":"    for IPA + IPMItool + socat became available."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_516e2297","line":5,"range":{"start_line":5,"start_character":31,"end_line":5,"end_character":47},"updated":"2016-07-08 08:25:13.000000000","message":"nit: are now available\n\nI think it sounds better","commit_id":"ed21afc6dda8c829684edb888cc41f6a6a7bb20d"}]}