)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"f9b7023518826ad28f1d2a56f93e4a41f256e298","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-18 10:00:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support to validate iLO SSL certificate in iLO drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"iLO drivers do not validate iLO SSL certificate. This commit adds"},{"line_number":10,"context_line":"support in iLO drivers to validate iLO SSL certificate."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_ea3a5a33","line":7,"updated":"2016-07-25 17:40:28.000000000","message":"Same as release note comment.","commit_id":"d36bd6f74aa12f6d460fbf086893150a2dc92d63"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f567ca1c2d55b4554d5af62a75a3142adfeac301","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-18 10:00:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support to validate iLO SSL certificate in iLO drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"iLO drivers do not validate iLO SSL certificate. This commit adds"},{"line_number":10,"context_line":"support in iLO drivers to validate iLO SSL certificate."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_00d22f00","line":7,"in_reply_to":"dada55a8_ea3a5a33","updated":"2016-07-25 18:14:42.000000000","message":"Default Certificates iLO creates a self-signed certificate for use in SSL connections. Today, iLO drivers do not validate that certificate.\n\niLO drivers make call to iLO by passing \u0027verify\u003doff\u0027 to iLO if no SSL certificate is passed. It is the default behavior today.\n\nHence iLO drivers are enabling SSL certificate validation through the proposed change\n\nCurrent code references:\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/common.py#L249-L253\n\nhttps://github.com/openstack/proliantutils/blob/master/proliantutils/ilo/client.py#L61-L67\n\nhttps://github.com/openstack/proliantutils/blob/master/proliantutils/ilo/ris.py#L113-L121","commit_id":"d36bd6f74aa12f6d460fbf086893150a2dc92d63"}],"ironic/conf/ilo.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8a3cd61a6655e9d0e9f6cdf27a9a5d4172d07d71","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               default\u003d2,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Amount of time in seconds to wait in between power \u0027"},{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ilo_ca_file\u0027,"},{"line_number":82,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":83,"context_line":"]"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_ab6551e2","line":81,"updated":"2016-07-18 14:16:31.000000000","message":"please remove the \"ilo\" prefix, you\u0027re already in the \"ilo\" group","commit_id":"92ee33f058520d6d0618197e811904b91282ad9a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"993e6246d93812fc288d4a25a2731cae98b19a12","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               default\u003d2,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Amount of time in seconds to wait in between power \u0027"},{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ilo_ca_file\u0027,"},{"line_number":82,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":83,"context_line":"]"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_fa5271dc","line":81,"in_reply_to":"dada55a8_ab6551e2","updated":"2016-07-18 16:33:29.000000000","message":"Done","commit_id":"92ee33f058520d6d0618197e811904b91282ad9a"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8a3cd61a6655e9d0e9f6cdf27a9a5d4172d07d71","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        elif param \u003d\u003d \"ilo_ca_file\":"},{"line_number":216,"context_line":"            if value and not os.path.isfile(value):"},{"line_number":217,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":218,"context_line":"                    \u0027%(param)s \"%(value)s\" not found.\u0027) %"},{"line_number":219,"context_line":"                    {\u0027param\u0027: param, \u0027value\u0027: value})"},{"line_number":220,"context_line":"            d_info[param] \u003d value"},{"line_number":221,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_cb6885bd","line":218,"updated":"2016-07-18 14:16:31.000000000","message":"nit: \"is not\" or \"was not\"","commit_id":"92ee33f058520d6d0618197e811904b91282ad9a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"993e6246d93812fc288d4a25a2731cae98b19a12","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        elif param \u003d\u003d \"ilo_ca_file\":"},{"line_number":216,"context_line":"            if value and not os.path.isfile(value):"},{"line_number":217,"context_line":"                raise exception.InvalidParameterValue(_("},{"line_number":218,"context_line":"                    \u0027%(param)s \"%(value)s\" not found.\u0027) %"},{"line_number":219,"context_line":"                    {\u0027param\u0027: param, \u0027value\u0027: value})"},{"line_number":220,"context_line":"            d_info[param] \u003d value"},{"line_number":221,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_1a6dc598","line":218,"in_reply_to":"dada55a8_cb6885bd","updated":"2016-07-18 16:33:29.000000000","message":"Done","commit_id":"92ee33f058520d6d0618197e811904b91282ad9a"}],"releasenotes/notes/validate-ilo-certificates-3ab98bb8cfad7d60.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8a3cd61a6655e9d0e9f6cdf27a9a5d4172d07d71","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    drivers."},{"line_number":5,"context_line":"    New config parameter \u0027[ilo]/ilo_ca_file\u0027 added to"},{"line_number":6,"context_line":"    specify iLO CA certificate file."},{"line_number":7,"context_line":"    If \u0027ilo_ca_file\u0027 is specified, iLO drivers would"},{"line_number":8,"context_line":"    validate iLO SSL certificates."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dada55a8_0b63bddd","line":7,"updated":"2016-07-18 14:16:31.000000000","message":"s/would/will/","commit_id":"92ee33f058520d6d0618197e811904b91282ad9a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"993e6246d93812fc288d4a25a2731cae98b19a12","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    drivers."},{"line_number":5,"context_line":"    New config parameter \u0027[ilo]/ilo_ca_file\u0027 added to"},{"line_number":6,"context_line":"    specify iLO CA certificate file."},{"line_number":7,"context_line":"    If \u0027ilo_ca_file\u0027 is specified, iLO drivers would"},{"line_number":8,"context_line":"    validate iLO SSL certificates."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dada55a8_fa00b1ac","line":7,"in_reply_to":"dada55a8_0b63bddd","updated":"2016-07-18 16:33:29.000000000","message":"Done","commit_id":"92ee33f058520d6d0618197e811904b91282ad9a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"f9b7023518826ad28f1d2a56f93e4a41f256e298","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    New config parameter \u0027[ilo]/ca_file\u0027 added to"},{"line_number":6,"context_line":"    specify iLO CA certificate file."},{"line_number":7,"context_line":"    If \u0027ca_file\u0027 is specified, iLO drivers will validate"},{"line_number":8,"context_line":"    iLO SSL certificates."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_0a408ea4","line":8,"updated":"2016-07-25 17:40:28.000000000","message":"Well, hopefully it\u0027s already validating them, but this adds a config for custom CA certs. Can we change the wording here to reflect that?","commit_id":"d36bd6f74aa12f6d460fbf086893150a2dc92d63"}]}