)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"2bd66b84d74536276d5a3a9fc8b23bfc5d72673d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix iLO drivers temporarily for local_gb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch temporarily fixes the iLO drivers\u0027"},{"line_number":10,"context_line":"inspection to not replace operator provided local_gb"},{"line_number":11,"context_line":"if inspection is not able to get the disk size due to hardware"},{"line_number":12,"context_line":"limitation of disk data not available out-of-band."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_4638253e","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":22},"updated":"2016-07-14 05:59:23.000000000","message":"Let us not call it as a temporary fix.","commit_id":"ccc5e8e4f073c693895ba123e76d67e49d70d82f"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"2bd66b84d74536276d5a3a9fc8b23bfc5d72673d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"if inspection is not able to get the disk size due to hardware"},{"line_number":12,"context_line":"limitation of disk data not available out-of-band."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This workaround can be removed once the in-band inspection"},{"line_number":15,"context_line":"is supported in iLO drivers which is being addressed"},{"line_number":16,"context_line":"as part of https://review.openstack.org/201904."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_26023973","line":14,"updated":"2016-07-14 05:59:23.000000000","message":"I do not think that we should call this as a workaround. In general, it is not good ux to overwrite something if tools are not able to get info about it. we should overwrite only if we are sure that the info is 100% correct.\n\nI would suggest we do not revert it as there will be users not willing to use in-band discoveries and in that case, this will help them. Even if in-band is used, and if for some reason, say lack of storage drivers etc, disk size is not detected, it will still be needed to do its magic.","commit_id":"ccc5e8e4f073c693895ba123e76d67e49d70d82f"}],"ironic/drivers/modules/ilo/inspect.py":[{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"9df8657b223290ce1403eefe3453f3038116958b","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # This will be removed once we have inband inspection support for"},{"line_number":223,"context_line":"        # ilo drivers."},{"line_number":224,"context_line":"        if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and"},{"line_number":225,"context_line":"                task.node.properties[\u0027local_gb\u0027] \u003e 0):"},{"line_number":226,"context_line":"            result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d task.node.properties[\u0027local_gb\u0027]"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        properties \u003d result[\u0027properties\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_6aa98924","line":225,"range":{"start_line":225,"start_character":16,"end_line":225,"end_character":52},"updated":"2016-07-14 14:54:55.000000000","message":"There could also be a case where user has not registered local_gb property. We should check for that case as well.","commit_id":"ccc5e8e4f073c693895ba123e76d67e49d70d82f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8855d9a4bc10e9dc60a63bb8eaa6581f5b6f8dbb","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # updated the local_gb in node.properties prior to node inspection."},{"line_number":225,"context_line":"        # This will be removed once we have inband inspection support for"},{"line_number":226,"context_line":"        # ilo drivers."},{"line_number":227,"context_line":"        check_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        if check_local_gb:"},{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and"},{"line_number":230,"context_line":"                    task.node.properties[\u0027local_gb\u0027] \u003e 0):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_d75e9175","line":227,"updated":"2016-09-20 09:49:10.000000000","message":"s/check_local_gb/current_local_gb/","commit_id":"8eee448aaa58dd79219dbb4705d3ff1890c635a5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c674aa7c5f6e3ab01569447ca0482ea6ec21e4b9","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # updated the local_gb in node.properties prior to node inspection."},{"line_number":225,"context_line":"        # This will be removed once we have inband inspection support for"},{"line_number":226,"context_line":"        # ilo drivers."},{"line_number":227,"context_line":"        check_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        if check_local_gb:"},{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and"},{"line_number":230,"context_line":"                    task.node.properties[\u0027local_gb\u0027] \u003e 0):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_6d87ac12","line":227,"in_reply_to":"7a8ec9b2_d75e9175","updated":"2016-09-20 11:12:42.000000000","message":"Done","commit_id":"8eee448aaa58dd79219dbb4705d3ff1890c635a5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8855d9a4bc10e9dc60a63bb8eaa6581f5b6f8dbb","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        check_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        if check_local_gb:"},{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and"},{"line_number":230,"context_line":"                    task.node.properties[\u0027local_gb\u0027] \u003e 0):"},{"line_number":231,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d ("},{"line_number":232,"context_line":"                    task.node.properties[\u0027local_gb\u0027])"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_f7538d6a","line":230,"updated":"2016-09-20 09:49:10.000000000","message":"you can reuse value of current_local_gb","commit_id":"8eee448aaa58dd79219dbb4705d3ff1890c635a5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c674aa7c5f6e3ab01569447ca0482ea6ec21e4b9","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        check_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        if check_local_gb:"},{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and"},{"line_number":230,"context_line":"                    task.node.properties[\u0027local_gb\u0027] \u003e 0):"},{"line_number":231,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d ("},{"line_number":232,"context_line":"                    task.node.properties[\u0027local_gb\u0027])"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_8de158d3","line":230,"in_reply_to":"7a8ec9b2_f7538d6a","updated":"2016-09-20 11:12:42.000000000","message":"Done","commit_id":"8eee448aaa58dd79219dbb4705d3ff1890c635a5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8855d9a4bc10e9dc60a63bb8eaa6581f5b6f8dbb","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and"},{"line_number":230,"context_line":"                    task.node.properties[\u0027local_gb\u0027] \u003e 0):"},{"line_number":231,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d ("},{"line_number":232,"context_line":"                    task.node.properties[\u0027local_gb\u0027])"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        properties \u003d result[\u0027properties\u0027]"},{"line_number":235,"context_line":"        for known_property in self.ESSENTIAL_PROPERTIES:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_1751d962","line":232,"updated":"2016-09-20 09:49:10.000000000","message":"ditto","commit_id":"8eee448aaa58dd79219dbb4705d3ff1890c635a5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c674aa7c5f6e3ab01569447ca0482ea6ec21e4b9","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and"},{"line_number":230,"context_line":"                    task.node.properties[\u0027local_gb\u0027] \u003e 0):"},{"line_number":231,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d ("},{"line_number":232,"context_line":"                    task.node.properties[\u0027local_gb\u0027])"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        properties \u003d result[\u0027properties\u0027]"},{"line_number":235,"context_line":"        for known_property in self.ESSENTIAL_PROPERTIES:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_4dd8301e","line":232,"in_reply_to":"7a8ec9b2_1751d962","updated":"2016-09-20 11:12:42.000000000","message":"Done","commit_id":"8eee448aaa58dd79219dbb4705d3ff1890c635a5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"862b2acbfa3f49f973d44c9ce13a88f99e114e5e","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        # ilo drivers."},{"line_number":227,"context_line":"        current_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        if current_local_gb:"},{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and current_local_gb \u003e 0):"},{"line_number":230,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d current_local_gb"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        properties \u003d result[\u0027properties\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_0e4970b7","line":229,"updated":"2016-09-21 12:41:46.000000000","message":"I wonder if result[\u0027properties\u0027][\u0027local_gb\u0027] can be completely missing or None. If it\u0027s possible, you have to handle this case too.","commit_id":"f0cfd2d55f89b30f78d9b5061b56cb08904ccdad"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cd01e72fe3a3f4a20a120869a403016bc595e644","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        # ilo drivers."},{"line_number":227,"context_line":"        current_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        if current_local_gb:"},{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and current_local_gb \u003e 0):"},{"line_number":230,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d current_local_gb"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        properties \u003d result[\u0027properties\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_178895c4","line":229,"in_reply_to":"7a8ec9b2_0e4970b7","updated":"2016-09-22 03:53:26.000000000","message":"result[\u0027properties\u0027][\u0027local_gb\u0027]  will never be \u0027None\u0027. It would be 0 if not detected.\nhttps://github.com/openstack/proliantutils/blob/master/proliantutils/ilo/ribcl.py#L789\nhttps://github.com/openstack/proliantutils/blob/master/proliantutils/ilo/ribcl.py#L889-L938","commit_id":"f0cfd2d55f89b30f78d9b5061b56cb08904ccdad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"862b2acbfa3f49f973d44c9ce13a88f99e114e5e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        current_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        if current_local_gb:"},{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and current_local_gb \u003e 0):"},{"line_number":230,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d current_local_gb"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        properties \u003d result[\u0027properties\u0027]"},{"line_number":233,"context_line":"        for known_property in self.ESSENTIAL_PROPERTIES:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_2ec8ec21","line":230,"updated":"2016-09-21 12:41:46.000000000","message":"let\u0027s issue LOG.warning here, as we\u0027re hiding a potential problem","commit_id":"f0cfd2d55f89b30f78d9b5061b56cb08904ccdad"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cd01e72fe3a3f4a20a120869a403016bc595e644","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        current_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        if current_local_gb:"},{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and current_local_gb \u003e 0):"},{"line_number":230,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d current_local_gb"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        properties \u003d result[\u0027properties\u0027]"},{"line_number":233,"context_line":"        for known_property in self.ESSENTIAL_PROPERTIES:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_52f78b58","line":230,"in_reply_to":"7a8ec9b2_2ec8ec21","updated":"2016-09-22 03:53:26.000000000","message":"Done","commit_id":"f0cfd2d55f89b30f78d9b5061b56cb08904ccdad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"862b2acbfa3f49f973d44c9ce13a88f99e114e5e","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and current_local_gb \u003e 0):"},{"line_number":230,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d current_local_gb"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        properties \u003d result[\u0027properties\u0027]"},{"line_number":233,"context_line":"        for known_property in self.ESSENTIAL_PROPERTIES:"},{"line_number":234,"context_line":"            inspected_properties[known_property] \u003d properties[known_property]"},{"line_number":235,"context_line":"        node_properties \u003d task.node.properties"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_4ecd3830","line":232,"updated":"2016-09-21 12:41:46.000000000","message":"if you move your new code below this line, it\u0027ll save you typing result[...], you\u0027ll just use properties","commit_id":"f0cfd2d55f89b30f78d9b5061b56cb08904ccdad"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cd01e72fe3a3f4a20a120869a403016bc595e644","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            if(result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d\u003d 0 and current_local_gb \u003e 0):"},{"line_number":230,"context_line":"                result[\u0027properties\u0027][\u0027local_gb\u0027] \u003d current_local_gb"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        properties \u003d result[\u0027properties\u0027]"},{"line_number":233,"context_line":"        for known_property in self.ESSENTIAL_PROPERTIES:"},{"line_number":234,"context_line":"            inspected_properties[known_property] \u003d properties[known_property]"},{"line_number":235,"context_line":"        node_properties \u003d task.node.properties"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_1d3a13ce","line":232,"in_reply_to":"7a8ec9b2_4ecd3830","updated":"2016-09-22 03:53:26.000000000","message":"Done","commit_id":"f0cfd2d55f89b30f78d9b5061b56cb08904ccdad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5ecc16ef35720d04b331ec21e27993f09130d47d","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        inspected_properties \u003d {}"},{"line_number":219,"context_line":"        result \u003d _get_essential_properties(task.node, ilo_object)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Added a temporary hook for OOB inspection to not update \u0027local_gb\u0027"},{"line_number":222,"context_line":"        # for hardwares if the storage is a \"Direct Attached Storage\" or"},{"line_number":223,"context_line":"        # \"Dynamic Smart Array Controllers\" and the operator has manually"},{"line_number":224,"context_line":"        # updated the local_gb in node.properties prior to node inspection."}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_692270bb","line":221,"updated":"2016-09-22 09:00:10.000000000","message":"s/Added a/A/","commit_id":"3881d4ed58146f5a6e9b36b20fec58605e16fbc1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"68fdc0f028c95123b0b41552941f77a873f1311c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        inspected_properties \u003d {}"},{"line_number":219,"context_line":"        result \u003d _get_essential_properties(task.node, ilo_object)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Added a temporary hook for OOB inspection to not update \u0027local_gb\u0027"},{"line_number":222,"context_line":"        # for hardwares if the storage is a \"Direct Attached Storage\" or"},{"line_number":223,"context_line":"        # \"Dynamic Smart Array Controllers\" and the operator has manually"},{"line_number":224,"context_line":"        # updated the local_gb in node.properties prior to node inspection."}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_3fd17afc","line":221,"in_reply_to":"5a8bc5a2_692270bb","updated":"2016-09-22 09:29:53.000000000","message":"Done","commit_id":"3881d4ed58146f5a6e9b36b20fec58605e16fbc1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5ecc16ef35720d04b331ec21e27993f09130d47d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        result \u003d _get_essential_properties(task.node, ilo_object)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Added a temporary hook for OOB inspection to not update \u0027local_gb\u0027"},{"line_number":222,"context_line":"        # for hardwares if the storage is a \"Direct Attached Storage\" or"},{"line_number":223,"context_line":"        # \"Dynamic Smart Array Controllers\" and the operator has manually"},{"line_number":224,"context_line":"        # updated the local_gb in node.properties prior to node inspection."},{"line_number":225,"context_line":"        # This will be removed once we have inband inspection support for"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_892fbca0","line":222,"updated":"2016-09-22 09:00:10.000000000","message":"s/hardwares/hardware/","commit_id":"3881d4ed58146f5a6e9b36b20fec58605e16fbc1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"68fdc0f028c95123b0b41552941f77a873f1311c","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        result \u003d _get_essential_properties(task.node, ilo_object)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Added a temporary hook for OOB inspection to not update \u0027local_gb\u0027"},{"line_number":222,"context_line":"        # for hardwares if the storage is a \"Direct Attached Storage\" or"},{"line_number":223,"context_line":"        # \"Dynamic Smart Array Controllers\" and the operator has manually"},{"line_number":224,"context_line":"        # updated the local_gb in node.properties prior to node inspection."},{"line_number":225,"context_line":"        # This will be removed once we have inband inspection support for"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_7fdb021c","line":222,"in_reply_to":"5a8bc5a2_892fbca0","updated":"2016-09-22 09:29:53.000000000","message":"Done","commit_id":"3881d4ed58146f5a6e9b36b20fec58605e16fbc1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5ecc16ef35720d04b331ec21e27993f09130d47d","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        current_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        properties \u003d result[\u0027properties\u0027]"},{"line_number":229,"context_line":"        if current_local_gb:"},{"line_number":230,"context_line":"            if(properties[\u0027local_gb\u0027] \u003d\u003d 0 and current_local_gb \u003e 0):"},{"line_number":231,"context_line":"                properties[\u0027local_gb\u0027] \u003d current_local_gb"},{"line_number":232,"context_line":"                LOG.warning(_LW(\u0027Could not discover size of disk on the node \u0027"},{"line_number":233,"context_line":"                                \u0027%s. Value of `properties/local_gb` of the \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_a92c78ac","line":230,"updated":"2016-09-22 09:00:10.000000000","message":"space needed after \"if\", brackets are redundant","commit_id":"3881d4ed58146f5a6e9b36b20fec58605e16fbc1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"68fdc0f028c95123b0b41552941f77a873f1311c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        current_local_gb \u003d task.node.properties.get(\u0027local_gb\u0027)"},{"line_number":228,"context_line":"        properties \u003d result[\u0027properties\u0027]"},{"line_number":229,"context_line":"        if current_local_gb:"},{"line_number":230,"context_line":"            if(properties[\u0027local_gb\u0027] \u003d\u003d 0 and current_local_gb \u003e 0):"},{"line_number":231,"context_line":"                properties[\u0027local_gb\u0027] \u003d current_local_gb"},{"line_number":232,"context_line":"                LOG.warning(_LW(\u0027Could not discover size of disk on the node \u0027"},{"line_number":233,"context_line":"                                \u0027%s. Value of `properties/local_gb` of the \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a8bc5a2_bf782afa","line":230,"in_reply_to":"5a8bc5a2_a92c78ac","updated":"2016-09-22 09:29:53.000000000","message":"Done","commit_id":"3881d4ed58146f5a6e9b36b20fec58605e16fbc1"}],"ironic/tests/unit/drivers/modules/ilo/test_inspect.py":[{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"2bd66b84d74536276d5a3a9fc8b23bfc5d72673d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            get_capabilities_mock.assert_called_once_with(task.node,"},{"line_number":133,"context_line":"                                                          ilo_object_mock)"},{"line_number":134,"context_line":"            create_port_mock.assert_called_once_with(task.node, macs)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @mock.patch.object(ilo_inspect, \u0027_get_capabilities\u0027, spec_set\u003dTrue,"},{"line_number":138,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_a624690e","line":135,"updated":"2016-07-14 05:59:23.000000000","message":"remove extra blank line.","commit_id":"ccc5e8e4f073c693895ba123e76d67e49d70d82f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1800ba19d23c57fde69f1dfaec77fb2cf277314b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            get_capabilities_mock.assert_called_once_with(task.node,"},{"line_number":133,"context_line":"                                                          ilo_object_mock)"},{"line_number":134,"context_line":"            create_port_mock.assert_called_once_with(task.node, macs)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @mock.patch.object(ilo_inspect, \u0027_get_capabilities\u0027, spec_set\u003dTrue,"},{"line_number":138,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_31ce1284","line":135,"in_reply_to":"1aa78d24_a624690e","updated":"2016-07-27 14:44:15.000000000","message":"++  This is the gate failure.","commit_id":"ccc5e8e4f073c693895ba123e76d67e49d70d82f"}],"releasenotes/notes/ilo-fix-inspection-b169ad0a22aea2ff.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"862b2acbfa3f49f973d44c9ce13a88f99e114e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes iLO drivers inspection to not to overwrite"},{"line_number":4,"context_line":"    node property \u0027local_gb\u0027 when it is not detected."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a8ec9b2_6ece742e","line":3,"updated":"2016-09-21 12:41:46.000000000","message":"\"overwrite existing...\"","commit_id":"f0cfd2d55f89b30f78d9b5061b56cb08904ccdad"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cd01e72fe3a3f4a20a120869a403016bc595e644","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes iLO drivers inspection to not to overwrite"},{"line_number":4,"context_line":"    node property \u0027local_gb\u0027 when it is not detected."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a8ec9b2_3753d1e3","line":3,"in_reply_to":"7a8ec9b2_6ece742e","updated":"2016-09-22 03:53:26.000000000","message":"Done","commit_id":"f0cfd2d55f89b30f78d9b5061b56cb08904ccdad"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ad3bc291845d0f77637dc1bdf69969c0d2419626","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes iLO drivers inspection to not to overwrite"},{"line_number":4,"context_line":"    existing node property \u0027local_gb\u0027 when it is not"},{"line_number":5,"context_line":"    detected."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_4e73f1b1","line":5,"updated":"2016-09-22 11:01:50.000000000","message":"How about: Fixes a bug in the iLO drivers\u0027 inspection where an existing ``local_gb`` node property was overwritten with \"0\" if not detected.","commit_id":"a073bcf8e06d7837d54f6704352a64bbcf8e081c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5ebb417555d2aacbf8b146d280c2e131db9bd8cd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes iLO drivers inspection to not to overwrite"},{"line_number":4,"context_line":"    existing node property \u0027local_gb\u0027 when it is not"},{"line_number":5,"context_line":"    detected."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_4ebbf172","line":5,"in_reply_to":"5a8bc5a2_4e73f1b1","updated":"2016-09-22 11:17:26.000000000","message":"Done","commit_id":"a073bcf8e06d7837d54f6704352a64bbcf8e081c"}]}
