)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"23ee5b28e3ed2e700c16f87a0e2991e174f32388","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0d63f31473776551550f917dbc7237564881f566"},{"line_number":13,"context_line":"Closes-bug:  #1603454"},{"line_number":14,"context_line":"Depends-On: I32e3d8ae5103d3a0f47a9d0aa3bb9464ff575d03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_5007b81b","line":14,"updated":"2016-09-01 10:42:02.000000000","message":"nit: may be removed patch was merged.","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"6b1792796959fdb5100a1e6bbe9ff681c88c9447","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0d63f31473776551550f917dbc7237564881f566"},{"line_number":13,"context_line":"Closes-bug:  #1603454"},{"line_number":14,"context_line":"Depends-On: I32e3d8ae5103d3a0f47a9d0aa3bb9464ff575d03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_b39c8b5e","line":14,"in_reply_to":"fa7ab95a_5007b81b","updated":"2016-09-01 11:29:41.000000000","message":"Done","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"}],"ironic/drivers/drac.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"037564739013f1307482c23feb4b4c68e43c7f92","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.driver_passthru_mapping \u003d {\u0027lookup\u0027: self.iscsi_vendor}"},{"line_number":54,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"},{"line_number":55,"context_line":"                                                 self.driver_passthru_mapping)"},{"line_number":56,"context_line":"        self.inspect \u003d inspect.DracInspect()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_96eb11b0","line":56,"updated":"2016-07-19 16:42:07.000000000","message":"I wonder if we should have two drivers: One with DRAC oob and another with inspector.\n\nBecause inspector does more things than the DRAC oob, so replacing it doesn\u0027t seem ideal. People may still want to use inspector with the DRAC machines.\n\nWhat about:\n\n class PXEDracDriver(base.BaseDriver):\n     ...\n\n\n class PXEDracInspectorDriver(PXEDracDriver):\n\n    def __init__(self):\n        super(PXEDracInspectorDriver, self).__init__()\n        self.inspect \u003d inspector.Inspector.create_if...","commit_id":"548c3ba00ab5f7c3568df30bc6ca953d16fc5862"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7fefa3d83bb4e02d050620778534bcd1c13ef3d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.driver_passthru_mapping \u003d {\u0027lookup\u0027: self.iscsi_vendor}"},{"line_number":54,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"},{"line_number":55,"context_line":"                                                 self.driver_passthru_mapping)"},{"line_number":56,"context_line":"        self.inspect \u003d inspect.DracInspect()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_abc71f63","line":56,"in_reply_to":"dada55a8_96eb11b0","updated":"2016-07-22 13:23:06.000000000","message":"Yeah, I was also wondering about it... Will change as you suggested.","commit_id":"548c3ba00ab5f7c3568df30bc6ca953d16fc5862"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d3ed71e9162c2964effe0a245f973f7a77921971","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.driver_passthru_mapping \u003d {\u0027lookup\u0027: self.iscsi_vendor}"},{"line_number":82,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"},{"line_number":83,"context_line":"                                                 self.driver_passthru_mapping)"},{"line_number":84,"context_line":"        self.inspect \u003d drac_inspect.DracInspect()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_ca0da2e9","line":84,"updated":"2016-08-29 16:31:33.000000000","message":"nit: Apparently the only difference in this class and PXEDracDriver is the \"inspect\" interface, perhaps we should just inherit it ?\n\ne.g\n\nclass PXEOOBInspectionDracDriver(PXEDracDriver):\n    \"\"\" ... \"\"\"\n    inspect \u003d drac_inspect.DracInspect()","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"c70f80caaa77cd6accffb28fb290c20d308c8b5f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.driver_passthru_mapping \u003d {\u0027lookup\u0027: self.iscsi_vendor}"},{"line_number":82,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"},{"line_number":83,"context_line":"                                                 self.driver_passthru_mapping)"},{"line_number":84,"context_line":"        self.inspect \u003d drac_inspect.DracInspect()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_a2004567","line":84,"in_reply_to":"fa7ab95a_ca0da2e9","updated":"2016-08-30 14:11:25.000000000","message":"good point!","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"}],"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"037564739013f1307482c23feb4b4c68e43c7f92","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":76,"context_line":"        properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        virtual_disks \u003d client.list_virtual_disks()"},{"line_number":79,"context_line":"        if virtual_disks:"},{"line_number":80,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(virtual_disks[0].size_mb / (2 ** 10))"},{"line_number":81,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_c2e14400","line":78,"updated":"2016-07-19 16:42:07.000000000","message":"A RAID device would fit as a virtual disk ? That\u0027s why we look at it first ?","commit_id":"548c3ba00ab5f7c3568df30bc6ca953d16fc5862"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7fefa3d83bb4e02d050620778534bcd1c13ef3d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":76,"context_line":"        properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        virtual_disks \u003d client.list_virtual_disks()"},{"line_number":79,"context_line":"        if virtual_disks:"},{"line_number":80,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(virtual_disks[0].size_mb / (2 ** 10))"},{"line_number":81,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_1d167555","line":78,"in_reply_to":"dada55a8_c2e14400","updated":"2016-07-22 13:23:06.000000000","message":"yeah, DRAC uses the term virtual disk for RAID volumes","commit_id":"548c3ba00ab5f7c3568df30bc6ca953d16fc5862"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"037564739013f1307482c23feb4b4c68e43c7f92","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        virtual_disks \u003d client.list_virtual_disks()"},{"line_number":79,"context_line":"        if virtual_disks:"},{"line_number":80,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(virtual_disks[0].size_mb / (2 ** 10))"},{"line_number":81,"context_line":"        else:"},{"line_number":82,"context_line":"            physical_disks \u003d client.list_physical_disks()"},{"line_number":83,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(physical_disks[0].size_mb / (2 ** 10))"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_c2ce64b3","line":80,"range":{"start_line":80,"start_character":68,"end_line":80,"end_character":77},"updated":"2016-07-19 16:42:07.000000000","message":"nit: 1024\n\n\nOr we could use the oslo units:\n\nfrom oslo_utils import units\n\nunits.M\nunits.Mi\nunits.Ki\nunits.K\n...","commit_id":"548c3ba00ab5f7c3568df30bc6ca953d16fc5862"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7fefa3d83bb4e02d050620778534bcd1c13ef3d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        virtual_disks \u003d client.list_virtual_disks()"},{"line_number":79,"context_line":"        if virtual_disks:"},{"line_number":80,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(virtual_disks[0].size_mb / (2 ** 10))"},{"line_number":81,"context_line":"        else:"},{"line_number":82,"context_line":"            physical_disks \u003d client.list_physical_disks()"},{"line_number":83,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(physical_disks[0].size_mb / (2 ** 10))"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_a0d73eec","line":80,"range":{"start_line":80,"start_character":68,"end_line":80,"end_character":77},"in_reply_to":"dada55a8_c2ce64b3","updated":"2016-07-22 13:23:06.000000000","message":"I used this form intentionally because I think it\u0027s easier to understand/compare. Using oslo_utils would work as well, so changing it...","commit_id":"548c3ba00ab5f7c3568df30bc6ca953d16fc5862"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"037564739013f1307482c23feb4b4c68e43c7f92","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(virtual_disks[0].size_mb / (2 ** 10))"},{"line_number":81,"context_line":"        else:"},{"line_number":82,"context_line":"            physical_disks \u003d client.list_physical_disks()"},{"line_number":83,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(physical_disks[0].size_mb / (2 ** 10))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":86,"context_line":"        missing_keys \u003d valid_keys - set(properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_c245c417","line":83,"range":{"start_line":83,"start_character":69,"end_line":83,"end_character":78},"updated":"2016-07-19 16:42:07.000000000","message":"ditto 1024","commit_id":"548c3ba00ab5f7c3568df30bc6ca953d16fc5862"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d7fefa3d83bb4e02d050620778534bcd1c13ef3d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(virtual_disks[0].size_mb / (2 ** 10))"},{"line_number":81,"context_line":"        else:"},{"line_number":82,"context_line":"            physical_disks \u003d client.list_physical_disks()"},{"line_number":83,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(physical_disks[0].size_mb / (2 ** 10))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":86,"context_line":"        missing_keys \u003d valid_keys - set(properties)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_e007767f","line":83,"range":{"start_line":83,"start_character":69,"end_line":83,"end_character":78},"in_reply_to":"dada55a8_c245c417","updated":"2016-07-22 13:23:06.000000000","message":"Done","commit_id":"548c3ba00ab5f7c3568df30bc6ca953d16fc5862"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d3ed71e9162c2964effe0a245f973f7a77921971","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            [memory.size_mb for memory in client.list_memory()])"},{"line_number":75,"context_line":"        cpus \u003d client.list_cpus()"},{"line_number":76,"context_line":"        properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":77,"context_line":"        properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        virtual_disks \u003d client.list_virtual_disks()"},{"line_number":80,"context_line":"        if virtual_disks:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_1d3fd624","line":77,"range":{"start_line":77,"start_character":45,"end_line":77,"end_character":59},"updated":"2016-08-29 16:31:33.000000000","message":"Will the \"arch64\" attribute be always present, even if it\u0027s \u0027x86\u0027 ?\n\nOtherwise we should do: hasattr(cpus[0], \u0027arch64\u0027)","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3ff683ce1d495ee5495924ffc59c1e7d4c7adcf","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            [memory.size_mb for memory in client.list_memory()])"},{"line_number":75,"context_line":"        cpus \u003d client.list_cpus()"},{"line_number":76,"context_line":"        properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":77,"context_line":"        properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        virtual_disks \u003d client.list_virtual_disks()"},{"line_number":80,"context_line":"        if virtual_disks:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_15bf6daa","line":77,"range":{"start_line":77,"start_character":45,"end_line":77,"end_character":59},"in_reply_to":"fa7ab95a_1d3fd624","updated":"2016-08-30 13:24:11.000000000","message":"yes, it\u0027s a boolean flag","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"c70f80caaa77cd6accffb28fb290c20d308c8b5f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            [memory.size_mb for memory in client.list_memory()])"},{"line_number":75,"context_line":"        cpus \u003d client.list_cpus()"},{"line_number":76,"context_line":"        properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":77,"context_line":"        properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        virtual_disks \u003d client.list_virtual_disks()"},{"line_number":80,"context_line":"        if virtual_disks:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_e2524d66","line":77,"range":{"start_line":77,"start_character":45,"end_line":77,"end_character":59},"in_reply_to":"fa7ab95a_1d3fd624","updated":"2016-08-30 14:11:25.000000000","message":"yes, it\u0027s always present. for x86, it\u0027s value will be False","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d3ed71e9162c2964effe0a245f973f7a77921971","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(virtual_disks[0].size_mb / units.Ki)"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            physical_disks \u003d client.list_physical_disks()"},{"line_number":84,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(physical_disks[0].size_mb / units.Ki)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":87,"context_line":"        missing_keys \u003d valid_keys - set(properties)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_5d8f9ecb","line":84,"updated":"2016-08-29 16:31:33.000000000","message":"It\u0027s unlikely, but I think we should test the \"physical_disks\" list before trying to access it\u0027s index.\n\n else:\n     physical_disks \u003d client.list...\n     if not physical_disks:\n         raise exception.HardwareInspectionFailure(...)\n     properties[\u0027local_gb] \u003d ...","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3ff683ce1d495ee5495924ffc59c1e7d4c7adcf","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(virtual_disks[0].size_mb / units.Ki)"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            physical_disks \u003d client.list_physical_disks()"},{"line_number":84,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(physical_disks[0].size_mb / units.Ki)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":87,"context_line":"        missing_keys \u003d valid_keys - set(properties)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_f5da0916","line":84,"in_reply_to":"fa7ab95a_5d8f9ecb","updated":"2016-08-30 13:24:11.000000000","message":"+1, just in case","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"c70f80caaa77cd6accffb28fb290c20d308c8b5f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(virtual_disks[0].size_mb / units.Ki)"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            physical_disks \u003d client.list_physical_disks()"},{"line_number":84,"context_line":"            properties[\u0027local_gb\u0027] \u003d int(physical_disks[0].size_mb / units.Ki)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":87,"context_line":"        missing_keys \u003d valid_keys - set(properties)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_75a43907","line":84,"in_reply_to":"fa7ab95a_5d8f9ecb","updated":"2016-08-30 14:11:25.000000000","message":"Done","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3ff683ce1d495ee5495924ffc59c1e7d4c7adcf","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                             \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":105,"context_line":"                         {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":106,"context_line":"            except exception.MACAlreadyExists:"},{"line_number":107,"context_line":"                LOG.warning(_LW(\u0027Port already exists with MAC address %(mac)s \u0027"},{"line_number":108,"context_line":"                                \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":109,"context_line":"                            {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        LOG.info(_LI(\u0027Node successfully %s inspected.\u0027), node.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_750b597d","line":108,"range":{"start_line":107,"start_character":16,"end_line":108,"end_character":76},"updated":"2016-08-30 13:24:11.000000000","message":"note: it might also exist for another node, not sure if we really have to check for it","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"c70f80caaa77cd6accffb28fb290c20d308c8b5f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                             \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":105,"context_line":"                         {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":106,"context_line":"            except exception.MACAlreadyExists:"},{"line_number":107,"context_line":"                LOG.warning(_LW(\u0027Port already exists with MAC address %(mac)s \u0027"},{"line_number":108,"context_line":"                                \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":109,"context_line":"                            {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        LOG.info(_LI(\u0027Node successfully %s inspected.\u0027), node.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_f880408d","line":108,"range":{"start_line":107,"start_character":16,"end_line":108,"end_character":76},"in_reply_to":"fa7ab95a_750b597d","updated":"2016-08-30 14:11:25.000000000","message":"you mean the warning message is unnecessary?","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2daba1c1f7a2941a9863fca84aad8356e6640b3d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":63,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":64,"context_line":"                 hardware properties."},{"line_number":65,"context_line":"        :returns: resulting state of the inspection i.e. states.MANAGEABLE"},{"line_number":66,"context_line":"                  or None."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_05ba9ec0","line":65,"updated":"2016-08-31 09:57:35.000000000","message":"returns only states.MANAGEABLE","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9dea979b4897ce11187cf2a93a39813bb47ae945","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":63,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":64,"context_line":"                 hardware properties."},{"line_number":65,"context_line":"        :returns: resulting state of the inspection i.e. states.MANAGEABLE"},{"line_number":66,"context_line":"                  or None."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_41e81017","line":65,"in_reply_to":"fa7ab95a_05ba9ec0","updated":"2016-08-31 12:05:26.000000000","message":"Done","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b7dc58d204a8342ef7c42b0287637059a024d799","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        properties \u003d {}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        properties[\u0027memory_mb\u0027] \u003d sum("},{"line_number":74,"context_line":"            [memory.size_mb for memory in client.list_memory()])"},{"line_number":75,"context_line":"        cpus \u003d client.list_cpus()"},{"line_number":76,"context_line":"        properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":77,"context_line":"        properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_41873012","line":74,"updated":"2016-08-31 11:51:40.000000000","message":"Should we wrap these drac client calls in a try except to convert them to an IronicException subclass?","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9dea979b4897ce11187cf2a93a39813bb47ae945","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        properties \u003d {}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        properties[\u0027memory_mb\u0027] \u003d sum("},{"line_number":74,"context_line":"            [memory.size_mb for memory in client.list_memory()])"},{"line_number":75,"context_line":"        cpus \u003d client.list_cpus()"},{"line_number":76,"context_line":"        properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":77,"context_line":"        properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_84406609","line":74,"in_reply_to":"fa7ab95a_41873012","updated":"2016-08-31 12:05:26.000000000","message":"Done","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"80aa6d13d9b2f1219cf9909a01ffe09c0cea6b05","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            physical_disks \u003d client.list_physical_disks()"},{"line_number":84,"context_line":"            if physical_disks:"},{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    physical_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":89,"context_line":"        missing_keys \u003d valid_keys - set(properties)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_e0295a9c","line":86,"updated":"2016-08-30 15:59:16.000000000","message":"nit: Would be good to have a warning (or even an exception!?) when neither a virtual disk (raid right!?) or physical disk is found in the node.","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9dea979b4897ce11187cf2a93a39813bb47ae945","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            physical_disks \u003d client.list_physical_disks()"},{"line_number":84,"context_line":"            if physical_disks:"},{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    physical_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":89,"context_line":"        missing_keys \u003d valid_keys - set(properties)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_410490c5","line":86,"in_reply_to":"fa7ab95a_e0295a9c","updated":"2016-08-31 12:05:26.000000000","message":"it\u0027s already raising an exception on L94","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2daba1c1f7a2941a9863fca84aad8356e6640b3d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    physical_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":89,"context_line":"        missing_keys \u003d valid_keys - set(properties)"},{"line_number":90,"context_line":"        if missing_keys:"},{"line_number":91,"context_line":"            error \u003d (_(\u0027Failed to discover the following properties: \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_973ee527","line":88,"updated":"2016-08-31 09:57:35.000000000","message":"If the code above does not raise an exception only \u0027local_gb\u0027 can be missing, l88-94 not needed if you raise exception as Lucas propose.","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c2aa26cf8a441e052107fedbe1dd6ee81fdf3e5a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    physical_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":89,"context_line":"        missing_keys \u003d valid_keys - set(properties)"},{"line_number":90,"context_line":"        if missing_keys:"},{"line_number":91,"context_line":"            error \u003d (_(\u0027Failed to discover the following properties: \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_b2f76cf4","line":88,"in_reply_to":"fa7ab95a_01f2889a","updated":"2016-08-31 12:37:41.000000000","message":"All keys except \u0027local_gb\u0027 will be present if no exception above, no error to check all but it\u0027s not needed.","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"682e60148f8565bd584b9f144deaf864bd46b6da","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    physical_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":89,"context_line":"        missing_keys \u003d valid_keys - set(properties)"},{"line_number":90,"context_line":"        if missing_keys:"},{"line_number":91,"context_line":"            error \u003d (_(\u0027Failed to discover the following properties: \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_dac33437","line":88,"in_reply_to":"fa7ab95a_973ee527","updated":"2016-08-31 10:06:38.000000000","message":"Agreed, let\u0027s raise an exception at L86 if no virtual or physical disks are found and get rid of this conditional here.","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9dea979b4897ce11187cf2a93a39813bb47ae945","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    physical_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":89,"context_line":"        missing_keys \u003d valid_keys - set(properties)"},{"line_number":90,"context_line":"        if missing_keys:"},{"line_number":91,"context_line":"            error \u003d (_(\u0027Failed to discover the following properties: \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_01f2889a","line":88,"in_reply_to":"fa7ab95a_dac33437","updated":"2016-08-31 12:05:26.000000000","message":"It\u0027s better to check for all required keys rather than only for disks, not?","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"80aa6d13d9b2f1219cf9909a01ffe09c0cea6b05","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                             \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":107,"context_line":"                         {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":108,"context_line":"            except exception.MACAlreadyExists:"},{"line_number":109,"context_line":"                LOG.warning(_LW(\u0027Port already exists with MAC address %(mac)s \u0027"},{"line_number":110,"context_line":"                                \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":111,"context_line":"                            {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(_LI(\u0027Node successfully %s inspected.\u0027), node.uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_8de60642","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":76},"updated":"2016-08-30 15:59:16.000000000","message":"nit: Following up the previous patch-set...\n\nI think that having a warning message is important but the message can be misleading because the port with that mac address doesn\u0027t necessarily needs to be registered with the node being inspected, it could belong to another node (if the nic was moved around).\n\nSo, we could drop the \"... for node\" bit and have a message along the lines:\n\n\u0027Failed to create a port with MAC address %(mac)s when inspecting the node %(node_uuid)s because the address is already registered\u0027","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"b7dc58d204a8342ef7c42b0287637059a024d799","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                             \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":107,"context_line":"                         {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":108,"context_line":"            except exception.MACAlreadyExists:"},{"line_number":109,"context_line":"                LOG.warning(_LW(\u0027Port already exists with MAC address %(mac)s \u0027"},{"line_number":110,"context_line":"                                \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":111,"context_line":"                            {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(_LI(\u0027Node successfully %s inspected.\u0027), node.uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_7cc9405a","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":76},"in_reply_to":"fa7ab95a_052ffef6","updated":"2016-08-31 11:51:40.000000000","message":"+1","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2daba1c1f7a2941a9863fca84aad8356e6640b3d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                             \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":107,"context_line":"                         {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":108,"context_line":"            except exception.MACAlreadyExists:"},{"line_number":109,"context_line":"                LOG.warning(_LW(\u0027Port already exists with MAC address %(mac)s \u0027"},{"line_number":110,"context_line":"                                \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":111,"context_line":"                            {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(_LI(\u0027Node successfully %s inspected.\u0027), node.uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_052ffef6","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":76},"in_reply_to":"fa7ab95a_8de60642","updated":"2016-08-31 09:57:35.000000000","message":"+1","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9dea979b4897ce11187cf2a93a39813bb47ae945","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                             \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":107,"context_line":"                         {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":108,"context_line":"            except exception.MACAlreadyExists:"},{"line_number":109,"context_line":"                LOG.warning(_LW(\u0027Port already exists with MAC address %(mac)s \u0027"},{"line_number":110,"context_line":"                                \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":111,"context_line":"                            {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(_LI(\u0027Node successfully %s inspected.\u0027), node.uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_61cb541f","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":76},"in_reply_to":"fa7ab95a_8de60642","updated":"2016-08-31 12:05:26.000000000","message":"Thanks for the explanation, makes sense!","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2daba1c1f7a2941a9863fca84aad8356e6640b3d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":111,"context_line":"                            {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(_LI(\u0027Node successfully %s inspected.\u0027), node.uuid)"},{"line_number":114,"context_line":"        return states.MANAGEABLE"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_25fde26e","line":113,"updated":"2016-08-31 09:57:35.000000000","message":"\u0027Node %s successfully inspected.\u0027","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9dea979b4897ce11187cf2a93a39813bb47ae945","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                \u0027for node %(node_uuid)s during inspection\u0027),"},{"line_number":111,"context_line":"                            {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        LOG.info(_LI(\u0027Node successfully %s inspected.\u0027), node.uuid)"},{"line_number":114,"context_line":"        return states.MANAGEABLE"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_c13ee028","line":113,"in_reply_to":"fa7ab95a_25fde26e","updated":"2016-08-31 12:05:26.000000000","message":"Done","commit_id":"c9c07a8009f8c76586b71200ec635dfa13c41c4f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"23ee5b28e3ed2e700c16f87a0e2991e174f32388","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        properties \u003d {}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            properties[\u0027memory_mb\u0027] \u003d sum("},{"line_number":78,"context_line":"                [memory.size_mb for memory in client.list_memory()])"},{"line_number":79,"context_line":"            cpus \u003d client.list_cpus()"},{"line_number":80,"context_line":"            properties[\u0027cpus\u0027] \u003d len(cpus)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_f0b9ac7a","line":77,"updated":"2016-09-01 10:42:02.000000000","message":"L77-L81 can\u0027t raise clientexception might be moved outside ot try/catch block.","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"6b1792796959fdb5100a1e6bbe9ff681c88c9447","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        properties \u003d {}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            properties[\u0027memory_mb\u0027] \u003d sum("},{"line_number":78,"context_line":"                [memory.size_mb for memory in client.list_memory()])"},{"line_number":79,"context_line":"            cpus \u003d client.list_cpus()"},{"line_number":80,"context_line":"            properties[\u0027cpus\u0027] \u003d len(cpus)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_b323aba6","line":77,"in_reply_to":"fa7ab95a_f0b9ac7a","updated":"2016-09-01 11:29:41.000000000","message":"Both L78 and L79 can raise that exception.","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e138977d682abf06f6cf9c5912750ce20deda308","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            virtual_disks \u003d client.list_virtual_disks()"},{"line_number":84,"context_line":"            if virtual_disks:"},{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    virtual_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                physical_disks \u003d client.list_physical_disks()"},{"line_number":89,"context_line":"                if physical_disks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_8fedd390","line":86,"range":{"start_line":86,"start_character":45,"end_line":86,"end_character":46},"updated":"2016-08-31 15:27:37.000000000","message":"nit - could do // without int conversion. Do we want to sort this before doing [0]?","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6a835fe285e09166eb87482fea2a8ae8d1e3c5cb","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            virtual_disks \u003d client.list_virtual_disks()"},{"line_number":84,"context_line":"            if virtual_disks:"},{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    virtual_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                physical_disks \u003d client.list_physical_disks()"},{"line_number":89,"context_line":"                if physical_disks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_a59e04b6","line":86,"range":{"start_line":86,"start_character":45,"end_line":86,"end_character":46},"in_reply_to":"fa7ab95a_83c4a340","updated":"2016-09-01 10:09:14.000000000","message":"Hm, to get the biggest disk? Because now you just get the first one no matter how big it is. I don\u0027t know much about inspection, but here is what happens in the inspector - https://github.com/openstack/ironic-inspector/blob/6a1083d7a1e4884bf435e34388b96b60291fe6a0/ironic_inspector/plugins/standard.py#L97-L104\n\nIs it possible to make something similar here?","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"f5998043dc90a3371c450667f7b570c78a065b1c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            virtual_disks \u003d client.list_virtual_disks()"},{"line_number":84,"context_line":"            if virtual_disks:"},{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    virtual_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                physical_disks \u003d client.list_physical_disks()"},{"line_number":89,"context_line":"                if physical_disks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_83c4a340","line":86,"range":{"start_line":86,"start_character":45,"end_line":86,"end_character":46},"in_reply_to":"fa7ab95a_8fedd390","updated":"2016-09-01 07:58:56.000000000","message":"int conversion is for having a consistent value between py2 and py3.\n\nwhat would be the purpose of sorting?","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"6b1792796959fdb5100a1e6bbe9ff681c88c9447","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            virtual_disks \u003d client.list_virtual_disks()"},{"line_number":84,"context_line":"            if virtual_disks:"},{"line_number":85,"context_line":"                properties[\u0027local_gb\u0027] \u003d int("},{"line_number":86,"context_line":"                    virtual_disks[0].size_mb / units.Ki)"},{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                physical_disks \u003d client.list_physical_disks()"},{"line_number":89,"context_line":"                if physical_disks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_13a0d79e","line":86,"range":{"start_line":86,"start_character":45,"end_line":86,"end_character":46},"in_reply_to":"fa7ab95a_a59e04b6","updated":"2016-09-01 11:29:41.000000000","message":"I checked how root device is detected with inspector: https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/utils.py#L290-L307\n\nI will update the patch.","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e138977d682abf06f6cf9c5912750ce20deda308","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                physical_disks \u003d client.list_physical_disks()"},{"line_number":89,"context_line":"                if physical_disks:"},{"line_number":90,"context_line":"                    properties[\u0027local_gb\u0027] \u003d int("},{"line_number":91,"context_line":"                        physical_disks[0].size_mb / units.Ki)"},{"line_number":92,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":93,"context_line":"            LOG.error(_LE(\u0027DRAC driver failed to introspect node \u0027"},{"line_number":94,"context_line":"                          \u0027%(node_uuid)s. Reason: %(error)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_6ff96f4d","line":91,"range":{"start_line":91,"start_character":50,"end_line":91,"end_character":51},"updated":"2016-08-31 15:27:37.000000000","message":"ditto","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"f5998043dc90a3371c450667f7b570c78a065b1c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                physical_disks \u003d client.list_physical_disks()"},{"line_number":89,"context_line":"                if physical_disks:"},{"line_number":90,"context_line":"                    properties[\u0027local_gb\u0027] \u003d int("},{"line_number":91,"context_line":"                        physical_disks[0].size_mb / units.Ki)"},{"line_number":92,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":93,"context_line":"            LOG.error(_LE(\u0027DRAC driver failed to introspect node \u0027"},{"line_number":94,"context_line":"                          \u0027%(node_uuid)s. Reason: %(error)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_a3a8c778","line":91,"range":{"start_line":91,"start_character":50,"end_line":91,"end_character":51},"in_reply_to":"fa7ab95a_6ff96f4d","updated":"2016-09-01 07:58:56.000000000","message":"same here","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"524da6891135553e398c8d257df3776465c63477","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":99,"context_line":"        missing_keys \u003d valid_keys - set(properties)"},{"line_number":100,"context_line":"        if missing_keys:"},{"line_number":101,"context_line":"            error \u003d (_(\u0027Failed to discover the following properties: \u0027"},{"line_number":102,"context_line":"                       \u0027%(missing_keys)s\u0027) %"},{"line_number":103,"context_line":"                     {\u0027missing_keys\u0027: \u0027, \u0027.join(missing_keys)})"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_cd01b13b","line":100,"updated":"2016-08-31 12:52:35.000000000","message":"Following up the previous patch-set:\n\n\u003clucasagomes\u003e ifarkas, will do\n\u003clucasagomes\u003e ifarkas, I think the idea there is that, all the other essential values (memory, arch and cpu) will always be present, unless an exception is raised\n\u003clucasagomes\u003e only the disks might be None\n\u003cifarkas\u003e lucasagomes, yeah, that\u0027s true for now\n\u003clucasagomes\u003e so instead of having that condition checking the 4 properties, you can only assert if a disk have been found or not (then raise something)\n\u003clucasagomes\u003e ifarkas, in any case, it\u0027s not a big deal\n\n...\n\nAnyway it\u0027s not a big deal to check for all properties and probably is less error prone in case something change on the other fields, so I\u0027m fine leaving it.","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"23ee5b28e3ed2e700c16f87a0e2991e174f32388","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        node.properties \u003d dict(node.properties, **properties)"},{"line_number":107,"context_line":"        node.save()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        nics \u003d client.list_nics()"},{"line_number":110,"context_line":"        for nic in nics:"},{"line_number":111,"context_line":"            try:"},{"line_number":112,"context_line":"                port \u003d objects.Port(task.context, address\u003dnic.mac,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_30d794c0","line":109,"range":{"start_line":109,"start_character":7,"end_line":109,"end_character":33},"updated":"2016-09-01 10:42:02.000000000","message":"Need to wrap with try/catch to except clientexception.","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"6b1792796959fdb5100a1e6bbe9ff681c88c9447","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        node.properties \u003d dict(node.properties, **properties)"},{"line_number":107,"context_line":"        node.save()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        nics \u003d client.list_nics()"},{"line_number":110,"context_line":"        for nic in nics:"},{"line_number":111,"context_line":"            try:"},{"line_number":112,"context_line":"                port \u003d objects.Port(task.context, address\u003dnic.mac,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_33723b4a","line":109,"range":{"start_line":109,"start_character":7,"end_line":109,"end_character":33},"in_reply_to":"fa7ab95a_30d794c0","updated":"2016-09-01 11:29:41.000000000","message":"good point","commit_id":"a99ca771215666fed1418c8e1713aa1279a132db"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9cf5ccfc518fe75aa419e3339bc48e0c38e35c1b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                properties[\u0027local_gb\u0027] \u003d int(root_disk.size_mb / units.Ki)"},{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                physical_disks \u003d client.list_physical_disks()"},{"line_number":89,"context_line":"                root_disk \u003d self._guess_root_disk(physical_disks)"},{"line_number":90,"context_line":"                if root_disk:"},{"line_number":91,"context_line":"                    properties[\u0027local_gb\u0027] \u003d int("},{"line_number":92,"context_line":"                        root_disk.size_mb / units.Ki)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_1ddfcb3a","line":89,"updated":"2016-09-02 09:39:01.000000000","message":"Nice one on using the base method to consistently find the appropriated disk","commit_id":"380a0f76dd8a3dd48bcbad246aff662d23bd08fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9cf5ccfc518fe75aa419e3339bc48e0c38e35c1b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            LOG.error(_LE(\u0027DRAC driver failed to introspect node \u0027"},{"line_number":95,"context_line":"                          \u0027%(node_uuid)s. Reason: %(error)s.\u0027),"},{"line_number":96,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":97,"context_line":"            raise exception.DracOperationError(error\u003dexc)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":100,"context_line":"        missing_keys \u003d valid_keys - set(properties)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_1dad0b9b","line":97,"range":{"start_line":97,"start_character":28,"end_line":97,"end_character":46},"updated":"2016-09-02 09:39:01.000000000","message":"Should this be HardwareInspectionFailure ?\n\nThe docstring doesn\u0027t mention raising DracOperationError for this method","commit_id":"380a0f76dd8a3dd48bcbad246aff662d23bd08fe"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"32b9b70db9032ecfd750c5687f725d10fd2b58c9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            LOG.error(_LE(\u0027DRAC driver failed to introspect node \u0027"},{"line_number":95,"context_line":"                          \u0027%(node_uuid)s. Reason: %(error)s.\u0027),"},{"line_number":96,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":97,"context_line":"            raise exception.DracOperationError(error\u003dexc)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":100,"context_line":"        missing_keys \u003d valid_keys - set(properties)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_9d8d9bd5","line":97,"range":{"start_line":97,"start_character":28,"end_line":97,"end_character":46},"in_reply_to":"fa7ab95a_1dad0b9b","updated":"2016-09-02 09:46:24.000000000","message":"yeah, I think you are right!","commit_id":"380a0f76dd8a3dd48bcbad246aff662d23bd08fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9cf5ccfc518fe75aa419e3339bc48e0c38e35c1b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            LOG.error(_LE(\u0027DRAC driver failed to introspect node \u0027"},{"line_number":114,"context_line":"                          \u0027%(node_uuid)s. Reason: %(error)s.\u0027),"},{"line_number":115,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":116,"context_line":"            raise exception.DracOperationError(error\u003dexc)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        for nic in nics:"},{"line_number":119,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_3d964f4c","line":116,"range":{"start_line":116,"start_character":28,"end_line":116,"end_character":46},"updated":"2016-09-02 09:39:01.000000000","message":"ditto HardwareInspectionFailure","commit_id":"380a0f76dd8a3dd48bcbad246aff662d23bd08fe"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"32b9b70db9032ecfd750c5687f725d10fd2b58c9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            LOG.error(_LE(\u0027DRAC driver failed to introspect node \u0027"},{"line_number":114,"context_line":"                          \u0027%(node_uuid)s. Reason: %(error)s.\u0027),"},{"line_number":115,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":116,"context_line":"            raise exception.DracOperationError(error\u003dexc)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        for nic in nics:"},{"line_number":119,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_7d90d7ed","line":116,"range":{"start_line":116,"start_character":28,"end_line":116,"end_character":46},"in_reply_to":"fa7ab95a_3d964f4c","updated":"2016-09-02 09:46:24.000000000","message":"Done","commit_id":"380a0f76dd8a3dd48bcbad246aff662d23bd08fe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ee4d7bb5990d80a30cbf3be2e25c0624fe7c33a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            properties[\u0027memory_mb\u0027] \u003d sum("},{"line_number":78,"context_line":"                [memory.size_mb for memory in client.list_memory()])"},{"line_number":79,"context_line":"            cpus \u003d client.list_cpus()"},{"line_number":80,"context_line":"            properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":81,"context_line":"            properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_05004200","line":79,"updated":"2016-09-02 13:37:25.000000000","message":"I wonder if we need to check for an empty list here... just in case :)","commit_id":"da93b01f32e1b9d6efe435c16c9996c3cc45823a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1d2694ecf448a9cab4400f25f9c2b5cc6bd16ba5","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        LOG.info(_LI(\u0027Node %s successfully inspected.\u0027), node.uuid)"},{"line_number":134,"context_line":"        return states.MANAGEABLE"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _guess_root_disk(self, disks, min_size_required\u003d4 * units.Ki):"},{"line_number":137,"context_line":"        disks.sort(key\u003dlambda disk: disk.size_mb)"},{"line_number":138,"context_line":"        for disk in disks:"},{"line_number":139,"context_line":"            if disk.size_mb \u003e\u003d min_size_required:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_e40b67d3","line":136,"range":{"start_line":136,"start_character":38,"end_line":136,"end_character":55},"updated":"2016-09-02 11:55:28.000000000","message":"Might be worth mentioning in the docstring that it is actually megabytes, would be good to followup.","commit_id":"da93b01f32e1b9d6efe435c16c9996c3cc45823a"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"39708303fd4dda7d3c55d2badad34f79f3b4daa9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        LOG.info(_LI(\u0027Node %s successfully inspected.\u0027), node.uuid)"},{"line_number":134,"context_line":"        return states.MANAGEABLE"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _guess_root_disk(self, disks, min_size_required\u003d4 * units.Ki):"},{"line_number":137,"context_line":"        disks.sort(key\u003dlambda disk: disk.size_mb)"},{"line_number":138,"context_line":"        for disk in disks:"},{"line_number":139,"context_line":"            if disk.size_mb \u003e\u003d min_size_required:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_1f141842","line":136,"range":{"start_line":136,"start_character":38,"end_line":136,"end_character":55},"in_reply_to":"fa7ab95a_e40b67d3","updated":"2016-09-02 12:10:58.000000000","message":"ack, will do a follow-up","commit_id":"da93b01f32e1b9d6efe435c16c9996c3cc45823a"}],"ironic/tests/unit/drivers/modules/drac/test_inspect.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5c8087c0fefa3a5b92804642c4fcab0572a6bfb0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        mock_client.list_memory.return_value \u003d self.memory"},{"line_number":173,"context_line":"        mock_client.list_cpus.return_value \u003d self.cpus"},{"line_number":174,"context_line":"        mock_client.list_virtual_disks.side_effect \u003d ("},{"line_number":175,"context_line":"            exception.DracOperationError(\u0027boom\u0027))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":178,"context_line":"                                  shared\u003dTrue) as task:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_68f733d3","line":175,"updated":"2016-09-02 09:56:53.000000000","message":"BaseClientException ?","commit_id":"022949ba9eeabbd7aaa2a87fab6c98e10f83e7e4"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"1dd17a38cc5742b48f2da3828e86c35e2113966d","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        mock_client.list_memory.return_value \u003d self.memory"},{"line_number":173,"context_line":"        mock_client.list_cpus.return_value \u003d self.cpus"},{"line_number":174,"context_line":"        mock_client.list_virtual_disks.side_effect \u003d ("},{"line_number":175,"context_line":"            exception.DracOperationError(\u0027boom\u0027))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":178,"context_line":"                                  shared\u003dTrue) as task:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_63ccb489","line":175,"in_reply_to":"fa7ab95a_68f733d3","updated":"2016-09-02 10:08:15.000000000","message":"Done","commit_id":"022949ba9eeabbd7aaa2a87fab6c98e10f83e7e4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5c8087c0fefa3a5b92804642c4fcab0572a6bfb0","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":178,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":179,"context_line":"            self.assertRaises(exception.DracOperationError,"},{"line_number":180,"context_line":"                              task.driver.inspect.inspect_hardware, task)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_28844b09","line":179,"updated":"2016-09-02 09:56:53.000000000","message":"Check if it was converted to HardwareInspectionFailure","commit_id":"022949ba9eeabbd7aaa2a87fab6c98e10f83e7e4"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"1dd17a38cc5742b48f2da3828e86c35e2113966d","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":178,"context_line":"                                  shared\u003dTrue) as task:"},{"line_number":179,"context_line":"            self.assertRaises(exception.DracOperationError,"},{"line_number":180,"context_line":"                              task.driver.inspect.inspect_hardware, task)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_83c5385d","line":179,"in_reply_to":"fa7ab95a_28844b09","updated":"2016-09-02 10:08:15.000000000","message":"Done","commit_id":"022949ba9eeabbd7aaa2a87fab6c98e10f83e7e4"}],"ironic/tests/unit/drivers/modules/drac/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3ff683ce1d495ee5495924ffc59c1e7d4c7adcf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    if values is None:"},{"line_number":21,"context_line":"        values \u003d {}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    return collections.namedtuple(name, values.keys())(**values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_559bb517","line":23,"range":{"start_line":23,"start_character":40,"end_line":23,"end_character":53},"updated":"2016-08-30 13:24:11.000000000","message":"I think it\u0027s safe to use list(values), keys mean different things on Py2 and Py3","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"c70f80caaa77cd6accffb28fb290c20d308c8b5f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    if values is None:"},{"line_number":21,"context_line":"        values \u003d {}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    return collections.namedtuple(name, values.keys())(**values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_98a1f448","line":23,"range":{"start_line":23,"start_character":40,"end_line":23,"end_character":53},"in_reply_to":"fa7ab95a_559bb517","updated":"2016-08-30 14:11:25.000000000","message":"Done","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"}],"setup.cfg":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3ff683ce1d495ee5495924ffc59c1e7d4c7adcf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    pxe_seamicro \u003d ironic.drivers.pxe:PXEAndSeaMicroDriver"},{"line_number":78,"context_line":"    pxe_iboot \u003d ironic.drivers.pxe:PXEAndIBootDriver"},{"line_number":79,"context_line":"    pxe_ilo \u003d ironic.drivers.pxe:PXEAndIloDriver"},{"line_number":80,"context_line":"    pxe_drac \u003d ironic.drivers.drac:PXEDracDriver"},{"line_number":81,"context_line":"    pxe_oob_inspection_drac \u003d ironic.drivers.drac:PXEOOBInspectionDracDriver"},{"line_number":82,"context_line":"    pxe_snmp \u003d ironic.drivers.pxe:PXEAndSNMPDriver"},{"line_number":83,"context_line":"    pxe_irmc \u003d ironic.drivers.pxe:PXEAndIRMCDriver"},{"line_number":84,"context_line":"    pxe_amt \u003d ironic.drivers.pxe:PXEAndAMTDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"fa7ab95a_55501532","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":76},"updated":"2016-08-30 13:24:11.000000000","message":"it might potentially be breaking, but I think we should switch pxe_drac to its own inspection, while adding pxe_drac_inspector. it would be more in line with other inspection implementation.","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"c70f80caaa77cd6accffb28fb290c20d308c8b5f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    pxe_seamicro \u003d ironic.drivers.pxe:PXEAndSeaMicroDriver"},{"line_number":78,"context_line":"    pxe_iboot \u003d ironic.drivers.pxe:PXEAndIBootDriver"},{"line_number":79,"context_line":"    pxe_ilo \u003d ironic.drivers.pxe:PXEAndIloDriver"},{"line_number":80,"context_line":"    pxe_drac \u003d ironic.drivers.drac:PXEDracDriver"},{"line_number":81,"context_line":"    pxe_oob_inspection_drac \u003d ironic.drivers.drac:PXEOOBInspectionDracDriver"},{"line_number":82,"context_line":"    pxe_snmp \u003d ironic.drivers.pxe:PXEAndSNMPDriver"},{"line_number":83,"context_line":"    pxe_irmc \u003d ironic.drivers.pxe:PXEAndIRMCDriver"},{"line_number":84,"context_line":"    pxe_amt \u003d ironic.drivers.pxe:PXEAndAMTDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"fa7ab95a_b37a59bb","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":76},"in_reply_to":"fa7ab95a_55501532","updated":"2016-08-30 14:11:25.000000000","message":"Done","commit_id":"e8b2b4efdc448d6c5d34eeb303de3652f17ec17f"}]}
