)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1b3064513d30d0962dabb640f840a99d9348c8f1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"depends on : Ie6fe9e3dbff5de4d490c88325a70f7916863f2a5"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I96eaede777ca60c7ba2b83ea6968108910b62953"},{"line_number":22,"context_line":"Closes-Bug: #1596829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_5ac75345","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":13},"updated":"2016-07-18 09:03:24.000000000","message":"Depends-On:\n\nBut it shouldn\u0027t be used for patches within the same repository, this tag is for cross-project dependencies.","commit_id":"550e83ec19b412483c60c4eab5891c6d012f099f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"59f17b9837062b794fed56a2395cdc4f55fe37e1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"depends on : Ie6fe9e3dbff5de4d490c88325a70f7916863f2a5"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I96eaede777ca60c7ba2b83ea6968108910b62953"},{"line_number":22,"context_line":"Closes-Bug: #1596829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_fd2ba131","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":13},"in_reply_to":"dada55a8_5ac75345","updated":"2016-07-18 09:23:32.000000000","message":"Lucas, depends-on may be used for setting inter-project dependencies, it was confirmed by infra-team. It requires that both changes are not in merge conflict, otherwise they should be added to single chain.","commit_id":"550e83ec19b412483c60c4eab5891c6d012f099f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d8bcde66bb893449f16c99cfd8de0ee075fe519a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: Ie6fe9e3dbff5de4d490c88325a70f7916863f2a5"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I96eaede777ca60c7ba2b83ea6968108910b62953"},{"line_number":22,"context_line":"Closes-Bug: #1596829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_c04992d2","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":53},"updated":"2016-07-18 09:41:43.000000000","message":"Not required, this tag is only for cross-project dependency and not dependencies in the same repository.","commit_id":"56ea24ec88ca962fae2fceef23cf05b0a2bb86c8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"af9470982fb84c669cc01122c27b5927f2f36d8c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: Ie6fe9e3dbff5de4d490c88325a70f7916863f2a5"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I96eaede777ca60c7ba2b83ea6968108910b62953"},{"line_number":22,"context_line":"Closes-Bug: #1596829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_ab76ff3b","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":53},"in_reply_to":"dada55a8_c04992d2","updated":"2016-07-18 09:56:29.000000000","message":"+1 to Lucas suggestion, there is no need to setup dependency between current patch and https://review.openstack.org/#/c/343030\nBut depends-on may be used for inter-project relations. We were used this during multitenancy development. https://review.openstack.org/#/c/296432/","commit_id":"56ea24ec88ca962fae2fceef23cf05b0a2bb86c8"}],"ironic/conductor/manager.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bb33120e05d6133ae9d7f644a22f74698cd4a628","unresolved":false,"context_lines":[{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"            if (action \u003d\u003d states.VERBS[\u0027adopt\u0027] and"},{"line_number":1042,"context_line":"                    node.provision_state in (states.MANAGEABLE,"},{"line_number":1043,"context_line":"               states.ADOPTFAIL)):"},{"line_number":1044,"context_line":"                task.process_event("},{"line_number":1045,"context_line":"                    \u0027adopt\u0027,"},{"line_number":1046,"context_line":"                    callback\u003dself._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_8a586058","line":1043,"updated":"2016-07-15 17:53:09.000000000","message":"This is unrelated, and I think it\u0027s also a PEP8 error (though the original indentation was IMHO atrocious).","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"0b63e753fa78294678f8a6f69a7bc754e33c2c8f","unresolved":false,"context_lines":[{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"            if (action \u003d\u003d states.VERBS[\u0027adopt\u0027] and"},{"line_number":1042,"context_line":"                    node.provision_state in (states.MANAGEABLE,"},{"line_number":1043,"context_line":"               states.ADOPTFAIL)):"},{"line_number":1044,"context_line":"                task.process_event("},{"line_number":1045,"context_line":"                    \u0027adopt\u0027,"},{"line_number":1046,"context_line":"                    callback\u003dself._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_c5e1a9d2","line":1043,"in_reply_to":"fad55976_8a586058","updated":"2016-07-15 18:05:37.000000000","message":"yes, it is not related but it was giving \"-1\", so i have corrected it","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bb33120e05d6133ae9d7f644a22f74698cd4a628","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"                # Otherwise, indicate in that clean step, that cleaning"},{"line_number":1056,"context_line":"                # should be aborted after that step is done."},{"line_number":1057,"context_line":"                if (node.clean_step and not"},{"line_number":1058,"context_line":"                   node.clean_step.get(\u0027abortable\u0027)):"},{"line_number":1059,"context_line":"                    LOG.info(_LI(\u0027The current clean step \"%(clean_step)s\" for \u0027"},{"line_number":1060,"context_line":"                                 \u0027node %(node)s is not abortable. Adding a \u0027"},{"line_number":1061,"context_line":"                                 \u0027flag to abort the cleaning after the clean \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_0a3bd0ec","line":1058,"updated":"2016-07-15 17:53:09.000000000","message":"Unrelated change.","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"0b63e753fa78294678f8a6f69a7bc754e33c2c8f","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"                # Otherwise, indicate in that clean step, that cleaning"},{"line_number":1056,"context_line":"                # should be aborted after that step is done."},{"line_number":1057,"context_line":"                if (node.clean_step and not"},{"line_number":1058,"context_line":"                   node.clean_step.get(\u0027abortable\u0027)):"},{"line_number":1059,"context_line":"                    LOG.info(_LI(\u0027The current clean step \"%(clean_step)s\" for \u0027"},{"line_number":1060,"context_line":"                                 \u0027node %(node)s is not abortable. Adding a \u0027"},{"line_number":1061,"context_line":"                                 \u0027flag to abort the cleaning after the clean \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_65d1ddfb","line":1058,"in_reply_to":"fad55976_0a3bd0ec","updated":"2016-07-15 18:05:37.000000000","message":"ditto","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bb33120e05d6133ae9d7f644a22f74698cd4a628","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"                                         states.INSPECTING,"},{"line_number":1736,"context_line":"                                         states.MANAGEABLE]"},{"line_number":1737,"context_line":"                if (node.provision_state not in allowed_update_states"},{"line_number":1738,"context_line":"                   and not node.maintenance):"},{"line_number":1739,"context_line":"                    action \u003d _(\"Portgroup %(portgroup)s can not be associated \""},{"line_number":1740,"context_line":"                               \"to node %(node)s unless the node is in a \""},{"line_number":1741,"context_line":"                               \"%(allowed)s state or in maintenance mode.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_2a2214ba","line":1738,"updated":"2016-07-15 17:53:09.000000000","message":"Unrelated change.","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"0b63e753fa78294678f8a6f69a7bc754e33c2c8f","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"                                         states.INSPECTING,"},{"line_number":1736,"context_line":"                                         states.MANAGEABLE]"},{"line_number":1737,"context_line":"                if (node.provision_state not in allowed_update_states"},{"line_number":1738,"context_line":"                   and not node.maintenance):"},{"line_number":1739,"context_line":"                    action \u003d _(\"Portgroup %(portgroup)s can not be associated \""},{"line_number":1740,"context_line":"                               \"to node %(node)s unless the node is in a \""},{"line_number":1741,"context_line":"                               \"%(allowed)s state or in maintenance mode.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_45ce595b","line":1738,"in_reply_to":"fad55976_2a2214ba","updated":"2016-07-15 18:05:37.000000000","message":"ditto","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bb33120e05d6133ae9d7f644a22f74698cd4a628","unresolved":false,"context_lines":[{"line_number":708,"context_line":"        LOG.error(_LE(\"Error opening file: %(file)s\"),"},{"line_number":709,"context_line":"                  {\u0027file\u0027: image_location})"},{"line_number":710,"context_line":"        raise exception.ImageRefValidationFailed(image_href\u003dimage_location,"},{"line_number":711,"context_line":"                                                 reason\u003de)"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    if actual_checksum !\u003d expected_checksum:"},{"line_number":714,"context_line":"        msg \u003d (_(\u0027Error verifying image checksum. Image %(image)s failed to \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_653a7dcf","line":711,"updated":"2016-07-15 17:53:09.000000000","message":"Is this related? What effect does it have?","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"0b63e753fa78294678f8a6f69a7bc754e33c2c8f","unresolved":false,"context_lines":[{"line_number":708,"context_line":"        LOG.error(_LE(\"Error opening file: %(file)s\"),"},{"line_number":709,"context_line":"                  {\u0027file\u0027: image_location})"},{"line_number":710,"context_line":"        raise exception.ImageRefValidationFailed(image_href\u003dimage_location,"},{"line_number":711,"context_line":"                                                 reason\u003de)"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    if actual_checksum !\u003d expected_checksum:"},{"line_number":714,"context_line":"        msg \u003d (_(\u0027Error verifying image checksum. Image %(image)s failed to \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_05b901ea","line":711,"in_reply_to":"fad55976_653a7dcf","updated":"2016-07-15 18:05:37.000000000","message":"this change is related to the http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"}],"ironic/drivers/modules/seamicro.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"bb33120e05d6133ae9d7f644a22f74698cd4a628","unresolved":false,"context_lines":[{"line_number":564,"context_line":"            LOG.error(_LE(\"Seamicro set boot device failed for node \""},{"line_number":565,"context_line":"                          \"%(node)s with the following error: %(error)s\"),"},{"line_number":566,"context_line":"                      {\u0027node\u0027: task.node.uuid, \u0027error\u0027: ex})"},{"line_number":567,"context_line":"            raise exception.IronicException(ex)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def get_boot_device(self, task):"},{"line_number":570,"context_line":"        \"\"\"Get the current boot device for the task\u0027s node."}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_a53475de","line":567,"updated":"2016-07-15 17:53:09.000000000","message":"As above.","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"},{"author":{"_account_id":18941,"name":"Bharath kumar","email":"bharath.kumar3@hpe.com","username":"bharathshetty4"},"change_message_id":"0b63e753fa78294678f8a6f69a7bc754e33c2c8f","unresolved":false,"context_lines":[{"line_number":564,"context_line":"            LOG.error(_LE(\"Seamicro set boot device failed for node \""},{"line_number":565,"context_line":"                          \"%(node)s with the following error: %(error)s\"),"},{"line_number":566,"context_line":"                      {\u0027node\u0027: task.node.uuid, \u0027error\u0027: ex})"},{"line_number":567,"context_line":"            raise exception.IronicException(ex)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def get_boot_device(self, task):"},{"line_number":570,"context_line":"        \"\"\"Get the current boot device for the task\u0027s node."}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_25fec56b","line":567,"in_reply_to":"fad55976_a53475de","updated":"2016-07-15 18:05:37.000000000","message":"ditto","commit_id":"33a7573d1158911d72fa7b184bfbeabbfb7a42e3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"913512990b1c305459df1a0869b3113997c3f0c9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"from oslo_service import loopingcall"},{"line_number":26,"context_line":"from oslo_utils import importutils"},{"line_number":27,"context_line":"import six"},{"line_number":28,"context_line":"from six.moves.urllib import parse as urlparse"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from ironic.common import boot_devices"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_3aab7f8b","line":27,"updated":"2016-07-18 09:02:27.000000000","message":"The pep8 error is because now \"six\" has been imported but not used anywhere in this module.","commit_id":"550e83ec19b412483c60c4eab5891c6d012f099f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5deb9fa32a9151246b5125c2b207b0c7401701aa","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_service import loopingcall"},{"line_number":26,"context_line":"from oslo_utils import importutils"},{"line_number":27,"context_line":"import six"},{"line_number":28,"context_line":"from six.moves.urllib import parse as urlparse"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from ironic.common import boot_devices"},{"line_number":31,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_3de7f9e5","side":"PARENT","line":28,"updated":"2016-07-18 09:23:20.000000000","message":"Please add it back, it is used at L123 https://review.openstack.org/#/c/342924/4/ironic/drivers/modules/seamicro.py@123","commit_id":"81db30156d105cad55b78b2d35dc9ca2f2021df6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c49bf456d879f8d34eda6146e161a7e50a01c3db","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_service import loopingcall"},{"line_number":26,"context_line":"from oslo_utils import importutils"},{"line_number":27,"context_line":"import six"},{"line_number":28,"context_line":"from six.moves.urllib import parse as urlparse"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from ironic.common import boot_devices"},{"line_number":31,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a05f3e0d","side":"PARENT","line":28,"in_reply_to":"dada55a8_3de7f9e5","updated":"2016-07-18 09:31:02.000000000","message":"urlparse still used.\n\nOnly \"import six\" should be removed","commit_id":"81db30156d105cad55b78b2d35dc9ca2f2021df6"}]}