)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"4d9f947e67b3aece5eee6b07cef260665628af6d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added some tests of db migration methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added unit tests for modules with prefixes"},{"line_number":10,"context_line":"1e1d5ace7dc6, 3ae36a5f5131, 487deb87cc9d"},{"line_number":11,"context_line":"in ironic.db.sqlalchemy.alembic.versions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1757519f8eee6a4266a79a8e6b2f8a7d5f9de201"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_5920f89b","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":41},"updated":"2016-07-18 12:05:57.000000000","message":"nit:\ns/... for modules with prefixes .../... missing tests ... for migration scripts ...","commit_id":"77229ce16721886be18cf01aed87968814881c51"}],"ironic/tests/unit/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"4d9f947e67b3aece5eee6b07cef260665628af6d","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        data_conductor \u003d {\u0027id\u0027: 456, \u0027hostname\u0027: \u0027test_host\u0027}"},{"line_number":371,"context_line":"        conductors.insert().execute(data_conductor)"},{"line_number":372,"context_line":"        data_node \u003d {\u0027id\u0027: 456, \u0027conductor_affinity\u0027: data_conductor[\u0027id\u0027]}"},{"line_number":373,"context_line":"        nodes.insert().execute(data_node)"},{"line_number":374,"context_line":"        node \u003d nodes.select(nodes.c.id \u003d\u003d data_node[\u0027id\u0027]).execute().first()"},{"line_number":375,"context_line":"        self.assertEqual(data_conductor[\u0027id\u0027], node[\u0027conductor_affinity\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_395d44ea","line":372,"range":{"start_line":372,"start_character":27,"end_line":372,"end_character":30},"updated":"2016-07-18 12:05:57.000000000","message":"nit: node\u0027 id is the same as conductor one, would be nice to use doff values here","commit_id":"77229ce16721886be18cf01aed87968814881c51"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"166d1f7a5b39c37845a736f600d733df2ab157b7","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        data_conductor \u003d {\u0027id\u0027: 456, \u0027hostname\u0027: \u0027test_host\u0027}"},{"line_number":371,"context_line":"        conductors.insert().execute(data_conductor)"},{"line_number":372,"context_line":"        data_node \u003d {\u0027id\u0027: 456, \u0027conductor_affinity\u0027: data_conductor[\u0027id\u0027]}"},{"line_number":373,"context_line":"        nodes.insert().execute(data_node)"},{"line_number":374,"context_line":"        node \u003d nodes.select(nodes.c.id \u003d\u003d data_node[\u0027id\u0027]).execute().first()"},{"line_number":375,"context_line":"        self.assertEqual(data_conductor[\u0027id\u0027], node[\u0027conductor_affinity\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_0527fc64","line":372,"range":{"start_line":372,"start_character":27,"end_line":372,"end_character":30},"in_reply_to":"dada55a8_395d44ea","updated":"2016-07-19 10:34:15.000000000","message":"Please do not use hardcoded node id here, it\u0027s not needed. You can generate uuid here.","commit_id":"77229ce16721886be18cf01aed87968814881c51"}]}
