)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"6ad8199e3a171c86896109b066a83e56467f70ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-29 18:15:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance ilo drivers to do inband-inspection"},{"line_number":8,"context_line":"This fix allow ilo drivers to do inband inspection"},{"line_number":9,"context_line":"using ironic-inspector when `oob_inspection_only`"},{"line_number":10,"context_line":"config is set to False."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bacf61ea_6505cf12","line":7,"updated":"2016-07-30 10:47:31.000000000","message":"I guess there should be blank line between commit message header and commit message body.","commit_id":"9d4b1134de344b37f0c6525723c3093800f5ba1a"}],"ironic/conf/ilo.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"88ce0775f5185d378395cc75e53ea07c7a2f3405","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                help\u003d_(\u0027Set this to True if only out-of-band inspection is \u0027"},{"line_number":46,"context_line":"                       \u0027to be performed. If this is set to False, ironic \u0027"},{"line_number":47,"context_line":"                       \u0027will perform both out-of-band and in-band inspection \u0027"},{"line_number":48,"context_line":"                       \u0027for ilo drivers.\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027clean_priority_erase_devices\u0027,"},{"line_number":50,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":51,"context_line":"               deprecated_reason\u003d_(\u0027This configuration option is duplicated \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_eaa690bf","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":40},"updated":"2016-09-19 05:51:07.000000000","message":"Better to indicate that it uses Inspector.\n\u0027in-band inspection using Inspector for iLO drivers.\u0027","commit_id":"b1d39451b283175da17f87dcb016a82b1ea4d6f5"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"420bfa3cb25ea171c356bb0c9a8edea745e72978","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                help\u003d_(\u0027Set this to True if only out-of-band inspection is \u0027"},{"line_number":46,"context_line":"                       \u0027to be performed. If this is set to False, ironic \u0027"},{"line_number":47,"context_line":"                       \u0027will perform both out-of-band and in-band inspection \u0027"},{"line_number":48,"context_line":"                       \u0027for ilo drivers.\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027clean_priority_erase_devices\u0027,"},{"line_number":50,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":51,"context_line":"               deprecated_reason\u003d_(\u0027This configuration option is duplicated \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_327f0616","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":40},"in_reply_to":"7a8ec9b2_eaa690bf","updated":"2016-09-19 10:01:34.000000000","message":"Done","commit_id":"b1d39451b283175da17f87dcb016a82b1ea4d6f5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5674702b8f6b0463ee6efad8e38366c061b21b2e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                help\u003d_(\u0027Set this to True if only out-of-band inspection is \u0027"},{"line_number":46,"context_line":"                       \u0027to be performed. If this is set to False, ironic \u0027"},{"line_number":47,"context_line":"                       \u0027will perform both out-of-band and in-band inspection \u0027"},{"line_number":48,"context_line":"                       \u0027using Inspector for iLO drivers.\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027clean_priority_erase_devices\u0027,"},{"line_number":50,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":51,"context_line":"               deprecated_reason\u003d_(\u0027This configuration option is duplicated \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_5a9a98c6","line":48,"updated":"2016-10-18 18:07:36.000000000","message":"This is true only for pxe_ilo right now, please mention it here.","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0033600b182e36b99d852b5e8e79790dc386965","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                help\u003d_(\u0027Set this to True if only out-of-band inspection is \u0027"},{"line_number":46,"context_line":"                       \u0027to be performed. If this is set to False, ironic \u0027"},{"line_number":47,"context_line":"                       \u0027will perform both out-of-band and in-band inspection \u0027"},{"line_number":48,"context_line":"                       \u0027using Inspector for iLO drivers.\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027clean_priority_erase_devices\u0027,"},{"line_number":50,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":51,"context_line":"               deprecated_reason\u003d_(\u0027This configuration option is duplicated \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_2636d103","line":48,"in_reply_to":"fa6399be_5a9a98c6","updated":"2016-11-07 18:10:41.000000000","message":"Will enable the inband inspection for all three ilo drivers now. The change was done to get it merged in Newton.","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"595e53e6f8784e1a62a6a2c46dcfaffcd2fad705","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                help\u003d_(\u0027Set this to True if only out-of-band inspection is \u0027"},{"line_number":46,"context_line":"                       \u0027to be performed. If this is set to False, ironic \u0027"},{"line_number":47,"context_line":"                       \u0027will perform both out-of-band and in-band inspection \u0027"},{"line_number":48,"context_line":"                       \u0027using Inspector for \"pxe_ilo\" driver.\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027clean_priority_erase_devices\u0027,"},{"line_number":50,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":51,"context_line":"               deprecated_reason\u003d_(\u0027This configuration option is duplicated \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_a110725a","line":48,"range":{"start_line":48,"start_character":24,"end_line":48,"end_character":63},"updated":"2017-01-17 08:30:24.000000000","message":"ironic.conf.sample needs to be regenerated. Moreover I think this attribute being used by pxe_ilo driver can go into documentation instead of being here.","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"}],"ironic/conf/inspector.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"c319667a2551e76a617a2ac266250e33462ff2ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"               help\u003d_(\u0027ironic-inspector HTTP endpoint. If this is not set, \u0027"},{"line_number":24,"context_line":"                      \u0027the ironic-inspector client default \u0027"},{"line_number":25,"context_line":"                      \u0027(http://127.0.0.1:5050) will be used.\u0027)),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027inspector_callback_url\u0027,"},{"line_number":27,"context_line":"               help\u003d_(\u0027ironic-inspector call back endpoint. If this is not\u0027"},{"line_number":28,"context_line":"                      \u0027the ironic-inspector client default \u0027"},{"line_number":29,"context_line":"                      \u0027(http://127.0.0.1:5050) will be used.\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_c3b6b73c","line":26,"updated":"2016-07-18 11:24:37.000000000","message":"You need to regenerate etc/ironic/ironic.conf.sample - you can do this by running `tox -e genconfig`.","commit_id":"a9d8f7b1af517f21307c9da38f628df02f5dae60"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d5b892f42597f896eadd080df06bb3fe28e94af0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                      \u0027(http://127.0.0.1:5050) will be used.\u0027)),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027inspector_callback_url\u0027,"},{"line_number":27,"context_line":"               help\u003d_(\u0027ironic-inspector call back endpoint. If this is not\u0027"},{"line_number":28,"context_line":"                      \u0027the ironic-inspector client default \u0027"},{"line_number":29,"context_line":"                      \u0027(http://127.0.0.1:5050) will be used.\u0027)),"},{"line_number":30,"context_line":"    cfg.IntOpt(\u0027status_check_period\u0027, default\u003d60,"},{"line_number":31,"context_line":"               help\u003d_(\u0027period (in seconds) to check status of nodes \u0027"},{"line_number":32,"context_line":"                      \u0027on inspection\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_3611d3ad","line":29,"range":{"start_line":28,"start_character":24,"end_line":29,"end_character":59},"updated":"2016-07-18 11:50:43.000000000","message":"this should be derived from service_url, maybe you don\u0027t even need a separate option","commit_id":"a9d8f7b1af517f21307c9da38f628df02f5dae60"}],"ironic/drivers/modules/ilo/inspect.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d5b892f42597f896eadd080df06bb3fe28e94af0","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    \"\"\""},{"line_number":305,"context_line":"    # NOTE: we should strip \u0027/\u0027 from the end because this is intended for"},{"line_number":306,"context_line":"    # hardcoded ramdisk script"},{"line_number":307,"context_line":"    inspector_callback_url \u003d CONF.inspector.service_url"},{"line_number":308,"context_line":"    inspection_options \u003d {"},{"line_number":309,"context_line":"        \u0027inspector_callback_url\u0027: inspector_callback_url,"},{"line_number":310,"context_line":"        \u0027ipa-inspection-callback-url\u0027: inspector_callback_url,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_f6645b4a","line":307,"range":{"start_line":307,"start_character":4,"end_line":307,"end_character":55},"updated":"2016-07-18 11:50:43.000000000","message":"please make sure this ends in /v1/continue. the service_url may end with /v1, but definitely not with /continue","commit_id":"a9d8f7b1af517f21307c9da38f628df02f5dae60"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"88ce0775f5185d378395cc75e53ea07c7a2f3405","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    :param node: A single Node."},{"line_number":331,"context_line":"    :returns: A string representing the boot mode type. Defaults to \u0027bios\u0027."},{"line_number":332,"context_line":"    \"\"\""},{"line_number":333,"context_line":"    boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(node)"},{"line_number":334,"context_line":"    if boot_mode:"},{"line_number":335,"context_line":"        return boot_mode"},{"line_number":336,"context_line":"    return \"bios\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_8a8fcc73","line":333,"range":{"start_line":333,"start_character":16,"end_line":333,"end_character":59},"updated":"2016-09-19 05:51:07.000000000","message":"Would it be better to call only capability instead of using method that checks instance_info?\ndriver_utils.get_node_capability(node, \u0027boot_mode\u0027)","commit_id":"b1d39451b283175da17f87dcb016a82b1ea4d6f5"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"420bfa3cb25ea171c356bb0c9a8edea745e72978","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    :param node: A single Node."},{"line_number":331,"context_line":"    :returns: A string representing the boot mode type. Defaults to \u0027bios\u0027."},{"line_number":332,"context_line":"    \"\"\""},{"line_number":333,"context_line":"    boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(node)"},{"line_number":334,"context_line":"    if boot_mode:"},{"line_number":335,"context_line":"        return boot_mode"},{"line_number":336,"context_line":"    return \"bios\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_b2b876c9","line":333,"range":{"start_line":333,"start_character":16,"end_line":333,"end_character":59},"in_reply_to":"7a8ec9b2_8a8fcc73","updated":"2016-09-19 10:01:34.000000000","message":"Done","commit_id":"b1d39451b283175da17f87dcb016a82b1ea4d6f5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"558ff0576902dfed014b927164cb04b8224d743c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                        enabled\u003dCONF.inspector.enabled)"},{"line_number":268,"context_line":"    def _periodic_check_result(self, manager, context):"},{"line_number":269,"context_line":"        \"\"\"Periodic task checking results of inspection.\"\"\""},{"line_number":270,"context_line":"        filters \u003d {\u0027provision_state\u0027: states.INSPECTING}"},{"line_number":271,"context_line":"        node_iter \u003d manager.iter_nodes(filters\u003dfilters)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        for node_uuid, driver in node_iter:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_880b1f7d","line":270,"updated":"2016-09-19 23:21:56.000000000","message":"We do this for all nodes in this state witch can have different drivers, not only ilo?","commit_id":"d64992f9d04890f7911028c2e8cc88fd77afe52c"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"26ff89f38a09f7cab786c96b8099099b0319e46a","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                        enabled\u003dCONF.inspector.enabled)"},{"line_number":268,"context_line":"    def _periodic_check_result(self, manager, context):"},{"line_number":269,"context_line":"        \"\"\"Periodic task checking results of inspection.\"\"\""},{"line_number":270,"context_line":"        filters \u003d {\u0027provision_state\u0027: states.INSPECTING}"},{"line_number":271,"context_line":"        node_iter \u003d manager.iter_nodes(filters\u003dfilters)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        for node_uuid, driver in node_iter:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_6b2a34e9","line":270,"in_reply_to":"7a8ec9b2_880b1f7d","updated":"2016-09-20 10:36:46.000000000","message":"Yes, all the nodes with different drivers have the state check. Do you suggest to make this check as the generic inspection method for all the drivers?","commit_id":"d64992f9d04890f7911028c2e8cc88fd77afe52c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"558ff0576902dfed014b927164cb04b8224d743c","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":277,"context_line":"                                          shared\u003dTrue,"},{"line_number":278,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":279,"context_line":"                    inspector._check_status(task)"},{"line_number":280,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":281,"context_line":"                continue"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_6816d3a8","line":279,"range":{"start_line":279,"start_character":30,"end_line":279,"end_character":43},"updated":"2016-09-19 23:21:56.000000000","message":"We should avoid to use method marked as private.","commit_id":"d64992f9d04890f7911028c2e8cc88fd77afe52c"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"26ff89f38a09f7cab786c96b8099099b0319e46a","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":277,"context_line":"                                          shared\u003dTrue,"},{"line_number":278,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":279,"context_line":"                    inspector._check_status(task)"},{"line_number":280,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":281,"context_line":"                continue"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_53c0dfe0","line":279,"range":{"start_line":279,"start_character":30,"end_line":279,"end_character":43},"in_reply_to":"7a8ec9b2_6816d3a8","updated":"2016-09-20 10:36:46.000000000","message":"Done","commit_id":"d64992f9d04890f7911028c2e8cc88fd77afe52c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9b7a53f348665fff2b856e6024a9f12db3ae4564","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":277,"context_line":"                                          shared\u003dTrue,"},{"line_number":278,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":279,"context_line":"                    inspector._check_status(task)"},{"line_number":280,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":281,"context_line":"                continue"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_cbf8c1c7","line":279,"range":{"start_line":279,"start_character":30,"end_line":279,"end_character":43},"in_reply_to":"7a8ec9b2_6816d3a8","updated":"2016-09-19 23:41:37.000000000","message":"If we want use only oob inspection with ilo why inspector called here in any case?","commit_id":"d64992f9d04890f7911028c2e8cc88fd77afe52c"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"26ff89f38a09f7cab786c96b8099099b0319e46a","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":277,"context_line":"                                          shared\u003dTrue,"},{"line_number":278,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":279,"context_line":"                    inspector._check_status(task)"},{"line_number":280,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":281,"context_line":"                continue"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_f392cbf5","line":279,"range":{"start_line":279,"start_character":30,"end_line":279,"end_character":43},"in_reply_to":"7a8ec9b2_cbf8c1c7","updated":"2016-09-20 10:36:46.000000000","message":"It is not only for oob inspection. This change add support of inband inspection for pxe_ilo driver","commit_id":"d64992f9d04890f7911028c2e8cc88fd77afe52c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5674702b8f6b0463ee6efad8e38366c061b21b2e","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        \u0027boot_mode\u0027: _get_boot_mode(node),"},{"line_number":333,"context_line":"        \u0027ipa-debug\u0027: 1,"},{"line_number":334,"context_line":"        \u0027ipa-inspection-collectors\u0027: \u0027default\u0027,"},{"line_number":335,"context_line":"        # NOTE: The below entry is a temporary workaround for bug/1433812"},{"line_number":336,"context_line":"    }"},{"line_number":337,"context_line":"    root_device \u003d deploy_utils.parse_root_device_hints(node)"},{"line_number":338,"context_line":"    if root_device:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_7a783c90","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":73},"updated":"2016-10-18 18:07:36.000000000","message":"no entry below","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0033600b182e36b99d852b5e8e79790dc386965","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        \u0027boot_mode\u0027: _get_boot_mode(node),"},{"line_number":333,"context_line":"        \u0027ipa-debug\u0027: 1,"},{"line_number":334,"context_line":"        \u0027ipa-inspection-collectors\u0027: \u0027default\u0027,"},{"line_number":335,"context_line":"        # NOTE: The below entry is a temporary workaround for bug/1433812"},{"line_number":336,"context_line":"    }"},{"line_number":337,"context_line":"    root_device \u003d deploy_utils.parse_root_device_hints(node)"},{"line_number":338,"context_line":"    if root_device:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_c6db551a","line":335,"range":{"start_line":335,"start_character":8,"end_line":335,"end_character":73},"in_reply_to":"fa6399be_7a783c90","updated":"2016-11-07 18:10:41.000000000","message":"will remove the comment.","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5674702b8f6b0463ee6efad8e38366c061b21b2e","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    return inspection_options"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"def _get_boot_mode(node):"},{"line_number":344,"context_line":"    \"\"\"Gets the boot mode."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    :param node: A single Node."},{"line_number":347,"context_line":"    :returns: A string representing the boot mode type. Defaults to \u0027bios\u0027."},{"line_number":348,"context_line":"    \"\"\""},{"line_number":349,"context_line":"    boot_mode \u003d driver_utils.get_node_capability(node, \u0027boot_mode\u0027)"},{"line_number":350,"context_line":"    if boot_mode:"},{"line_number":351,"context_line":"        return boot_mode"},{"line_number":352,"context_line":"    return \"bios\""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_da122858","line":352,"range":{"start_line":343,"start_character":0,"end_line":352,"end_character":17},"updated":"2016-10-18 18:07:36.000000000","message":"Isn\u0027t it better to use deploy_utils.get_boot_mode_for_deploy here? It has much better coverage of possibilities.","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"50a59f70a4fe686e9353ebe1440fb9f5410d5d90","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    return inspection_options"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"def _get_boot_mode(node):"},{"line_number":344,"context_line":"    \"\"\"Gets the boot mode."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    :param node: A single Node."},{"line_number":347,"context_line":"    :returns: A string representing the boot mode type. Defaults to \u0027bios\u0027."},{"line_number":348,"context_line":"    \"\"\""},{"line_number":349,"context_line":"    boot_mode \u003d driver_utils.get_node_capability(node, \u0027boot_mode\u0027)"},{"line_number":350,"context_line":"    if boot_mode:"},{"line_number":351,"context_line":"        return boot_mode"},{"line_number":352,"context_line":"    return \"bios\""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a3c09a3_60307d02","line":352,"range":{"start_line":343,"start_character":0,"end_line":352,"end_character":17},"in_reply_to":"fa6399be_da122858","updated":"2017-01-16 09:25:57.000000000","message":"Done.","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0033600b182e36b99d852b5e8e79790dc386965","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    return inspection_options"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"def _get_boot_mode(node):"},{"line_number":344,"context_line":"    \"\"\"Gets the boot mode."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    :param node: A single Node."},{"line_number":347,"context_line":"    :returns: A string representing the boot mode type. Defaults to \u0027bios\u0027."},{"line_number":348,"context_line":"    \"\"\""},{"line_number":349,"context_line":"    boot_mode \u003d driver_utils.get_node_capability(node, \u0027boot_mode\u0027)"},{"line_number":350,"context_line":"    if boot_mode:"},{"line_number":351,"context_line":"        return boot_mode"},{"line_number":352,"context_line":"    return \"bios\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_86db1ded","line":352,"range":{"start_line":343,"start_character":0,"end_line":352,"end_character":17},"in_reply_to":"fa6399be_da122858","updated":"2016-11-07 18:10:41.000000000","message":"I will check and and see if that serves the purpose.","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ac1bc23edaffe2516f89fce311f1237c1c173b16","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    return capabilities"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"class IloInspect(base.InspectInterface):"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def get_properties(self):"},{"line_number":172,"context_line":"        return ilo_common.REQUIRED_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_db528866","line":169,"range":{"start_line":169,"start_character":17,"end_line":169,"end_character":38},"updated":"2017-01-24 06:50:55.000000000","message":"Just an idea. What if we change this to inherit from inspector.Inspector in which case we don\u0027t have to redefine periodic_check_result and also can leverage it\u0027s inspect_hardware.","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ac1bc23edaffe2516f89fce311f1237c1c173b16","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                  {\u0027properties\u0027: inspected_properties,"},{"line_number":268,"context_line":"                   \u0027node\u0027: task.node.uuid})"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.info(_LI(\"Node %s inspected.\"), task.node.uuid)"},{"line_number":271,"context_line":"        if power_turned_on:"},{"line_number":272,"context_line":"            conductor_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":273,"context_line":"            LOG.info(_LI(\"The node %s was powered on for inspection. \""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_bba69cab","line":270,"range":{"start_line":270,"start_character":8,"end_line":270,"end_character":59},"updated":"2017-01-24 06:50:55.000000000","message":"Need to be moved down once the inband inspection is complete.","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e26366ca4432eb2e2b339e0666a51cb11f863999","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                         \"Powered off the node as inspection completed.\"),"},{"line_number":275,"context_line":"                     task.node.uuid)"},{"line_number":276,"context_line":"        state \u003d states.MANAGEABLE"},{"line_number":277,"context_line":"        if \u0027pxe_ilo\u0027 in task.node.driver and not CONF.ilo.oob_inspection_only:"},{"line_number":278,"context_line":"            state \u003d _call_inspector(task)"},{"line_number":279,"context_line":"        return state"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_e22355a5","line":277,"range":{"start_line":277,"start_character":21,"end_line":277,"end_character":23},"updated":"2017-01-17 10:29:15.000000000","message":"\u003d\u003d","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ac1bc23edaffe2516f89fce311f1237c1c173b16","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                     task.node.uuid)"},{"line_number":276,"context_line":"        state \u003d states.MANAGEABLE"},{"line_number":277,"context_line":"        if \u0027pxe_ilo\u0027 in task.node.driver and not CONF.ilo.oob_inspection_only:"},{"line_number":278,"context_line":"            state \u003d _call_inspector(task)"},{"line_number":279,"context_line":"        return state"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    @periodics.periodic(spacing\u003dCONF.inspector.status_check_period,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_db87e8b2","line":278,"range":{"start_line":278,"start_character":20,"end_line":278,"end_character":35},"updated":"2017-01-24 06:50:55.000000000","message":"We don\u0027t require this method, if assuming we derive this class from inspector.Inspector, We just do \nsuper(IloInspect,self).inspect_hardware()","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ac1bc23edaffe2516f89fce311f1237c1c173b16","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    @periodics.periodic(spacing\u003dCONF.inspector.status_check_period,"},{"line_number":282,"context_line":"                        enabled\u003dCONF.inspector.enabled)"},{"line_number":283,"context_line":"    def _periodic_check_result(self, manager, context):"},{"line_number":284,"context_line":"        \"\"\"Periodic task checking results of inspection.\"\"\""},{"line_number":285,"context_line":"        filters \u003d {\u0027provision_state\u0027: states.INSPECTING}"},{"line_number":286,"context_line":"        node_iter \u003d manager.iter_nodes(filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_bbfcdcb8","line":283,"range":{"start_line":283,"start_character":4,"end_line":283,"end_character":55},"updated":"2017-01-24 06:50:55.000000000","message":"Do we really require to duplicate the functionality here. As I mentioned above, if we inherit the class from inspector.Inspector we get this function directly from the base class.\nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/base_manager.py#L269-L283 i can see that it iterates over all the members which also includes the base class methods as well.","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e26366ca4432eb2e2b339e0666a51cb11f863999","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            state \u003d _call_inspector(task)"},{"line_number":279,"context_line":"        return state"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    @periodics.periodic(spacing\u003dCONF.inspector.status_check_period,"},{"line_number":282,"context_line":"                        enabled\u003dCONF.inspector.enabled)"},{"line_number":283,"context_line":"    def _periodic_check_result(self, manager, context):"},{"line_number":284,"context_line":"        \"\"\"Periodic task checking results of inspection.\"\"\""},{"line_number":285,"context_line":"        filters \u003d {\u0027provision_state\u0027: states.INSPECTING}"},{"line_number":286,"context_line":"        node_iter \u003d manager.iter_nodes(filters\u003dfilters)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        for node_uuid, driver in node_iter:"},{"line_number":289,"context_line":"            try:"},{"line_number":290,"context_line":"                lock_purpose \u003d \u0027checking hardware inspection status\u0027"},{"line_number":291,"context_line":"                with task_manager.acquire(context, node_uuid,"},{"line_number":292,"context_line":"                                          shared\u003dTrue,"},{"line_number":293,"context_line":"                                          purpose\u003dlock_purpose) as task:"},{"line_number":294,"context_line":"                    inspector.check_status(task)"},{"line_number":295,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":296,"context_line":"                continue"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"def _call_inspector(task):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_8207f1c8","line":296,"range":{"start_line":281,"start_character":4,"end_line":296,"end_character":24},"updated":"2017-01-17 10:29:15.000000000","message":"Would be good to refactor this into some mixin class, both ilo inspect and inspector would inherit from, to avoid duplication.","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e26366ca4432eb2e2b339e0666a51cb11f863999","unresolved":false,"context_lines":[{"line_number":304,"context_line":"             could not be retrieved successfully."},{"line_number":305,"context_line":"    :returns: The resulting state of inspection."},{"line_number":306,"context_line":"    \"\"\""},{"line_number":307,"context_line":"    inspection_ramdisk_opts \u003d _build_ramdisk_options(task.node)"},{"line_number":308,"context_line":"    nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":309,"context_line":"    inspection_ramdisk_opts[\u0027BOOTIF\u0027] \u003d nic_mac"},{"line_number":310,"context_line":"    inspector_inspect \u003d inspector.Inspector()"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_429269f7","line":307,"range":{"start_line":307,"start_character":4,"end_line":307,"end_character":27},"updated":"2017-01-17 10:29:15.000000000","message":"This seems to be unused.","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ac1bc23edaffe2516f89fce311f1237c1c173b16","unresolved":false,"context_lines":[{"line_number":304,"context_line":"             could not be retrieved successfully."},{"line_number":305,"context_line":"    :returns: The resulting state of inspection."},{"line_number":306,"context_line":"    \"\"\""},{"line_number":307,"context_line":"    inspection_ramdisk_opts \u003d _build_ramdisk_options(task.node)"},{"line_number":308,"context_line":"    nic_mac \u003d deploy_utils.get_single_nic_with_vif_port_id(task)"},{"line_number":309,"context_line":"    inspection_ramdisk_opts[\u0027BOOTIF\u0027] \u003d nic_mac"},{"line_number":310,"context_line":"    inspector_inspect \u003d inspector.Inspector()"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a3905b3_fbf10496","line":307,"range":{"start_line":307,"start_character":4,"end_line":307,"end_character":27},"in_reply_to":"7a3c09a3_429269f7","updated":"2017-01-24 06:50:55.000000000","message":"++\nSo which essentially means we don\u0027t even require the definition of this method.","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e26366ca4432eb2e2b339e0666a51cb11f863999","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    \"\"\"Build the ramdisk config options for a node"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    This method builds the ramdisk options for a node,"},{"line_number":319,"context_line":"    given all the required parameters for doing iscsi deploy."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    :param node: a single Node."},{"line_number":322,"context_line":"    :returns: A dictionary of options to be passed to ramdisk for performing"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_02cdc165","line":319,"range":{"start_line":319,"start_character":47,"end_line":319,"end_character":60},"updated":"2017-01-17 10:29:15.000000000","message":"we don\u0027t seem to care if it\u0027s iscsi or not.","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e26366ca4432eb2e2b339e0666a51cb11f863999","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    given all the required parameters for doing iscsi deploy."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    :param node: a single Node."},{"line_number":322,"context_line":"    :returns: A dictionary of options to be passed to ramdisk for performing"},{"line_number":323,"context_line":"        the deploy."},{"line_number":324,"context_line":"    \"\"\""},{"line_number":325,"context_line":"    # NOTE: we should strip \u0027/\u0027 from the end because this is intended for"},{"line_number":326,"context_line":"    # hardcoded ramdisk script"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_020f8137","line":323,"range":{"start_line":322,"start_character":13,"end_line":323,"end_character":17},"updated":"2017-01-17 10:29:15.000000000","message":"I don\u0027t see how they are passed to ramdisk, should it be during _call_inspector?","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"595e53e6f8784e1a62a6a2c46dcfaffcd2fad705","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        \u0027inspector_callback_url\u0027: inspector_callback_url,"},{"line_number":330,"context_line":"        \u0027ipa-inspection-callback-url\u0027: inspector_callback_url,"},{"line_number":331,"context_line":"        \u0027ipa-driver-name\u0027: node.driver,"},{"line_number":332,"context_line":"        \u0027boot_mode\u0027: _get_boot_mode(node),"},{"line_number":333,"context_line":"        \u0027ipa-debug\u0027: 1,"},{"line_number":334,"context_line":"        \u0027ipa-inspection-collectors\u0027: \u0027default\u0027,"},{"line_number":335,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_1316fd4b","line":332,"range":{"start_line":332,"start_character":8,"end_line":332,"end_character":42},"updated":"2017-01-17 08:30:24.000000000","message":"May be you can avoid _get_boot_mode() by:\n\u0027boot_mode\u0027: (deploy_utils.get_boot_mode_for_deploy(node) or \u0027bios\u0027)","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e26366ca4432eb2e2b339e0666a51cb11f863999","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        \u0027inspector_callback_url\u0027: inspector_callback_url,"},{"line_number":330,"context_line":"        \u0027ipa-inspection-callback-url\u0027: inspector_callback_url,"},{"line_number":331,"context_line":"        \u0027ipa-driver-name\u0027: node.driver,"},{"line_number":332,"context_line":"        \u0027boot_mode\u0027: _get_boot_mode(node),"},{"line_number":333,"context_line":"        \u0027ipa-debug\u0027: 1,"},{"line_number":334,"context_line":"        \u0027ipa-inspection-collectors\u0027: \u0027default\u0027,"},{"line_number":335,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_2220fd47","line":332,"range":{"start_line":332,"start_character":8,"end_line":332,"end_character":42},"in_reply_to":"7a3c09a3_1316fd4b","updated":"2017-01-17 10:29:15.000000000","message":"++","commit_id":"9a098c50898b61dceb0b58149ce5b6213c449ca8"}],"ironic/drivers/modules/inspector.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"c319667a2551e76a617a2ac266250e33462ff2ac","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    node \u003d task.node"},{"line_number":164,"context_line":"    if node.provision_state !\u003d states.INSPECTING:"},{"line_number":165,"context_line":"        return"},{"line_number":166,"context_line":"    #if not isinstance(task.driver.inspect, Inspector):"},{"line_number":167,"context_line":"    #    return"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    LOG.debug(\u0027Calling to inspector to check status of node %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_432be730","line":166,"updated":"2016-07-18 11:24:37.000000000","message":"Please don\u0027t commit commented-out code.","commit_id":"a9d8f7b1af517f21307c9da38f628df02f5dae60"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"558ff0576902dfed014b927164cb04b8224d743c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                 node_uuid)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"def _check_status(task):"},{"line_number":160,"context_line":"    \"\"\"Check inspection status for node given by a task.\"\"\""},{"line_number":161,"context_line":"    node \u003d task.node"},{"line_number":162,"context_line":"    if node.provision_state !\u003d states.INSPECTING:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_6899731f","line":159,"range":{"start_line":159,"start_character":4,"end_line":159,"end_character":17},"updated":"2016-09-19 23:21:56.000000000","message":"We should also remove underscore from name.","commit_id":"d64992f9d04890f7911028c2e8cc88fd77afe52c"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"26ff89f38a09f7cab786c96b8099099b0319e46a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                 node_uuid)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"def _check_status(task):"},{"line_number":160,"context_line":"    \"\"\"Check inspection status for node given by a task.\"\"\""},{"line_number":161,"context_line":"    node \u003d task.node"},{"line_number":162,"context_line":"    if node.provision_state !\u003d states.INSPECTING:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_aad7dd21","line":159,"range":{"start_line":159,"start_character":4,"end_line":159,"end_character":17},"in_reply_to":"7a8ec9b2_6899731f","updated":"2016-09-20 10:36:46.000000000","message":"Done","commit_id":"d64992f9d04890f7911028c2e8cc88fd77afe52c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5674702b8f6b0463ee6efad8e38366c061b21b2e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    # Modified the condition so as to allow other drivers call"},{"line_number":167,"context_line":"    # inspector successfully even if task.driver.inspect is not"},{"line_number":168,"context_line":"    # the instance of inspector."},{"line_number":169,"context_line":"    if not task.driver.inspect:"},{"line_number":170,"context_line":"        return"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    LOG.debug(\u0027Calling to inspector to check status of node %s\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_7f4e6e97","line":169,"range":{"start_line":169,"start_character":28,"end_line":169,"end_character":29},"updated":"2016-10-18 18:07:36.000000000","message":"could you at least check that it is an instance of base.InspectInterface?","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"50a59f70a4fe686e9353ebe1440fb9f5410d5d90","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    # Modified the condition so as to allow other drivers call"},{"line_number":167,"context_line":"    # inspector successfully even if task.driver.inspect is not"},{"line_number":168,"context_line":"    # the instance of inspector."},{"line_number":169,"context_line":"    if not task.driver.inspect:"},{"line_number":170,"context_line":"        return"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    LOG.debug(\u0027Calling to inspector to check status of node %s\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_74303c02","line":169,"range":{"start_line":169,"start_character":28,"end_line":169,"end_character":29},"in_reply_to":"9a629dbe_66ec49c8","updated":"2017-01-16 09:25:57.000000000","message":"I dont think thats required as whomsoever calling check_status() would have done validation in their inspect interface.","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a0033600b182e36b99d852b5e8e79790dc386965","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    # Modified the condition so as to allow other drivers call"},{"line_number":167,"context_line":"    # inspector successfully even if task.driver.inspect is not"},{"line_number":168,"context_line":"    # the instance of inspector."},{"line_number":169,"context_line":"    if not task.driver.inspect:"},{"line_number":170,"context_line":"        return"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    LOG.debug(\u0027Calling to inspector to check status of node %s\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_66ec49c8","line":169,"range":{"start_line":169,"start_character":28,"end_line":169,"end_character":29},"in_reply_to":"fa6399be_7f4e6e97","updated":"2016-11-07 18:10:41.000000000","message":"Yes, that can be checked. Let me try if that way inspection works.","commit_id":"467c2f736b1542f1f458d1415019a9a49a43f8b4"}]}
